When upgrading libvirt packages, there's no strict ordering for the
installation or removal of the individual libvirt sub packages. Thus
libvirt-daemon may be upgraded (and its %postun scriptlet) started
before all sub packages with driver libraries are upgraded. When
libvirt-daemon's %postun scrip
On Mon, Oct 30, 2017 at 10:02:35AM +0100, Daniel P. Berrange wrote:
> There is no reason for the libvirt-dbus daemon to require root privileges. All
> it actually needs is ability to connect to libvirtd, which can be achieved by
> dropping in a polkit configuration file
s/file/file./
> Now a libv
On Tue, Oct 31, 2017 at 07:04:35AM +0100, Michal Privoznik wrote:
> On 10/30/2017 11:12 PM, Jim Fehlig wrote:
> > On 10/30/2017 03:31 PM, Jim Fehlig wrote:
> >> On 10/03/2017 07:53 AM, Daniel P. Berrange wrote:
> >>> On Tue, Oct 03, 2017 at 02:11:44PM +0200, Martin Kletzander wrote:
> On Tue,
On 10/31/2017 03:31 PM, Andrea Bolognani wrote:
> Andrea Bolognani (2):
> Remove backslash alignment attempts
> cfg.mk: Prohibit backspace alignment attempts
I like the idea. It's always pain if I'm adding new argument to a macro.
Not to mention that since the Makefile.am files use tabs instea
Andrea Bolognani (2):
Remove backslash alignment attempts
cfg.mk: Prohibit backspace alignment attempts
Makefile.am | 10 +-
cfg.mk| 830
config-post.h |2 +-
daemon/Makefile.
Now that our codebase is clean, we can add a syntax-check rule
to ensure it will remain so.
Signed-off-by: Andrea Bolognani
---
cfg.mk | 6 ++
1 file changed, 6 insertions(+)
diff --git a/cfg.mk b/cfg.mk
index d5db05f68..5321a52b7 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -1037,6 +1037,12 @@ sc_p
Right-aligning backslashes when defining macros or using complex
commands in Makefiles looks cute, but as soon as any changes is
required to the code you end up with either distractingly broken
alignment or unnecessarily big diffs where most of the changes
are just pushing all backslashes a few cha
On 10/31/2017 02:43 PM, Peter Krempa wrote:
> On Tue, Oct 31, 2017 at 14:10:25 +0100, Michal Privoznik wrote:
>> This is supposed to go on the top of:
>>
>> https://www.redhat.com/archives/libvir-list/2017-October/msg01367.html
>>
>> Before digging any deeper to this hole I want to make sure that
>
On Tue, Oct 31, 2017 at 14:10:25 +0100, Michal Privoznik wrote:
> This is supposed to go on the top of:
>
> https://www.redhat.com/archives/libvir-list/2017-October/msg01367.html
>
> Before digging any deeper to this hole I want to make sure that
> this approach is acceptable.
>
> So how does th
On Tue, Oct 31, 2017 at 16:15:51 +0300, Nikolay Shirokovskiy wrote:
>
>
> On 31.10.2017 15:57, Peter Krempa wrote:
> > On Tue, Oct 31, 2017 at 13:48:01 +0100, Peter Krempa wrote:
> >> On Tue, Oct 31, 2017 at 15:06:36 +0300, Nikolay Shirokovskiy wrote:
> >>> If block job is completed with error qe
On 31.10.2017 15:57, Peter Krempa wrote:
> On Tue, Oct 31, 2017 at 13:48:01 +0100, Peter Krempa wrote:
>> On Tue, Oct 31, 2017 at 15:06:36 +0300, Nikolay Shirokovskiy wrote:
>>> If block job is completed with error qemu additionally provides error
>>> message.
>>> This patch introduces new event
Signed-off-by: Michal Privoznik
---
tools/virsh-domain-monitor.c | 30 +++
tools/virsh-domain.c | 182 ++-
tools/virsh-snapshot.c | 24 +++---
tools/virsh.c| 43 ++
tools/virsh.h| 8 +-
5 files
The idea is that .completer for vshCmdOptDef would be called if
the last token on the input is a cmd opt. For instance:
virsh # start --domain
However, with current code that's not happening.
Signed-off-by: Michal Privoznik
---
tools/vsh.c | 45 ++---
1
This is supposed to go on the top of:
https://www.redhat.com/archives/libvir-list/2017-October/msg01367.html
Before digging any deeper to this hole I want to make sure that
this approach is acceptable.
So how does this work. The idea is to have handful of generic
functions that fetch names (so c
On Tue, Oct 31, 2017 at 13:48:01 +0100, Peter Krempa wrote:
> On Tue, Oct 31, 2017 at 15:06:36 +0300, Nikolay Shirokovskiy wrote:
> > If block job is completed with error qemu additionally provides error
> > message.
> > This patch introduces new event VIR_DOMAIN_EVENT_ID_BLOCK_JOB_3 to pass
> >
On Tue, Oct 31, 2017 at 13:37:55 +0100, Andrea Bolognani wrote:
> On Tue, 2017-10-31 at 12:39 +0100, Michal Privoznik wrote:
> > @@ -781,7 +781,7 @@ static const vshCmdOptDef opts_attach_interface[] = {
> > * 'average,peak,burst,floor', in which peak and burst are optional,
> > * thus 'average,
On Tue, Oct 31, 2017 at 15:06:36 +0300, Nikolay Shirokovskiy wrote:
> If block job is completed with error qemu additionally provides error message.
> This patch introduces new event VIR_DOMAIN_EVENT_ID_BLOCK_JOB_3 to pass error
> message to client.
>
> ---
>
> The patch is applied on top of [1]
On Tue, 2017-10-31 at 12:39 +0100, Michal Privoznik wrote:
> @@ -781,7 +781,7 @@ static const vshCmdOptDef opts_attach_interface[] = {
> * 'average,peak,burst,floor', in which peak and burst are optional,
> * thus 'average,,burst' and 'average,peak' are also legal. */
>
> -#define VIRSH_PARSE
If block job is completed with error qemu additionally provides error message.
This patch introduces new event VIR_DOMAIN_EVENT_ID_BLOCK_JOB_3 to pass error
message to client.
---
The patch is applied on top of [1] patch series (not yet pushed though). Looks
like this patch consists of too much b
On Tue, Oct 31, 2017 at 12:39:40 +0100, Michal Privoznik wrote:
> In some cases there's dangling backward slash at the end of multi
> line macros. While technically the code works, it will stop if
> some empty lines are removed.
>
> Signed-off-by: Michal Privoznik
> ---
> tools/virsh-domain-moni
In some cases there's dangling backward slash at the end of multi
line macros. While technically the code works, it will stop if
some empty lines are removed.
Signed-off-by: Michal Privoznik
---
tools/virsh-domain-monitor.c | 2 +-
tools/virsh-domain.c | 20 ++--
21 matches
Mail list logo
