Re: [libvirt] [PATCH] qemu_agent: report VIR_ERR_AGENT_UNSYNCED if guest_sync failed.

On 30.11.2017 06:08, Chen Hanxiao wrote: > From: Chen Hanxiao > > Commit 5e5019bf removed this kind of error. > > But we've already protected race condition by qemuDomainObjEnterAgent, > it was very unlikely to revieve a sync from other calls. > For call from

[libvirt] [PATCH] qemu_agent: report VIR_ERR_AGENT_UNSYNCED if guest_sync failed.

From: Chen Hanxiao Commit 5e5019bf removed this kind of error. But we've already protected race condition by qemuDomainObjEnterAgent, it was very unlikely to revieve a sync from other calls. For call from virDomain*, it's better to show this error if we really got a

Re: [libvirt] [PATCH 3/3] qemu: domain: Fix backing store terminator for non-backing local files

On 11/24/2017 07:21 AM, Peter Krempa wrote: > Raw local files do not pass through the backing store detector and thus > the code did not allocate the required backing store terminator for > them. Previously the terminating element would be formatted into the XML > since the default values used

Re: [libvirt] [PATCH 2/3] qemu: process: Move handling of non-backing files into qemuDomainDetermineDiskChain

On 11/24/2017 07:21 AM, Peter Krempa wrote: > Until now we would skip loading of the backing chain for files which > don't support backing chains only when starting up the VM. Move the > check from qemuProcessPrepareHostStorage with some adaptations so that's > always applied. > --- >

Re: [libvirt] [PATCH 1/3] qemu: domain: Refactor control flow in qemuDomainDetermineDiskChain

On 11/24/2017 07:21 AM, Peter Krempa wrote: > Split out clearing of the backing chain prior to other code since it > will be required later and optimize few layers of nested conditions and > loops. > --- > src/qemu/qemu_domain.c | 37 + > 1 file changed, 17

[libvirt] PATCH add q35 support ide

hello everyone: In q35 motherboard use ide, Currently, the qemu has supported q35 Motherboard support ide bus diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index cc7596b..2dbade8 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -7188,6 +7188,7 @@ bool

Re: [libvirt] [PATCH] Remove non-existant 'wiremode' attribute

On 11/29/2017 11:01 AM, Daniel P. Berrange wrote: The 'wiremode' attribute exists in a couple of Xen XML files, but no code has ever parsed that value. It was later added to the RNG schema too, again despite there not being any code which parses it. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] Misc XML schema fixes for libxl

On 11/29/2017 10:44 AM, Daniel P. Berrange wrote: The libxlxml2domconfigdata directory was not covered in the RNG schema tests. This hid a few bugs in both the libxl XML files and the RNG schema itself. Signed-off-by: Daniel P. Berrange --- docs/schemas/domaincommon.rng

[libvirt] [PATCH] Remove non-existant 'wiremode' attribute

The 'wiremode' attribute exists in a couple of Xen XML files, but no code has ever parsed that value. It was later added to the RNG schema too, again despite there not being any code which parses it. Signed-off-by: Daniel P. Berrange --- docs/schemas/domaincommon.rng

[libvirt] [PATCH] Misc XML schema fixes for libxl

The libxlxml2domconfigdata directory was not covered in the RNG schema tests. This hid a few bugs in both the libxl XML files and the RNG schema itself. Signed-off-by: Daniel P. Berrange --- docs/schemas/domaincommon.rng | 3 ++-

Re: [libvirt] [PATCH] audit: Log only an info message if audit_level < 2 and audit is not supported

On Mon, Nov 27, 2017 at 07:02 PM +0100, Marc Hartmayer wrote: > Replace the error message during startup of libvirtd with an info > message if audit_level < 2 and audit is not supported by the > kernel. Audit is not supported by the current kernel if the kernel >

Re: [libvirt] [libvirt-python][PATCH] Don't hardcode interpreter path

On Wed, Nov 29, 2017 at 06:12:48PM +0100, Cédric Bosdonnat wrote: > This is particularly useful on operating systems that don't ship > Python as part of the base system (eg. FreeBSD) while still working > just as well as it did before on Linux. > --- > examples/event-test.py | 2 +- >

[libvirt] [libvirt-python][PATCH] Don't hardcode interpreter path

This is particularly useful on operating systems that don't ship Python as part of the base system (eg. FreeBSD) while still working just as well as it did before on Linux. --- examples/event-test.py | 2 +- generator.py | 2 +- sanitytest.py | 2 +- setup.py | 2

Re: [libvirt] [PATCH] spec: don't package product dirs

On Wed, Nov 15, 2017 at 12:39:27 +0100, Martin Kletzander wrote: > On Tue, Nov 14, 2017 at 06:12:56PM +0300, Nikolay Shirokovskiy wrote: > > > > > >On 13.11.2017 11:35, Martin Kletzander wrote: > >> On Thu, Sep 28, 2017 at 09:35:45AM +0300, Nikolay Shirokovskiy wrote: > >>> Directories

Re: [libvirt] [PATCH] qemu-capabilities: Adjust function header comments of virQEMUCapsInitCPUModel*

On Mon, Nov 27, 2017 at 13:12:17 +0100, Boris Fiuczynski wrote: > Adjust function descriptions of virQEMUCapsInitCPUModelS390 and > virQEMUCapsInitCPUModel to the changes introduced with > commitID 74fc32a955. > > Signed-off-by: Boris Fiuczynski > Reviewed-by: Marc

[libvirt] Entering freeze for libvirt-3.10.0

As planned yesterday (but a bit late) I tagged Release Candidate 1 in git and pushed the signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ Seems to work fine in my limited testing, but please give them a try especially for portability accross arches and platforms !

Re: [libvirt] [PATCH 0/2] spec: Make the build reproducible

On Wednesday, 29 November 2017 14:58:31 CET Jiri Denemark wrote: > Jiri Denemark (2): > spec: Turn on verbose build > spec: Make the build reproducible > > libvirt.spec.in | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) The whole series: Reviewed-by: Pino Toscano

Re: [libvirt] [PATCH] qemu: forbid user aliases for implicit pci-root controllers

On 11/29/2017 03:15 PM, Jiri Denemark wrote: > On Wed, Nov 29, 2017 at 11:57:30 +0100, Michal Privoznik wrote: >> On 11/28/2017 02:51 PM, Ján Tomko wrote: >>> For implicit controllers, we do not format user aliases on the command >>> line so we provide a translation between the user alias and the

[libvirt] [PATCH 3/4] virQEMUCapsHasPCIMultiBus: use def->os.arch

We do not fill out qemuCaps->arch when parsing status XML. Use def->os.arch like we do for PPC. This fixes hotplug after daemon restart for domains that use a user alias for the implicit pci-root on x86. https://bugzilla.redhat.com/show_bug.cgi?id=1518148 --- src/qemu/qemu_capabilities.c

[libvirt] [PATCH 4/4] virQEMUCapsHasPCIMultiBus: assume true if we have no version information

In status XML, we do not store the QEMU version information, we only format all the capabilities. We dropped QEMU_CAPS_PCI_MULTIBUS in commit 5b783379 which was released in libvirt 3.2.0. Therefore the only way of telling if the already running domain at the time of daemon restart has been

[libvirt] [PATCH 0/4] Fix hotplug after daemon restart

The logic in virQEMUCapsHasPCIMultiBus cannot be reasonably fixed for already running domains, since we dropped the MULTIBUS capability, so only resort to calling it if the domain is using user aliases. That way only hotplug on PPC machines other than pseries with QEMU < 2.0 (possibly older) that

[libvirt] [PATCH 2/4] qemu: prefer the PCI bus alias from status XML

For some corner cases, virQEMUCapsHasPCIMultiBus depends on the QEMU version, which is by desing not stored in the status XML and therefore it cannot be fixed for all existing running domains. Prefer the controller alias read from the status XML when formatting PCI addresses and only fall back to

[libvirt] [PATCH 1/4] Move USER_ALIAS_PREFIX to the header file

Allow other parts of code to decide whether the alias is user-specified or not. --- src/conf/domain_conf.c | 3 +-- src/conf/domain_conf.h | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b31917dad..41c94ed18 100644 ---

Re: [libvirt] [PATCH] qemu: forbid user aliases for implicit pci-root controllers

On Wed, Nov 29, 2017 at 11:57:30 +0100, Michal Privoznik wrote: > On 11/28/2017 02:51 PM, Ján Tomko wrote: > > For implicit controllers, we do not format user aliases on the command > > line so we provide a translation between the user alias and the qemu > > alias. > > > > However for pci-root

[libvirt] [PATCH 2/2] spec: Make the build reproducible

If the spec file applies a patch which touches any file in the API XMLs dependency tree, we need to regenerate the XMLs and consequently recreate hvsupport.html. The file will contain a time stamp in a comment which means it will be different every time the package is built. The commit a54c9622860

[libvirt] [PATCH 1/2] spec: Turn on verbose build

When building a package in a build system, such as koji or cbs, logs are the only thing which can be used to diagnose failures. Make them verbose since human friendly output of V=0 build doesn't really help when a build fails. Signed-off-by: Jiri Denemark ---

[libvirt] [PATCH 0/2] spec: Make the build reproducible

Jiri Denemark (2): spec: Turn on verbose build spec: Make the build reproducible libvirt.spec.in | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 2.15.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: forbid user aliases for implicit pci-root controllers

On 11/28/2017 02:51 PM, Ján Tomko wrote: > For implicit controllers, we do not format user aliases on the command > line so we provide a translation between the user alias and the qemu > alias. > > However for pci-root controllers, the logic determining whether to use > 'pci' or 'pci.0' depends

Re: [libvirt] [PATCH 0/6] Remove some repetitive code from qemuDomainNamespace* functions

On 11/24/2017 06:54 PM, Ján Tomko wrote: > Ján Tomko (6): > qemuDomainNamespaceTeardownHostdev: rename path to paths > Introduce qemuDomainNamespaceMknodPaths > Introduce qemuDomainNamespaceMknodPath > Introduce qemuDomainNamespaceUnlinkPaths > Introduce qemuDomainNamespaceUnlinkPath >