Re: [libvirt] [PATCH 0/3] Adjust some formatting for numa distance code and resolve a memory leak

ping? Patch 3 is a memory leak bugfix for code added in this release... Tks, John On 11/24/2017 12:18 PM, John Ferlan wrote: > While reviewing the recent distance adjustments for Michal, I noted a > couple of minor formatting things as well as a memory leak when removing > the distances. > >

[libvirt] [PATCH] apparmor: allow qemu abstraction to read /proc/pid/cmdline

Noticed the following denial in audit.log when shutting down an apparmor confined domain type=AVC msg=audit(1512002299.742:131): apparmor="DENIED" operation="open" profile="libvirt-66154842-e926-4f92-92f0-1c1bf61dd1ff" name="/proc/1475/cmdline" pid=2958 comm="qemu-system-x86" requested_mask="r"

Re: [libvirt] [PATCH v3 REBASE v2 2/2] qemu: report drive mirror errors on migration

On Fri, Oct 27, 2017 at 15:37:23 +0300, Nikolay Shirokovskiy wrote: > --- > src/qemu/qemu_blockjob.c | 14 +--- > src/qemu/qemu_blockjob.h | 3 ++- > src/qemu/qemu_driver.c| 4 ++-- > src/qemu/qemu_migration.c | 55 > +-- > 4 files

Re: [libvirt] [PATCH] conf: fix migratable XML for graphics if socket is generated based on config

On Thu, Nov 30, 2017 at 17:14:34 +0100, Pavel Hrdina wrote: > The graphics code is complex and there are a lot of exceptions and > backward compatible combinations. One of them is the possibility > to configure "spice_auto_unix_socket" in qemu.conf which will convert > all spice graphics with

[libvirt] [PATCH] conf: fix migratable XML for graphics if socket is generated based on config

The graphics code is complex and there are a lot of exceptions and backward compatible combinations. One of them is the possibility to configure "spice_auto_unix_socket" in qemu.conf which will convert all spice graphics with listen type "address" without any address specified to listen type

Re: [libvirt] Entering freeze for libvirt-3.10.0

On Wed, Nov 29, 2017 at 17:27:40 +0100, Daniel Veillard wrote: > As planned yesterday (but a bit late) I tagged Release Candidate 1 > in git and pushed the signed tarball and rpms to the usual place: > > ftp://libvirt.org/libvirt/ > > > Seems to work fine in my limited testing, but please

Re: [libvirt] [PATCH 4/4] virQEMUCapsHasPCIMultiBus: assume true if we have no version information

On Thu, Nov 30, 2017 at 10:10:26AM -0500, John Ferlan wrote: On 11/29/2017 09:58 AM, Ján Tomko wrote: In status XML, we do not store the QEMU version information, we only format all the capabilities. We dropped QEMU_CAPS_PCI_MULTIBUS in commit 5b783379 which was released in libvirt 3.2.0.

Re: [libvirt] [PATCH 4/4] virQEMUCapsHasPCIMultiBus: assume true if we have no version information

On 11/29/2017 09:58 AM, Ján Tomko wrote: > In status XML, we do not store the QEMU version information, we only > format all the capabilities. We dropped QEMU_CAPS_PCI_MULTIBUS > in commit 5b783379 which was released in libvirt 3.2.0. > > Therefore the only way of telling if the already running

Re: [libvirt] [PATCH 2/4] qemu: prefer the PCI bus alias from status XML

On 11/29/2017 09:58 AM, Ján Tomko wrote: > For some corner cases, virQEMUCapsHasPCIMultiBus depends on the QEMU > version, which is by desing not stored in the status XML and therefore design > it cannot be fixed for all existing running domains. > > Prefer the controller alias read from the

Re: [libvirt] [PATCH 1/4] Move USER_ALIAS_PREFIX to the header file

On 11/29/2017 09:58 AM, Ján Tomko wrote: > Allow other parts of code to decide whether the alias is user-specified > or not. > --- > src/conf/domain_conf.c | 3 +-- > src/conf/domain_conf.h | 2 ++ > 2 files changed, 3 insertions(+), 2 deletions(-) > Why not a convenience API instead? e.g.

Re: [libvirt] [PATCH 3/3] qemu: domain: Fix backing store terminator for non-backing local files

On Wed, Nov 29, 2017 at 21:29:32 -0500, John Ferlan wrote: > > > On 11/24/2017 07:21 AM, Peter Krempa wrote: > > Raw local files do not pass through the backing store detector and thus > > the code did not allocate the required backing store terminator for > > them. Previously the terminating

Re: [libvirt] [PATCH] qemu: forbid user aliases for implicit pci-root controllers

On 11/30/2017 02:46 PM, Ján Tomko wrote: > On Wed, Nov 29, 2017 at 04:27:16PM +0100, Michal Privoznik wrote: >> On 11/29/2017 03:15 PM, Jiri Denemark wrote: >>> On Wed, Nov 29, 2017 at 11:57:30 +0100, Michal Privoznik wrote: On 11/28/2017 02:51 PM, Ján Tomko wrote: > For implicit

Re: [libvirt] [PATCH 4/4] virQEMUCapsHasPCIMultiBus: assume true if we have no version information

On Wed, Nov 29, 2017 at 03:58:57PM +0100, Ján Tomko wrote: > In status XML, we do not store the QEMU version information, we only > format all the capabilities. We dropped QEMU_CAPS_PCI_MULTIBUS > in commit 5b783379 which was released in libvirt 3.2.0. > > Therefore the only way of telling if the

Re: [libvirt] [PATCH] qemu: forbid user aliases for implicit pci-root controllers

On Wed, Nov 29, 2017 at 04:27:16PM +0100, Michal Privoznik wrote: On 11/29/2017 03:15 PM, Jiri Denemark wrote: On Wed, Nov 29, 2017 at 11:57:30 +0100, Michal Privoznik wrote: On 11/28/2017 02:51 PM, Ján Tomko wrote: For implicit controllers, we do not format user aliases on the command line

[libvirt] [PATCH jenkins-ci] Make args to 'go test' configurable

Each module has its own set of tags it may wish to pass to 'go test', so set it based on an env variable Signed-off-by: Daniel P. Berrange --- jobs/go.yaml | 2 +- projects/libvirt-go-xml.yaml | 2 ++ projects/libvirt-go.yaml | 2 ++ 3 files changed, 5

Re: [libvirt] [PATCH 1/3] qemu: domain: Refactor control flow in qemuDomainDetermineDiskChain

On Wed, Nov 29, 2017 at 21:25:08 -0500, John Ferlan wrote: > > > On 11/24/2017 07:21 AM, Peter Krempa wrote: > > Split out clearing of the backing chain prior to other code since it > > will be required later and optimize few layers of nested conditions and > > loops. > > --- > >

Re: [libvirt] [PATCH 2/3] qemu: process: Move handling of non-backing files into qemuDomainDetermineDiskChain

On Wed, Nov 29, 2017 at 21:25:45 -0500, John Ferlan wrote: > > > On 11/24/2017 07:21 AM, Peter Krempa wrote: > > Until now we would skip loading of the backing chain for files which > > don't support backing chains only when starting up the VM. Move the > > check from

Re: [libvirt] [PATCH] qemu_agent: report VIR_ERR_AGENT_UNSYNCED if guest_sync failed.

On 30.11.2017 13:37, Chen Hanxiao wrote: > > At 2017-11-30 14:11:36, "Nikolay Shirokovskiy" > wrote: >> >> >> On 30.11.2017 06:08, Chen Hanxiao wrote: >>> From: Chen Hanxiao >>> >>> Commit 5e5019bf removed this kind of error. >>> >>> But

Re: [libvirt] [PATCH] qemu_agent: report VIR_ERR_AGENT_UNSYNCED if guest_sync failed.

At 2017-11-30 14:11:36, "Nikolay Shirokovskiy" wrote: > > >On 30.11.2017 06:08, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> Commit 5e5019bf removed this kind of error. >> >> But we've already protected race condition by

Re: [libvirt] [PATCH] Remove non-existant 'wiremode' attribute

On Wed, Nov 29, 2017 at 05:51:13PM -0700, Jim Fehlig wrote: > On 11/29/2017 11:01 AM, Daniel P. Berrange wrote: > > The 'wiremode' attribute exists in a couple of Xen XML files, but no code > > has > > ever parsed that value. It was later added to the RNG schema too, again > > despite > > there

Re: [libvirt] PATCH add q35 support ide

On Thu, Nov 30, 2017 at 09:50:01AM +0800, Paul Schlacter wrote: > hello everyone: > In q35 motherboard use ide, Currently, the qemu has supported q35 > Motherboard support ide bus IIRC, this is not quite correct - q35 has a built-in SATA controller, as opposed to IDE controller. You can