[libvirt] [PATCH v4 5/5] news: qemu: use arp table of host to get the IP address of guests

From: Chen Hanxiao Signed-off-by: Chen Hanxiao --- v3: more verbose description docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 5a2943a58..5d6a467d3 100644 --- a/docs/news.xml +++

[libvirt] [PATCH v4 2/5] util: introduce helper to parse message from RTM_GETNEIGH query

From: Chen Hanxiao introduce helper to parse RTM_GETNEIGH query message and store it in struct virArpTable. Signed-off-by: Chen Hanxiao --- v4: use netlink query instead of parsing /proc/net/arp v3: s/virGetArpTable/virArpTableGet alloc

[libvirt] [PATCH v4 1/5] util: introduce virNetlinkGetNeighbor to get neighbor table entry

From: Chen Hanxiao use RTM_GETNEIGH to query arp table entry by netlink socket Signed-off-by: Chen Hanxiao --- v4: use netlink to get arp table entry src/libvirt_private.syms | 1 + src/util/virnetlink.c| 82

[libvirt] [PATCH v4 3/5] qemu: introduce qemuARPGetInterfaces to get IP from host's arp table

From: Chen Hanxiao introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address of VM from the message of netlink RTM_GETNEIGH Signed-off-by: Chen Hanxiao --- v4： remove dummy entry use VIR_APPEND_ELEMENT v3: add docs in

[libvirt] [PATCH v4 4/5] virsh: add --source arp to domifaddr

From: Chen Hanxiao We can use: domifaddr f26-cloud --source arp to get the address. Acked-by: Michal Privoznik Signed-off-by: Chen Hanxiao --- tools/virsh-domain-monitor.c | 2 ++ tools/virsh.pod | 7 --- 2

[libvirt] [PATCH v4 0/5] qemu: use arp table of host to get the

introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address of VM from the output of /proc/net/arp Chen Hanxiao (5): util: introduce virNetlinkGetNeighbor to get neighbor table entry util: introduce helper to parse message from RTM_GETNEIGH query qemu: introduce qemuARPGetInterfaces

[libvirt] [PATCH v1 41/51] util: conf: separate virDomainDefParseRedirFilterInfo from virDomainDefParseXML

separate virDomainDefParseRedirFilterInfo from virDomainDefParseXML, move virDomainDefParseRedirFilterInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 55 +- 1 file changed, 36 insertions(+), 19 deletions(-) diff --git

[libvirt] [PATCH v1 33/51] util: conf: separate virDomainDefParseHostdevInfo from virDomainDefParseXML

separate virDomainDefParseHostdevInfo from virDomainDefParseXML, move virDomainDefParseHostdevInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 91 +++--- 1 file changed, 56 insertions(+), 35 deletions(-) diff --git

[libvirt] [PATCH v1 35/51] util: conf: separate virDomainDefParseMemballoonInfo from virDomainDefParseXML

separate virDomainDefParseMemballoonInfo from virDomainDefParseXML, move virDomainDefParseMemballoonInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 58 +- 1 file changed, 38 insertions(+), 20 deletions(-) diff --git

[libvirt] [PATCH v1 01/51] util: conf: separate virDomainDefParseXML into serial parts

beacause virDomainDefParseXML is too long, and all domain xml parse in this function, it's difficulty to maintain this function so separate virDomainDefParseXML into serial parts use virDomainPreaseInfoFunc. then it will easy to maintain --- src/conf/domain_conf.c | 52

[libvirt] [PATCH v1 24/51] util: conf: separate virDomainDefParseSmartCardsInfo from virDomainDefParseXML

separate virDomainDefParseSmartCardsInfo from virDomainDefParseXML, move virDomainDefParseSmartCardsInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 57 +- 1 file changed, 38 insertions(+), 19 deletions(-) diff --git

[libvirt] [PATCH v1 45/51] util: conf: separate virDomainDefParseIommuInfo from virDomainDefParseXML

separate virDomainDefParseIommuInfo from virDomainDefParseXML, move virDomainDefParseIommuInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 47 --- 1 file changed, 32 insertions(+), 15 deletions(-) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCH v1 28/51] util: conf: separate virDomainDefParseChannelInfo from virDomainDefParseXML

separate virDomainDefParseChannelInfo from virDomainDefParseXML, move virDomainDefParseChannelInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 59 +- 1 file changed, 39 insertions(+), 20 deletions(-) diff --git

[libvirt] [PATCH v1 04/35] util: conf: separate virDomainDefParseDisksInfo from virDomainDefParseXML

separate virDomainDefParseDisksInfo from virDomainDefParseXML, move virDomainDefParseDisksInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 78 +++--- 1 file changed, 49 insertions(+), 29 deletions(-) diff --git

[libvirt] [PATCH v1 02/34] util: conf: separate virDomainDefParseControllerInfo from virDomainDefParseXML

separate virDomainDefParseDeviceInfo from virDomainDefParseXML, separate virDomainDefParseControllerInfo from virDomainDefParseXML, move virDomainDefParseControllerInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 153 - 1 file

[libvirt] [PATCH v1 03/35] util: conf: separate virDomainDefParseControllerInfo from virDomainDefParseXML

separate virDomainDefParseDeviceInfo from virDomainDefParseXML, separate virDomainDefParseControllerInfo from virDomainDefParseXML, move virDomainDefParseControllerInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 153 - 1 file

[libvirt] [PATCH v1 02/51] util: conf: separate virDomainDefParseIdInfo from virDomainDefParseXML

separate virDomainDefParseIdInfo from virDomainDefParseXML --- src/conf/domain_conf.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e36783b..055404e 100644 --- a/src/conf/domain_conf.c +++

[libvirt] [PATCH v1 37/51] util: conf: separate virDomainDefParseTpmInfo from virDomainDefParseXML

separate virDomainDefParseTpmInfo from virDomainDefParseXML, move virDomainDefParseTpmInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 52 ++ 1 file changed, 36 insertions(+), 16 deletions(-) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCH v1 06/51] util: conf: separate virDomainDefParseSecurityLabelInfo from virDomainDefParseXML

separate virDomainDefParseSecurityLabelInfo from virDomainDefParseXML --- src/conf/domain_conf.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2daa6df..64b6c09 100644 ---

[libvirt] [PATCH v1 44/51] util: conf: separate virDomainDefParseDeviceMemInfo from virDomainDefParseXML

separate virDomainDefParseDeviceMemInfo from virDomainDefParseXML, move virDomainDefParseDeviceMemInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 57 +- 1 file changed, 38 insertions(+), 19 deletions(-) diff --git

[libvirt] [PATCH v1 25/51] util: conf: separate virDomainDefParseParallelInfo from virDomainDefParseXML

separate virDomainDefParseParallelInfo from virDomainDefParseXML, move virDomainDefParseParallelInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 77 -- 1 file changed, 49 insertions(+), 28 deletions(-) diff --git

[libvirt] [PATCH v1 49/51] util: conf: separate virDomainDefParseMetadataInfo from virDomainDefParseXML

separate virDomainDefParseMetadataInfo from virDomainDefParseXML --- src/conf/domain_conf.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 03bf5ad..7006e7f 100644 --- a/src/conf/domain_conf.c +++

[libvirt] [PATCH v1 20/51] util: conf: separate virDomainDefParseDisksInfo from virDomainDefParseXML

separate virDomainDefParseDisksInfo from virDomainDefParseXML, move virDomainDefParseDisksInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 78 +++--- 1 file changed, 49 insertions(+), 29 deletions(-) diff --git

[libvirt] [PATCH v1 51/51] util: conf: separate virDomainDefPostParseInternalInfo from virDomainDefParseXML

separate virDomainDefPostParseInternalInfo from virDomainDefParseXML --- src/conf/domain_conf.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7caff3a..0f2450a 100644 --- a/src/conf/domain_conf.c

[libvirt] [PATCH v1 26/51] util: conf: separate virDomainDefParseSerialInfo from virDomainDefParseXML

separate virDomainDefParseSerialInfo from virDomainDefParseXML, move virDomainDefParseSerialInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 76 +++--- 1 file changed, 48 insertions(+), 28 deletions(-) diff --git

[libvirt] [PATCH v1 14/51] util: conf: separate virDomainDefParseEventActionInfo from virDomainDefParseXML

separate virDomainDefParseEventActionInfo from virDomainDefParseXML --- src/conf/domain_conf.c | 68 +- 1 file changed, 39 insertions(+), 29 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b8fe24e..8374b9d 100644 ---

[libvirt] [PATCH v1 19/51] util: conf: separate virDomainDefParseControllerInfo from virDomainDefParseXML

separate virDomainDefParseDeviceInfo from virDomainDefParseXML, separate virDomainDefParseControllerInfo from virDomainDefParseXML, move virDomainDefParseControllerInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 153 - 1 file

[libvirt] [PATCH v1 08/51] util: conf: separate virDomainDefParseVcpuInfo from virDomainDefParseXML

separate virDomainDefParseVcpuInfo from virDomainDefParseXML --- src/conf/domain_conf.c | 92 +++--- 1 file changed, 58 insertions(+), 34 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 809c06a..4453621 100644 ---

[libvirt] [PATCH v1 18/51] util: conf: separate virDomainDefParseBootOptionsInfo from virDomainDefParseXML

separate virDomainDefParseBootOptionsInfo from virDomainDefParseXML --- src/conf/domain_conf.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1a8248d..92a6522 100644 --- a/src/conf/domain_conf.c +++

[libvirt] [PATCH v1 23/51] util: conf: separate virDomainDefParseInterfaceInfo from virDomainDefParseXML

separate virDomainDefParseInterfaceInfo from virDomainDefParseXML, move virDomainDefParseInterfaceInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 82 +++--- 1 file changed, 51 insertions(+), 31 deletions(-) diff --git

[libvirt] [PATCH v1 22/51] util: conf: separate virDomainDefParseFilesystemInfo from virDomainDefParseXML

separate virDomainDefParseFilesystemInfo from virDomainDefParseXML, move virDomainDefParseFilesystemInfo into virDomainDefParseDeviceInfo --- src/conf/domain_conf.c | 54 ++ 1 file changed, 37 insertions(+), 17 deletions(-) diff --git

[libvirt] [PATCH v1 10/51] util: conf: separate virDomainDefParseCputuneInfo from virDomainDefParseXML

separate virDomainDefParseCputuneInfo from virDomainDefParseXML --- src/conf/domain_conf.c | 227 +++-- 1 file changed, 124 insertions(+), 103 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1d74631..e50e56f 100644 ---

[libvirt] [PATCH v1 04/51] util: conf: separate virDomainDefParseOsNodeInfo from virDomainDefParseXML

separate virDomainDefParseOsNodeInfo from virDomainDefParseXML --- src/conf/domain_conf.c | 180 +++-- 1 file changed, 100 insertions(+), 80 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index bf2cf7f..0f7069c 100644 ---

[libvirt] [PATCH v1 12/51] util: conf: separate virDomainDefParseResourceInfo from virDomainDefParseXML

separate virDomainDefParseResourceInfo from virDomainDefParseXML --- src/conf/domain_conf.c | 51 +- 1 file changed, 34 insertions(+), 17 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 892e871..24bd240 100644 ---

[libvirt] [PATCH v1 11/51] util: conf: separate virDomainDefParseCpuNumaInfo from virDomainDefParseXML

separate virDomainDefParseCpuNumaInfo from virDomainDefParseXML --- src/conf/domain_conf.c | 77 ++ 1 file changed, 46 insertions(+), 31 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e50e56f..892e871 100644 ---

[libvirt] [PATCH v1 07/51] util: conf: separate virDomainDefParseMemoryInfo from virDomainDefParseXML

separate virDomainDefParseMemoryInfo from virDomainDefParseXML --- src/conf/domain_conf.c | 228 +++-- 1 file changed, 125 insertions(+), 103 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 64b6c09..809c06a 100644 ---

[libvirt] [PATCH v1 15/51] util: conf: separate virDomainDefParsePMStateInfo from virDomainDefParseXML

separate virDomainDefParsePMStateInfo from virDomainDefParseXML --- src/conf/domain_conf.c | 83 -- 1 file changed, 47 insertions(+), 36 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 8374b9d..248472b 100644 ---

Re: [libvirt] Support interface network stats for SR-IOV in Switchdev mode(VF representors)

After deriving VF representor name on host based on BDF info in 'hostdev' and querying net sysfs entries, virNetDevTapInterfaceStats defined in virnetdevtap.c already serves the purpose for returning stats based on interface name. Is it ok to define a macro as follows to avoid duplicate code or

[libvirt] Developing libvirt for virtual devices like virtual printers

Hi, I have a couple of questions. - I am a new libvirt code developer. I have just cloned the repo and I am looking for a suitable debugger/IDE which will help me debug the code. - I work in developing and creating virtual printers with display, with QEMU as the hypervisor (no KVM-only Qemu).

[libvirt] [tck PATCH 2/9] Use $net->get_dhcp_leases() when available

Newer versions of libvirt no longer let dnsmasq create a leases file, they keep track of it themselves and provide an API to retrieve the current list of leases. Use that to get the guest's IP address when it's available. --- I later realized that it might be more appropriate to use

[libvirt] [tck PATCH 7/9] Fix ebtables check in no-mac-broadcast test

Once the correct filter is enabled for the no-mac-broadcast test, the original test to validate ebtables rules is no longer correct - it was checking for the presence of the test guest's MAC address in the ebtables output on the host, but the no-mac-broadcast filter doesn't have the guest's MAC

[libvirt] [tck PATCH 1/9] create vms that use virt-builder images with no graphics and virtio-net

This is consistent with what is used to create the disk image supplied by virt-builder. It doesn't currently affect the outcome of the test, but it's possible that in the future it could. In particular, the network device name changes depending on whether or not there is a graphics device (due to

[libvirt] [tck PATCH 9/9] Eliminate unnecessary path specifications in binary names

The root account in the Fedora image used for the tests has a properly specified path, so the extra verbiage just clutters up the screen. --- scripts/nwfilter/210-no-mac-spoofing.t | 20 ++-- scripts/nwfilter/220-no-ip-spoofing.t | 26 +-

[libvirt] [tck PATCH 8/9] filter for proper IP address in tcpdump looking for broadcast packet

In the no-mac-broadcast test, a ping is sent to 192.168.122.255, but tcpdump is set to look for packets with a destination IP of 255.255.255.255. Change it to check for the correct IP address and also for mac broadcast (which is what the no-mac-broadcast filter actually looks at). This should

[libvirt] [tck PATCH 6/9] parameterize filterref in generic_domain

...and set it properly in all the nwfilter tests (it's irrelevant for the others). This corrects a problem with the no-mac-broadcast test, which was checking to see that packets with a destination MAC address of ff:ff:ff:ff:ff:ff weren't allowed, but was neglecting to add the "no-mac-broadcast"

[libvirt] [tck PATCH 5/9] Fix no-arp-spoof test script generation

I'm not sure if or how this ever worked before - what is supposed to happen is that the shell script in $cmdfile is put into the file /test.sh on the guest, then /test.sh is executed. But the code was instead trying to directly execute the text of the entire script as a single command and write

[libvirt] [tck PATCH 3/9] Use Net::OpenSSH instead of Net::SSH::Perl

Net::SSH::Perl is out of date in the Fedora git repos. The version currently supported in Fedora fails to connect to most modern sshd's, and updating to the new version would require adding several new perl packages to Fedora. Instead, this patch switches to using Net::OpenSSH, whose current

[libvirt] [tck PATCH 4/9] Fix no-ip-spoofing test script generation

The setting of the environment variable MASK was for some reason producing "8" instead of "24". Changing from using back-ticks "`" that resolved at the time the script was created, to using $(blah) resolved when the script is *run* magically fixed the problem. Note that this doesn't change the

[libvirt] [tck PATCH 0/9] Fix libvirt-tck nwfilter tests

libvirt-tck happens to have the most thorough set of nwfilter tests around. Unfortunately they haven't been run in quite awhile, and have suffered from some bit rot. This patch series (along with Dan's patch to force virt-builder to redo selinux labels after installing extra packages) gets the

Re: [libvirt] [PATCH 1/3] Add a plugin dlm for lock manager

On 02/05/2018 04:07 AM, river wrote: > dlm is implemented by linux kernel, provides userspace API by > 'libdlm' to lock/unlock resource, cooperated with cluster > communication software, such as corosync, could satisfy the > demands of libvirt lock manager. This is lacking in any description of

Re: [libvirt] [PATCH] qemu: fix migration with local and VIR_STORAGE_TYPE_NETWORK disks

On 02/07/2018 12:05 PM, Daniel P. Berrangé wrote: On Wed, Feb 07, 2018 at 11:57:19AM -0600, Chris Friesen wrote: In the current implementation of qemuMigrateDisk() the value of the "nmigrate_disks" parameter wrongly impacts the decision whether or not to migrate a disk that is not a member of

Re: [libvirt] [PATCH] qemu: fix migration with local and VIR_STORAGE_TYPE_NETWORK disks

On Wed, Feb 07, 2018 at 11:57:19AM -0600, Chris Friesen wrote: > In the current implementation of qemuMigrateDisk() the value of the > "nmigrate_disks" parameter wrongly impacts the decision whether or not > to migrate a disk that is not a member of "migrate_disks": > > 1) If "nmigrate_disks" is

[libvirt] [PATCH] qemu: fix migration with local and VIR_STORAGE_TYPE_NETWORK disks

In the current implementation of qemuMigrateDisk() the value of the "nmigrate_disks" parameter wrongly impacts the decision whether or not to migrate a disk that is not a member of "migrate_disks": 1) If "nmigrate_disks" is zero, "disk" is migrated if it's non-shared non-readonly with source. 2)

Re: [libvirt] [RFC v2 REPOST] arm64: KVM: KVM API extensions for SVE

On Wed, Feb 07, 2018 at 05:17:50PM +0100, Christoffer Dall wrote: > On Wed, Feb 07, 2018 at 03:34:03PM +, Dave Martin wrote: > > On Wed, Feb 07, 2018 at 03:58:31PM +0100, Christoffer Dall wrote: > > > On Wed, Feb 07, 2018 at 11:33:28AM +, Dave Martin wrote: [...] > > > > Alternatively,

Re: [libvirt] [RFC v2 REPOST] arm64: KVM: KVM API extensions for SVE

On Wed, Feb 07, 2018 at 03:34:03PM +, Dave Martin wrote: > On Wed, Feb 07, 2018 at 03:58:31PM +0100, Christoffer Dall wrote: > > On Wed, Feb 07, 2018 at 11:33:28AM +, Dave Martin wrote: > > [...] > > > > What if KVM_ARM_SVE_SET_VLS() were to yield 0 if the exact requested set > > > of

[libvirt] [jenkins-ci PATCH 2/2] jobs: Switch all Python builds to Python 3

virt-manager is Python 3 only now, so using Python 2 to call its build script will not work. Moreover, since we build and test it against our local copy of libvirt-python, we need to make sure libvirt-python itself is built for Python 3. At the moment, we don't have support for building against

[libvirt] [jenkins-ci PATCH 1/2] guests: Install Python 3 dependencies for virt-manager

virt-manager is Python 3 only now, so we need to update the list of packages that gets installed on our guests. In some cases the Python 3 build of the dependency is not available, so we have no choice but to stop building virt-manager there. Signed-off-by: Andrea Bolognani

[libvirt] [jenkins-ci PATCH 0/2] Fix virt-manager build failure

By making a lot of compromises. Not a perfect solution, but still better than not building virt-manager at all until we've come up with a proper one I reckon. ¯\_(ツ)_/¯ Andrea Bolognani (2): guests: Install Python 3 dependencies for virt-manager jobs: Switch all Python builds to Python 3

Re: [libvirt] [RFC v2 REPOST] arm64: KVM: KVM API extensions for SVE

On Wed, Feb 07, 2018 at 03:58:31PM +0100, Christoffer Dall wrote: > On Wed, Feb 07, 2018 at 11:33:28AM +, Dave Martin wrote: [...] > > What if KVM_ARM_SVE_SET_VLS() were to yield 0 if the exact requested set > > of VLs was configured, -ERANGE if some subset was configured successfully > >

Re: [libvirt] [RFC v2 REPOST] arm64: KVM: KVM API extensions for SVE

On Wed, Feb 07, 2018 at 11:33:28AM +, Dave Martin wrote: > On Tue, Feb 06, 2018 at 02:17:57PM +0100, Christoffer Dall wrote: > > On Tue, Feb 06, 2018 at 11:43:16AM +, Dave Martin wrote: > > > On Mon, Feb 05, 2018 at 05:13:08PM +0100, Christoffer Dall wrote: > > > > Hi Dave, > > > > > > >

[libvirt] [PATCH python 1/1] Set hints for virPyDictToTypedParams

Predefine hints for all parameters possible to avoid wrong type convert. Signed-off-by: Edgar Kaziakhmedov --- libvirt-override.c | 128 +++-- 1 file changed, 124 insertions(+), 4 deletions(-) diff --git

Re: [libvirt] [PATCH] virlog: determine the hostname on startup CVE-2018-XXX

+-- On Mon, 5 Feb 2018, Daniel P. Berrangé wrote --+ | From: Lubomir Rintel | | At later point it might not be possible or even safe to use getaddrinfo(). It | can in turn result in a load of NSS module. | | Notably, on a LXC container startup we may find ourselves with the

Re: [libvirt] [jenkins-ci] lcitool: Use default python for creating salty passwords

On Wed, 2018-02-07 at 13:37 +, Daniel P. Berrangé wrote: > Or can we just use openssl > > $ openssl passwd -crypt hello > RtT4tOPU/wPnU I'd love to avoid embedding a Python script in there[1], but it doesn't look like openssl supports the same strong hashing algorithm we're currently using,

[libvirt] [PATCH] util: Fix syntax-check

Broken by 759b4d1b0fe5f4d84d98b99153dfa7ac289dd167. Signed-off-by: Andrea Bolognani --- Pushed as a CI build fix. src/util/virlog.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 9105337ce..8f1e4800d 100644

Re: [libvirt] [jenkins-ci] lcitool: Use default python for creating salty passwords

On Wed, Feb 07, 2018 at 02:32:34PM +0100, Andrea Bolognani wrote: > On Tue, 2018-01-30 at 10:57 +0100, Martin Kletzander wrote: > > On my system the crypt module in python2 doesn't have mksalt() function. > > However python3 does and the code is perfectly fine python3 code as well. > > So > >

Re: [libvirt] [jenkins-ci] lcitool: Use default python for creating salty passwords

On Tue, 2018-01-30 at 10:57 +0100, Martin Kletzander wrote: > On my system the crypt module in python2 doesn't have mksalt() function. > However python3 does and the code is perfectly fine python3 code as well. So > let's make it run in the default python version as that has the highest chance >

Re: [libvirt] [PATCH python 1/1] Fix type extracting from PyDict

On 02/07/2018 03:26 PM, Daniel P. Berrangé wrote: On Wed, Feb 07, 2018 at 03:23:58PM +0300, Edgar Kaziakhmedov wrote: On 02/07/2018 01:56 PM, Daniel P. Berrangé wrote: On Wed, Feb 07, 2018 at 01:46:00PM +0300, Edgar Kaziakhmedov wrote: Ping On 01/31/2018 07:34 PM, Edgar Kaziakhmedov

Re: [libvirt] [PATCH] virlog: determine the hostname on startup CVE-2018-XXX

On Wed, Feb 07, 2018 at 09:58:21AM +0530, P J P wrote: > +-- On Mon, 5 Feb 2018, Daniel P. Berrangé wrote --+ > | From: Lubomir Rintel > | > | At later point it might not be possible or even safe to use getaddrinfo(). > It > | can in turn result in a load of NSS module. > | > |

Re: [libvirt] [PATCH] conf: Check for NUMA distances in validity check

On 02/07/2018 12:18 PM, Peter Krempa wrote: > > ACK with the variable declaration fixed. 'n' in case of the number of > numa nodes will be rather small, so it should not be a problem to use > O(n^2) algorithm here. > Agreed. We have plenty of O(n^2) algorithms in our code (even O(n^3) I

Re: [libvirt] [PATCH 0/4] qemu: Don't refresh 'halted' state for domain stats

On Tue, Feb 06, 2018 at 16:30:51 +0100, Peter Krempa wrote: > The halted state information is useless on most platforms and calling > 'query-cpus' is very expensive. Don't report the info on platforms where > it does not make sense. > > Peter Krempa (3): > qemu: driver: Extract vcpu halted

Re: [libvirt] [PATCH python 1/1] Fix type extracting from PyDict

On Wed, Feb 07, 2018 at 03:23:58PM +0300, Edgar Kaziakhmedov wrote: > > > On 02/07/2018 01:56 PM, Daniel P. Berrangé wrote: > > On Wed, Feb 07, 2018 at 01:46:00PM +0300, Edgar Kaziakhmedov wrote: > > > Ping > > > > > > > > > On 01/31/2018 07:34 PM, Edgar Kaziakhmedov wrote: > > > > PyInt_Check

Re: [libvirt] [PATCH python 1/1] Fix type extracting from PyDict

On 02/07/2018 01:56 PM, Daniel P. Berrangé wrote: On Wed, Feb 07, 2018 at 01:46:00PM +0300, Edgar Kaziakhmedov wrote: Ping On 01/31/2018 07:34 PM, Edgar Kaziakhmedov wrote: PyInt_Check returns value whether or not an input object is the integer type. The existing implementation of

Re: [libvirt] [RFC v2 REPOST] arm64: KVM: KVM API extensions for SVE

On Tue, Feb 06, 2018 at 02:17:57PM +0100, Christoffer Dall wrote: > On Tue, Feb 06, 2018 at 11:43:16AM +, Dave Martin wrote: > > On Mon, Feb 05, 2018 at 05:13:08PM +0100, Christoffer Dall wrote: > > > Hi Dave, > > > > > > On Fri, Jan 26, 2018 at 05:28:49PM +, Dave Martin wrote: [...] >

Re: [libvirt] [PATCH] conf: Check for NUMA distances in validity check

On Wed, Feb 07, 2018 at 10:45:39 +0100, Michal Privoznik wrote: > On 02/06/2018 09:34 PM, Peter Krempa wrote: > > On Tue, Feb 06, 2018 at 17:23:47 +0100, Michal Privoznik wrote: > >> NUMA distances are part of guest ABI (guests can read it > >> directly!) and therefore as such shouldn't change

Re: [libvirt] [Libguestfs] [PATCH tck] Relabel SELinux when customizing virt-builder image

On Tue, Feb 06, 2018 at 12:50:51PM -0500, Laine Stump wrote: > On 02/06/2018 10:53 AM, Pino Toscano wrote: > > On Tuesday, 6 February 2018 16:40:04 CET Daniel P. Berrangé wrote: > >> When you tell virt-builder to install extra RPMs, this potentially > >> looses the SELinux labelling that Anaconda

Re: [libvirt] [PATCH python 1/1] Fix type extracting from PyDict

On Wed, Feb 07, 2018 at 01:46:00PM +0300, Edgar Kaziakhmedov wrote: > Ping > > > On 01/31/2018 07:34 PM, Edgar Kaziakhmedov wrote: > > PyInt_Check returns value whether or not an input object is the integer > > type. The existing implementation of extracting leads to the wrong > > type

Re: [libvirt] [PATCH python 1/1] Fix type extracting from PyDict

Ping On 01/31/2018 07:34 PM, Edgar Kaziakhmedov wrote: PyInt_Check returns value whether or not an input object is the integer type. The existing implementation of extracting leads to the wrong type interpretation in the following code: params = {libvirt.VIR_MIGRATE_PARAM_DISKS_PORT : 50123}

Re: [libvirt] [PATCH] conf: Check for NUMA distances in validity check

On 02/06/2018 09:34 PM, Peter Krempa wrote: > On Tue, Feb 06, 2018 at 17:23:47 +0100, Michal Privoznik wrote: >> NUMA distances are part of guest ABI (guests can read it >> directly!) and therefore as such shouldn't change throughout the >> lifetime of domain. >> >> Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH RFCv2 0/4] Add optional pSeries features

On Tue, 2018-02-06 at 21:25 +0100, Peter Krempa wrote: > On Tue, Feb 06, 2018 at 17:54:55 +0100, Andrea Bolognani wrote: > > Applies on top of [req]. > > > > RFC because we still don't have a way of probing QEMU to figure > > out whether the relevant toggles are available. Plus, there's no > >