[libvirt] [PATCH 04/11] virsh: Fix man page argument ordering for vol-upload command

The proper command order is 'virsh vol-upload volume file pool'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the volume could be found if the pool name was not provided. Signed-off-by: John Ferlan ---

[libvirt] [PATCH 07/11] virsh: Fix man page argument ordering for vol-dumpxml command

The proper command order is 'virsh vol-dumpxml volume pool'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the volume could be found if the pool name was not provided. Signed-off-by: John Ferlan ---

[libvirt] [PATCH 09/11] virsh: Clean up man page formatting for vol-list and vol-pool

Make the output more readable. Signed-off-by: John Ferlan --- tools/virsh.pod | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index cd1ccc6fa..1b59251bf 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@

[libvirt] [PATCH 11/11] tools: Clean up the vol-resize man page

Instead of appearing as one long paragraph, split the output to list each command option on its own line for better readability. Signed-off-by: John Ferlan --- tools/virsh.pod | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff

[libvirt] [PATCH 03/11] virsh: Fix man page argument ordering for vol-delete command

The proper command order is 'virsh vol-delete volume pool'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the volume could be found if the pool name was not provided. Signed-off-by: John Ferlan ---

[libvirt] [PATCH 06/11] virsh: Fix man page argument ordering for vol-wipe command

The proper command order is 'virsh vol-wipe volume pool algorithm'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the volume could be found if the pool name was not provided. Signed-off-by: John Ferlan ---

[libvirt] [PATCH 08/11] virsh: Fix man page argument ordering for vol-info command

The proper command order is 'virsh vol-info volume pool'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the volume could be found if the pool name was not provided. Signed-off-by: John Ferlan ---

[libvirt] [PATCH 10/11] virsh: Fix man page argument ordering for vol-{path|name|key} commands

The proper command order is 'virsh vol-path volume pool', or 'virsh vol-name volume pool', or 'virsh vol-key volume'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the volume could be found if the pool name was not provided.

[libvirt] [PATCH 01/11] virsh: Clean up formatting of the vol-create* commands

Clean up the formatting to make the output a bit more readable at least with respect to not having one paragraph of output. Each option will start on its own line. Signed-off-by: John Ferlan --- tools/virsh.pod | 30 +++--- 1 file changed, 23

[libvirt] [PATCH 02/11] virsh: Fix man page argument ordering for vol-clone command

The proper command order is 'virsh vol-clone source-vol target-vol pool'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the source-vol could be found if the pool name was not provided. Signed-off-by: John Ferlan

[libvirt] [PATCH 05/11] virsh: Fix man page argument ordering for vol-download command

The proper command order is 'virsh vol-download volume file pool'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the volume could be found if the pool name was not provided. Signed-off-by: John Ferlan ---

[libvirt] [PATCH 00/11] Make some virsh.pod adjustments for vol-* commands

Been reviewing documentation lately - ran into the virsh vol-* commands and their "inconsistency" with the expected ordering of the command options. Also the commands were largely a mash of sentences without regard for any sort of readability. John Ferlan (11): virsh: Clean up formatting of the

[libvirt] [GSoC]: Help in setup

Hi, I am Sukrit, currently pursuing Masters in Computer Science and Engineering from Indian Institute of Technology Bombay, India. I am interested in applying for a few projects listed on the ideas page. But, I am not able to connect to IRC channel (missing key problem). Also, I am not able to

Re: [libvirt] [dbus PATCH 16/18] introduce support for libdbus library

On Mon, Mar 12, 2018 at 05:21:46PM +0100, Pavel Hrdina wrote: > We will switch to libdbus library because the systemd sd-bus > implementation is not thread safe. Hmmm, libdbus.so isn't all that great with threads either. It has had countless bugs in its thread support over the years to the extent

Re: [libvirt] Two more libvirt GSOC ideas

On Mon, Mar 12, 2018 at 03:25:48PM +, Daniel P. Berrangé wrote: > On Mon, Mar 12, 2018 at 04:18:35PM +0100, Erik Skultety wrote: > > Hi, > > I'd like to add 2 more GSOC ideas to our wiki page, but I'd like to get some > > opinions whether you think these might even be appropriate GSOC project

[libvirt] [dbus PATCH 16/18] introduce support for libdbus library

We will switch to libdbus library because the systemd sd-bus implementation is not thread safe. Processing messages in threads is essential since Libvirt API can take some significant amount of time to return and that would block the whole libvirt-dbus daemon. Signed-off-by: Pavel Hrdina

[libvirt] [dbus PATCH 07/18] events: fix function names for TrayChange and DiskChange events

Signed-off-by: Pavel Hrdina --- src/events.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/events.c b/src/events.c index 420fe63..0ece3ab 100644 --- a/src/events.c +++ b/src/events.c @@ -126,7 +126,7 @@

[libvirt] [dbus PATCH 01/18] util: rename VIR_ATTR_UNUSED

The correct prefix is VIRT. Signed-off-by: Pavel Hrdina --- src/connect.c | 8 +++--- src/domain.c | 78 +-- src/events.c | 12 - src/main.c| 12 - src/util.h| 3 ++- 5 files changed, 57

[libvirt] [dbus PATCH 18/18] main: introduce threads to process the dbus messages

This implements very simple thread pool to process dbus messages in separate threads. We don't need to handle queue for messages because dbus does that for us. The default thread count will be currently 4 and it is also configurable via --threads parameter for the libvirt-dbus daemon.

[libvirt] [dbus PATCH 10/18] spec: don't use hard-coded system_user

Signed-off-by: Pavel Hrdina --- libvirt-dbus.spec.in | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libvirt-dbus.spec.in b/libvirt-dbus.spec.in index 572300f..87f20d4 100644 --- a/libvirt-dbus.spec.in +++ b/libvirt-dbus.spec.in @@ -2,6 +2,7 @@

[libvirt] [dbus PATCH 12/18] maint: cleanup includes

Signed-off-by: Pavel Hrdina --- src/connect.c | 1 - src/domain.c | 1 + src/domain.h | 1 - src/events.c | 1 + src/events.h | 3 --- src/main.c| 2 ++ src/util.c| 2 ++ src/util.h| 2 -- 8 files changed, 6 insertions(+), 7 deletions(-) diff --git

[libvirt] [dbus PATCH 06/18] events: fix signal message for TrayChange event

The reply contains only two strings. Signed-off-by: Pavel Hrdina --- src/events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/events.c b/src/events.c index 681441d..420fe63 100644 --- a/src/events.c +++ b/src/events.c @@ -160,7 +160,7 @@

[libvirt] [dbus PATCH 15/18] domain: create a helper function to get a domain object

This is called for every API, create a function for it. Signed-off-by: Pavel Hrdina --- src/domain.c | 220 --- 1 file changed, 75 insertions(+), 145 deletions(-) diff --git a/src/domain.c b/src/domain.c index

[libvirt] [dbus PATCH 11/18] maint: fix coding style

Signed-off-by: Pavel Hrdina --- src/connect.h | 21 ++--- src/domain.c | 1 + src/util.c| 42 +- 3 files changed, 36 insertions(+), 28 deletions(-) diff --git a/src/connect.h b/src/connect.h index 9078ae7..1086bc6

[libvirt] [dbus PATCH 17/18] switch from sd-bus to libdbus

This removes all the systemd sd-bus code. Signed-off-by: Pavel Hrdina --- README | 1 - configure.ac | 3 - data/Makefile.am | 4 +- data/org.libvirt.Connect.xml | 56 + data/org.libvirt.Domain.xml | 51 +

[libvirt] [dbus PATCH 13/18] domain: ensure connection to libvirt

Fixes an bug that was introduced by <8e24f602>. Signed-off-by: Pavel Hrdina --- src/connect.c | 2 +- src/connect.h | 4 src/domain.c | 51 +++ 3 files changed, 56 insertions(+), 1 deletion(-) diff --git

[libvirt] [dbus PATCH 09/18] main: fix error message

Signed-off-by: Pavel Hrdina --- src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main.c b/src/main.c index c4ad1e3..5dca7fb 100644 --- a/src/main.c +++ b/src/main.c @@ -198,7 +198,7 @@ main(int argc, char *argv[]) r =

[libvirt] [dbus PATCH 04/18] connect: introduce VIRT_DBUS_CONNECT_INTERFACE

This also fixes the one wrong interface name in events.c. Signed-off-by: Pavel Hrdina --- src/connect.c | 2 +- src/connect.h | 2 ++ src/events.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/connect.c b/src/connect.c index b44d247..45fb2ae

[libvirt] [dbus PATCH 14/18] connect: parse message arguments as first thing

There is no need to open connection if parsing arguments fails. Signed-off-by: Pavel Hrdina --- src/connect.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/connect.c b/src/connect.c index b31f08e..695fc0d 100644 --- a/src/connect.c +++

[libvirt] [dbus PATCH 03/18] util: introduce VIRT_DBUS_ERROR_INTERFACE

Signed-off-by: Pavel Hrdina --- src/util.c | 4 ++-- src/util.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/util.c b/src/util.c index 962eaab..3e6be4e 100644 --- a/src/util.c +++ b/src/util.c @@ -66,14 +66,14 @@

[libvirt] [dbus PATCH 08/18] main: error out if signal handler is not registered

Signed-off-by: Pavel Hrdina --- src/main.c | 4 1 file changed, 4 insertions(+) diff --git a/src/main.c b/src/main.c index e0f9434..c4ad1e3 100644 --- a/src/main.c +++ b/src/main.c @@ -219,6 +219,10 @@ main(int argc, char *argv[])

[libvirt] [dbus PATCH 02/18] util: there is no need to mark cleanup functions as inline

Signed-off-by: Pavel Hrdina --- src/util.c | 34 ++ src/util.h | 38 -- 2 files changed, 42 insertions(+), 30 deletions(-) diff --git a/src/util.c b/src/util.c index d0649fa..962eaab 100644 --- a/src/util.c

[libvirt] [dbus PATCH 05/18] domain: introduce VIRT_DBUS_DOMAIN_INTERFACE

Signed-off-by: Pavel Hrdina --- src/domain.c | 2 +- src/domain.h | 2 ++ src/events.c | 8 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/domain.c b/src/domain.c index ebcd142..850ea4a 100644 --- a/src/domain.c +++ b/src/domain.c @@ -573,7 +573,7

[libvirt] [dbus PATCH 00/18] rewrite to use libdbus and some other fixes

The first 15 patches fixes some issues and bugs and cleanups the code. Patch 16 introduces support for libdbus and a lot of helper functions. Patch 17 switches the code to use libdbus instead of sd-bus and drops all sd-bus related code. Patch 18 introduces threading so every message is

Re: [libvirt] [PATCH] bhyve: fix crash on missing interface model

Michal Privoznik wrote: > On 03/11/2018 05:02 PM, Roman Bogorodskiy wrote: > > The bhyve driver crashes in bhyveBuildNetArgStr() when > > network interface model is not defined. As it has to be provided > > explicitly, add a check to report an error if it's missing. > > --- > >

Re: [libvirt] [PATCH] Fix build with clang 6.0.0

Michal Privoznik wrote: > On 03/11/2018 04:38 PM, Roman Bogorodskiy wrote: > > Clang 6.0.0 complains when initializing structure with { NULL }: > > > > conf/domain_addr.c:1494:38: error: missing field 'type' initializer > > [-Werror,-Wmissing-field-initializers] > > virDomainDeviceInfo

Re: [libvirt] [PATCH v2 2/9] qemu: introduce SEV feature in hypervisor capabilities

On Mon, Mar 12, 2018 at 10:25:44AM -0500, Brijesh Singh wrote: > > > On 03/12/2018 08:33 AM, Daniel P. Berrangé wrote: > > On Thu, Mar 08, 2018 at 11:12:01AM -0600, Brijesh Singh wrote: > > > Extend hypervisor capabilities to include sev feature. When available, > > > hypervisor supports

Re: [libvirt] [PATCH v2 5/9] libvirt: add new public API to get launch security info

On 03/12/2018 07:01 AM, Daniel P. Berrangé wrote: On Thu, Mar 08, 2018 at 11:12:04AM -0600, Brijesh Singh wrote: The API can be used outside the libvirt to get the launch security information. When SEV is enabled, the API can be used to get the measurement of the launch process.

Re: [libvirt] [PATCH v2 1/9] qemu: provide support to query the SEV capability

On 03/12/2018 08:52 AM, Peter Krempa wrote: On Mon, Mar 12, 2018 at 13:31:23 +, Daniel Berrange wrote: On Thu, Mar 08, 2018 at 11:12:00AM -0600, Brijesh Singh wrote: QEMU version >= 2.12 provides support for launching an encrypted VMs on AMD x86 platform using Secure Encrypted

Re: [libvirt] [PATCH v2 4/9] qemu: add support to launch SEV guest

On 03/12/2018 08:41 AM, Daniel P. Berrangé wrote: On Thu, Mar 08, 2018 at 11:12:03AM -0600, Brijesh Singh wrote: QEMU >= 2.12 provides 'sev-guest' object which is used to launch encrypted VMs on AMD platform using SEV feature. The various inputs required to launch SEV guest is provided

Re: [libvirt] [PATCH v2 2/9] qemu: introduce SEV feature in hypervisor capabilities

On 03/12/2018 08:33 AM, Daniel P. Berrangé wrote: On Thu, Mar 08, 2018 at 11:12:01AM -0600, Brijesh Singh wrote: Extend hypervisor capabilities to include sev feature. When available, hypervisor supports launching an encrypted VM on AMD platform. The sev feature tag provides additional

Re: [libvirt] Two more libvirt GSOC ideas

On Mon, Mar 12, 2018 at 04:18:35PM +0100, Erik Skultety wrote: > Hi, > I'd like to add 2 more GSOC ideas to our wiki page, but I'd like to get some > opinions whether you think these might even be appropriate GSOC project > candidates. > > #1 > PROJECT: > Support wildcard with log filters > >

Re: [libvirt] [PATCH] keycodemapdb: Update submodule

On Mon, Mar 12, 2018 at 04:03:59PM +0100, Andrea Bolognani wrote: > On Mon, 2018-03-12 at 14:58 +, Daniel P. Berrangé wrote: > > On Mon, Mar 12, 2018 at 03:53:09PM +0100, Andrea Bolognani wrote: > > > On Mon, 2018-03-12 at 14:46 +, Daniel P. Berrangé wrote: > > > > > The build system

[libvirt] Two more libvirt GSOC ideas

Hi, I'd like to add 2 more GSOC ideas to our wiki page, but I'd like to get some opinions whether you think these might even be appropriate GSOC project candidates. #1 PROJECT: Support wildcard with log filters SUMMARY: Enhance the log filters format to allow specifying a wildcard, i.e. :*

Re: [libvirt] [PATCH v2 1/9] qemu: provide support to query the SEV capability

On 03/12/2018 08:31 AM, Daniel P. Berrangé wrote: On Thu, Mar 08, 2018 at 11:12:00AM -0600, Brijesh Singh wrote: QEMU version >= 2.12 provides support for launching an encrypted VMs on AMD x86 platform using Secure Encrypted Virtualization (SEV) feature. This patch adds support to query the

Re: [libvirt] [PATCH] keycodemapdb: Update submodule

On Mon, 2018-03-12 at 14:58 +, Daniel P. Berrangé wrote: > On Mon, Mar 12, 2018 at 03:53:09PM +0100, Andrea Bolognani wrote: > > On Mon, 2018-03-12 at 14:46 +, Daniel P. Berrangé wrote: > > > > The build system doesn't get refreshed automatically after this > > > > change, so it's still

Re: [libvirt] [PATCH] keycodemapdb: Update submodule

On Mon, Mar 12, 2018 at 03:53:09PM +0100, Andrea Bolognani wrote: > On Mon, 2018-03-12 at 14:46 +, Daniel P. Berrangé wrote: > > > The build system doesn't get refreshed automatically after this > > > change, so it's still trying to generate virkeycodetable_rfb.h > > > and failing because the

Re: [libvirt] [PATCH] keycodemapdb: Update submodule

On Mon, 2018-03-12 at 14:46 +, Daniel P. Berrangé wrote: > > The build system doesn't get refreshed automatically after this > > change, so it's still trying to generate virkeycodetable_rfb.h > > and failing because the current version of keymap-gen doesn't know > > about it. > > Perhaps it

Re: [libvirt] [PATCH] keycodemapdb: Update submodule

On Mon, Mar 12, 2018 at 03:30:33PM +0100, Andrea Bolognani wrote: > On Mon, 2018-03-12 at 14:00 +, Daniel P. Berrangé wrote: > > On Mon, Mar 12, 2018 at 02:29:49PM +0100, Andrea Bolognani wrote: > > > This time around it's not enough to just pick the latest commit, > > > because with

Re: [libvirt] [PATCH] qemu: different declarations for the same method.

On Mon, Mar 12, 2018 at 11:26:42AM -0300, Julio Faracco wrote: > Hi guys, > > I'm using cppcheck with gcc as template. > See virsocketaddr as an example. > > $ cppcheck --template=gcc --enable=warning --inconclusive > src/util/virsocketaddr.c > Checking src/util/virsocketaddr.c ... >

Re: [libvirt] [PATCH] keycodemapdb: Update submodule

On Mon, 2018-03-12 at 14:00 +, Daniel P. Berrangé wrote: > On Mon, Mar 12, 2018 at 02:29:49PM +0100, Andrea Bolognani wrote: > > This time around it's not enough to just pick the latest commit, > > because with aed87bb2aa6ed83b49574eb982e3bdd4c36acf17 keycodemapdb > > renamed the 'rfb' keycode

Re: [libvirt] [PATCH] qemu: different declarations for the same method.

Hi guys, I'm using cppcheck with gcc as template. See virsocketaddr as an example. $ cppcheck --template=gcc --enable=warning --inconclusive src/util/virsocketaddr.c Checking src/util/virsocketaddr.c ... src/util/virsocketaddr.c:204: warning: Function 'virSocketAddrSetIPv4AddrNetOrder' argument

Re: [libvirt] [PATCH] conf: allow more user friendly names for disk formats

Your system clock is 21 days early. On Mon, Mar 12, 2018 at 01:57:36PM +, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- src/conf/domain_conf.c | 6 ++ 1 file changed, 6 insertions(+) Missing tests. diff --git a/src/conf/domain_conf.c

Re: [libvirt] [PATCH] keycodemapdb: Update submodule

On Mon, Mar 12, 2018 at 02:29:49PM +0100, Andrea Bolognani wrote: > This time around it's not enough to just pick the latest commit, > because with aed87bb2aa6ed83b49574eb982e3bdd4c36acf17 keycodemapdb > renamed the 'rfb' keycode to 'qnum' and we need to accept the new > name while maintaining

[libvirt] [PATCH] conf: allow more user friendly names for disk formats

Signed-off-by: Daniel P. Berrangé --- src/conf/domain_conf.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 04a6ee77af..007b73a84d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9152,6

Re: [libvirt] [PATCH v2 1/9] qemu: provide support to query the SEV capability

On Mon, Mar 12, 2018 at 13:31:23 +, Daniel Berrange wrote: > On Thu, Mar 08, 2018 at 11:12:00AM -0600, Brijesh Singh wrote: > > QEMU version >= 2.12 provides support for launching an encrypted VMs on > > AMD x86 platform using Secure Encrypted Virtualization (SEV) feature. > > This patch adds

Re: [libvirt] [PATCH v2 4/9] qemu: add support to launch SEV guest

On Thu, Mar 08, 2018 at 11:12:03AM -0600, Brijesh Singh wrote: > QEMU >= 2.12 provides 'sev-guest' object which is used to launch encrypted > VMs on AMD platform using SEV feature. The various inputs required to > launch SEV guest is provided through the tag. A typical > SEV guest launch command

Re: [libvirt] [PATCH v2 3/9] conf: introduce launch-security element in domain

On Thu, Mar 08, 2018 at 11:12:02AM -0600, Brijesh Singh wrote: > The launch-security element can be used to define the security > model to use when launching a domain. Currently we support 'sev'. > > When 'sev' is used, the VM will be launched with AMD SEV feature enabled. > SEV feature supports

Re: [libvirt] [PATCH v2 2/9] qemu: introduce SEV feature in hypervisor capabilities

On Thu, Mar 08, 2018 at 11:12:01AM -0600, Brijesh Singh wrote: > Extend hypervisor capabilities to include sev feature. When available, > hypervisor supports launching an encrypted VM on AMD platform. The > sev feature tag provides additional details like platform diffie-hellman > key and

Re: [libvirt] [PATCH v2 1/9] qemu: provide support to query the SEV capability

On Thu, Mar 08, 2018 at 11:12:00AM -0600, Brijesh Singh wrote: > QEMU version >= 2.12 provides support for launching an encrypted VMs on > AMD x86 platform using Secure Encrypted Virtualization (SEV) feature. > This patch adds support to query the SEV capability from the qemu. > > Signed-off-by:

[libvirt] [PATCH] keycodemapdb: Update submodule

This time around it's not enough to just pick the latest commit, because with aed87bb2aa6ed83b49574eb982e3bdd4c36acf17 keycodemapdb renamed the 'rfb' keycode to 'qnum' and we need to accept the new name while maintaining backwards compatibility. Signed-off-by: Andrea Bolognani

Re: [libvirt] [PATCH 03/20] libxl: Properly cleanup after libxlDomObjFromDomain

On 03/11/2018 10:13 PM, Jim Fehlig wrote: > On 03/09/2018 09:47 AM, John Ferlan wrote: >> Commit id '9ac945078' altered libxlDomObjFromDomain to return >> a locked *and* ref counted object for some specific purposes; >> however, it neglected to alter all the consumers of the helper >> to use

Re: [libvirt] [PATCH 3/3] qemu: Forbid user aliases for USB controllers

On 03/12/2018 10:04 AM, Peter Krempa wrote: > On Fri, Mar 09, 2018 at 12:56:13 +0100, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1552127 >> >> These are bit different than other devices. Their alias also >> specify the name of the bus. For instance, if there are these

Re: [libvirt] [PATCH v2 5/9] libvirt: add new public API to get launch security info

On Thu, Mar 08, 2018 at 11:12:04AM -0600, Brijesh Singh wrote: > The API can be used outside the libvirt to get the launch security > information. When SEV is enabled, the API can be used to get the > measurement of the launch process. > > Signed-off-by: Brijesh Singh >

Re: [libvirt] [PATCH] libvirtd: fix potential deadlock when reloading

On Thu, Mar 08, 2018 at 03:25:51PM -0700, Jim Fehlig wrote: > It is possible to deadlock libvirtd when concurrently starting a domain > and restarting the daemon. Threads involved in the deadlock are > > Thread 4 (Thread 0x7fc13b53e700 (LWP 64084)): > #0 0x7fc13fba10bf in

[libvirt] [PATCH] Update to latest gnulib

GnuLib has now fixed the incompatibility with latest GLibC that was affecting builds on Fedora rawhide. We can thus update and drop our local workaround. Signed-off-by: Daniel P. Berrangé --- Pushed to git since we don't review trivial gnulib updates. .gnulib

Re: [libvirt] [Qemu-devel] [RFC] Defining firmware (OVMF, et al) metadata format & file

On Thu, Mar 08, 2018 at 09:47:27PM +0100, Laszlo Ersek wrote: > On 03/08/18 16:47, Daniel P. Berrangé wrote: > > On Thu, Mar 08, 2018 at 12:10:30PM +0100, Laszlo Ersek wrote: > > >> I suggest (or agree) that the property list be composed of free-form > >> name=value pairs (at least conceptually).

Re: [libvirt] [Qemu-devel] [RFC] Defining firmware (OVMF, et al) metadata format & file

On Fri, Mar 09, 2018 at 04:18:45PM +0100, Laszlo Ersek wrote: > On 03/09/18 15:27, Gerd Hoffmann wrote: > > Hi, > > > >> For OVMF (x86), I guess the initial set of properties should come from > >> the "-D FOO[=BAR]" build flags that OVMF currently supports. (The list > >> might grow or change

Re: [libvirt] [PATCH go-xml] fix type tag for rdp and destkop graphics devices

Thanks, I've pushed this to git now On Sat, Mar 10, 2018 at 06:46:30PM -0500, Ryan Goodfellow wrote: > Signed-off-by: Ryan Goodfellow > > On Mon, Mar 5, 2018 at 4:25 AM, Daniel P. Berrangé > wrote: > > > On Sun, Mar 04, 2018 at 10:41:43AM -0500, Ryan

Re: [libvirt] [PATCH] qemu: different declarations for the same method.

On Fri, Mar 09, 2018 at 12:24:15AM -0300, Julio Faracco wrote: > Recently, this warning is appearing while libvirt is being compiled: > Function 'qemuAssignDeviceDiskAlias' argument order different: > declaration 'vmdef, def' definition 'def, disk' No objection to the patch, but can you say which

Re: [libvirt] [PATCH] qemu: different declarations for the same method.

On Fri, 2018-03-09 at 00:24 -0300, Julio Faracco wrote: > Recently, this warning is appearing while libvirt is being compiled: > Function 'qemuAssignDeviceDiskAlias' argument order different: > declaration 'vmdef, def' definition 'def, disk' > > This commit change the default declaration for

[libvirt] [PATCH] daemonStreamHandleWriteData: Preserve error when aborting stream

The daemonStreamHandleWriteData() function is called whenever server side of stream is able to receive some data. Nevertheless, it calls virStreamSend() (to pass data down to virFDStream) and depending on its return value it may abort the stream. However, the functions it called when doing so are

Re: [libvirt] [PATCH] util, remote: Fixing the sending of stream when length is defined.

On 03/04/2018 08:24 PM, Julio Faracco wrote: > When a length of a file is defined, the responsible thread to send > stream is finishing inappropriately. It is happening because there is > wrong conditional which compares an offset with the length and because > of that the code throws ENOSPC error.

Re: [libvirt] [PATCH 3/3] qemu: Forbid user aliases for USB controllers

On Fri, Mar 09, 2018 at 12:56:13 +0100, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1552127 > > These are bit different than other devices. Their alias also > specify the name of the bus. For instance, if there are these > 'joined' USB devices: > > > >

Re: [libvirt] [PATCH 2/3] conf: Check for user aliases duplicates only

On Fri, Mar 09, 2018 at 12:56:12 +0100, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1553162 > > When validating a device XML config we check if user provided > alias is unique. We do this by maintaining a hash table of device > aliases as we iterated over all devices

Re: [libvirt] [PATCH 1/3] virDomainDeviceValidateAliasForHotplug: Use correct domain defintion

On Fri, Mar 09, 2018 at 12:56:11 +0100, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1553075 > > For some weird reason this function is getting live and > persistent def for domain but then accesses vm->def and > vm->newDef directly. This is rather unsafe as we can be >

Re: [libvirt] [PATCH] libvirt:spec: Require gcc for build

On Mon, Mar 12, 2018 at 06:15:31AM +0100, Michal Privoznik wrote: > According to latest discussion on fedora devel list [1] gcc will > be removed from default buildroot and packages requiring it must > have explicit build dependency, > > 1: >

Re: [libvirt] [PATCH 0/3] Update the virsh pool define/create for vHBA/NPIV

On 03/09/2018 12:31 AM, John Ferlan wrote: > Looks like when adding support in commit 78be2e8b (and the 3 just > before it), I neglected to update the virsh command allow command > line usage of the fields. This series updates virsh in order to > allow adding the fields (as ugly as they are) to

Re: [libvirt] [PATCH] bhyve: fix crash on missing interface model

On 03/11/2018 05:02 PM, Roman Bogorodskiy wrote: > The bhyve driver crashes in bhyveBuildNetArgStr() when > network interface model is not defined. As it has to be provided > explicitly, add a check to report an error if it's missing. > --- > src/bhyve/bhyve_command.c | 6 ++ > 1 file

Re: [libvirt] [PATCH] Fix build with clang 6.0.0

On 03/11/2018 04:38 PM, Roman Bogorodskiy wrote: > Clang 6.0.0 complains when initializing structure with { NULL }: > > conf/domain_addr.c:1494:38: error: missing field 'type' initializer > [-Werror,-Wmissing-field-initializers] > virDomainDeviceInfo nfo = { NULL }; > > Use { 0 } instead to

Re: [libvirt] [PATCH] qemu: Add qemu functions for storage source private data handling

On 03/09/2018 02:52 PM, Peter Krempa wrote: > The qemu driver registered the helpers from util code, but it will be > necessary to format also some qemu-specific data. > > Signed-off-by: Peter Krempa > --- > > This patch conflicts with Michal's persistent reservations