[libvirt] [PATCH] build: Remove --with-xml-catalog-file option

2018-03-23 Thread Rainer Müller
After validation against XHTML 1.0 was dropped in f802c9de0, the XML_CATALOG_FILE is not in use anymore. Therefore the checks in configure can be removed. --- configure.ac | 3 --- m4/virt-xml-catalog.m4 | 33 - 2 files changed, 36 deletions(-) delete

Re: [libvirt] [PATCH] polkit: reintroduce check for pkcheck

2018-03-23 Thread Andrea Bolognani
On Fri, 2018-03-23 at 19:20 +0100, Ján Tomko wrote: > Commit 2499d1a0 was too eager and possibly enabled polkit > on all platforms with D-Bus, regardless of whether they use polkit. > > Reintroduce the usage of pkcheck as a witness for --with-polkit=check, > but do not require it for

Re: [libvirt] [PATCH v3 1/9] qemu: provide support to query the SEV capability

2018-03-23 Thread John Ferlan
On 03/14/2018 11:44 AM, Brijesh Singh wrote: > QEMU version >= 2.12 provides support for launching an encrypted VMs on > AMD x86 platform using Secure Encrypted Virtualization (SEV) feature. > This patch adds support to query the SEV capability from the qemu. > > Reviewed-by: "Daniel P.

Re: [libvirt] [PATCH v3 0/9] x86: Secure Encrypted Virtualization (AMD)

2018-03-23 Thread Brijesh Singh
Hi Daniel and Peter. Any feedback on the series ? -Brijesh On 3/14/18 10:44 AM, Brijesh Singh wrote: > The patch series is test with QEMU recent pull which includes SEV support: > > https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg03826.html > > This patch series provides support for

Re: [libvirt] [PATCH v3 0/6] Add support for video and input devices on S390

2018-03-23 Thread Ján Tomko
On Fri, Mar 23, 2018 at 01:22:37PM -0400, Farhan Ali wrote: [...] Farhan Ali (6): qemu: Introduce a new capability for virtio-gpu-ccw qemu: Add support for virtio-gpu-ccw video device on S390 qemu: Change default video model type to virtio for S390 qemu: Introduce capabilities for virtio

[libvirt] [PATCH] polkit: reintroduce check for pkcheck

2018-03-23 Thread Ján Tomko
Commit 2499d1a0 was too eager and possibly enabled polkit on all platforms with D-Bus, regardless of whether they use polkit. Reintroduce the usage of pkcheck as a witness for --with-polkit=check, but do not require it for --with-polkit=yes. Signed-off-by: Ján Tomko

[libvirt] [PATCH v3 6/6] news: Update for virtio-gpu-ccw and virtio input ccw devices

2018-03-23 Thread Farhan Ali
Document support for the virtio-gpu-ccw and virtio-{keyboard, mouse, tablet}-ccw devices. Signed-off-by: Farhan Ali Reviewed-by: Boris Fiuczynski --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml

[libvirt] [PATCH v3 3/6] qemu: Change default video model type to virtio for S390

2018-03-23 Thread Farhan Ali
S390 guests can only support a virtio-gpu-ccw device as a video device. So set default video model type to VIR_DOMAIN_VIDEO_TYPE_VIRTIO for S390 guests. Signed-off-by: Farhan Ali --- src/qemu/qemu_domain.c | 2 +-

[libvirt] [PATCH v3 1/6] qemu: Introduce a new capability for virtio-gpu-ccw

2018-03-23 Thread Farhan Ali
QEMU on S390 (since v2.11) can support virtio-gpu-ccw device. Let's introduce a new qemu capability for the device. Signed-off-by: Farhan Ali Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_capabilities.c | 5 ++

[libvirt] [PATCH v3 2/6] qemu: Add support for virtio-gpu-ccw video device on S390

2018-03-23 Thread Farhan Ali
QEMU on S390 (since v2.11) can support the virtio-gpu-ccw device, which can be used as a video device. Signed-off-by: Farhan Ali --- docs/formatdomain.html.in| 3 +++ src/qemu/qemu_command.c | 13 ++--

[libvirt] [PATCH v3 4/6] qemu: Introduce capabilities for virtio input ccw devices

2018-03-23 Thread Farhan Ali
QEMU on S390 (since v2.11) can support virtio input ccw devices. Introduce qemu capabilities for these devices. Signed-off-by: Farhan Ali Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_capabilities.c | 8

[libvirt] [PATCH v3 5/6] qemu: Add support for virtio input ccw devices

2018-03-23 Thread Farhan Ali
QEMU on S390 (since v2.11) can support virtio input ccw devices. So build the qemu command line for ccw devices. Also add test cases for virtio-{keyboard, mouse, tablet}-ccw. Signed-off-by: Farhan Ali Signed-off-by: Boris Fiuczynski ---

[libvirt] [PATCH v3 0/6] Add support for video and input devices on S390

2018-03-23 Thread Farhan Ali
Hi, This patch series adds Libvirt support for video and input devices for QEMU guests on S390. QEMU v2.11.0 added support for the virtio-gpu-ccw device [1] and virtio-{keyboard, mouse, tablet}-ccw devices [2], which can be used as video and input devices respectively. Thanks Farhan [1]

Re: [libvirt] [PATCH 0/3] tests: Improvements and cleanups to capabilities testing

2018-03-23 Thread Ján Tomko
On Fri, Mar 23, 2018 at 03:05:38PM +0100, Andrea Bolognani wrote: *** BLURB NOW OR FOREVER HOLD YOUR PEACE *** Andrea Bolognani (3): tests: domaincaps: Order by architecture tests: domaincaps: Add QEMU 2.12 tests: qemucapabilities: Drop mostly duplicated data ACK Jan signature.asc

[libvirt] [dbus PATCH v2 1/6] virtDBusDomainGetVcpus: Should be implemented as method and not as property

2018-03-23 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 5 - src/domain.c| 51 ++--- test/test_domain.py | 3 ++- 3 files changed, 35 insertions(+), 24 deletions(-) diff --git

[libvirt] [dbus PATCH v2 0/6] Use API calls supporting flags

2018-03-23 Thread Katerina Koukiou
* Use API calls with flags parameter when possible * Since libvirt-dbus API doesn't follow strictly the naming of libvirt API there should be documentation regarding which libvirt API is used for each libvirt-dbus API. This patch introduces documentation annotations in D-Bus Interface XML

[libvirt] [dbus PATCH v2 2/6] virtDBusDomainShutdown: Use virDomainShutdownFlags instead of virDomainShutdown

2018-03-23 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 4 +++- src/domain.c| 5 - test/test_domain.py | 6 +++--- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml

[libvirt] [dbus PATCH v2 4/6] virtDBusDomainUndefine: Use virDomainUndefineFlags instead of virDomainUndefine

2018-03-23 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 4 +++- src/domain.c| 5 - test/test_domain.py | 4 ++-- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml

[libvirt] [dbus PATCH v2 5/6] virtDBusDomainDestroy: Use virDomainDestroyFlags instead of virDomainDestroy

2018-03-23 Thread Katerina Koukiou
We need to catch Exceptions when testing this API call, since virDomainDestroyFlags will be supported in test-driver in 4.2.0 libvirt release. Better version checks for unsupported API calls need to be done in all tests, but it's not relevant to this commit. When virConnectGetVersion will be

[libvirt] [dbus PATCH v2 6/6] Use Documentation Annotations in D-Bus Interface XML

2018-03-23 Thread Katerina Koukiou
Since we don't follow the exact naming of libvirt API for libvirt-dbus, documentation should clarify which API call is used internally each time. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 24 data/org.libvirt.Domain.xml | 66

[libvirt] [dbus PATCH v2 3/6] virtDBusDomainCreate: Use virDomainCreateWithFlags instead of virDomainCreate

2018-03-23 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 4 +++- src/domain.c| 5 - test/test_domain.py | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index

[libvirt] [PATCH sandbox] Python 3 renamed string.lowercase to string.ascii_lowercase

2018-03-23 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- libvirt-sandbox/image/cli.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-sandbox/image/cli.py b/libvirt-sandbox/image/cli.py index d2035de..605183c 100644 --- a/libvirt-sandbox/image/cli.py +++

[libvirt] [PATCH sandbox] Fix argparser incompatibilities with newer python 3

2018-03-23 Thread Daniel P . Berrangé
Python 3 changes such that if no subparser command is listed, it just throws an error. To get back the old behavior we need to set the 'required' attribute and a dest name. Since we treat 'debug' as a global attribute we need to set that on the top level parser too, otherwise we get a missing

Re: [libvirt] [PATCHv2 6/6] qemu: refresh vcpu halted state only via query-cpus-fast

2018-03-23 Thread John Ferlan
On 03/05/2018 06:44 AM, Viktor Mihajlovski wrote: > In order to not affect running VMs, refreshing the halted state > is only performed if QEMU supports the query-cpus-fast QAPI. > > Signed-off-by: Viktor Mihajlovski > Reviewed-by: Boris Fiuczynski

Re: [libvirt] [PATCHv2 5/6] tests: add testcase for s390 query-cpus-fast

2018-03-23 Thread John Ferlan
On 03/05/2018 06:44 AM, Viktor Mihajlovski wrote: > The s390 testcase verifies that the s390-specific cpu-state > field is correctly mapped to the halted property. > > Since a few of the x86 and ppc testcases return "halted": "true" > it was necessary to update the respective .data files. > >

Re: [libvirt] [PATCHv2 4/6] qemu: add architecture-specific CPU info handling

2018-03-23 Thread John Ferlan
On 03/05/2018 06:44 AM, Viktor Mihajlovski wrote: > Extract architecture specific data from query-cpus[-fast] if > available. A new function qemuMonitorJSONExtractCPUArchInfo() > uses a call-back table to find and call architecture-specific > extraction handlers. > > Initially, there's a

Re: [libvirt] [PATCHv2 2/6] qemu: use query-cpus-fast in JSON monitor

2018-03-23 Thread John Ferlan
On 03/05/2018 06:44 AM, Viktor Mihajlovski wrote: > Use query-cpus-fast instead of query-cpus if supported by QEMU. > Based on the QEMU_CAPS_QUERY_CPUS_FAST capability. > > Signed-off-by: Viktor Mihajlovski > --- > src/qemu/qemu_domain.c | 12 ++-- >

Re: [libvirt] [PATCHv2 3/6] tests: add qemumonitorjson tests for query-cpus-fast

2018-03-23 Thread John Ferlan
On 03/05/2018 06:44 AM, Viktor Mihajlovski wrote: > Extended the json monitor test program with support for query-cpus-fast > and added a sample file set for x86 data obtained using the it. > > Signed-off-by: Viktor Mihajlovski > --- >

Re: [libvirt] [PATCHv2 1/6] qemu: add capability detection for query-cpus-fast

2018-03-23 Thread John Ferlan
On 03/05/2018 06:44 AM, Viktor Mihajlovski wrote: > Detect whether QEMU supports the QMP query-cpus-fast API > and set QEMU_CAPS_QUERY_CPUS_FAST in this case. > > Signed-off-by: Viktor Mihajlovski > Reviewed-by: Boris Fiuczynski >

[libvirt] [PATCH sandbox] rpm: fix references to python 2 packages / files

2018-03-23 Thread Daniel P . Berrangé
Since we switched to python 3, we should have deps on the python 3 based packages, and look at the python 3 sitelib directory. Signed-off-by: Daniel P. Berrangé --- libvirt-sandbox.spec.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[libvirt] [PATCH sandbox] Explicitly check for python3 in configure.ac

2018-03-23 Thread Daniel P . Berrangé
A bare AM_PATH_PYTHON statement is satisfied by any version of python >= 2.0.0, but we converted to Python 3, so should be explicit about it. Signed-off-by: Daniel P. Berrangé --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac

Re: [libvirt] [PATCH] conf: avoid reporting errors when network driver is disabled

2018-03-23 Thread Daniel P . Berrangé
On Fri, Mar 23, 2018 at 11:27:37AM -0400, Laine Stump wrote: > On 03/23/2018 07:46 AM, Daniel P. Berrangé wrote: > > In previous releases all these methods were a no-op if the network > > driver is disabled. These helper methods are called unconditionally for > > all types of network interface, so

Re: [libvirt] [PATCH] conf: avoid reporting errors when network driver is disabled

2018-03-23 Thread Laine Stump
On 03/23/2018 07:46 AM, Daniel P. Berrangé wrote: > In previous releases all these methods were a no-op if the network > driver is disabled. These helper methods are called unconditionally for > all types of network interface, so must be no-ops if missing. Other code > will already generate an

Re: [libvirt] [PATCH python] Disable Python 2 on future RHEL and Fedora > 29

2018-03-23 Thread Jiri Denemark
On Fri, Mar 23, 2018 at 15:01:54 +, Daniel P. Berrangé wrote: > The end of Python 2 is nearing, so declare when it will be removed > from libvirt Python binding RPMs. > > NB, this doesn't imply we'll be removing py2 support from upstream > libvirt-python on the same timeframe - we'll consider

Re: [libvirt] [dbus PATCH 02/10] GetVcpus API method: Renamed to GetVcpusFlags

2018-03-23 Thread Katerina Koukiou
Right, as seen here [1], "documentation can also be added as annotation elements in the XML". I 'll repost, thanks. [1] https://dbus.freedesktop.org/doc/dbus-api-design.html#documentation On Fri, Mar 23, 2018 at 3:51 PM, Daniel P. Berrangé wrote: > On Fri, Mar 23, 2018 at

[libvirt] [PATCH python] Disable Python 2 on future RHEL and Fedora > 29

2018-03-23 Thread Daniel P . Berrangé
The end of Python 2 is nearing, so declare when it will be removed from libvirt Python binding RPMs. NB, this doesn't imply we'll be removing py2 support from upstream libvirt-python on the same timeframe - we'll consider what todo wrt that when upstream Python 2 finally goes EOL. Signed-off-by:

Re: [libvirt] [dbus PATCH 02/10] GetVcpus API method: Renamed to GetVcpusFlags

2018-03-23 Thread Daniel P . Berrangé
On Fri, Mar 23, 2018 at 03:43:45PM +0100, Pavel Hrdina wrote: > On Fri, Mar 23, 2018 at 02:25:25PM +, Daniel P. Berrangé wrote: > > On Fri, Mar 23, 2018 at 03:16:59PM +0100, Katerina Koukiou wrote: > > > Same for internal virtDBusDomainGetVcpus: > > > Renamed to virtDBusDomainGetVcpusFlags > >

Re: [libvirt] [PATCH] qemu: Build smartcard command line more wisely

2018-03-23 Thread Andrea Bolognani
On Fri, 2018-03-23 at 14:28 +0100, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1558317 > > Similarly to b133fac356324c3 we need to look up alias of CCID > controller when constructing smartcard command line instead of > relying on broken assumption it will always be

Re: [libvirt] [dbus PATCH 02/10] GetVcpus API method: Renamed to GetVcpusFlags

2018-03-23 Thread Pavel Hrdina
On Fri, Mar 23, 2018 at 02:25:25PM +, Daniel P. Berrangé wrote: > On Fri, Mar 23, 2018 at 03:16:59PM +0100, Katerina Koukiou wrote: > > Same for internal virtDBusDomainGetVcpus: > > Renamed to virtDBusDomainGetVcpusFlags > > > > Following naming from libvirt API. > > > > Signed-off-by:

Re: [libvirt] [dbus PATCH 02/10] GetVcpus API method: Renamed to GetVcpusFlags

2018-03-23 Thread Daniel P . Berrangé
On Fri, Mar 23, 2018 at 03:16:59PM +0100, Katerina Koukiou wrote: > Same for internal virtDBusDomainGetVcpus: > Renamed to virtDBusDomainGetVcpusFlags > > Following naming from libvirt API. > > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 2 +- >

[libvirt] [dbus PATCH 03/10] virtDBusDomainShutdown: Use virDomainShutdownFlags instead of virDomainShutdown

2018-03-23 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 4 +++- src/domain.c| 5 - test/test_domain.py | 6 +++--- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml

[libvirt] [dbus PATCH 07/10] virtDBusDomainUndefine: Use virDomainUndefineFlags instead of virDomainUndefine

2018-03-23 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 4 +++- src/domain.c| 5 - test/test_domain.py | 4 ++-- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml

[libvirt] [dbus PATCH 05/10] virtDBusDomainCreate: Use virDomainCreateWithFlags instead of virDomainCreate

2018-03-23 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 4 +++- src/domain.c| 5 - test/test_domain.py | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index

[libvirt] [dbus PATCH 02/10] GetVcpus API method: Renamed to GetVcpusFlags

2018-03-23 Thread Katerina Koukiou
Same for internal virtDBusDomainGetVcpus: Renamed to virtDBusDomainGetVcpusFlags Following naming from libvirt API. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 2 +- src/domain.c| 17 - test/test_domain.py | 2

[libvirt] [dbus PATCH 01/10] virtDBusDomainGetVcpus: Should be implemented as method and not as property

2018-03-23 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 5 - src/domain.c| 51 ++--- test/test_domain.py | 3 ++- 3 files changed, 35 insertions(+), 24 deletions(-) diff --git

[libvirt] [dbus PATCH 09/10] virtDBusDomainDestroy: Use virDomainDestroyFlags instead of virDomainDestroy

2018-03-23 Thread Katerina Koukiou
We need to catch Exceptions when testing this API call, since virDomainDestroyFlags will be supported in test-driver in 4.2.0 libvirt release. Better version checks for unsupported API calls need to be done in all tests, but it's not relevant to this commit. When virConnectGetVersion will be

[libvirt] [dbus PATCH 10/10] Destroy API method: Renamed to DestroyFlags

2018-03-23 Thread Katerina Koukiou
Same for internal virtDBusDomainDestroy: Renamed to virtDBusDomainDestroyFlags Following naming from libvirt API. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 2 +- src/domain.c| 16 test/test_domain.py | 2 +-

[libvirt] [dbus PATCH 08/10] Undefine API method: Renamed to UndefineFlags

2018-03-23 Thread Katerina Koukiou
Same for internal virtDBusDomainUndefine: Renamed to virtDBusDomainUndefineFlags Following naming from libvirt API Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 2 +- src/domain.c| 16 test/test_domain.py | 4

[libvirt] [dbus PATCH 04/10] Shutdown API method: Renamed to ShutdownFlags

2018-03-23 Thread Katerina Koukiou
Same for internal virtDBusDomainShutdown: Renamed to virtDBusDomainShutdownFlags Following naming from libvirt API. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 2 +- src/domain.c| 16 test/test_domain.py | 6

[libvirt] [dbus PATCH 06/10] Create API method: Renamed to CreateWithFlags

2018-03-23 Thread Katerina Koukiou
Same for internal virtDBusDomainCreate: Renamed to virtDBusDomainCreatewithFlags Following naming from libvirt API. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 2 +- src/domain.c| 16 test/test_domain.py | 2

[libvirt] [dbus PATCH 00/10] *** Use API calls supporting flags ***

2018-03-23 Thread Katerina Koukiou
* Replace all API calls to support flags where possible. * Replace libvirt-dbus API method names to follow naming of libvirt API. * Change type of virtDBusDomainGetVcpus from property to method. Katerina Koukiou (10): virtDBusDomainGetVcpus: Should be implemented as method and not as

[libvirt] [PATCH 3/3] tests: qemucapabilities: Drop mostly duplicated data

2018-03-23 Thread Andrea Bolognani
When GIC support was introduced (QEMU 2.6 timeframe) we needed to make sure both GICv2 hardware and GICv3 hardware were handled correctly, and that was achieved by having separate capabilities data for each. Now that we have capabilities data for several QEMU versions we can stop storing data for

[libvirt] [PATCH 1/3] tests: domaincaps: Order by architecture

2018-03-23 Thread Andrea Bolognani
Test cases in qemucapabilitiestest are ordered by architecture first, then by QEMU version. Use the same order here. Signed-off-by: Andrea Bolognani --- tests/domaincapstest.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff

[libvirt] [PATCH 2/3] tests: domaincaps: Add QEMU 2.12

2018-03-23 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- .../qemu_2.12.0-virt.aarch64.xml | 119 + tests/domaincapsschemadata/qemu_2.12.0.ppc64.xml | 81 tests/domaincapsschemadata/qemu_2.12.0.s390x.xml | 78 +++

[libvirt] [PATCH 0/3] tests: Improvements and cleanups to capabilities testing

2018-03-23 Thread Andrea Bolognani
*** BLURB NOW OR FOREVER HOLD YOUR PEACE *** Andrea Bolognani (3): tests: domaincaps: Order by architecture tests: domaincaps: Add QEMU 2.12 tests: qemucapabilities: Drop mostly duplicated data ...rt.aarch64.xml => qemu_2.12.0-virt.aarch64.xml} | 5 +- ...icv2-virt.aarch64.xml =>

[libvirt] [PATCH] qemu: domain: Drop declaration of qemuDomainDefValidateDisk

2018-03-23 Thread Peter Krempa
There is no such function in our code. Commit abca72faa49 added it spuriously. Signed-off-by: Peter Krempa --- Pushed as trivial. src/qemu/qemu_domain.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index

Re: [libvirt] Call to virDomainIsActive hangs forever

2018-03-23 Thread Michal Privoznik
On 03/22/2018 05:10 PM, Mathieu Tarral wrote: > Hi ! > > I'm submitting my messages on this mailing list to request a bit of > help on a case that I have > where a Python application makes a call to virDomainIsActive, and the > call never returns. > > I have tried to investigate, but as there

Re: [libvirt] [PATCH 1/4] secret: Return with locked obj from virSecretObjListRemove

2018-03-23 Thread John Ferlan
On 03/22/2018 05:44 AM, Erik Skultety wrote: > On Wed, Mar 21, 2018 at 11:53:32AM -0400, John Ferlan wrote: >> Rather than unlock the object that was expected to be locked on >> input, let the caller perform the unlock or more succinctly a >> virSecretObjEndAPI on the object which will perform

[libvirt] [PATCH] qemu: Build smartcard command line more wisely

2018-03-23 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1558317 Similarly to b133fac356324c3 we need to look up alias of CCID controller when constructing smartcard command line instead of relying on broken assumption it will always be 'ccid0'. After user aliases it can be anything. Signed-off-by: Michal

Re: [libvirt] [PATCH] lxc: report error message raised by the failing function

2018-03-23 Thread Daniel P . Berrangé
On Fri, Mar 23, 2018 at 01:30:22PM +0100, Cedric Bosdonnat wrote: > Hello Prafull, > > On Thu, 2018-03-22 at 20:04 +0530, Prafull wrote: > > The code that calls VIR_WARN after a function fails, doesn't > > report the error message raised by the failing function. > > Such error messages are now

Re: [libvirt] [PATCH] lxc: report error message raised by the failing function

2018-03-23 Thread Cedric Bosdonnat
Hello Prafull, On Thu, 2018-03-22 at 20:04 +0530, Prafull wrote: > The code that calls VIR_WARN after a function fails, doesn't > report the error message raised by the failing function. > Such error messages are now reported in lxc/lxc_driver.c > > Signed-off-by: Prafullkumar T

Re: [libvirt] Call to virDomainIsActive hangs forever

2018-03-23 Thread Erik Skultety
On Thu, Mar 22, 2018 at 06:10:49PM +0200, Mathieu Tarral wrote: > Hi ! > > I'm submitting my messages on this mailing list to request a bit of > help on a case that I have > where a Python application makes a call to virDomainIsActive, and the > call never returns. > > I have tried to investigate,

Re: [libvirt] [PATCH] remote: remove some __sun conditionals

2018-03-23 Thread Andrea Bolognani
On Fri, 2018-03-23 at 11:02 +, Daniel P. Berrangé wrote: > The libvirtd daemon has some arbitrary logic to drop privileges, but > only on Solaris platforms. This was added during Xen days, when Xen was > the only driver running in libvirtd. There's no expectation or testing > that this works

Re: [libvirt] [dbus PATCH v2] Convert testsuite from unittest to pytest

2018-03-23 Thread Pavel Hrdina
On Thu, Mar 22, 2018 at 07:22:40PM +0100, Katerina Koukiou wrote: > Move to pytest to take advantage of: > * tests parametrization > * pdb support > * more compact tests - not forcing large test classes > > Signed-off-by: Katerina Koukiou > --- > HACKING.md |

Re: [libvirt] [PATCH v2 2/2] docs: introduce libvirt-dbus binding

2018-03-23 Thread Daniel P . Berrangé
On Fri, Mar 23, 2018 at 12:55:58PM +0100, Pavel Hrdina wrote: > libvirt-dbus is a new binding that wraps libvirt API into D-Bus calls. > > Signed-off-by: Pavel Hrdina > --- > docs/bindings.html.in | 13 ++- > docs/dbus.html.in | 102 >

Re: [libvirt] [PATCH v2 1/2] docs: fix a typo in docs.html page

2018-03-23 Thread Daniel P . Berrangé
On Fri, Mar 23, 2018 at 12:55:57PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > docs/docs.html.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/docs.html.in b/docs/docs.html.in > index a8d544f83f..ee521c7460 100644 > ---

[libvirt] [PATCH v2 1/2] docs: fix a typo in docs.html page

2018-03-23 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- docs/docs.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/docs.html.in b/docs/docs.html.in index a8d544f83f..ee521c7460 100644 --- a/docs/docs.html.in +++ b/docs/docs.html.in @@ -59,7 +59,7 @@ c#,

[libvirt] [PATCH v2 2/2] docs: introduce libvirt-dbus binding

2018-03-23 Thread Pavel Hrdina
libvirt-dbus is a new binding that wraps libvirt API into D-Bus calls. Signed-off-by: Pavel Hrdina --- docs/bindings.html.in | 13 ++- docs/dbus.html.in | 102 + docs/docs.html.in | 6 ++-

[libvirt] [PATCH v2 0/2] introduce libvirt-dbus binding

2018-03-23 Thread Pavel Hrdina
Pavel Hrdina (2): docs: fix a typo in docs.html page docs: introduce libvirt-dbus binding docs/bindings.html.in | 13 ++- docs/dbus.html.in | 102 + docs/docs.html.in | 8 ++-- docs/downloads.html.in | 15 4 files

[libvirt] [PATCH] conf: avoid reporting errors when network driver is disabled

2018-03-23 Thread Daniel P . Berrangé
In previous releases all these methods were a no-op if the network driver is disabled. These helper methods are called unconditionally for all types of network interface, so must be no-ops if missing. Other code will already generate an error if the network driver is disabled and a NIC with

Re: [libvirt] [PATCH RFC] storage: Remove 'cow' disk format

2018-03-23 Thread Peter Krempa
On Fri, Mar 23, 2018 at 11:37:17 +, Daniel Berrange wrote: > On Fri, Mar 23, 2018 at 12:32:29PM +0100, Peter Krempa wrote: > > There's no tests for this format and nothing seems to specifically care > > about this format. QEMU does not even recognize it. Remove it completely. > > This format

Re: [libvirt] [PATCH] docs: introduce libvirt-dbus binding

2018-03-23 Thread Pavel Hrdina
On Fri, Mar 23, 2018 at 11:30:56AM +, Daniel P. Berrangé wrote: > On Fri, Mar 23, 2018 at 12:26:56PM +0100, Pavel Hrdina wrote: > > On Fri, Mar 23, 2018 at 10:15:58AM +, Daniel P. Berrangé wrote: > > > On Fri, Mar 23, 2018 at 08:35:34AM +0100, Pavel Hrdina wrote: > > > > libvirt-dbus is a

Re: [libvirt] [PATCH RFC] storage: Remove 'cow' disk format

2018-03-23 Thread Daniel P . Berrangé
On Fri, Mar 23, 2018 at 12:32:29PM +0100, Peter Krempa wrote: > There's no tests for this format and nothing seems to specifically care > about this format. QEMU does not even recognize it. Remove it completely. This format is from the User Mode Linux driver, not QEMU. > Signed-off-by: Peter

[libvirt] [PATCH RFC] storage: Remove 'cow' disk format

2018-03-23 Thread Peter Krempa
There's no tests for this format and nothing seems to specifically care about this format. QEMU does not even recognize it. Remove it completely. Signed-off-by: Peter Krempa --- docs/schemas/storagecommon.rng | 1 - src/util/virstoragefile.c | 31

Re: [libvirt] [PATCH] docs: introduce libvirt-dbus binding

2018-03-23 Thread Daniel P . Berrangé
On Fri, Mar 23, 2018 at 12:26:56PM +0100, Pavel Hrdina wrote: > On Fri, Mar 23, 2018 at 10:15:58AM +, Daniel P. Berrangé wrote: > > On Fri, Mar 23, 2018 at 08:35:34AM +0100, Pavel Hrdina wrote: > > > libvirt-dbus is a new binding that wraps libvirt API into D-Bus calls. > > > > > >

Re: [libvirt] [PATCH] docs: introduce libvirt-dbus binding

2018-03-23 Thread Pavel Hrdina
On Fri, Mar 23, 2018 at 10:15:58AM +, Daniel P. Berrangé wrote: > On Fri, Mar 23, 2018 at 08:35:34AM +0100, Pavel Hrdina wrote: > > libvirt-dbus is a new binding that wraps libvirt API into D-Bus calls. > > > > Signed-off-by: Pavel Hrdina > > --- > >

Re: [libvirt] [PATCH] docs: introduce libvirt-dbus binding

2018-03-23 Thread Pavel Hrdina
On Fri, Mar 23, 2018 at 10:38:46AM +0100, Ján Tomko wrote: > On Fri, Mar 23, 2018 at 08:35:34AM +0100, Pavel Hrdina wrote: > > libvirt-dbus is a new binding that wraps libvirt API into D-Bus calls. > > > > Signed-off-by: Pavel Hrdina > > --- > > docs/bindings.html.in | 4

[libvirt] [PATCH] remote: remove some __sun conditionals

2018-03-23 Thread Daniel P . Berrangé
The libvirtd daemon has some arbitrary logic to drop privileges, but only on Solaris platforms. This was added during Xen days, when Xen was the only driver running in libvirtd. There's no expectation or testing that this works with the new libxl stack, nor whether dropping privileges breaks any

Re: [libvirt] [PATCH] docs: introduce libvirt-dbus binding

2018-03-23 Thread Daniel P . Berrangé
On Fri, Mar 23, 2018 at 08:35:34AM +0100, Pavel Hrdina wrote: > libvirt-dbus is a new binding that wraps libvirt API into D-Bus calls. > > Signed-off-by: Pavel Hrdina > --- > docs/bindings.html.in | 4 ++ > docs/dbus.html.in | 102 >

Re: [libvirt] [PATCH 1/1] Add KVM on Z to Planet virttools

2018-03-23 Thread Martin Kletzander
On Thu, Mar 22, 2018 at 09:52:38PM +0100, Stefan Raspl wrote: Signed-off-by: Stefan Raspl --- updater/virt-tools/config.ini | 3 +++ 1 file changed, 3 insertions(+) Hi, thanks for sending the patch. No need to add cover letter if it's one patch only. diff --git

Re: [libvirt] [PATCH 1/1] Add KVM on Z to Planet virttools

2018-03-23 Thread Daniel P . Berrangé
On Thu, Mar 22, 2018 at 09:52:38PM +0100, Stefan Raspl wrote: > Signed-off-by: Stefan Raspl > --- > updater/virt-tools/config.ini | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/updater/virt-tools/config.ini b/updater/virt-tools/config.ini > index

[libvirt] [jenkins-ci PATCH] guests: Enable ccache

2018-03-23 Thread Andrea Bolognani
We install ccache on all guests where it's available, but Fedora is the only one actually using it at the moment, because it enables it automatically. Tweak the user's profile so that compilation will use ccache if it's installed. Signed-off-by: Andrea Bolognani ---

Re: [libvirt] [PATCH] docs: introduce libvirt-dbus binding

2018-03-23 Thread Ján Tomko
On Fri, Mar 23, 2018 at 08:35:34AM +0100, Pavel Hrdina wrote: libvirt-dbus is a new binding that wraps libvirt API into D-Bus calls. Signed-off-by: Pavel Hrdina --- docs/bindings.html.in | 4 ++ docs/dbus.html.in | 102

[libvirt] ANNOUNCE: libvirt-dbus 0.0.1 released

2018-03-23 Thread Pavel Hrdina
I'm happy to announce the release of libvirt-dbus 0.0.1. libvirt-dbus wraps libvirt API to provide high-level object-oriented API better suited for dbus-based applications. This is a first release which should be considered as unstable release since we don't promise API stability. You can

[libvirt] [PATCH] docs: introduce libvirt-dbus binding

2018-03-23 Thread Pavel Hrdina
libvirt-dbus is a new binding that wraps libvirt API into D-Bus calls. Signed-off-by: Pavel Hrdina --- docs/bindings.html.in | 4 ++ docs/dbus.html.in | 102 + docs/docs.html.in | 1 + docs/downloads.html.in |

Re: [libvirt] [PATCH v4 5/5] virt-aa-helper: test: check for expected profile content

2018-03-23 Thread Christian Ehrhardt
On Thu, Mar 22, 2018 at 5:35 PM, Jamie Strandboge wrote: > On Wed, 2018-03-21 at 22:22 +0100, Christian Ehrhardt wrote: > > So far the virt-aa-helper tests only checked the return code and > > thereby > > catched aborts like issues failing to parse the XML. But there is one

Re: [libvirt] [PATCH] tools: fix variable scope in in check_guests_shutdown

2018-03-23 Thread Christian Ehrhardt
On Thu, Mar 22, 2018 at 5:26 PM, Martin Kletzander wrote: > On Mon, Mar 19, 2018 at 12:44:31PM +0100, Christian Ehrhardt wrote: > >> libvirt-guests.sh when run with more active guests than requested to >> shut down in parallel will run until it times out only shutting down