Re: [libvirt] [PATCH libvirt v2 9/9] remote: shrink the critical sections

On 04/26/2018 12:40 PM, Marc Hartmayer wrote: > On Thu, Apr 26, 2018 at 05:08 PM +0200, John Ferlan > wrote: >> On 04/12/2018 08:41 AM, Marc Hartmayer wrote: >>> No lock is required to access 'priv->conn' therefore we can shrink the >>> critical sections. >>> >>>

Re: [libvirt] [PATCH libvirt v2 4/9] remote: Use domainClientEventCallbacks for remoteReplayConnectionClosedEvent

On 04/26/2018 12:27 PM, Marc Hartmayer wrote: > On Thu, Apr 26, 2018 at 05:07 PM +0200, John Ferlan > wrote: >> On 04/12/2018 08:40 AM, Marc Hartmayer wrote: >>> This allows us to get rid of another usage of the global variable >>> remoteProgram. >>> >>> Signed-off-by: Marc

Re: [libvirt] [PATCH libvirt v2 1/9] virConnectRegisterCloseCallback: Cleanup 'opaque' if there is no connectRegisterCloseCallback

On 04/26/2018 12:09 PM, Marc Hartmayer wrote: > On Thu, Apr 26, 2018 at 05:06 PM +0200, John Ferlan > wrote: >> On 04/12/2018 08:40 AM, Marc Hartmayer wrote: >>> The commit 'close callback: move it to driver' (88f09b75eb99) moved >>> the responsibility for the close

Re: [libvirt] [PATCH v2 2/6] tpm: Add support for external swtpm TPM emulator

On 04/26/2018 10:31 AM, Stefan Berger wrote: > On 04/26/2018 09:38 AM, Stefan Berger wrote: >> On 04/25/2018 01:13 PM, John Ferlan wrote: +virTPMCreateEmulatorSocket(const char *swtpmStateDir, const char *vmname) +{ +    char *path = NULL; + +   

Re: [libvirt] [PATCH v2 2/6] tpm: Add support for external swtpm TPM emulator

[...] >>>   >> Two blank lines between new functions and we like Free instead of Delete >> unless of course this is something more specific... > > This is something more specifc. The TPM emulator writes state into files > in a dedicated directory. That state would normally be written into >

Re: [libvirt] [PATCH v2 1/6] tpm: Enable TPM CRB interface

[...] > diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c > index 308d71f..2992197 100644 > --- a/tests/qemuxml2argvtest.c > +++ b/tests/qemuxml2argvtest.c > @@ -2134,6 +2134,9 @@ mymain(void) > DO_TEST("tpm-passthrough", >   

Re: [libvirt] [PATCH v4 5/5] qemu: Introduce memoryBacking/discard

On 04/26/2018 09:34 PM, Peter Krempa wrote: > On Thu, Apr 26, 2018 at 18:00:15 +0200, Michal Privoznik wrote: >> On 04/26/2018 02:56 PM, Ján Tomko wrote: >>> On Fri, Apr 20, 2018 at 11:09:31AM +0200, Michal Privoznik wrote: > > [...] > >> So what was the showstopper for this patch? I wanted to

Re: [libvirt] [PATCH v4 5/5] qemu: Introduce memoryBacking/discard

On Thu, Apr 26, 2018 at 18:00:15 +0200, Michal Privoznik wrote: > On 04/26/2018 02:56 PM, Ján Tomko wrote: > > On Fri, Apr 20, 2018 at 11:09:31AM +0200, Michal Privoznik wrote: [...] > So what was the showstopper for this patch? I wanted to get this in > upcoming release (and freeze is

Re: [libvirt] [PATCH 0/3] sample: vfio mdev display devices.

* Kirti Wankhede (kwankh...@nvidia.com) wrote: > > > On 4/26/2018 1:22 AM, Dr. David Alan Gilbert wrote: > > * Alex Williamson (alex.william...@redhat.com) wrote: > >> On Wed, 25 Apr 2018 21:00:39 +0530 > >> Kirti Wankhede wrote: > >> > >>> On 4/25/2018 4:29 AM, Alex

Re: [libvirt] [PATCH 0/3] sample: vfio mdev display devices.

On 4/26/2018 1:22 AM, Dr. David Alan Gilbert wrote: > * Alex Williamson (alex.william...@redhat.com) wrote: >> On Wed, 25 Apr 2018 21:00:39 +0530 >> Kirti Wankhede wrote: >> >>> On 4/25/2018 4:29 AM, Alex Williamson wrote: On Wed, 25 Apr 2018 01:20:08 +0530 Kirti

Re: [libvirt] [RFC 2/3] lxc: Move up virLXCControllerAppendNBDPids

On 04/15/2018 05:25 PM, Radostin Stoyanov wrote: > There is no functional change in this patch. > > It only moves virLXCControllerAppendNBDPids above > virLXCControllerSetupNBDDeviceFS. > --- > src/lxc/lxc_controller.c | 96 > > 1 file changed,

Re: [libvirt] [RFC 3/3] lxc: Mount NBD devices before clone

On 04/15/2018 05:25 PM, Radostin Stoyanov wrote: > When user-namespace is enabled we are not allowed > to mount block/NBD devices. > > Instead, mount /dev/nbdX to /run/libvirt/lxc/.root > and set: > > fs->src->path = /run/libvirt/lxc/.root > fs->type = VIR_DOMAIN_FS_TYPE_MOUNT >

Re: [libvirt] [RFC 1/3] lxc: Make lxcContainerMountFSBlock non static

On 04/15/2018 05:25 PM, Radostin Stoyanov wrote: > --- > src/lxc/lxc_container.c | 5 + > src/lxc/lxc_container.h | 4 > 2 files changed, 5 insertions(+), 4 deletions(-) > Hopefully mprivozn can take a look at this series as he knows most about namespaces... Not sure if he's just

Re: [libvirt] [PATCH] bhyve: add support for passing stdin to loader

On 26 Apr 2018, at 18:38, John Ferlan wrote: > On 04/13/2018 03:27 PM, Fabian Freyer wrote: >> This commit adds the node to the domain definition, >> with the following semantics: >> >> To pass standard input verbatim to the bootloader, set >> >> some stdin >> >> Multiline standard input

[libvirt] [PATCH v3 0/3] Support tpm-crb TPM interface for QEMU

This patch series adds support for the recently added tpm-crb TPM interface for QEMU (2.12). Stefan Stefan Berger (3): tpm: Enable TPM CRB interface in the domain XML and test it qemu: Extend the capabilities with tpm-crb device tests: add test case for tpm-crb QEMU device command line

[libvirt] [PATCH v3 3/3] tests: add test case for tpm-crb QEMU device command line

Add a test case for the formation of the tpm-crb QEMU device command line. Signed-off-by: Stefan Berger --- src/qemu/qemu_command.c | 16 ++- tests/qemuxml2argvdata/tpm-passthrough-crb.args | 26 +

[libvirt] [PATCH v3 2/3] qemu: Extend the capabilities with tpm-crb device

QEMU on x86_64 (since v2.12) can support tpm-crb devices. Introduce qemu capabilities for this device. Signed-off-by: Stefan Berger --- src/qemu/qemu_capabilities.c | 5 + src/qemu/qemu_capabilities.h | 1 +

[libvirt] [PATCH v3 1/3] tpm: Enable TPM CRB interface in the domain XML and test it

Enable the TPM CRB to be specified in the domain XML. This now allows to describe the TPM device like this: Extend the XML schema to also allow tpm-crb. Extend the documentation. Add a test case for testing the XML parser and formatter. Signed-off-by: Stefan Berger

Re: [libvirt] [PATCH libvirt v2 9/9] remote: shrink the critical sections

On Thu, Apr 26, 2018 at 05:08 PM +0200, John Ferlan wrote: > On 04/12/2018 08:41 AM, Marc Hartmayer wrote: >> No lock is required to access 'priv->conn' therefore we can shrink the >> critical sections. >> >> Signed-off-by: Marc Hartmayer >>

Re: [libvirt] [PATCH] bhyve: add support for passing stdin to loader

On 04/13/2018 03:27 PM, Fabian Freyer wrote: > This commit adds the node to the domain definition, > with the following semantics: > > To pass standard input verbatim to the bootloader, set > > some stdin > > Multiline standard input can be set using a CDATA tag: > > > > Standard

Re: [libvirt] [PATCH] nwfilter: increase pcap buffer size to be compatible with TPACKET_V3

On Thu, Apr 26, 2018 at 5:55 PM, Laine Stump wrote: > On 04/26/2018 04:38 AM, Daniel P. Berrangé wrote: > > On Thu, Apr 26, 2018 at 08:09:47AM +0200, Christian Ehrhardt wrote: > > On Wed, Apr 25, 2018 at 11:25 PM, Laine Stump > wrote: > > >

Re: [libvirt] [PATCH] nwfilter: increase pcap buffer size to be compatible with TPACKET_V3

On Thu, Apr 26, 2018 at 11:55:55AM -0400, Laine Stump wrote: > >> That will help the next one stumbling over this code. > > FWIW, having just checked libpcap git history, the current 2 MB default > > size has been there since 2008 ! I'm guessing we don't use that as we > > don't want to consume

Re: [libvirt] [PATCH libvirt v2 4/9] remote: Use domainClientEventCallbacks for remoteReplayConnectionClosedEvent

On Thu, Apr 26, 2018 at 05:07 PM +0200, John Ferlan wrote: > On 04/12/2018 08:40 AM, Marc Hartmayer wrote: >> This allows us to get rid of another usage of the global variable >> remoteProgram. >> >> Signed-off-by: Marc Hartmayer >> Reviewed-by:

Re: [libvirt] [PATCH libvirt v2 3/9] remote: Add the information which program has to be used to daemonClientEventCallback

On Thu, Apr 26, 2018 at 05:07 PM +0200, John Ferlan wrote: > On 04/12/2018 08:40 AM, Marc Hartmayer wrote: >> As a result, you can later determine at the callback which program has > > s/at/during > s/has to be/was > >> to be used. This makes it easier to refactor the code in

Re: [libvirt] [PATCH libvirt v2 2/9] test: Convert testDriver to virObjectLockable

On Thu, Apr 26, 2018 at 05:07 PM +0200, John Ferlan wrote: > On 04/12/2018 08:40 AM, Marc Hartmayer wrote: >> The test driver state (@testDriver) uses it's own reference counting >> and locking implementation. Instead of doing that, convert @testDriver >> into a

Re: [libvirt] [PATCH libvirt v2 1/9] virConnectRegisterCloseCallback: Cleanup 'opaque' if there is no connectRegisterCloseCallback

On Thu, Apr 26, 2018 at 05:06 PM +0200, John Ferlan wrote: > On 04/12/2018 08:40 AM, Marc Hartmayer wrote: >> The commit 'close callback: move it to driver' (88f09b75eb99) moved >> the responsibility for the close callback to the driver. But if the >> driver doesn't support

Re: [libvirt] [PATCH v4 5/5] qemu: Introduce memoryBacking/discard

On 04/26/2018 02:56 PM, Ján Tomko wrote: > On Fri, Apr 20, 2018 at 11:09:31AM +0200, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1480668 >> >> QEMU has this new feature memory-backend-file.discard-data=yes >> which is a nifty optimization. Basically, when qemu is

Re: [libvirt] [PATCH] nwfilter: increase pcap buffer size to be compatible with TPACKET_V3

On 04/26/2018 04:38 AM, Daniel P. Berrangé wrote: > On Thu, Apr 26, 2018 at 08:09:47AM +0200, Christian Ehrhardt wrote: >> On Wed, Apr 25, 2018 at 11:25 PM, Laine Stump wrote: >> >>> When an nwfilter rule sets the parameter CTRL_IP_LEARNING to "dhcp", >>> this turns on the

Re: [libvirt] [PATCH 0/3] sample: vfio mdev display devices.

On Thu, 26 Apr 2018 08:14:27 +0200 Gerd Hoffmann wrote: > On Thu, Apr 26, 2018 at 03:44:15AM +, Tian, Kevin wrote: > > > From: Alex Williamson > > > Sent: Thursday, April 19, 2018 2:32 AM > > > > > > That almost begins to look reasonable, but then we can only expose this

Re: [libvirt] [PATCH libvirt v2 6/9] remote/rpc: Use virNetServerGetProgram() to determine the program

On 04/12/2018 08:41 AM, Marc Hartmayer wrote: > Use virNetServerGetProgram() to determine the virNetServerProgram > instead of using hard coded global variables. This allows us to remove > the global variables @remoteProgram and @qemuProgram as they're now no > longer necessary. > >

Re: [libvirt] [PATCH libvirt v2 3/9] remote: Add the information which program has to be used to daemonClientEventCallback

On 04/12/2018 08:40 AM, Marc Hartmayer wrote: > As a result, you can later determine at the callback which program has s/at/during s/has to be/was > to be used. This makes it easier to refactor the code in the future > and is less prone to error. > > Signed-off-by: Marc Hartmayer

Re: [libvirt] [PATCH libvirt v2 9/9] remote: shrink the critical sections

On 04/12/2018 08:41 AM, Marc Hartmayer wrote: > No lock is required to access 'priv->conn' therefore we can shrink the > critical sections. > > Signed-off-by: Marc Hartmayer > Reviewed-by: Boris Fiuczynski > --- >

Re: [libvirt] [PATCH libvirt v2 1/9] virConnectRegisterCloseCallback: Cleanup 'opaque' if there is no connectRegisterCloseCallback

On 04/12/2018 08:40 AM, Marc Hartmayer wrote: > The commit 'close callback: move it to driver' (88f09b75eb99) moved > the responsibility for the close callback to the driver. But if the > driver doesn't support the connectRegisterCloseCallback API this > function does nothing, even no

Re: [libvirt] [PATCH libvirt v2 4/9] remote: Use domainClientEventCallbacks for remoteReplayConnectionClosedEvent

On 04/12/2018 08:40 AM, Marc Hartmayer wrote: > This allows us to get rid of another usage of the global variable > remoteProgram. > > Signed-off-by: Marc Hartmayer > Reviewed-by: Boris Fiuczynski > --- >

Re: [libvirt] [PATCH libvirt v2 8/9] remote: remove ATTRIBUTE_UNUSED when attribute is actually used

On 04/12/2018 08:41 AM, Marc Hartmayer wrote: > Signed-off-by: Marc Hartmayer > Reviewed-by: Boris Fiuczynski > --- > src/remote/remote_daemon_dispatch.c | 32 > 1 file changed, 16 insertions(+), 16

Re: [libvirt] [PATCH libvirt v2 7/9] rpc: use the return value of virObjectRef directly

On 04/12/2018 08:41 AM, Marc Hartmayer wrote: > Use the return value of virObjectRef directly. This way, it's easier > for another reader to identify the reason why the additional reference > is required. > > Signed-off-by: Marc Hartmayer > Reviewed-by: Boris

Re: [libvirt] [PATCH libvirt v2 2/9] test: Convert testDriver to virObjectLockable

On 04/12/2018 08:40 AM, Marc Hartmayer wrote: > The test driver state (@testDriver) uses it's own reference counting > and locking implementation. Instead of doing that, convert @testDriver > into a virObjectLockable and use the provided functionalities. > > Signed-off-by: Marc Hartmayer

[libvirt] [dbus PATCH 08/10] Implement NodeSetMemoryParameters method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 31 +++ 2 files changed, 37 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index fc306be..a929802

[libvirt] [dbus PATCH 06/10] Implement NodeGetMemoryStats method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 7 +++ src/connect.c| 42 ++ 2 files changed, 49 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index

[libvirt] [dbus PATCH 02/10] Implement NodeGetCPUStats method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 7 +++ src/connect.c| 42 ++ 2 files changed, 49 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index

[libvirt] [RFC PATCH 0/4] qemu: Forbid NBD migration with TLS

Currently we can't use TLS for NBD so allowing it if TLS is requested creates a security problem. Reject it by refusing to migrate disks and setup TLS on destination since that is easy enough. Note: That I've did not test this yet since my TLS setup was broken. I'll fix it later today and reprot

[libvirt] [dbus PATCH 09/10] Implement NodeSuspendForDuration method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 8 src/connect.c| 42 ++ 2 files changed, 50 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index

[libvirt] [dbus PATCH 10/10] Implement NodeGetCPUMap method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 35 +++ 2 files changed, 41 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index

[libvirt] [dbus PATCH 04/10] Implement NodeGetInfo method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 5 + src/connect.c| 25 + 2 files changed, 30 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index f0a7738..2e65f8b 100644

[libvirt] [RFC PATCH 3/4] qemu: migration: Use TLS environment for NBD server if requested

Use the TLS env for migration when starting the NBD server if TLS is enabled for migration. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_migration.c

[libvirt] [dbus PATCH 01/10] Implement NodeGetCellsFreeMemory method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 7 +++ src/connect.c| 39 +++ 2 files changed, 46 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index

[libvirt] [dbus PATCH 00/10] NodeAPIs for Connect Interface

Katerina Koukiou (10): Implement NodeGetCellsFreeMemory method for Connect Interface Implement NodeGetCPUStats method for Connect Interface Implement NodeGetFreeMemory method for Connect Interface Implement NodeGetInfo method for Connect Interface Implement NodeGetMemoryParameters method

[libvirt] [RFC PATCH 4/4] qemu: migration: Forbid 'nbd' migration of non-shared storage if TLS is requested

Since libvirt is currently not able to setup the NBD migration stream secured by TLS we should not allow such migration since data would be transferred unencrypted. This will break compatibility of TLS migration if non-shared storage is requested but the security implications are more severe.

[libvirt] [dbus PATCH 05/10] Implement NodeGetMemoryParameters method in Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 36 2 files changed, 42 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index

[libvirt] [dbus PATCH 03/10] Implement NodeGetFreeMemory method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 5 + src/connect.c| 24 2 files changed, 29 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 0dcc6e8..f0a7738 100644

[libvirt] [dbus PATCH 07/10] Implement NodeGetSecurityModel method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 23 +++ 2 files changed, 29 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index abb2dbc..fc306be 100644

[libvirt] [RFC PATCH 2/4] qemu: monitor: Add 'tls-creds' parameter to 'nbd-server-start' command

To allow encryption of the non-shared storage migration NBD connection we will need to instantiated the NBD server with the TLS env. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c| 2 +- src/qemu/qemu_monitor.c | 7 --- src/qemu/qemu_monitor.h |

[libvirt] [RFC PATCH 1/4] qemu: caps: Add capability for TLS transport in the NBD server

The NBD server in qemu supports TLS transport. Detect this capability. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 1

Re: [libvirt] [PATCH v2 2/6] tpm: Add support for external swtpm TPM emulator

On 04/26/2018 09:38 AM, Stefan Berger wrote: On 04/25/2018 01:13 PM, John Ferlan wrote: +virTPMCreateEmulatorSocket(const char *swtpmStateDir, const char *vmname) +{ +char *path = NULL; + +ignore_value(virAsprintf(, "%s/%s-swtpm.sock", swtpmStateDir, +

Re: [libvirt] [jenkins-ci PATCH 0/5] guests: Enable ccache transparently

On Wed, Apr 18, 2018 at 05:25:17PM +0200, Andrea Bolognani wrote: > This allows us to drop the ugly workaround from the Go and > MinGW templates; as a nice side-effect, we also remove the > need to hardcode most OS-dependent paths in the inventory. > > Andrea Bolognani (5): > guests: Reorder

Re: [libvirt] [PATCH v2 2/6] tpm: Add support for external swtpm TPM emulator

On 04/25/2018 01:13 PM, John Ferlan wrote: On 04/10/2018 10:50 PM, Stefan Berger wrote: This patch adds support for an external swtpm TPM emulator. The XML for this type of TPM looks as follows: The XML will currently only start a TPM 1.2. Upon first start, libvirt will run

[libvirt] Entering freeze for libvirt-4.3.0

As planned I just tagged the release candidate 1 in git and pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ Seems all fine with my limited testing and jenkins is all green: https://ci.centos.org/view/libvirt/ so so far thing looks good but that won't replace

Re: [libvirt] [PATCH v4 5/5] qemu: Introduce memoryBacking/discard

On Fri, Apr 20, 2018 at 11:09:31AM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1480668 QEMU has this new feature memory-backend-file.discard-data=yes which is a nifty optimization. Basically, when qemu is quitting or on memory hotplug it calls munmap() and close()

Re: [libvirt] [PATCH v4 4/5] qemu_capabilities: Introduce QEMU_CAPS_OBJECT_MEMORY_FILE_DISCARD

On Fri, Apr 20, 2018 at 11:09:30AM +0200, Michal Privoznik wrote: This capability tracks if memory-backend-file has discard-data attribute or not. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 18 + src/qemu/qemu_capabilities.h

Re: [libvirt] [PATCH v4 3/5] qemu_capabilities: Introduce QEMU_CAPS_QOM_LIST_PROPERTIES

On Fri, Apr 20, 2018 at 11:09:29AM +0200, Michal Privoznik wrote: This capability tracks if qemu has "qom-list-properties" monitor command. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h

Re: [libvirt] [PATCH v4 2/5] qemu_monitor: Introduce qemuMonitorGetObjectProps

On Fri, Apr 20, 2018 at 11:09:28AM +0200, Michal Privoznik wrote: Now that we've gotten rid of misleading names we can introduce qemuMonitorGetObjectProps() function which queries -object properties. Again, some parts of code can be reused. Signed-off-by: Michal Privoznik

Re: [libvirt] [dbus PATCH 6/6] Implement SetSchedulerParameters method for Domain Interface

On Wed, Apr 25, 2018 at 07:22:42PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 33 + > 2 files changed, 39 insertions(+) > > diff --git

Re: [libvirt] [dbus PATCH 5/6] Implement SetNumaParameters method for Domain Interface

On Wed, Apr 25, 2018 at 07:22:41PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 33 + > 2 files changed, 39 insertions(+) Reviewed-by: Pavel

Re: [libvirt] [dbus PATCH 4/6] Implement SetMemoryParameters method for Domain Interface

On Wed, Apr 25, 2018 at 07:22:40PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 33 + > 2 files changed, 39 insertions(+) Reviewed-by: Pavel

Re: [libvirt] [dbus PATCH 3/6] Implement SetInterfaceParameters method for Domain Interface

On Wed, Apr 25, 2018 at 07:22:39PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 34 ++ > 2 files changed, 40 insertions(+) > > diff --git

Re: [libvirt] [dbus PATCH 2/6] Implement SetBlockIOTune method for Domain Interface

On Wed, Apr 25, 2018 at 07:22:38PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 7 +++ > src/domain.c| 34 ++ > 2 files changed, 41 insertions(+) Reviewed-by:

Re: [libvirt] [PATCH v4 1/5] qemuMonitorJSONGetDeviceProps: Separate props processing

On Fri, Apr 20, 2018 at 11:09:27AM +0200, Michal Privoznik wrote: The code that processes list of device properties is going to be reused. Therefore put it into a separate function. Signed-off-by: Michal Privoznik --- src/qemu/qemu_monitor_json.c | 59

Re: [libvirt] [dbus PATCH 1/6] Implement SetBlkioParameters method for Domain Interface

On Wed, Apr 25, 2018 at 07:22:37PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 33 + > 2 files changed, 39 insertions(+) Reviewed-by: Pavel

Re: [libvirt] [dbus PATCH v2] Implement GetIOThreadInfo method for Domain Interface

On Wed, Apr 25, 2018 at 07:04:25PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 + > src/domain.c| 63 > + > 2 files changed, 69 insertions(+) > >

Re: [libvirt] [PATCH 5/6] libxl: Add refcnt for args->conn during migration

On Tue, Apr 24, 2018 at 02:28 PM +0200, John Ferlan wrote: > Since the @dconn reference via args->conn will be used via a thread > or callback, let's make sure memory associated with it isn't free'd > unexpectedly before we use it. The Unref will be done when the object > is

Re: [libvirt] [PATCH 4/6] libxl: Add refcnt for args->vm during migration

On Tue, Apr 24, 2018 at 02:28 PM +0200, John Ferlan wrote: > When adding the @vm to the @args for usage during a thread or > callback, let's add the reference to it at the time of adding to > ensure nothing else deletes it. The corresponding Unref is then > added to the

[libvirt] [PATCH] syntax-check: pass srcdir to group-qemu-caps.pl

The script assumed to be run in the source directory. Pass top_srcdir as the argument to fix VPATH builds. My commit 81a7571 broke this. Signed-off-by: Ján Tomko --- Pushed as a build-breaker fix. cfg.mk | 2 +- tests/group-qemu-caps.pl | 10 -- 2

Re: [libvirt] [PATCH v2] logging: Don't inhibit shutdown in system daemon

On Thu, Apr 26, 2018 at 12:32:27PM +0200, Martin Kletzander wrote: > That is a job of libvirtd and virtlogd has a dependency on it, so that will > prevent it properly. Doing it one extra time in virtlogd might also cause AVC > denials because it is not allowed to call that dbus method. > >

[libvirt] [PATCH v2] logging: Don't inhibit shutdown in system daemon

That is a job of libvirtd and virtlogd has a dependency on it, so that will prevent it properly. Doing it one extra time in virtlogd might also cause AVC denials because it is not allowed to call that dbus method. Caused by commit df34363d58bb. Resolves:

Re: [libvirt] Call to virDomainIsActive hangs forever

Hi, thanks for your answer Daniel. I think the best way to get more information about this bug is to reproduce it with libvirt master branch. However, i'm facing an issue when i try to run my own daemon: there is a chid process which is failing in a loop. I used sudo strace -f ./libvirtd to

Re: [libvirt] [PATCH 5/6] util: refactor storage file checks to allow error reporting

On Wed, Apr 25, 2018 at 16:52:42 +0100, Daniel Berrange wrote: > The virStorageFileSupportsSecurityDriver and > virStorageFileSupportsAccess currently just return a boolean > value. This is ok because they don't have any failure scenarios > but a subsequent patch is going to introduce potential

Re: [libvirt] [PATCH 6/6] storage: create separate loadable modules for storage file drivers

On Thu, Apr 26, 2018 at 10:52:02AM +0200, Peter Krempa wrote: > On Wed, Apr 25, 2018 at 16:52:43 +0100, Daniel Berrange wrote: > > The storage file drivers are currently loaded as a side effect of > > loading the storage driver. This is a bogus dependancy because the > > storage file code has no

Re: [libvirt] [PATCH 6/6] storage: create separate loadable modules for storage file drivers

On Wed, Apr 25, 2018 at 16:52:43 +0100, Daniel Berrange wrote: > The storage file drivers are currently loaded as a side effect of > loading the storage driver. This is a bogus dependancy because the > storage file code has no interaction with the storage drivers, and > even ultimately be running

Re: [libvirt] [PATCH] logging: Don't inhibit shutdown

On Wed, Apr 25, 2018 at 03:03:37PM +0100, Daniel P. Berrangé wrote: On Wed, Apr 25, 2018 at 03:57:05PM +0200, Martin Kletzander wrote: That is a job of libvirtd and virtlogd has a dependency on it, so that will prevent it properly. Doing it one extra time in virtlogd might also cause AVC

Re: [libvirt] [PATCH] nwfilter: increase pcap buffer size to be compatible with TPACKET_V3

On Thu, Apr 26, 2018 at 08:09:47AM +0200, Christian Ehrhardt wrote: > On Wed, Apr 25, 2018 at 11:25 PM, Laine Stump wrote: > > > When an nwfilter rule sets the parameter CTRL_IP_LEARNING to "dhcp", > > this turns on the "dhcpsnoop" thread, which uses libpcap to monitor > >

Re: [libvirt] [PATCH 0/8] vfio-ccw passthrough support

Shalini Chellathurai Saroja [2018-04-11, 05:49PM +0200]: > Let us support the basic channel I/O passthrough infrastructure based on > vfio, which have been introduced in QEMU 2.10. The current focus is to > support dasd-eckd (cu_type/dev_type = 0x3990/0x3390) as the

Re: [libvirt] [PATCH 4/6] storage: fix virStorageFileGetBackingStoreStr error handling

On Wed, Apr 25, 2018 at 16:52:41 +0100, Daniel Berrange wrote: > The virStorageFileGetBackingStoreStr method has overloaded the NULL > return value to indicate both no backing available and a fatal > error dealing with it. > > The caller is thus not able to correctly propagate the error >

Re: [libvirt] [PATCH 19/30] test/: Remove spaces after casts

On Wed, Apr 25, 2018 at 03:24:56PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/test/test_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: Digital

Re: [libvirt] [PATCH 20/30] uml/: Remove spaces after casts

On Wed, Apr 25, 2018 at 03:24:57PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/uml/uml_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: Digital

Re: [libvirt] [PATCH 16/30] rpc/: Remove spaces after casts

On Wed, Apr 25, 2018 at 03:24:53PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/rpc/virnetclientstream.c | 4 ++-- src/rpc/virnetserverclient.c | 2 +- src/rpc/virnetserverprogram.c | 2 +- src/rpc/virnetsocket.c| 6 +++--- 4 files changed,

Re: [libvirt] [PATCH 29/30] Remove spaces after casts in rest of the files

On Wed, Apr 25, 2018 at 03:25:06PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/internal.h | 4 ++-- src/libvirt-domain.c | 4 ++-- src/libvirt-host.c | 2 +- src/libvirt-lxc.c| 4 ++-- src/libvirt-stream.c | 4 ++-- 5 files changed, 9

Re: [libvirt] [PATCH 17/30] security/: Remove spaces after casts

On Wed, Apr 25, 2018 at 03:24:54PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/security/security_apparmor.c | 6 ++--- src/security/security_dac.c | 42 src/security/security_selinux.c | 14 +--

Re: [libvirt] [PATCH 26/30] xenconfig/: Remove spaces after casts

On Wed, Apr 25, 2018 at 03:25:03PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/xenconfig/xen_common.c | 4 ++-- src/xenconfig/xen_xl.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [libvirt] [PATCH 18/30] storage/: Remove spaces after casts

On Wed, Apr 25, 2018 at 03:24:55PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/storage/storage_backend_fs.c | 2 +- src/storage/storage_backend_gluster.c | 6 ++-- src/storage/storage_backend_logical.c | 2 +-

Re: [libvirt] [PATCH 24/30] vz/: Remove spaces after casts

On Wed, Apr 25, 2018 at 03:25:01PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/vz/vz_utils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: Digital signature

Re: [libvirt] [PATCH 23/30] vmx/: Remove spaces after casts

On Wed, Apr 25, 2018 at 03:25:00PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/vmx/vmx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: Digital signature

Re: [libvirt] [PATCH 3/6] storage: split fs storage file code from storage driver backend

On Wed, Apr 25, 2018 at 16:52:40 +0100, Daniel Berrange wrote: > The storage file code needs to be run in the hypervisor drivers, while > the storage backend code needs to be run in the storage driver. Split > the source code as a preparatory step for creating separate loadable > modules. > >

Re: [libvirt] [PATCH 14/30] qemu/: Remove spaces after casts

On Wed, Apr 25, 2018 at 03:24:51PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/qemu/qemu_agent.c | 4 +- src/qemu/qemu_alias.c | 2 +- src/qemu/qemu_block.c | 2 +- src/qemu/qemu_capabilities.c | 20 +-

Re: [libvirt] [PATCH 12/30] nwfilter/: Remove spaces after casts

On Wed, Apr 25, 2018 at 03:24:49PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/nwfilter/nwfilter_dhcpsnoop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc

Re: [libvirt] [PATCH 13/30] phyp/: Remove spaces after casts

On Wed, Apr 25, 2018 at 03:24:50PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/phyp/phyp_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: Digital

Re: [libvirt] [PATCH 03/30] admin/: Remove spaces after casts

On Wed, 2018-04-25 at 15:24 +0200, Martin Kletzander wrote: > if (call(srv->conn, 0, ADMIN_PROC_SERVER_SET_THREADPOOL_PARAMETERS, > - (xdrproc_t)xdr_admin_server_set_threadpool_parameters_args, > (char *) , > +

Re: [libvirt] [PATCH 10/30] lxc/: Remove spaces after casts

On Wed, Apr 25, 2018 at 03:24:47PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/lxc/lxc_cgroup.c | 2 +- src/lxc/lxc_controller.c | 4 ++-- src/lxc/lxc_domain.c | 4 ++-- src/lxc/lxc_driver.c | 4 ++-- src/lxc/lxc_monitor.c| 2 +-

Re: [libvirt] [PATCH 11/30] network/: Remove spaces after casts

On Wed, Apr 25, 2018 at 03:24:48PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/network/bridge_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description:

Re: [libvirt] [PATCH 07/30] hyperv/: Remove spaces after casts

On Wed, Apr 25, 2018 at 03:24:44PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/hyperv/hyperv_driver.c | 8 src/hyperv/hyperv_wmi.c| 24 2 files changed, 16 insertions(+), 16 deletions(-) Reviewed-by: Ján

Re: [libvirt] [PATCH 06/30] esx/: Remove spaces after casts

On Wed, Apr 25, 2018 at 03:24:43PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/esx/esx_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: Digital

  1   2   >