Re: [libvirt] [PATCH 02/30] access/: Remove spaces after casts

2018-04-26 Thread Ján Tomko
On Wed, Apr 25, 2018 at 03:24:39PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/access/viraccessdriverpolkit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description:

Re: [libvirt] [PATCH 29/30] Remove spaces after casts in rest of the files

2018-04-26 Thread Andrea Bolognani
On Wed, 2018-04-25 at 15:25 +0200, Martin Kletzander wrote: > /* Round up to the next closest power of 2. It will return rounded number or > 0 > * for 0 or number more than 2^31 (for 32bit unsigned int). */ > # define VIR_ROUND_UP_POWER_OF_TWO(value) \ > -((value) > 0 && (value) <= 1U <<

Re: [libvirt] [PATCH 30/30] Prohibit space after cast

2018-04-26 Thread Ján Tomko
On Wed, Apr 25, 2018 at 03:25:07PM +0200, Martin Kletzander wrote: Let's make a rule out of it and document it. Signed-off-by: Martin Kletzander --- cfg.mk | 6 ++ docs/hacking.html.in | 9 + 2 files changed, 15 insertions(+) diff --git a/cfg.mk

Re: [libvirt] [PATCH 2/6] storage: split gluster storage file code from storage driver backend

2018-04-26 Thread Peter Krempa
On Wed, Apr 25, 2018 at 16:52:39 +0100, Daniel Berrange wrote: > The storage file code needs to be run in the hypervisor drivers, while > the storage backend code needs to be run in the storage driver. Split > the source code as a preparatory step for creating separate loadable > modules. At

Re: [libvirt] [PATCH 15/30] remote/: Remove spaces after casts

2018-04-26 Thread Ján Tomko
On Wed, Apr 25, 2018 at 03:24:52PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/remote/remote_daemon_dispatch.c | 50 +-- src/remote/remote_daemon_stream.c | 2 +- src/remote/remote_driver.c | 620 ++--

Re: [libvirt] [PATCH 1/6] util: create new virmodule.{c, h} files for dlopen support code

2018-04-26 Thread Peter Krempa
On Wed, Apr 25, 2018 at 16:52:38 +0100, Daniel Berrange wrote: > The driver.{c,h} files are primarily targetted at loading hypervisor > drivers and some helper functions in that area. It also, however, > contains a generically useful function for loading extension modules > that is called by the

Re: [libvirt] [PATCH] nwfilter: increase pcap buffer size to be compatible with TPACKET_V3

2018-04-26 Thread Christian Ehrhardt
On Thu, Apr 26, 2018 at 8:09 AM, Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > > > On Wed, Apr 25, 2018 at 11:25 PM, Laine Stump wrote: > >> When an nwfilter rule sets the parameter CTRL_IP_LEARNING to "dhcp", >> this turns on the "dhcpsnoop" thread, which uses

Re: [libvirt] [PATCH 0/3] sample: vfio mdev display devices.

2018-04-26 Thread Gerd Hoffmann
On Thu, Apr 26, 2018 at 03:44:15AM +, Tian, Kevin wrote: > > From: Alex Williamson > > Sent: Thursday, April 19, 2018 2:32 AM > > > > That almost begins to look reasonable, but then we can only expose this > > for mdev devices, what if we were to hack a back door into a directly > > assigned

Re: [libvirt] [PATCH] nwfilter: increase pcap buffer size to be compatible with TPACKET_V3

2018-04-26 Thread Christian Ehrhardt
On Wed, Apr 25, 2018 at 11:25 PM, Laine Stump wrote: > When an nwfilter rule sets the parameter CTRL_IP_LEARNING to "dhcp", > this turns on the "dhcpsnoop" thread, which uses libpcap to monitor > traffic on the domain's tap device and extract the IP address from the > DHCP

<    1   2