On 07/13/2018 05:31 PM, Katerina Koukiou wrote:
> Since commit f14c37, virDomainConfVMNWFilterTeardown is reporting errors
> thus any previously reported error gets overwritten.
> We need to save the errors in qemuDomainAttachNetDevice before calling
> this function when we are in cleanup code.
>
From: Clementine Hayat
Signed-off-by: Clementine Hayat
---
configure.ac | 6 ++-
m4/virt-storage-iscsi-direct.m4| 41 +
src/conf/domain_conf.c | 1 +
src/conf/storage_conf.c| 31 +
From: Clementine Hayat
The minimal required version is 1.18.0 because the synchrounous function
needed were introduced here.
Signed-off-by: Clementine Hayat
---
configure.ac| 3 +++
m4/virt-libiscsi.m4 | 30 ++
2 files changed, 33 insertions(+)
create mode
From: Clementine Hayat
We need here libiscsi for the storgae pool backend.
For the iscsi-direct storage pool, only checkPool and refreshPool should
be necessary.
The pool is state-less and just need the informations within the volume
to work.
Signed-off-by: Clementine Hayat
---
m4/virt-storage
From: Clementine Hayat
Hello,
This is the implementation of the iscsi-direct backend storage pool.
The documentation, some API calls and tests are still missing and will
be comming in a second part.
Best Regards,
--
Clementine Hayat
Clementine Hayat (3):
configure: Introduce libiscsi in b
viralloc.h is pulled in by virbitmap.h
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util/virbitmap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c
index 0cc5292..ef18dad 100644
--- a/src/util/virbitmap.c
+++ b/src/util/virbi
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOPTR macro for declaring aggregate pointer variables,
majority of the calls to *Free functions can be dropped, which
in turn leads to getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Sku
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util
viralloc.h is pulled in by virjson.h
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util/virjson.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/util/virjson.c b/src/util/virjson.c
index 0559d40..92f3994 100644
--- a/src/util/virjson.c
+++ b/src/util/virjson.c
@@ -2
Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in
src/util/viralloc.h, define a new wrapper around an existing
cleanup function which will be called when a variable declared
with VIR_AUTOPTR macro goes out of scope.
When a variable of type virJSONValuePtr is declared using
VIR_AUTOPTR, the fu
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util
viralloc.h is pulled in by virauthconfig.h
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util/virauth.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/util/virauth.c b/src/util/virauth.c
index adb093e..c6a2ce7 100644
--- a/src/util/virauth.c
+++ b/src/util/virauth.c
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOPTR macro for declaring aggregate pointer variables,
majority of the calls to *Free functions can be dropped, which
in turn leads to getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Sku
viralloc.h is pulled in by virfile.h
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util/virfile.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/util/virfile.c b/src/util/virfile.c
index 378d03e..2690e2d 100644
--- a/src/util/virfile.c
+++ b/src/util/virfile.c
@@ -6
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOPTR macro for declaring aggregate pointer variables,
majority of the calls to *Free functions can be dropped, which
in turn leads to getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Sku
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOPTR macro for declaring aggregate pointer variables,
majority of the calls to *Free functions can be dropped, which
in turn leads to getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Sku
Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in
src/util/viralloc.h, define a new wrapper around an existing
cleanup function which will be called when a variable declared
with VIR_AUTOPTR macro goes out of scope.
When a variable of type virBitmapPtr is declared using
VIR_AUTOPTR, the funct
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util
Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in
src/util/viralloc.h, define a new wrapper around an existing
cleanup function which will be called when a variable declared
with VIR_AUTOPTR macro goes out of scope.
When a variable of type virFileWrapperFdPtr is declared using
VIR_AUTOPTR, th
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOPTR macro for declaring aggregate pointer variables,
majority of the calls to *Free functions can be dropped, which
in turn leads to getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Sku
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util
viralloc.h is pulled in by virauthconfig.h
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util/virauthconfig.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/util/virauthconfig.c b/src/util/virauthconfig.c
index 91c9c0c..3487cc2 100644
--- a/src/util/virauthconfig.c
Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in
src/util/viralloc.h, define a new wrapper around an existing
cleanup function which will be called when a variable declared
with VIR_AUTOPTR macro goes out of scope.
When a variable of type virCommandPtr is declared using VIR_AUTOPTR,
the func
Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in
src/util/viralloc.h, define a new wrapper around an existing
cleanup function which will be called when a variable declared
with VIR_AUTOPTR macro goes out of scope.
When a variable of type virAuthConfigPtr is declared using
VIR_AUTOPTR, the f
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util
viralloc.h is pulled in by vircommand.h
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util/vircommand.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index 6dab105..8681e7b 100644
--- a/src/util/vircommand.c
+++ b/src/util/
Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in
src/util/viralloc.h, define a new wrapper around an existing
cleanup function which will be called when a variable declared
with VIR_AUTOPTR macro goes out of scope.
Alias virString to (char *) so that the new cleanup macros
can be used for a
New macros are introduced which help in adding GNU C's cleanup
attribute to variable declarations. Variables declared with these
macros will have their allocated memory freed automatically when
they go out of scope.
Signed-off-by: Sukrit Bhatnagar
Reviewed-by: Erik Skultety
---
src/util/virallo
This series of patches first introduces a new set of macros which help
in using GNU C's __attribute__((cleanup)) in the code.
Then a few syntax-check rules are added which help in ensuring correct
usage of the newly introduced cleanup macros.
Then the patches modify a few files in src/util to use
A variable, which is never assigned a value in the function, might get
passed into the cleanup function which may or may not raise any errors.
To maintain the correct usage, the variable must be initialized, either
with a value or with NULL. This syntax-check rule takes care of that.
Signed-off-b
On Mon, Jul 09, 2018 at 22:56:44 -0500, Chris Venteicher wrote:
> Some architectures (S390) depend on QEMU to compute baseline CPU model and
> expand a models feature set.
>
> Interacting with QEMU requires starting the QEMU process and completing one or
> more query-cpu-model-baseline QMP exchang
On Mon, Jul 09, 2018 at 22:56:55 -0500, Chris Venteicher wrote:
> Transient S390 configurations require using QEMU to compute CPU Model
> Baseline and to do CPU Feature Expansion.
>
> Start and use a single QEMU instance to do both the baseline and
> expansion transactions required by BaselineHype
Drop "(baseline using QEMU)" from Subject to make it shorter.
On Mon, Jul 09, 2018 at 22:56:54 -0500, Chris Venteicher wrote:
> Baseline cpu model using QEMU/QMP query-cpu-model-baseline
>
> query-cpu-model-baseline only compares two CPUModels so multiple
> exchanges are needed to evaluate more t
Since commit f14c37, virDomainConfVMNWFilterTeardown is reporting errors
thus any previously reported error gets overwritten.
We need to save the errors in qemuDomainAttachNetDevice before calling
this function when we are in cleanup code.
https://bugzilla.redhat.com/show_bug.cgi?id=1598311
Signe
On Mon, Jul 09, 2018 at 22:56:53 -0500, Chris Venteicher wrote:
> Commit makes starting a single persistent QEMU instance possible for use
> over multiple independent QMP commands without starting and stopping
> QEMU for each QMP command or command type.
>
> Commit allows functions outside qemu_ca
On 07/13/2018 02:02 PM, Pavel Hrdina wrote:
> On Wed, Jul 11, 2018 at 06:03:08PM +0200, Pavel Hrdina wrote:
>> To make it clear I'll summarize all the possible combinations and how it
>> should work so we are on the same page.
>
> originally: before commit [1]
> now: after commit [1] (current mast
On Mon, Jul 09, 2018 at 22:56:52 -0500, Chris Venteicher wrote:
> Previously QMPCommandPtr (handle for issuing QMP commands) required an
> external char * qmperr to persist over the lifespan of QMPCommand to
> expose a QMP error string outside of QMPCommand.
>
> Before this change, an external cha
On 07/13/2018 02:50 PM, John Ferlan wrote:
>
>
> On 07/09/2018 10:32 AM, Michal Privoznik wrote:
>> On 07/06/2018 08:50 PM, John Ferlan wrote:
>>> Prior to the hostdev being inserted in the hostdevs list,
>>> add a check during qemuDomainAttachDeviceConfig to determine
>>> whether the new/incomin
On 07/13/2018 02:50 PM, John Ferlan wrote:
>
>
> On 07/09/2018 10:32 AM, Michal Privoznik wrote:
>> On 07/06/2018 08:50 PM, John Ferlan wrote:
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1559867
>>>
>>> When attaching a device to the domain we need to be sure
>>> to use the correct domain def
On Fri, Jul 13, 2018 at 03:57:04PM +0200, Katerina Koukiou wrote:
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1599513
The 'Resolves: ' prefix is still pointless, but Andrea might try to disagree
Signed-off-by: Katerina Koukiou
---
src/qemu/qemu_hotplug.c | 5 +
1 file changed,
On Fri, Jul 13, 2018 at 03:48:25PM +0200, Michal Privoznik wrote:
*** BLURB HERE ***
Michal Prívozník (2):
virDevMapperGetTargetsImpl: Be tolerant to kernels without DM support
qemu_cgroup: Allow/disallow devmapper control iff available
src/qemu/qemu_cgroup.c | 36 +++
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1599513
Signed-off-by: Katerina Koukiou
---
src/qemu/qemu_hotplug.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 3dfa51b0a0..bb50d19c85 100644
--- a/src/qemu/qemu_hotplug.c
+
On Mon, Jul 09, 2018 at 22:56:51 -0500, Chris Venteicher wrote:
> Bi-directional conversion functions.
> Converts model / name and features / properties between the two structures.
>
> Created reusable functions to bridge the internal (virCpuDef) and
s/virCpuDef/virCPUDef/
> QEMU/QMP specific st
https://bugzilla.redhat.com/show_bug.cgi?id=1591732
On kernels without device mapper support there won't be
/dev/mapper/control. Therefore it doesn't make much sense to
put it into devices CGroup.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_cgroup.c | 36 +++---
https://bugzilla.redhat.com/show_bug.cgi?id=1591732
If kernel is compiled without CONFIG_BLK_DEV_DM enabled, there is
no /dev/mapper/control device and since dm_task_create() actually
does some ioctl() over it creating a task may fail.
To cope with this handle ENOENT and ENODEV gracefully.
Signed
*** BLURB HERE ***
Michal Prívozník (2):
virDevMapperGetTargetsImpl: Be tolerant to kernels without DM support
qemu_cgroup: Allow/disallow devmapper control iff available
src/qemu/qemu_cgroup.c | 36 +++-
src/util/virdevmapper.c | 8 +++-
2 files changed
On Fri, 2018-07-13 at 13:59 +0200, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1595184
>
> Some domain do not have a name (because they are
> not TAP devices). Therefore, if
> virNetDevTapInterfaceStats(net->ifname, ...) is called an instant
> crash occurs. In Linux vers
From: Marc-André Lureau
See function documentation, used in following patch.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_security.c | 48
src/qemu/qemu_security.h | 6 +
2 files changed, 54 insertions(+)
diff --git a/src/qemu/qemu_security.
From: Marc-André Lureau
Check qemu capability, and accept 3d acceleration.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_process.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index c903a8e5c8..ee4c3445fb 100644
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
.../vhost-user-gpu-secondary.args | 34 +
.../vhost-user-gpu-secondary.xml | 38 +++
tests/qemuxml2argvdata/vhost-user-vga.args| 31 +++
tests/qemuxml2argvdata/v
From: Marc-André Lureau
Similar to the qemu_tpm.c, add a unit with a few functions to
start/stop and setup the cgroup of the external vhost-user-gpu
process. See function documentation.
Signed-off-by: Marc-André Lureau
---
src/conf/device_conf.h | 1 +
src/qemu/Makefile.inc.am
From: Marc-André Lureau
Change the model name to "vhost-user-gpu-pci" if running on PCI.
Set the "max_outputs" property.
Associate the device with the "vhost-user" backend.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
From: Marc-André Lureau
It's a virtio device, like virtio-gpu.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_domain_address.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
index df98d7384f..476ee2d4a5
From: Marc-André Lureau
Each vhost-user-gpu needs its own helper gpu process.
Start/stop them, and apply the emulator cgroup controller.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_extdevice.c | 47 ++-
1 file changed, 42 insertions(+), 5 deletions(-)
From: Marc-André Lureau
Pass the vhost-user socket to a chardev, and associate a
vhost-user-backend with it for each vhost-user-gpu.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c | 50 +
1 file changed, 50 insertions(+)
diff --git a/src/q
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_domain.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 20da58d978..59c63fa2a4 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
From: Marc-André Lureau
Learn to accept "vhost-user" model type:
(fill the required enum and switches to compile successfully)
Signed-off-by: Marc-André Lureau
---
docs/formatdomain.html.in | 5 +++--
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c
From: Marc-André Lureau
To support VGA, we need vhost-user-vga device, for "vhost-user" model.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_domain.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index b8b5919795..20da58d978 100644
From: Marc-André Lureau
vhost-user doesn't have a virgl option, it's given to the
vhost-user-gpu helper process instead.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/q
From: Marc-André Lureau
When the memory is shared and the source isn't specified to be a file,
we can make use of memory-backend-memfd. Sealing is enabled by default
in qemu, hugepage is easier to setup, which makes it a better choice
than memory-backend-file.
Signed-off-by: Marc-André Lureau
-
From: Marc-André Lureau
If vhost-user-gpu is supported, vhost-user video type is.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index a6c00308a2..b517477709 100
From: Marc-André Lureau
When a domain is configured with 'shared' memory backing:
But no explicit NUMA configuration, let's configure a shared memory
backend associated with default -numa.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c | 100 +++
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 6 ++
src/qemu/qemu_capabilities.h | 4
2 files changed, 10 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 4ffd2d6257..a6c00308a2 100644
--- a/src/
From: Marc-André Lureau
Hi,
This series of patches add support for running a virtio GPU in a
seperate process, using vhost-user.
The QEMU series "[PATCH v4 00/29] vhost-user for input & GPU" is still
under review, and will hopefully land in 3.1. There are several
benefits of running the GPU pro
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 +
t
On Wed, Jul 11, 2018 at 03:58:27PM +0200, Erik Skultety wrote:
Since QEMU 2.12, QEMU understands a new vfio-pci device option 'display'
which can be used to turn on display capabilities on vgpu-enabled
mediated devices, IOW emulated GPU devices like QXL will no longer be
needed with vgpu-enable m
On Wed, Jul 11, 2018 at 03:58:26PM +0200, Erik Skultety wrote:
QEMU 2.12 introduced a new type of display for mediated devices using
vfio-pci backend which allows a mediated device to be used as a VGA
compatible device as an alternative to an emulated video device. QEMU
exposes this feature via a
On Wed, Jul 11, 2018 at 03:58:25PM +0200, Erik Skultety wrote:
The exit path is the same for both success and failure, so the label
should be called cleanup.
Signed-off-by: Erik Skultety
---
src/conf/domain_conf.c | 38 +++---
1 file changed, 19 insertions(+), 19
On Wed, Jul 11, 2018 at 03:58:24PM +0200, Erik Skultety wrote:
A simple helper which will loop through all the graphics elements and
checks whether at least one of them enables OpenGL support, either by
containing or being of type 'egl-headless'.
Signed-off-by: Erik Skultety
Acked-by: Michal P
On 07/09/2018 10:32 AM, Michal Privoznik wrote:
> On 07/06/2018 08:50 PM, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1559867
>>
>> When attaching a device to the domain we need to be sure
>> to use the correct domain definition (vm->def or vm->newDef)
>> when calling virDo
On 07/09/2018 10:32 AM, Michal Privoznik wrote:
> On 07/06/2018 08:50 PM, John Ferlan wrote:
>> Prior to the hostdev being inserted in the hostdevs list,
>> add a check during qemuDomainAttachDeviceConfig to determine
>> whether the new/incoming device is providing
>> the same as some existing
On Wed, Jul 11, 2018 at 03:58:23PM +0200, Erik Skultety wrote:
QEMU 2.12 introduced a new vfio-pci device option 'display=on/off/auto'.
This patch introduces the necessary capability.
Signed-off-by: Erik Skultety
Reviewed-by: John Ferlan
---
src/qemu/qemu_capabilities.c |
s/conf/qemu/ in the commit summary, since you chose to group the XML
parser and the QEMU driver changes in one commit.
On Wed, Jul 11, 2018 at 03:58:22PM +0200, Erik Skultety wrote:
Since 2.10 QEMU supports a new display type egl-headless which uses the
drm nodes for OpenGL rendering copying bac
On Wed, Jul 11, 2018 at 03:58:21PM +0200, Erik Skultety wrote:
Since QEMU 2.10, it's possible to use a new type of display -
egl-headless which uses drm nodes to provide OpenGL support. This patch
adds a capability for that. However, since QEMU doesn't provide a QMP
command to probe it, we have t
On Thu, Jul 12, 2018 at 01:58:38PM +0200, Peter Krempa wrote:
I was trying to add some new commands and made a typo. The tests did not
catch it. I must have messed up something when sending the original
schema validation impl.
Peter Krempa (6):
tests: qemuschema: Fix copy-paste error in functio
On Thu, Jul 12, 2018 at 01:58:42PM +0200, Peter Krempa wrote:
The debug output of the schema validator on success is not so
interresting that it should be printed when basic debugging is enabled.
*interesting
Print it only when test debugging is set to 3 and more.
Signed-off-by: Peter Kremp
On Thu, Jul 12, 2018 at 05:19:19PM +0200, Andrea Bolognani wrote:
Doesn't do much right now, but it's a start :)
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 69 ++
1 file changed, 69 insertions(+)
create mode 100755 guests/lcitool
diff --
On Wed, Jul 11, 2018 at 06:03:08PM +0200, Pavel Hrdina wrote:
> To make it clear I'll summarize all the possible combinations and how it
> should work so we are on the same page.
originally: before commit [1]
now: after commit [1] (current master)
expect: what this patch series should fix
==
On Thu, Jul 12, 2018 at 05:08:48PM +0200, Erik Skultety wrote:
Signed-off-by: Erik Skultety
---
docs/news.xml | 14 ++
1 file changed, 14 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 773c95b0da..93832acc4c 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -46,6 +46,
https://bugzilla.redhat.com/show_bug.cgi?id=1595184
Some domain do not have a name (because they are
not TAP devices). Therefore, if
virNetDevTapInterfaceStats(net->ifname, ...) is called an instant
crash occurs. In Linux version of the function strlen() is called
over the name and in BSD version
On Thu, Jul 12, 2018 at 05:08:47PM +0200, Erik Skultety wrote:
Historically, we've always enabled an emulated video device every time we
see that graphics should be supported with a guest. With the appearance
of mediated devices which can support QEMU's vfio-display capability,
users might want t
On Thu, Jul 12, 2018 at 05:08:46PM +0200, Erik Skultety wrote:
Currently it reads:
Refer MDEV to create a mediated device on the host
...even though it resembles English, it's not a proper English.
Signed-off-by: Erik Skultety
---
docs/formatdomain.html.in | 10 ++
1 file changed, 6 ins
On Thu, 12 Jul 2018 17:47:00 +0200
Thomas Huth wrote:
> On 12.07.2018 08:32, Markus Armbruster wrote:
> > Daniel P. Berrangé writes:
> [...]
> >> For libvirt, I think whenever something is proposed for deprecation
> >> we could just CC libvir-list, or ask one of the libvirt people to
> >> conf
On Fri, 2018-07-13 at 11:24 +0200, Michal Privoznik wrote:
[...]
> +if (!ifname) {
> +virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> + _("Interface not found"));
> +return -1;
> +}
I would use something like "Interface name not provided" here,
as it wo
On Fri, Jul 13, 2018 at 10:56:56AM +0200, Andrea Bolognani wrote:
> Recent versions of Ansible complain about this, and suggest
> to replace 'result|search' with 'result is search'.
>
> Since f17097c7af59, however, we've been including operating
> system information in the inventory: this allows us
On Mon, Jul 09, 2018 at 22:56:50 -0500, Chris Venteicher wrote:
> Filter out cpu properties in qemuMonitorCPUModelInfo structure based on
> boolean value of true or false.
>
> Goal is to form a list of "enabled" or "disabled" properties.
>
> Required to convert between cpu model feature / propert
On Tue, Jul 10, 2018 at 05:46:00PM -0400, Cole Robinson wrote:
> v1: https://www.redhat.com/archives/libvir-list/2018-February/msg01135.html
>
> virnodedeviceobj.c generic ListAll infrastructure is not stateless
> and will try to refresh nodedev scsi/pci/etc. config. Understandable
> this doesn't p
On Tue, Jul 10, 2018 at 05:46:01PM -0400, Cole Robinson wrote:
> Add a 'skipUpdateCaps' bool that we set for test_driver.c nodedevs
> which will skip accessing host resources via virNodeDeviceUpdateCaps
>
> Signed-off-by: Cole Robinson
>
...
> @@ -5565,6 +5566,7 @@ testNodeDeviceMockCreateVport(
https://bugzilla.redhat.com/show_bug.cgi?id=1595184
Some domain do not have a name (because they are
not TAP devices). Therefore, if
virNetDevTapInterfaceStats(net->ifname, ...) is called an instant
crash occurs. In Linux version of the function strlen() is called
over the name and in BSD version
On Fri, 2018-07-13 at 11:14 +0200, Erik Skultety wrote:
> > > > +libvirt-ubuntu-16
> > > > +libvirt-ubuntu-18
> > >
> > > shouldn't ubuntu 14 be mentioned here too?
> >
> > We were able to drop Ubuntu 14.04 support, at long last, about a
> > month ago with commit 19a3626d1bab :)
>
> If only I pu
On Fri, Jul 13, 2018 at 11:07:23AM +0200, Andrea Bolognani wrote:
> On Fri, 2018-07-13 at 10:55 +0200, Erik Skultety wrote:
> > On Wed, Jul 11, 2018 at 12:59:13PM +0200, Andrea Bolognani wrote:
> [...]
> > > libvirt-freebsd-10
> > > libvirt-freebsd-11
> > > +libvirt-freebsd-current
> >
> > what d
On Fri, 2018-07-13 at 10:55 +0200, Erik Skultety wrote:
> On Wed, Jul 11, 2018 at 12:59:13PM +0200, Andrea Bolognani wrote:
[...]
> > libvirt-freebsd-10
> > libvirt-freebsd-11
> > +libvirt-freebsd-current
>
> what does ^this map to?
It doesn't map to any other FreeBSD version: -CURRENT it's jus
Recent versions of Ansible complain about this, and suggest
to replace 'result|search' with 'result is search'.
Since f17097c7af59, however, we've been including operating
system information in the inventory: this allows us to drop
our use of search() entirely.
Signed-off-by: Andrea Bolognani
--
1 - 100 of 106 matches
Mail list logo