[libvirt] [PATCH v3 11/11] util: qemu: use VIR_AUTOPTR for aggregate types

By making use of GNU C's cleanup attribute handled by the VIR_AUTOPTR macro for declaring aggregate pointer variables, majority of the calls to *Free functions can be dropped, which in turn leads to getting rid of most of our cleanup sections. Signed-off-by: Sukrit Bhatnagar ---

[libvirt] [PATCH v3 01/11] util: iscsi: use VIR_AUTOFREE instead of VIR_FREE for scalar types

Add another usage for VIR_AUTOFREE macro which was left in the commit ec3e878, thereby dropping a VIR_FREE call and and a cleanup section. Signed-off-by: Sukrit Bhatnagar --- src/util/viriscsi.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git

[libvirt] [PATCH v3 03/11] util: netlink: use VIR_AUTOFREE instead of VIR_FREE for scalar types

By making use of GNU C's cleanup attribute handled by the VIR_AUTOFREE macro for declaring scalar variables, majority of the VIR_FREE calls can be dropped, which in turn leads to getting rid of most of our cleanup sections. Signed-off-by: Sukrit Bhatnagar --- src/util/virnetlink.c | 43

[libvirt] [PATCH v3 04/11] util: netlink: use VIR_AUTOPTR for aggregate types

By making use of GNU C's cleanup attribute handled by the VIR_AUTOPTR macro for declaring aggregate pointer variables, majority of the calls to *Free functions can be dropped, which in turn leads to getting rid of most of our cleanup sections. Signed-off-by: Sukrit Bhatnagar ---

[libvirt] [PATCH v3 05/11] util: netdevbridge: use VIR_AUTOFREE instead of VIR_FREE for scalar types

By making use of GNU C's cleanup attribute handled by the VIR_AUTOFREE macro for declaring scalar variables, majority of the VIR_FREE calls can be dropped, which in turn leads to getting rid of most of our cleanup sections. Signed-off-by: Sukrit Bhatnagar --- src/util/virnetdevbridge.c | 46

[libvirt] [PATCH v3 00/11] use GNU C's cleanup attribute in src/util (batch III)

This third series of patches also modifies a few files in src/util to use VIR_AUTOFREE and VIR_AUTOPTR for automatic freeing of memory and get rid of some VIR_FREE macro invocations and *Free function calls. This is meant as a follow-up of the v1 series [1] of the same batch, and contains those

[libvirt] [PATCH v3 02/11] util: netlink: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC

Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in src/util/viralloc.h, define a new wrapper around an existing cleanup function which will be called when a variable declared with VIR_AUTOPTR macro goes out of scope. Also, drop the redundant viralloc.h include, since that has moved from the

Re: [libvirt] [jenkins-ci PATCH] jobs: ensure rpmbuild purges $RPM-ROOT/BUILD/$PACKAGE

On Thu, 2018-08-09 at 12:02 +0100, Daniel P. Berrangé wrote: > When using 'rpmbuild --rebuild', $RPM-ROOT/BUILD/$PACKAGE is s/ / / > automatically deleted on completion, but when using 'rpmbuild --ta' it s/--ta/-ta/ > is not deleted. We need to pass --clean to get the desired behaviour. > >

[libvirt] [jenkins-ci PATCH] jobs: ensure rpmbuild purges $RPM-ROOT/BUILD/$PACKAGE

When using 'rpmbuild --rebuild', $RPM-ROOT/BUILD/$PACKAGE is automatically deleted on completion, but when using 'rpmbuild --ta' it is not deleted. We need to pass --clean to get the desired behaviour. This was not a visible problem in the past because "git clean -fdx" would purge the directory,

Re: [libvirt] [jenkins-ci PATCH 11/12] lcitool: Support building arbitrary branches

On Wed, 2018-08-08 at 15:45 +0200, Andrea Bolognani wrote: [...] > -def _action_update(self, hosts, projects): > -self._execute_playbook("update", hosts, projects) > +def _action_update(self, hosts, projects, _branch): > +self._execute_playbook("update", hosts, project,

Re: [libvirt] [PATCH] conf: rewrite filtering for capabilities lookup

ping On Fri, Aug 03, 2018 at 03:28:16PM +0100, Daniel P. Berrangé wrote: > The virCapabilitiesDomainDataLookupInternal() is given a list of > parameters representing the desired domain characteristics. It then has > to look throught the capabilities to identify an acceptable match. > > The

[libvirt] [PATCH v2] qemu: qemuDomainChangeNet: validity checks should be done before XML autocompletion

This patch ensures that changes in attributes of interfaces will be emit errors accept if they are missing from the XML. Previously we were falsely reporting successfull updates, because some changed attributes got overwritten before the validity checks.

Re: [libvirt] [PATCH] network: restrict usage of port management APIs

On Wed, Aug 08, 2018 at 11:41:23PM -0400, Laine Stump wrote: > On 08/08/2018 11:46 AM, Daniel P. Berrangé wrote: > > The port allocation APIs are currently called unconditionally for all > > types of NIC, but (mostly) only do anything for NICs with type=network. > > > > The exception is the port

Re: [libvirt] [PATCH libvirt-tck] Cleanup secret in disk encryption test

On Wed, Aug 08, 2018 at 02:44:54PM -0600, Jim Fehlig wrote: > 100-disk-encryption.t does not undefine the secret it defines > for the test disk, causing subsequent runs of the test to fail > > not ok 1 - secret created > Failed test 'secret created' > at

Re: [libvirt] [PATCH] storage: tweak error message when skipping file

On Wed, Aug 08, 2018 at 04:45:43PM +0100, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- src/storage/storage_util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Martin Kletzander diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c

<    1   2