[libvirt] [PATCH] storage: Fix mention of disk pool default

2018-08-29 Thread Eric Blake
The default disk storage pool type is 'dos', not 'msdos'. Signed-off-by: Eric Blake --- I ran into this doc bug when trying to figure out why a disk storage pool that I had copied from another machine wouldn't autostart; it turns out that the old disk used BIOS partitioning (dos), and the new

Re: [libvirt] [PATCH for v4.7.0] virDomainDefCompatibleDevice: Relax alias change check

2018-08-29 Thread John Ferlan
On 08/29/2018 11:11 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1621910 > > When introducing this check back in 4ad54a417a1 my mindset was > that if an element is missing in update XML then user is > requesting for removal of the corresponding setting. For >

Re: [libvirt] [PATCH v3 2/2] qemu: adding domainGetHostname support for QEMU.

2018-08-29 Thread John Ferlan
On 08/21/2018 10:39 PM, Julio Faracco wrote: > This commit add the support to use the function qemuAgentGetHostname() s/add the/adds/ > for obtain the domain hostname using QEMU-GA command. s/for/to/ > > Signed-off-by: Julio Faracco > --- > src/qemu/qemu_driver.c | 40

Re: [libvirt] [PATCH v3 1/2] qemu: implementing qemuAgentGetHostname() function.

2018-08-29 Thread John Ferlan
On 08/21/2018 10:39 PM, Julio Faracco wrote: > This commit implements the function qemuAgentGetHostname() that uses > the QEMU command 'guest-get-host-name' to retrieve the guest hostname QEMU guest agent > of Virtual Machine. It is a possibility where QEMU-GA is running. of the virtual

Re: [libvirt] [PATCH] virDomainDetachDeviceFlags: Clarify update semantics

2018-08-29 Thread Michal Privoznik
On 08/29/2018 03:45 PM, John Ferlan wrote: > > > On 08/27/2018 09:50 AM, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1621910 >> > > FWIW: my thoughts w/r/t "alias" (in particular) and the bz - since > libvirt creates the alias for the live XML and does not extend that

[libvirt] [PATCH for v4.7.0] virDomainDefCompatibleDevice: Relax alias change check

2018-08-29 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1621910 When introducing this check back in 4ad54a417a1 my mindset was that if an element is missing in update XML then user is requesting for removal of the corresponding setting. For instance, if is not present in update XML any QoS previously set on

[libvirt] [jenkins-ci PATCH 8/8] guests: Update documentation

2018-08-29 Thread Andrea Bolognani
Provide instructions on how to build from non-default git repositories and branches. Signed-off-by: Andrea Bolognani --- guests/README.markdown | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/guests/README.markdown b/guests/README.markdown index 68a6af7..f5d1219

[libvirt] [jenkins-ci PATCH 7/8] guests: Use "git_remote" when building

2018-08-29 Thread Andrea Bolognani
This makes the build process use the value provided by the user through lcitool instead of the default. With this change, building arbitrary branches from arbitrary git repository through lcitool is fully working. Signed-off-by: Andrea Bolognani ---

[libvirt] [jenkins-ci PATCH 0/8] lcitool: Support building arbitrary branches

2018-08-29 Thread Andrea Bolognani
Better (hopefully :) implementation of the feature scrapped from the initial "build support" series. Andrea Bolognani (8): lcitool: Add "-r REVISION" argument for build Don't use "branch" in paths and job names jobs: Hardcode "master" branch guests: Use "git_branch" when building Drop

[libvirt] [jenkins-ci PATCH 5/8] Drop "branch" variable

2018-08-29 Thread Andrea Bolognani
It's no longer used anywhere. Signed-off-by: Andrea Bolognani --- guests/playbooks/build/jobs/defaults.yml | 1 - jobs/defaults.yaml | 1 - 2 files changed, 2 deletions(-) diff --git a/guests/playbooks/build/jobs/defaults.yml b/guests/playbooks/build/jobs/defaults.yml

[libvirt] [jenkins-ci PATCH 2/8] Don't use "branch" in paths and job names

2018-08-29 Thread Andrea Bolognani
We'll soon to make it possible to build arbitrary branches from arbitrary git repositories with lcitool: sticking with the current scheme for on-disk storage would mean that we would create a separate git clone for each branch that was ever built this way, which is clearly extremely wasteful not

[libvirt] [jenkins-ci PATCH 6/8] Add "git_urls" dictionary to defaults

2018-08-29 Thread Andrea Bolognani
Out of the box, it contains the upstream repository for all projects; additionally, the user will be able to store information about their own repositories, making it possible to test-build in-progress branches before submitting the code upstream. Despite all the pieces being now in place for us

[libvirt] [jenkins-ci PATCH 3/8] jobs: Hardcode "master" branch

2018-08-29 Thread Andrea Bolognani
We never build from any other branch on the CentOS CI environment, so treating this as a configurable parameter is pointless and will only get in the way of making further changes. Signed-off-by: Andrea Bolognani --- jobs/autotools.yaml| 2 +- jobs/generic.yaml | 2 +-

[libvirt] [jenkins-ci PATCH 4/8] guests: Use "git_branch" when building

2018-08-29 Thread Andrea Bolognani
This makes the build process use the value provided by the user through lcitool instead of the default. Signed-off-by: Andrea Bolognani --- guests/playbooks/build/jobs/prepare.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guests/playbooks/build/jobs/prepare.yml

[libvirt] [jenkins-ci PATCH 1/8] lcitool: Add "-r REVISION" argument for build

2018-08-29 Thread Andrea Bolognani
This will allow users to build arbitrary branches from arbitrary git repositories, but for the moment all it does is parse the argument and pass it down to the Ansible playbook. Signed-off-by: Andrea Bolognani --- guests/lcitool | 36 ++-- 1 file changed, 26

Re: [libvirt] [PATCH] qemu: domain: validate memory access during validate domain config

2018-08-29 Thread John Ferlan
On 08/27/2018 11:51 PM, lhuang wrote: > > > On 08/28/2018 06:01 AM, John Ferlan wrote: >> >> On 08/20/2018 05:48 AM, Luyao Huang wrote: >>> commit 6534b3c4 try to raise an error when there is no numa nodes but >>> set access='shared' in domain config. In that commit, we add a memory >>> access

Re: [libvirt] [PATCH -v2 1/1] esx: Make esxDomainGetVcpusFlags check flags

2018-08-29 Thread John Ferlan
On 08/15/2018 05:35 AM, Marcos Paulo de Souza wrote: > Before this patch, esxDomainGetVcpusFlags was not checking the flags > argument. Current, get and set vcpus was failing in ESX since it was > checking for "maxSupportedVcpus", and this configuration can be ommited > by ESXi[1]. Now, if

Re: [libvirt] [PATCH] virDomainDetachDeviceFlags: Clarify update semantics

2018-08-29 Thread John Ferlan
On 08/27/2018 09:50 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1621910 > FWIW: my thoughts w/r/t "alias" (in particular) and the bz - since libvirt creates the alias for the live XML and does not extend that alias to the config XML that means I can see just

Re: [libvirt] [PATCH] virDomainDetachDeviceFlags: Clarify update semantics

2018-08-29 Thread Erik Skultety
On Mon, Aug 27, 2018 at 03:50:20PM +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1621910 > > When users want to update a path to a CDROM they tend to > construct a very minimal XML and feed the API with it. This is > not a good practice as it breaks the assumptions

Re: [libvirt] [PATCH] vsh-table: Fix broken build on centos and rhel

2018-08-29 Thread Andrea Bolognani
On Wed, 2018-08-29 at 09:48 +0200, Simon Kobyda wrote: > The reason of broken build was that centos and rhel use older version of > glibc. > These versions of glibc on these platforms cannot work with newer unicodes, > therefore functions iswprint() and wcwidth() failed. So I replaced them with >

Re: [libvirt] [PATCH] tests: Properly reset mocked CPU model

2018-08-29 Thread Erik Skultety
On Tue, Aug 28, 2018 at 04:17:30PM +0200, Jiri Denemark wrote: > When switching the host architecture to something for which we do not > have any host CPU model defined, the mocked > virQEMUCapsProbeHostCPUForEmulator would just return the previous CPU > model resulting in strange combinations,

Re: [libvirt] Entering freeze for libvirt-4.7.0

2018-08-29 Thread Daniel Veillard
On Wed, Aug 29, 2018 at 09:54:56AM +0200, Peter Krempa wrote: > On Tue, Aug 28, 2018 at 19:00:12 +0200, Daniel Veillard wrote: > > Sorry I forgot to announce it but we are the last week of the month, > > so it's about time, I tagged RC1 in git and pushed the signed tarball > > and rpms to the

Re: [libvirt] [RFC v2 02/16] qemu: add memfd memory backing

2018-08-29 Thread Daniel P . Berrangé
On Tue, Aug 28, 2018 at 11:39:20PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add a new memoryBacking source type "memfd", support by QEMU (when the > capability is available). > > Sealing is enabled by default in qemu, and hugepage is easier to > setup, which makes

Re: [libvirt] [PATCH] Add virNetlinkNewLink for simplifying virNetDev*Create

2018-08-29 Thread Erik Skultety
On Thu, Aug 23, 2018 at 12:15:08PM +0800, Shi Lei wrote: > This patch adds virNetlinkNewLink for simplifying virNetDevMacVLanCreate > and virNetDevBridgeCreate. > > Signed-off-by: Shi Lei > --- There are multiple changes happening in this patch so it will need to be split into several patches,

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-29 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Aug 17, 2018 at 03:13:22PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Fri, Aug 17, 2018 at 12:35:11PM +0200, Andrea Bolognani wrote: >> >> On Fri, 2018-08-17 at 10:29 +0100, Daniel P. Berrangé wrote: >> >> > On Thu, Aug 16,

Re: [libvirt] [PATCH v2 8/8] storage_driver: Release pool object lock for some long running jobs

2018-08-29 Thread Michal Privoznik
On 08/28/2018 08:36 PM, John Ferlan wrote: > > > On 08/20/2018 08:09 AM, Michal Privoznik wrote: >> As advertised in previous commit, there are three APIs that might >> run for quite some time (because they read/write data from/to a >> volume) and these three are: downloadVol, uploadVol,

Re: [libvirt] [PATCH] vsh-table: Fix broken build on centos and rhel

2018-08-29 Thread Ján Tomko
On Wed, Aug 29, 2018 at 09:48:10AM +0200, Simon Kobyda wrote: The reason of broken build was that centos and rhel use older version of glibc. These versions of glibc on these platforms cannot work with newer unicodes, therefore functions iswprint() and wcwidth() failed. So I replaced them with

Re: [libvirt] [RFC v2 10/16] qemu: add vhost-user-gpu helper unit

2018-08-29 Thread Daniel P . Berrangé
On Tue, Aug 28, 2018 at 11:39:28PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Similar to the qemu_tpm.c, add a unit with a few functions to > start/stop and setup the cgroup of the external vhost-user-gpu > process. See function documentation. > > Signed-off-by:

Re: [libvirt] [RFC v2 04/16] domain: add "vhost-user" video type

2018-08-29 Thread Daniel P . Berrangé
On Tue, Aug 28, 2018 at 11:39:22PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Learn to accept "vhost-user" model type: > > > The model element's purpose is to indicate the guest device type. 'vhost-user' is a host backend, not a new guest device type, so

Re: [libvirt] [PATCH] vsh-table: Fix broken build on centos and rhel

2018-08-29 Thread Erik Skultety
On Wed, Aug 29, 2018 at 09:48:10AM +0200, Simon Kobyda wrote: > The reason of broken build was that centos and rhel use older version of > glibc. > These versions of glibc on these platforms cannot work with newer unicodes, > therefore functions iswprint() and wcwidth() failed. So I replaced them

Re: [libvirt] [PATCH v4 00/12] PCI passthrough support on s390

2018-08-29 Thread Yi Min Zhao
在 2018/8/29 下午4:19, Andrea Bolognani 写道: On Wed, 2018-08-29 at 13:32 +0800, Yi Min Zhao wrote: Hi @Andrea, Is there any chance that these patches catch up with 4.7.0 release? I see it's entering freeze. We're already frozen, which means only fixes can be merged. I'll review the patches in

Re: [libvirt] [PATCH v4 00/12] PCI passthrough support on s390

2018-08-29 Thread Andrea Bolognani
On Wed, 2018-08-29 at 13:32 +0800, Yi Min Zhao wrote: > Hi @Andrea, > > Is there any chance that these patches catch up with 4.7.0 release? > > I see it's entering freeze. We're already frozen, which means only fixes can be merged. I'll review the patches in the next few days and if everything

Re: [libvirt] [PATCH] virDomainObjListAddLocked: fix double free

2018-08-29 Thread Michal Privoznik
On 08/27/2018 06:06 PM, Marc Hartmayer wrote: > On Mon, Aug 27, 2018 at 04:03 PM +0200, Michal Prívozník > wrote: >> On 08/27/2018 03:20 PM, Marc Hartmayer wrote: >>> If @vm has flagged as "to be removed" virDomainObjListFindByNameLocked >>> returns NULL (although the definition actually

Re: [libvirt] Entering freeze for libvirt-4.7.0

2018-08-29 Thread Peter Krempa
On Tue, Aug 28, 2018 at 19:00:12 +0200, Daniel Veillard wrote: > Sorry I forgot to announce it but we are the last week of the month, > so it's about time, I tagged RC1 in git and pushed the signed tarball > and rpms to the usual place earlier today: > > ftp://libvirt.org/libvirt/ > > this

[libvirt] [PATCH] vsh-table: Fix broken build on centos and rhel

2018-08-29 Thread Simon Kobyda
The reason of broken build was that centos and rhel use older version of glibc. These versions of glibc on these platforms cannot work with newer unicodes, therefore functions iswprint() and wcwidth() failed. So I replaced them with older unicode characters. Signed-off-by: Simon Kobyda ---