On 09/07/2018 12:52 AM, John Ferlan wrote:
>
>
> On 09/06/2018 12:16 PM, Michal Privoznik wrote:
>> There is no need to check if @npaths is not zero. Let's
>> qemuDomainNamespaceUnlinkPaths() handle that.
>>
>> Signed-off-by: Michal Privoznik
>> ---
>> src/qemu/qemu_domain.c | 3 +--
>> 1 file
On 2018-09-06 at 21:27, Erik Skultety wrote:
>...
>
>> >
>> >> + if (dummy && nla_put(msg, attrtype, datalen, data) < 0) { \
>> >> + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", \
>> >> + _("nla_put error [" #attrtype "]")); \
>> >> + return -1; \
>> >> +
virDomainDefCollectBootOrder() is called for every item on the list
for each type of device. Since an is on
both the list of hostdev devices and the list of network devices, it
will be counted twice, and the code that checks for multiple devices
with the same boot order will give a false
On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote:
Specifically, list sub-elements and where they can be used. In addition,
describe supported machine types for Xen.
Signed-off-by: Marek Marczykowski-Górecki
---
docs/formatcaps.html.in | 20 +++-
ping^2?
Tks,
John
On 08/24/2018 10:27 AM, John Ferlan wrote:
>
> ping?
>
> Tks -
>
> John
>
> On 08/21/2018 12:23 PM, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1613737
>>
>> Details in the patches (and even more in the bz).
>>
>> John Ferlan (3):
>> storage:
ping^2?
Tks,
John
These are essentially what Daniel and I agreed upon during the v2 review
- link the patches below...
On 08/30/2018 06:24 PM, John Ferlan wrote:
> ping?
>
> Tks,
>
> John
>
> On 08/24/2018 10:02 AM, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1607202
On 09/06/2018 12:16 PM, Michal Privoznik wrote:
> There is no need to check if @npaths is not zero. Let's
> qemuDomainNamespaceUnlinkPaths() handle that.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_domain.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
At the
On 09/06/2018 11:44 AM, Jiri Denemark wrote:
> Broken by v3.10.0-68-gaed3d038a6.
>
> Signed-off-by: Jiri Denemark
> ---
> src/conf/domain_conf.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Trivial.
Reviewed-by: John Ferlan
John
--
libvir-list mailing list
$SUBJ:
s/attatched/attached
s/bug//
On 08/31/2018 03:34 AM, Wu Zongyong wrote:
So, first off - I believe there are two things going on in this one
patch. Even though there is "some relationship" between the issues, the
libvirtd restart is kind of a corner case, while the change to readd the
On Thu, Sep 06, 2018 at 02:58:30PM -0600, Jim Fehlig wrote:
> On 09/03/2018 04:09 PM, Marek Marczykowski-Górecki wrote:
> > Signed-off-by: Marek Marczykowski-Górecki
> > ---
> > Changes in v2:
> > - use virDomainObjEndAPI
> > - drop duplicated error reporting on virDomainObjIsActive
> > -
On 09/03/2018 04:09 PM, Marek Marczykowski-Górecki wrote:
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- use virDomainObjEndAPI
- drop duplicated error reporting on virDomainObjIsActive
- bump version comment to 4.8.0
You missed some other comments from V1. I'll repeat
There is no need to check if @npaths is not zero. Let's
qemuDomainNamespaceUnlinkPaths() handle that.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_domain.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
Broken by v3.10.0-68-gaed3d038a6.
Signed-off-by: Jiri Denemark
---
src/conf/domain_conf.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 86199623cc..6aa5ff51b4 100644
--- a/src/conf/domain_conf.c
+++
On Thu, Sep 06, 2018 at 05:13:23PM +0200, Pino Toscano wrote:
> Hi,
>
> for reasons mostly lost in the history, after the libvirt-ocaml
> repository was converted to git, it was not used by its main author
> (Rich Jones); the development continued on Rich's git, at
>
Hi,
for reasons mostly lost in the history, after the libvirt-ocaml
repository was converted to git, it was not used by its main author
(Rich Jones); the development continued on Rich's git, at
http://git.annexia.org/?p=ocaml-libvirt.git;a=summary
After a talk with Rich, we agreed that it was
On 09/06/2018 09:04 AM, Martin Kletzander wrote:
On Wed, Sep 05, 2018 at 03:37:22PM +0100, Daniel P. Berrangé wrote:
On Wed, Sep 05, 2018 at 02:01:42PM +0200, Martin Kletzander wrote:
On Wed, Sep 05, 2018 at 09:28:52AM +0100, Daniel P. Berrangé wrote:
> On Tue, Sep 04, 2018 at 03:44:12PM
The '.' at the end of the summary is not necessary
On Wed, Sep 05, 2018 at 01:20:56AM -0300, Julio Faracco wrote:
The function to retrieve the file system info using QEMU-GA is using
some conditionals to retrieve the info. This is wrong because the error
of some conditionals will be raised if
...
> >
> >> + if (dummy && nla_put(msg, attrtype, datalen, data) < 0) { \
> >> + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", \
> >> + _("nla_put error [" #attrtype "]")); \
> >> + return -1; \
> >> + } \
> >> +} while(0)
> >> +
> >> +# define
On Thu, Sep 06, 2018 at 02:22:19PM +0200, Andrea Bolognani wrote:
A virtio device such as
will be translated to one of four different QEMU devices
based on the address type. This behavior is the same for
all virtio devices, but unfortunately we have separate
ad-hoc code dealing with each and
On Thu, Sep 06, 2018 at 02:22:18PM +0200, Andrea Bolognani wrote:
The checks and error messages are mostly the same across
all virtio-input devices, so we can avoid having multiple
copies of the same code.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_domain.c | 51
On Wed, Sep 05, 2018 at 03:37:22PM +0100, Daniel P. Berrangé wrote:
On Wed, Sep 05, 2018 at 02:01:42PM +0200, Martin Kletzander wrote:
On Wed, Sep 05, 2018 at 09:28:52AM +0100, Daniel P. Berrangé wrote:
> On Tue, Sep 04, 2018 at 03:44:12PM -0400, Cole Robinson wrote:
> > Right now in
s/ites/ities/
On Thu, Sep 06, 2018 at 02:22:17PM +0200, Andrea Bolognani wrote:
The appropriate time to ensure the required capabilities are
present is validate rather than command line generation: add
a new qemuDomainDeviceDefValidateInput() function and move
all existing checks there.
On Thu, Sep 06, 2018 at 02:22:16PM +0200, Andrea Bolognani wrote:
So far we've only formatted it for virtio-blk-pci and
virtio-blk-ccw, but other virtio-blk devices also support
the corresponding option; moreover, we've always formatted
it for all virtio-scsi devices.
Signed-off-by: Andrea
On Thu, Sep 06, 2018 at 02:22:15PM +0200, Andrea Bolognani wrote:
There are several functions where we pointlessly duplicate
parts of the format string and pass the same arguments:
refactor them so that the common parts are formatted separately
from the variable parts.
Signed-off-by: Andrea
On Thu, Sep 06, 2018 at 02:22:14PM +0200, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 877269f52e..72d8bb4cf6 100644
---
On Thu, Sep 06, 2018 at 02:22:13PM +0200, Andrea Bolognani wrote:
A few qemuxml2xml tests for virtio-input devices are
missing the capabilities used for the corresponding
qemuxml2argv tests: this wasn't a problem until now
because capabilities were only checked at command line
generation time,
A virtio device such as
will be translated to one of four different QEMU devices
based on the address type. This behavior is the same for
all virtio devices, but unfortunately we have separate
ad-hoc code dealing with each and every one of them: not
only this is pointless duplication, but it
So far we've only formatted it for virtio-blk-pci and
virtio-blk-ccw, but other virtio-blk devices also support
the corresponding option; moreover, we've always formatted
it for all virtio-scsi devices.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 5 +
1 file changed, 1
The appropriate time to ensure the required capabilities are
present is validate rather than command line generation: add
a new qemuDomainDeviceDefValidateInput() function and move
all existing checks there.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 26 --
The checks and error messages are mostly the same across
all virtio-input devices, so we can avoid having multiple
copies of the same code.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_domain.c | 51 +-
1 file changed, 25 insertions(+), 26
A few qemuxml2xml tests for virtio-input devices are
missing the capabilities used for the corresponding
qemuxml2argv tests: this wasn't a problem until now
because capabilities were only checked at command line
generation time, but we're going to change that later.
Signed-off-by: Andrea
Or, how to turn a single patch into a seven patches series
using the astounding power of review comments!
Andrea Bolognani (7):
tests: Add missing virtio-input capabilities
qemu: Check type range for virtio-input devices
qemu: Remove duplicated option formatting for virtio devices
qemu:
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 877269f52e..72d8bb4cf6 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -4096,7
There are several functions where we pointlessly duplicate
parts of the format string and pass the same arguments:
refactor them so that the common parts are formatted separately
from the variable parts.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 42
On Fri, Aug 31, 2018 at 12:19:12 +0200, Laszlo Ersek wrote:
> On 08/31/18 10:00, Igor Mammedov wrote:
> > On Thu, 30 Aug 2018 17:51:13 +0200
> > Laszlo Ersek wrote:
> >
> >> +Drew
> >>
> >> On 08/30/18 14:08, Igor Mammedov wrote:
> >>> If VM has VCPUs plugged sparselly (for example a VM started
How about implementing spell checker(like codespell) in the check script to
avoid typos in patches?
On Thu, Sep 6, 2018 at 3:26 AM, Eric Blake wrote:
> Signed-off-by: Eric Blake
> ---
>
> Pushing under the trivial rule.
>
> src/libvirt-domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1
On 2018-09-05 at 23:01, Erik Skultety wrote:
>On Wed, Sep 05, 2018 at 04:36:28PM +0800, Shi Lei wrote:
>> This patch adds wrapper macros around nla_nest*/nla_put* which apply to
>> virNetlinkNewLink and virNetDevSetVfConfig and
>> virNetDevVPortProfileOpSetLink.
>>
>> Signed-off-by: Shi Lei
>>
On Wed, 5 Sep 2018 10:45:12 -0300
Eduardo Habkost wrote:
> On Wed, Sep 05, 2018 at 11:25:11AM +0200, Igor Mammedov wrote:
> > On Tue, 4 Sep 2018 23:12:55 -0300
> > Eduardo Habkost wrote:
> >
> > > On Tue, Sep 04, 2018 at 03:22:35PM +0200, Igor Mammedov wrote:
> > > > -smp
38 matches
Mail list logo
