Re: [libvirt] question about syntax of storage volume element

2018-10-01 Thread John Ferlan
On 9/28/18 12:54 AM, Jim Fehlig wrote: > I've attempted to use virt-manager to create a new VM that uses a volume > from an rbd-based network pool, but have not been able to progress past > step 4/5 where VM storage is selected. It appears virt-manager has > problems properly detecting the

Re: [libvirt] [tck PATCH] Fix runtime "undefined global" error in 100-disk-encryption.t

2018-10-01 Thread Yash Mankad
On 10/01/2018 04:07 PM, Laine Stump wrote: > Commit 3836a38c added a $secret-undefine call at the end of > 100-disk-encryption.t because the presence of the secret was > reportedly causing an error when the test was run a 2nd > time. Unfortunately the definition of "my $secret" was inside a

[libvirt] [tck PATCH] Fix runtime "undefined global" error in 100-disk-encryption.t

2018-10-01 Thread Laine Stump
Commit 3836a38c added a $secret-undefine call at the end of 100-disk-encryption.t because the presence of the secret was reportedly causing an error when the test was run a 2nd time. Unfortunately the definition of "my $secret" was inside a SKIP: { ... } block, but the $secret->undefine was added

Re: [libvirt] [PATCH v2] qemu: agent: Avoid agentError when closing the QEMU agent

2018-10-01 Thread John Ferlan
On 9/28/18 5:36 AM, Wang Yechao wrote: > After calling qemuAgentClose(), it is still possible for > the QEMU Agent I/O event callback to get invoked. This > will trigger an agent error because mon->fd has been set > to -1 at this point. Then vm->privateData->agentError is > always 'true'

Re: [libvirt] question about syntax of storage volume element

2018-10-01 Thread Cole Robinson
On 09/28/2018 12:54 AM, Jim Fehlig wrote: I've attempted to use virt-manager to create a new VM that uses a volume from an rbd-based network pool, but have not been able to progress past step 4/5 where VM storage is selected. It appears virt-manager has problems properly detecting the volume

Re: [libvirt] [PATCH] tests: reintroduce tests for libxl's legacy nested setting

2018-10-01 Thread Jim Fehlig
On 10/1/18 2:35 AM, Erik Skultety wrote: On Mon, Oct 01, 2018 at 08:04:57AM +0200, Erik Skultety wrote: On Thu, Sep 27, 2018 at 08:25:53AM -0600, Jim Fehlig wrote: On 9/27/18 3:29 AM, Erik Skultety wrote: On Wed, Sep 26, 2018 at 11:31:19AM -0600, Jim Fehlig wrote: The preferred location for

[libvirt] Release of libvirt-4.8.0

2018-10-01 Thread Daniel Veillard
It is out, as planned, tagged in git, the signed tarball and rpms are at the usual place: ftp://libvirt.org/libvirt/ I also make a python binding release which include event testing updates, you can find those at ftp://libvirt.org/libvirt/python/ This is a relatively large release

Re: [libvirt] [libvirt PATCH v4] news: Update for 4.8.0 release

2018-10-01 Thread Erik Skultety
On Mon, Oct 01, 2018 at 04:40:12PM +0200, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [libvirt PATCH v4] news: Update for 4.8.0 release

2018-10-01 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- I went through the commits since last release and added a few notes which seem to be relevant for the news. In case you notice there's something missing, please, either send me the text to add it (and I'll re-sping this patch) and add the text before merging

Re: [libvirt] [PATCH] security: dac: also label listen UNIX sockets

2018-10-01 Thread Erik Skultety
On Mon, Oct 01, 2018 at 01:14:34PM +0200, Ján Tomko wrote: > On Mon, Oct 01, 2018 at 10:22:59AM +0200, Erik Skultety wrote: > > On Thu, Sep 27, 2018 at 05:02:13PM +0200, Ján Tomko wrote: > > > We switched to opening mode='bind' sockets ourselves: > > > commit

Re: [libvirt] [libvirt PATCH v3] news: Update for 4.8.0 release

2018-10-01 Thread Fabiano Fidêncio
On Mon, 2018-10-01 at 15:22 +0200, Peter Krempa wrote: > On Mon, Oct 01, 2018 at 15:04:37 +0200, Fabiano Fidêncio wrote: > > Signed-off-by: Fabiano Fidêncio > > --- > > I went through the commits since last release and added a few notes > > which seem to be relevant for the news. > > > > In case

Re: [libvirt] [libvirt PATCH v3] news: Update for 4.8.0 release

2018-10-01 Thread Erik Skultety
On Mon, Oct 01, 2018 at 03:04:37PM +0200, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > I went through the commits since last release and added a few notes > which seem to be relevant for the news. > > In case you notice there's something missing, please, either send me the >

Re: [libvirt] [libvirt PATCH v3] news: Update for 4.8.0 release

2018-10-01 Thread Peter Krempa
On Mon, Oct 01, 2018 at 15:04:37 +0200, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > I went through the commits since last release and added a few notes > which seem to be relevant for the news. > > In case you notice there's something missing, please, either send me the >

Re: [libvirt] [PATCH 06/11] conf: Get rid of virDomainDeviceDefPostParseOne

2018-10-01 Thread Marc Hartmayer
On Mon, Oct 01, 2018 at 02:50 PM +0200, Peter Krempa wrote: > On Mon, Oct 01, 2018 at 14:38:40 +0200, Marc Hartmayer wrote: >> On Mon, Oct 01, 2018 at 12:41 PM +0200, Peter Krempa >> wrote: >> > On Mon, Oct 01, 2018 at 12:27:41 +0200, Marc Hartmayer wrote: >> >> On Sat, Sep 29, 2018 at 04:09 AM

[libvirt] [libvirt PATCH v3] news: Update for 4.8.0 release

2018-10-01 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- I went through the commits since last release and added a few notes which seem to be relevant for the news. In case you notice there's something missing, please, either send me the text to add it (and I'll re-sping this patch) and add the text before merging

Re: [libvirt] [PATCH 03/11] qemu: Pass QEMUCaps to virDomainDefPostParse

2018-10-01 Thread Peter Krempa
On Mon, Oct 01, 2018 at 14:58:11 +0200, Marc Hartmayer wrote: > On Mon, Oct 01, 2018 at 12:36 PM +0200, Peter Krempa > wrote: [...] > >> Yep, that’s why I said in the cover letter “With this patch series the > >> behavior is still not (completely) fixed, but the performance has been > >>

Re: [libvirt] [PATCH 03/11] qemu: Pass QEMUCaps to virDomainDefPostParse

2018-10-01 Thread Marc Hartmayer
On Mon, Oct 01, 2018 at 12:36 PM +0200, Peter Krempa wrote: […snip…] >> I would do all the precondition stuff (e.g. the priv->qemuCaps isn’t >> valid anymore) as early as possible in the overall “task/job” process. > > Well, technically priv->qemuCaps is invalid and unneeded when the VM is >

Re: [libvirt] [PATCH 06/11] conf: Get rid of virDomainDeviceDefPostParseOne

2018-10-01 Thread Peter Krempa
On Mon, Oct 01, 2018 at 14:38:40 +0200, Marc Hartmayer wrote: > On Mon, Oct 01, 2018 at 12:41 PM +0200, Peter Krempa > wrote: > > On Mon, Oct 01, 2018 at 12:27:41 +0200, Marc Hartmayer wrote: > >> On Sat, Sep 29, 2018 at 04:09 AM +0200, John Ferlan > >> wrote: > >> > On 9/20/18 1:44 PM, Marc

Re: [libvirt] [PATCH 04/11] conf: Use getParseOpaque() in virDomainObjSetDefTransient

2018-10-01 Thread Peter Krempa
On Thu, Sep 20, 2018 at 19:44:50 +0200, Marc Hartmayer wrote: > This allows the QEMU driver to use the originally used QEMU > capabilities for copying the domain. It avoids the usage of a possible > changed QEMU capability as virQEMUCapsCacheLookup might return a > different QEMU capability than

Re: [libvirt] [PATCH 06/11] conf: Get rid of virDomainDeviceDefPostParseOne

2018-10-01 Thread Marc Hartmayer
On Mon, Oct 01, 2018 at 12:41 PM +0200, Peter Krempa wrote: > On Mon, Oct 01, 2018 at 12:27:41 +0200, Marc Hartmayer wrote: >> On Sat, Sep 29, 2018 at 04:09 AM +0200, John Ferlan >> wrote: >> > On 9/20/18 1:44 PM, Marc Hartmayer wrote: >> >> Move the domainPostParseDataAlloc/Free calls to >> >>

Re: [libvirt] [Qemu-devel] [PATCH v4 2/4] block/rbd: Attempt to parse legacy filenames

2018-10-01 Thread Jeff Cody
On Sat, Sep 22, 2018 at 08:18:26AM +0200, Markus Armbruster wrote: > Jeff Cody writes: > > > When we converted rbd to get rid of the older key/value-centric > > encoding format, we broke compatibility with image files with backing > > file strings encoded in the old format. > > > > This leaves a

Re: [libvirt] [PATCH v2] news: Update for 4.8.0 release

2018-10-01 Thread Michal Privoznik
On 10/01/2018 01:58 PM, Erik Skultety wrote: > On Mon, Oct 01, 2018 at 12:57:18PM +0200, Fabiano Fidêncio wrote: >> Signed-off-by: Fabiano Fidêncio >> --- >> I went through the commits since last release and added a few notes >> which seem to be relevant for the news. >> >> In case you notice

Re: [libvirt] [RFC] Faster libvirtd restart with nwfilter rules

2018-10-01 Thread Nikolay Shirokovskiy
ping On 24.09.2018 10:41, Nikolay Shirokovskiy wrote: > Hi, all. > > > On fat hosts which are capable to run hundreds of VMs restarting libvirtd > makes it's services unavailable

Re: [libvirt] [PATCH v2] news: Update for 4.8.0 release

2018-10-01 Thread John Ferlan
On 10/1/18 6:57 AM, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > I went through the commits since last release and added a few notes > which seem to be relevant for the news. > > In case you notice there's something missing, please, either send me the > text to add it (and

Re: [libvirt] [PATCH v2] news: Update for 4.8.0 release

2018-10-01 Thread Erik Skultety
On Mon, Oct 01, 2018 at 12:57:18PM +0200, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > I went through the commits since last release and added a few notes > which seem to be relevant for the news. > > In case you notice there's something missing, please, either send me the >

Re: [libvirt] [PATCH] uml: Fix weird logic inside umlConnectOpen() function.

2018-10-01 Thread John Ferlan
On 9/28/18 12:13 AM, Julio Faracco wrote: > The pointer related to uml_driver needs to be checked before its usage > inside the function. Some attributes of the driver are being accessed > while the pointer is NULL considering the current logic. > I see it's pushed already... Perhaps

Re: [libvirt] [PATCH] security: dac: also label listen UNIX sockets

2018-10-01 Thread Ján Tomko
On Mon, Oct 01, 2018 at 10:22:59AM +0200, Erik Skultety wrote: On Thu, Sep 27, 2018 at 05:02:13PM +0200, Ján Tomko wrote: We switched to opening mode='bind' sockets ourselves: commit 30fb2276d88b275dc2aad6ddd28c100d944b59a5 qemu: support passing pre-opened UNIX socket listen FD in

[libvirt] [PATCH v2] news: Update for 4.8.0 release

2018-10-01 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- I went through the commits since last release and added a few notes which seem to be relevant for the news. In case you notice there's something missing, please, either send me the text to add it (and I'll re-sping this patch) and add the text before merging

Re: [libvirt] [PATCH] security: dac: also label listen UNIX sockets

2018-10-01 Thread Ján Tomko
On Mon, Oct 01, 2018 at 10:34:38AM +0200, Michal Privoznik wrote: On 09/27/2018 05:02 PM, Ján Tomko wrote: We switched to opening mode='bind' sockets ourselves: commit 30fb2276d88b275dc2aad6ddd28c100d944b59a5 qemu: support passing pre-opened UNIX socket listen FD in v4.5.0-rc1~251 Then

Re: [libvirt] [PATCH 08/11] conf: Use domainPostParseData(Alloc|Free) in virDomainDefValidate

2018-10-01 Thread Marc Hartmayer
On Sat, Sep 29, 2018 at 05:35 PM +0200, John Ferlan wrote: > On 9/20/18 1:44 PM, Marc Hartmayer wrote: >> For the usage of the parameter @parseOpqaue within >> virDomainDefValidate it must be ensured that the parameter >> @parseOpaque is not NULL. But since there are code paths where >>

Re: [libvirt] [PATCH 06/11] conf: Get rid of virDomainDeviceDefPostParseOne

2018-10-01 Thread Peter Krempa
On Mon, Oct 01, 2018 at 12:27:41 +0200, Marc Hartmayer wrote: > On Sat, Sep 29, 2018 at 04:09 AM +0200, John Ferlan > wrote: > > On 9/20/18 1:44 PM, Marc Hartmayer wrote: > >> Move the domainPostParseDataAlloc/Free calls to > >> virDomainDeviceDefParse. As an consequence > >>

Re: [libvirt] [PATCH 03/11] qemu: Pass QEMUCaps to virDomainDefPostParse

2018-10-01 Thread Peter Krempa
On Mon, Oct 01, 2018 at 10:31:36 +0200, Marc Hartmayer wrote: > On Mon, Oct 01, 2018 at 09:33 AM +0200, Peter Krempa > wrote: > > On Fri, Sep 28, 2018 at 22:02:59 -0400, John Ferlan wrote: > >> > >> > >> On 9/20/18 1:44 PM, Marc Hartmayer wrote: > >> > ...although priv->qemuCaps will be NULL in

Re: [libvirt] [libvirt PATCH] news: Update for 4.8.0 release

2018-10-01 Thread Fabiano Fidêncio
On Mon, 2018-10-01 at 11:48 +0200, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > I went through the commits since last release and added a few notes > which seem to be relevant for the news. > > In case you notice there's something missing, please, either send me > the > text

Re: [libvirt] [PATCH 07/11] conf: Extend virDomainDefValidate(Callback) for parseOpaque

2018-10-01 Thread Marc Hartmayer
On Sat, Sep 29, 2018 at 05:34 PM +0200, John Ferlan wrote: > On 9/20/18 1:44 PM, Marc Hartmayer wrote: >> Add @parseOpaque argument to virDomainDefValidate and >> virDomainDefValidateCallback, but don't use it for now since it's not >> ensured that it's always a non-NULL value. >> >>

Re: [libvirt] [PATCH 06/11] conf: Get rid of virDomainDeviceDefPostParseOne

2018-10-01 Thread Marc Hartmayer
On Sat, Sep 29, 2018 at 04:09 AM +0200, John Ferlan wrote: > On 9/20/18 1:44 PM, Marc Hartmayer wrote: >> Move the domainPostParseDataAlloc/Free calls to >> virDomainDeviceDefParse. As an consequence >> virDomainDeviceDefPostParseOne is superfluous and can therefore be >> removed. >> >>

[libvirt] [libvirt PATCH] news: Update for 4.8.0 release

2018-10-01 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- I went through the commits since last release and added a few notes which seem to be relevant for the news. In case you notice there's something missing, please, either send me the text to add it (and I'll re-sping this patch) and add the text before merging

Re: [libvirt] [PATCH 0/7] Various Coverity based concerns

2018-10-01 Thread Michal Privoznik
On 09/28/2018 05:28 PM, John Ferlan wrote: > I'm sure it'll be felt one or two could just be false positives, > but I have 35-40 of true false positives and it seems at least > these go above just noise on the channel. > > Perhaps the most difficult one to immediately see was the libxl > refcnt

Re: [libvirt] [PATCH 05/11] conf: Add function description for virDomainDefPostParse

2018-10-01 Thread Marc Hartmayer
On Sat, Sep 29, 2018 at 04:08 AM +0200, John Ferlan wrote: > On 9/20/18 1:44 PM, Marc Hartmayer wrote: >> Signed-off-by: Marc Hartmayer >> Reviewed-by: Boris Fiuczynski >> --- >> src/conf/domain_conf.c | 13 + >> 1 file changed, 13 insertions(+) >> >> diff --git

Re: [libvirt] [PATCH v2] qemu: agent: Avoid agentError when closing the QEMU agent

2018-10-01 Thread Michal Privoznik
On 09/28/2018 11:36 AM, Wang Yechao wrote: > After calling qemuAgentClose(), it is still possible for > the QEMU Agent I/O event callback to get invoked. This > will trigger an agent error because mon->fd has been set > to -1 at this point. Then vm->privateData->agentError is > always 'true'

Re: [libvirt] [PATCH 04/11] conf: Use getParseOpaque() in virDomainObjSetDefTransient

2018-10-01 Thread Marc Hartmayer
On Sat, Sep 29, 2018 at 04:06 AM +0200, John Ferlan wrote: > On 9/20/18 1:44 PM, Marc Hartmayer wrote: >> This allows the QEMU driver to use the originally used QEMU >> capabilities for copying the domain. It avoids the usage of a possible >> changed QEMU capability as virQEMUCapsCacheLookup

Re: [libvirt] [PATCH RFC] lxc: Include support to lxc version 3.0 and higher.

2018-10-01 Thread Michal Privoznik
On 10/01/2018 04:18 AM, Julio Faracco wrote: > This patch introduce the new settings for LXC 3.0 and higher. The older > versions keep the compatibility to deprecated settings for LXC, but > after release 3.0, the compatibility was removed. This commit adds the > support to the refactored

Re: [libvirt] [PATCH] tests: reintroduce tests for libxl's legacy nested setting

2018-10-01 Thread Erik Skultety
On Mon, Oct 01, 2018 at 08:04:57AM +0200, Erik Skultety wrote: > On Thu, Sep 27, 2018 at 08:25:53AM -0600, Jim Fehlig wrote: > > On 9/27/18 3:29 AM, Erik Skultety wrote: > > > On Wed, Sep 26, 2018 at 11:31:19AM -0600, Jim Fehlig wrote: > > > > The preferred location for setting the nested CPU flag

Re: [libvirt] [PATCH] security: dac: also label listen UNIX sockets

2018-10-01 Thread Michal Privoznik
On 09/27/2018 05:02 PM, Ján Tomko wrote: > We switched to opening mode='bind' sockets ourselves: > commit 30fb2276d88b275dc2aad6ddd28c100d944b59a5 > qemu: support passing pre-opened UNIX socket listen FD > in v4.5.0-rc1~251 > > Then fixed qemuBuildChrChardevStr to change libvirtd's label >

Re: [libvirt] [PATCH 03/11] qemu: Pass QEMUCaps to virDomainDefPostParse

2018-10-01 Thread Marc Hartmayer
On Mon, Oct 01, 2018 at 09:33 AM +0200, Peter Krempa wrote: > On Fri, Sep 28, 2018 at 22:02:59 -0400, John Ferlan wrote: >> >> >> On 9/20/18 1:44 PM, Marc Hartmayer wrote: >> > ...although priv->qemuCaps will be NULL in almost every case when the >> > post parse callback has failed. That may

Re: [libvirt] [PATCH] security: dac: also label listen UNIX sockets

2018-10-01 Thread Erik Skultety
On Thu, Sep 27, 2018 at 05:02:13PM +0200, Ján Tomko wrote: > We switched to opening mode='bind' sockets ourselves: > commit 30fb2276d88b275dc2aad6ddd28c100d944b59a5 > qemu: support passing pre-opened UNIX socket listen FD > in v4.5.0-rc1~251 > > Then fixed qemuBuildChrChardevStr to change

[libvirt] [PATCH] virFileIsSharedFSType: Check for fuse.glusterfs too

2018-10-01 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1632711 GlusterFS is typically safe when it comes to migration. It's a network FS after all. However, it can be mounted via FUSE driver they provide. If that is the case we fail to identify it and think migration is not safe and require

Re: [libvirt] [PATCH 03/11] qemu: Pass QEMUCaps to virDomainDefPostParse

2018-10-01 Thread Peter Krempa
On Fri, Sep 28, 2018 at 22:02:59 -0400, John Ferlan wrote: > > > On 9/20/18 1:44 PM, Marc Hartmayer wrote: > > ...although priv->qemuCaps will be NULL in almost every case when the > > post parse callback has failed. That may change in the future. > > > > Signed-off-by: Marc Hartmayer > >

Re: [libvirt] [PATCH] uml: Fix weird logic inside umlConnectOpen() function.

2018-10-01 Thread Erik Skultety
I reworded the commit subject a little and pushed. One more thing to note is that we don't put a 'period' at the end of a commit subject, I've noticed it in a few of your patches, it's just I kept removing them intuitively and always forgot to mention it :). Reviewed-by: Erik Skultety --

Re: [libvirt] [PATCH] tests: reintroduce tests for libxl's legacy nested setting

2018-10-01 Thread Erik Skultety
On Thu, Sep 27, 2018 at 08:25:53AM -0600, Jim Fehlig wrote: > On 9/27/18 3:29 AM, Erik Skultety wrote: > > On Wed, Sep 26, 2018 at 11:31:19AM -0600, Jim Fehlig wrote: > > > The preferred location for setting the nested CPU flag changed in > > > Xen 4.10 and is advertised via the