Creating a checkpoint does not modify guest-visible state,
but does modify host resources. Rather than reuse existing
domain:write, domain:block_write, or domain:snapshot access
controls, it seems better to introduce a new access control
specific to tasks related to checkpoints and incremental
The remote code generator had to be taught about the new
virDomainCheckpointPtr type, at which point the remote driver
code for backups can be generated.
Signed-off-by: Eric Blake
---
src/remote/remote_daemon_dispatch.c | 15 ++
src/remote/remote_driver.c | 33 +++-
The following is the latest version of my API proposal for
incremental backups.
I have even more work-in-progress patches on top of these:
https://repo.or.cz/libvirt/ericb.git
which I am slowly improving to be more in line with my thread
on the overview of the API usage:
Upcoming patches plan to introduce virDomainCheckpointPtr as a new
object for use in incremental backups, along with documentation on
how incremental backups differ from snapshots. But first, we need
to rename any existing mention of a 'system checkpoint' to instead
be a 'full system snapshot',
Prepare for new checkpoint and backup APIs by describing the XML
that will represent a checkpoint and backup. The checkpoint XML
is modeled heavily after virDomainSnapshotPtr, since both represent
a point in time of the guest (however, a snapshot exists with the
intent to roll back to that point,
Introduce a bunch of new public APIs related to backup checkpoints.
Checkpoints are modeled heavily after virDomainSnapshotPtr (both
represent a point in time of the guest), although a snapshot exists
with the intent of rolling back to that state, while a checkpoint
exists to make it possible to
Introduce a few more new public APIs related to incremental backups.
This builds on the previous notion of a checkpoint (without an
existing checkpoint, the new API is a full backup, differing only
from virDomainCopy in the point of time chosen); and also allows
creation of a new checkpoint at the
Upcoming patches will add support for incremental backups via
a new API; but first, we need a landing page that gives an
overview of capturing various pieces of guest state, and which
APIs are best suited to which tasks.
Signed-off-by: Eric Blake
---
v2: wording improvements based on review
---
An upcoming patch wants to reuse XML parsing of both unix and tcp
network host descriptions in the context of setting up a backup
NBD server. Make that easier by refactoring the existing parser.
Signed-off-by: Eric Blake
---
src/conf/domain_conf.h | 2 ++
src/conf/domain_conf.c | 43
Prepare for introducing a bunch of new public APIs related to
backup checkpoints by first introducing a new internal type
and errors associated with that type. Checkpoints are modeled
heavily after virDomainSnapshotPtr (both represent a point in
time of the guest), although a snapshot exists with
The commit 89563efc0209b854d2b2e554423423d7602acdbd fix the
monitor error when closing the QEMU monitor. The QEMU agent
has a problem similar to QEMU monitor. So fix the QEMU agent
with the same method.
Signed-off-by: Wang Yechao
---
Changes in v3:
- change the commit messages
---
The function was never defined in source, just the protoype.
Signed-off-by: John Ferlan
---
Pushed as trivial.
src/qemu/qemu_process.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/qemu/qemu_process.h b/src/qemu/qemu_process.h
index c2f7c2b5d2..2037467c94 100644
---
On 10/4/18 9:14 AM, Daniel Henrique Barboza wrote:
> This patch makes two quality of life changes for non-x86 guests. The
> first one is a maxCpus validation at qemuDomainDefValidate. The check
> is made by the same function used to do that at qemuProcessStartValidateXML,
>
On 10/11/18 8:03 AM, Michal Privoznik wrote:
> In the next commit the virSecurityManagerMetadataLock() is going
> to be turned thread unsafe. Therefore, we have to spawn a
> separate process for it. Always.
>
> Signed-off-by: Michal Privoznik
> ---
> src/security/security_dac.c | 12
On 10/11/2018 11:40 AM, Fabiano Fidêncio wrote:
The first patch is needed to properly support Q35 machine type on GNOME
Boxes (or any other app using libvirt-glib) as the ICH9 audio device
should be used together with Q35 machine type,
The second patch is mostly a convenience for the apps and
Commit 4f4c3b13 (v3.3) fixed an issue where cleaning libvirt objects
lost error messages, by adding code to copy the libvirt error into
last_error prior to cleanup paths. However, it caused a regression:
some errors are now printed twice, because libvirt still remembers in
its thread-local
On 10/11/2018 06:20 AM, Daniel P. Berrangé wrote:
> On Mon, Sep 24, 2018 at 10:41:37AM +0300, Nikolay Shirokovskiy wrote:
>
>> What speed up is possible on conservative approach? First we can remove for
>> test purpuses firewall ruleLock, gentech dirver updateMutex and filter object
>> mutex
On Thu, Oct 11, 2018 at 12:03:44PM -0400, John Ferlan wrote:
>
>
> On 9/29/18 6:58 AM, Peng Hao wrote:
> > sometimes we hoped that the memory of vm can be evenly distributed in
> > all nodes according to interleave mode. But different hosts
> > has different node number. So we add nodeset='all'
On 9/29/18 6:58 AM, Peng Hao wrote:
> Signed-off-by: Peng Hao
> ---
> docs/formatdomain.html.in | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
This should have been merged with patch 1
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index
On Sat, Sep 29, 2018 at 06:58:01PM +0800, Peng Hao wrote:
> sometimes we hoped that the memory of vm can be evenly distributed in
> all nodes according to interleave mode. But different hosts
> has different node number. So we add nodeset='all' for interleave mode.
>
> Signed-off-by: Peng Hao
>
On 9/29/18 6:58 AM, Peng Hao wrote:
> sometimes we hoped that the memory of vm can be evenly distributed in
> all nodes according to interleave mode. But different hosts
> has different node number. So we add nodeset='all' for interleave mode.
>
> Signed-off-by: Peng Hao
> ---
>
Adding Markus since we're talking about new CLI argument and capability
reporting standards.
On Fri, Sep 14, 2018 at 05:52:30PM +0400, Marc-André Lureau wrote:
> As discussed during "[PATCH v4 00/29] vhost-user for input & GPU"
> review, let's define a common set of backend conventions to help
Signed-off-by: Fabiano Fidêncio
---
libvirt-gconfig/libvirt-gconfig-domain-os.c | 7 +++
libvirt-gconfig/libvirt-gconfig-domain-os.h | 1 +
libvirt-gconfig/libvirt-gconfig.sym | 1 +
3 files changed, 9 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-os.c
The first patch is needed to properly support Q35 machine type on GNOME
Boxes (or any other app using libvirt-glib) as the ICH9 audio device
should be used together with Q35 machine type,
The second patch is mostly a convenience for the apps and the third one
just adds a test case for the second.
Signed-off-by: Fabiano Fidêncio
---
tests/test-gconfig.c| 2 ++
tests/xml/gconfig-domain-os.xml | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c
index a64da26..3328297 100644
--- a/tests/test-gconfig.c
+++
Signed-off-by: Fabiano Fidêncio
---
libvirt-gconfig/libvirt-gconfig-domain-sound.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-sound.h
b/libvirt-gconfig/libvirt-gconfig-domain-sound.h
index 8779754..41b0122 100644
---
On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote:
> # conf/device_conf.h
> +virDeviceInfoPCIAddressExtensionIsPresent;
> +virDeviceInfoPCIAddressExtensionIsWanted;
> virDeviceInfoPCIAddressIsPresent;
> virDeviceInfoPCIAddressIsWanted;
> virDomainDeviceAddressIsValid;
> @@ -119,6 +121,9 @@
On Thu, 2018-10-11 at 14:44 +0200, Andrea Bolognani wrote:
[...]
> With the above addressed,
>
> Reviewed-by: Andrea Bolognani
Forgot to mention: it would be really nice if you added a negative
test case showing that using zPCI addresses on eg. x86 will result
in a validation error.
--
On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote:
[...]
> +static int
> +qemuDomainDeviceDefValidateAddress(const virDomainDeviceDef *dev,
> + virQEMUCapsPtr qemuCaps)
> +{
> +virDomainDeviceInfoPtr info =
> +
On Thu, Oct 11, 2018 at 13:06:14 +0100, Dr. David Alan Gilbert wrote:
> * Peter Krempa (pkre...@redhat.com) wrote:
> > On Tue, Oct 09, 2018 at 19:34:43 +0200, Markus Armbruster wrote:
> > > Cc: libvir-list for review of the compatibility argument below.
> > >
> > > Daniel Henrique Barboza
* Peter Krempa (pkre...@redhat.com) wrote:
> On Tue, Oct 09, 2018 at 19:34:43 +0200, Markus Armbruster wrote:
> > Cc: libvir-list for review of the compatibility argument below.
> >
> > Daniel Henrique Barboza writes:
> >
> > > Hey David,
> > >
> > > On 9/21/18 9:29 AM, Dr. David Alan Gilbert
This reverts commit 22baf6e08c65d9174b24f66370724ce961ce9576.
Signed-off-by: Michal Privoznik
---
src/locking/lock_driver.h | 2 -
src/locking/lock_driver_lockd.c | 297 +++---
src/locking/lock_driver_sanlock.c | 37 ++--
3 files changed, 116 insertions(+),
This reverts commit aaf34cb9013d6d746f4edf9807408cb9dfbcf01d.
Signed-off-by: Michal Privoznik
---
src/locking/lock_driver_lockd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/locking/lock_driver_lockd.c b/src/locking/lock_driver_lockd.c
index
This reverts commit 3e26b476b5f322353bf0dcd8e3f037ca672b8c62.
Signed-off-by: Michal Privoznik
---
cfg.mk | 4 +---
src/lxc/lxc_controller.c | 3 +--
src/lxc/lxc_driver.c | 2 +-
src/qemu/qemu_driver.c | 3 ---
In the next commit the virSecurityManagerMetadataLock() is going
to be turned thread unsafe. Therefore, we have to spawn a
separate process for it. Always.
Signed-off-by: Michal Privoznik
---
src/security/security_dac.c | 12 ++--
src/security/security_selinux.c | 12 ++--
2
This reverts commit 8b8aefb3d6ae2139ea3d4ef6d7dd2c06f57f6075.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_conf.c | 1 -
src/qemu/qemu_conf.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 17b7e11e02..32da9a7351 100644
---
This reverts commit 21c34b86be5233634eb38f77be64e2263bfc4e48.
Signed-off-by: Michal Privoznik
---
src/locking/lock_daemon_dispatch.c | 10 ++
src/locking/lock_driver_lockd.c| 3 +--
src/locking/lock_driver_lockd.h| 1 -
3 files changed, 3 insertions(+), 11 deletions(-)
diff
This reverts commit 385eb8399bdb1610447c2857abfe99cee4a9fb9e.
Signed-off-by: Michal Privoznik
---
src/locking/lock_driver.h | 4 --
src/locking/lock_driver_lockd.c | 82 ++---
2 files changed, 24 insertions(+), 62 deletions(-)
diff --git
This reverts commit afd5a27575e8b6a494d2728552fe0e89c71e32b4.
Signed-off-by: Michal Privoznik
---
src/locking/lock_daemon_dispatch.c | 3 ---
src/util/virlockspace.c| 15 +--
src/util/virlockspace.h| 4
tests/virlockspacetest.c | 29
This reverts commit 35b5b244da825fb41e35e4dc62e740d716214ec9.
Signed-off-by: Michal Privoznik
---
src/locking/lock_driver.h | 4
src/locking/lock_driver_lockd.c | 4 +---
src/locking/lock_driver_sanlock.c | 4 +---
src/locking/lock_manager.c| 10 +++---
4 files
This reverts commit 997283b54b0e1f599aed3085ceba027eb8110acb.
Signed-off-by: Michal Privoznik
---
src/locking/lock_driver.h | 2 --
src/locking/lock_driver_lockd.c | 47 +--
src/locking/lock_driver_sanlock.c | 3 +-
3 files changed, 14 insertions(+), 38
v2 of:
https://www.redhat.com/archives/libvir-list/2018-October/msg00162.html
diff to v1 (all of this happened in 2/11 only):
- Moved virFileIsDir() and related checks into virSecurityManagerMetadataLock
- Use VIR_APPEND_ELEMENT_COPY_INPLACE() to properly fill FD array
- Lock sockets iff open()
Trying to use virlockd to lock metadata turns out to be too big
gun. Since we will always spawn a separate process for relabeling
we are safe to use thread unsafe POSIX locks and take out
virtlockd completely out of the picture.
Signed-off-by: Michal Privoznik
---
src/security/security_dac.c
Answers refined.
On 10/11/2018 3:14 AM, John Ferlan wrote:
>
> On 10/9/18 6:30 AM, Wang Huaqiang wrote:
>> In resctrl file system, more than one monitoring groups
>> could be created within one allocation group, along with
>> the creation of allocation group, a monitoring group is
>> created at
On CentOS 6, udev_monitor_receive_device will block until the socket becomes
readable, udevEventHandleThread will hold the lock all the time and
udevEventHandleCallback hard to get the lock, will block the event poll.
To fix this, set dataReady to false after receive an udev event.
Signed-off-by:
Hi Team,
Please share the XML format for virtual HBA or how can I assign virtual HBA
port to XEN vm.
Regards
Debaprasad
Sensitivity: Internal & Restricted
The information contained in this electronic message and any attachments to
this message are intended for the exclusive use of the
On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote:
> This patch introduces new XML parser/formatter functions. Uid is
> 16-bit and non-zero. Fid is 32-bit. They are the two attributes of zpci
> which is introduced as PCI address element. Zpci element is parsed and
> formatted along with PCI
On 11.10.2018 13:20, Daniel P. Berrangé wrote:
> On Mon, Sep 24, 2018 at 10:41:37AM +0300, Nikolay Shirokovskiy wrote:
>> Hi, all.
>>
>> On fat hosts which are capable to run hundreds of VMs restarting libvirtd
>> makes it's services unavailable for a long time if VMs use network filters.
>>
The URI parser used by libvirt does not populate uri->path if the
trailing slash is missing. The code virStorageSourceParseBackingURI
would then not populate src->path.
As only NBD network disks are allowed to have the 'name' field in the
XML defining the disk source omitted we'd generate an
The name is misleading. Change it to 'uristr' so that 'path' can be
reused in the proper context later.
Signed-off-by: Peter Krempa
---
src/util/virstoragefile.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index
see 2/2 for explanation
Peter Krempa (2):
util: storage: Rename '@path' argument of
virStorageSourceParseBackingURI
util: storage: Properly parse URIs with missing trailing slash
src/util/virstoragefile.c | 28 +---
tests/qemublocktest.c | 3 +++
On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote:
[...]
> +static void
> +virDomainPCIAddressSetExtensionFree(virDomainPCIAddressSetPtr addrs)
> +{
> +if (!addrs || !addrs->zpciIds)
> +return;
> +
> +virHashFree(addrs->zpciIds->uids);
> +virHashFree(addrs->zpciIds->fids);
>
On Mon, Sep 24, 2018 at 10:41:37AM +0300, Nikolay Shirokovskiy wrote:
> Hi, all.
>
> On fat hosts which are capable to run hundreds of VMs restarting libvirtd
> makes it's services unavailable for a long time if VMs use network filters. In
> my tests each of 100 VMs has no-promisc [1] and
在 2018/10/11 下午4:49, Andrea Bolognani 写道:
On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote:
[...]
@@ -166,6 +166,10 @@ struct _virDomainDeviceInfo {
* assignment, never saved and never reported.
*/
int pciConnectFlags; /* enum virDomainPCIConnectFlags */
+/*
Not built on Debian 8, as the version of OCaml is not new enough.
Signed-off-by: Pino Toscano
---
guests/host_vars/libvirt-centos-7/main.yml| 1 +
guests/host_vars/libvirt-debian-9/main.yml| 1 +
guests/host_vars/libvirt-debian-sid/main.yml | 1 +
Not built on Debian 8, as the version of OCaml is not new enough.
Signed-off-by: Pino Toscano
---
jobs/defaults.yaml | 2 ++
projects/libvirt-ocaml.yaml | 23 +++
2 files changed, 25 insertions(+)
create mode 100644 projects/libvirt-ocaml.yaml
diff --git
Soon to be used by libvirt-ocaml.
Signed-off-by: Pino Toscano
---
guests/vars/mappings.yml | 6 ++
1 file changed, 6 insertions(+)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index 5df918f..cd92bd8 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@
Now that the libvirt-ocaml repository is fixed, let's build it in CI.
Pino Toscano (3):
guests: add mappings for OCaml components
guests: add libvirt-ocaml project
projects: add libvirt-ocaml project
guests/host_vars/libvirt-centos-7/main.yml| 1 +
On Thu, 2018-10-11 at 10:37 +0200, Michal Privoznik wrote:
> The mock is built on Linux only. Therefore we should load it only
> on Linux too. This fixes the FreeBSD build.
>
> Signed-off-by: Michal Privoznik
> ---
> tests/virfiletest.c | 4
> 1 file changed, 4 insertions(+)
Reviewed-by:
On Thu, 2018-10-11 at 10:45 +0200, Martin Kletzander wrote:
> On Thu, Oct 11, 2018 at 10:20:34AM +0200, Andrea Bolognani wrote:
> > I was quite surprised, while reviewing some code, that an obvious
> > case of "space after cast" was not being caught by syntax-check; a
> > bit of digging made me
On 10/11/2018 3:15 AM, John Ferlan wrote:
>
>
> On 10/9/18 6:30 AM, Wang Huaqiang wrote:
>> Refactoring the code of matching the new resctrl with
>> existing resctrl groups. Add the virObjectRef action
>> into function virDomainResctrlVcpuMatch.
>>
>> Signed-off-by: Wang Huaqiang
>> ---
>>
On 10/11/2018 3:14 AM, John Ferlan wrote:
>
>
> On 10/9/18 6:30 AM, Wang Huaqiang wrote:
>> In resctrl file system, more than one monitoring groups
>> could be created within one allocation group, along with
>> the creation of allocation group, a monitoring group is
>> created at the same, which
On 10/11/2018 3:13 AM, John Ferlan wrote:
>
>
> On 10/9/18 6:30 AM, Wang Huaqiang wrote:
>> Add interfaces monitor group to support operations such
>> as add PID, set ID, remove group ... etc.
>>
>> The interface for getting cache occupancy information
>> from the monitor is also added.
>>
>>
On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote:
[...]
> @@ -166,6 +166,10 @@ struct _virDomainDeviceInfo {
> * assignment, never saved and never reported.
> */
> int pciConnectFlags; /* enum virDomainPCIConnectFlags */
> +/* pciAddrExtFlags is only used interanlly to
On 10/11/2018 3:13 AM, John Ferlan wrote:
>
> On 10/9/18 6:30 AM, Wang Huaqiang wrote:
>> Add interface for creating the resource monitoring group according
>> to '@virResctrlMonitor->path'.
>>
>> Signed-off-by: Wang Huaqiang
>> ---
>> src/libvirt_private.syms | 1 +
>> src/util/virresctrl.c
On Thu, Oct 11, 2018 at 10:20:34AM +0200, Andrea Bolognani wrote:
On Wed, 2018-04-25 at 15:24 +0200, Martin Kletzander wrote:
According to previous discussions it looks like this is the preferred way
of casting. One difference to the previous one is that this time I
tuned the regexp a bit so
The mock is built on Linux only. Therefore we should load it only
on Linux too. This fixes the FreeBSD build.
Signed-off-by: Michal Privoznik
---
tests/virfiletest.c | 4
1 file changed, 4 insertions(+)
diff --git a/tests/virfiletest.c b/tests/virfiletest.c
index d5102b1cc4..1f2be74c8d
在 2018/10/11 下午3:17, Andrea Bolognani 写道:
On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote:
[...]
struct _virPCIDeviceAddress {
unsigned int domain;
unsigned int bus;
unsigned int slot;
unsigned int function;
int multi; /* virTristateSwitch */
+
On Wed, 2018-04-25 at 15:24 +0200, Martin Kletzander wrote:
> According to previous discussions it looks like this is the preferred way
> of casting. One difference to the previous one is that this time I
> tuned the regexp a bit so that it doesn't match some macros and
> assignments and it also
On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote:
[...]
> struct _virPCIDeviceAddress {
> unsigned int domain;
> unsigned int bus;
> unsigned int slot;
> unsigned int function;
> int multi; /* virTristateSwitch */
> +virZPCIDeviceAddress zpci;
> };
It's kinda
70 matches
Mail list logo
