Re: [libvirt] [PATCH v6 07/13] conf: Introduce parser, formatter for uid and fid

2018-10-15 Thread Yi Min Zhao
在 2018/10/11 下午7:45, Andrea Bolognani 写道: On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote: This patch introduces new XML parser/formatter functions. Uid is 16-bit and non-zero. Fid is 32-bit. They are the two attributes of zpci which is introduced as PCI address element. Zpci element is

Re: [libvirt] [PATCH v6 09/13] conf: Allocate/release 'uid' and 'fid' in PCI address

2018-10-15 Thread Yi Min Zhao
在 2018/10/11 下午10:50, Andrea Bolognani 写道: On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote: # conf/device_conf.h +virDeviceInfoPCIAddressExtensionIsPresent; +virDeviceInfoPCIAddressExtensionIsWanted; virDeviceInfoPCIAddressIsPresent; virDeviceInfoPCIAddressIsWanted;

Re: [libvirt] [PATCH RFC v2] qemu: fix deadlock when waiting in non async jobs

2018-10-15 Thread John Ferlan
On 10/8/18 4:10 AM, Nikolay Shirokovskiy wrote: > Block job abort operation can not handle properly qemu crashes when waiting > for > abort/pivot completion. Deadlock scenario is next: > > - qemuDomainBlockJobAbort waits for pivot/abort completion > - qemu crashes, then

Re: [libvirt] [RFC PATCH auto partition NUMA guest domains v1 0/2] auto partition guests providing the host NUMA topology

2018-10-15 Thread Wim ten Have
On Tue, 25 Sep 2018 14:37:15 +0200 Jiri Denemark wrote: > On Tue, Sep 25, 2018 at 12:02:40 +0200, Wim Ten Have wrote: > > From: Wim ten Have > > > > This patch extends the guest domain administration adding support > > to automatically advertise the host NUMA node capabilities obtained > >

[libvirt] ANNOUNCE: virt-manager 2.0.0 released

2018-10-15 Thread Cole Robinson
I'm happy to announce the release of virt-manager 2.0.0! virt-manager is a desktop application for managing KVM, Xen, and LXC virtualization via libvirt. The release can be downloaded from: http://virt-manager.org/download/ The 2.0.0 isn't hugely significant here, the app will largely look

Re: [libvirt] [PATCHv5 13/19] conf: Add resctrl monitor configuration

2018-10-15 Thread John Ferlan
On 10/15/18 11:25 AM, Wang, Huaqiang wrote: > > On 10/13/2018 6:29 AM, John Ferlan wrote: >> >> On 10/12/18 3:10 AM, Wang, Huaqiang wrote: -Original Message- [...] IOW: What is cache_occupancy measuring? Each cache? The entire thing? If there's no cache elements,

Re: [libvirt] [PATCHv5 13/19] conf: Add resctrl monitor configuration

2018-10-15 Thread Wang, Huaqiang
On 10/13/2018 6:29 AM, John Ferlan wrote: On 10/12/18 3:10 AM, Wang, Huaqiang wrote: -Original Message- From: John Ferlan [mailto:jfer...@redhat.com] Sent: Thursday, October 11, 2018 4:58 AM To: Wang, Huaqiang ; libvir-list@redhat.com Cc: Feng, Shaohe ; Niu, Bing ; Ding, Jian-feng ;

Re: [libvirt] [PATCH 00/11] Allow modification of IOThread polling values (redux)

2018-10-15 Thread Christian Borntraeger
On 10/15/2018 04:28 PM, John Ferlan wrote: > > ping? > > Any takers or thoughts? No review, but I think it makes a lot of sense to expose these tuneables. > > Tks, > > John > > > On 10/7/18 9:00 AM, John Ferlan wrote: >> This series attempts to resurrect the concept of being able to modify

Re: [libvirt] [PATCH] conf: Fix bug in finding alloc through matching vcpus

2018-10-15 Thread John Ferlan
On 10/12/18 6:24 AM, Wang Huaqiang wrote: > The @alloc object returned by virDomainResctrlVcpuMatch is not > properly referenced and un-referenced in virDomainCachetuneDefParse. > > This patch fixes this problem. > > Signed-off-by: Wang Huaqiang > --- > src/conf/domain_conf.c | 4 +--- > 1

Re: [libvirt] [PATCH 00/11] Allow modification of IOThread polling values (redux)

2018-10-15 Thread John Ferlan
ping? Any takers or thoughts? Tks, John On 10/7/18 9:00 AM, John Ferlan wrote: > This series attempts to resurrect the concept of being able to modify > the IOThread polling parameters; however, in a slightly different > manner than the previous series posted by posted by Pavel Hrdina > : >

[libvirt] [PATCH 2/2] docs: Enhance polkit documentation to describe secondary connection

2018-10-15 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1631608 Since commit 8259255 usage of a primary connection driver for a virConnect has been modified to open (virConnectOpen) and use a connection to the specific driver in order to handle the API calls to/for that driver. This causes some confusion and

[libvirt] [PATCH 1/2] access: Modify the VIR_ERR_ACCESS_DENIED to include driverName

2018-10-15 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1631606 Changes made to manage and utilize a secondary connection driver to APIs outside the scope of the primary connection driver have resulted in some confusion processing polkit rules since the simple "access denied" error message doesn't provide

[libvirt] [PATCH 0/2] Augment access denied error message and adjust polkit docs

2018-10-15 Thread John Ferlan
Details in the patches John Ferlan (2): access: Modify the VIR_ERR_ACCESS_DENIED to include driverName docs: Enhance polkit documentation to describe secondary connection docs/aclpolkit.html.in| 117 ++ docs/libvirt.css | 1 +

[libvirt] [ocaml PATCH] doc: invoke ocamldoc with -colorize-code

2018-10-15 Thread Pino Toscano
This way, the OCaml snippets are colorized. The OCaml version required is higher than the first version shipping ocamldoc with this option, so that can be done unconditionally. Signed-off-by: Pino Toscano --- Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [ocaml PATCH 3/4] build: remove config.h.in

2018-10-15 Thread Pino Toscano
It is generated by autoheader, no need to keep it in the sources. Signed-off-by: Pino Toscano --- .gitignore | 1 + config.h.in | 61 - 2 files changed, 1 insertion(+), 61 deletions(-) delete mode 100644 config.h.in diff --git a/.gitignore

[libvirt] [ocaml PATCH 0/4] Misc build improvements

2018-10-15 Thread Pino Toscano
A round of few build system improvements: - use the OCaml build macros from libguestfs - remove generated stuff - use pkg-config to find & use libvirt Pino Toscano (4): build: move OCaml macros to a m4 subdir build: sync OCaml macros from libguestfs build: remove config.h.in build: use

Re: [libvirt] [ocaml PATCH] doc: invoke ocamldoc with -colorize-code

2018-10-15 Thread Richard W.M. Jones
On Mon, Oct 15, 2018 at 04:07:01PM +0200, Pino Toscano wrote: > This way, the OCaml snippets are colorized. > > The OCaml version required is higher than the first version shipping > ocamldoc with this option, so that can be done unconditionally. > > Signed-off-by: Pino Toscano > --- >

Re: [libvirt] [ocaml PATCH 0/4] Misc build improvements

2018-10-15 Thread Richard W.M. Jones
On Mon, Oct 15, 2018 at 04:02:31PM +0200, Pino Toscano wrote: > A round of few build system improvements: > - use the OCaml build macros from libguestfs > - remove generated stuff > - use pkg-config to find & use libvirt > > Pino Toscano (4): > build: move OCaml macros to a m4 subdir > build:

Re: [libvirt] [PATCH 1/2] conf: Forbid hugepages and

2018-10-15 Thread Michal Privoznik
On 10/15/2018 03:17 PM, Daniel P. Berrangé wrote: > On Mon, Oct 15, 2018 at 02:39:26PM +0200, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1633562 >> >> Under we allow users to configure various memory >> backing related knobs. However, there are some combinations that

[libvirt] [ocaml PATCH 4/4] build: use pkg-config to find libvirt

2018-10-15 Thread Pino Toscano
Rely on pkg-config to detect libvirt, and use its variables to locate it. The version required is taken from the API documentation. Signed-off-by: Pino Toscano --- configure.ac| 20 ++-- libvirt/Makefile.in | 14 -- 2 files changed, 10 insertions(+), 24

[libvirt] [ocaml PATCH 2/4] build: sync OCaml macros from libguestfs

2018-10-15 Thread Pino Toscano
Less old version, and work better with newer versions of autoconf. Adapt configure.ac to it: - use the different variable names set by AC_CHECK_OCAML_PKG - remove the comment about using ocamlfind, as it is what the new macros do already Signed-off-by: Pino Toscano --- configure.ac | 5 +-

[libvirt] [ocaml PATCH 1/4] build: move OCaml macros to a m4 subdir

2018-10-15 Thread Pino Toscano
This way they will not be overwritten when aclocal.m4 is changed. Signed-off-by: Pino Toscano --- .gitignore| 1 + configure.ac | 1 + aclocal.m4 => m4/ocaml.m4 | 0 3 files changed, 2 insertions(+) rename aclocal.m4 => m4/ocaml.m4 (100%) diff --git a/.gitignore

Re: [libvirt] [PATCH 1/2] conf: Forbid hugepages and

2018-10-15 Thread Daniel P . Berrangé
On Mon, Oct 15, 2018 at 02:39:26PM +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1633562 > > Under we allow users to configure various memory > backing related knobs. However, there are some combinations that > make no sense. For instance, requesting hugepages and

Re: [libvirt] [Qemu-devel] [PULL 0/2] Ui2 20181012 patches

2018-10-15 Thread Peter Maydell
On 12 October 2018 at 15:05, Gerd Hoffmann wrote: > The following changes since commit 69ac8c4cb93f2685839ff7b857cef306b388ff3c: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20181012' into > staging (2018-10-12 12:40:04 +0100) > > are available in the git repository at: > >

[libvirt] [PATCH 2/2] conf: Forbid hugepages and

2018-10-15 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1633562 Under we allow users to configure various memory backing related knobs. However, there are some combinations that make no sense. For instance, requesting hugepages and 'ondemand' allocation at the same time. Forbid this configuration then.

[libvirt] [PATCH 1/2] conf: Forbid hugepages and

2018-10-15 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1633562 Under we allow users to configure various memory backing related knobs. However, there are some combinations that make no sense. For instance, requesting hugepages and file allocation at the same time. Forbid this configuration then.

[libvirt] [PATCH 0/2] conf: Forbid some nonsensical combinations under

2018-10-15 Thread Michal Privoznik
*** BLURB HERE *** Michal Prívozník (2): conf: Forbid hugepages and conf: Forbid hugepages and src/conf/domain_conf.c| 25 +-- .../qemuxml2argvdata/hugepages-memaccess2.xml | 1 - 2 files changed, 23 insertions(+), 3 deletions(-) -- 2.18.1 --

[libvirt] [PATCH] version: Add ParseVersion and a Version struct

2018-10-15 Thread W. Trevor King
Make it easier to convert version integers to the more human-readable major.minor.release format. --- connect.go | 8 version.go | 52 ++ version_test.go | 64 + 3 files

[libvirt] [PATCH 2/3] qemu: vfio-ap device support

2018-10-15 Thread Boris Fiuczynski
Adjusting domain format documentation, adding device address support and adding command line generation for vfio-ap. Signed-off-by: Boris Fiuczynski Reviewed-by: Bjoern Walk --- docs/formatdomain.html.in | 3 ++- docs/schemas/domaincommon.rng | 1 + src/qemu/qemu_command.c| 8

[libvirt] [PATCH 0/3] qemu: guest dedicated crypto adapters

2018-10-15 Thread Boris Fiuczynski
This patch series introduces initial libvirt support for guest dedicated crypto adapters on S390. It allows to specify a vfio-ap mediated device in a domain. Extensive documentation about AP is available in patch 6 of the QEMU patch series. KVM/kernel: guest dedicated crypto adapters

[libvirt] [PATCH 1/3] qemu: add vfio-ap capability

2018-10-15 Thread Boris Fiuczynski
Introduce vfio-ap capability. Signed-off-by: Boris Fiuczynski Reviewed-by: Bjoern Walk --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index

[libvirt] [PATCH 3/3] news: Update news for vfio-ap support

2018-10-15 Thread Boris Fiuczynski
Signed-off-by: Boris Fiuczynski --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index dc08c96352..e5476a3332 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,6 +35,15 @@ + + + qemu: Add vfio AP

Re: [libvirt] [PATCHv5 10/19] cdtil: Introduce default monitor

2018-10-15 Thread Wang, Huaqiang
On 10/12/2018 11:18 PM, John Ferlan wrote: On 10/11/18 8:02 AM, Wang, Huaqiang wrote: Answers refined. On 10/11/2018 3:14 AM, John Ferlan wrote: On 10/9/18 6:30 AM, Wang Huaqiang wrote: In resctrl file system, more than one monitoring groups could be created within one allocation group,

Re: [libvirt] [RFC 0/7] Warn at runtime when deprecated features are used

2018-10-15 Thread Daniel P . Berrangé
On Sun, Oct 14, 2018 at 01:41:27PM +0200, Andrea Bolognani wrote: > On Fri, 2018-10-12 at 16:21 +0100, Daniel P. Berrangé wrote: > > On Wed, Oct 10, 2018 at 01:09:50PM +0200, Andrea Bolognani wrote: > > > So once we have these changes in place, command line users can be > > > pretty much

[libvirt] [PATCH] nwfilter: intantiate filters on loading driver

2018-10-15 Thread Nikolay Shirokovskiy
Before using filters binding filters instantiation was done by hypervisors drivers initialization code (qemu was the only such hypervisor). Now qemu reconnection done supposes it should be done by nwfilter driver probably. Let's add this missing step. Signed-off-by: Nikolay Shirokovskiy ---

Re: [libvirt] [PATCH v6 08/13] qemu: Add zPCI address definition check

2018-10-15 Thread Yi Min Zhao
在 2018/10/15 下午2:59, Andrea Bolognani 写道: On Mon, 2018-10-15 at 09:31 +0800, Yi Min Zhao wrote: 在 2018/10/11 下午9:08, Andrea Bolognani 写道: Forgot to mention: it would be really nice if you added a negative test case showing that using zPCI addresses on eg. x86 will result in a validation

Re: [libvirt] [PATCHv5 09/19] util: Add more interfaces for resctrl monitor

2018-10-15 Thread Wang, Huaqiang
On 10/12/2018 10:40 PM, John Ferlan wrote: [...] virResctrlMonitorCreate(virResctrlAllocPtr alloc, virResctrlMonitorPtr monitor, const char *machinename) @@ -2534,3 +2565,177 @@ virResctrlMonitorCreate(virResctrlAllocPtr alloc,

Re: [libvirt] [PATCH v6 00/13] PCI passthrough support on s390

2018-10-15 Thread Christian Borntraeger
On 10/15/2018 09:30 AM, Boris Fiuczynski wrote: > On 10/14/18 2:47 PM, Andrea Bolognani wrote: >> On Fri, 2018-10-12 at 16:04 +0100, Daniel P. Berrangé wrote: >>> On Fri, Sep 28, 2018 at 04:46:13PM +0800, Yi Min Zhao wrote: >> [...]      

Re: [libvirt] [PATCH v6 00/13] PCI passthrough support on s390

2018-10-15 Thread Boris Fiuczynski
On 10/14/18 2:47 PM, Andrea Bolognani wrote: On Fri, 2018-10-12 at 16:04 +0100, Daniel P. Berrangé wrote: On Fri, Sep 28, 2018 at 04:46:13PM +0800, Yi Min Zhao wrote: [...] I'm not sure if this was discussed in earlier versions, but to

Re: [libvirt] [PATCHv5 08/19] util: Add interface for creating monitor group

2018-10-15 Thread Wang, Huaqiang
On 10/12/2018 10:27 PM, John Ferlan wrote: [...] 402 virResctrlMonitorDispose(void *obj) 403 { 404 virResctrlMonitorPtr monitor = obj; 405 406 virObjectUnref(monitor->alloc); 407 VIR_FREE(monitor->id); 408 VIR_FREE(monitor->path); 409 } The one "thing"

Re: [libvirt] [PATCH v6 08/13] qemu: Add zPCI address definition check

2018-10-15 Thread Andrea Bolognani
On Mon, 2018-10-15 at 09:31 +0800, Yi Min Zhao wrote: > 在 2018/10/11 下午9:08, Andrea Bolognani 写道: > > Forgot to mention: it would be really nice if you added a negative > > test case showing that using zPCI addresses on eg. x86 will result > > in a validation error. > > OK. Let me have a try.