Re: [libvirt] [PATCH 2/9] Add semicolon to VIR_ENUM_IMPL calls

2019-02-03 Thread Cole Robinson
On 1/28/19 2:41 PM, John Ferlan wrote: On 1/23/19 5:46 PM, Cole Robinson wrote: Missing semicolon at the end of macros can confuse some analyzers (like cppcheck ), and we have a mix of semicolon and non-semicolon usage through the code. Let's standardize on using a semicolon for VIR_ENUM_IMPL

[libvirt] ANNOUNCE: virt-manager 2.1.0 released

2019-02-03 Thread Cole Robinson
I'm happy to announce the release of virt-manager 2.1.0! The release can be downloaded from: http://virt-manager.org/download/ This release includes: - Bash autocompletion support (Lin Ma, Cole Robinson) - UI and command line --vsock support (Slavomir Kaslev) - virt-xml: Add --os-variant

Re: [libvirt] [PULL 0/5] Ui 20190201 patches

2019-02-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190201123100.27419-1-kra...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[libvirt] [PATCH] util: remove test code accidentally committed to virFirewallDZoneExists

2019-02-03 Thread Laine Stump
Just before pushing the series containing commit 3bba4825 I had added a "return true" to the top of virFirewallDZoneExists() to measure the impact of calling that function once per network during startup. I found that the effect was minimal, but forgot to remove the "return true" before pushing.