On Mon, Feb 11, 2019 at 10:14:56PM -0500, John Ferlan wrote:
On 2/11/19 7:52 AM, Ján Tomko wrote:
On Fri, Feb 08, 2019 at 01:37:06PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities. This also allows
for the cleanup of some goto paths.
Signed-off-by: John Ferlan
On Mon, Feb 11, 2019 at 09:33:53PM -0500, John Ferlan wrote:
On 2/11/19 9:52 AM, Ján Tomko wrote:
On Mon, Feb 11, 2019 at 07:41:41AM -0500, John Ferlan wrote:
On 2/11/19 7:33 AM, Ján Tomko wrote:
On Fri, Feb 08, 2019 at 01:37:05PM -0500, John Ferlan wrote:
Let's make use of the auto
On 2/11/19 7:52 AM, Ján Tomko wrote:
> On Fri, Feb 08, 2019 at 01:37:06PM -0500, John Ferlan wrote:
>> Let's make use of the auto __cleanup capabilities. This also allows
>> for the cleanup of some goto paths.
>>
>> Signed-off-by: John Ferlan
>> ---
>> src/storage/storage_backend.c
On 2/11/19 9:52 AM, Ján Tomko wrote:
> On Mon, Feb 11, 2019 at 07:41:41AM -0500, John Ferlan wrote:
>>
>>
>> On 2/11/19 7:33 AM, Ján Tomko wrote:
>>> On Fri, Feb 08, 2019 at 01:37:05PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
now
On 2/6/19 2:18 PM, Eric Blake wrote:
> The remote code generator had to be taught about the new
> virDomainCheckpointPtr type, at which point the remote driver
> code for backups can be generated.
>
> Signed-off-by: Eric Blake
> ---
> src/remote/remote_daemon_dispatch.c | 22 ++-
>
On 2/6/19 2:18 PM, Eric Blake wrote:
> Creating a checkpoint does not modify guest-visible state,
> but does modify host resources. Rather than reuse existing
> domain:write, domain:block_write, or domain:snapshot access
> controls, it seems better to introduce a new access control
> specific
On 2/6/19 2:18 PM, Eric Blake wrote:
> Introduce a few more new public APIs related to incremental backups.
> This builds on the previous notion of a checkpoint (without an
> existing checkpoint, the new API is a full backup, differing only
> from virDomainCopy in the point of time chosen); and
On 2/6/19 2:18 PM, Eric Blake wrote:
> Introduce a bunch of new public APIs related to backup checkpoints.
> Checkpoints are modeled heavily after virDomainSnapshotPtr (both
> represent a point in time of the guest), although a snapshot exists
> with the intent of rolling back to that state,
On 2/11/19 9:56 AM, Daniel P. Berrangé wrote:
On Mon, Feb 11, 2019 at 09:51:09AM -0500, Laine Stump wrote:
On 2/11/19 6:11 AM, Daniel P. Berrangé wrote:
On Mon, Feb 11, 2019 at 06:07:40AM -0500, Laine Stump wrote:
On Mon, Feb 11, 2019, 5:50 AM Daniel P. Berrangé
wrote:
On Sat, Feb 09, 2019
On Mon, 2019-02-11 at 08:53 +, Nikolay Shirokovskiy wrote:
> On 08.02.2019 18:02, Andrea Bolognani wrote:
> > On Thu, 2019-02-07 at 14:31 +0300, Nikolay Shirokovskiy wrote:
> > [...]
> > > @@ -393,9 +393,11 @@ qemuBuildDeviceAddressStr(virBufferPtr buf,
> > >
On 2/11/19 9:43 AM, Daniel P. Berrangé wrote:
> QEMU will refuse to live migrate with the default caching mode, so we
> must explicitly set cache=none for the migration tests to pass.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> lib/Sys/Virt/TCK/DomainBuilder.pm | 11 ---
> 1 file
On Fri, Feb 08, 2019 at 12:23:23PM +0100, Michal Privoznik wrote:
While implementing some other feature I wanted to use wireshark to debug
a migration issue. Only then I found that our wireshark plugin is no
longer being loaded. Here are the fixes.
Michal Prívozník (5):
tools: Cleanup
On Fri, Feb 08, 2019 at 12:23:28PM +0100, Michal Privoznik wrote:
The wireshark-2.4.0 is almost 2 years old now. Assuming anybody
While 2 years is not that much given our support page:
https://libvirt.org/platforms.html
the wireshark plugin was always an exception to those
interested in
On Fri, Feb 08, 2019 at 12:23:27PM +0100, Michal Privoznik wrote:
Since wirshark-2.5.0 toplevel plugins are no longer loaded. Only
plugins from epan/, wiretap/ or codecs/ subdirs are. Update the
plugin dir we generate. This is safe to do even for older
wiresharks, since they load plugins from
On Mon, Feb 11, 2019 at 03:23:31PM +, Daniel P. Berrangé wrote:
> On Mon, Feb 11, 2019 at 04:11:55PM +0100, Erik Skultety wrote:
> > Also enforce the enum type for MigrateSetMaxSpeed and MigrateGetMaxSpeed
> > functions which previously accepted generic uint32 type since the flags
> > haven't
On Sun, Feb 10, 2019 at 07:08:53PM +0400, Roman Bogorodskiy wrote:
bhyve(8) uses PCI ISA bridge to attach serial ports and a boot ROM.
In the libvirt driver a PCI slot 1 was always reserved for that, and
if a domain used serial ports or a boot ROM, then it would be added
to the command line.
https://bugzilla.redhat.com/show_bug.cgi?id=1624204
The guestfwd channels are -netdevs really. Hotunplug them as
such. Also, DEVICE_DELETED event is not triggered (surprisingly,
since we're not issuing device_del rather than netdev_del) and
associated chardev is removed automagically too. This
Previous two commits demonstrate a hole in our test scenario.
Fix that.
Signed-off-by: Michal Privoznik
---
tests/qemuhotplugtest.c | 6 ++
.../qemuhotplug-guestfwd.xml | 4 ++
.../qemuhotplug-base-live+guestfwd.xml| 55 +++
3
Introduced by d86c876a66e3.
There is no real need to have "user-" prefix for chardev.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_command.c | 2 +-
tests/qemuxml2argvdata/channel-guestfwd.args | 2 +-
https://bugzilla.redhat.com/show_bug.cgi?id=1624204
The guestfwd channels are -netdevs really. Hotplug them as such.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_hotplug.c | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c
*** BLURB HERE ***
Michal Prívozník (5):
qemuDomainDetachChrDevice: Use @tmpChr to build device string
qemuL: Drop "user-" prefix for guestfwd netdev
qemu_hotplug: Attach guestfwd using netdev_add
qemu_hotplug: Detach guestfwd using netdev_del
qemuhotplugtest: Test guestfwd attach and
So far we are passing @chr to qemuBuildChrDeviceStr. This is
suboptimal beacuse @chr is just parsed XML definition provided by
user which by definition may lack some information. On the other
hand, @tmpChr is the one that was found using @chr in domain
definition so it contains the same amount of
s/completor/completer/ in the commit summary
On Mon, Feb 11, 2019 at 02:22:30PM +, Daniel P. Berrangé wrote:
The function must return a pointer, not a boolean. Fortunately 'false'
is equivalent to 'NULL' so this bug no had ill effect previously.
Signed-off-by: Daniel P. Berrangé
---
On Thu, Feb 07, 2019 at 04:39:52PM -0600, Eric Blake wrote:
> Python counterpart to:
> https://www.redhat.com/archives/libvir-list/2019-February/msg00252.html
>
> I'll push patch 1 now as a trivial fix; patch 2 can't go in until
> the corresponding libvirt patches are accepted (which may in turn
On Mon, Feb 11, 2019 at 04:11:55PM +0100, Erik Skultety wrote:
> Also enforce the enum type for MigrateSetMaxSpeed and MigrateGetMaxSpeed
> functions which previously accepted generic uint32 type since the flags
> haven't been in use.
FWIW, Erik asked me about this change off-list.
Technically
> So from your output it seems:
>
> virStorageFileMetadataNew
> virStorageFileGetMetadataFromFD
> virStorageSourceCopy
> virStorageSourceUpdateCapacity
> virStorageSourceNewFromBackingAbsolute
> virStorageSourceNewFromBacking
> virStorageFileGetMetadataRecurse
> virStorageFileGetBackingStoreStr
>
On Mon, Feb 11, 2019 at 04:11:54PM +0100, Erik Skultety wrote:
> Signed-off-by: Erik Skultety
> ---
> domain.go | 4
> domain_compat.h | 5 +
> 2 files changed, 9 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-
Also enforce the enum type for MigrateSetMaxSpeed and MigrateGetMaxSpeed
functions which previously accepted generic uint32 type since the flags
haven't been in use.
Signed-off-by: Erik Skultety
---
domain.go | 10 --
domain_compat.h | 4
2 files changed, 12 insertions(+), 2
Erik Skultety (2):
Add VIR_MIGRATE_PARAM_BANDWIDTH_POSTCOPY constant
Introduce DomainMigrateMaxSpeedFlags constant
domain.go | 14 --
domain_compat.h | 9 +
2 files changed, 21 insertions(+), 2 deletions(-)
--
2.20.1
--
libvir-list mailing list
Signed-off-by: Erik Skultety
---
domain.go | 4
domain_compat.h | 5 +
2 files changed, 9 insertions(+)
diff --git a/domain.go b/domain.go
index 98dd290..f4546b8 100644
--- a/domain.go
+++ b/domain.go
@@ -2309,6 +2309,10 @@ func getMigrateParameterFieldInfo(params
On Mon, Feb 11, 2019 at 09:51:09AM -0500, Laine Stump wrote:
> On 2/11/19 6:11 AM, Daniel P. Berrangé wrote:
> > On Mon, Feb 11, 2019 at 06:07:40AM -0500, Laine Stump wrote:
> > > On Mon, Feb 11, 2019, 5:50 AM Daniel P. Berrangé
> > > wrote:
> > >
> > > > On Sat, Feb 09, 2019 at 02:03:05PM
On Mon, Feb 11, 2019 at 07:41:41AM -0500, John Ferlan wrote:
On 2/11/19 7:33 AM, Ján Tomko wrote:
On Fri, Feb 08, 2019 at 01:37:05PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
On 2/11/19 6:11 AM, Daniel P. Berrangé wrote:
On Mon, Feb 11, 2019 at 06:07:40AM -0500, Laine Stump wrote:
On Mon, Feb 11, 2019, 5:50 AM Daniel P. Berrangé
wrote:
On Sat, Feb 09, 2019 at 02:03:05PM -0500, Laine Stump wrote:
Since this test (050-apply-verify-host.t), we can't use a regexp in
On Thu, Feb 07, 2019 at 04:39:54PM -0600, Eric Blake wrote:
> Copies heavily from existing virDomainSnapshot handling, regarding
> what special cases the generator has to be taught and what overrides
> need to be written.
>
> Signed-off-by: Eric Blake
> ---
> HACKING
On Thu, Feb 07, 2019 at 04:39:53PM -0600, Eric Blake wrote:
> Signed-off-by: Eric Blake
> ---
> generator.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/generator.py b/generator.py
> index 6cb923f..ffa3ce5 100755
> --- a/generator.py
> +++ b/generator.py
> @@
On 2/11/19 6:12 AM, Daniel P. Berrangé wrote:
On Mon, Feb 11, 2019 at 06:10:38AM -0500, Laine Stump wrote:
On Mon, Feb 11, 2019, 5:47 AM Daniel P. Berrangé
wrote:
On Thu, Feb 07, 2019 at 10:08:28PM -0500, Laine Stump wrote:
RHEL8 has dropped support for qcow1 format images, so skip the
QEMU will refuse to live migrate with the default caching mode, so we
must explicitly set cache=none for the migration tests to pass.
Signed-off-by: Daniel P. Berrangé
---
lib/Sys/Virt/TCK/DomainBuilder.pm | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git
On 2/11/19 8:45 AM, Erik Skultety wrote:
> On Mon, Feb 11, 2019 at 08:33:32AM -0500, John Ferlan wrote:
>>
>>
>> On 2/11/19 7:44 AM, Erik Skultety wrote:
>>> On Fri, Feb 08, 2019 at 01:37:26PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
The function must return a pointer, not a boolean. Fortunately 'false'
is equivalent to 'NULL' so this bug no had ill effect previously.
Signed-off-by: Daniel P. Berrangé
---
tools/virsh-completer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh-completer.c
On Fri, Feb 08, 2019 at 01:37:26PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.c| 3 +-
src/qemu/qemu_domain.c| 3 +-
On Fri, Feb 08, 2019 at 01:37:25PM -0500, John Ferlan wrote:
To prepare for subsequent change to use VIR_AUTOPTR logic rename
the @ret to @def.
Signed-off-by: John Ferlan
---
tests/virstoragetest.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Ján
On Fri, Feb 08, 2019 at 01:37:24PM -0500, John Ferlan wrote:
To prepare for subsequent change to use VIR_AUTOPTR logic rename
the @ret to @def.
Signed-off-by: John Ferlan
---
src/util/virstoragefile.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
On Fri, Feb 08, 2019 at 01:37:23PM -0500, John Ferlan wrote:
To prepare for subsequent change to use VIR_AUTOPTR logic rename
the @ret to @def.
Signed-off-by: John Ferlan
---
src/util/virstoragefile.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
On Fri, Feb 08, 2019 at 01:37:22PM -0500, John Ferlan wrote:
To prepare for subsequent change to use VIR_AUTOPTR logic rename
the @ret to @def.
Signed-off-by: John Ferlan
---
src/util/virstoragefile.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
On Fri, Feb 08, 2019 at 01:37:21PM -0500, John Ferlan wrote:
To prepare for subsequent change to use VIR_AUTOPTR logic rename
the @ret to @def.
Signed-off-by: John Ferlan
---
src/util/virstoragefile.c | 96 +++
1 file changed, 48 insertions(+), 48
On Fri, Feb 08, 2019 at 01:37:20PM -0500, John Ferlan wrote:
To prepare for subsequent change to use VIR_AUTOPTR logic rename
the @ret to @def.
I guess we could call it a definition even though it does not have 'Def'
in its type name.
Signed-off-by: John Ferlan
---
On Fri, Feb 08, 2019 at 01:37:19PM -0500, John Ferlan wrote:
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/storage/storage_util.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
--
On Fri, Feb 08, 2019 at 01:37:18PM -0500, John Ferlan wrote:
Only one path will consume the @def; otherwise, we need to free it.
Signed-off-by: John Ferlan
---
tests/storagepoolxml2argvtest.c | 4
1 file changed, 4 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description:
On Fri, Feb 08, 2019 at 01:37:17PM -0500, John Ferlan wrote:
Modify code to use the VIR_AUTOCLOSE logic cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/storage/storage_backend_logical.c | 3 +-
src/storage/storage_backend_scsi.c|
On Mon, Feb 11, 2019 at 08:18:13AM -0500, John Ferlan wrote:
>
>
> On 2/11/19 7:24 AM, Erik Skultety wrote:
> > On Fri, Feb 08, 2019 at 01:37:18PM -0500, John Ferlan wrote:
> >> Only one path will consume the @def; otherwise, we need to free it.
> >>
> >> Signed-off-by: John Ferlan
> >> ---
> >>
On Mon, Feb 11, 2019 at 08:33:32AM -0500, John Ferlan wrote:
>
>
> On 2/11/19 7:44 AM, Erik Skultety wrote:
> > On Fri, Feb 08, 2019 at 01:37:26PM -0500, John Ferlan wrote:
> >> Let's make use of the auto __cleanup capabilities cleaning up any
> >> now unnecessary goto paths.
> >>
> >>
On Mon, Feb 11, 2019 at 02:40:55PM +0100, Andrea Bolognani wrote:
> On Mon, 2019-02-11 at 08:14 +, Nikolay Shirokovskiy wrote:
> > On 08.02.2019 17:34, Andrea Bolognani wrote:
> > > Even with that fixed, while your code prevents a element
> > > associated to the isa-debugcon to be
On Mon, 2019-02-11 at 08:14 +, Nikolay Shirokovskiy wrote:
> On 08.02.2019 17:34, Andrea Bolognani wrote:
> > Even with that fixed, while your code prevents a element
> > associated to the isa-debugcon to be automatically created, it
> > doesn't prevent something like
> >
> >
> >
> >
On Fri, Feb 08, 2019 at 01:37:16PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
tests/storagebackendsheepdogtest.c | 50 --
On Fri, Feb 08, 2019 at 01:37:15PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/test/test_driver.c | 169 -
1 file
On Fri, Feb 08, 2019 at 01:37:14PM -0500, John Ferlan wrote:
Commit 390c06b67 added @xml, but it was never used.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/test/test_driver.c | 2 --
1 file changed, 2 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description:
On Fri, Feb 08, 2019 at 01:37:13PM -0500, John Ferlan wrote:
Rather than have a need for old_dom_name, let's just VIR_FREE
the old name first, then use VIR_STEAL_PTR to handle the swap
from the old name to the new name.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
On 2/11/19 7:44 AM, Erik Skultety wrote:
> On Fri, Feb 08, 2019 at 01:37:26PM -0500, John Ferlan wrote:
>> Let's make use of the auto __cleanup capabilities cleaning up any
>> now unnecessary goto paths.
>>
>> Signed-off-by: John Ferlan
>> ---
> ...
>> target->backingStore->type =
On Fri, 2019-02-08 at 15:09 -0200, Daniel Henrique Barboza wrote:
> On 2/8/19 3:07 PM, Andrea Bolognani wrote:
> > On Fri, 2019-02-08 at 14:14 +0100, Jiri Denemark wrote:
> > > Anyway, the virNodeInfo structure is just not flexible enough to deal
> > > with all possible topologies and users are
On Fri, Feb 08, 2019 at 01:37:12PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/util/virstoragefile.c | 128 ++
1 file
On Fri, Feb 08, 2019 at 01:37:11PM -0500, John Ferlan wrote:
virStorageFileGetRelativeBackingPath and virStorageFileGetMetadataRecurse
open coded.
There might be a missing.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/util/virstoragefile.c | 6 ++
1 file changed, 2
On Fri, Feb 08, 2019 at 01:37:10PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/conf/storage_conf.c | 179 +---
1 file
On Fri, Feb 08, 2019 at 01:37:09PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
---
src/storage/storage_util.c | 335 +
1 file changed, 113 insertions(+),
On 2/11/19 7:24 AM, Erik Skultety wrote:
> On Fri, Feb 08, 2019 at 01:37:18PM -0500, John Ferlan wrote:
>> Only one path will consume the @def; otherwise, we need to free it.
>>
>> Signed-off-by: John Ferlan
>> ---
>> tests/storagepoolxml2argvtest.c | 4
>> 1 file changed, 4
On Fri, Feb 08, 2019 at 01:37:08PM -0500, John Ferlan wrote:
Commit a523770c3 added @retval return processing for
virStorageBackendUpdateVolInfo in order to allow a -2
to be return; however, upon successful completion
@retval = 0 and if either the virStorageBackendSCSISerial
or the
On Fri, Feb 08, 2019 at 01:37:07PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/storage/storage_driver.c | 70
1 file
On Wed, Feb 06, 2019 at 08:41:40AM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
---
src/storage/storage_driver.c | 70
1 file changed, 23 insertions(+), 47
On Mon, Feb 11, 2019 at 07:14:26AM -0500, John Ferlan wrote:
>
>
> On 2/11/19 6:12 AM, Daniel P. Berrangé wrote:
> > On Mon, Feb 11, 2019 at 06:10:38AM -0500, Laine Stump wrote:
> >> On Mon, Feb 11, 2019, 5:47 AM Daniel P. Berrangé
> >> wrote:
> >>
> >>> On Thu, Feb 07, 2019 at 10:08:28PM
On Fri, Feb 08, 2019 at 01:37:06PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities. This also allows
for the cleanup of some goto paths.
Signed-off-by: John Ferlan
---
src/storage/storage_backend.c | 9 +--
src/storage/storage_backend_disk.c |
On Fri, Feb 08, 2019 at 01:37:26PM -0500, John Ferlan wrote:
> Let's make use of the auto __cleanup capabilities cleaning up any
> now unnecessary goto paths.
>
> Signed-off-by: John Ferlan
> ---
...
> target->backingStore->type = VIR_STORAGE_TYPE_NETWORK;
>
On 2/11/19 7:33 AM, Ján Tomko wrote:
> On Fri, Feb 08, 2019 at 01:37:05PM -0500, John Ferlan wrote:
>> Let's make use of the auto __cleanup capabilities cleaning up any
>> now unnecessary goto paths.
>>
>> Signed-off-by: John Ferlan
>> Reviewed-by: Erik Skultety
>> ---
>>
On Fri, Feb 08, 2019 at 01:37:05PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/storage/storage_backend_disk.c | 85 +
On Fri, Feb 08, 2019 at 01:37:24PM -0500, John Ferlan wrote:
> To prepare for subsequent change to use VIR_AUTOPTR logic rename
> the @ret to @def.
>
> Signed-off-by: John Ferlan
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On Fri, Feb 08, 2019 at 01:37:25PM -0500, John Ferlan wrote:
> To prepare for subsequent change to use VIR_AUTOPTR logic rename
> the @ret to @def.
>
> Signed-off-by: John Ferlan
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On Fri, Feb 08, 2019 at 01:37:23PM -0500, John Ferlan wrote:
> To prepare for subsequent change to use VIR_AUTOPTR logic rename
> the @ret to @def.
>
> Signed-off-by: John Ferlan
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On Fri, Feb 08, 2019 at 01:37:22PM -0500, John Ferlan wrote:
> To prepare for subsequent change to use VIR_AUTOPTR logic rename
> the @ret to @def.
>
> Signed-off-by: John Ferlan
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On Fri, Feb 08, 2019 at 01:37:21PM -0500, John Ferlan wrote:
> To prepare for subsequent change to use VIR_AUTOPTR logic rename
> the @ret to @def.
>
> Signed-off-by: John Ferlan
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On Fri, Feb 08, 2019 at 01:37:20PM -0500, John Ferlan wrote:
> To prepare for subsequent change to use VIR_AUTOPTR logic rename
> the @ret to @def.
>
> Signed-off-by: John Ferlan
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On Fri, Feb 08, 2019 at 01:37:18PM -0500, John Ferlan wrote:
> Only one path will consume the @def; otherwise, we need to free it.
>
> Signed-off-by: John Ferlan
> ---
> tests/storagepoolxml2argvtest.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/storagepoolxml2argvtest.c
On 2/11/19 5:39 AM, Erik Skultety wrote:
> On Fri, Feb 08, 2019 at 01:37:06PM -0500, John Ferlan wrote:
>> Let's make use of the auto __cleanup capabilities. This also allows
>> for the cleanup of some goto paths.
>>
>> Signed-off-by: John Ferlan
>> ---
>
>> @@ -459,15 +454,15 @@
On Fri, Feb 08, 2019 at 01:37:04PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/storage/storage_backend_iscsi_direct.c | 3 +-
On 2/11/19 6:12 AM, Daniel P. Berrangé wrote:
> On Mon, Feb 11, 2019 at 06:10:38AM -0500, Laine Stump wrote:
>> On Mon, Feb 11, 2019, 5:47 AM Daniel P. Berrangé
>> wrote:
>>
>>> On Thu, Feb 07, 2019 at 10:08:28PM -0500, Laine Stump wrote:
RHEL8 has dropped support for qcow1 format images,
On Fri, Feb 08, 2019 at 01:37:03PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/conf/domain_conf.c | 3 +--
src/conf/storage_conf.c|
On Fri, Feb 08, 2019 at 01:37:02PM -0500, John Ferlan wrote:
Rather than having an error path, let's rework the code to allocate
and fill into an @def variable and then steal that into @ret when we
are successful leaving just a cleanup: path.
Signed-off-by: John Ferlan
---
On Fri, Feb 08, 2019 at 01:37:09PM -0500, John Ferlan wrote:
> Let's make use of the auto __cleanup capabilities cleaning up any
> now unnecessary goto paths.
>
> Signed-off-by: John Ferlan
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On Fri, Feb 08, 2019 at 01:37:08PM -0500, John Ferlan wrote:
> Commit a523770c3 added @retval return processing for
> virStorageBackendUpdateVolInfo in order to allow a -2
> to be return; however, upon successful completion
> @retval = 0 and if either the virStorageBackendSCSISerial
> or the
On Fri, Feb 08, 2019 at 01:37:01PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/conf/storage_conf.c| 3 +--
src/conf/storage_conf.h
On Fri, Feb 08, 2019 at 01:37:00PM -0500, John Ferlan wrote:
Rather than having an error path, let's rework the code to allocate
and fill into an @def variable and then steal that into @ret when we
are successful leaving just a cleanup: path.
Signed-off-by: John Ferlan
Reviewed-by: Erik
On Fri, Feb 08, 2019 at 01:36:59PM -0500, John Ferlan wrote:
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/storage/storage_backend_gluster.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
--
On Fri, Feb 08, 2019 at 01:36:58PM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/conf/storage_conf.c| 4 ++--
src/conf/storage_conf.h
On Mon, Feb 11, 2019 at 06:10:38AM -0500, Laine Stump wrote:
> On Mon, Feb 11, 2019, 5:47 AM Daniel P. Berrangé
> wrote:
>
> > On Thu, Feb 07, 2019 at 10:08:28PM -0500, Laine Stump wrote:
> > > RHEL8 has dropped support for qcow1 format images, so skip the tests
> > > related to creating/cloning
On Mon, Feb 11, 2019 at 06:07:40AM -0500, Laine Stump wrote:
> On Mon, Feb 11, 2019, 5:50 AM Daniel P. Berrangé
> wrote:
>
> > On Sat, Feb 09, 2019 at 02:03:05PM -0500, Laine Stump wrote:
> > > Since this test (050-apply-verify-host.t), we can't use a regexp in
> > > the string to be compared.
On Mon, Feb 11, 2019, 5:47 AM Daniel P. Berrangé
wrote:
> On Thu, Feb 07, 2019 at 10:08:28PM -0500, Laine Stump wrote:
> > RHEL8 has dropped support for qcow1 format images, so skip the tests
> > related to creating/cloning qcow1 images (based on the output of
> > qemu-img -help).
> >
> >
On Mon, Feb 11, 2019, 5:50 AM Daniel P. Berrangé
wrote:
> On Sat, Feb 09, 2019 at 02:03:05PM -0500, Laine Stump wrote:
> > Since this test (050-apply-verify-host.t), we can't use a regexp in
> > the string to be compared. The fix method that leads to the least
> > changes is to use sed to remove
On Sat, Feb 09, 2019 at 02:03:05PM -0500, Laine Stump wrote:
> Since this test (050-apply-verify-host.t), we can't use a regexp in
> the string to be compared. The fix method that leads to the least
> changes is to use sed to remove potential leading 0's.
>
> Signed-off-by: Laine Stump
> ---
>
On Thu, Feb 07, 2019 at 10:08:31PM -0500, Laine Stump wrote:
> The ebtables command in RHEL8 prints 00 in a MAC address as "00",
> unlike e.g. Fedora 29, which prints it as "0". Allow for both.
>
> Signed-off-by: Laine Stump
> ---
> scripts/nwfilter/100-ping-still-working.t | 4 ++--
>
On Thu, Feb 07, 2019 at 10:08:30PM -0500, Laine Stump wrote:
> brctl has been deprecated for a long time, and distros are starting to
> remove it. "ip link blah type bridge" should be used instead.
>
> Signed-off-by: Laine Stump
> ---
> scripts/networks/340-guest-network-bridge.t | 4 ++--
> 1
On Thu, Feb 07, 2019 at 10:08:29PM -0500, Laine Stump wrote:
> Due to copy/paste, the tests for several other formats were described
> as "qcow". Also, a couple of messages didn't give the image format.
>
> Signed-off-by: Laine Stump
> ---
> scripts/storage/100-create-vol-dir.t | 16
On Thu, Feb 07, 2019 at 10:08:28PM -0500, Laine Stump wrote:
> RHEL8 has dropped support for qcow1 format images, so skip the tests
> related to creating/cloning qcow1 images (based on the output of
> qemu-img -help).
>
> Signed-off-by: Laine Stump
> ---
> scripts/storage/100-create-vol-dir.t |
On Fri, Feb 08, 2019 at 01:37:06PM -0500, John Ferlan wrote:
> Let's make use of the auto __cleanup capabilities. This also allows
> for the cleanup of some goto paths.
>
> Signed-off-by: John Ferlan
> ---
> @@ -459,15 +454,15 @@ virStorageBackendLogicalFindPoolSourcesFunc(char
> **const
1 - 100 of 108 matches
Mail list logo
