Commit d2a929d4 (0.9.4) defined virDomainSaveImageGetXMLDesc()'s use
of @flags as a subset of virDomainXMLFlags, documenting that 2 of the
3 flags defined at the time would never be valid. Later, commit
28f8dfdc (1.0.0) introduced a new flag, VIR_DOMAIN_XML_MIGRATABLE, but
did not adjust the save
Many drivers had a comment that they did not validate the incoming
'flags' to virDomainGetXMLDesc() because they were relying on
virDomainDefFormat() to do it instead. This used to be the case,
but regressed in commit 0ecd6851 (1.2.12), when all of the drivers
were changed to pass 'flags' through
Commit f609cb85 (0.9.5) introduced virDomainSnapshotGetXMLDesc()'s use
of @flags as a subset of virDomainXMLFlags, documenting that 2 of the
3 flags defined at the time would never be valid. Later, commit
28f8dfdc (1.0.0) introduced a new flag, VIR_DOMAIN_XML_MIGRATABLE, but
did not adjust the
Since v1: add two new patches (1, 2), improve commit message wording
of patch 4/5 [Dan].
Eric Blake (5):
domain: Fix unknown flags diagnosis in virDomainGetXMLDesc
qemu: Use correct domain xml flag
domain: Document VIR_DOMAIN_XML_MIGRATABLE
domain: Define explicit flags for saved image
Commit 28f8dfdc (1.0.0) added a flag to virDomainGetXMLDesc, but
failed to document its effects.
Signed-off-by: Eric Blake
---
src/libvirt-domain.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 54ca18f249..6158382d07
Although VIR_DOMAIN_DEF_FORMAT_INACTIVE and VIR_DOMAIN_XML_INACTIVE
happen to have the same value (1<<1), they come from different enums;
and it is nicer to reason about a 'flags' variable if all uses of
that variable are compared against the same enum type. Messed up in
commit 06f75ff2 (3.8.0).
On Thu, Feb 14, 2019 at 02:46:22PM -0500, Laine Stump wrote:
> The libvirt zonefile for firewalld (added in commit 3b71f2e4) does the
> following:
>
> 1) lists specific services it wants to allow, then
>
> 2) uses a lower priority rule to block all other services to
>the host, and then
The libvirt zonefile for firewalld (added in commit 3b71f2e4) does the
following:
1) lists specific services it wants to allow, then
2) uses a lower priority rule to block all other services to
the host, and then finally,
3) relies on the zone's default "accept" policy to, accept all
On Thu, 14 Feb 2019 at 10:58, Laurent Vivier wrote:
>
> The following changes since commit 0b5e750bea635b167eb03d86c3d9a09bbd43bc06:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request'
> into staging (2019-02-12 10:53:37 +)
>
> are available in the Git repository
The corresponding libvirt-jenkins-ci commit is bb67e0969566.
Signed-off-by: Andrea Bolognani
---
Pushed under the Dockerfiles refresh rule.
buildenv-centos-7.Dockerfile | 1 +
buildenv-debian-8.Dockerfile | 1 +
buildenv-debian-9.Dockerfile | 1 +
On Thu, Feb 14, 2019 at 04:30:16PM +0100, Michal Privoznik wrote:
> On some very basic installations (e.g. some container images) the
> modprobe binary might be missing. If that is the case, don't fail
> virkmodtest.
>
> Signed-off-by: Michal Privoznik
> ---
> tests/virkmodtest.c | 7 ++-
>
On Thu, Feb 14, 2019 at 02:45:46PM +0100, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> guests/vars/projects/libvirt.yml | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-
On Thu, Feb 14, 2019 at 02:45:45PM +0100, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> guests/vars/mappings.yml | 4
> 1 file changed, 4 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-
On Wed, 2019-02-13 at 18:52 +, Daniel P. Berrangé wrote:
> On Thu, Feb 07, 2019 at 04:21:34PM +0100, Andrea Bolognani wrote:
> > On Tue, 2019-02-05 at 17:53 +, Daniel P. Berrangé wrote:
> > [...]
> > > With the Debian 9 distro, this supports arm64, armel, armhf, mips,
> > > mipsel,
On 2/14/19 7:48 AM, Ján Tomko wrote:
> The root snapshot does not have a parent.
> Use NULLSTR_EMPTY to pass an empty string instead of putting
> too few columns in the table.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1662849
>
> Signed-off-by: Ján Tomko
> ---
> tools/virsh-snapshot.c |
On some very basic installations (e.g. some container images) the
modprobe binary might be missing. If that is the case, don't fail
virkmodtest.
Signed-off-by: Michal Privoznik
---
tests/virkmodtest.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/virkmodtest.c
On 2/14/19 4:01 AM, Marc Hartmayer wrote:
> Even if an error is reported by `udev_enumerate_scan_devices`,
> e.g. because a driver of a device has an bug, we can still enumerate
> all other devices. Additionally the documentation of
> udev_enumerate_scan_devices says that on success an integer
The root snapshot does not have a parent.
Use NULLSTR_EMPTY to pass an empty string instead of putting
too few columns in the table.
https://bugzilla.redhat.com/show_bug.cgi?id=1662849
Signed-off-by: Ján Tomko
---
tools/virsh-snapshot.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Signed-off-by: Andrea Bolognani
---
guests/vars/mappings.yml | 4
1 file changed, 4 insertions(+)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index f31b460..8ff2f34 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@ -513,6 +513,10 @@ mappings:
Signed-off-by: Andrea Bolognani
---
guests/vars/projects/libvirt.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvirt.yml
index b19d91f..f813f21 100644
--- a/guests/vars/projects/libvirt.yml
+++ b/guests/vars/projects/libvirt.yml
Turns out some Docker base images (eg. ubuntu:18.04) don't include
it, so we have to drag it in manually. It's a crazy world we live
in these days :)
Andrea Bolognani (2):
guests: Add mapping for modprobe
guests: Install modprobe for libvirt
guests/vars/mappings.yml | 4
On 2/14/19 8:31 AM, Michal Privoznik wrote:
> My change in 112f3a8d0f32 was too drastic. The @charAlias
> variable is initialized only if @monitor == true. However, it is
> used even outside of that condition, at which point it's just
> uninitialized pointer.
>
> Reported-by: John Ferlan
>
My change in 112f3a8d0f32 was too drastic. The @charAlias
variable is initialized only if @monitor == true. However, it is
used even outside of that condition, at which point it's just
uninitialized pointer.
Reported-by: John Ferlan
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_hotplug.c |
This patch adds functionality to allow libvirt to configure the 'dot1q-tunnel'
modes(802.1ad double-tagged) on openvswitch networks.
For example:
Signed-off-by: ZhiPeng Lu
---
v1->v2:
1. Fix "make
On Thu, 2019-02-14 at 12:33 +0100, Ján Tomko wrote:
> Given that your only compelling argument is "it's extra work" I went
> ahead and done the work:
> https://www.redhat.com/archives/libvir-list/2019-February/msg00860.html
I won't NACK that series, even though I disagree with the approach
taken.
On 2/14/19 4:56 AM, Michal Privoznik wrote:
> *** BLURB HERE ***
>
> Michal Prívozník (2):
> qemu_hotplug: Don't build device string in qemuDomainDetachChrDevice
> qemu_hotplug: Assume chardev alias always exists in
> qemuDomainDetachChrDevice
>
> src/qemu/qemu_hotplug.c | 12
On Wed, Feb 13, 2019 at 05:18:55PM +0100, Andrea Bolognani wrote:
On Wed, 2019-02-13 at 13:29 +0100, Ján Tomko wrote:
On Wed, Feb 13, 2019 at 10:59:28AM +0100, Andrea Bolognani wrote:
> On Wed, 2019-02-13 at 10:03 +0100, Ján Tomko wrote:
> > Also, the device will be given an iobase by QEMU, we
From: Nikolay Shirokovskiy
Format the device on QEMU command line.
Signed-off-by: Nikolay Shirokovskiy
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 2 +-
.../isa-serial-debugcon.x86_64-latest.args| 30 +++
tests/qemuxml2argvtest.c
v2: https://www.redhat.com/archives/libvir-list/2019-February/msg00293.html
v3:
* dropped the pointless isa-prefix
* use DO_TEST_CAPS_LATEST
* trimmed the XML
* compiles with gcc
* only make irq optional
* autofill iobase
Ján Tomko (3):
qemu: introduce qemuDomainChrSerialTargetModel
Allow adding serial device models that deviate from the perceived
semantics of our model attributes blindly copying the
hypervisor-specific device name strings.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff
Some devices (e.g. debugcon) only use the iobase.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index c28ced6919..17237e4fc6 100644
--- a/src/qemu/qemu_command.c
If no address was provided, use QEMU's default of 0xE9 and reflect it
in the domain XML.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_domain.c | 9 +
.../isa-serial-debugcon.x86_64-latest.args | 2 +-
From: Nikolay Shirokovskiy
This interface can be used for example by firmware to print
debug messages. Here is domain xml example:
Add checks to make sure this new serial type won't be reported
as back-compat console.
Signed-off-by: Nikolay Shirokovskiy
A build task will validate that the dockerfile generator is
able to create output, and a syntax-check task will run flake8
Signed-off-by: Daniel P. Berrangé
---
guests/playbooks/build/jobs/defaults.yml | 2 ++
.../build/projects/libvirt-jenkins-ci.yml | 15 +++
This sets things up so that we do testing of the libvirt-jenkins-ci
via flake8, and also validate the docker file builder works.
Daniel P. Berrangé (5):
make: add a rule for running a 'syntax-check' with flake8
lcitool: use subparsers for commands
lcitool: allow restricting host list to
Signed-off-by: Daniel P. Berrangé
---
Makefile | 4
1 file changed, 4 insertions(+)
create mode 100644 Makefile
diff --git a/Makefile b/Makefile
new file mode 100644
index 000..1ba6b21
--- /dev/null
+++ b/Makefile
@@ -0,0 +1,4 @@
+
+
+syntax-check:
+ flake8 guests/lcitool
--
Currently only a single global parser is used for all commands. This
means that every command accepts every argument which is undesirable as
users don't know what to pass. It also prevents the parser from
generating useful help information.
Python's argparse module supports multi-command binaries
Add a '-d' arg to the 'hosts' command to restrict the output to
only include hosts on which dockerfiles can be built
Signed-off-by: Daniel P. Berrangé
---
guests/lcitool | 10 ++
1 file changed, 10 insertions(+)
diff --git a/guests/lcitool b/guests/lcitool
index 35a6b68..374ba50 100755
This is useful for local testing of docker changes, and can also be
called to rebuild the content needed for the libvirt-dockerfiles
repository.
Signed-off-by: Daniel P. Berrangé
---
Makefile | 19 +++
1 file changed, 19 insertions(+)
diff --git a/Makefile b/Makefile
index
The corresponding libvirt-jenkins-ci commit is eb8dbc6ffdd1.
Signed-off-by: Andrea Bolognani
---
Pushed under the Dockerfiles refresh rule.
buildenv-centos-7.Dockerfile | 137 ++--
buildenv-debian-8.Dockerfile | 151 +++---
On Tue, Feb 12, 2019 at 9:07 AM Christophe Fergeau
wrote:
> It's not used outside of the libvirt-glib-event.c file, so there is no
> good reason for not having it static. As it was not listed in
> libvirt-glib.sym, this will make no changes to the publicly exported
> symbols (ie this is not an
On Tue, Feb 12, 2019 at 9:07 AM Christophe Fergeau
wrote:
> If xmlNodeDump() fails, we would be leaking the xmlBuffer we created.
> This commit ensures we don't return early before this buffer is freed.
>
> Signed-off-by: Christophe Fergeau
>
Reviewed-by: Fabiano Fidêncio
--
libvir-list
On Tue, Feb 12, 2019 at 9:08 AM Christophe Fergeau
wrote:
> We need to free the string returned by gvir_config_object_to_xml() after
> using it.
>
> Signed-off-by: Christophe Fergeau
>
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
On Thu, 2019-02-14 at 09:59 +, Daniel P. Berrangé wrote:
> On Thu, Feb 14, 2019 at 10:46:21AM +0100, Andrea Bolognani wrote:
> > flake8 complains about this line being too long, so please rewrite
> > it as
>
> What args (if any) are you giving to flake8 when you test this
No arguments, just
On Wed, 2019-02-13 at 19:03 +, Daniel P. Berrangé wrote:
[...]
> elif package_format == "rpm":
> if os_name == "Fedora" and os_version == "Rawhide":
> sys.stdout.write(textwrap.dedent("""
> RUN yum update -y --nogpgcheck
On Thu, Feb 14, 2019 at 10:46:21AM +0100, Andrea Bolognani wrote:
> On Wed, 2019-02-13 at 19:03 +, Daniel P. Berrangé wrote:
> [...]
> > @@ -177,8 +177,8 @@ class Inventory:
> > parser = configparser.SafeConfigParser()
> > parser.read(ansible_cfg_path)
> >
The @tmpChr is looked up in domain definition based on user
provided chardev XML. Therefore, the alias must have been
allocated already when domain was started up.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_hotplug.c | 5 -
1 file changed, 5 deletions(-)
diff --git
*** BLURB HERE ***
Michal Prívozník (2):
qemu_hotplug: Don't build device string in qemuDomainDetachChrDevice
qemu_hotplug: Assume chardev alias always exists in
qemuDomainDetachChrDevice
src/qemu/qemu_hotplug.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
--
This is basically an old artefact from 24b0821926e when the idea
was:
1) Build device string only to see if chardev has any -device
associated with it and thus if device_del is needed
2) Detach chardev using chardev_del
Now, that DEVICE and DEVICE_DELETED capabilities are assumed for
every
On Wed, 2019-02-13 at 19:03 +, Daniel P. Berrangé wrote:
[...]
> +pkgname = temp[item]
> +if pkgname is None:
> +continue
> +if pkgname not in pkgs:
> +pkgs.append(pkgname)
I think this would look slightly better as
if
On Wed, 2019-02-13 at 19:03 +, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> guests/lcitool | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
On Wed, 2019-02-13 at 19:03 +, Daniel P. Berrangé wrote:
[...]
> @@ -177,8 +177,8 @@ class Inventory:
> parser = configparser.SafeConfigParser()
> parser.read(ansible_cfg_path)
> inventory_path = parser.get("defaults", "inventory")
> -except
It hasn't been needed since dbe55924f90d, and flake8 rightfully
complains about that.
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 1 -
1 file changed, 1 deletion(-)
diff --git a/guests/lcitool b/guests/lcitool
index 759eff6..e8263da 100755
--- a/guests/lcitool
+++ b/guests/lcitool
@@
On Wed, Feb 13, 2019 at 05:22:50PM -0600, Eric Blake wrote:
> Commit d2a929d4 (0.9.4) defined virDomainSaveImageGetXMLDesc()'s use
> of @flags as a subset of virDomainXMLFlags, documenting that 2 of the
> 3 flags defined at the time would never be valid. Later, commit
> 28f8dfdc (1.0.0)
On Wed, 2019-02-13 at 19:02 +, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> guests/vars/mappings.yml | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
Even if an error is reported by `udev_enumerate_scan_devices`,
e.g. because a driver of a device has an bug, we can still enumerate
all other devices. Additionally the documentation of
udev_enumerate_scan_devices says that on success an integer >= 0 is
returned (see man
On Wed, Feb 13, 2019 at 03:56 PM +0100, John Ferlan wrote:
> On 2/13/19 7:38 AM, Marc Hartmayer wrote:
>> Even if an error is reported by `udev_enumerate_scan_devices`,
>> e.g. because a driver of a device has an bug, we can still enumerate
>> all other devices. Additionally the documentation of
57 matches
Mail list logo
