Re: [libvirt] [PATCH v4 1/2] qemu_domain: NVLink2 bridge detection function for PPC64

On Tue, 2 Apr 2019 10:34:27 +0200 Erik Skultety wrote: > On Tue, Mar 12, 2019 at 06:55:49PM -0300, Daniel Henrique Barboza wrote: > > The NVLink2 support in QEMU implements the detection of NVLink2 > > capable devices by verifying the attributes of the VFIO mem region > > QEMU allocates for the

Re: [libvirt] [PATCH for 5.2.0] docs: Add virt-lightning app

On 4/3/19 5:03 PM, Ján Tomko wrote: > On Wed, Apr 03, 2019 at 02:10:19PM -0400, Cole Robinson wrote: >> On 4/1/19 8:19 AM, Michal Privoznik wrote: >>> There was this introduction made on the users list: >>> >>> https://www.redhat.com/archives/libvirt-users/2019-March/msg00046.html >>> >>> Add the

[libvirt] [PATCH 3/3] docs: Remove search.php and all references

libvirt.org/search.php drops into some kind of screen which I guess is supposed to show a search bar with options, but presently for me renders as nothing but the following text: Search the documentation on Libvirt.org The search service indexes the libvirt APIs and documentation as well as the

[libvirt] [PATCH 1/3] docs: Use google sitesearch for website search

The website search is perpetually broken, has had XSS issues in the past, and I suspect when it's working it's not as fast or capable as a simple google site:libvirt.org search Replace the implementation with one that sends the user to google.com with 'site:libvirt.org' appended to the search

[libvirt] [PATCH 0/3] Remove website search, just use google

Andrea's ChangeLog patches reminder me that I attempted something similarish once, and also tried to drop our custom website search: http://www.redhat.com/archives/libvir-list/2016-May/msg01616.html danpb recommended I just make our search bar use google instead but I never made the attempt. 3

[libvirt] [PATCH 2/3] docs: Remove index.py

This was used for generating the website search, which now just calls out to google. Remove it Signed-off-by: Cole Robinson --- docs/index.py | 1266 - 1 file changed, 1266 deletions(-) delete mode 100755 docs/index.py diff --git a/docs/index.py

[libvirt] [PATCH 2/6] build-aux: header-ifdef: Handle #pragma once

If we see if, skip all remaining header guard checks Signed-off-by: Cole Robinson --- build-aux/header-ifdef.pl | 5 + 1 file changed, 5 insertions(+) diff --git a/build-aux/header-ifdef.pl b/build-aux/header-ifdef.pl index 297696eb70..401f25fb81 100644 --- a/build-aux/header-ifdef.pl +++

[libvirt] [PATCH 5/6] node_device_hal.h: Use #pragma once

Signed-off-by: Cole Robinson --- src/node_device/node_device_hal.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/node_device/node_device_hal.h b/src/node_device/node_device_hal.h index ffcf0c84e6..5e9c25ae34 100644 --- a/src/node_device/node_device_hal.h +++

[libvirt] [PATCH 3/6] node_device_driver.h: Use #pragma once

Signed-off-by: Cole Robinson --- src/node_device/node_device_driver.h | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/src/node_device/node_device_driver.h b/src/node_device/node_device_driver.h index 5876671c03..eae5e2cb17 100644 ---

[libvirt] [PATCH 4/6] node_device_udev.h: Use #pragma once

Signed-off-by: Cole Robinson --- src/node_device/node_device_udev.h | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/node_device/node_device_udev.h b/src/node_device/node_device_udev.h index 8c1d8fec1d..996677dfe0 100644 ---

[libvirt] [PATCH 6/6] vircgrouppriv.h: Use #pragma once

Signed-off-by: Cole Robinson --- src/util/vircgrouppriv.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/util/vircgrouppriv.h b/src/util/vircgrouppriv.h index a6fb3bb9f8..9110c77297 100644 --- a/src/util/vircgrouppriv.h +++ b/src/util/vircgrouppriv.h @@ -23,11

[libvirt] [PATCH 0/6] Some '#pragma once' conversions

danpb added a BiteSizedTask for '#pragma once' conversions https://wiki.libvirt.org/page/BiteSizedTasks#Switch_headers_to_use_.23pragma_once We don't currently have any usage in the code. Turns out we need some syntax check tweaks to make things happy. This series fixes those, and adds a few

[libvirt] [PATCH 1/6] build-aux: header-ifdef: Fix typos

Signed-off-by: Cole Robinson --- build-aux/header-ifdef.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/build-aux/header-ifdef.pl b/build-aux/header-ifdef.pl index ccabf14055..297696eb70 100644 --- a/build-aux/header-ifdef.pl +++ b/build-aux/header-ifdef.pl @@ -106,7

Re: [libvirt] [PATCH 3/3] vmware: Use VMX_CONFIG_FORMAT_ARGV for vmware naive argv

*native in the subject On 3/28/19 1:57 AM, Han Han wrote: > Signed-off-by: Han Han > --- > src/vmware/vmware_conf.c | 2 +- > src/vmware/vmware_driver.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c > index

Re: [libvirt] [PATCH v2 0/3] qemu: don't duplicate suspended events and state changes

On 3/27/19 7:53 AM, Nikolay Shirokovskiy wrote: > ping > > On 13.02.2019 19:55, John Ferlan wrote: >> >> >> On 2/8/19 2:52 AM, Nikolay Shirokovskiy wrote: >>> Patches 1 and 2 are already Reviewed-by: John. Patch 3 needs Peter comments. >>> >> >> Right - feel free to add my : >> >> Reviewed-by:

Re: [libvirt] [PATCH for 5.2.0] docs: Add virt-lightning app

On Wed, Apr 03, 2019 at 02:10:19PM -0400, Cole Robinson wrote: On 4/1/19 8:19 AM, Michal Privoznik wrote: There was this introduction made on the users list: https://www.redhat.com/archives/libvirt-users/2019-March/msg00046.html Add the application onto the list of apps known to use libvirt.

Re: [libvirt] [PATCH v3 5/5] tools: console: pass stream/fd errors to user

On 3/18/19 5:08 AM, Nikolay Shirokovskiy wrote: > If the console was disconnected due to a connection problem or a problem on > the > server side it is convinient to provide the cause to the user. If the error > come from the API then the error is saved in a virsh global variable. However, >

Re: [libvirt] [PATCH v3 4/5] tools: console: check if console was shutdown in callbacks

On 3/18/19 5:08 AM, Nikolay Shirokovskiy wrote: > On error in main thread virConsoleShutdown is called which > deletes fd watches/stream callback and yet callbacks can > be called after. Thus we can incorrectly allocate > terminalToStream.data memory and get memory leak for example. > Let's check

Re: [libvirt] [PATCH v3 3/5] tools: console: add missing locks in callbacks

On 3/18/19 5:08 AM, Nikolay Shirokovskiy wrote: > Stream/fd callbacks accessing console object are called from the > event loop thread and the console object is also accessed from > the main thread so we are better add locking to handlers. > > Signed-off-by: Nikolay Shirokovskiy > --- >

Re: [libvirt] [PATCH v3 2/5] tools: console: cleanup console on errors in main thread

On 3/18/19 5:08 AM, Nikolay Shirokovskiy wrote: > We only check now for virObjectWait failures in virshRunConsole but > we'd better check and for other failures too. And we need to shutdown > console on error in the main thread. > > Signed-off-by: Nikolay Shirokovskiy > --- >

Re: [libvirt] [PATCH v3 1/5] tools: console: make console virLockableObject

On 3/18/19 5:08 AM, Nikolay Shirokovskiy wrote: > We need to turn console into virObject object because stream/fd callbacks > can be called from the event loop thread after freeing console > in main thread. It is convinient to turn into virLockableObject as > we have mutex in console object. > >

Re: [libvirt] [PATCH 3/3] virNWFilterBindingObjListAddLocked: Produce better error message than 'Duplicate key'

On 3/19/19 9:49 AM, Michal Privoznik wrote: > If there are two concurrent threads, one of which is removing an > nwfilter from the list and the other is trying to add it back they > may serialize in the following order: > > 1) obj->removing is set and @obj is unlocked. > 2) The tread that's

Re: [libvirt] [PATCH 2/3] virDomainObjListAddLocked: Produce better error message than 'Duplicate key'

On 3/19/19 9:49 AM, Michal Privoznik wrote: > If there are two concurrent threads, one of which is removing a > domain from the list and the other is trying to add it back they > may serialize in the following order: > > 1) vm->removing is set and @vm is unlocked. > 2) The tread that's trying to

[libvirt] [PATCH] virErrorPreserveLast conversions

From: Humaid Converted few instances of virSaveLastError() to virErrorPreserveLast() as per the newer internal APIs for saving and restoring error reports. Signed-off-by: Syed Humaid --- src/libvirt-domain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [libvirt] [PATCH 0/4] qemu: Use PCI by default on RISC-V

On 3/29/19 6:19 AM, Andrea Bolognani wrote: > Now that the patches necessary to enable pcie-root-port usage on > RISC-V have been merged into QEMU, we can go ahead and start using > PCI by default on such guests when appropriate. > > The full series, with patch 3/4 in its unabridged form, can be

Re: [libvirt] [PATCH for 5.2.0] docs: Add virt-lightning app

On 4/1/19 8:19 AM, Michal Privoznik wrote: > There was this introduction made on the users list: > > https://www.redhat.com/archives/libvirt-users/2019-March/msg00046.html > > Add the application onto the list of apps known to use libvirt. > > Signed-off-by: Michal Privoznik > --- >

Re: [libvirt] [PATCH] virsh.pod: Improve native configuration format doc

On 3/28/19 12:06 AM, Han Han wrote: > Add native guest format of BSD hypervisor and VMware/ESX. Quote native > guest format of domxml-from-native for domxml-to-native. > > Signed-off-by: Han Han > --- > tools/virsh.pod | 14 +- > 1 file changed, 5 insertions(+), 9 deletions(-) > >

Re: [libvirt] vcpupin reports bogus vcpu affinities

On 3/26/19 4:06 PM, Allen, John wrote: > For pinned vcpus, vcpupin will report inaccurate affinity values on machines > with high core counts (256 cores in my case). The problem is produced as > follows: > > $ virsh vcpupin myguest 0 4 > > $ virsh vcpupin myguest 0 > > VCPU CPU Affinity >

Re: [libvirt] [PATCH] qemu_hotplug: Remove virQEMUDriverPtr arguments

On 3/23/19 8:41 PM, Suyang Chen wrote: > Since commit 2e6ecba1bcac, the pointer to the qemu driver is saved in > domain object's private data and hence does not have to be passed as > yet another parameter if domain object is already one of them. > > This just changed qemuDomainChangeDiskLive and

[libvirt] [python PATCH] rpm: use new python macros for build/install rules

The new %py{2,3}_{build,install} macros ensure that the right compiler and linker flags are used when building python modules. Signed-off-by: Daniel P. Berrangé --- libvirt-python.spec.in | 16 1 file changed, 16 insertions(+) diff --git a/libvirt-python.spec.in

[libvirt] CfP VHPC19: HPC Virtualization-Containers: Paper due May 1, 2019 (extended)

CALL FOR PAPERS 14th Workshop on Virtualization in High­-Performance Cloud Computing (VHPC '19) held in conjunction with the International Supercomputing Conference - High Performance, June 16-20, 2019, Frankfurt, Germany.

Re: [libvirt] Release of libvirt-5.2.0

On Wed, Apr 03, 2019 at 04:24:02PM +0100, Daniel P. Berrangé wrote: > On Wed, Apr 03, 2019 at 11:57:42AM +0200, Daniel Veillard wrote: > > It's out, a bit late but the signed tarball and rpms are at the usual > > place > > and it's tagged in git: > > > > ftp://libvirt.org/libvirt/ > > > >

[libvirt] [perl PATCH] rpm: remove BuildRoot setting

This is obsolete and removed from all Fedora RPMs Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 1 - 1 file changed, 1 deletion(-) Pushed as a trivial sync back from Fedora dist-git diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL index b489a41..5623fe5 100644 ---

[libvirt] [PATCH] docs: stop advertizing FTP or HTTP for downloads of libvirt

On the modern internet it is not credible to continue to advertize software downloads over unencrypted connections. Even if users could theoretically use GPG to verify the signatures, not all our downloads and signed and few people know how to correctly verify signatures. Signed-off-by: Daniel P.

[libvirt] [PATCH] docs: update Perl download to point to modern CPAN site

The search.cpan.org site is a transparent redirect to metacpan.org these days, so we should just point directly to the new site. Signed-off-by: Daniel P. Berrangé --- docs/downloads.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/downloads.html.in

Re: [libvirt] Release of libvirt-5.2.0

On Wed, 2019-04-03 at 16:24 +0100, Daniel P. Berrangé wrote: > BTW, it is preferrable to link to https:// URLs for the downloads. > > Personally I'd suggest disabling the FTP service entirely on the machine > as non-encrypted file transfer has no place on the modern internet. The > kernel.org

Re: [libvirt] Release of libvirt-5.2.0

On Wed, Apr 03, 2019 at 11:57:42AM +0200, Daniel Veillard wrote: > It's out, a bit late but the signed tarball and rpms are at the usual place > and it's tagged in git: > > ftp://libvirt.org/libvirt/ > > > I also pushed the python bindings, with only a single patch since 5.1.0 at: > >

Re: [libvirt] [PATCH 5/5] util: Remove virParseNumber

On Wed, Apr 03, 2019 at 02:44:54PM +0200, Peter Krempa wrote: We have more modern replacements. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 - src/util/virutil.c | 31 --- src/util/virutil.h | 1 - 3 files changed, 33 deletions(-)

Re: [libvirt] [PATCH 4/5] rpc: ssh: Use virStrToLong_i instead of virParseNumber

On Wed, Apr 03, 2019 at 02:44:53PM +0200, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/rpc/virnetlibsshsession.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir-list mailing list

Re: [libvirt] [PATCH 3/5] vmx: Refactor number parsing in virVMXParseConfig

On Wed, Apr 03, 2019 at 02:44:52PM +0200, Peter Krempa wrote: Parsing of the cpu affinity list was using virParseNumber. Modernize it to get rid of the virParseNumber call. Signed-off-by: Peter Krempa --- src/vmx/vmx.c | 56 ++- 1 file changed, 20

Re: [libvirt] [PATCH] mingw: Bump minimum supported Fedora version to 28

On Wed, 2019-04-03 at 15:55 +0200, Ján Tomko wrote: > On Wed, Apr 03, 2019 at 03:47:28PM +0200, Andrea Bolognani wrote: > > -%define min_fedora 26 > > +%define min_fedora 28 > > This means you can also get rid of the else clause below: > %if 0%{?fedora} >= 27 > BuildRequires: perl-interpreter >

[libvirt] [PATCH 0/2] Fix permissions checks for virDomainGetTime/Hostname

These two APIs mistakenly allowed access to read-only users. This was was reported publically in a bug tracker, so I'm sending these patches without applying any embargo time. Daniel P. Berrangé (2): api: disallow virDomainGetHostname for read-only connections remote: enforce ACL write

[libvirt] [PATCH 2/2] remote: enforce ACL write permission for getting guest time & hostname

Getting the guest time and hostname both require use of guest agent commands. These must not be allowed for read-only users, so the permissions check must validate "write" permission not "read". Fixes CVE-2019-3886 Signed-off-by: Daniel P. Berrangé --- src/remote/remote_protocol.x | 4 ++-- 1

[libvirt] [PATCH 1/2] api: disallow virDomainGetHostname for read-only connections

The virDomainGetHostname API is fetching guest information and this may involve use of an untrusted guest agent. As such its use must be forbidden on a read-only connection to libvirt. Fixes CVE-2019-3886 Signed-off-by: Daniel P. Berrangé --- src/libvirt-domain.c | 2 ++ 1 file changed, 2

Re: [libvirt] [PATCH] mingw: Bump minimum supported Fedora version to 28

On Wed, Apr 03, 2019 at 03:47:28PM +0200, Andrea Bolognani wrote: Should have been part of 2569ba133822, but clearly wasn't. Self-evidently. Signed-off-by: Andrea Bolognani --- mingw-libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mingw-libvirt.spec.in

Re: [libvirt] deadlock in remoteDispatchDomainUndefine vs daemonStreamHandleAbort

On Tue, Apr 2, 2019 at 3:30 PM Michal Privoznik wrote: > > On 4/2/19 10:45 AM, Christian Ehrhardt wrote: > > On Mon, Apr 1, 2019 at 4:35 PM Michal Privoznik wrote: > >> > >> On 4/1/19 4:25 PM, Christian Ehrhardt wrote: > >>> Hi, > >>> I happened to analyze a bug [1] report I got from a friend

Re: [libvirt] [PATCH v4 1/2] qemu_domain: NVLink2 bridge detection function for PPC64

On 4/3/19 4:05 AM, Erik Skultety wrote: On Tue, Apr 02, 2019 at 05:27:55PM -0300, Daniel Henrique Barboza wrote: On 4/2/19 5:34 AM, Erik Skultety wrote: On Tue, Mar 12, 2019 at 06:55:49PM -0300, Daniel Henrique Barboza wrote: The NVLink2 support in QEMU implements the detection of NVLink2

[libvirt] [PATCH] mingw: Bump minimum supported Fedora version to 28

Should have been part of 2569ba133822, but clearly wasn't. Signed-off-by: Andrea Bolognani --- mingw-libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in index bea822fd73..8756a56a23 100644 --- a/mingw-libvirt.spec.in

Re: [libvirt] [PATCH] mingw: unconditionally enable libssh2 in RPM

On Wed, 2019-04-03 at 11:18 +0100, Daniel P. Berrangé wrote: > The libssh2 support in libvirt is not solely for phyp, it is used by the > remote driver too. > > Signed-off-by: Daniel P. Berrangé > --- > mingw-libvirt.spec.in | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Andrea

Re: [libvirt] [PATCH] mingw: remove obsolete Group tag in RPM spec

On Wed, 2019-04-03 at 11:18 +0100, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > mingw-libvirt.spec.in | 1 - > 1 file changed, 1 deletion(-) According to https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections this change is correct, so

Re: [libvirt] Reproducible VM start bug which affects libvirt 5.1.0 and 5.2.0

On Wed, Apr 03, 2019 at 10:52:57AM +, Frank Schreuder wrote: > Hello, > > I am currently running into a reproducible libvirt bug which affects libvirt > 5.1.0 and 5.2.0. > > There seem to be a racecondition in the nwfilter-define and virsh start > commands. Several times a day I'm not able

Re: [libvirt] [PATCH v3 2/6] tests: add targets for building libvirt inside docker containers

On Wed, 2019-04-03 at 11:44 +0100, Daniel P. Berrangé wrote: > On Mon, Apr 01, 2019 at 01:03:21PM +0200, Andrea Bolognani wrote: > > On Mon, 2019-04-01 at 11:39 +0100, Daniel P. Berrangé wrote: > > > On Fri, Mar 29, 2019 at 05:39:59PM +0100, Andrea Bolognani wrote: > > > > On Wed, 2019-03-27 at

Re: [libvirt] [PATCH 2/5] vmx: Remove unused variable in virVMXParseConfig

On Wed, Apr 03, 2019 at 02:44:51PM +0200, Peter Krempa wrote: cpumasklen is only ever written to. Remove it. Unused since ee7d23ba4b4d487f8ac078c66b743d93a24141c0 Signed-off-by: Peter Krempa --- src/vmx/vmx.c | 6 -- 1 file changed, 6 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [libvirt] [PATCH 1/5] util: Remove virPipeReadUntilEOF

On Wed, Apr 03, 2019 at 02:44:50PM +0200, Peter Krempa wrote: Unused since 3c269b51a6f03a1a678e8d Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 - src/util/virutil.c | 82 src/util/virutil.h | 3 -- 3 files changed, 86

Re: [libvirt] [PATCH v4 0/7] Facilitate running libvirt builds via docker containers

On Wed, 2019-04-03 at 14:43 +0200, Martin Kletzander wrote: > On Wed, Apr 03, 2019 at 01:34:04PM +0100, Daniel P. Berrangé wrote: > > On Wed, Apr 03, 2019 at 02:29:55PM +0200, Martin Kletzander wrote: > > > On Wed, Apr 03, 2019 at 11:41:41AM +0100, Daniel P. Berrangé wrote: > > > > For a while

[libvirt] [PATCH 3/5] util: Don't include 'viralloc.h' into other header files

'viralloc.h' does not provide any type or macro which would be necessary in headers. Prevent leakage of the inclusion. Signed-off-by: Peter Krempa --- src/conf/domain_capabilities.h | 1 - src/conf/node_device_util.c | 1 + src/conf/virdomainmomentobjlist.c | 1 +

[libvirt] [PATCH 5/5] Include unistd.h directly by files using it

util/virutil.h bogously included unistd.h. Drop it and replace it by including it directly where needed. Signed-off-by: Peter Krempa --- src/conf/virnwfilterbindingobj.c | 2 ++ src/libxl/libxl_domain.c | 1 + src/locking/lock_daemon_config.c | 2 ++

[libvirt] [PATCH 2/5] util: Move the VIR_AUTO(CLEAN|PTR) helper macros into a separate header

Keeping them with viralloc.h forcibly pulls in the other stuff from viralloc.h into other header files. This in turn creates a mess as more and more headers pull in the 'viral' header file. If we want to make 'viralloc.h' omnipresent we should pick a different approach. Signed-off-by: Peter

[libvirt] [PATCH 1/5] util: Move VIR_AUTOUNREF definition to virobject.h

This helper has solely to do with virObjects. Move it together with other virObject stuff. This also avoids the potential problem where VIR_AUTOUNREF uses virObjectAutoUnref which is defined in virobject.h. Signed-off-by: Peter Krempa --- src/util/viralloc.h | 11 ---

[libvirt] [PATCH 4/5] util: Move enum convertors into virenum.(c|h)

virutil.(c|h) is a very gross collection of random code. Remove the enum handlers from there so we can limit the scope where virtutil.h is used. Signed-off-by: Peter Krempa --- src/Makefile.am | 3 ++ src/access/viraccessperm.h| 1 + src/conf/capabilities.c

[libvirt] [PATCH 0/5] util: Clean up header inclusion

Peter Krempa (5): util: Move VIR_AUTOUNREF definition to virobject.h util: Move the VIR_AUTO(CLEAN|PTR) helper macros into a separate header util: Don't include 'viralloc.h' into other header files util: Move enum convertors into virenum.(c|h) Include unistd.h directly by files using

Re: [libvirt] [PATCH] virjson: drop compatibility macros

On Wed, Apr 03, 2019 at 14:34:56 +0200, Ján Tomko wrote: > Since commit 66460e3 dropped support for YAJL 1, we no longer need > these. > > Signed-off-by: Ján Tomko > --- > src/util/virjson.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) ACK signature.asc Description:

[libvirt] [PATCH 3/5] vmx: Refactor number parsing in virVMXParseConfig

Parsing of the cpu affinity list was using virParseNumber. Modernize it to get rid of the virParseNumber call. Signed-off-by: Peter Krempa --- src/vmx/vmx.c | 56 ++- 1 file changed, 20 insertions(+), 36 deletions(-) diff --git a/src/vmx/vmx.c

[libvirt] [PATCH 2/5] vmx: Remove unused variable in virVMXParseConfig

cpumasklen is only ever written to. Remove it. Signed-off-by: Peter Krempa --- src/vmx/vmx.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 8ffd5ff088..429630faaf 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -1301,7 +1301,6 @@

[libvirt] [PATCH 0/5] util: Remove some obsolete and dead code

Peter Krempa (5): util: Remove virPipeReadUntilEOF vmx: Remove unused variable in virVMXParseConfig vmx: Refactor number parsing in virVMXParseConfig rpc: ssh: Use virStrToLong_i instead of virParseNumber util: Remove virParseNumber src/libvirt_private.syms | 2 -

[libvirt] [PATCH 4/5] rpc: ssh: Use virStrToLong_i instead of virParseNumber

Signed-off-by: Peter Krempa --- src/rpc/virnetlibsshsession.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/rpc/virnetlibsshsession.c b/src/rpc/virnetlibsshsession.c index b9143239b9..039d8a278c 100644 --- a/src/rpc/virnetlibsshsession.c +++

[libvirt] [PATCH 1/5] util: Remove virPipeReadUntilEOF

Unused since 3c269b51a6f03a1a678e8d Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 - src/util/virutil.c | 82 src/util/virutil.h | 3 -- 3 files changed, 86 deletions(-) diff --git a/src/libvirt_private.syms

[libvirt] [PATCH 5/5] util: Remove virParseNumber

We have more modern replacements. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 - src/util/virutil.c | 31 --- src/util/virutil.h | 1 - 3 files changed, 33 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms

Re: [libvirt] [PATCH v4 0/7] Facilitate running libvirt builds via docker containers

On Wed, Apr 03, 2019 at 01:34:04PM +0100, Daniel P. Berrangé wrote: On Wed, Apr 03, 2019 at 02:29:55PM +0200, Martin Kletzander wrote: On Wed, Apr 03, 2019 at 11:41:41AM +0100, Daniel P. Berrangé wrote: > For a while QEMU has provided simple make rules for building QEMU inside > standard docker

Re: [libvirt] [PATCH] virjson: drop compatibility macros

On Wed, Apr 03, 2019 at 02:34:56PM +0200, Ján Tomko wrote: > Since commit 66460e3 dropped support for YAJL 1, we no longer need > these. > > Signed-off-by: Ján Tomko > --- > src/util/virjson.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) Reviewed-by: Daniel P. Berrangé

[libvirt] [PATCH] virjson: drop compatibility macros

Since commit 66460e3 dropped support for YAJL 1, we no longer need these. Signed-off-by: Ján Tomko --- src/util/virjson.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/util/virjson.c b/src/util/virjson.c index bb4052ba81..1dceb746b9 100644 ---

Re: [libvirt] [PATCH v4 0/7] Facilitate running libvirt builds via docker containers

On Wed, Apr 03, 2019 at 02:29:55PM +0200, Martin Kletzander wrote: > On Wed, Apr 03, 2019 at 11:41:41AM +0100, Daniel P. Berrangé wrote: > > For a while QEMU has provided simple make rules for building QEMU inside > > standard docker container environments. This provides an equivalent > >

Re: [libvirt] [PATCH v4 0/7] Facilitate running libvirt builds via docker containers

On Wed, Apr 03, 2019 at 11:41:41AM +0100, Daniel P. Berrangé wrote: For a while QEMU has provided simple make rules for building QEMU inside standard docker container environments. This provides an equivalent mechanism for libvirt inspired by QEMU's. Can we change this so that we don't

[libvirt] [PATCH] rbd: fix build with LIBRBD_VERSION_CODE <= 265

Add ATTRIBUTE_UNUSED to the volStorageBackendRBDGetFlags stub. Fixes: 21deeaf02fdf216b08210fc899579736973ca81d Signed-off-by: Ján Tomko --- Pushed as a build breaker fix src/storage/storage_backend_rbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH] build-aux: ensure all scripts are included in EXTRA_DIST

Few of the scripts in build-aux are included in EXTRA_DIST. This is not a serious problem since they are primarily tools intended for developers upstream, and downstream builds won't need them. Having them missing, however, complicates downstream patching because it means patches that are

[libvirt] Reproducible VM start bug which affects libvirt 5.1.0 and 5.2.0

Hello, I am currently running into a reproducible libvirt bug which affects libvirt 5.1.0 and 5.2.0. There seem to be a racecondition in the nwfilter-define and virsh start commands. Several times a day I'm not able to start a VM anymore with the following error message: error: Failed to

Re: [libvirt] [PATCH v3 2/6] tests: add targets for building libvirt inside docker containers

On Mon, Apr 01, 2019 at 01:03:21PM +0200, Andrea Bolognani wrote: > On Mon, 2019-04-01 at 11:39 +0100, Daniel P. Berrangé wrote: > > On Fri, Mar 29, 2019 at 05:39:59PM +0100, Andrea Bolognani wrote: > > > On Wed, 2019-03-27 at 17:10 +, Daniel P. Berrangé wrote: > > > > It is neccessary to

[libvirt] [PATCH v4 7/7] tests: perform cross compiler builds on GitLab CI

GitLab CI provides some shared build runners that use Docker containers. This resource can usefully run cross-compiled builds since all other CI build testing is currently x86 only, and Travis CI is already very busy testing native builds. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.yml |

[libvirt] [PATCH v4 5/7] travis: put macOS script inline in the macOS matrix entry

Now that we don't have separate scripts defined for native and mingw builds, there is no point having one for macOS. It can just be inlined at the one place it is needed. Signed-off-by: Daniel P. Berrangé --- .travis.yml | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-)

[libvirt] [PATCH v4 3/7] travis: use declarative syntax for Homebrew packages

Instead of running custom commands use the new declarative syntax for listing extra Homebrew packages. Signed-off-by: Daniel P. Berrangé --- .travis.yml | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 90a52c7f08..47757ccfc9 100644

[libvirt] [PATCH v4 6/7] tests: add cross compiler images to CI test help output

Signed-off-by: Daniel P. Berrangé --- Makefile.ci | 12 1 file changed, 12 insertions(+) diff --git a/Makefile.ci b/Makefile.ci index 984cd3c205..967846a673 100644 --- a/Makefile.ci +++ b/Makefile.ci @@ -203,6 +203,18 @@ ci-help: @echo "fedora-rawhide" @echo "

[libvirt] [PATCH v4 2/7] travis: convert Ubuntu, CentOS & MinGW builds to use new make rules

Change the Travis CI configuration to invoke the new ci-build@$IMAGE target instead of directly running Docker. This guarantees that when a developer runs ci-build@$IMAGE locally, the container build setup is identical to that used in Travis CI, with exception of the host kernel and Docker

[libvirt] [PATCH v4 4/7] travis: remove display of test-suite.log from macOS

We are not running "make check" on macOS, so the commands to cat the test-suite.log are not useful. Reviewed-by: Andrea Bolognani Signed-off-by: Daniel P. Berrangé --- .travis.yml | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.travis.yml b/.travis.yml index

[libvirt] [PATCH v4 0/7] Facilitate running libvirt builds via docker containers

For a while QEMU has provided simple make rules for building QEMU inside standard docker container environments. This provides an equivalent mechanism for libvirt inspired by QEMU's. QEMU actually builds the container images on developer's machines locally. Libvirt already hosts pre-built images

[libvirt] [PATCH v4 1/7] tests: add targets for building libvirt inside Docker containers

The Travis CI system uses Docker containers for its build environment. These are pre-built and hosted under quay.io/libvirt so that developers can use them for reproducing problems locally. Getting the right Docker command syntax to use them, however, is not entirely easy. This patch addresses

[libvirt] [jenkins-ci PATCH] Ensure ca-certificates are installed

On Red Hat variant distros ca-certificates gets pulled in automatically by other packages we require. This doesn't happen on Debian and so any use of https URIs fails. This prevents git from cloning submodules over https. Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 4

[libvirt] [PATCH] mingw: unconditionally enable libssh2 in RPM

The libssh2 support in libvirt is not solely for phyp, it is used by the remote driver too. Signed-off-by: Daniel P. Berrangé --- mingw-libvirt.spec.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in index 9983a5013f..913aaa8751 100644 ---

[libvirt] [PATCH] mingw: remove obsolete Group tag in RPM spec

Signed-off-by: Daniel P. Berrangé --- mingw-libvirt.spec.in | 1 - 1 file changed, 1 deletion(-) diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in index bea822fd73..9983a5013f 100644 --- a/mingw-libvirt.spec.in +++ b/mingw-libvirt.spec.in @@ -39,7 +39,6 @@ Release:1%{?dist}

[libvirt] Release of libvirt-5.2.0

It's out, a bit late but the signed tarball and rpms are at the usual place and it's tagged in git: ftp://libvirt.org/libvirt/ I also pushed the python bindings, with only a single patch since 5.1.0 at: ftp://libvirt.org/libvirt/python/ Note that it's a release with rather large

Re: [libvirt] [python PATCH v7] Add virDomainCheckpoint APIs

On Wed, Mar 27, 2019 at 05:09:27AM -0500, Eric Blake wrote: > Copies heavily from existing virDomainSnapshot handling, regarding > what special cases the generator has to be taught and what overrides > need to be written. > > Signed-off-by: Eric Blake > --- > > Python counterparts to my

Re: [libvirt] [PATCHv2 08/14] virjsontest: switch DO_TEST_PARSE_FILE to use output files

On Tue, Apr 02, 2019 at 17:41:47 +0200, Ján Tomko wrote: > Also switch the expected output of DO_TEST_PARSE_FILE to be > in a file, now that we demonstrated the input files match > the expected string representation. > > Signed-off-by: Ján Tomko > --- > tests/virjsondata/parse-Harder-out.json

Re: [libvirt] [PATCHv2 07/14] virjsontest: introduce DO_TEST_PARSE_FILE

On Tue, Apr 02, 2019 at 17:41:46 +0200, Ján Tomko wrote: > Introduce a new macro DO_TEST_PARSE_FILE which takes the input JSON > from a file instead of a C string. > > This lets us get rid of quote escaping and makes the JSON easier to > edit. > > The output JSON is still taken from a string and

Re: [libvirt] [PATCHv2 12/14] virjsondata: json_reformat input data

On Tue, Apr 02, 2019 at 17:41:51 +0200, Ján Tomko wrote: > Remove trailing slashes and run json_reformat. > > Signed-off-by: Ján Tomko > --- > tests/virjsondata/parse-Harder-in.json | 17 +- > tests/virjsondata/parse-NotSoSimple-in.json | 18 ++- > tests/virjsondata/parse-Simple-in.json

Re: [libvirt] [PATCH 01/10] rbd: depend on diff_iterate2

On Wed, Apr 03, 2019 at 10:00:18 +0100, Daniel Berrange wrote: > On Wed, Apr 03, 2019 at 10:48:25AM +0200, Peter Krempa wrote: > > On Wed, Apr 03, 2019 at 09:40:14 +0100, Daniel Berrange wrote: > > > On Wed, Apr 03, 2019 at 07:40:16AM +0200, Ján Tomko wrote: > > > > This function was added by > >

Re: [libvirt] [PATCH 01/10] rbd: depend on diff_iterate2

On Wed, Apr 03, 2019 at 10:48:25AM +0200, Peter Krempa wrote: > On Wed, Apr 03, 2019 at 09:40:14 +0100, Daniel Berrange wrote: > > On Wed, Apr 03, 2019 at 07:40:16AM +0200, Ján Tomko wrote: > > > This function was added by > > > commit 6d5b969d4206208e91ca807b09aac75f2f428393 > > > librbd: add

Re: [libvirt] [PATCH 03/10] build: drop check for SASL1

On Wed, Apr 03, 2019 at 09:32:10AM +0100, Daniel P. Berrangé wrote: > On Wed, Apr 03, 2019 at 07:40:18AM +0200, Ján Tomko wrote: > > Even Debian 8 which we no longer support has 2.1.26. > > > > https://repology.org/project/cyrus-sasl/versions > > > > Signed-off-by: Ján Tomko > > --- > >

Re: [libvirt] [PATCH 10/10] configure.ac: add foreign to AM_INIT_AUTOMAKE

On Wed, Apr 03, 2019 at 07:40:25AM +0200, Ján Tomko wrote: > We do not care about the portability warnings implied by the implicit > 'gnu' option. Switch to 'foreign' to opt out of checking the files > present in the top directory to let us drop ChangeLog completely. > > Signed-off-by: Ján Tomko

Re: [libvirt] [PATCH 09/10] configure.ac: drop -Wno-obsolete from AM_INIT_AUTOMAKE

On Wed, Apr 03, 2019 at 07:40:24AM +0200, Ján Tomko wrote: > Even Ubuntu 16.04 has automake 1.11. > Now that we no longer cater to automake 1.9, drop the comment > as well as the -Wno-obsolete option, since it does not seem to generate > any warnings anymore. > > Signed-off-by: Ján Tomko > --- >

[libvirt] [PATCH 2/2] fixup: regroup QEMU capabilities

--- src/qemu/qemu_capabilities.c | 246 +-- src/qemu/qemu_capabilities.h | 246 +-- 2 files changed, 246 insertions(+), 246 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index

[libvirt] [PATCH 0/2] drop QEMU_CAPS*KQEMU

Ján Tomko (2): Delete QEMU_CAPS_KQEMU and QEMU_CAPS_ENABLE_KQEMU fixup: regroup QEMU capabilities src/qemu/qemu_capabilities.c | 248 +-- src/qemu/qemu_capabilities.h | 248 +-- 2 files changed, 246 insertions(+), 250

  1   2   >