[libvirt] [jenkins-ci PATCH 1/6] mappings: add libgcrypt native & mingw packages

2019-05-03 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 98c0cc9..7cde719 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -319,6 +319,11 @@

[libvirt] [jenkins-ci PATCH 4/6] projects: make virt-viewer depend on gtk-vnc jobs

2019-05-03 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- guests/playbooks/build/jobs/defaults.yml | 1 + guests/vars/projects/virt-viewer+mingw32.yml | 1 - guests/vars/projects/virt-viewer+mingw64.yml | 1 - guests/vars/projects/virt-viewer.yml | 1 - jenkins/jobs/defaults.yaml | 1 +

[libvirt] [jenkins-ci PATCH 5/6] mappings: remove gtk-vnc2 native and mingw packages

2019-05-03 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 12 1 file changed, 12 deletions(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 6347024..40eeb02 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -228,12 +228,6 @@

[libvirt] [jenkins-ci PATCH 2/6] mappings: add pulseaudio libs for native packages

2019-05-03 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 4 1 file changed, 4 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 7cde719..6347024 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -780,6 +780,10 @@ mappings:

[libvirt] [jenkins-ci PATCH 6/6] jobs: allow test-suite.log to exist anywhere

2019-05-03 Thread Daniel P . Berrangé
Don't assume that all projects have a dedicated tests/ subdirectory for unit tests. Signed-off-by: Daniel P. Berrangé --- guests/playbooks/build/jobs/autotools-check-job.yml | 2 +- jenkins/jobs/autotools.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[libvirt] [jenkins-ci PATCH 3/6] projects: add gtk-vnc project

2019-05-03 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- guests/host_vars/libvirt-centos-7/main.yml| 1 + guests/host_vars/libvirt-debian-9/main.yml| 1 + guests/host_vars/libvirt-debian-sid/main.yml | 1 + guests/host_vars/libvirt-fedora-29/main.yml | 1 +

[libvirt] [jenkins-ci PATCH 0/6] Add support for gtk-vnc builds

2019-05-03 Thread Daniel P . Berrangé
Support gtk-vnc and make virt-viewer depend on it Daniel P. Berrangé (6): mappings: add libgcrypt native & mingw packages mappings: add pulseaudio libs for native packages projects: add gtk-vnc project projects: make virt-viewer depend on gtk-vnc jobs mappings: remove gtk-vnc2 native

Re: [libvirt] [jenkins-ci PATCH v2] lcitool: check for virt-install / ansible-playbook in $PATH

2019-05-03 Thread Andrea Bolognani
On Fri, 2019-05-03 at 16:41 +0100, Daniel P. Berrangé wrote: > On Fri, May 03, 2019 at 05:37:58PM +0200, Andrea Bolognani wrote: > > > @@ -461,8 +462,12 @@ class Application: > > > "git_branch": git_branch, > > > }) > > > > > > +ap_path =

Re: [libvirt] [jenkins-ci PATCH v2] lcitool: check for virt-install / ansible-playbook in $PATH

2019-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2019 at 05:37:58PM +0200, Andrea Bolognani wrote: > On Fri, 2019-05-03 at 11:02 +0100, Daniel P. Berrangé wrote: > > This improves error reporting: > > > > $ ./lcitool install libvirt-fedora-29 > > ./lcitool: Failed to install 'libvirt-fedora-29': [Errno 2] No such file > >

Re: [libvirt] [jenkins-ci PATCH v2] lcitool: check for virt-install / ansible-playbook in $PATH

2019-05-03 Thread Andrea Bolognani
On Fri, 2019-05-03 at 11:02 +0100, Daniel P. Berrangé wrote: > This improves error reporting: > > $ ./lcitool install libvirt-fedora-29 > ./lcitool: Failed to install 'libvirt-fedora-29': [Errno 2] No such file or > directory > > To > > $ ./lcitool install libvirt-fedora-29 >

Re: [libvirt] [jenkins-ci PATCH] lcitool: use yaml.safe_load instead of load

2019-05-03 Thread Andrea Bolognani
On Fri, 2019-05-03 at 11:03 +0100, Daniel P. Berrangé wrote: > The yaml.load() method is historically unsafe as it allowed for > arbitrary code execution: > > ./lcitool:323: YAMLLoadWarning: calling yaml.load() without > Loader=... is deprecated, as the default Loader is unsafe. > Please read

Re: [libvirt] [jenkins-ci PATCH] lcitool: don't use SafeConfigParser under Python3

2019-05-03 Thread Andrea Bolognani
On Fri, 2019-05-03 at 11:02 +0100, Daniel P. Berrangé wrote: > Since Python 3.2 the SafeConfigParser class is renamed to > just ConfigParser. The SafeConfigParser alias is targetted > for deletion. > > ./lcitool:224: DeprecationWarning: The SafeConfigParser class > has been renamed to

Re: [libvirt] [PATCH 0/2] Avoid issues due to qemu dropping osxsave and ospke

2019-05-03 Thread Christian Ehrhardt
On Thu, Apr 25, 2019 at 2:50 PM Christian Ehrhardt wrote: > > Hi, > this series tries to address a drop of commandline options by qemu in regard > to > osxsave [1] and ospke [2]. > This was already discussed in [3] late last year but got forgotten afterwards. > The Ubuntu bug is at [4] and an

Re: [libvirt] [dockerfiles PATCH 2/3] Add Fedora 30

2019-05-03 Thread Andrea Bolognani
On Fri, 2019-05-03 at 15:04 +0200, Pavel Hrdina wrote: > On Fri, May 03, 2019 at 02:49:29PM +0200, Andrea Bolognani wrote: > > +FROM fedora:30 > > + > > +RUN yum update -y && \ > > +yum install -y audit-libs-devel \ > > We should stop using yum in Fedora and switch to dnf, yum is deprecated >

Re: [libvirt] [dockerfiles PATCH 2/3] Add Fedora 30

2019-05-03 Thread Pavel Hrdina
On Fri, May 03, 2019 at 02:49:29PM +0200, Andrea Bolognani wrote: > The corresponding libvirt-jenkins-ci commit is b73a4dc8f6b9. > > Signed-off-by: Andrea Bolognani > --- > buildenv-fedora-30.Dockerfile | 88 +++ > 1 file changed, 88 insertions(+) > create mode

[libvirt] [dockerfiles PATCH 3/3] Drop Fedora 28

2019-05-03 Thread Andrea Bolognani
The corresponding libvirt-jenkins-ci commit is 3c305799f0f6. Signed-off-by: Andrea Bolognani --- buildenv-fedora-28.Dockerfile | 88 --- 1 file changed, 88 deletions(-) delete mode 100644 buildenv-fedora-28.Dockerfile diff --git a/buildenv-fedora-28.Dockerfile

[libvirt] [dockerfiles PATCH] Add git-publish configuration file

2019-05-03 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- .gitpublish | 4 1 file changed, 4 insertions(+) create mode 100644 .gitpublish diff --git a/.gitpublish b/.gitpublish new file mode 100644 index 000..a56a6d0 --- /dev/null +++ b/.gitpublish @@ -0,0 +1,4 @@ +[gitpublishprofile "default"] +base =

[libvirt] [dockerfiles PATCH 2/3] Add Fedora 30

2019-05-03 Thread Andrea Bolognani
The corresponding libvirt-jenkins-ci commit is b73a4dc8f6b9. Signed-off-by: Andrea Bolognani --- buildenv-fedora-30.Dockerfile | 88 +++ 1 file changed, 88 insertions(+) create mode 100644 buildenv-fedora-30.Dockerfile diff --git a/buildenv-fedora-30.Dockerfile

[libvirt] [dockerfiles PATCH 1/3] Refresh after adding ncurses for libvirt

2019-05-03 Thread Andrea Bolognani
The corresponding libvirt-jenkins-ci commit is 3a79fafa0cfc. Signed-off-by: Andrea Bolognani --- buildenv-centos-7.Dockerfile | 1 + buildenv-debian-9-cross-aarch64.Dockerfile| 1 + buildenv-debian-9-cross-armv6l.Dockerfile | 1 +

[libvirt] [dockerfiles PATCH 0/3] Refresh, add Fedora 30, drop Fedora 28

2019-05-03 Thread Andrea Bolognani
Pushed under the Dockerfile refresh rule. Andrea Bolognani (3): Refresh after adding ncurses for libvirt Add Fedora 30 Drop Fedora 28 buildenv-centos-7.Dockerfile | 1 + buildenv-debian-9-cross-aarch64.Dockerfile | 1 +

Re: [libvirt] [PATCH] RFC: use a slirp helper process

2019-05-03 Thread Marc-André Lureau
Hi On Tue, Apr 30, 2019 at 7:31 PM Daniel P. Berrangé wrote: > > At this point, the slirp-helper doesn't handle migration. But is it > > really worth it? From a guest POV, it would look like packet lost or > > disconnection. Adding migration handling is possible, to avoid a > > disconnection

Re: [libvirt] [PATCH 1/4] tests: Add capabilities for QEMU 3.1.0 on s390x

2019-05-03 Thread Andrea Bolognani
On Fri, 2019-05-03 at 10:46 +0200, Boris Fiuczynski wrote: > In addition adjusting *s390x-latest.args files to qemu deprecation changes > made > in commit e8c2c8bd078 (Prefer '-overcommit mem-lock' over -realtime mlock'). > > Signed-off-by: Boris Fiuczynski > --- > .../caps_3.1.0.s390x.replies

Re: [libvirt] [PATCH 1/3] virbuffer: Don't leak memory in virBufferAddBuffer

2019-05-03 Thread Andrea Bolognani
On Fri, 2019-05-03 at 11:57 +0200, Michal Privoznik wrote: > On 5/3/19 11:18 AM, Andrea Bolognani wrote: > > On Thu, 2019-04-18 at 14:11 +0200, Michal Privoznik wrote: > > > +if (virBufferCurrentContent() || > > > +!virBufferCurrentContent()) { > > > +VIR_TEST_DEBUG("Unexpected

[libvirt] [jenkins-ci PATCH] lcitool: don't use SafeConfigParser under Python3

2019-05-03 Thread Daniel P . Berrangé
Since Python 3.2 the SafeConfigParser class is renamed to just ConfigParser. The SafeConfigParser alias is targetted for deletion. ./lcitool:224: DeprecationWarning: The SafeConfigParser class has been renamed to ConfigParser in Python 3.2. This alias will be removed in future versions. Use

[libvirt] [jenkins-ci PATCH] lcitool: use yaml.safe_load instead of load

2019-05-03 Thread Daniel P . Berrangé
The yaml.load() method is historically unsafe as it allowed for arbitrary code execution: ./lcitool:323: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details. The PyYAML >= 5.1 is now

[libvirt] [jenkins-ci PATCH v2] lcitool: check for virt-install / ansible-playbook in $PATH

2019-05-03 Thread Daniel P . Berrangé
This improves error reporting: $ ./lcitool install libvirt-fedora-29 ./lcitool: Failed to install 'libvirt-fedora-29': [Errno 2] No such file or directory To $ ./lcitool install libvirt-fedora-29 ./lcitool: Cannot find virt-install in $PATH Signed-off-by: Daniel P. Berrangé ---

Re: [libvirt] [PATCH 1/3] virbuffer: Don't leak memory in virBufferAddBuffer

2019-05-03 Thread Michal Privoznik
On 5/3/19 11:18 AM, Andrea Bolognani wrote: On Thu, 2019-04-18 at 14:11 +0200, Michal Privoznik wrote: If an error occurs in a virBuffer* API the idea is to free the content immediately and set @error member used in error reporting later. Well, this is not what how virBufferAddBuffer works.

Re: [libvirt] [PATCH 1/3] virbuffer: Don't leak memory in virBufferAddBuffer

2019-05-03 Thread Andrea Bolognani
On Thu, 2019-04-18 at 14:11 +0200, Michal Privoznik wrote: > If an error occurs in a virBuffer* API the idea is to free the > content immediately and set @error member used in error reporting > later. Well, this is not what how virBufferAddBuffer works. > > Signed-off-by: Michal Privoznik > ---

Re: [libvirt] [PATCH 2/3] virbuffer: Use signed integer for storing error

2019-05-03 Thread Michal Privoznik
On 5/3/19 10:30 AM, Erik Skultety wrote: On Thu, Apr 18, 2019 at 02:11:24PM +0200, Michal Privoznik wrote: The @error member can contain a positive value (errno) or a negative value (-1) to denote an usage error. It doesn't make s/an usage/a usage --> even though there are 2 vowels in a row,

Re: [libvirt] [PATCH 3/3] virBuffer: Try harder to free buffer

2019-05-03 Thread Michal Privoznik
On 5/3/19 11:01 AM, Erik Skultety wrote: On Thu, Apr 18, 2019 at 02:11:25PM +0200, Michal Privoznik wrote: Currently, the way virBufferFreeAndReset() works is it relies on virBufferContentAndReset() to fetch the buffer content which is then freed. This works as long as there is no bug in

Re: [libvirt] [PATCH 1/3] virbuffer: Don't leak memory in virBufferAddBuffer

2019-05-03 Thread Michal Privoznik
On 5/3/19 10:40 AM, Erik Skultety wrote: On Thu, Apr 18, 2019 at 02:11:23PM +0200, Michal Privoznik wrote: If an error occurs in a virBuffer* API the idea is to free the content immediately and set @error member used in error reporting later. Well, this is not what how virBufferAddBuffer works.

Re: [libvirt] [PATCH 3/3] virBuffer: Try harder to free buffer

2019-05-03 Thread Erik Skultety
On Thu, Apr 18, 2019 at 02:11:25PM +0200, Michal Privoznik wrote: > Currently, the way virBufferFreeAndReset() works is it relies on > virBufferContentAndReset() to fetch the buffer content which is > then freed. This works as long as there is no bug in virBuffer* > implementation (not true

[libvirt] [PATCH 4/4] tests: domaincaps: Add QEMU 4.0.0 for s390x

2019-05-03 Thread Boris Fiuczynski
Signed-off-by: Boris Fiuczynski --- .../domaincapsschemadata/qemu_4.0.0.s390x.xml | 198 ++ tests/domaincapstest.c| 4 + 2 files changed, 202 insertions(+) create mode 100644 tests/domaincapsschemadata/qemu_4.0.0.s390x.xml diff --git

[libvirt] [PATCH 2/4] tests: domaincaps: Add QEMU 3.1.0 for s390x

2019-05-03 Thread Boris Fiuczynski
Signed-off-by: Boris Fiuczynski --- .../domaincapsschemadata/qemu_3.1.0.s390x.xml | 196 ++ tests/domaincapstest.c| 4 + 2 files changed, 200 insertions(+) create mode 100644 tests/domaincapsschemadata/qemu_3.1.0.s390x.xml diff --git

[libvirt] [PATCH 0/4] tests: Add capabilities for s390x

2019-05-03 Thread Boris Fiuczynski
This series adds the capabilities of QEMU 3.1.0 and 4.0.0 on s390x. Boris Fiuczynski (4): tests: Add capabilities for QEMU 3.1.0 on s390x tests: domaincaps: Add QEMU 3.1.0 for s390x tests: Add capabilities for QEMU 4.0.0 on s390x tests: domaincaps: Add QEMU 4.0.0 for s390x

Re: [libvirt] [PATCH 1/3] virbuffer: Don't leak memory in virBufferAddBuffer

2019-05-03 Thread Erik Skultety
On Thu, Apr 18, 2019 at 02:11:23PM +0200, Michal Privoznik wrote: > If an error occurs in a virBuffer* API the idea is to free the > content immediately and set @error member used in error reporting > later. Well, this is not what how virBufferAddBuffer works. > > Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH v2 1/1] tests/virhostdevtest: remove virHostdevHostSupportsPassthroughKVM

2019-05-03 Thread Michal Privoznik
On 5/2/19 2:51 PM, Daniel Henrique Barboza wrote: virhostdevtest is using pci mock to emulate all PCI attach/detach operations. This means that that this test does not rely on KVM support of the host anymore and the tests in this file shouldn't be affected by it. Suggested-by: Michal Privoznik

Re: [libvirt] [PATCH 2/3] virbuffer: Use signed integer for storing error

2019-05-03 Thread Erik Skultety
On Thu, Apr 18, 2019 at 02:11:24PM +0200, Michal Privoznik wrote: > The @error member can contain a positive value (errno) or a > negative value (-1) to denote an usage error. It doesn't make s/an usage/a usage --> even though there are 2 vowels in a row, pronounciation is important, since you

Re: [libvirt] [PATCH] qemuConnectOpen: Drop unused @cfg and simplify

2019-05-03 Thread Andrea Bolognani
On Tue, 2019-04-30 at 11:47 +0200, Michal Privoznik wrote: > After 65a372d6e0 the @cfg variable is no longer used. This means > we can drop it and therefore drop 'cleanup' label with it. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_driver.c | 17 + > 1 file changed,