Re: [libvirt] [PATCH v3 0/8] CPU Model Baseline and Comparison for s390x

2019-06-12 Thread Collin Walling
Polite ping. I'd like to at least make sure these patches are on the right track with what libvirt expects for these commands. :) On 5/30/19 10:23 AM, Collin Walling wrote: Changelog: v2 - numerous cleanups - removed "policy fix function" and now properly check

Re: [libvirt] [PATCH 0/3] tests: Include LDADDS in qemu_LDADDS

2019-06-12 Thread Andrea Bolognani
On Wed, 2019-06-12 at 10:53 -0600, Jim Fehlig wrote: > On 6/12/19 5:19 AM, Andrea Bolognani wrote: > > Finally got around to implement the suggestion I made in > > > >https://www.redhat.com/archives/libvir-list/2019-May/msg00894.html > > > > Andrea Bolognani (3): > >tests: Tweak

Re: [libvirt] [PATCH] qemu: Add support for overriding max threads per process limit

2019-06-12 Thread Jim Fehlig
On 6/6/19 11:40 AM, Jim Fehlig wrote: Some VM configurations may result in a large number of threads created by the associated qemu process which can exceed the system default limit. The maximum number of threads allowed per process is controlled by the pids cgroup controller and is set to 16k

Re: [libvirt] [PATCH 0/3] tests: Include LDADDS in qemu_LDADDS

2019-06-12 Thread Jim Fehlig
On 6/12/19 5:19 AM, Andrea Bolognani wrote: Finally got around to implement the suggestion I made in https://www.redhat.com/archives/libvir-list/2019-May/msg00894.html Andrea Bolognani (3): tests: Tweak cputest_LDADDS tests: Tweak vircapstest_LDADD tests: Include LDADDS in

Re: [libvirt] [PATCH 1/3] tests: Tweak cputest_LDADDS

2019-06-12 Thread Jim Fehlig
On 6/12/19 5:19 AM, Andrea Bolognani wrote: We want have all test programs using qemu_LDADDS also use LDADDS, This part of the sentence seems awkward. How about "We want all test programs using qemu_LDADDS to also use LDADDS," ? and cputest is the only existing exception. We can't just

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-12 Thread Halil Pasic
On Wed, 12 Jun 2019 09:14:39 +0200 Cornelia Huck wrote: > On Tue, 11 Jun 2019 14:28:22 -0600 > Alex Williamson wrote: > > > On Tue, 11 Jun 2019 21:45:08 +0200 > > Cornelia Huck wrote: > > > > > On Fri, 7 Jun 2019 18:06:30 +0200 > > > Halil Pasic wrote: > > > > > I guess for vfio-ccw one

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-12 Thread Halil Pasic
On Tue, 11 Jun 2019 21:45:08 +0200 Cornelia Huck wrote: > On Fri, 7 Jun 2019 18:06:30 +0200 > Halil Pasic wrote: > > > On Fri, 24 May 2019 12:11:06 +0200 > > Cornelia Huck wrote: > > > > > On Thu, 23 May 2019 17:20:01 -0600 > > > Alex Williamson wrote: > > > > > > > Hi, > > > > > > >

Re: [libvirt] [PATCH] qemu: domain: Log some useful data in qemuDomainStorageSourceAccessModify

2019-06-12 Thread Bjoern Walk
Peter Krempa [2019-06-12, 01:53PM +0200]: > Log the flags passed to the function in a exploded state so that it's > easily visible what's happening to the image. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_domain.c | 13 ++--- > 1 file changed, 10 insertions(+), 3

Re: [libvirt] [PATCH] qemu: domain: Log some useful data in qemuDomainStorageSourceAccessModify

2019-06-12 Thread Ján Tomko
On Wed, Jun 12, 2019 at 01:53:39PM +0200, Peter Krempa wrote: Log the flags passed to the function in a exploded state so that it's s/a exploded/an exploded/ easily visible what's happening to the image. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 13 ++--- 1 file

[libvirt] [PATCH] qemu: domain: Log some useful data in qemuDomainStorageSourceAccessModify

2019-06-12 Thread Peter Krempa
Log the flags passed to the function in a exploded state so that it's easily visible what's happening to the image. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_domain.c

[libvirt] [PATCH 2/3] tests: Tweak vircapstest_LDADD

2019-06-12 Thread Andrea Bolognani
We optionally include QEMU and LXC support in this test and depending on which is enabled (if either is enabled at all) we need to link in different objects. Right now we implicitly depend on the fact that qemu_LDADDS is empty when QEMU is not enabled to get the correct set of objects, but it's

[libvirt] [PATCH 0/3] tests: Include LDADDS in qemu_LDADDS

2019-06-12 Thread Andrea Bolognani
Finally got around to implement the suggestion I made in https://www.redhat.com/archives/libvir-list/2019-May/msg00894.html Andrea Bolognani (3): tests: Tweak cputest_LDADDS tests: Tweak vircapstest_LDADD tests: Include LDADDS in qemu_LDADDS tests/Makefile.am | 44

[libvirt] [PATCH 3/3] tests: Include LDADDS in qemu_LDADDS

2019-06-12 Thread Andrea Bolognani
At this point, all test programs that use qemu_LDADDS also use LDADDS, so we can remove a bunch of repetition by simply including the latter in the former. Signed-off-by: Andrea Bolognani --- tests/Makefile.am | 34 +- 1 file changed, 17 insertions(+), 17

Re: [libvirt] [PATCH] build: fix linking libqemutestdriver with LTO enabled

2019-06-12 Thread Andrea Bolognani
On Tue, 2019-06-04 at 09:33 +0200, Andrea Bolognani wrote: > I have something almost reasonable in a local branch, I'll polish it > up in the next few days and then post it. Done :) https://www.redhat.com/archives/libvir-list/2019-June/msg00339.html -- Andrea Bolognani / Red Hat /

[libvirt] [PATCH 1/3] tests: Tweak cputest_LDADDS

2019-06-12 Thread Andrea Bolognani
We want have all test programs using qemu_LDADDS also use LDADDS, and cputest is the only existing exception. We can't just replace GNULIB_LIBS with LDADDS though, even though the latter is a superset of the former, because that would result in a linking error due to including the same object

Re: [libvirt] [PATCH] test_driver: implement virDomainGetLaunchSecurityInfo

2019-06-12 Thread Erik Skultety
On Tue, Jun 11, 2019 at 01:07:26PM +0200, Ilias Stamatis wrote: > Since this is the test driver and this is tied to AMD CPUs at the > moment, we can pretend that the domain doesn't have launch security and > always return 0 parameters. I'd reword this in a bit different way: "Since the behaviour

Re: [libvirt] [PATCH v2]daemon: Fix a crash during virNetlinkEventServiceStopAll

2019-06-12 Thread Haitaoliu
The steps to reproduce: 1. create a xml file including the following configuration.             function='0x0' />                       function='0x0'/>     2.  ensure you systemd  has supported core dump function 3. create and start vm

[libvirt] [PATCH v2]daemon: Fix a crash during virNetlinkEventServiceStopAll

2019-06-12 Thread Liu Haitao
When reboot the host, a core dump file would be generated. The call traces are: Note.In this case, the main thread is thread 5. (gdb) thread 5 [Switching to thread 5 (LWP 4142)] (gdb) bt 0 0x7f00a6838273 in futex_wait_cancelable (private=, expected=0,

[libvirt] [PATCH] tests: qemumonitorjson: Replace use of virReportError

2019-06-12 Thread Peter Krempa
Use VIR_TEST_VERBOSE instead. This fixes the following syntax check problem: tests/qemumonitorjsontest.c:1409:virReportError(VIR_ERR_INTERNAL_ERROR, "arr should have been cleared"); Signed-off-by: Peter Krempa --- Pushed under the build-breaker rule. tests/qemumonitorjsontest.c | 2

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-12 Thread Cornelia Huck
On Tue, 11 Jun 2019 14:28:22 -0600 Alex Williamson wrote: > On Tue, 11 Jun 2019 21:45:08 +0200 > Cornelia Huck wrote: > > > On Fri, 7 Jun 2019 18:06:30 +0200 > > Halil Pasic wrote: > > > I guess for vfio-ccw one needs to make sure that the ccw device is bound > > > to the vfio-ccw driver