> virsh has to be able to work remotely so this code will definitely not
> be acceptable here.
>
> I think we can only go with adding a "type" field for the diskspec
> string which will be either "file" or "block" and do this in that case.
> e.g.
> --diskspec
On Wed, 26 Jun 2019 08:37:20 -0600
Alex Williamson wrote:
> On Wed, 26 Jun 2019 11:58:06 +0200
> Cornelia Huck wrote:
>
> > On Tue, 25 Jun 2019 16:52:51 -0600
> > Alex Williamson wrote:
> >
> > > Hi,
> > >
> > > Based on the discussions we've had, I've rewritten the bulk of
> > > mdevctl.
As planned I tagged RC1 in git and pushed signed tarball and source rpm
to the usual place:
https://libvirt.org/sources/
I'm on the road with even less testing capacity than usual, but
https://ci.centos.org/view/libvirt/ looks rather green except for some go
bindings so I assume we are in
On 5/30/19 11:23 AM, Collin Walling wrote:
Refactor some code in qemuMonitorJSONGetCPUModelExpansion to be
later used for the comparison and baseline functions.
This does not alter any functionality.
Signed-off-by: Collin Walling
Reviewed-by: Bjoern Walk
---
Reviewed-by: Daniel Henrique
From: Shivaprasad G Bhat
The softlink to physfn is the way to know if the device is
VF or not. So, the patch softlinks 'physfn' to the parent function.
The multifunction PCI devices dont have 'physfn' softlinks.
The patch adds few Virtual functions to the mock environment and
changes the
From: Shivaprasad G Bhat
Signed-off-by: Shivaprasad G Bhat
Signed-off-by: Daniel Henrique Barboza
---
src/util/virprocess.h | 2 +-
tests/Makefile.am | 7 +++
tests/qemuhotplugtest.c | 42 +-
From: Shivaprasad G Bhat
The pci-stub is obsolete for a while now. Upcoming test cases try
to test the VFIO hotplug/unplug cases.
Change the default test driver to vfio-pci instead of pci-stub,
and fail bind for pci-stub instead.
Signed-off-by: Shivaprasad G Bhat
Signed-off-by: Daniel
From: Michal Privoznik
The pci_driver_bind() and pci_driver_unbind() functions are
"internal implementation", meaning other parts of the code should
be able to call them and get the job done. Checking for actions
(PCI_ACTION_BIND and PCI_ACTION_UNBIND) should be done in
handlers
From: Shivaprasad G Bhat
There are already good number of test cases with hostdevices,
few have multifunction devices but none having more than one
than one multifunction cards.
This patch adds a case where there are two multifunction cards
and two Virtual functions part of the same XML.
The current virHostdevPreparePCIDevices code fails to detect an unmanaged
VFIO device that is in the activePCIHostdevs, and active in the same
domain name as dom_name, as a device in use. Considering a call to this
function, when activePCIHostdevs has a VFIO deviceA in the list, and
deviceA is
From: Shivaprasad G Bhat
The iommu group, /dev/vfio/ behaviors
of the host are mocked. This patch implements support for
multifunction/multiple devices per iommu groups and emulates
the /dev/vfio/ file correctly.
This code helps adding necessary testcases for pci-hotplug
code.
Signed-off-by:
This is the first part of the feature discussed at [1]. With the
exception of patch 06, these patches are aimed into preparing
the existing unit test infrastructure for the more sofisticated
multifunction tests to come.
First 3 Michal's patches helped me with unit test issues in
the first 3-4
From: Shivaprasad G Bhat
The mocked path falls into /sys/bus/kernel/iommu_groups instead of
/sys/kernel/iommu_groups. Needed for adding some new test cases.
Signed-off-by: Shivaprasad G Bhat
Signed-off-by: Daniel Henrique Barboza
---
tests/virpcimock.c | 4 ++--
1 file changed, 2
From: Michal Privoznik
This reverts commit b70c093ffa00cd87c8d39d3652b798f033a81faf.
In next commit the virpcimock is going to be extended and thus
binding a PCI device to vfio-pci driver will finally succeed.
Remove this test as it will no longer make sense.
Signed-off-by: Michal Privoznik
From: Michal Privoznik
Newer kernels (v3.16-rc1~29^2~6^4) have 'driver_override' file
which simplifies way of binding a PCI device to desired driver.
Libvirt has support for this for some time too (v2.3.0-rc1~236),
but not our virpcimock. So far we did not care because our code
is designed to
On Wed, Jun 26, 2019 at 04:54:42PM +0100, Daniel P. Berrangé wrote:
This reverts commit 71626402f481ed47ff67dafa8521b01a42625707.
Signed-off-by: Daniel P. Berrangé
---
docs/libvirt.css | 6 --
1 file changed, 6 deletions(-)
diff --git a/docs/libvirt.css b/docs/libvirt.css
index
On Wed, Jun 26, 2019 at 04:54:39PM +0100, Daniel P. Berrangé wrote:
A deprecation is inherantly a warning, not an error, so adding an error
with this name makes no conceptual sense.
Features in drivers may come & go at any time and we've always use the
VIR_ERR_NO_SUPPORT to indicate when a
On Wed, Jun 26, 2019 at 04:54:43PM +0100, Daniel P. Berrangé wrote:
This reverts commit fd14dfec88957599ac5cffa28ddb7b513f404d9d.
Signed-off-by: Daniel P. Berrangé
---
docs/hvsupport.pl | 44 ++--
docs/libvirt.css | 4
2 files changed, 14
On Wed, Jun 26, 2019 at 04:54:41PM +0100, Daniel P. Berrangé wrote:
This reverts commit 226094fbc483128cf4171c353aed738b8346.
A deprecation is a warning to something that use of a feature is
being discouraged. By definition it is not an error condition to
continue to use a deprecated
On Wed, Jun 26, 2019 at 04:54:40PM +0100, Daniel P. Berrangé wrote:
The public API entry points will report VIR_ERR_NO_SUPPORT to the
caller when a driver does not provide an implementation of a particular
method.
Signed-off-by: Daniel P. Berrangé
---
src/qemu/qemu_driver.c | 31
On Wed, Jun 26, 2019 at 04:54:42PM +0100, Daniel P. Berrangé wrote:
This reverts commit 71626402f481ed47ff67dafa8521b01a42625707.
Signed-off-by: Daniel P. Berrangé
---
docs/libvirt.css | 6 --
1 file changed, 6 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP
Hello,
I was thinking about how to implement the following APIs in the test driver:
-virDomainFSFreeze
-virDomainFSThaw
-virDomainFSTrim
The first two are conceptually paired. They both get a mountpoints
argument. The QEMU driver (which is the only driver implementing this
currently) ignores
This reverts commit 226094fbc483128cf4171c353aed738b8346.
A deprecation is a warning to something that use of a feature is
being discouraged. By definition it is not an error condition to
continue to use a deprecated feature.
A VIR_ERR_DEPRECATED constant thus makes no conceptual sense. For
The public API entry points will report VIR_ERR_NO_SUPPORT to the
caller when a driver does not provide an implementation of a particular
method.
Signed-off-by: Daniel P. Berrangé
---
src/qemu/qemu_driver.c | 31 ---
1 file changed, 31 deletions(-)
diff --git
This reverts commit fd14dfec88957599ac5cffa28ddb7b513f404d9d.
Signed-off-by: Daniel P. Berrangé
---
docs/hvsupport.pl | 44 ++--
docs/libvirt.css | 4
2 files changed, 14 insertions(+), 34 deletions(-)
diff --git a/docs/hvsupport.pl
A deprecation is inherantly a warning, not an error, so adding an error
with this name makes no conceptual sense.
Features in drivers may come & go at any time and we've always use the
VIR_ERR_NO_SUPPORT to indicate when a hypervisor driver does not support
a particular API.
Daniel P. Berrangé
This reverts commit 71626402f481ed47ff67dafa8521b01a42625707.
Signed-off-by: Daniel P. Berrangé
---
docs/libvirt.css | 6 --
1 file changed, 6 deletions(-)
diff --git a/docs/libvirt.css b/docs/libvirt.css
index 6639b1df64..54d015db98 100644
--- a/docs/libvirt.css
+++ b/docs/libvirt.css
@@
On Wed, 26 Jun 2019 11:58:06 +0200
Cornelia Huck wrote:
> On Tue, 25 Jun 2019 16:52:51 -0600
> Alex Williamson wrote:
>
> > Hi,
> >
> > Based on the discussions we've had, I've rewritten the bulk of
> > mdevctl. I think it largely does everything we want now, modulo
> > devices that will
https://bugzilla.redhat.com/show_bug.cgi?id=1692296#c7
This is a counterpart for ddc72f99027 and implements the same
check for coldplug.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_driver.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/src/qemu/qemu_driver.c
The sys/sysctl.h header is only needed on BSD platforms to get
the sysctlbyname() function declaration. On Linux we talk to
procfs instead to change sysctls.
Unfortunately a legacy sys/sysctl.h header does exist on Linux
and including it has recently started triggering a deprecation
warning from
On Wed, Jun 26, 2019 at 14:05:41 +0800, Liu Dayu wrote:
> virsh snapshot-create-as supports 'file' storage type in --diskspec by
> default.
> It doesn't support 'block' storage type in the process of
> virshParseSnapshotDiskspec().
> So if a snapshot on a block device (e.g. LV) was created, the
virsh snapshot-create-as supports 'file' storage type in --diskspec by default.
It doesn't support 'block' storage type in the process of
virshParseSnapshotDiskspec().
So if a snapshot on a block device (e.g. LV) was created, the type of current
running
storage source in dumpxml is inconsistent
On Wed, Jun 26, 2019 at 10:27:31AM +0200, Peter Krempa wrote:
> On Wed, Jun 26, 2019 at 10:23:25 +0200, Pavel Hrdina wrote:
> > On Wed, Jun 26, 2019 at 09:21:59AM +0200, Peter Krempa wrote:
> > > On Tue, Jun 25, 2019 at 13:16:25 +0200, Pavel Hrdina wrote:
> > > > Currently CPU controller cannot be
On Tue, 25 Jun 2019 16:52:51 -0600
Alex Williamson wrote:
> Hi,
>
> Based on the discussions we've had, I've rewritten the bulk of
> mdevctl. I think it largely does everything we want now, modulo
> devices that will need some sort of 1:N values per key for
> configuration in the config file
On Tue, Jun 25, 2019 at 04:30:33PM +0200, Peter Krempa wrote:
Our code would skip adding the default type in this cases, but since we
know that the only reasonable option here is 'fat' we can add it while
starting the VM.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c
On Tue, Jun 25, 2019 at 04:30:31PM +0200, Peter Krempa wrote:
qemuBuildDriveSourceStr omits the disk format string when we are
emulating a 'fat' filesystem froma directory. The logic should decide
from a
based on the 'actualType' as a disk type=pool may be converted to a
directory.
On Tue, Jun 25, 2019 at 04:30:32PM +0200, Peter Krempa wrote:
The storage volume may in fact convert into a directory when starting
the VM so that it may be actually possible to use it.
This is a regression caused by c9b27af32d5 as moving the check to
validation time without adjustment causes
On Tue, Jun 25, 2019 at 04:30:30PM +0200, Peter Krempa wrote:
virStorageSourceGetActualType would return VIR_STORAGE_TYPE_NONE in case
when a virStorageSource of (top level) type VIR_STORAGE_TYPE_VOLUME was
not prepared to use by the vm by calling
virDomainDiskTranslateSourcePool.
Fix this
Hello everyone once again.
Regarding an email bellow, i found why is this happening. Namely I've tried
updating libvirt and all it's components to version 4.10.0, but still the same
issue happened. I've reviewed xml files between CentOS 6 hypervisors and new
one on CentOS 7. And basically
On Mon, Jun 24, 2019 at 05:54:52PM +0200, Peter Krempa wrote:
This belongs to the new job management API which can manage also
non-block based jobs.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 12
src/qemu/qemu_monitor.h | 4
On Mon, Jun 24, 2019 at 05:54:55PM +0200, Peter Krempa wrote:
This new event is a superset of the BLOCK_JOB* events and also covers
jobs which don't bind to a VM disk.
In this patch the monitor part is implemented.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 13
On Mon, Jun 24, 2019 at 05:54:54PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 23 +
src/qemu/qemu_monitor.h | 49 +++
src/qemu/qemu_monitor_json.c | 79 +
On Wed, 2019-06-26 at 10:07 +0200, Ján Tomko wrote:
> And with this squashed into 4/4:
>
> diff --git
> a/tests/qemuxml2xmloutdata/aarch64-virt-graphics.aarch64-latest.xml
> b/tests/qemuxml2xmloutdata/aarch64-virt-graphics.aarch64-latest.xml
> index bf55bdace5..418fa29def 100644
> ---
On Mon, Jun 24, 2019 at 05:54:56PM +0200, Peter Krempa wrote:
The 'blockdev-create' starts a job which creates a storage volume using
the given protocol or formats an existing (added) volume with one of the
supported storage formats.
This patch adds the monitor interaction bits.
Signed-off-by:
On Mon, Jun 24, 2019 at 05:54:53PM +0200, Peter Krempa wrote:
This belongs to the new job management API which can manage also
non-block based jobs.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 12
src/qemu/qemu_monitor.h | 4
On Mon, Jun 24, 2019 at 05:54:51PM +0200, Peter Krempa wrote:
This belongs to the new job management API for generic jobs.
The dismiss command is meant to remove a concluded job after we were
able to get the final status.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 12
On Mon, Jun 24, 2019 at 05:54:50PM +0200, Peter Krempa wrote:
Allow using the delayed dismiss of the job so that we can reap the state
even if libvirtd was not running when qemu emitted the job completion
event.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c| 2 +-
On Mon, Jun 24, 2019 at 05:54:48PM +0200, Peter Krempa wrote:
Allow using the node name to specify the base of the 'stream' operation,
allow specifying explicit job name and add support for delayed dismiss
of the job so that we can reap the state even if libvirtd was not
running when qemu
On Mon, Jun 24, 2019 at 05:54:49PM +0200, Peter Krempa wrote:
Allow using the node name to specify the base and top of the 'commit'
operation, allow specifying explicit job name and add support for
delayed dismiss of the job so that we can reap the state even if
libvirtd was not running when
On Wed, Jun 26, 2019 at 10:23:25 +0200, Pavel Hrdina wrote:
> On Wed, Jun 26, 2019 at 09:21:59AM +0200, Peter Krempa wrote:
> > On Tue, Jun 25, 2019 at 13:16:25 +0200, Pavel Hrdina wrote:
> > > Currently CPU controller cannot be enabled if there is any real-time
> > > task running and is assigned
On Tue, Jun 25, 2019 at 13:16:21 +0200, Pavel Hrdina wrote:
> This affects only cgroups v2 where enabled controllers are not based on
> available mount points but on the list provided in cgroup.controllers
> file. However, moving it will fill in placement as well, so it needs
> to be freed
On Wed, Jun 26, 2019 at 09:21:59AM +0200, Peter Krempa wrote:
> On Tue, Jun 25, 2019 at 13:16:25 +0200, Pavel Hrdina wrote:
> > Currently CPU controller cannot be enabled if there is any real-time
> > task running and is assigned to non-root cgroup which is the case on
> > several distributions
On Tue, Jun 25, 2019 at 13:16:26 +0200, Pavel Hrdina wrote:
> When detecting available controllers on host we can be limited by list
> of controllers from qemu.conf file.
>
> Signed-off-by: Pavel Hrdina
> ---
>
> Notes:
> Introduced in v3
>
> src/util/vircgroupv2.c | 8
> 1 file
On Wed, Jun 26, 2019 at 09:58:51AM +0200, Andrea Bolognani wrote:
On Tue, 2019-06-25 at 20:38 +0200, Ján Tomko wrote:
On Fri, Jun 14, 2019 at 10:04:39AM +0200, Andrea Bolognani wrote:
[...]
> +/usr/share/AAVMF/AAVMF_CODE.fd
> +/home/abologna/.config/libvirt/qemu/nvram/guest_VARS.fd
On Tue, 2019-06-25 at 20:38 +0200, Ján Tomko wrote:
> On Fri, Jun 14, 2019 at 10:04:39AM +0200, Andrea Bolognani wrote:
[...]
> > + > type='pflash'>/usr/share/AAVMF/AAVMF_CODE.fd
> > +/home/abologna/.config/libvirt/qemu/nvram/guest_VARS.fd
>
> Haha, nope.
> 928) QEMU XML-2-XML-inactive
On Wed, Jun 05, 2019 at 12:31:01PM +0200, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
The field is set just before returning on success.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_firmware.c | 2 --
1 file changed, 2 deletions(-)
Reviewed-by: Ján Tomko
and I pushed
On Tue, Jun 25, 2019 at 13:16:24 +0200, Pavel Hrdina wrote:
> In order to skip controllers that we are not able to activate we need
> to return different return value so the caller can decide what to do.
>
> Signed-off-by: Pavel Hrdina
> ---
>
> Notes:
> Introduced in v2
ACK although based
On Wed, Jun 05, 2019 at 12:31:00PM +0200, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_tpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c
index
On Wed, Jun 05, 2019 at 12:30:59PM +0200, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/conf/device_conf.c | 21 -
src/conf/device_conf.h | 2 --
src/libvirt_private.syms | 1 -
3 files changed, 24 deletions(-)
On Tue, Jun 25, 2019 at 13:16:25 +0200, Pavel Hrdina wrote:
> Currently CPU controller cannot be enabled if there is any real-time
> task running and is assigned to non-root cgroup which is the case on
> several distributions with graphical environment.
>
> Instead of erroring out treat it as the
On Wed, Jun 26, 2019 at 11:27:45AM +1000, Sergei Turchanov wrote:
This fixes regression caused by the 1d39dbaf637db03f6e597ed56b96aa065710b4a1
fdlist[i] erroneously was replaced by fdlist[1] which caused
lxcOpenNamespace to return a list with identical elements.
Signed-off-by: Sergei Turchanov
61 matches
Mail list logo
