Re: [libvirt] [PATCH 1/2] libxl: add acpi slic table support

On 9/10/19 5:24 PM, Marek Marczykowski-Górecki wrote: > On Tue, Sep 10, 2019 at 10:54:15PM +, Jim Fehlig wrote: >> On 9/6/19 8:31 PM, Marek Marczykowski-Górecki wrote: >>> From: Ivan Kardykov >>> >>> Libxl driver did not support setup additional acpi firmware to xen >>> guest. It is

Re: [libvirt] [PATCH 1/2] libxl: add acpi slic table support

On Tue, Sep 10, 2019 at 10:54:15PM +, Jim Fehlig wrote: > On 9/6/19 8:31 PM, Marek Marczykowski-Górecki wrote: > > From: Ivan Kardykov > > > > Libxl driver did not support setup additional acpi firmware to xen > > guest. It is necessary to activate OEM Windows installs. This patch > > allow

Re: [libvirt] [PATCH 1/2] libxl: add acpi slic table support

On 9/6/19 8:31 PM, Marek Marczykowski-Górecki wrote: > From: Ivan Kardykov > > Libxl driver did not support setup additional acpi firmware to xen > guest. It is necessary to activate OEM Windows installs. This patch > allow to define in OS section acpi table param (which supported domain >

Re: [libvirt] [Libvirt-ci] Build failed in Jenkins: libosinfo-build » libvirt-fedora-rawhide #231

[snip] > *** error: gettext infrastructure mismatch: using a Makefile.in.in from > gettext version 0.19 but the autoconf macros are from gettext version 0.20 > gmake[2]: *** [Makefile:237: stamp-po] Error 1 > gmake[2]: Leaving directory >

Re: [libvirt] [PATCH v4 0/8] CPU Model Baseline and Comparison for s390x

On 9/10/19 11:38 AM, David Hildenbrand wrote: On 10.09.19 17:22, Jiri Denemark wrote: On Tue, Sep 03, 2019 at 15:32:34 -0400, Collin Walling wrote: On 8/20/19 10:06 AM, Jiri Denemark wrote: First, let me apologize for such a late review. I'll try my best to review your series earlier next

Re: [libvirt] [PATCH] qemu: Fix regression in snapshot-revert

On 9/10/19 3:59 PM, Eric Blake wrote: On 9/9/19 5:17 PM, Daniel Henrique Barboza wrote: On 9/9/19 5:52 PM, Eric Blake wrote: Commit f10562799 introduced a regression: if reverting to a snapshot fails early (such as when we refuse to revert to an external snapshot), we lose track of the

Re: [libvirt] [PATCH 0/7] qemu_command: clean up more labels (virtio-fs epopee)

On 8/26/19 4:44 PM, Ján Tomko wrote: > Ján Tomko (7): > qemuBuildHostNetStr: remove unused cfg > qemuBuildHostNetStr: remove unused 'driver' argument > qemuBuildHostNetStr: remove unnecessary cleanup label > qemuBuildSoundCommandLine: reduce scope of codecstr >

Re: [libvirt] [PATCH] qemu: Fix regression in snapshot-revert

On 9/9/19 5:17 PM, Daniel Henrique Barboza wrote: > > > On 9/9/19 5:52 PM, Eric Blake wrote: >> Commit f10562799 introduced a regression: if reverting to a snapshot >> fails early (such as when we refuse to revert to an external >> snapshot), we lose track of the domain's current snapshot. >> >>

Re: [libvirt] [PATCH] libvirt.spec.in: Add the Secure Boot-variant OVMF binaries

On 7/30/19 12:11 PM, Kashyap Chamarthy wrote: > Currently the RPM spec doesn't add the 'secboot'-variant OVMF binaries > (an unintentional omission, checking with Cole on #virt, OFTC) for > 'x86_64' and 'ia32'. Add them. > > This way, getDomainCapabilities() will report all the OVMF binaries

Re: [libvirt] Error when creating VM with persistent memory

On 9/4/19 6:31 PM, Dan Williams wrote: > On Wed, Sep 4, 2019 at 12:56 AM Seema Pandit wrote: >> >> Actually there is still some issue around this. When trying to start another >> VM, so using even more pmem, there is a different issue now. Error copied >> below. >> >> []# virsh start

Re: [libvirt] [PATCH v4 0/8] CPU Model Baseline and Comparison for s390x

On 10.09.19 17:22, Jiri Denemark wrote: > On Tue, Sep 03, 2019 at 15:32:34 -0400, Collin Walling wrote: >> On 8/20/19 10:06 AM, Jiri Denemark wrote: >>> First, let me apologize for such a late review. I'll try my best to >>> review your series earlier next time. >>> >> >> Your review is greatly

Re: [libvirt] [PATCH v4 0/8] CPU Model Baseline and Comparison for s390x

On Tue, Sep 03, 2019 at 15:32:34 -0400, Collin Walling wrote: > On 8/20/19 10:06 AM, Jiri Denemark wrote: > > First, let me apologize for such a late review. I'll try my best to > > review your series earlier next time. > > > > Your review is greatly appreciated! I haven't replied to your other

[libvirt] [PATCH] libvirt_python:fix bug of sanitytest.py script

From: ossdev libvirt-python:fix bug of sanitytest.py script Signed-off-by: ossdev --- sanitytest.py | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/sanitytest.py b/sanitytest.py index e87b57d..c5d1f42 100644 --- a/sanitytest.py +++ b/sanitytest.py @@

[libvirt] [PATCH v5 2/2] snapshot: Store both config and live XML in the snapshot domain

From: "Maxiwell S. Garcia" The snapshot-create operation of running guests saves the live XML and uses it to replace the active and inactive domain in case of revert. So, the config XML is ignored by the snapshot process. This commit changes it and adds the config XML in the snapshot XML as the

Re: [libvirt] [PATCH v4 2/2] snapshot: Store both config and live XML in the snapshot domain

On Thu, Aug 29, 2019 at 17:55:43 -0300, Maxiwell S. Garcia wrote: > The snapshot-create operation of running guests saves the live > XML and uses it to replace the active and inactive domain in > case of revert. So, the config XML is ignored by the snapshot > process. This commit changes it and

Re: [libvirt] [PATCH] domain_conf: Drop ancient reservation of unit 7 in drive address

On Wed, Aug 28, 2019 at 11:52:45AM +0200, Michal Privoznik wrote: Introduced in v1.0.6~3, the idea was that unit 7 was reserved and couldn't be used by QEMU. Well, that limitation is long gone. How does "long gone" translate to our platform support matrix? Jano Signed-off-by: Michal

Re: [libvirt] [PATCH] domain_conf: Drop ancient reservation of unit 7 in drive address

On 8/28/19 6:52 AM, Michal Privoznik wrote: Introduced in v1.0.6~3, the idea was that unit 7 was reserved and couldn't be used by QEMU. Well, that limitation is long gone. Signed-off-by: Michal Privoznik --- Reviewed-by: Daniel Henrique Barboza src/conf/domain_conf.c | 6 -- 1

Re: [libvirt] [PATCH 0/5] qemu: Use FW descriptors to report FW image paths

On 8/5/19 6:14 PM, Michal Privoznik wrote: > Ping. Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] domain_conf: Drop ancient reservation of unit 7 in drive address

On 8/28/19 11:52 AM, Michal Privoznik wrote: > Ping. Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] qemu: Don't leak domain def when RevertToSnapshot fails

Once we copy the domain definition from virDomainSnapshotDef, we either need to assign it to the domain object or free it to avoid memory leaks. Signed-off-by: Jiri Denemark --- src/qemu/qemu_driver.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git

[libvirt] [PATCH] virnetdevmacvlan: Provide stubs for macvlan related functions

In recent commit of 3d21ff72e0e the virNetDevMacVLanTapOpen() and virNetDevMacVLanTapSetup() functions were exported in our private symbols. But these functions live in an #ifdef so they need a stub implementation. Then in 1b46566ee the virNetDevMacVLanIsMacvtap() function was implemented but

Re: [libvirt] [PATCH 0/2] conf: Avoid checking root element name in virDomainDefParseNode

On 9/10/19 10:45 AM, Jiri Denemark wrote: The only caller for which this check makes sense is virDomainDefParse. Thus the check should be moved there. Jiri Denemark (2): conf: Add cleanup label to virDomainDefParse conf: Avoid checking root element name in virDomainDefParseNode

[libvirt] [PATCH v2 2/2] Revert "qemu: add socket datagram capability"

This reverts commit 0cebb6422a63f5a8289ae43a36f8f33eb9956a4c. This capability is not used anywhere and also it is not contained in any release so it's safe to just remove it. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 5 -

[libvirt] [PATCH v2 1/2] qemu: Enable slirp-helper iff dbus-vmstate present

The fact that qemu is capable -netdev socket is not enough to start a migratable domain. It also needs dbus-vmstate capability. Since there are already some qemu releases which have net-socket-dgram capability and don't have dbus-vmstate we need to check for dbus-vmstate. Signed-off-by: Michal

[libvirt] [PATCH v2 0/2] qemu: Enable slirp-helper iff dbus-vmstate present

This is technically a v2 of: https://www.redhat.com/archives/libvir-list/2019-September/msg00281.html It implements what Jano suggested - use dbus-vmstate capability to decide if slirp-helper is used. Michal Prívozník (2): qemu: Enable slirp-helper iff dbus-vmstate present Revert "qemu: add

Re: [libvirt] [PATCH v4 1/2] qemu: formatting XML from domain def choosing the root name

On Thu, Aug 29, 2019 at 17:55:42 -0300, Maxiwell S. Garcia wrote: > The function virDomainDefFormatInternal() has the predefined root name > "domain" to format the XML. But to save both active and inactive domain > in the snapshot XML, the new root name "inactiveDomain" was created. > So, the new

[libvirt] [PATCH 1/2] conf: Add cleanup label to virDomainDefParse

Signed-off-by: Jiri Denemark --- src/conf/domain_conf.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7f49c8253f..17ddebb575 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -21517,16

[libvirt] [PATCH 0/2] conf: Avoid checking root element name in virDomainDefParseNode

The only caller for which this check makes sense is virDomainDefParse. Thus the check should be moved there. Jiri Denemark (2): conf: Add cleanup label to virDomainDefParse conf: Avoid checking root element name in virDomainDefParseNode src/conf/domain_conf.c | 29

[libvirt] [PATCH 2/2] conf: Avoid checking root element name in virDomainDefParseNode

The only caller for which this check makes sense is virDomainDefParse. Thus the check should be moved there. Signed-off-by: Jiri Denemark --- src/conf/domain_conf.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c

Re: [libvirt] [PATCH 5/6] lxcParseConfigString: Don't return success if post parse callback fails

On Mon, Sep 09, 2019 at 06:00:26PM +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/lxc/lxc_native.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature -- libvir-list mailing list

Re: [libvirt] [PATCH 6/6] lib: Define and use autofree for virConfPtr

On Mon, Sep 09, 2019 at 06:00:27PM +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/bhyve/bhyve_conf.c| 10 +--- > src/libvirt-admin.c | 3 +- > src/libvirt.c | 4 +- > src/libxl/libxl_conf.c| 22 +++- >

Re: [libvirt] [PATCH 1/6] qemu_conf.c: Fix naming of *AddRemove* functions

On Mon, Sep 09, 2019 at 06:00:22PM +0200, Michal Privoznik wrote: > Our naming rules prefer qemuObjectOperation() scheme rather than > qemuOperationObject() for function names. These were not honoured > in recent commits to qemu_conf.c. > > Signed-off-by: Michal Privoznik > --- >

Re: [libvirt] [PATCH 4/6] qemu_conf: Use more of VIR_AUTOUNREF()

On Mon, Sep 09, 2019 at 06:00:25PM +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_conf.c | 139 --- > 1 file changed, 63 insertions(+), 76 deletions(-) Reviewed-by: Pavel Hrdina signature.asc Description: PGP

Re: [libvirt] [PATCH 2/6] qemu_conf: Drop a pair of needless 'cleanup' labels

On Tue, Sep 10, 2019 at 09:19:50AM +0200, Pavel Hrdina wrote: > On Mon, Sep 09, 2019 at 06:00:23PM +0200, Michal Privoznik wrote: > > There are two 'cleanup' labels - one in > > virQEMUDriverConfigHugeTLBFSInit() and the other in > > virQEMUDriverConfigSetDefaults() that do nothing more than > >

Re: [libvirt] [PATCH 3/6] qemu_conf: Use more of VIR_AUTOFREE()

On Mon, Sep 09, 2019 at 06:00:24PM +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_conf.c | 130 +-- > 1 file changed, 40 insertions(+), 90 deletions(-) > > diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c >

Re: [libvirt] [PATCH 2/6] qemu_conf: Drop a pair of needless 'cleanup' labels

On Mon, Sep 09, 2019 at 06:00:23PM +0200, Michal Privoznik wrote: > There are two 'cleanup' labels - one in > virQEMUDriverConfigHugeTLBFSInit() and the other in > virQEMUDriverConfigSetDefaults() that do nothing more than > return and integer value. No memory freeing or anything important > is