On Sat, Sep 14, 2019 at 21:04:28 -0500, Eric Blake wrote:
> On 9/14/19 3:44 AM, Peter Krempa wrote:
> > Most code paths prevent starting a blockjob if we already have one but
> > the job registering function does not do this check. While this isn't a
> > problem for regular cases we had a bad test
On 9/13/19 4:02 PM, Michal Prívozník wrote:
On 9/13/19 4:52 PM, Laine Stump wrote:
+qemuCaps && !virQEMUCapsGet(qemuCaps,
QEMU_CAPS_VHOSTUSER_MULTIQUEUE)) {
NULL is never passed to qemuCaps, so no need to check it.
I had put that in so I could also call it from
On 9/13/19 4:02 PM, Michal Prívozník wrote:
On 9/13/19 4:52 PM, Laine Stump wrote:
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -5300,6 +5300,86 @@ qemuDomainWatchdogDefValidate(const virDomainWatchdogDef
*dev,
}
+
3 empty lines instead of 2.
:-O
+int
On 9/13/19 4:02 PM, Michal Prívozník wrote:
On 9/13/19 4:52 PM, Laine Stump wrote:
There is some validation of NetDefs () that can't be done
until runtime, due to not knowing the exact configuration until that
time. This needs to happen in 3 places: 1) in the qemu commandline
when a new guest
From: Ivan Kardykov
Libxl driver did not support setup additional acpi firmware to xen
guest. It is necessary to activate OEM Windows installs. This patch
allow to define in OS section acpi table param (which supported domain
common schema).
Signed-off-by: Ivan Kardykov
[added info to
Signed-off-by: Marek Marczykowski-Górecki
---
tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json | 54 +-
tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml | 32 -
tests/libxlxml2domconfigtest.c | 2 +-
3 files changed, 88 insertions(+)
create
This isn't exactly equivalent setting (acpi_firmware may point to
non-SLIC ACPI table), but it's the most behavior preserving option.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/xen_xl.c | 7 ++-
tests/xlconfigdata/test-fullvirt-acpi-slic.cfg | 26
On Sat, Sep 14, 2019 at 10:43:59AM +0200, Peter Krempa wrote:
We leaked a block job object in the tests because two jobs with distinct
names referenced the same disk. Fix the test data and add code to
prevent this issue.
This makes way more sense than the patch form Michal, so I prefer this
