On Wed, Sep 18, 2019 at 16:18:23 +0200, Michal Privoznik wrote:
> On 9/18/19 9:58 AM, Peter Krempa wrote:
> > Basing the colors on the message itself is in many cases wrong. Look
> > into the patches for examples.
> >
> > Peter Krempa (2):
> > Revert "virt-result.m4: Colourize summary
On Wed, Sep 18, 2019 at 9:57 PM Ján Tomko wrote:
>
> On Wed, Sep 18, 2019 at 05:40:06PM +0200, Fabiano Fidêncio wrote:
> >On Wed, Sep 18, 2019 at 1:22 AM Fabiano Fidêncio wrote:
> >>
> >> On Tue, Sep 17, 2019 at 8:17 PM Pavel Hrdina wrote:
> >> >
> >> > On Tue, Sep 17, 2019 at 06:53:30PM +0200,
On Wed, Sep 18, 2019 at 05:40:06PM +0200, Fabiano Fidêncio wrote:
On Wed, Sep 18, 2019 at 1:22 AM Fabiano Fidêncio wrote:
On Tue, Sep 17, 2019 at 8:17 PM Pavel Hrdina wrote:
>
> On Tue, Sep 17, 2019 at 06:53:30PM +0200, Fabiano Fidêncio wrote:
> > On Tue, Sep 17, 2019 at 5:22 PM Pavel Hrdina
Similar work to [1], but this time someone already changed
the virQEMUDriverConfigPtr to use VIR_AUTOUNREF() in this
file, which is less work pending to do, which is good.
This change in particular will royally mess up with my
rebases, but it's for a good cause.
[1]
Using VIR_AUTOFREE() spare us from calling VIR_VREE() and
sometimes a whole 'cleanup' label can be erased as well.
There are quite a few strings in qemu_hotplug.c to be
auto-freed. This is the last part of this change.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_hotplug.c | 93
Using VIR_AUTOFREE() spare us from calling VIR_VREE() and
sometimes a whole 'cleanup' label can be erased as well.
There are quite a few strings in qemu_hotplug.c to be
auto-freed. This is the second part of this change.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_hotplug.c | 87
Using VIR_AUTOFREE() spare us from calling VIR_VREE() and
sometimes a whole 'cleanup' label can be erased as well.
There are quite a few strings in qemu_hotplug.c to be
auto-freed. This is the first part of this change.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_hotplug.c | 106
On Mon, Sep 16, 2019 at 14:17:12 +0200, Peter Krempa wrote:
> Use VIR_AUTO* for temporary locals and get rid of the 'cleanup' label.
>
> Signed-off-by: Peter Krempa
> ---
> src/conf/secret_conf.c | 34 ++
> 1 file changed, 14 insertions(+), 20 deletions(-)
On Mon, Sep 16, 2019 at 14:17:11 +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> src/conf/secret_conf.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/conf/secret_conf.h b/src/conf/secret_conf.h
> index de1c28e187..7cfcfc8a60 100644
> ---
On Mon, Sep 16, 2019 at 14:17:10 +0200, Peter Krempa wrote:
> Use VIR_AUTOPTR for temporary locals and get rid of the cleanup label.
>
> Signed-off-by: Peter Krempa
> ---
> src/conf/domain_conf.c | 20 +++-
> 1 file changed, 7 insertions(+), 13 deletions(-)
Reviewed-by: Jiri
On Mon, Sep 16, 2019 at 14:17:09 +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> src/conf/domain_conf.h | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Jiri Denemark
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Mon, Sep 16, 2019 at 14:17:08 +0200, Peter Krempa wrote:
> Refactor functions using these two object types together with
> VIR_AUTOPTR.
>
> Signed-off-by: Peter Krempa
> ---
> src/conf/domain_conf.c | 16 +---
> src/conf/storage_conf.c | 20 +++-
> 2 files
On Mon, Sep 16, 2019 at 14:17:07 +0200, Peter Krempa wrote:
> Clean up functions which grab and free the context to use VIR_AUTOPTR.
>
> Signed-off-by: Peter Krempa
> ---
> src/conf/checkpoint_conf.c | 12
> src/conf/domain_conf.c | 13 -
>
On Mon, Sep 16, 2019 at 14:17:06 +0200, Peter Krempa wrote:
> Use VIR_AUTO* helpers to get rid of the convoluted cleanup path.
>
> Signed-off-by: Peter Krempa
> ---
> src/conf/domain_conf.c | 73 +++---
> 1 file changed, 33 insertions(+), 40 deletions(-)
On Mon, Sep 16, 2019 at 14:17:05 +0200, Peter Krempa wrote:
> Add automatic cleanup for variables of xmlDoc and xmlXPathContext type
> to remove the cleanup section.
>
> Signed-off-by: Peter Krempa
> ---
> src/conf/network_conf.c | 36
> 1 file changed, 16
On Mon, Sep 16, 2019 at 14:17:04 +0200, Peter Krempa wrote:
> The wrapper reports libvirt errors for the libxml2 function so that
> the same does not have to be repeated over and over.
>
> Signed-off-by: Peter Krempa
> ---
> src/conf/checkpoint_conf.c | 5 +
> src/conf/domain_conf.c
On Wed, Sep 18, 2019 at 02:55:53PM +0200, Andrea Bolognani wrote:
> On Wed, 2019-09-18 at 10:39 +0100, Daniel P. Berrangé wrote:
> > We certainly could bundle meson with them, but given that in very
> > short time we're going to have libvirt, libvirt-dbus, osinfo-db-tools,
> > libosinfo, gtk-vnc,
It's been agreed that the projects using libvirt-jenkins-ci would have
the `syntax-check` running as part of their test suite. Therefore,
there's no reason for keeping a job which is not going to be used.
Signed-off-by: Fabiano Fidêncio
---
.../build/projects/osinfo-db-tools.yml| 1 -
On Wed, Sep 18, 2019 at 1:22 AM Fabiano Fidêncio wrote:
>
> On Tue, Sep 17, 2019 at 8:17 PM Pavel Hrdina wrote:
> >
> > On Tue, Sep 17, 2019 at 06:53:30PM +0200, Fabiano Fidêncio wrote:
> > > On Tue, Sep 17, 2019 at 5:22 PM Pavel Hrdina wrote:
> > > >
> > > > Meson build system is simple and
On Fri, Sep 13, 2019 at 04:50:41PM +0400, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
vhost-user-gpu helper takes --render-node option to specify on which
GPU should the renderning be done.
Signed-off-by: Marc-André Lureau
---
docs/formatdomain.html.in | 6
On Fri, Sep 13, 2019 at 04:50:40PM +0400, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Accept a new driver name attribute to specify usage of helper process, ex:
Signed-off-by: Marc-André Lureau
---
docs/formatdomain.html.in | 12 ++-
VIR_AUTOFREE is a beautiful macro. Let's use it across the board
inside qemu_driver.c to make the code a bit tidier and smaller,
sparing VIR_FREE() calls and sometimes a whole 'cleanup'
label.
This is the last part of this change.
Signed-off-by: Daniel Henrique Barboza
---
VIR_AUTOFREE is a beautiful macro. Let's use it across the board
inside qemu_driver.c to make the code a bit tidier and smaller,
sparing VIR_FREE() calls and sometimes a whole 'cleanup'
label.
This is a huge change due to the amount of char * declared in
this file, thus let's split it in 3. This
VIR_AUTOFREE is a beautiful macro. Let's use it across the board
inside qemu_driver.c to make the code a bit tidier and smaller,
sparing VIR_FREE() calls and sometimes a whole 'cleanup'
label.
This is a huge change due to the amount of char * declared in
this file, thus let's split it in 3. This
virQEMUDriverConfigPtr can be auto-unref for the great majority
of the uses made in qemu_driver, sparing us a virObjectUnref()
call and sometimes a whole 'cleanup' label.
This patch changes virQEMUDriverConfigPtr declarations to
use VIR_AUTOUNREF(). 'cleanup' labels were deleted when
applicable.
virQEMUDriverConfigPtr can be auto-unref for the great majority
of the uses made in qemu_driver, sparing us a virObjectUnref()
call and sometimes a whole 'cleanup' label.
This patch changes virQEMUDriverConfigPtr declarations to
use VIR_AUTOUNREF(). 'cleanup' labels were deleted when
applicable.
virQEMUDriverConfigPtr can be auto-unref for the great majority
of the uses made in qemu_driver, sparing us a virObjectUnref()
call and sometimes a whole 'cleanup' label.
This patch changes virQEMUDriverConfigPtr declarations to
use VIR_AUTOUNREF(). 'cleanup' labels were deleted when
applicable.
I am messing a lot with qemu_driver.c and other QEMU files due
to a multifunction PCI feature I'm working on, ending up
sometimes moving code here and there, sometimes copy and
pasting parts of it, and spreading all these 'vices', namely
using char* and VIR_FREE() and virQEMUDriverConfigPtr with
On Fri, Sep 13, 2019 at 04:50:38PM +0400, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
The same config files disovery & priority rules are used for
vhost-user backends.
No functional change, the only difference is that
qemuInteropFetchConfigs() takes a "name" argument and
On Mon, Sep 16, 2019 at 02:45:31PM +0200, Peter Krempa wrote:
See patch 1 for impl and description and patch 2 for example.
Peter Krempa (5):
virsh: Allow using VIR_AUTOPTR for releasing virDomainPtr in virsh
virsh: demonstrate use of VIR_AUTOPTR(virshDomain) on
'send-process-signal'
On 9/18/19 9:58 AM, Peter Krempa wrote:
> Basing the colors on the message itself is in many cases wrong. Look
> into the patches for examples.
>
> Peter Krempa (2):
> Revert "virt-result.m4: Colourize summary printings"
> Revert "configure: Colorize output"
>
> m4/virt-colours.m4 | 62
On Wed, 2019-09-18 at 10:39 +0100, Daniel P. Berrangé wrote:
> We certainly could bundle meson with them, but given that in very
> short time we're going to have libvirt, libvirt-dbus, osinfo-db-tools,
> libosinfo, gtk-vnc, spice-gtk all using meson, bundling meson in the
> individual tarballs
On Mon, Sep 16, 2019 at 05:45:45PM +0100, Daniel P. Berrangé wrote:
Neither virThreadInitialize or virThreadOnExit do anything since we
dropped the Win32 threads impl, in favour of win-pthreads.
In commit 0240d94c36c8ce0e7c35b5be430acd9ebf5adcfa to be precise.
Signed-off-by: Daniel P.
On Wed, Sep 18, 2019 at 12:19:43PM +0800, Shi Lei wrote:
Replace 'sc_prohibit_semicolon_at_eol_in_python' with generic 'sc_flake8' rule
to check python code style.
Now 'sc_flake8' just check the error E703: 'statement ends with a semicolon'.
In future, we could use '--select' to introduce more
On Wed, Sep 18, 2019 at 11:02:54AM +0100, Stefan Hajnoczi wrote:
> On Wed, Sep 18, 2019 at 9:28 AM Stefano Garzarella
> wrote:
> >
> > On Tue, Sep 17, 2019 at 02:02:59PM +0100, Stefan Hajnoczi wrote:
> > I volunteer for "Libvirt: Never too Late to Learn New Tricks" by
> > Daniel Berrange.
>
>
On Wed, Sep 18, 2019 at 9:28 AM Stefano Garzarella wrote:
>
> On Tue, Sep 17, 2019 at 02:02:59PM +0100, Stefan Hajnoczi wrote:
> I volunteer for "Libvirt: Never too Late to Learn New Tricks" by
> Daniel Berrange.
Hi Stefano,
Paolo has already volunteered for that. Is there another talk you are
On Tue, 17 Sep 2019 14:02:59 +0100
Stefan Hajnoczi wrote:
> Hi,
> LWN.net is a popular open source news site that covers Linux and other
> open source communities (Python, GNOME, Debian, etc). It has published
> a few KVM articles in the past too.
>
> Let's raise awareness of QEMU, KVM, and
On Wed, Sep 18, 2019 at 11:30:14AM +0200, Andrea Bolognani wrote:
> On Tue, 2019-09-17 at 20:17 +0200, Pavel Hrdina wrote:
> > On Tue, Sep 17, 2019 at 06:53:30PM +0200, Fabiano Fidêncio wrote:
> > > I didn't go through the patch, will do that in the next days ... but a
> > > few things should be
On Tue, 2019-09-17 at 20:17 +0200, Pavel Hrdina wrote:
> On Tue, Sep 17, 2019 at 06:53:30PM +0200, Fabiano Fidêncio wrote:
> > I didn't go through the patch, will do that in the next days ... but a
> > few things should be considered here:
> > - meson >= 0.49.0 basically means the project won't be
On Tue, Sep 17, 2019 at 02:02:59PM +0100, Stefan Hajnoczi wrote:
> Hi,
> LWN.net is a popular open source news site that covers Linux and other
> open source communities (Python, GNOME, Debian, etc). It has published
> a few KVM articles in the past too.
>
> Let's raise awareness of QEMU, KVM,
The colors are not based on the semantics of the message but rather
on the message itself. This means that the default human-perceived
semantics (red = bad, green = good) don't really apply and spotting a
color does not mean anythting.
This is amplified by the sheer amount of output which
The colorization based on the string itself makes little to no sense as
the semantic meaning of the color (red = bad, green = good) is not
extracted from the semantics of the message:
1) If there is some additional string a 'yes' is marked yellow:
configure: driver_modules: yes (CFLAGS=''
Basing the colors on the message itself is in many cases wrong. Look
into the patches for examples.
Peter Krempa (2):
Revert "virt-result.m4: Colourize summary printings"
Revert "configure: Colorize output"
m4/virt-colours.m4 | 62 --
Missing piece for [1]
[1]: 577a1f98: qemu: Pass correct qemuCaps to virDomainDefParseNode
Signed-off-by: Nikolay Shirokovskiy
---
src/vz/vz_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index 536a992..eb3fcf1 100644
---
Pushed as trivial and build breaker.
Nikolay Shirokovskiy (2):
vz: build fix for passing qemuCaps to virDomainDeviceDefPostParse
vz: build fix for passing qemuCaps to virDomainDefParseNode
src/vz/vz_driver.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
--
1.8.3.1
--
Missing piece for [1].
[1] b449c2704: qemu: Pass correct qemuCaps to virDomainDeviceDefPostParse
Signed-off-by: Nikolay Shirokovskiy
---
src/vz/vz_driver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index a4f6c39..536a992
46 matches
Mail list logo
