On 9/16/19 5:12 AM, Michal Privoznik wrote:
See 5/5 for explanation.
Michal Prívozník (5):
security: Pass @migrated to virSecurityManagerSetAllLabel
security: Rename virSecurityManagerGetDriver() to
virSecurityManagerGetVirtDriver()
security: Introduce
Sorry for the late reply, and thanks Jano for pointing out elsewhere
that this didn't receive a response.
On 8/12/19 5:56 AM, Li Feng wrote:
Hi Guys,
And I want to add the vhost-user-scsi-pci/vhost-user-blk-pci support
for libvirt.
The usage in qemu like this:
Vhost-SCSI
-chardev
It's an old compatibility shim that just delegates to ide-cd or ide-hd.
I'd like to refactor these some day, and getting rid of the super-object
will make that easier.
Either way, we don't need this.
Libvirt-checked-by: Peter Krempa
Signed-off-by: John Snow
---
qemu-deprecated.texi |
On 10/8/19 2:51 AM, Markus Armbruster wrote:
>> I'll respin to hit the tests with a stiffer scrub-brush.
> Thanks!
051 is the only test I can find that uses ide-drive, and the non-pc
version of the test doesn't seem to use it, so this actually seems
sufficient.
I'd like to keep the test for
V2: Change phrasings and spellings as Markus suggested.
John Snow (1):
IDE: deprecate ide-drive
qemu-deprecated.texi | 5 +
hw/ide/qdev.c | 3 +++
tests/qemu-iotests/051.pc.out | 6 --
3 files changed, 12 insertions(+), 2 deletions(-)
--
2.21.0
--
On 10/8/19 4:06 PM, Daniel Henrique Barboza wrote:
This patch adds the implementation of the ccf-assist pSeries
feature, based on the QEMU_CAPS_MACHINE_PSERIES_CAP_CCF_ASSIST
capability that was added in the previous patch.
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.html.in
On 10/7/19 6:49 PM, Cole Robinson wrote:
For the only usage, the rel == parent->backingStoreRaw, so drop
the direct access
Signed-off-by: Cole Robinson
---
Reviewed-by: Daniel Henrique Barboza
src/util/virstoragefile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On 10/7/19 6:49 PM, Cole Robinson wrote:
Call qcow2GetExtensions to actually fill in the virStorageSource
externalDataStoreRaw member
Signed-off-by: Cole Robinson
---
Reviewed-by: Daniel Henrique Barboza
src/util/virstoragefile.c | 6 ++
1 file changed, 6 insertions(+)
diff
On 10/7/19 6:49 PM, Cole Robinson wrote:
This is tracked as a qcow2 extension, like backing store format
Signed-off-by: Cole Robinson
---
Reviewed-by: Daniel Henrique Barboza
src/util/virstoragefile.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
This change gives me a segfault at startup when running libvirtd from
my working directory. Reverting these two patches solves the issue.
Thread 17 "lt-libvirtd" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffc0dff700 (LWP 4338)]
virDomainObjIsActive
On 10/7/19 6:49 PM, Cole Robinson wrote:
Add the plumbing to track a qcow2 external data file path in
virStorageSource
Signed-off-by: Cole Robinson
---
Reviewed-by: Daniel Henrique Barboza
src/util/virstoragefile.c | 2 ++
src/util/virstoragefile.h | 2 ++
2 files changed, 4
On 10/7/19 6:49 PM, Cole Robinson wrote:
>From qemu.git docs/interop/qcow2.txt
Here's the '>' again. I think this is something you're using to cite an
external source in the commit message. Is that it?
== String header extensions ==
Some header extensions (such as the backing file
On 10/7/19 6:49 PM, Cole Robinson wrote:
To backingFormat, which makes it more clear. Move it to the end of
the argument list which will scale nicer with future patches
Signed-off-by: Cole Robinson
---
This really makes it clearer. I was getting confused about whether
'format' was
On 10/7/19 6:49 PM, Cole Robinson wrote:
...to qcow2GetExtensions. We will extend it for more extension
parsing in future patches
Signed-off-by: Cole Robinson
---
Reviewed-by: Daniel Henrique Barboza
src/util/virstoragefile.c | 8
1 file changed, 4 insertions(+), 4
On 10/2/19 7:24 PM, John Snow wrote:
> This parameter has been deprecated since 2.12.0 and is eligible for
> removal. Remove this parameter as it is actually completely ignored;
> let's not give false hope.
>
> Signed-off-by: John Snow
> Reviewed-by: Eric Blake
> Reviewed-by: Vladimir
On 10/7/19 6:49 PM, Cole Robinson wrote:
This is a step towards making this qcow2GetBackingStoreFormat into
a generic qcow2 extensions parser
Signed-off-by: Cole Robinson
---
Reviewed-by: Daniel Henrique Barboza
src/util/virstoragefile.c | 66 +--
On 10/7/19 6:49 PM, Cole Robinson wrote:
This is a step towards making this qcow2GetBackingStoreFormat into
a generic qcow2 extensions parser
Signed-off-by: Cole Robinson
---
Reviewed-by: Daniel Henrique Barboza
src/util/virstoragefile.c | 33 +
1
On 10/7/19 6:49 PM, Cole Robinson wrote:
The qcow1 and qcow2 variants are identical, so remove the wrappers
Signed-off-by: Cole Robinson
---
Reviewed-by: Daniel Henrique Barboza
src/util/virstoragefile.c | 27 +++
1 file changed, 3 insertions(+), 24
On 10/7/19 6:49 PM, Cole Robinson wrote:
Signed-off-by: Cole Robinson
---
Reviewed-by: Daniel Henrique Barboza
src/util/virstoragefile.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index
On 10/7/19 6:49 PM, Cole Robinson wrote:
Rather than require a boolean to be passed in
Signed-off-by: Cole Robinson
---
I was about to say 'why didn't you remove the isQCow2 boolean and
change the 2 callers of the function ' but then I saw that the next 2
patches does further code
On 10/7/19 6:49 PM, Cole Robinson wrote:
Letting qcowXGetBackingStore fill in format gives the same behavior
we were opencoding in qcow1GetBackingStore
Signed-off-by: Cole Robinson
---
Reviewed-by: Daniel Henrique Barboza
src/util/virstoragefile.c | 19 +--
1 file
On 9/11/19 5:05 PM, Daniel Henrique Barboza wrote:
For some architectures and setups, device removal can take
longer than the default 5 seconds. This results in commands
such as 'virsh setvcpus' to fire timeout messages even if
the operation were successful in the guest, confusing the
user.
On 10/8/19 7:16 AM, Pavel Mores wrote:
If a graphics device is added to XML that has no video device, libvirt
automatically adds a video device which is always of type 'cirrus', even if
the underlying qemu doesn't support cirrus.
This patch refines a bit the decision about the type of the video
On 10/7/19 6:49 PM, Cole Robinson wrote:
>From f772b3d91fd the intention of this code seems to be to set
Is this leading '>' a bogus?
format=NONE when the image does not have a backing file. However
'buf' here is the whole qcow1 file header. What we want to be
checking is 'res' which is
On 10/7/19 6:49 PM, Cole Robinson wrote:
Check explicitly for BACKING_STORE_OK and not its 0 value
Signed-off-by: Cole Robinson
---
Reviewed-by: Daniel Henrique Barboza
src/util/virstoragefile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 9/10/19 2:19 AM, oss...@puresoftware.com wrote:
From: ossdev
libvirt-python:fix bug of sanitytest.py script
Hmm, what exactly is the bug you are hitting? Are you seeing an error? I
don't exactly follow what the patch is achieving
Signed-off-by: ossdev
This needs to list your real
On 10/7/19 6:49 PM, Cole Robinson wrote:
It is only used in virstoragefile.c
Signed-off-by: Cole Robinson
---
Reviewed-by: Daniel Henrique Barboza
src/libvirt_private.syms | 1 -
src/util/virstoragefile.c | 2 +-
src/util/virstoragefile.h | 6 --
3 files changed, 1
On 9/13/19 5:20 PM, Jonathon Jongsma wrote:
When the bochs display type was added, the capability was never checked.
Add that check in the same place as the other video device capability
checks.
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_process.c | 4 +++-
1 file changed, 3
Signed-off-by: Daniel Henrique Barboza
---
tests/Makefile.am | 7 ++-
tests/virdriverconnvalidatetest.c | 90 +++
2 files changed, 96 insertions(+), 1 deletion(-)
create mode 100644 tests/virdriverconnvalidatetest.c
diff --git a/tests/Makefile.am
changes from v4:
- other patches got merged, this is the last survivor
- enhanced the code by attending to all suggestions from Cole Robinson
v4: https://www.redhat.com/archives/libvir-list/2019-September/msg01164.html
Daniel Henrique Barboza (1):
tests: add a test for
ping series
On Fri, 2019-09-13 at 16:20 -0500, Jonathon Jongsma wrote:
> When the bochs display type was added, the capability was never
> checked.
> Add that check in the same place as the other video device capability
> checks.
>
> Signed-off-by: Jonathon Jongsma
> ---
>
On Fedora, already whitelisted paths to AAVMF and OVMF binaries
are symlinks to binaries under /usr/share/edk2/. Add that directory
to the RO whitelist so virt-aa-helper-test passes
Signed-off-by: Cole Robinson
---
I don't know if anyone is actually using apparmor on Fedora, but
I have the libs
Unmatched double quote in the commit summary
On Wed, Oct 09, 2019 at 12:39:15PM -0400, Laine Stump wrote:
Back in July 2009, in the days before libvirt supported explicitly
assigning a PCI address to every device, code was added to save the
PCI addresses of hotplugged network, disk, and
Daniel P. Berrangé writes:
> What userspace tool is broken, and in what way ?
The major use case, as far as I know, is from software license
managers which use this to determine how much to charge for
software. I would have to ask around to know exactly which ones and
how they operate.
>
Daniel P. Berrangé writes:
> On Tue, Oct 08, 2019 at 01:46:57PM -0300, Fabiano Rosas wrote:
>> Since QEMU v4.0.0, the host's model is no longer automatically exposed
>> to the guest via /proc/device-tree/host-model. There is now a machine
>> option 'host-model' that allows an arbitrary string to
On Tue, 2019-09-17 at 16:47 +0300, Nikolay Shirokovskiy wrote:
> If usb device attached to a domain is unplugged from host and
> then plugged back then it will no longer be available in guest.
> We are going to support this case so that device will be detached
> from qemu on unplug and attached
Back in July 2009, in the days before libvirt supported explicitly
assigning a PCI address to every device, code was added to save the
PCI addresses of hotplugged network, disk, and hostdevs in the domain
status with this XML element:
This was added in commits 4e21a95a, 01654107, in v0.7.0,
The corresponding libvirt-jenkins-ci commit is 1ec59b56598b.
Signed-off-by: Andrea Bolognani
---
Pushed under the Dockerfile refresh rule. Plain-text diff below.
buildenv-libosinfo-centos-7.zip | Bin 532 -> 546 bytes
buildenv-libosinfo-debian-10.zip | Bin 638 -> 646
On Wed, Oct 9, 2019 at 6:03 PM Daniel P. Berrangé wrote:
>
> On Wed, Oct 09, 2019 at 05:52:27PM +0200, Fabiano Fidêncio wrote:
> > Since commit d63d6a59cc we're installing EPEL on CentOS7 in order to
> > have both "ninja" and "python36-*" packages in the system.
> >
> > However, we've forgot to
On Wed, 2019-10-09 at 17:08 +0200, Fabiano Fidêncio wrote:
> The former can be added to tbe base project as a direct or indirect
> dependency of the most part of the projects in libvirt-jenkins-ci. The
> latter is needed in order to use pip module for ansible, which is used
> to install meson in
On Wed, Oct 09, 2019 at 05:52:27PM +0200, Fabiano Fidêncio wrote:
> Since commit d63d6a59cc we're installing EPEL on CentOS7 in order to
> have both "ninja" and "python36-*" packages in the system.
>
> However, we've forgot to add the very code to the lcitool so the
> containers would also have
On Wed, 2019-10-09 at 17:52 +0200, Fabiano Fidêncio wrote:
> +++ b/guests/lcitool
> @@ -714,6 +714,14 @@ class Application:
> {package_manager} autoremove -y && \\
> {package_manager} clean all -y
> """).format(**varmap))
> +
Since commit d63d6a59cc we're installing EPEL on CentOS7 in order to
have both "ninja" and "python36-*" packages in the system.
However, we've forgot to add the very code to the lcitool so the
containers would also have EPEL release installed.
Signed-off-by: Fabiano Fidêncio
---
guests/lcitool
python3-setuptools is an ansible pip module dependency, which is not
automatically pulled in.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/projects/base.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml
index
python3-setuptools is an ansible pip module dependency, which is not
automatically pulled in.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mappings.yml | 4
1 file changed, 4 insertions(+)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index ba0f1cf..02bf8fd 100644
The former can be added to tbe base project as a direct or indirect
dependency of the most part of the projects in libvirt-jenkins-ci. The
latter is needed in order to use pip module for ansible, which is used
to install meson in platforms where it's either not supported or doesn't
match the
As a bunch of projects already directly depend on python3 (libvirt-dbus,
libvirt-python, osinfo-db-tools, osinfo-db, virt-manager), and some
depend on it indirectly (as libvirt or anything else depending on
flake8), let's add python3 to the base project.
Signed-off-by: Fabiano Fidêncio
---
On 10/9/19 4:44 PM, Han Han wrote:
Hi,
Although libvirt-5.8 is released, however some features or improvement like
"slirp helper process" are missing in release note now. Can I update the
news.xml
even after v5.8 ?
That would only affect our web page and future releases. Unfortunately,
we
On Wed, Oct 09, 2019 at 10:44:25PM +0800, Han Han wrote:
> Hi,
> Although libvirt-5.8 is released, however some features or improvement like
> "slirp helper process" are missing in release note now. Can I update the
> news.xml
> even after v5.8 ?
Yes, that's fine. The website will see the update.
Hi,
Although libvirt-5.8 is released, however some features or improvement like
"slirp helper process" are missing in release note now. Can I update the
news.xml
even after v5.8 ?
--
Best regards,
---
Han Han
Quality Engineer
Redhat.
Email: h...@redhat.com
Phone:
On 10/8/19 6:22 PM, Cole Robinson wrote:
It is the only user. Rename it to match the local style
Signed-off-by: Cole Robinson
---
src/conf/domain_conf.c| 42 -
src/conf/domain_conf.h| 10 ---
src/libvirt_private.syms | 1 -
On 10/8/19 6:22 PM, Cole Robinson wrote:
This series does some preparation cleanup and refactoring to
simplify adding qcow2 data_file support to the apparmor driver.
More info on the qcow2 feature and libvirt work here:
https://www.redhat.com/archives/libvir-list/2019-October/msg00303.html
Cole
On 10/8/19 5:19 PM, Daniel P. Berrangé wrote:
The object locking test code is not run by any CI tests and has
bitrotted to the point where it isn't worth the effort to try to
fix it.
Signed-off-by: Daniel P. Berrangé
---
.gitignore | 3 -
configure.ac | 12 -
On 10/9/19 7:58 AM, Daniel P. Berrangé wrote:
We recently introduced flake8 to check for bogus semicolon at the end of
line in python code. It can check for sooo much more than this. In
general it is desirable to comply with as much as possible, since this
results in python code that is more
On 10/9/19 7:58 AM, Daniel P. Berrangé wrote:
The current flake8 check only looks at one item (semicolons at end of
line). This means that our code quality will continue to get worse,
violating an increasing number of checks.
Switching to a whitelist means that we freeze the badness at its
On Wed, Oct 09, 2019 at 03:16:38PM +0200, Ján Tomko wrote:
> On Wed, Oct 09, 2019 at 09:07:57AM +0200, Pavel Hrdina wrote:
> > On Tue, Oct 08, 2019 at 07:08:25PM +0200, Ján Tomko wrote:
> > > On Mon, Oct 07, 2019 at 06:14:17PM +0100, Daniel P. Berrangé wrote:
> > > > Converting from virObject to
On Wed, Oct 09, 2019 at 09:07:57AM +0200, Pavel Hrdina wrote:
On Tue, Oct 08, 2019 at 07:08:25PM +0200, Ján Tomko wrote:
On Mon, Oct 07, 2019 at 06:14:17PM +0100, Daniel P. Berrangé wrote:
> Converting from virObject to GObject is reasonably straightforward,
> as illustrated by this patch for
Simplify the list of ignored warnings now that we only have two left,
and document why we're not honouring them.
Signed-off-by: Daniel P. Berrangé
---
build-aux/syntax-check.mk | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/build-aux/syntax-check.mk
Coding style expects 1 blank line between each method and 2 blank lines
before each class.
docs/apibuild.py:171:5: E303 too many blank lines (2)
def set_header(self, header):
^
docs/apibuild.py:230:1: E302 expected 2 blank lines, found 1
class index:
^
docs/apibuild.py:175:5: E301
docs/apibuild.py:2436:65: F821 undefined name 'first_letter'
chunks.append(["chunk%s" % (chunk - 1), first_letter,
letter])
^
src/hyperv/hyperv_wmi_generator.py:415:57: F821 undefined name 'number'
There should be a single space either side of operators. Inline
comments should have two spaces before the '#'
src/hyperv/hyperv_wmi_generator.py:130:45: E261 at least two spaces before
inline comment
source += '{ "", "", 0 },\n' # null terminated
Line continuations should be 4 space indented unless a previous opening
brace required different alignment.
docs/apibuild.py:2014:24: E126 continuation line over-indented for hanging
indent
token[0], token[1]))
^
docs/apibuild.py:74:3: E121
Exception catching statements should always match on a class name, the
most specific one possible. Rather than analyse the code to look at what
the most specific one is, this just uses the base Exception class.
docs/apibuild.py:255:9: E722 do not use bare 'except'
except:
^
Python code style recommends avoiding a variable named 'l' as it is
visually similar to '1'.
docs/apibuild.py:482:13: E741 ambiguous variable name 'l'
l = len(line)
^
docs/apibuild.py:503:21: E741 ambiguous variable name 'l'
l = len(line)
The current flake8 check only looks at one item (semicolons at end of
line). This means that our code quality will continue to get worse,
violating an increasing number of checks.
Switching to a whitelist means that we freeze the badness at its
current level & can incrementally fix things up.
We
When writing regexes special regex matches like "\d" can get
misinterpreted as normal string escape sequences:
docs/apibuild.py:1359:51: W605 invalid escape sequence '\d'
value = value + re.sub("^(\d+)U$", "\\1", token[1])
We recently introduced flake8 to check for bogus semicolon at the end of
line in python code. It can check for sooo much more than this. In
general it is desirable to comply with as much as possible, since this
results in python code that is more consistent in style to that seen in
other projects.
Signed-off-by: Daniel P. Berrangé
---
docs/apibuild.py | 23 ---
1 file changed, 23 deletions(-)
diff --git a/docs/apibuild.py b/docs/apibuild.py
index 92886e1276..3f0b72d18e 100755
--- a/docs/apibuild.py
+++ b/docs/apibuild.py
@@ -553,17 +553,10 @@ class CLexer:
On Wed, Oct 09, 2019 at 02:25:09PM +0200, Peter Krempa wrote:
> On Wed, Oct 09, 2019 at 13:39:54 +0200, Christian Ehrhardt wrote:
> > Hi,
> > when discussing bug [1] triggered by [2] Daniel and I have found that
> > the change [3] which is in since v4.3 was a semantic change to the
> > behavior of
On Wed, Oct 09, 2019 at 13:39:54 +0200, Christian Ehrhardt wrote:
> Hi,
> when discussing bug [1] triggered by [2] Daniel and I have found that
> the change [3] which is in since v4.3 was a semantic change to the
> behavior of libvirt.
>
> virt-manager used and still does issue a volume XML like:
On Tue, Oct 08, 2019 at 01:46:55PM -0300, Fabiano Rosas wrote:
> This series adds support for the -machine,host-model= QEMU option for
> for pseries guests.
>
> Pseries guests used to have a node (/proc/device-tree/host-model) in
> device-tree that exposed the host's model string so that guest
>
On Tue, Oct 08, 2019 at 01:46:57PM -0300, Fabiano Rosas wrote:
> Since QEMU v4.0.0, the host's model is no longer automatically exposed
> to the guest via /proc/device-tree/host-model. There is now a machine
> option 'host-model' that allows an arbitrary string to be used as the
> host model [1].
Since QEMU v4.0.0, the host's model is no longer automatically exposed
to the guest via /proc/device-tree/host-model. There is now a machine
option 'host-model' that allows an arbitrary string to be used as the
host model [1].
This patch adds support for exposing the real host model string from
As of QEMU v4.0.0, the pseries machine has a new parameter
'host-model' which receives an arbitrary string to be exposed inside
the guest at /proc/device-tree/host-model.
Signed-off-by: Fabiano Rosas
---
src/qemu/qemu_capabilities.c| 2 ++
src/qemu/qemu_capabilities.h
This series adds support for the -machine,host-model= QEMU option for
for pseries guests.
Pseries guests used to have a node (/proc/device-tree/host-model) in
device-tree that exposed the host's model string so that guest
userspace tools could determine the host machine they were running on.
On Wed, Oct 09, 2019 at 12:37:15 +0100, Daniel Berrange wrote:
[...]
> - src/rpc/gendispatch.pl
> - src/rpc/genprotocol.pl
> - tools/wireshark/util/genxdrstub.pl
[...]
> Note that the check-spacing.py script is significantly
> slower in Python than in Perl. After researching this
> it
On Wed, Oct 9, 2019 at 12:56 PM Fabiano Fidêncio wrote:
>
> This will bring back the ability to have CentOS7, Debian9, Ubuntu16 and
> Ubuntu18 containers.
>
> The corresponding libvirt-jenkins-ci commit is b6aabedc67ca.
>
> Signed-off-by: Fabiano Fidêncio
Self-nack as Andrea submitted the very
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the group-qemu-caps.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall structure
of the file and approach is the same.
Signed-off-by:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the check-aclrules.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall structure
of the file and approach is the same.
Signed-off-by:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the augeas-gentest.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall structure
of the file and approach is the same.
The use of
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the check-aclperms.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall structure
of the file and approach is the same.
Signed-off-by:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the mock-noinline.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall structure
of the file and approach is the same.
Signed-off-by: Daniel
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the check-driverimpls.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall structure
of the file and approach is the same.
Signed-off-by:
Hi,
when discussing bug [1] triggered by [2] Daniel and I have found that
the change [3] which is in since v4.3 was a semantic change to the
behavior of libvirt.
virt-manager used and still does issue a volume XML like:
disk.qcow2
16106127360
16106127360
Up
This series is an effort to reduce the number of different
languages we use by eliminating most use of perl in favour
of python.
This aligns with fact that the likely future build system
we'll use (meson) is written in python, and that python
is much more commonly used/understood by developers
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the check-spacing.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall structure
of the file and approach is the same.
Signed-off-by: Daniel
On Wed, Oct 9, 2019 at 12:18 PM Andrea Bolognani wrote:
>
> Now that we can install Meson from pip, building libosinfo and
> friends is once again possible on these platforms.
>
> Signed-off-by: Andrea Bolognani
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the dtrace2systemtap.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall structure
of the file and approach is the same.
Signed-off-by:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the hvsupport.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall structure
of the file and approach is the same.
The new impl generates
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the check-drivername.pl tool in Python.
This was mostly a straight conversion, manually going line-by-line
to change the syntax from Perl to Python. Thus the overall structure
of the file and approach is the same.
In testing
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the check-file-access.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall structure
of the file and approach is the same.
Signed-off-by:
ping
On 17.09.2019 16:47, Nikolay Shirokovskiy wrote:
> Diff to v2[1] version:
> - add 'replug' attribute for hostdev element to allow replug semantics
> - avoid accuiring domain lock in event loop thread on udev events as
> suggested by Peter
> - nit picks after review by Daniel Henrique
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the pdwtags processing script in Python.
The original inline shell and perl code was completely
unintelligible. The new python code is a manual conversion
that attempts todo basically the same thing.
Signed-off-by: Daniel P.
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the check-symfile.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall structure
of the file and approach is the same.
Signed-off-by: Daniel
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the prohibit-duplicate-header.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall structure
of the file and approach is the same.
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the check-symsorting.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall structure
of the file and approach is the same.
Signed-off-by:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the gensystemtap.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall structure
of the file and approach is the same.
Signed-off-by: Daniel
Signed-off-by: Daniel P. Berrangé
---
Makefile.am | 1 +
{src/hyperv => scripts}/hyperv_wmi_generator.py | 0
src/hyperv/Makefile.inc.am | 5 ++---
3 files changed, 3 insertions(+), 3 deletions(-)
rename {src/hyperv =>
The use of $(AUG_GENTEST) as a dependency in the makefiles is
a problem because this was assumed to be the filename of the
script, but is in fact a full shell command line.
Split it into two variables, so it can be correctly used for
dependencies.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel P.
Signed-off-by: Daniel P. Berrangé
---
Makefile.am| 7 ---
{docs => scripts}/reformat-news.py | 0
2 files changed, 4 insertions(+), 3 deletions(-)
rename {docs => scripts}/reformat-news.py (100%)
diff --git a/Makefile.am b/Makefile.am
index e63c005db7..f131c40f62
1 - 100 of 115 matches
Mail list logo