Re: [libvirt] [PULL 1/9] IDE: deprecate ide-drive

2019-10-31 Thread Markus Armbruster
Paolo Bonzini writes: > On 31/10/19 11:58, John Snow wrote: >> It's an old compatibility shim that just delegates to ide-cd or ide-hd. >> I'd like to refactor these some day, and getting rid of the super-object >> will make that easier. >> >> Either way, we don't need this. > > Good idea. I wil

Re: [libvirt] [PATCH 0/2] Doc fix and news entry for Xen ACPI support

2019-10-31 Thread Ján Tomko
On Thu, Oct 31, 2019 at 03:58:02PM +, Jim Fehlig wrote: I was jetlagged and not thinking clearly when I pushed Marek's patches that add support for specifying ACPI firmware path in the libxl driver. I pushed them outside of my usual dev setup hence misssed Reviewed-by: tags and forgot to u

Re: [libvirt] [PULL 1/9] IDE: deprecate ide-drive

2019-10-31 Thread Paolo Bonzini
On 31/10/19 11:58, John Snow wrote: > It's an old compatibility shim that just delegates to ide-cd or ide-hd. > I'd like to refactor these some day, and getting rid of the super-object > will make that easier. > > Either way, we don't need this. Good idea. I will prepare a similar patch for scsi

Re: [libvirt] [PULL v2 0/9] Ide patches

2019-10-31 Thread Peter Maydell
On Thu, 31 Oct 2019 at 15:57, John Snow wrote: > > The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 > 14:10:32 +) > > are available in the Git repository

Re: [libvirt] [PULL v2 0/9] Ide patches

2019-10-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191031155636.18589-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [libvirt] [PULL v2 0/9] Ide patches Type: series Message-id: 20191031155636.18589-1-js...@redhat.com === TES

Re: [libvirt] Entering freeze for libvirt 5.9.0

2019-10-31 Thread Daniel Veillard
On Thu, Oct 31, 2019 at 04:02:12PM +0100, Andrea Bolognani wrote: > On Wed, 2019-10-30 at 21:58 +0100, Daniel Veillard wrote: > > On Mon, Oct 28, 2019 at 06:08:39PM +0100, Daniel Veillard wrote: > > [...] > > > Please give it a try, I will try to push RC2 on Wednesday, and based > > > on feedback r

Re: [libvirt] [PATCH v3 REBASE 2 00/12] hostdev: handle usb detach/attach on node

2019-10-31 Thread Dave Allan
On Thu, Oct 31, 2019 at 10:40:42AM +, Nikolay Shirokovskiy wrote: On 30.10.2019 23:21, Dave Allan wrote: On Tue, Oct 29, 2019 at 11:17:51AM +0300, Nikolay Shirokovskiy wrote: Diff to v2[1] version: - add 'replug' attribute for hostdev element to allow replug semantics - avoid accuiring do

Re: [libvirt] Entering freeze for libvirt 5.9.0

2019-10-31 Thread Jim Fehlig
On 10/30/19 2:58 PM, Daniel Veillard wrote: > On Mon, Oct 28, 2019 at 06:08:39PM +0100, Daniel Veillard wrote: > [...] >> Please give it a try, I will try to push RC2 on Wednesday, and based >> on feedback roll the release on Friday or during the week-end, > >Well, so far there haven't been an

[libvirt] [PATCH 1/2] docs: Fix version that introduced Xen support for ACPI firmware

2019-10-31 Thread Jim Fehlig
Xen support for specifying ACPI firmware path was introduced in the 5.9.0 dev cycle, not 5.8.0 as currently indicated by the docs. Signed-off-by: Jim Fehlig --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdo

[libvirt] [PATCH 2/2] news: Add entry for ACPI firmware support in Xen

2019-10-31 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index c8d55e357b..79255de011 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -59,6 +59,15 @@ support should be available to pSeries guests.

[libvirt] [PATCH 0/2] Doc fix and news entry for Xen ACPI support

2019-10-31 Thread Jim Fehlig
I was jetlagged and not thinking clearly when I pushed Marek's patches that add support for specifying ACPI firmware path in the libxl driver. I pushed them outside of my usual dev setup hence misssed Reviewed-by: tags and forgot to update the docs with s/5.8.0/5.9.0/. There's nothing I can do a

[libvirt] [PULL v2 9/9] hd-geo-test: Add tests for lchs override

2019-10-31 Thread John Snow
From: Sam Eiderman Add QTest tests to check the logical geometry override option. The tests in hd-geo-test are out of date - they only test IDE and do not test interesting MBRs. Creating qcow2 disks with specific size and MBR layout is currently unused - we only use a default empty MBR. Review

[libvirt] [PULL v2 8/9] bootdevice: FW_CFG interface for LCHS values

2019-10-31 Thread John Snow
From: Sam Eiderman Using fw_cfg, supply logical CHS values directly from QEMU to the BIOS. Non-standard logical geometries break under QEMU. A virtual disk which contains an operating system which depends on logical geometries (consistent values being reported from BIOS INT13 AH=08) will most l

[libvirt] [PULL v2 6/9] bootdevice: Gather LCHS from all relevant devices

2019-10-31 Thread John Snow
From: Sam Eiderman Relevant devices are: * ide-hd (and ide-cd, ide-drive) * scsi-hd (and scsi-cd, scsi-disk, scsi-block) * virtio-blk-pci We do not call del_boot_device_lchs() for ide-* since we don't need to - IDE block devices do not support unplugging. Reviewed-by: Karl Heubaum

[libvirt] [PULL v2 7/9] bootdevice: Refactor get_boot_devices_list

2019-10-31 Thread John Snow
From: Sam Eiderman Move device name construction to a separate function. We will reuse this function in the following commit to pass logical CHS parameters through fw_cfg much like we currently pass bootindex. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Reviewed-by: Philippe Mathieu-Da

[libvirt] [PULL v2 5/9] scsi: Propagate unrealize() callback to scsi-hd

2019-10-31 Thread John Snow
From: Sam Eiderman We will need to add LCHS removal logic to scsi-hd's unrealize() in the next commit. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Sam Eiderman Signed-off-by: Sam Eiderman Tested-by: Philippe Mathieu-Daudé Signed-off

[libvirt] [PULL v2 3/9] block: Support providing LCHS from user

2019-10-31 Thread John Snow
From: Sam Eiderman Add logical geometry variables to BlockConf. A user can now supply "lcyls", "lheads" & "lsecs" for any HD device that supports CHS ("cyls", "heads", "secs"). These devices include: * ide-hd * scsi-hd * virtio-blk-pci In future commits we will use the provided LCH

[libvirt] [PULL v2 4/9] bootdevice: Add interface to gather LCHS

2019-10-31 Thread John Snow
From: Sam Eiderman Add an interface to provide direct logical CHS values for boot devices. We will use this interface in the next commits. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Signed-off-by: Sam Eiderman Signed-off-by: Sam Eiderman Reviewed-by: Philippe Mathieu-Daudé Tested-by

[libvirt] [PULL v2 2/9] block: Refactor macros - fix tabbing

2019-10-31 Thread John Snow
From: Sam Eiderman Fixing tabbing in block related macros. Signed-off-by: Sam Eiderman Signed-off-by: Sam Eiderman Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: John Snow --- include/hw/block/block.h | 16 hw/ide/qde

[libvirt] [PULL v2 0/9] Ide patches

2019-10-31 Thread John Snow
The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: Merge remote-tracking branch 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 14:10:32 +) are available in the Git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-reques

[libvirt] [PULL v2 1/9] IDE: deprecate ide-drive

2019-10-31 Thread John Snow
It's an old compatibility shim that just delegates to ide-cd or ide-hd. I'd like to refactor these some day, and getting rid of the super-object will make that easier. Either way, we don't need this. Signed-off-by: John Snow Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster ACKed-by: Pet

Re: [libvirt] [PULL 0/9] Ide patches

2019-10-31 Thread John Snow
On 10/31/19 11:02 AM, Peter Maydell wrote: > On Thu, 31 Oct 2019 at 10:59, John Snow wrote: >> >> The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: >> >> Merge remote-tracking branch >> 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 >> 1

Re: [libvirt] [PULL 0/9] Ide patches

2019-10-31 Thread Peter Maydell
On Thu, 31 Oct 2019 at 10:59, John Snow wrote: > > The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 > 14:10:32 +) > > are available in the Git repository

Re: [libvirt] Entering freeze for libvirt 5.9.0

2019-10-31 Thread Andrea Bolognani
On Wed, 2019-10-30 at 21:58 +0100, Daniel Veillard wrote: > On Mon, Oct 28, 2019 at 06:08:39PM +0100, Daniel Veillard wrote: > [...] > > Please give it a try, I will try to push RC2 on Wednesday, and based > > on feedback roll the release on Friday or during the week-end, > > Well, so far there

Re: [libvirt] [PULL 0/9] Ide patches

2019-10-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191031105904.12194-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [libvirt] [PULL 0/9] Ide patches Type: series Message-id: 20191031105904.12194-1-js...@redhat.com === TEST S

[libvirt] [PULL 9/9] hd-geo-test: Add tests for lchs override

2019-10-31 Thread John Snow
From: Sam Eiderman Add QTest tests to check the logical geometry override option. The tests in hd-geo-test are out of date - they only test IDE and do not test interesting MBRs. Creating qcow2 disks with specific size and MBR layout is currently unused - we only use a default empty MBR. Review

[libvirt] [PULL 8/9] bootdevice: FW_CFG interface for LCHS values

2019-10-31 Thread John Snow
From: Sam Eiderman Using fw_cfg, supply logical CHS values directly from QEMU to the BIOS. Non-standard logical geometries break under QEMU. A virtual disk which contains an operating system which depends on logical geometries (consistent values being reported from BIOS INT13 AH=08) will most l

[libvirt] [PULL 7/9] bootdevice: Refactor get_boot_devices_list

2019-10-31 Thread John Snow
From: Sam Eiderman Move device name construction to a separate function. We will reuse this function in the following commit to pass logical CHS parameters through fw_cfg much like we currently pass bootindex. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Reviewed-by: Philippe Mathieu-Da

[libvirt] [PULL 5/9] scsi: Propagate unrealize() callback to scsi-hd

2019-10-31 Thread John Snow
From: Sam Eiderman We will need to add LCHS removal logic to scsi-hd's unrealize() in the next commit. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Sam Eiderman Signed-off-by: Sam Eiderman Tested-by: Philippe Mathieu-Daudé Signed-off

[libvirt] [PULL 6/9] bootdevice: Gather LCHS from all relevant devices

2019-10-31 Thread John Snow
From: Sam Eiderman Relevant devices are: * ide-hd (and ide-cd, ide-drive) * scsi-hd (and scsi-cd, scsi-disk, scsi-block) * virtio-blk-pci We do not call del_boot_device_lchs() for ide-* since we don't need to - IDE block devices do not support unplugging. Reviewed-by: Karl Heubaum

[libvirt] [PULL 4/9] bootdevice: Add interface to gather LCHS

2019-10-31 Thread John Snow
From: Sam Eiderman Add an interface to provide direct logical CHS values for boot devices. We will use this interface in the next commits. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Signed-off-by: Sam Eiderman Signed-off-by: Sam Eiderman Reviewed-by: Philippe Mathieu-Daudé Tested-by

[libvirt] [PULL 3/9] block: Support providing LCHS from user

2019-10-31 Thread John Snow
From: Sam Eiderman Add logical geometry variables to BlockConf. A user can now supply "lcyls", "lheads" & "lsecs" for any HD device that supports CHS ("cyls", "heads", "secs"). These devices include: * ide-hd * scsi-hd * virtio-blk-pci In future commits we will use the provided LCH

[libvirt] [PULL 2/9] block: Refactor macros - fix tabbing

2019-10-31 Thread John Snow
From: Sam Eiderman Fixing tabbing in block related macros. Signed-off-by: Sam Eiderman Signed-off-by: Sam Eiderman Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: John Snow --- include/hw/block/block.h | 16 hw/ide/qde

[libvirt] [PULL 1/9] IDE: deprecate ide-drive

2019-10-31 Thread John Snow
It's an old compatibility shim that just delegates to ide-cd or ide-hd. I'd like to refactor these some day, and getting rid of the super-object will make that easier. Either way, we don't need this. Signed-off-by: John Snow Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster ACKed-by: Pet

[libvirt] [PULL 0/9] Ide patches

2019-10-31 Thread John Snow
The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: Merge remote-tracking branch 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 14:10:32 +) are available in the Git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-reques

Re: [libvirt] [PATCH v3 REBASE 2 00/12] hostdev: handle usb detach/attach on node

2019-10-31 Thread Nikolay Shirokovskiy
On 30.10.2019 23:21, Dave Allan wrote: > On Tue, Oct 29, 2019 at 11:17:51AM +0300, Nikolay Shirokovskiy wrote: >> Diff to v2[1] version: >> - add 'replug' attribute for hostdev element to allow replug semantics >> - avoid accuiring domain lock in event loop thread on udev events as >>  suggested