We don't use strsep any more.
Signed-off-by: Peter Krempa
Reviewed-by: Ján Tomko
Reviewed-by: Pavel Hrdina
---
bootstrap.conf | 1 -
1 file changed, 1 deletion(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index f13fcae11a..e519c69d30 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@
From: Pavel Hrdina
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
bootstrap.conf | 1 -
1 file changed, 1 deletion(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index c93daf5a8d..4ba3ebfdd5 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -72,7 +72,6 @@ setenv
setsockopt
On Tue, Nov 19, 2019 at 15:22:58 +0100, Pavel Hrdina wrote:
> Last usage was removed by commit
> <41f6198e231285cc813f8c0687c8ec5c9488> and commit
> <0f4d31720430b4e3735064cc0d8f88a1a438e154> forgot to drop include.
>
> Signed-off-by: Pavel Hrdina
> ---
> bootstrap.conf | 1 -
On Tue, Nov 19, 2019 at 14:15:12 +0100, Michal Privoznik wrote:
> If user starts a blockcommit without --pivot or a blockcopy also
> without --pivot then we modify access for qemu on both images and
> leave it like that until pivot is executed. So far so good.
> Problem is, if user instead of
On Wed, Nov 20, 2019 at 11:44:52 +0100, Pavel Mores wrote:
> Since the blockcommit operation is asynchronous, this has conceptually two
> parts. First, we have to propagate the flag from qemuDomainBlockCommit()
> (which was just ignoring it until now) to qemuBlockJobDiskNewCommit(). Then
> it
On Wed, Nov 20, 2019 at 11:44:55 +0100, Pavel Mores wrote:
> The new element was only added to the active commit test, the non-active
> commit test doesn't have the new element so as to test its absence.
>
> Signed-off-by: Pavel Mores
> ---
> tests/qemustatusxml2xmldata/blockjob-blockdev-in.xml
On Wed, Nov 20, 2019 at 11:44:53 +0100, Pavel Mores wrote:
> When blockcommit finishes successfully, one of the
> qemuBlockJobProcessEventCompletedCommit() and
> qemuBlockJobProcessEventCompletedActiveCommit() event handlers is called.
> This is where the delete flag (stored in
On Wed, 20 Nov 2019 at 09:10, Thomas Huth wrote:
>
> We are going to remove the bitrotten bluetooth backend, so we can
> not use it in the n800 and n810 machines anymore. Replace the chardev
> here with a "null" chardev and stop including the "hw/bt.h" header.
>
> I am not aware of a full working
When blockcommit finishes successfully, one of the
qemuBlockJobProcessEventCompletedCommit() and
qemuBlockJobProcessEventCompletedActiveCommit() event handlers is called.
This is where the delete flag (stored in qemuBlockJobCommitData since the
previous commit) can actually be used to delete the
Since blockcommit is asynchronous, libvirtd can be restarted while the
operation runs. To ensure the information necessary to finish up the job
is not lost, serialisation to and deserialisation from the status XML is
added.
Signed-off-by: Pavel Mores
---
src/qemu/qemu_domain.c | 4
1 file
Since the blockcommit operation is asynchronous, this has conceptually two
parts. First, we have to propagate the flag from qemuDomainBlockCommit()
(which was just ignoring it until now) to qemuBlockJobDiskNewCommit(). Then
it can be stored in the qemuBlockJobCommitData structure which holds
v2 fixes a mess-up in handling of strerror_r() return value.
Pavel Mores (4):
qemu: block: propagate the delete flag to where it can actually be
used
qemu: block: use the delete flag to delete snapshot images if
requested
qemu: block: store the delete flag in libvirtd's status XML
The new element was only added to the active commit test, the non-active
commit test doesn't have the new element so as to test its absence.
Signed-off-by: Pavel Mores
---
tests/qemustatusxml2xmldata/blockjob-blockdev-in.xml | 1 +
1 file changed, 1 insertion(+)
diff --git
On Wed, Nov 20, 2019 at 10:37:14AM +, Daniel P. Berrangé wrote:
> On Wed, Nov 20, 2019 at 11:34:24AM +0100, Michal Privoznik wrote:
> > On 11/20/19 11:05 AM, Daniel P. Berrangé wrote:
> > > On Wed, Nov 20, 2019 at 10:51:47AM +0100, Michal Privoznik wrote:
> > > > Another weird bug appeared
On Wed, Nov 20, 2019 at 11:34:24AM +0100, Michal Privoznik wrote:
> On 11/20/19 11:05 AM, Daniel P. Berrangé wrote:
> > On Wed, Nov 20, 2019 at 10:51:47AM +0100, Michal Privoznik wrote:
> > > Another weird bug appeared concerning qemu namespaces. Basically
> > > the problem is as follows:
> > >
>
On 11/20/19 11:05 AM, Daniel P. Berrangé wrote:
On Wed, Nov 20, 2019 at 10:51:47AM +0100, Michal Privoznik wrote:
Another weird bug appeared concerning qemu namespaces. Basically
the problem is as follows:
1) Issue an API that causes libvirt to create a node in domain's
namespace, say
On Wed, Nov 20, 2019 at 10:55:25AM +0100, Pavel Mores wrote:
> When blockcommit finishes successfully, one of the
> qemuBlockJobProcessEventCompletedCommit() and
> qemuBlockJobProcessEventCompletedActiveCommit() event handlers is called.
> This is where the delete flag (stored in
On Wed, Nov 20, 2019 at 10:51:47AM +0100, Michal Privoznik wrote:
> Another weird bug appeared concerning qemu namespaces. Basically
> the problem is as follows:
>
> 1) Issue an API that causes libvirt to create a node in domain's
>namespace, say /dev/sda with 8:0 as major:minor (the API can
On 20/11/19 10:10, Thomas Huth wrote:
> This patch series removes the bitrotten bluetooth subsystem. See
> the patch description of the third patch for the rationale.
Acked-by: Paolo Bonzini
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Since blockcommit is asynchronous, libvirtd can be restarted while the
operation runs. To ensure the information necessary to finish up the job
is not lost, serialisation to and deserialisation from the status XML is
added.
Signed-off-by: Pavel Mores
---
src/qemu/qemu_domain.c | 4
1 file
Since the blockcommit operation is asynchronous, this has conceptually two
parts. First, we have to propagate the flag from qemuDomainBlockCommit()
(which was just ignoring it until now) to qemuBlockJobDiskNewCommit(). Then
it can be stored in the qemuBlockJobCommitData structure which holds
Adds handling of the VIR_DOMAIN_BLOCK_COMMIT_DELETE flag to the qemu driver
which previously just ignored it. This should fix a problem with the virsh
blockcommit command where --delete did nothing.
https://bugzilla.redhat.com/show_bug.cgi?id=1008350
Pavel Mores (4):
qemu: block: propagate
When blockcommit finishes successfully, one of the
qemuBlockJobProcessEventCompletedCommit() and
qemuBlockJobProcessEventCompletedActiveCommit() event handlers is called.
This is where the delete flag (stored in qemuBlockJobCommitData since the
previous commit) can actually be used to delete the
The new element was only added to the active commit test, the non-active
commit test doesn't have the new element so as to test its absence.
Signed-off-by: Pavel Mores
---
tests/qemustatusxml2xmldata/blockjob-blockdev-in.xml | 1 +
1 file changed, 1 insertion(+)
diff --git
Another weird bug appeared concerning qemu namespaces. Basically
the problem is as follows:
1) Issue an API that causes libvirt to create a node in domain's
namespace, say /dev/sda with 8:0 as major:minor (the API can
be attach-disk for instance). Or simply create the node from
a console
On Wed, Nov 20, 2019 at 10:10:13AM +0100, Thomas Huth wrote:
It's been deprecated since QEMU v3.1. We've explicitly asked in the
deprecation message that people should speak up on qemu-devel in case
they are still actively using the bluetooth part of QEMU, but nobody
ever replied that they are
On Wed, Nov 20, 2019 at 10:10:12AM +0100, Thomas Huth wrote:
We are going to remove the bluetooth backend, so the USB bluetooth
dongle can not work anymore. It's a completely optional device, no
board depends on it, so let's simply remove it now.
Signed-off-by: Thomas Huth
---
hw/usb/Kconfig
We are going to remove the bluetooth backend, so the USB bluetooth
dongle can not work anymore. It's a completely optional device, no
board depends on it, so let's simply remove it now.
Signed-off-by: Thomas Huth
---
hw/usb/Kconfig | 5 -
hw/usb/Makefile.objs | 1 -
On Mon, Nov 11, 2019 at 02:38:15PM +, Daniel P. Berrangé wrote:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the check-aclrules.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall
This patch series removes the bitrotten bluetooth subsystem. See
the patch description of the third patch for the rationale.
Thomas Huth (4):
hw/arm/nseries: Replace the bluetooth chardev with a "null" chardev
hw/usb: Remove the USB bluetooth dongle device
Remove the core bluetooth code
Since the bluetooth code has been removed, we don't need to test
with this library anymore.
Signed-off-by: Thomas Huth
---
.gitlab-ci.yml | 2 +-
tests/docker/dockerfiles/fedora.docker | 1 -
tests/docker/dockerfiles/ubuntu.docker | 1 -
We are going to remove the bitrotten bluetooth backend, so we can
not use it in the n800 and n810 machines anymore. Replace the chardev
here with a "null" chardev and stop including the "hw/bt.h" header.
I am not aware of a full working N8x0 environment that can be used to
test these machines,
On Mon, Nov 04, 2019 at 10:06:40AM +0100, Stefan Hajnoczi wrote:
On Fri, Nov 1, 2019 at 1:18 PM Ján Tomko wrote:
+if (qemuSecuritySetDaemonSocketLabel(driver->securityManager, vm->def) < 0)
+goto cleanup;
+fd = qemuOpenChrChardevUNIXSocket(chrdev);
+if (fd < 0)
+
On Mon, Nov 04, 2019 at 09:56:28AM +0100, Stefan Hajnoczi wrote:
On Fri, Nov 1, 2019 at 1:15 PM Ján Tomko wrote:
Introduce a new 'virtio-fs' driver type for filesystem.
What happens with the target dir?
For virtio-fs, it is used the same way as with 9pfs - it is passed as
the
On Wed, Nov 20, 2019 at 07:58:04AM +0100, Fabiano Fidêncio wrote:
On Tue, Nov 19, 2019 at 9:00 PM Jonathon Jongsma wrote:
Signed-off-by: Jonathon Jongsma
---
src/libvirt-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
On Wed, 2019-11-20 at 07:56 +0100, Fabiano Fidêncio wrote:
> On Wed, Nov 20, 2019 at 12:01 AM Jim Fehlig wrote:
> > On 11/19/19 3:32 AM, Andrea Bolognani wrote:
> > > As for os_version, if you look at all existing entries we use the
> > > major version number only: eg. we have CentOS7 instead of
101 - 136 of 136 matches
Mail list logo
