On Thu, Dec 12, 2019 at 11:48:25AM +0800, Jason Wang wrote:
>
> On 2019/12/6 下午8:49, Yan Zhao wrote:
> > On Fri, Dec 06, 2019 at 05:40:02PM +0800, Jason Wang wrote:
> >> On 2019/12/6 下午4:22, Yan Zhao wrote:
> >>> On Thu, Dec 05, 2019 at 09:05:54PM +0800, Jason Wang wrote:
> On 2019/12/5
On 2019/12/7 上午1:42, Alex Williamson wrote:
On Fri, 6 Dec 2019 17:40:02 +0800
Jason Wang wrote:
On 2019/12/6 下午4:22, Yan Zhao wrote:
On Thu, Dec 05, 2019 at 09:05:54PM +0800, Jason Wang wrote:
On 2019/12/5 下午4:51, Yan Zhao wrote:
On Thu, Dec 05, 2019 at 02:33:19PM +0800, Jason Wang wrote:
On 2019/12/6 下午8:49, Yan Zhao wrote:
On Fri, Dec 06, 2019 at 05:40:02PM +0800, Jason Wang wrote:
On 2019/12/6 下午4:22, Yan Zhao wrote:
On Thu, Dec 05, 2019 at 09:05:54PM +0800, Jason Wang wrote:
On 2019/12/5 下午4:51, Yan Zhao wrote:
On Thu, Dec 05, 2019 at 02:33:19PM +0800, Jason Wang wrote:
On Thu, Dec 12, 2019 at 11:07:42AM +0800, Alex Williamson wrote:
> On Wed, 11 Dec 2019 21:02:40 -0500
> Yan Zhao wrote:
>
> > On Thu, Dec 12, 2019 at 02:56:55AM +0800, Alex Williamson wrote:
> > > On Wed, 11 Dec 2019 01:25:55 -0500
> > > Yan Zhao wrote:
> > >
> > > > On Wed, Dec 11, 2019 at
On Wed, 11 Dec 2019 21:02:40 -0500
Yan Zhao wrote:
> On Thu, Dec 12, 2019 at 02:56:55AM +0800, Alex Williamson wrote:
> > On Wed, 11 Dec 2019 01:25:55 -0500
> > Yan Zhao wrote:
> >
> > > On Wed, Dec 11, 2019 at 12:38:05AM +0800, Alex Williamson wrote:
> > > > On Tue, 10 Dec 2019 02:44:44
Add Hygon Dhyana CPU data test case related files.
Signed-off-by: Yingle Hou
---
tests/cputest.c|1 +
...86_64-cpuid-Hygon-C86-7185-32-core-disabled.xml |7 +
...x86_64-cpuid-Hygon-C86-7185-32-core-enabled.xml |9 +
Add CPU model Dhyana to QEMU 4.1.0 and QEMU 4.2.0 in tests/domaincapstest/.
Signed-off-by: Yingle Hou
---
tests/domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 +
tests/domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 1 +
tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 1 +
The x86ModelParseSignatures function makes an assumption that CPU signature
model equals 0 as an invalid case. While in Hygon processor definition, A1
version (model 0, stepping 1) is mass production version, to support Hygon
Dhyana A1 version, we have removed CPU signature model zero checking
As a Joint Venture between AMD and Haiguang Information Technology Co., Ltd.,
Hygon aims to provide x86 server processor in China market. The first
generation processor Dhyana (family 18h) shares similar architecture with
AMD family 17h.
As Dhyana support in QEMU already have been merged in
Add Hygon Dhyana CPU model to the processor model.
Signed-off-by: Yingle Hou
---
src/cpu_map/Makefile.inc.am | 1 +
src/cpu_map/index.xml | 3 ++
src/cpu_map/x86_Dhyana.xml | 70 +
src/cpu_map/x86_vendors.xml | 1 +
4 files changed, 75
On Thu, Dec 12, 2019 at 02:56:55AM +0800, Alex Williamson wrote:
> On Wed, 11 Dec 2019 01:25:55 -0500
> Yan Zhao wrote:
>
> > On Wed, Dec 11, 2019 at 12:38:05AM +0800, Alex Williamson wrote:
> > > On Tue, 10 Dec 2019 02:44:44 -0500
> > > Yan Zhao wrote:
> > >
> > > > On Tue, Dec 10, 2019 at
On 11/14/19 12:44 PM, Marc Hartmayer wrote:
> The commit 'close callback: move it to driver' (88f09b75eb99) moved
> the responsibility for the close callback to the driver. But if the
> driver doesn't support the connectRegisterCloseCallback API this
> function does nothing, even no unsupported
On 11/14/19 12:44 PM, Marc Hartmayer wrote:
> To free the structs and save the error, it is not necessary to hold
> @priv->lock,
> therefore move these parts after the mutex unlock.
>
> Signed-off-by: Marc Hartmayer
> ---
> src/remote/remote_daemon_dispatch.c | 32 ++---
On 11/26/19 8:33 AM, Daniel Henrique Barboza wrote:
> changes from previous version [1]:
> - do not overload address type='none'. A new address type called
> 'unassigned' is introduced;
> - there is no unassigned' flag being created in virDomainHostdevDef.
> The logic added by new address type is
On 12/11/19 12:59 PM, Daniel P. Berrangé wrote:
On Wed, Dec 11, 2019 at 12:52:20PM -0600, Eric Blake wrote:
On 12/11/19 12:45 PM, Daniel P. Berrangé wrote:
This avoids leaving a zero length or partially generated output
file on errors.
Signed-off-by: Daniel P. Berrangé
---
On Wed, Dec 11, 2019 at 12:52:20PM -0600, Eric Blake wrote:
> On 12/11/19 12:45 PM, Daniel P. Berrangé wrote:
> > This avoids leaving a zero length or partially generated output
> > file on errors.
> >
> > Signed-off-by: Daniel P. Berrangé
> > ---
> > docs/Makefile.am | 10 +-
> > 1
On Wed, 11 Dec 2019 01:25:55 -0500
Yan Zhao wrote:
> On Wed, Dec 11, 2019 at 12:38:05AM +0800, Alex Williamson wrote:
> > On Tue, 10 Dec 2019 02:44:44 -0500
> > Yan Zhao wrote:
> >
> > > On Tue, Dec 10, 2019 at 05:16:08AM +0800, Alex Williamson wrote:
> > > > On Mon, 9 Dec 2019 01:22:12
On 12/11/19 12:45 PM, Daniel P. Berrangé wrote:
This avoids leaving a zero length or partially generated output
file on errors.
Signed-off-by: Daniel P. Berrangé
---
docs/Makefile.am | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/docs/Makefile.am
Some versions of the rst2man convertor are buggy failing to
cope with syntax highlighting in code blocks.
This isn't something we really need for the man page code
blocks, so we can just delete the highlighting directive.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/libvirtd.rst
This avoids leaving a zero length or partially generated output
file on errors.
Signed-off-by: Daniel P. Berrangé
---
docs/Makefile.am | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/docs/Makefile.am b/docs/Makefile.am
index eb8de80b9c..9a1f7a6117 100644
---
Any static list of images is destined to become outdated eventually,
so let's start generating it dynamically instead.
Unfortunately there doesn't seem to be a straightforward way to get
Podman/Docker to list all repositories under quay.io/libvirt, so we
have to resort to searching and filtering
On 12/10/19 10:08 AM, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Support by usage name can be considered separately (with a 'usage'
> attribute?).
>
> Cc: Stefan Berger
> Signed-off-by: Marc-André Lureau
> ---
> docs/formatsecret.html.in | 4 ++--
> 1 file changed, 2
The corresponding libvirt-jenkins-ci commit is f289e64a5fd9.
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index b47f54553e..44ff5e9898 100644
--- a/.travis.yml
+++ b/.travis.yml
The use of the parseOpaque parameter was mistakenly removed in
commit 4a4132b4625778cf80acb9c92d06351b44468ac3
Author: Daniel P. Berrangé
Date: Tue Dec 3 10:49:49 2019 +
conf: don't use passed in caps in post parse method
causing the method to re-fetch qemuCaps that were
Don't check os type / virt type / arch in the post-parse callback
because we can't assume qemuCaps is non-NULL at this point. It
also conceptually belongs to the validation callback.
Signed-off-by: Daniel P. Berrangé
---
src/qemu/qemu_domain.c | 42
Daniel P. Berrangé (3):
tests: add a domain ID to live status XML doc
qemu: check os type / virt type / arch in validate callback
qemu: honour parseOpaque instead of refetching caps
src/qemu/qemu_domain.c| 54 ++-
The status XML represents a running VM, so we should always have an
ID present for the domain.
Signed-off-by: Daniel P. Berrangé
---
tests/qemustatusxml2xmldata/vcpus-multi-in.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemustatusxml2xmldata/vcpus-multi-in.xml
On Wed, Dec 11, 2019 at 10:25:32AM -0500, Cole Robinson wrote:
> On 12/4/19 5:11 AM, Daniel P. Berrangé wrote:
> > When QEMU uid/gid is set to non-root this is pointless as if we just
> > used a regular setuid/setgid call, the process will have all its
> > capabilities cleared anyway by the
On 12/4/19 5:11 AM, Daniel P. Berrangé wrote:
> When QEMU uid/gid is set to non-root this is pointless as if we just
> used a regular setuid/setgid call, the process will have all its
> capabilities cleared anyway by the kernel.
>
> When QEMU uid/gid is set to root, this is almost (always?) never
On Fri, 2019-12-06 at 18:53 +, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> guests/vars/projects/libvirt.yml | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
On Fri, 2019-12-06 at 18:53 +, Daniel P. Berrangé wrote:
> Add a mapping exclusively for CentOS 7 to pull in the libprlsdk package,
> since other distros don't have it available at this time.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> guests/vars/mappings.yml | 4
> 1 file changed,
On Fri, 2019-12-06 at 18:53 +, Daniel P. Berrangé wrote:
> +++ b/guests/lcitool
> +def _get_openvz_repo(self):
> +basedir = os.path.dirname(sys.argv[0])
> +repofile = os.path.join(basedir, "playbooks", "update", "templates",
> "openvz.repo.j2")
This should be
base =
There's some pre-existing libvirt design questions I would like some
feedback on, and one new one
* `virsh blockresize` doesn't prevent shrink by default, couple users
have blown their foot off and there's attempts at patches.
The corresponding libvirt-jenkins-ci commit is f289e64a5fd9.
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
...ntu-16.zip => buildenv-libosinfo-ubuntu-1604.zip | Bin
...ntu-18.zip => buildenv-libosinfo-ubuntu-1804.zip | Bin
...buntu-16.zip => buildenv-libvirt-ubuntu-1604.zip | Bin
The RPM tags must not be indented.
Fixes: 6b8ab20f9b9b1a9383bd2cb9a075f57beb196c1c
Signed-off-by: Ján Tomko
---
libvirt.spec.in | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Pushed as a build breaker fix.
diff --git a/libvirt.spec.in b/libvirt.spec.in
index
Remove the usage where sanity of the length argument is verified
by other conditions not matching the previous patches.
Signed-off-by: Ján Tomko
---
src/libxl/xen_common.c | 18 --
tools/vsh.c| 5 ++---
2 files changed, 10 insertions(+), 13 deletions(-)
diff --git
Signed-off-by: Ján Tomko
Reviewed-by: Daniel Henrique Barboza
---
src/bhyve/bhyve_parse_command.c | 6 ++
src/libxl/xen_common.c | 8 +++-
src/libxl/xen_xm.c | 3 +--
src/lxc/lxc_driver.c| 3 +--
src/qemu/qemu_driver.c | 3 +--
Replace all the uses passing a single parameter as the length.
Signed-off-by: Ján Tomko
---
src/conf/nwfilter_conf.c | 4 ++--
src/conf/nwfilter_params.c | 6 ++
src/interface/interface_backend_udev.c | 8 ++--
src/libxl/xen_common.c | 3 +--
Signed-off-by: Ján Tomko
Reviewed-by: Daniel Henrique Barboza
---
docs/hacking.html.in | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/docs/hacking.html.in b/docs/hacking.html.in
index 06deab9e90..74aba5d46b 100644
--- a/docs/hacking.html.in
+++
Signed-off-by: Ján Tomko
Reviewed-by: Daniel Henrique Barboza
---
tests/virstringtest.c | 136 --
1 file changed, 136 deletions(-)
diff --git a/tests/virstringtest.c b/tests/virstringtest.c
index fc5f9bf937..1f195ab4b9 100644
--- a/tests/virstringtest.c
Signed-off-by: Ján Tomko
Reviewed-by: Daniel Henrique Barboza
---
src/libvirt_private.syms | 2 --
src/util/virstring.c | 49
src/util/virstring.h | 69
3 files changed, 120 deletions(-)
diff --git
We abort on allocation errors now so there is no need to
have a function for it.
Replace the only use by return -1, chosen by fair dice roll.
Signed-off-by: Ján Tomko
---
tools/vsh.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/tools/vsh.c b/tools/vsh.c
Ján Tomko (8):
Remove VIR_STRDUP usage that sneaked in in the meantime
vsh: remove vshErrorOOM
Remove VIR_STRNDUP usage with checked pointers
Remove all the uses that use subtraction in their length argument
Remove the rest of VIR_STRNDUP
tests: delete tests for VIR_STR(N)DUP
util:
My hesitation to remove VIR_STRDUP without VIR_STRNDUP resulted
in these being able to sneak in.
Signed-off-by: Ján Tomko
---
src/conf/backup_conf.c | 4 +---
src/qemu/qemu_monitor_json.c | 3 +--
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/conf/backup_conf.c
On Wed, Dec 11, 2019 at 14:12:34 +0100, Ján Tomko wrote:
> The recent specfile addition broke syntax-check:
> cppi: ../libvirt.spec.in: line 338: not properly indented
> cppi: ../libvirt.spec.in: line 341: not properly indented
> cppi: ../libvirt.spec.in: line 344: not properly indented
>
>
The recent specfile addition broke syntax-check:
cppi: ../libvirt.spec.in: line 338: not properly indented
cppi: ../libvirt.spec.in: line 341: not properly indented
cppi: ../libvirt.spec.in: line 344: not properly indented
Fixes: ac063cb2e76d64a907f96bf0b6a29da4eb484ebc
Signed-off-by: Ján Tomko
On Tue, Dec 10, 2019 at 02:54:23PM +0100, Andrea Bolognani wrote:
> We've supported both Ubuntu 16.04 and Ubuntu 18.04 as build targets
> for a long time now, and we are even building on the latter on
> Travis CI, but we've never actually deployed the corresponding VMs
> in the CentOS CI
ping
On Wed, Dec 04, 2019 at 10:11:47AM +, Daniel P. Berrangé wrote:
> When QEMU uid/gid is set to non-root this is pointless as if we just
> used a regular setuid/setgid call, the process will have all its
> capabilities cleared anyway by the kernel.
>
> When QEMU uid/gid is set to root,
On Wed, Dec 11, 2019 at 1:33 PM Andrea Bolognani wrote:
>
> On Wed, 2019-12-11 at 13:26 +0100, Fabiano Fidêncio wrote:
> > And this is the fixup for this one:
> > ```
> > diff --git a/guests/lcitool b/guests/lcitool
> > index 059b789..c28c414 100755
> > --- a/guests/lcitool
> > +++
On 12/10/19 10:08 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Support by usage name can be considered separately (with a 'usage'
attribute?).
Cc: Stefan Berger
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
---
docs/formatsecret.html.in | 4 ++--
1 file
On Wed, 2019-12-11 at 13:26 +0100, Fabiano Fidêncio wrote:
> And this is the fixup for this one:
> ```
> diff --git a/guests/lcitool b/guests/lcitool
> index 059b789..c28c414 100755
> --- a/guests/lcitool
> +++ b/guests/lcitool
> @@ -749,13 +749,23 @@ class Application:
>
On Wed, 2019-12-11 at 13:25 +0100, Fabiano Fidêncio wrote:
> This is the fixup for this patch:
> ```
> diff --git a/guests/lcitool b/guests/lcitool
> index 803477e..059b789 100755
> --- a/guests/lcitool
> +++ b/guests/lcitool
> @@ -748,7 +748,7 @@ class Application:
>
On Wed, Dec 11, 2019 at 10:32 AM Andrea Bolognani wrote:
>
> On Tue, 2019-12-10 at 16:38 +0100, Fabiano Fidêncio wrote:
> > +++ b/guests/playbooks/update/tasks/base.yml
> > +- name: Enable PowerTools repository
> > + command: '{{ package_manager }} config-manager --set-enabled PowerTools
> >
On Wed, Dec 11, 2019 at 10:44 AM Fabiano Fidêncio wrote:
>
> On Wed, Dec 11, 2019 at 10:31 AM Andrea Bolognani wrote:
> >
> > On Tue, 2019-12-10 at 16:38 +0100, Fabiano Fidêncio wrote:
> > > +++ b/guests/playbooks/update/tasks/base.yml
> > > @@ -15,7 +15,6 @@
> > > state: latest
> > >
On Wed, 2019-12-11 at 11:07 +, Daniel P. Berrangé wrote:
> +++ b/m4/virt-external-programs.m4
> @@ -33,10 +33,13 @@ AC_DEFUN([LIBVIRT_CHECK_EXTERNAL_PROGRAMS], [
>then
> AC_MSG_ERROR("xsltproc is required to build libvirt")
>fi
> - AC_PATH_PROGS([RST2HTML], [rst2html rst2html.py
On Wed, 2019-12-11 at 11:00 +, Daniel P. Berrangé wrote:
> On Wed, Dec 11, 2019 at 10:09:58AM +0100, Andrea Bolognani wrote:
> > On Fri, 2019-12-06 at 17:18 +, Daniel P. Berrangé wrote:
> > > On Debian 10, pdwtags reliably segfaults when parsing the libvirt remote
> > > protocol files.
> >
Our website is written assuming HTML5 standard & doctype:
commit b1c81567c7172bc9dcd701cf46ea3f87725d62c7
Author: Daniel P. Berrangé
Date: Wed Jul 26 18:01:25 2017 +0100
docs: switch to using HTML5 doctype declaration
so we want the RST conversion to also use HTML5. Ubuntu 16.04
On Wed, Dec 11, 2019 at 10:09:58AM +0100, Andrea Bolognani wrote:
> On Fri, 2019-12-06 at 17:18 +, Daniel P. Berrangé wrote:
> > On Debian 10, pdwtags reliably segfaults when parsing the libvirt remote
> > protocol files.
>
> Have you reported this bug?
Nope, I asssumed it has already been
On Wed, Dec 11, 2019 at 10:16:28AM +0100, Andrea Bolognani wrote:
> On Fri, 2019-12-06 at 17:50 +, Daniel P. Berrangé wrote:
> > Now that we don't have to support CentOS 7's python2-docutils, we can
> > use the rst2html5 tool instead, which generates HTML5 output instead
> > of HTML4 output.
>
On Sat, Dec 07, 2019 at 04:43:36PM +0100, Fabiano Fidêncio wrote:
> Fedora 29 has reached its end of life on November 26th 2019.
>
> For more info, please, refer to the following e-mail:
> https://lists.fedoraproject.org/archives/list/devel-annou...@lists.fedoraproject.org/thread/
>
>
On Tue, Dec 10, 2019 at 08:25:25PM -0500, Cole Robinson wrote:
> On 12/6/19 9:50 AM, Daniel P. Berrangé wrote:
> > As part of the goal to eliminate Perl from libvirt, this gets rid of the
> > use of POD format for man pages. There's nothing especially bad about
> > POD as a markup language
On Sat, Dec 07, 2019 at 04:43:37PM +0100, Fabiano Fidêncio wrote:
> librbd1-devel and librados2-devel have their package name changed to
> librbd-devel and librados-devel on all the supported Fedora versions and
> CentOS / RHEL 8.
>
> For more info about this change, please, refer to the
We have Python 3 on CentOS 7 now, so the existing comment is no
longer accurate.
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
guests/playbooks/build/projects/virt-manager.yml | 4 +---
jenkins/projects/virt-manager.yaml | 4 +---
2 files changed, 2 insertions(+), 6
On Wed, Dec 11, 2019 at 10:31 AM Andrea Bolognani wrote:
>
> On Tue, 2019-12-10 at 16:38 +0100, Fabiano Fidêncio wrote:
> > +++ b/guests/playbooks/update/tasks/base.yml
> > @@ -15,7 +15,6 @@
> > state: latest
> >when:
> > - os_name == 'CentOS'
> > -- os_version == '7'
>
> Welp,
On 12/10/19 11:36 AM, Pavel Mores wrote:
This commit aims to fix
https://bugzilla.redhat.com/show_bug.cgi?id=1610207
The cause was apparently incorrect handling of jobs in snapshot revert code
which allowed a thread executing snapshot delete to begin job while
snapshot revert was still
On Tue, 2019-12-10 at 16:38 +0100, Fabiano Fidêncio wrote:
> +++ b/guests/playbooks/update/tasks/base.yml
> @@ -15,7 +15,6 @@
> state: latest
>when:
> - os_name == 'CentOS'
> -- os_version == '7'
Welp, I just realized you need to apply the same change to the
_action_dockerfile()
On Tue, 2019-12-10 at 16:38 +0100, Fabiano Fidêncio wrote:
> +++ b/guests/playbooks/update/tasks/base.yml
> +- name: Enable PowerTools repository
> + command: '{{ package_manager }} config-manager --set-enabled PowerTools -y'
> + args:
> +warn: no
> + when:
> +- os_name == 'CentOS'
> +
On Fri, 2019-12-06 at 17:50 +, Daniel P. Berrangé wrote:
> Now that we don't have to support CentOS 7's python2-docutils, we can
> use the rst2html5 tool instead, which generates HTML5 output instead
> of HTML4 output.
Ubuntu 16.04 still has rst2html only, see
On Fri, 2019-12-06 at 17:18 +, Daniel P. Berrangé wrote:
> On Debian 10, pdwtags reliably segfaults when parsing the libvirt remote
> protocol files.
Have you reported this bug?
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@redhat.com
On Sat, Dec 7, 2019 at 4:43 PM Fabiano Fidêncio wrote:
>
> Fedora 29 has reached its EOL on November 26th 2019;
> librbd1-devel has been replaced by librbd-devel;
> librados2-devel has been replaced by librados;
>
> Fabiano Fidêncio (2):
> spec: Update Fedora minimum supported version
> spec:
On Wed, Dec 11, 2019 at 08:34:38AM +0100, Peter Krempa wrote:
> On Tue, Dec 10, 2019 at 17:25:41 +0100, Pavel Mores wrote:
> > With all plumbing in place, we can now enable the new functionality.
> >
> > Signed-off-by: Pavel Mores
> > ---
> > src/qemu/qemu_driver.c | 12 ++--
> > 1 file
71 matches
Mail list logo
