Re: [libvirt] [PATCH] cpu: add CLZERO CPUID support for AMD platforms

> On Dec 16, 2019, at 5:35 PM, Jiri Denemark wrote: > > On Tue, Dec 03, 2019 at 03:09:12 -0800, Ani Sinha wrote: >> Qemu commit e900135dcfb67 ("i386: Add CPUID bit for CLZERO and XSAVEERPTR") >> adds support for CLZERO CPUID bit. >> This commit extends support for this CPUID bit into libvirt.

Re: [libvirt] [PATCH 03/42] rpc: Use g_autofree on virNetClientNewLibSSH2()

On Fri, Dec 20, 2019 at 12:30 AM Daniel Henrique Barboza wrote: > > > > On 12/19/19 7:17 PM, Fabiano Fidêncio wrote: > > On Thu, Dec 19, 2019 at 8:00 PM Daniel Henrique Barboza > > wrote: > >> > >> > >> > >> On 12/19/19 7:04 AM, Fabiano Fidêncio wrote: > >>> Signed-off-by: Fabiano Fidêncio >

Re: [libvirt] [PATCH 03/42] rpc: Use g_autofree on virNetClientNewLibSSH2()

On 12/19/19 7:17 PM, Fabiano Fidêncio wrote: On Thu, Dec 19, 2019 at 8:00 PM Daniel Henrique Barboza wrote: On 12/19/19 7:04 AM, Fabiano Fidêncio wrote: Signed-off-by: Fabiano Fidêncio --- src/rpc/virnetclient.c | 18 ++ 1 file changed, 6 insertions(+), 12

Re: [libvirt] [PATCH 16/42] rpc: Don't check the output of virGetUserConfigDirectory()

On Thu, Dec 19, 2019 at 8:23 PM Ján Tomko wrote: > > On Thu, Dec 19, 2019 at 11:04:21AM +0100, Fabiano Fidêncio wrote: > >virGetUserConfigDirectory() *never* *ever* returns NULL, making the > >checks for it completely unnecessary. > > > >Signed-off-by: Fabiano Fidêncio > >--- > >

Re: [libvirt] [PATCH 03/42] rpc: Use g_autofree on virNetClientNewLibSSH2()

On Thu, Dec 19, 2019 at 8:00 PM Daniel Henrique Barboza wrote: > > > > On 12/19/19 7:04 AM, Fabiano Fidêncio wrote: > > Signed-off-by: Fabiano Fidêncio > > --- > > src/rpc/virnetclient.c | 18 ++ > > 1 file changed, 6 insertions(+), 12 deletions(-) > > > [...] > > > if

Re: [libvirt] [PATCH 41/42] admin: Use g_autofree on getSocketPath()

On Thu, Dec 19, 2019 at 8:32 PM Ján Tomko wrote: > > On Thu, Dec 19, 2019 at 05:22:32PM +0100, Fabiano Fidêncio wrote: > >On Thu, Dec 19, 2019 at 5:14 PM Pavel Hrdina wrote: > >> > >> On Thu, Dec 19, 2019 at 11:04:46AM +0100, Fabiano Fidêncio wrote: > >> > Signed-off-by: Fabiano Fidêncio > >> >

[libvirt] [PATCH v4 1/4] qemu_process.c: use g_autofree

Change all feasible strings and scalar pointers to use g_autofree. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_process.c | 97 +++-- 1 file changed, 34 insertions(+), 63 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c

[libvirt] [PATCH v4 4/4] qemu_process.c: remove 'cleanup' label from qemuProcessCreatePretendCmd()

The 'cleanup' flag is doing no cleaup in this function. We can remove it and return NULL on error or qemuBuildCommandLine(). Signed-off-by: Daniel Henrique Barboza --- As mentioned in the cover, sending this one in its own patch simply because it is not related to the cleanup made in this

[libvirt] [PATCH v4 3/4] qemu_process.c: remove cleanup labels after g_auto*() changes

The g_auto*() changes made by the previous patches made a lot of 'cleanup' labels obsolete. Let's remove them. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_process.c | 182 1 file changed, 70 insertions(+), 112 deletions(-) diff --git

[libvirt] [PATCH v4 0/4] qemu_process: Glib sponsored cleanup

This series got buried a few months ago. Let's go onward unto the 20s with no one left behind. changes from version 3 [1]: - rebased to master at commit 330b556829 - removed former patch 4. The 'g_strdup_printf' change was made along the road - new patch 4: I am sending this one in separate to

[libvirt] [PATCH v4 2/4] qemu_process.c: use g_autoptr()

Change all feasible pointers to use g_autoptr(). Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_process.c | 113 +--- 1 file changed, 37 insertions(+), 76 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index

Re: [libvirt] [PATCH 41/42] admin: Use g_autofree on getSocketPath()

On Thu, Dec 19, 2019 at 05:22:32PM +0100, Fabiano Fidêncio wrote: On Thu, Dec 19, 2019 at 5:14 PM Pavel Hrdina wrote: On Thu, Dec 19, 2019 at 11:04:46AM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > src/admin/libvirt-admin.c | 3 +-- > 1 file changed, 1

Re: [libvirt] [PATCH 42/42] admin: Don't check the output of virGetUserRuntimeDirectory()

On Thu, Dec 19, 2019 at 11:04:47AM +0100, Fabiano Fidêncio wrote: virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/admin/libvirt-admin.c | 3 --- 1 file changed, 3 deletions(-) Reviewed-by: Ján

Re: [libvirt] [PATCH 40/42] interface: Don't check the output of virGetUserRuntimeDirectory()

On Thu, Dec 19, 2019 at 11:04:45AM +0100, Fabiano Fidêncio wrote: virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/interface/interface_backend_netcf.c | 3 +--

Re: [libvirt] [PATCH 39/42] locking: Don't check the output of virGetUserRuntimeDirectory()

On Thu, Dec 19, 2019 at 11:04:44AM +0100, Fabiano Fidêncio wrote: virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/locking/lock_daemon.c | 11 +++ src/locking/lock_driver_lockd.c | 3

Re: [libvirt] [PATCH 37/42] locking: Use g_autofree on virLockDaemonUnixSocketPaths()

On Thu, Dec 19, 2019 at 11:04:42AM +0100, Fabiano Fidêncio wrote: Together with the change, let's also simplify the function and get rid of the goto. Signed-off-by: Fabiano Fidêncio --- src/locking/lock_daemon.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) Reviewed-by:

Re: [libvirt] [PATCH 38/42] locking: Use g_autofree on virLockDaemonExecRestartStatePath()

On Thu, Dec 19, 2019 at 11:04:43AM +0100, Fabiano Fidêncio wrote: Together with the change, let's also simplify the function and get rid of the goto. Signed-off-by: Fabiano Fidêncio --- src/locking/lock_daemon.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) Reviewed-by:

Re: [libvirt] [PATCH 35/42] logging: Don't check the output of virGetUserRuntimeDirectory()

On Thu, Dec 19, 2019 at 11:04:40AM +0100, Fabiano Fidêncio wrote: virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/logging/log_daemon.c | 11 +++ src/logging/log_manager.c | 3 +-- 2 files

Re: [libvirt] [PATCH 36/42] locking: Use g_autofree on virLockManagerLockDaemonPath()

s/on/in/ On Thu, Dec 19, 2019 at 11:04:41AM +0100, Fabiano Fidêncio wrote: Signed-off-by: Fabiano Fidêncio --- src/locking/lock_driver_lockd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir-list

Re: [libvirt] [PATCH 34/42] logging: Use g_autofree on virLogDaemonExecRestartStatePath()

s/on/in/ On Thu, Dec 19, 2019 at 11:04:39AM +0100, Fabiano Fidêncio wrote: Together with the change, let's also simplify the function and get rid of the goto. Signed-off-by: Fabiano Fidêncio --- src/logging/log_daemon.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-)

Re: [libvirt] [PATCH 33/42] logging: Use g_autofree on virLogDaemonUnixSocketPaths()

On Thu, Dec 19, 2019 at 11:04:38AM +0100, Fabiano Fidêncio wrote: Together with the change, let's also simplify the function and get rid of the goto. Signed-off-by: Fabiano Fidêncio --- src/logging/log_daemon.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) Reviewed-by:

Re: [libvirt] [PATCH 32/42] logging: Use g_autofree on virLogManagerDaemonPath()

s/on/in/ On Thu, Dec 19, 2019 at 11:04:37AM +0100, Fabiano Fidêncio wrote: Signed-off-by: Fabiano Fidêncio --- src/logging/log_manager.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir-list mailing

Re: [libvirt] [PATCH 31/42] network: Don't check the output of virGetUserRuntimeDirectory()

On Thu, Dec 19, 2019 at 11:04:36AM +0100, Fabiano Fidêncio wrote: virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/network/bridge_driver.c | 2 -- 1 file changed, 2 deletions(-) Reviewed-by: Ján

Re: [libvirt] [PATCH 30/42] node_device: Don't check the output of virGetUserRuntimeDirectory()

On Thu, Dec 19, 2019 at 11:04:35AM +0100, Fabiano Fidêncio wrote: virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/node_device/node_device_hal.c | 3 +-- src/node_device/node_device_udev.c | 3 +--

Re: [libvirt] [PATCH 29/42] qemu: Don't check the output of virGetUserRuntimeDirectory()

On Thu, Dec 19, 2019 at 11:04:34AM +0100, Fabiano Fidêncio wrote: virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/qemu/qemu_conf.c | 2 -- 1 file changed, 2 deletions(-) Reviewed-by: Ján Tomko

Re: [libvirt] [PATCH 27/42] rpc: Don't check the output of virGetUserRuntimeDirectory()

On Thu, Dec 19, 2019 at 11:04:32AM +0100, Fabiano Fidêncio wrote: virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/rpc/virnetsocket.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [libvirt] [PATCH 28/42] remote: Don't check the output of virGetUserRuntimeDirectory()

On Thu, Dec 19, 2019 at 11:04:33AM +0100, Fabiano Fidêncio wrote: virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/remote/remote_daemon.c | 8 +--- src/remote/remote_driver.c | 3 +-- 2 files

Re: [libvirt] [PATCH 26/42] secret: Don't check the output of virGetUserRuntimeDirectory()

On Thu, Dec 19, 2019 at 11:04:31AM +0100, Fabiano Fidêncio wrote: virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/secret/secret_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [libvirt] [PATCH 23/42] locking: Don't check the output of virGetUserConfigDirectory()

On Thu, Dec 19, 2019 at 11:04:28AM +0100, Fabiano Fidêncio wrote: virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/locking/lock_daemon_config.c | 6 +- 1 file changed, 1 insertion(+), 5

Re: [libvirt] [PATCH 25/42] storage: Don't check the output of virGetUserRuntimeDirectory()

On Thu, Dec 19, 2019 at 11:04:30AM +0100, Fabiano Fidêncio wrote: virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/storage/storage_driver.c | 2 -- 1 file changed, 2 deletions(-) Reviewed-by:

Re: [libvirt] [PATCH 24/42] util: Don't check the output of virGetUserRuntimeDirectory()

On Thu, Dec 19, 2019 at 11:04:29AM +0100, Fabiano Fidêncio wrote: virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/util/virhostdev.c | 3 +-- src/util/virpidfile.c | 3 +-- 2 files changed, 2

Re: [libvirt] [PATCH 21/42] logging: Don't check the output of virGetUserConfigDirectory()

On Thu, Dec 19, 2019 at 11:04:26AM +0100, Fabiano Fidêncio wrote: virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/logging/log_daemon_config.c | 6 +- 1 file changed, 1 insertion(+), 5

Re: [libvirt] [PATCH 22/42] locking: Use g_autofree on virLockDaemonConfigFilePath()

On Thu, Dec 19, 2019 at 11:04:27AM +0100, Fabiano Fidêncio wrote: Signed-off-by: Fabiano Fidêncio --- src/locking/lock_daemon_config.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir-list mailing list

Re: [libvirt] [PATCH 20/42] logging: Use g_autofree on virLogDaemonConfigFilePath()

s/on/in/ On Thu, Dec 19, 2019 at 11:04:25AM +0100, Fabiano Fidêncio wrote: Signed-off-by: Fabiano Fidêncio --- src/logging/log_daemon_config.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir-list

Re: [libvirt] [PATCH 19/42] network: Don't check the output of virGetUserConfigDirectory()

On Thu, Dec 19, 2019 at 11:04:24AM +0100, Fabiano Fidêncio wrote: virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/network/bridge_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [libvirt] [PATCH 18/42] qemu: Don't check the output of virGetUserConfigDirectory()

On Thu, Dec 19, 2019 at 11:04:23AM +0100, Fabiano Fidêncio wrote: virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/qemu/qemu_conf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [libvirt] [PATCH 17/42] remote: Don't check the output of virGetUserConfigDirectory()

On Thu, Dec 19, 2019 at 11:04:22AM +0100, Fabiano Fidêncio wrote: virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/remote/remote_daemon_config.c | 6 +- 1 file changed, 1 insertion(+), 5

Re: [libvirt] [PATCH 16/42] rpc: Don't check the output of virGetUserConfigDirectory()

On Thu, Dec 19, 2019 at 11:04:21AM +0100, Fabiano Fidêncio wrote: virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/rpc/virnetclient.c | 11 --- 1 file changed, 4 insertions(+), 7

Re: [libvirt] [PATCH 15/42] qemu: Don't check the output of virGetUserCacheDirectory()

On Thu, Dec 19, 2019 at 11:04:20AM +0100, Fabiano Fidêncio wrote: virGetUserCacheDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/qemu/qemu_conf.c | 2 -- 1 file changed, 2 deletions(-) Reviewed-by: Ján Tomko

Re: [libvirt] [PATCH 14/42] util: Don't check the output of virGetUserCacheDirectory()

On Thu, Dec 19, 2019 at 11:04:19AM +0100, Fabiano Fidêncio wrote: virGetUserCacheDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/util/virlog.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [libvirt] [PATCH 13/42] util: Use g_autofree on virLogSetDefaultOutputToFile()

s/on/in/ On Thu, Dec 19, 2019 at 11:04:18AM +0100, Fabiano Fidêncio wrote: Signed-off-by: Fabiano Fidêncio --- src/util/virlog.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir-list mailing

Re: [libvirt] [PATCH 12/42] vbox: Don't check the output of virGetUserCacheDirectory()

On Thu, Dec 19, 2019 at 11:04:17AM +0100, Fabiano Fidêncio wrote: virGetUserCacheDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/vbox/vbox_common.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

Re: [libvirt] [PATCH 11/42] vbox: Use g_autofree on vboxDomainScreenshot()

On Thu, Dec 19, 2019 at 11:04:16AM +0100, Fabiano Fidêncio wrote: This also fixes a cacheDir's leak when g_mkstep_full() fails. Signed-off-by: Fabiano Fidêncio --- src/vbox/vbox_common.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [libvirt] [PATCH 10/42] tools: Don't check the output of virGetUserCacheDirectory()

On Thu, Dec 19, 2019 at 11:04:15AM +0100, Fabiano Fidêncio wrote: virGetUserCacheDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- tools/vsh.c | 5 - 1 file changed, 5 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [libvirt] [PATCH 03/42] rpc: Use g_autofree on virNetClientNewLibSSH2()

On 12/19/19 7:04 AM, Fabiano Fidêncio wrote: Signed-off-by: Fabiano Fidêncio --- src/rpc/virnetclient.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) [...] if (knownHostsPath) { @@ -517,12 +517,6 @@ virNetClientPtr virNetClientNewLibSSH2(const char

Re: [libvirt] [PATCH 08/42] storage: Don't check the output of virGetUserConfigDirectory()

On Thu, Dec 19, 2019 at 5:51 PM Ján Tomko wrote: > > On Thu, Dec 19, 2019 at 11:04:13AM +0100, Fabiano Fidêncio wrote: > >virGetUserConfigDirectory() *never* *ever* returns NULL, making the > >checks for it completely unnecessary. > > > >Signed-off-by: Fabiano Fidêncio > >--- > >

Re: [libvirt] [PATCH 09/42] secret: Don't check the output of virGetUserConfigDirectory()

On Thu, Dec 19, 2019 at 11:04:14AM +0100, Fabiano Fidêncio wrote: virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/secret/secret_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [libvirt] [PATCH 08/42] storage: Don't check the output of virGetUserConfigDirectory()

On Thu, Dec 19, 2019 at 11:04:13AM +0100, Fabiano Fidêncio wrote: virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/storage/storage_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [libvirt] [PATCH 05/42] rpc: Don't check the output of virGetUserDirectory()

On Thu, Dec 19, 2019 at 05:42:14PM +0100, Ján Tomko wrote: > On Thu, Dec 19, 2019 at 05:25:59PM +0100, Pavel Hrdina wrote: > > On Thu, Dec 19, 2019 at 05:21:21PM +0100, Fabiano Fidêncio wrote: > > > On Thu, Dec 19, 2019 at 5:07 PM Pavel Hrdina wrote: > > > > > > > > On Thu, Dec 19, 2019 at

Re: [libvirt] [PATCH 07/42] util: Don't check the output of virGetUserConfigDirectory()

On Thu, Dec 19, 2019 at 11:04:12AM +0100, Fabiano Fidêncio wrote: virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/util/virauth.c | 3 +-- src/util/virconf.c | 2 -- 2 files changed, 1 insertion(+),

Re: [libvirt] [PATCH 06/42] qemu: Don't check the output of virGetUserDirectory()

On Thu, Dec 19, 2019 at 11:04:11AM +0100, Fabiano Fidêncio wrote: virGetUserDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/qemu/qemu_interop_config.c | 3 --- 1 file changed, 3 deletions(-) Reviewed-by: Ján

Re: [libvirt] [PATCH 05/42] rpc: Don't check the output of virGetUserDirectory()

On Thu, Dec 19, 2019 at 05:25:59PM +0100, Pavel Hrdina wrote: On Thu, Dec 19, 2019 at 05:21:21PM +0100, Fabiano Fidêncio wrote: On Thu, Dec 19, 2019 at 5:07 PM Pavel Hrdina wrote: > > On Thu, Dec 19, 2019 at 11:04:10AM +0100, Fabiano Fidêncio wrote: > > virGetUserDirectory() *never* *ever*

Re: [libvirt] [PATCH 05/42] rpc: Don't check the output of virGetUserDirectory()

On Thu, Dec 19, 2019 at 11:04:10AM +0100, Fabiano Fidêncio wrote: virGetUserDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/rpc/virnetclient.c | 12 src/rpc/virnettlscontext.c | 12 2

Re: [libvirt] [PATCH 04/42] rpc: Use g_autofree on virNetClientNewLibssh()

s/on/in/ On Thu, Dec 19, 2019 at 11:04:09AM +0100, Fabiano Fidêncio wrote: Signed-off-by: Fabiano Fidêncio --- src/rpc/virnetclient.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature --

Re: [libvirt] [PATCH 03/42] rpc: Use g_autofree on virNetClientNewLibSSH2()

s/on/in/ On Thu, Dec 19, 2019 at 11:04:08AM +0100, Fabiano Fidêncio wrote: Signed-off-by: Fabiano Fidêncio --- src/rpc/virnetclient.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature --

Re: [libvirt] [PATCH 05/42] rpc: Don't check the output of virGetUserDirectory()

On Thu, Dec 19, 2019 at 05:21:21PM +0100, Fabiano Fidêncio wrote: > On Thu, Dec 19, 2019 at 5:07 PM Pavel Hrdina wrote: > > > > On Thu, Dec 19, 2019 at 11:04:10AM +0100, Fabiano Fidêncio wrote: > > > virGetUserDirectory() *never* *ever* returns NULL, making the checks for > > > it completely

Re: [libvirt] [PATCH 02/42] vbox: Don't leak virGetUserDirectory()'s output

On Thu, Dec 19, 2019 at 11:04:07AM +0100, Fabiano Fidêncio wrote: On vboxStorageVolCreateXML(), virGetUserDirectory() was called without s/On/In/ freeing its content later on. Signed-off-by: Fabiano Fidêncio --- src/vbox/vbox_storage.c | 7 +-- 1 file changed, 5 insertions(+), 2

Re: [libvirt] [PATCH 01/42] tools: Use g_autofree on cmdCd()

In the commit summary: s/on/in/ On Thu, Dec 19, 2019 at 11:04:06AM +0100, Fabiano Fidêncio wrote: Signed-off-by: Fabiano Fidêncio --- tools/vsh.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature --

Re: [libvirt] [PATCH 41/42] admin: Use g_autofree on getSocketPath()

On Thu, Dec 19, 2019 at 5:14 PM Pavel Hrdina wrote: > > On Thu, Dec 19, 2019 at 11:04:46AM +0100, Fabiano Fidêncio wrote: > > Signed-off-by: Fabiano Fidêncio > > --- > > src/admin/libvirt-admin.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > s/on/in/ $SUBJECT? > > This might

Re: [libvirt] [PATCH 05/42] rpc: Don't check the output of virGetUserDirectory()

On Thu, Dec 19, 2019 at 5:07 PM Pavel Hrdina wrote: > > On Thu, Dec 19, 2019 at 11:04:10AM +0100, Fabiano Fidêncio wrote: > > virGetUserDirectory() *never* *ever* returns NULL, making the checks for > > it completely unnecessary. > > > > Signed-off-by: Fabiano Fidêncio > > --- > >

Re: [libvirt] [PATCH 41/42] admin: Use g_autofree on getSocketPath()

On Thu, Dec 19, 2019 at 11:04:46AM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > src/admin/libvirt-admin.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) s/on/in/ $SUBJECT? This might be the case for other patches as well. One note, I would say it's ok to

Re: [libvirt] [PATCH 05/42] rpc: Don't check the output of virGetUserDirectory()

On Thu, Dec 19, 2019 at 11:04:10AM +0100, Fabiano Fidêncio wrote: > virGetUserDirectory() *never* *ever* returns NULL, making the checks for > it completely unnecessary. > > Signed-off-by: Fabiano Fidêncio > --- > src/rpc/virnetclient.c | 12 > src/rpc/virnettlscontext.c | 12

Re: [libvirt] [PATCH] AUTHORS: Add Fabiano Fidêncio

On 12/19/19 4:28 PM, Ján Tomko wrote: > $ git log --committer=fidencio --pretty=oneline | wc -l > 12 > > Signed-off-by: Ján Tomko > --- > Déjà vu from c379576dbc80a66820e256f9ce27595270d95ac2 except the > mailmap entry is already set up. > > AUTHORS.in | 1 + > 1 file changed, 1 insertion(+) >

[libvirt] CfP VHPC20: HPC Containers-Kubernetes

CALL FOR PAPERSa 15th Workshop on Virtualization in High-Performance Cloud Computing (VHPC 20) held in conjunction with the International Supercomputing Conference - High Performance, June 21-25, 2020, Frankfurt, Germany.

Re: [libvirt] [PATCH] AUTHORS: Add Fabiano Fidêncio

On Thu, Dec 19, 2019 at 4:31 PM Ján Tomko wrote: > > $ git log --committer=fidencio --pretty=oneline | wc -l > 12 > > Signed-off-by: Ján Tomko > --- > Déjà vu from c379576dbc80a66820e256f9ce27595270d95ac2 except the > mailmap entry is already set up. > > AUTHORS.in | 1 + > 1 file changed, 1

[libvirt] [PATCH] AUTHORS: Add Fabiano Fidêncio

$ git log --committer=fidencio --pretty=oneline | wc -l 12 Signed-off-by: Ján Tomko --- Déjà vu from c379576dbc80a66820e256f9ce27595270d95ac2 except the mailmap entry is already set up. AUTHORS.in | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.in b/AUTHORS.in index

Re: [libvirt] [libvirt-tck PATCH v2] Add cases for nvram

On Wed, Dec 18, 2019 at 04:52:03PM +0800, dzh...@redhat.com wrote: > From: Dan Zheng > > This is to add the tests for below flags: > - Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM > - Sys::Virt::Domain::UNDEFINE_NVRAM > > v1: https://www.redhat.com/archives/libvir-list/2019-December/msg00932.html

[libvirt] [PATCH 4/5] hostcpu: add support for reporting die_id in NUMA topology

Update the host CPU code to report the die_id in the NUMA topology capabilities. On systems with mulitple dies, this fixes the bug where CPU cores can't be distinguished: Notes core_id is repeated within the scope of the socket. It now reports

[libvirt] [PATCH 3/5] qemu: add support for specifying CPU "dies" topology parameter

QEMU since 4.1.0 supports the "dies" parameter for -smp Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 9 +++-- .../caps_4.1.0.x86_64.xml

[libvirt] [PATCH 5/5] tests: add host CPU data files for validating die_id

Only Cascadelake-AP CPUs appear to report "die_id" values != 0 on Linux right now - AMD EPYC's don't report "die_id" (at least with Fedora 31 kernel). Lacking access to Cascadelake-AP CPUs, this test data was from a Fedora 31 QEMU guest launched with -cpu qemu64 -smp

[libvirt] [PATCH 0/5] introduce support for CPU dies in host/guest topology

Latest generation CPUs (CascadeLake-AP) support a new topology level known as a 'die', sitting between a socket and a core. QEMU supports this with -smp arg since 4.1.0 Linux can report this via /sys/devices/system/cpu/cpuNNN/topology via 'die_id' and 'die_cpus' and 'die_cpus_list' files since

[libvirt] [PATCH 2/5] conf: remove unused virCapabilitiesSetHostCPU method

Signed-off-by: Daniel P. Berrangé --- src/conf/capabilities.c | 21 - src/conf/capabilities.h | 6 -- src/libvirt_private.syms | 1 - 3 files changed, 28 deletions(-) diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c index da54591c11..e54e46f54e 100644

[libvirt] [PATCH 1/5] conf: add support for specifying CPU "dies" parameter

Recently CPU hardware vendors have started to support a new level of inside the CPU package topology known as a "die". Thus the hierarchy is now: sockets > dies > cores > threads This adds support for "dies" in the XML parser, with the value defaulting to 1 if not specified for backwards

Re: [libvirt] [PATCH v2 1/2] virhostuptime: Introduce virHostBootTimeInit()

On Thu, Dec 19, 2019 at 12:25:00PM +0100, Michal Privoznik wrote: > The idea is to offer callers an init function that they can call > independently to ensure that the global variables get > initialized. > > Signed-off-by: Michal Privoznik > --- > src/libvirt_private.syms | 1 + >

Re: [libvirt] [PATCH] remote_daemon: Log host boot time

On 12/18/19 11:07 PM, Cole Robinson wrote: > On 12/17/19 8:25 AM, Michal Privoznik wrote: >> This is not strictly needed, but it makes sure we initialize the >> @bootTime global variable. Thing is, in order to validate XATTRs >> and prune those set in some previous runs of the host, a >> timestamp

[libvirt] [PATCH v2 2/2] remote_daemon: Initialize host boot time global variable

This is not strictly needed, but it makes sure we initialize the @bootTime global variable. Thing is, in order to validate XATTRs and prune those set in some previous runs of the host, a timestamp is recorded in XATTRs. The host boot time was unique enough so it was chosen as the timestamp value.

[libvirt] [PATCH v2 1/2] virhostuptime: Introduce virHostBootTimeInit()

The idea is to offer callers an init function that they can call independently to ensure that the global variables get initialized. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 + src/util/virhostuptime.c | 13 - src/util/virhostuptime.h | 3 +++ 3 files

[libvirt] [PATCH v2 0/2] Initialize host boot time global var upfront

This is a v2 for: https://www.redhat.com/archives/libvir-list/2019-December/msg01045.html While technically v1 was fixed I agree with Cole's suggestion, so I'm discarding v1 and sending another version which implements his suggestion. Michal Prívozník (2): virhostuptime: Introduce

Re: [libvirt] [PATCH 4/7] libvirt: support an "embed" URI path selector for opening drivers

On Tue, Dec 17, 2019 at 12:41:27PM -0500, Cole Robinson wrote: > On 12/2/19 10:03 AM, Daniel P. Berrangé wrote: > > The driver URI scheme: > > > > "$drivername:///embed?root=/some/path" > > > > enables a new way to use the drivers by embedding them directly in the > > calling process. To use

[libvirt] [PATCH v2 1/1] qemu: hide details of fake reboot

If we use fake reboot then domain goes thru running->shutdown->running state changes with shutdown state only for short period of time. At least this is implementation details leaking into API. And also there is one real case when this is not convinient. I'm doing a backup with the help of

Re: [libvirt] [PATCH] cpu: add CLZERO CPUID support for AMD platforms (libvirt 4.5)

Thanks. Going forward I will only send patches against the current master. Ani On 12/16/19, 5:37 PM, "Jiri Denemark" wrote: On Tue, Dec 03, 2019 at 03:19:39 -0800, Ani Sinha wrote: > Qemu commit e900135dcfb67 ("i386: Add CPUID bit for CLZERO and XSAVEERPTR") > adds support for

[libvirt] [PATCH 36/42] locking: Use g_autofree on virLockManagerLockDaemonPath()

Signed-off-by: Fabiano Fidêncio --- src/locking/lock_driver_lockd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/locking/lock_driver_lockd.c b/src/locking/lock_driver_lockd.c index e8f0329b05..8ca77e525d 100644 --- a/src/locking/lock_driver_lockd.c +++

[libvirt] [PATCH 33/42] logging: Use g_autofree on virLogDaemonUnixSocketPaths()

Together with the change, let's also simplify the function and get rid of the goto. Signed-off-by: Fabiano Fidêncio --- src/logging/log_daemon.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/logging/log_daemon.c b/src/logging/log_daemon.c index

[libvirt] [PATCH 37/42] locking: Use g_autofree on virLockDaemonUnixSocketPaths()

Together with the change, let's also simplify the function and get rid of the goto. Signed-off-by: Fabiano Fidêncio --- src/locking/lock_daemon.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/locking/lock_daemon.c b/src/locking/lock_daemon.c index

[libvirt] [PATCH 41/42] admin: Use g_autofree on getSocketPath()

Signed-off-by: Fabiano Fidêncio --- src/admin/libvirt-admin.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/admin/libvirt-admin.c b/src/admin/libvirt-admin.c index f156736d9f..d0c191a56a 100644 --- a/src/admin/libvirt-admin.c +++ b/src/admin/libvirt-admin.c @@ -99,7

[libvirt] [PATCH 21/42] logging: Don't check the output of virGetUserConfigDirectory()

virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/logging/log_daemon_config.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/logging/log_daemon_config.c

[libvirt] [PATCH 29/42] qemu: Don't check the output of virGetUserRuntimeDirectory()

virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/qemu/qemu_conf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index aa96d50e41..c07a844dfc

[libvirt] [PATCH 19/42] network: Don't check the output of virGetUserConfigDirectory()

virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/network/bridge_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c

[libvirt] [PATCH 25/42] storage: Don't check the output of virGetUserRuntimeDirectory()

virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/storage/storage_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index

[libvirt] [PATCH 40/42] interface: Don't check the output of virGetUserRuntimeDirectory()

virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/interface/interface_backend_netcf.c | 3 +-- src/interface/interface_backend_udev.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff

[libvirt] [PATCH 35/42] logging: Don't check the output of virGetUserRuntimeDirectory()

virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/logging/log_daemon.c | 11 +++ src/logging/log_manager.c | 3 +-- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git

[libvirt] [PATCH 20/42] logging: Use g_autofree on virLogDaemonConfigFilePath()

Signed-off-by: Fabiano Fidêncio --- src/logging/log_daemon_config.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/logging/log_daemon_config.c b/src/logging/log_daemon_config.c index 0cf9729e7f..ab42921140 100644 --- a/src/logging/log_daemon_config.c +++

[libvirt] [PATCH 22/42] locking: Use g_autofree on virLockDaemonConfigFilePath()

Signed-off-by: Fabiano Fidêncio --- src/locking/lock_daemon_config.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/locking/lock_daemon_config.c b/src/locking/lock_daemon_config.c index d7e13013d7..62df30d9f4 100644 --- a/src/locking/lock_daemon_config.c +++

[libvirt] [PATCH 32/42] logging: Use g_autofree on virLogManagerDaemonPath()

Signed-off-by: Fabiano Fidêncio --- src/logging/log_manager.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/logging/log_manager.c b/src/logging/log_manager.c index e191093272..7a4f036240 100644 --- a/src/logging/log_manager.c +++ b/src/logging/log_manager.c @@ -47,14

[libvirt] [PATCH 16/42] rpc: Don't check the output of virGetUserConfigDirectory()

virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/rpc/virnetclient.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c

[libvirt] [PATCH 30/42] node_device: Don't check the output of virGetUserRuntimeDirectory()

virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/node_device/node_device_hal.c | 3 +-- src/node_device/node_device_udev.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH 34/42] logging: Use g_autofree on virLogDaemonExecRestartStatePath()

Together with the change, let's also simplify the function and get rid of the goto. Signed-off-by: Fabiano Fidêncio --- src/logging/log_daemon.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/logging/log_daemon.c b/src/logging/log_daemon.c index

[libvirt] [PATCH 09/42] secret: Don't check the output of virGetUserConfigDirectory()

virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/secret/secret_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c

[libvirt] [PATCH 42/42] admin: Don't check the output of virGetUserRuntimeDirectory()

virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/admin/libvirt-admin.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/admin/libvirt-admin.c b/src/admin/libvirt-admin.c index

[libvirt] [PATCH 27/42] rpc: Don't check the output of virGetUserRuntimeDirectory()

virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/rpc/virnetsocket.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index

  1   2   >