Re: [libvirt] Xen + libvirt + TPM

2020-01-06 Thread Jim Fehlig
You posted the same message on the libvirt-user list, which would have been sufficient for this query. For the record, it was answered there https://www.redhat.com/archives/libvirt-users/2020-January/msg3.html Regards, Jim On 12/30/19 8:30 AM, Arthur Borsboom wrote: > Hello, > > I am

Re: [libvirt] [PATCHv2 1/2] util, resctrl: using 64bit interface instead of 32bit for counters

2020-01-06 Thread Wang, Huaqiang
Hi Daniel, Thanks for review! Br Huaqiang > -Original Message- > From: Daniel P. Berrangé > Sent: Monday, January 6, 2020 10:16 PM > To: Wang, Huaqiang > Cc: libvir-list@redhat.com > Subject: Re: [PATCHv2 1/2] util, resctrl: using 64bit interface instead of > 32bit > for counters >

Re: [libvirt] [PATCHv2 2/2] Introduce command 'virsh domstats --memory' for reporting memory BW

2020-01-06 Thread Wang, Huaqiang
Hi Daniel, Thanks for your hard work and review! Br Huaqiang > -Original Message- > From: Daniel P. Berrangé > Sent: Monday, January 6, 2020 10:17 PM > To: Wang, Huaqiang > Cc: libvir-list@redhat.com > Subject: Re: [PATCHv2 2/2] Introduce command 'virsh domstats --memory' > for

[libvirt] [PATCH v1 23/26] util: remove remaining unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
This patch remove the remaining unneeded labels in 'util' files: virnetdev.c virnetdevmacvlan.c virnetdevtap.c virtpm.c virtypedparam.c viruuid.c Signed-off-by: Daniel Henrique Barboza --- src/util/virnetdev.c| 13 - src/util/virnetdevmacvlan.c | 3 +--

[libvirt] [PATCH v1 18/26] vz/vz_sdk.c: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/vz/vz_sdk.c | 102 ++-- 1 file changed, 37 insertions(+), 65 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index c98542c244..b8ac055574 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@

[libvirt] [PATCH v1 26/26] examples: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- examples/c/misc/hellolibvirt.c | 28 +--- examples/c/misc/openauth.c | 22 ++ 2 files changed, 15 insertions(+), 35 deletions(-) diff --git a/examples/c/misc/hellolibvirt.c

[libvirt] [PATCH v1 10/26] locking/lock_driver_lockd.c: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/locking/lock_driver_lockd.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/locking/lock_driver_lockd.c b/src/locking/lock_driver_lockd.c index 339e2f6949..393154bb3c 100644 ---

[libvirt] [PATCH v1 16/26] qemu: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
This patch remove unneeded labels for the following files: qemu_capabilities.c qemu_domain_address.c qemu_hostdev.c qemu_hotplug.c qemu_migration_cookie.c qemu_migration_params.c Next patch will handle the remaining QEMU files that can be cleaned up. Signed-off-by: Daniel Henrique Barboza ---

[libvirt] [PATCH v1 06/26] storage: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/storage/storage_backend_iscsi_direct.c | 4 +--- src/storage/storage_driver.c | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/storage/storage_backend_iscsi_direct.c

[libvirt] [PATCH v1 25/26] tests: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- tests/qemumonitortestutils.c | 15 +-- tests/testutilsqemu.c| 8 ++-- tests/virhostdevtest.c | 14 +- 3 files changed, 12 insertions(+), 25 deletions(-) diff --git a/tests/qemumonitortestutils.c

[libvirt] [PATCH v1 21/26] util/virsysinfo.c: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/util/virsysinfo.c | 54 ++- 1 file changed, 17 insertions(+), 37 deletions(-) diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c index e5af4f25e0..c526c0322f 100644 --- a/src/util/virsysinfo.c +++

[libvirt] [PATCH v1 07/26] nwfilter: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/nwfilter/nwfilter_ebiptables_driver.c | 11 --- src/nwfilter/nwfilter_learnipaddr.c | 3 +-- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/nwfilter/nwfilter_ebiptables_driver.c

[libvirt] [PATCH v1 19/26] vbox: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/vbox/vbox_MSCOMGlue.c | 11 +-- src/vbox/vbox_snapshot_conf.c | 9 +++-- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/src/vbox/vbox_MSCOMGlue.c b/src/vbox/vbox_MSCOMGlue.c index 18a291a0d8..5cc3f5c7c8 100644 ---

[libvirt] [PATCH v1 09/26] hyperv/hyperv_wmi.c: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/hyperv/hyperv_wmi.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 7d56677588..ca2d29733e 100644 --- a/src/hyperv/hyperv_wmi.c +++

[libvirt] [PATCH v1 24/26] logging: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/logging/log_handler.c | 7 ++- src/logging/log_manager.c | 14 -- 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/src/logging/log_handler.c b/src/logging/log_handler.c index 29ea3011b9..030c9d66e3 100644 ---

[libvirt] [PATCH v1 20/26] security: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/security/security_dac.c | 26 ++--- src/security/security_selinux.c | 26 ++--- src/security/virt-aa-helper.c | 41 ++--- 3 files changed, 41 insertions(+), 52 deletions(-) diff

[libvirt] [PATCH v1 14/26] secret/secret_driver.c: remove unneeded label

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/secret/secret_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c index 096672f114..5a93c3af82 100644 --- a/src/secret/secret_driver.c +++

[libvirt] [PATCH v1 05/26] test/test_driver.c: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/test/test_driver.c | 51 ++ 1 file changed, 22 insertions(+), 29 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index f8e08dcf07..1908185743 100644 --- a/src/test/test_driver.c +++

[libvirt] [PATCH v1 17/26] qemu: remove remaining unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
This patch finishes cleaning up unneeded labels on the QEMU files. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_command.c | 93 +++-- src/qemu/qemu_domain.c | 11 ++--- src/qemu/qemu_driver.c | 32 +- 3 files changed, 55

[libvirt] [PATCH v1 08/26] remote/remote_daemon_config.c: remove unneeded label

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/remote/remote_daemon_config.c | 101 +++--- 1 file changed, 49 insertions(+), 52 deletions(-) diff --git a/src/remote/remote_daemon_config.c b/src/remote/remote_daemon_config.c index 1d739caabf..0ecc49f179 100644 ---

[libvirt] [PATCH v1 01/26] bhyve: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Labels that are simply a jump to a 'return' call are unneeded and can be replaced by the return value instead. Signed-off-by: Daniel Henrique Barboza --- src/bhyve/bhyve_device.c| 13 - src/bhyve/bhyve_parse_command.c | 47 + 2 files changed, 23

[libvirt] [PATCH v1 15/26] openvz: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/openvz/openvz_conf.c | 11 -- src/openvz/openvz_driver.c | 42 +++--- 2 files changed, 21 insertions(+), 32 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index

[libvirt] [PATCH v1 03/26] conf: remove more unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Remove unneeded labels from the following conf files: cpu_conf.c domain_addr.c interface_conf.c nwfilter_params.c Signed-off-by: Daniel Henrique Barboza --- src/conf/cpu_conf.c| 36 src/conf/domain_addr.c | 9 -

[libvirt] [PATCH v1 11/26] cpu/cpu_ppc64.c: remove unneeded label

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/cpu/cpu_ppc64.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 818f1ec699..6b3590ab6a 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -81,7 +81,6 @@

[libvirt] [PATCH v1 12/26] lxc: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/lxc/lxc_container.c | 7 ++- src/lxc/lxc_controller.c | 10 -- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 42ed08ede6..b44cc68e67 100644 ---

[libvirt] [PATCH v1 22/26] util: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Remove unneeded labels of the following util files: virhostcpu.c virnetdevvportprofile.c virnetlink.c virpci.c virsocketaddr.c virstoragefile.c Signed-off-by: Daniel Henrique Barboza --- src/util/virhostcpu.c| 6 ++-- src/util/virnetdevvportprofile.c | 52

[libvirt] [PATCH v1 13/26] node_device: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
gather_scsi_host_cap() in node_device_hal.c can be greatly simplified, given that the 'out' label is always getting hit regardless of 'retval', which can also be eliminated. Signed-off-by: Daniel Henrique Barboza --- src/node_device/node_device_driver.c | 4 ++--

[libvirt] [PATCH v1 04/26] conf/domain_conf.c: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/conf/domain_conf.c | 192 ++--- 1 file changed, 65 insertions(+), 127 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ee33b7caf0..c026fdf45c 100644 --- a/src/conf/domain_conf.c +++

[libvirt] [PATCH v1 02/26] conf: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Remove unneeded labels from the following src/conf files: capabilities.c network_conf.c networkcommon_conf.c nwfilter_conf.c virnetworkobj.c Signed-off-by: Daniel Henrique Barboza --- src/conf/capabilities.c | 14 --- src/conf/network_conf.c | 45

[libvirt] [PATCH v1 00/26] remove more unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
Hi, This is a follow up of a cleanup I did last year [1], which was more focused on 'cleanup' labels. In this one I covered all labels that are simply a 'return' proxy call. This wasn't a 'purge all return labels' series. Some of them are still around in cases where they help the code flow (like

Re: [libvirt] [PATCH 0/7] fix debian 9 incompatibility with recent changes

2020-01-06 Thread Daniel Henrique Barboza
On 1/6/20 2:26 PM, Daniel P. Berrangé wrote: Previous commits to eliminate gnulib modules accidentally used some glib APIs not available in Debian 9. GLib has support for compile time version checking of APIs but we mistakenly havent enabled it in libvirt. This series fixes the bad API

Re: [libvirt] [PATCH 6/7] util: introduce compile time API version checking

2020-01-06 Thread Daniel Henrique Barboza
Just a small nit: On 1/6/20 2:26 PM, Daniel P. Berrangé wrote: GLib header files annotate every API with a version number. It is possible to define some constants before including glib.h which will result in useful compile time warnings. Setting GLIB_VERSION_MIN_REQUIRED will result in a

[libvirt] [PATCH 6/7] util: introduce compile time API version checking

2020-01-06 Thread Daniel P . Berrangé
GLib header files annotate every API with a version number. It is possible to define some constants before including glib.h which will result in useful compile time warnings. Setting GLIB_VERSION_MIN_REQUIRED will result in a warning if libvirt uses an API that was deprecated in the declared

[libvirt] [PATCH 4/7] util: add compat impl of g_canonicalize_filename

2020-01-06 Thread Daniel P . Berrangé
g_canonicalize_filename was not introduced until glib 2.58 so we need a temporary backport of its impl. Signed-off-by: Daniel P. Berrangé --- src/libvirt_private.syms | 1 + src/util/glibcompat.c| 106 +++ src/util/glibcompat.h| 3 ++ 3 files

[libvirt] [PATCH 5/7] src: remove use of g_date_time_new_from_iso8601 function

2020-01-06 Thread Daniel P . Berrangé
The g_date_time_new_from_iso8601() function was introduced as a replacement for strptime in commit 810613a60efe3924c536b3663246900bc08910a5 Author: Daniel P. Berrangé Date: Mon Dec 23 15:37:26 2019 + src: replace strptime()/timegm()/mktime() with GDateTime APIs set

[libvirt] [PATCH 1/7] util: always replace g_fsync usage with our wrapper

2020-01-06 Thread Daniel P . Berrangé
g_fsync was introduced in 2.63 which is newer than our minimum glib version. A future commit will introduce compile time checking of API versions to prevent accidental usage of APIs from glib newer than our min declared. To avoid triggering this warning, however, we need to ensure that we always

[libvirt] [PATCH 3/7] util: fix indent depth for glib compat impls

2020-01-06 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- src/util/glibcompat.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/util/glibcompat.c b/src/util/glibcompat.c index e19cf74e72..42f9353c8f 100644 --- a/src/util/glibcompat.c +++

[libvirt] [PATCH 0/7] fix debian 9 incompatibility with recent changes

2020-01-06 Thread Daniel P . Berrangé
Previous commits to eliminate gnulib modules accidentally used some glib APIs not available in Debian 9. GLib has support for compile time version checking of APIs but we mistakenly havent enabled it in libvirt. This series fixes the bad API usage, then enables version checkihng, and finally

[libvirt] [PATCH 7/7] travis: add build for Debian 9

2020-01-06 Thread Daniel P . Berrangé
Debian 9 ships the oldest versions of some of our dependent packages so can highlight bugs not seen elsewhere. CentOS 7, despite being quite old, has rebased some packages to much newer versions. Signed-off-by: Daniel P. Berrangé --- .travis.yml | 7 +++ 1 file changed, 7 insertions(+)

[libvirt] [PATCH 2/7] util: keep glib compat methods in alphabetical order

2020-01-06 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- src/util/glibcompat.c | 26 +- src/util/glibcompat.h | 2 +- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/util/glibcompat.c b/src/util/glibcompat.c index 9fba54cb79..e19cf74e72 100644 ---

Re: [libvirt] [PATCH 2/2] qemu_firmware: Try to autofill for old style UEFI specification

2020-01-06 Thread Michal Privoznik
On 12/18/19 11:50 PM, Cole Robinson wrote: On 12/17/19 12:25 PM, Michal Privoznik wrote: While we discourage people to use the old style of specifying UEFI for their domains (the old style is putting path to the FW image under /domain/os/loader/ whilst the new one is using

Re: [libvirt] [jenkins-ci PATCH 2/2] guests: Only install OpenVZ on CentOS 7

2020-01-06 Thread Andrea Bolognani
On Mon, 2019-12-16 at 12:55 +0100, Fabiano Fidêncio wrote: > OpenVZ has been added as part of commit 0a7993d3ed30ae. However, it's > wrongly set to be installed on any supported CentOS. > > Signed-off-by: Fabiano Fidêncio > --- > guests/playbooks/update/tasks/base.yml | 1 + > 1 file changed, 1

Re: [libvirt] [jenkins-ci PATCH 1/2] guests: Mention CentOS8 as a valid OS version

2020-01-06 Thread Andrea Bolognani
On Mon, 2019-12-16 at 12:55 +0100, Fabiano Fidêncio wrote: > # Valid OS versions are: > -# - CentOS7, Debian9, FedoraRawhide, OpenSUSE151, Ubuntu1804 and so on > +# - CentOS7, CentOS8, Debian9, FedoraRawhide, OpenSUSE151, Ubuntu1804 and > so > +# on This list is intended to show what

Re: [libvirt] [PATCH] ci: Fetch list of available container images dynamically

2020-01-06 Thread Andrea Bolognani
On Tue, 2019-12-17 at 11:21 -0500, Cole Robinson wrote: > But the other ci/ scripts are listed in Makefile.am EXTRA_DIST, so > adjust that before pushing unless it was deliberate Nah, it was just an oversight. Good catch! I've fixed it before pushing. -- Andrea Bolognani / Red Hat /

Re: [libvirt] [PATCH 0/2] vircgroupv2devices: Avoid double close on map FD

2020-01-06 Thread Pavel Hrdina
On Mon, Jan 06, 2020 at 03:24:18PM +0100, Michal Privoznik wrote: > *** BLURB HERE *** > > Michal Prívozník (2): > vircgroupv2devices: Unexport virCgroupV2DevicesAttachProg() > vircgroupv2devices: Avoid double close on map FD Reviewed-by: Pavel Hrdina signature.asc Description: PGP

[libvirt] [PATCH 1/2] qemu: checkpoint: Extract and export rollback of checkpoint metadata storing

2020-01-06 Thread Peter Krempa
If we are certain that the checkpoint creation failed we remove the metadata from the list. To allow reusing this in the backup code add a new helper and export it. Signed-off-by: Peter Krempa --- src/qemu/qemu_checkpoint.c | 22 -- src/qemu/qemu_checkpoint.h | 4 2

[libvirt] [PATCH 0/2] backup: Remove checkpoint metadata on failed backup

2020-01-06 Thread Peter Krempa
When creating a checkpoint along with a backup, failure in some cases lead to libvirt keeping the stale chekckpoint metadata. Peter Krempa (2): qemu: checkpoint: Extract and export rollback of checkpoint metadata storing qemu: backup: roll-back checkpoint metadata if the checkpoint wasn't

[libvirt] [PATCH 2/2] qemu: backup: roll-back checkpoint metadata if the checkpoint wasn't taken

2020-01-06 Thread Peter Krempa
We insert the checkpoint metadata into the list of checkpoints prior to actually creating the on-disk bits. If the 'transaction' or any other steps done between inserting the checkpoint and creating the on-disk data fail we'd end up with an unusable checkpoint that would vanish after libvirtd

[libvirt] [PATCH 7/9] qemu: address: take fsdriver type into account

2020-01-06 Thread Ján Tomko
Split the switch by fsdriver type to allow adding a new one. Signed-off-by: Ján Tomko --- src/qemu/qemu_domain_address.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index

[libvirt] [PATCH 5/9] qemu: add private data to virDomainFSDef

2020-01-06 Thread Ján Tomko
Wire up the allocation and disposal of private data. Signed-off-by: Ján Tomko --- src/qemu/qemu_domain.c | 38 ++ src/qemu/qemu_domain.h | 12 2 files changed, 50 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index

[libvirt] [PATCH 8/9] qemu: command: take fsdriver type into account

2020-01-06 Thread Ján Tomko
Split the formatting by fsdriver type to allow adding a new type. Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 3b18282de4..90236620a1 100644 ---

[libvirt] [PATCH 3/9] conf: add xmlopt to virDomainFSDefNew

2020-01-06 Thread Ján Tomko
This will be needed in the future for allocating private data. Signed-off-by: Ján Tomko --- src/conf/domain_conf.c | 4 ++-- src/conf/domain_conf.h | 2 +- src/lxc/lxc_native.c | 2 +- src/lxc/lxc_process.c| 2 +- src/openvz/openvz_conf.c | 2 +- src/vmx/vmx.c| 2 +-

[libvirt] [PATCH 2/9] qemu: rename gluster_debug_entry

2020-01-06 Thread Ján Tomko
Remove the 'gluster' part and decouple the return from the gluster_debug_level parsing to allow adding more options to this section. Signed-off-by: Ján Tomko --- src/qemu/libvirtd_qemu.aug | 4 ++-- src/qemu/qemu_conf.c | 11 +++ 2 files changed, 9 insertions(+), 6 deletions(-)

[libvirt] [PATCH 0/9] Filesystem-device-related refactors (virtio-fs epopee)

2020-01-06 Thread Ján Tomko
Ján Tomko (9): build: error out when check-augeas fails qemu: rename gluster_debug_entry conf: add xmlopt to virDomainFSDefNew conf: add private data to virDomainFSDef qemu: add private data to virDomainFSDef qemu: pass private data to qemuBuildFilesystemCommandLine qemu: address:

[libvirt] [PATCH 4/9] conf: add private data to virDomainFSDef

2020-01-06 Thread Ján Tomko
Add an object to hold the private data and call the allocation function if it's present in xmlopt. Signed-off-by: Ján Tomko --- src/conf/domain_conf.c | 7 ++- src/conf/domain_conf.h | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCH 1/9] build: error out when check-augeas fails

2020-01-06 Thread Ján Tomko
Fixes: 2ffbdabb859594256d45c1b48521dd6501629852 Signed-off-by: Ján Tomko --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index f3d4c28c6d..c9b5eeba47 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -342,7 +342,7 @@

[libvirt] [PATCH 6/9] qemu: pass private data to qemuBuildFilesystemCommandLine

2020-01-06 Thread Ján Tomko
This will be used by a future patch. Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 11d3c29297..3b18282de4 100644 --- a/src/qemu/qemu_command.c +++

[libvirt] [PATCH 9/9] docs: formatdomain: use 'element' instead of 'block'

2020-01-06 Thread Ján Tomko
Signed-off-by: Ján Tomko --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index dd04a05f09..b7910e3742 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -3979,7 +3979,7

[libvirt] [PATCH 0/2] vircgroupv2devices: Avoid double close on map FD

2020-01-06 Thread Michal Privoznik
*** BLURB HERE *** Michal Prívozník (2): vircgroupv2devices: Unexport virCgroupV2DevicesAttachProg() vircgroupv2devices: Avoid double close on map FD src/libvirt_private.syms | 1 - src/util/vircgroupv2devices.c | 29 + src/util/vircgroupv2devices.h | 5

[libvirt] [PATCH 1/2] vircgroupv2devices: Unexport virCgroupV2DevicesAttachProg()

2020-01-06 Thread Michal Privoznik
This function is not called outside of the source file where it's defined. There's no need to export it. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 - src/util/vircgroupv2devices.c | 14 +- src/util/vircgroupv2devices.h | 5 - 3 files changed, 1

[libvirt] [PATCH 2/2] vircgroupv2devices: Avoid double close on map FD

2020-01-06 Thread Michal Privoznik
When allowing/denying a device in devices CGroupV2 we have to write a BPF program for it. The program we put there is merely static and all it does it looks up a device in a hash table (also known as map in BPF terminology). A map is referenced via an FD which can be acquired via virBPFCreateMap()

Re: [libvirt] [PATCHv2 2/2] Introduce command 'virsh domstats --memory' for reporting memory BW

2020-01-06 Thread Daniel P . Berrangé
On Thu, Jan 02, 2020 at 06:45:05PM +0800, Wang Huaqiang wrote: > Introduce an option '--memory' for showing memory related > information. The memory bandwidth infomatio is listed as: > > Domain: 'libvirt-vm' > memory.bandwidth.monitor.count=4 > memory.bandwidth.monitor.0.name=vcpus_0-4 >

Re: [libvirt] [PATCHv2 1/2] util, resctrl: using 64bit interface instead of 32bit for counters

2020-01-06 Thread Daniel P . Berrangé
On Thu, Jan 02, 2020 at 06:45:04PM +0800, Wang Huaqiang wrote: > The underlying resctrl monitoring is actually using 64 bit counters, > not the 32bit one. Correct this by using 64bit data type for reading > hardware value. > > To keep the interface consistent, the result of CPU last level cache >

Re: [libvirt] [PATCH] qemu: backup: Move capability check after inactive check

2020-01-06 Thread Erik Skultety
On Mon, Jan 06, 2020 at 12:36:57PM +0100, Peter Krempa wrote: > Inactive VM doesn't have qemuCaps set thus we'd never properly report > that VM backups are supported only for running VMs. > > Move the capability check after the active check. > > Signed-off-by: Peter Krempa > --- Reviewed-by: Erik

[libvirt] [PATCH] qemu: backup: Move capability check after inactive check

2020-01-06 Thread Peter Krempa
Inactive VM doesn't have qemuCaps set thus we'd never properly report that VM backups are supported only for running VMs. Move the capability check after the active check. Signed-off-by: Peter Krempa --- src/qemu/qemu_backup.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[libvirt] [PATCH] util: time: Fix comment for virTimeFieldsNow

2020-01-06 Thread Peter Krempa
Signed-off-by: Peter Krempa --- src/util/virtime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Trivial. diff --git a/src/util/virtime.c b/src/util/virtime.c index 54466b2f39..13f899cb91 100644 --- a/src/util/virtime.c +++ b/src/util/virtime.c @@ -223,7 +223,7 @@ int

Re: [libvirt] [PATCH 6/7] docs: Documents for virtio-rng backend builtin

2020-01-06 Thread Peter Krempa
On Wed, Jan 01, 2020 at 13:06:36 +0800, Han Han wrote: > Signed-off-by: Han Han > --- > docs/formatdomain.html.in | 10 ++ > docs/formatdomaincaps.html.in | 1 + > 2 files changed, 11 insertions(+) This should be part of the XML addition commit. > > diff --git

Re: [libvirt] [PATCH 3/7] qemu: Implement builtin rng backend

2020-01-06 Thread Peter Krempa
On Mon, Jan 06, 2020 at 11:11:01 +0100, Peter Krempa wrote: > On Wed, Jan 01, 2020 at 13:06:33 +0800, Han Han wrote: > > Since v4.2-rc0, QEMU introduced a builtin rng backend that uses > > getrandom() syscall to generate random. Add it to libvirt with the > > backend model 'builtin'. > > > >

[libvirt] [PATCH] Cleaning up pools is not always ideal

2020-01-06 Thread ebenner
Libvirt cleans up pools that error out by deactivating them. When using LVM this is not very useful. We rather would have our own system handle any real failures and to many situations where errors are meaningless and unimportant cause Libvirt to disable our pools continuously causing lots of

[libvirt] [PATCH] Don't check if the path exists for LVM

2020-01-06 Thread ebenner
I'm not entirely sure why Libvirt is checking to see if the target file exists for LVM but it is a problem. Empty volume groups do not appear in /dev. When libvirt starts these pools then fail to autostart because their path does not exist. This is not useful, this is the patch we are running

Re: [libvirt] [PATCH 4/7] docs: Add schemas for rng backend builtin

2020-01-06 Thread Peter Krempa
On Wed, Jan 01, 2020 at 13:06:34 +0800, Han Han wrote: > Signed-off-by: Han Han > --- > docs/schemas/domaincommon.rng | 6 ++ > 1 file changed, 6 insertions(+) This hunk should be part of the XML addition commit. > > diff --git a/docs/schemas/domaincommon.rng

Re: [libvirt] [PATCH 5/7] tests: Add tests fr virtio-rng backend builtin

2020-01-06 Thread Peter Krempa
On Wed, Jan 01, 2020 at 13:06:35 +0800, Han Han wrote: > Signed-off-by: Han Han > --- > .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + > .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + > .../qemu_4.2.0-virt.aarch64.xml | 1 + >

Re: [libvirt] [PATCH 3/7] qemu: Implement builtin rng backend

2020-01-06 Thread Peter Krempa
On Wed, Jan 01, 2020 at 13:06:33 +0800, Han Han wrote: > Since v4.2-rc0, QEMU introduced a builtin rng backend that uses > getrandom() syscall to generate random. Add it to libvirt with the > backend model 'builtin'. > > https://bugzilla.redhat.com/show_bug.cgi?id=1785091 > > Signed-off-by: Han

Re: [libvirt] [PATCH 1/7] qemu_capabilities: Introduce QEMU_CAPS_OBJECT_RNG_BUILTIN

2020-01-06 Thread Peter Krempa
On Wed, Jan 01, 2020 at 13:06:31 +0800, Han Han wrote: > It is used to check if qemu is capable of rng-builtin object: > -object rng-builtin,id=id > > This object is added since qemu-4.2.0-rc0, commit 6c4e9d48. > > Signed-off-by: Han Han > --- > src/qemu/qemu_capabilities.c | 4 >

Re: [libvirt] [PATCH 2/7] util: Do not assume comma after object id

2020-01-06 Thread Peter Krempa
On Wed, Jan 01, 2020 at 13:06:32 +0800, Han Han wrote: > From: Han Han > > For qemu object like rng-builtin, there are no properties after id > property. We should always set comma after object id. Otherwise it will > cause trailing comma on object: > -object rng-builtin,id=ID, > >

[libvirt] stream does not work in non-block mode with event loop implementation on Fibers

2020-01-06 Thread senid senid
*libvirt_stream_event_add_callback* creates *passthrough* variable using *rb_ary_new2* and pass it to *virStreamEventAddCallback* at *ext/libvirt/stream.c:272*. After that ruby garbage collector removes this variable (I think because there is no references for *passthrough* in ruby code).

Re: [libvirt] [PATCH 09/23] util: introduce virFileDataSync

2020-01-06 Thread Pino Toscano
On Thursday, 2 January 2020 15:53:43 CET Daniel P. Berrangé wrote: > A wrapper that calls g_fsync on Win32/macOS and fdatasync > elsewhere. g_fsync is a stronger flush than we need but it > satisfies the caller's requirements & matches the approach > gnulib takes. > > [...] > +int >

Re: [libvirt] [PATCH 18/23] util: use realpath/g_canonicalize_filename

2020-01-06 Thread Pino Toscano
On Thursday, 2 January 2020 15:53:52 CET Daniel P. Berrangé wrote: > The canonicalize_file_name(path) is equivalent to calling > realpath(path, NULL). Passing NULL for the second arg of > realpath is not standardized behaviour, however, Linux, > FreeBSD > 6.4 and macOS > 10.5 all support this