On Thu, Jan 09, 2020 at 23:04:19 +, Jim Fehlig wrote:
> Are they supported with tunneled migration? The feature seems limited to
> native
> migration, in which case I can send a patch prohibiting parallel migration
> connections with the tunnel.
That is true. Libvirt's stream which is used
Are they supported with tunneled migration? The feature seems limited to native
migration, in which case I can send a patch prohibiting parallel migration
connections with the tunnel.
Regards,
Jim
--
libvir-list mailing list
libvir-list@redhat.com
On 1/9/20 3:31 PM, Peter Krempa wrote:
Use the user-configured name of the bitmap when merging the appropriate
bitmaps for an incremental backup so that the user can see it as
configured. Additionally expose the default bitmap name if nothing is
configured.
Signed-off-by: Peter Krempa
---
On 1/9/20 3:31 PM, Peter Krempa wrote:
Pass the exportname as configured when exporting the image via NBD and
fill it with the default if it's not configured.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_backup.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by:
On 1/9/20 3:31 PM, Peter Krempa wrote:
If users wish to use different name for exported disks or bitmaps
the new fields allow to do so. Additionally they also document the
current settings.
Signed-off-by: Peter Krempa
---
docs/formatbackup.html.in | 9
Previous patches deprecated some 'cleanup' labels. Let's remove
them.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 267 +++--
1 file changed, 98 insertions(+), 169 deletions(-)
diff --git a/src/qemu/qemu_domain.c
qemuDomainChrDefDropDefaultPath() returns an int, but it's
always returning 0. Callers are checking for result < 0 to
run their cleanup code needlessly.
Turn the function to 'void' and adjust the callers.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 17 +
Previous patch used 'g_autofree' to eliminate instances of
VIR_FREE(), making some cleanup labels obsolete. This
patch removes them.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_addr.c | 98 +++---
1 file changed, 34 insertions(+), 64
Starting on commit 1f43393283ff, qemuDomainFillDeviceIsolationGroup()
returns 0 in all circunstances. Let's turn it to 'void' make it
clearer that the function will not fail. This also spares a
check for < 0 return in qemu_hotplug.c. The
qemuDomainFillDeviceIsolationGroupIter() callback now
Hi,
These are a few cleanups in some files that I'll end up
messing with in a future series (which isn't Glibfied ATM).
Figured it's best to clean them up now instead of adding
more non-Glibfied code on top.
Patches 7 and 8 are stuff that I noted some time ago and
figured it might be worth
The 'caps' variable in qemuDomainObjPrivateXMLParseAutomaticPlacement()
is set to auto clean via g_autoptr(), but a 'virObjectUnref(caps)' is
being executed in the 'cleanup' label.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 1 -
1 file changed, 1 deletion(-)
diff --git
Use g_autofree in strings when possible to spare a VIR_FREE()
call. Unneeded 'cleanup' labels will be taken care of in the
next patch.
The 'str' string in virDomainVirtioSerialAddrReserve() was
never used by the logic, only being used in cleanup by
VIR_FREE(). Let's remove it.
Signed-off-by:
Avoid some of the virObjectUnref() calls by using g_autoptr.
Aside from the 'cleanup' label in qemuDomainSetFakeReboot(),
all other now deprecated cleanup labels will be removed in
the next patch.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 87
Use g_autofree to remove VIR_FREE() calls used for cleanups.
Labels that became deprecated will be removed in a later
patch.
In qemuDomainSetupDisk(), the 'dst' variable is not used at
all and could be removed.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 139
These were already posted before.
oVirt folks would like to be able to read the export and bitmap names.
Given that I already wrote support for configuring it and it's rather
simple I'm re-posting these as they were before.
Peter Krempa (3):
conf: backup: Allow configuration of names exported
If users wish to use different name for exported disks or bitmaps
the new fields allow to do so. Additionally they also document the
current settings.
Signed-off-by: Peter Krempa
---
docs/formatbackup.html.in | 9 +
docs/schemas/domainbackup.rng
Use the user-configured name of the bitmap when merging the appropriate
bitmaps for an incremental backup so that the user can see it as
configured. Additionally expose the default bitmap name if nothing is
configured.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_backup.c | 9 -
1 file
Pass the exportname as configured when exporting the image via NBD and
fill it with the default if it's not configured.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_backup.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c
Use the synthetic test data to verify that the algorithm correctly picks
bitmaps to merge when the bitmap is changed along with the image itself.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 7 +++
.../snapshots-intermediate2-out.json | 7 +++
Allow qemu access to modify backing files in case when we want to delete
a checkpoint.
This patch adds tracking of which images need to be relabelled when
calculating the transaction, the code to relabel them and rollback.
To verify that stuff works we also output the list of images to relabel
Add test infrastructure and a basic test for bitmap deletion.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 59 +++
.../checkpointdelete/basic-noparent-out.json | 9 +++
2 files changed, 68 insertions(+)
create mode 100644
Allow deleting of checkpoints when snapshots were created along. The
code tracks and modifies the checkpoint list so that backups can still
be taken with such a backing chain. This unfortunately requires to
rename few bitmaps (by copying and deleting them) in some cases.
Signed-off-by: Peter
Add test cases for merging various pairs of bitmaps when snapshots were
created together with checkpoints.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 6 +++
.../snapshots-current-out.json| 29 +++
.../snapshots-intermediate1-out.json
Add all intermediate steps and deletion of the current checkpoint on a
flat (single-image) disk image.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 4 +++
.../checkpointdelete/basic-current-out.json | 29 +++
.../basic-intermediate1-out.json
If a disk is unplugged and then the user tries to delete a checkpoint
the code would try to use NULL node name as it was not checked.
Fix this by fetching the whole disk definition object and verifying it
was found.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_checkpoint.c | 23
Upcomming patches will also use the domain diks definition. Rename disk
to chkdisk for clarity.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_checkpoint.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c
index
Upcomming patches will also use the domain diks definition. Rename disk
to chkdisk for clarity.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_checkpoint.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c
Lookup the whole disk definition rather than just the node name.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_checkpoint.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c
index 0aa854324b..03a8321135
Add a faked qemu output which would simulate scenario where libvirt
would take a snapshot and checkpoint simultaneously. This is visible in
libvirt-2-format node where bitmap 'c' appears, but bitmap 'b' which is
active in the previous layer is not present.
Signed-off-by: Peter Krempa
---
This will allow some testing before refactoring.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_checkpoint.c | 72 --
src/qemu/qemu_checkpoint.h | 7
2 files changed, 53 insertions(+), 26 deletions(-)
diff --git a/src/qemu/qemu_checkpoint.c
The algorithm is used in two places to find the parent checkpoint object
which contains given disk and then uses data from the disk. Additionally
the code is written in a very non-obvious way. Factor out the lookup of
the disk into a function which also simplifies the callers.
Signed-off-by:
The function has no users now and there's no need for it as the common
pattern is to look up the whole disk object anyways.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 14 --
src/qemu/qemu_domain.h | 3 ---
2 files changed, 17 deletions(-)
diff --git
Avoid two computations by using a boolean.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_checkpoint.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c
index 2fa5c1ae00..d13d4c2a37 100644
---
Posted as RFC because qemu probably doesn't reopen backing images for
bitmap operations resulting in:
$ virsh checkpoint-delete vm --checkpointname a
error: Failed to delete checkpoint a
error: internal error: unable to execute QEMU command 'transaction': Bitmap
'a' is readonly and cannot be
qemuCheckpointDiscard is a massive function that can be separated into
smaller bits. Extract the part that actually modifies the disk from the
metadata handling.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_checkpoint.c | 137 -
1 file changed, 76
When debugging tests under GDB there is a significant time
delay each time an execve is done as GDB scans shared libraries
once again. For tests which use many mock libraries, we have
been invoking execve many times which makes the GDB experience
horrible. This changes our framework to activate
On Thu, Jan 09, 2020 at 03:53:13PM +0100, Pavel Hrdina wrote:
> We are in process of removing gnulib and adopting meson as our build
> system. In order to help with the transition let's drop gnulib tests.
>
> This will also help with the fact that before we will be able to drop
> gnulib
On Thu, Jan 09, 2020 at 03:53:12PM +0100, Pavel Hrdina wrote:
> We already use this function and so far we've been lucky that the same
> check is done by gnulib. This will change once we will drop gnulib and
> also make it obvious that we have to do the same check in Meson as well.
>
>
On Thu, Jan 09, 2020 at 03:53:11PM +0100, Pavel Hrdina wrote:
> The function virSecretGetSecretString calls into secret driver and is
> used from other hypervisros drivers and as such makes more sense in
> util.
s/hypervisros/hypervisors/
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|:
On 1/8/20 7:20 PM, Daniel P. Berrangé wrote:
bhyveargv2xmlmock calls virBhyveCapsBuild which in turn
calls virCPUProbeHost, probing the real host CPU. This
causes a test failure if the host CPU happens to contain
the 'arch-capabilities' feature as it triggers a call
to virHostCPUGetMSR() which
On 1/9/20 3:50 PM, Jiri Denemark wrote:
Commit v5.10.0-290-g3a4787a301 refactored qemuDomainGetHostdevPath to
return a single path rather than an array of paths. When the function is
called on a missing device, it will now return NULL in @path rather than
a NULL array with zero items and the
On 1/9/20 2:15 PM, Daniel P. Berrangé wrote:
On Wed, Jan 08, 2020 at 05:30:23PM +0100, Michal Privoznik wrote:
On 12/20/19 3:16 PM, Daniel P. Berrangé wrote:
Hm.. maybe I'm doing something wrong, but the following doesn't work for me.
Note, "fedora" is a VM with two disks:
Dear list,
QEMU gained support for configuring HMAT recently (see
v4.2.0-415-g9b12dfa03a
and friends). HMAT stands for Heterogeneous Memory Attribute Table and
defines
various attributes to NUMA. Guest OS/app can read these information and fine
tune optimization. See [1] for more info (esp.
On Thu, Jan 09, 2020 at 14:47:22 +, Martin Wilck wrote:
> On Thu, 2020-01-09 at 14:34 +, Daniel P. Berrangé wrote:
[...]
> >
> > - Run qemu-img rebase to set the backing_fmt
> >
> > or
> >
> > - Update the guest XML to set the format value
> >
> > or
> >
> > - Update the
On Thu, Jan 09, 2020 at 02:47:22PM +, Martin Wilck wrote:
> On Thu, 2020-01-09 at 14:34 +, Daniel P. Berrangé wrote:
> >
> > IIUC there are three scenarios at play here
> >
> > 1. qcow2 file, first level raw backing
> > 2. qcow2 file, first level qcow2 backing, no backing
> > 3.
On Wed, 2020-01-08 at 15:49 +, Daniel P. Berrangé wrote:
>
> I wonder if there's any scope for improving qemu-img here so that it
> can 'do the right thing', or at least issue a warning if the suer
> doesn't set a backing format.
Yes, someone should send a patch that would make qemu-img
On Thu, 2020-01-09 at 14:34 +, Daniel P. Berrangé wrote:
>
> IIUC there are three scenarios at play here
>
> 1. qcow2 file, first level raw backing
> 2. qcow2 file, first level qcow2 backing, no backing
> 3. qcow2 file, first level qcow2 backing, with second level backing
>
>
Running bootstrap and autoreconf from autogen.sh produced different
files in build-aux directory. The reason is that gnulib usually have
newer version of these files and overwrites them after the autoreconf
step.
In order to fix it remove the --install and --force options, in addition
introduce
This patch series is motivated by the effort to adopt Meson as our
build system but all of it improves the current build system on its own.
It moves the burden to run bootstrap/autoreconf to developers which
means it will save some time for others when there is any change to
the build system.
There is no need to run bootstrap every time a clean git checkout is
done as the result will be always the same. We only need to run it
when there is some change to gnulib modules or when we update to new
gnulib or there is a change to the build system. All of the steps
above are done as by
We already ignore most of these files and the .gitignore files as well.
Signed-off-by: Pavel Hrdina
---
.gitignore | 5 -
bootstrap.conf | 3 +++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/.gitignore b/.gitignore
index 2139d176da..949bd3bc5a 100644
--- a/.gitignore
Now that we have bootstrap output stored in git there is no need for
these options.
Signed-off-by: Pavel Hrdina
---
autogen.sh | 29 +++--
docs/compiling.html.in | 13 -
2 files changed, 3 insertions(+), 39 deletions(-)
diff --git a/autogen.sh
Signed-off-by: Pavel Hrdina
---
autogen.sh | 2 +-
bootstrap.conf | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/autogen.sh b/autogen.sh
index 9afad8f9d5..a119b099cb 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -147,7 +147,7 @@ if test -d .git || test -f .git; then
Signed-off-by: Pavel Hrdina
---
build-aux/syntax-check.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 7e7c59c3df..b2f4bf59f8 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -572,7 +572,7
We already use this function and so far we've been lucky that the same
check is done by gnulib. This will change once we will drop gnulib and
also make it obvious that we have to do the same check in Meson as well.
Signed-off-by: Pavel Hrdina
---
configure.ac | 1 +
1 file changed, 1
Signed-off-by: Pavel Hrdina
---
autogen.sh | 53 +++--
1 file changed, 15 insertions(+), 38 deletions(-)
diff --git a/autogen.sh b/autogen.sh
index 47446dc785..f20a61ed29 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -20,21 +20,11 @@ test -f
The function virSecretGetSecretString calls into secret driver and is
used from other hypervisros drivers and as such makes more sense in
util.
Signed-off-by: Pavel Hrdina
---
po/POTFILES.in | 1 -
src/libvirt_private.syms | 5 +-
We are in process of removing gnulib and adopting meson as our build
system. In order to help with the transition let's drop gnulib tests.
This will also help with the fact that before we will be able to drop
gnulib completely we will store output of bootstrap in git.
Signed-off-by: Pavel
The existence of AUTHORS file is required for GNU projects but since
commit <8bfb36db40f38e92823b657b5a342652064b5adc> we do not require
these files to exist.
Signed-off-by: Pavel Hrdina
---
autogen.sh | 2 +-
bootstrap.conf | 3 ---
2 files changed, 1 insertion(+), 4 deletions(-)
diff
Preparation for having bootstrap result in git.
Signed-off-by: Pavel Hrdina
---
bootstrap.conf | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index 13d0e77514..3798284dad 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -127,11 +127,7
Commit v5.10.0-290-g3a4787a301 refactored qemuDomainGetHostdevPath to
return a single path rather than an array of paths. When the function is
called on a missing device, it will now return NULL in @path rather than
a NULL array with zero items and the callers need to be adapted
properly.
On Thu, Jan 09, 2020 at 14:34:08 +, Daniel Berrange wrote:
> On Wed, Jan 08, 2020 at 03:46:59PM +0100, Peter Krempa wrote:
> > On Wed, Jan 08, 2020 at 13:34:14 +, Martin Wilck wrote:
> > > The recent change in libvirt to pass storage arguments to qemu via
> > > "-blockdev", explicity
Pushed under the Dockerfile update rule.
Andrea Bolognani (2):
Update openSUSE Leap 15.1 to install Meson from pip
Add openSUSE Leap 15.1 Dockerfile for libosinfo
buildenv-libosinfo-opensuse-151.zip | Bin 0 -> 570 bytes
buildenv-libvirt-opensuse-151.zip | Bin 761 -> 785 bytes
2 files
The corresponding libvirt-jenkins-ci commit is 732952acd532.
Signed-off-by: Andrea Bolognani
---
buildenv-libvirt-opensuse-151.zip | Bin 761 -> 785 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/buildenv-libvirt-opensuse-151.zip
b/buildenv-libvirt-opensuse-151.zip
index
The corresponding libvirt-jenkins-ci commit is c83eda1bc92d.
Signed-off-by: Andrea Bolognani
---
buildenv-libosinfo-opensuse-151.zip | Bin 0 -> 570 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
create mode 100644 buildenv-libosinfo-opensuse-151.zip
diff --git
On Wed, Jan 08, 2020 at 03:46:59PM +0100, Peter Krempa wrote:
> On Wed, Jan 08, 2020 at 13:34:14 +, Martin Wilck wrote:
> > The recent change in libvirt to pass storage arguments to qemu via
> > "-blockdev", explicity passing backing file chain information rather
> > than relying on qemu to
On Wed, Jan 08, 2020 at 05:30:23PM +0100, Michal Privoznik wrote:
> On 12/20/19 3:16 PM, Daniel P. Berrangé wrote:
> >
>
> Hm.. maybe I'm doing something wrong, but the following doesn't work for me.
> Note, "fedora" is a VM with two disks:
>
>
>
>
>
>
>
On 12/27/19 9:36 PM, Julio Faracco wrote:
There is a lots of possibilities to retrieve hostname information from
domain. Libvirt could use lease information from dnsmasq to get current
hostname too. QEMU supports QEMU-agent but it can use lease source. See
'domifaddr' as an example.
This commit
From: Julio Faracco
Our virsh already has 'domhostname' command. Add '--source'
argument to it so that users can chose between 'lease' and
'agent' sources. Also, implement completer for the argument.
Signed-off-by: Julio Faracco
Signed-off-by: Michal Privoznik
---
docs/manpages/virsh.rst
From: Julio Faracco
There is a lots of possibilities to retrieve hostname information
from domain. Libvirt could use lease information from dnsmasq to
get current hostname too. QEMU supports QEMU-agent but it can use
lease source.
Signed-off-by: Michal Privoznik
Signed-off-by: Julio Faracco
From: Julio Faracco
We have to keep the default - querying the agent if no flag is
set.
Signed-off-by: Michal Privoznik
Signed-off-by: Julio Faracco
---
src/qemu/qemu_driver.c | 125 +++--
1 file changed, 109 insertions(+), 16 deletions(-)
diff --git
In v5.0.0-rc1~94 we switched from one huge switch() to an array
for translating error numbers into error messages. However, the
array is declared to have VIR_ERR_NUMBER_LAST items which makes
it impossible to spot this place by compile checking when adding
new error number.
Signed-off-by: Michal
From: Julio Faracco
Since there is no guest agent in LXC world (yet), we can
implement _LEASE flag only.
Signed-off-by: Michal Privoznik
---
src/lxc/lxc_driver.c | 79
1 file changed, 79 insertions(+)
diff --git a/src/lxc/lxc_driver.c
v4 of:
https://www.redhat.com/archives/libvir-list/2019-December/msg01453.html
diff to v3:
- I've split Julio's one patch into 4 smaller ones,
- I've fixed issues I've raised in v3, like new error code (patch 1/5 is
completely new that's why I'm authoring it), fixed the completer and
some
On Thu, 2020-01-09 at 11:57 +0100, Fabiano Fidêncio wrote:
> Now that openSUSE 15.1 is a thing on libvirt-jenkins-ci, let's add all
> possible projects to the OS, doing the needed mappings adjustments
> whenever needed.
>
> Changes since v2:
>
On Thu, Jan 09, 2020 at 10:04:31AM +, Daniel P. Berrangé wrote:
> On Thu, Jan 09, 2020 at 09:16:30AM +0100, Pavel Hrdina wrote:
> > This patch series is motivated by the effort to adopt Meson as our
> > build system but all of it improves the current build system on its own.
> >
> > It moves
libvirt-tck and libvirt-cim could not be added due to missing packages.
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-opensuse-151/main.yml | 14 ++
guests/playbooks/build/projects/libvirt-dbus.yml | 1 +
.../playbooks/build/projects/libvirt-sandbox.yml | 1
On Thu, Jan 09, 2020 at 10:07:34AM +, Daniel P. Berrangé wrote:
> On Thu, Jan 09, 2020 at 09:16:34AM +0100, Pavel Hrdina wrote:
> > We use this module but we don't have explicit dependency on it.
> >
> > Signed-off-by: Pavel Hrdina
> > ---
> > bootstrap.conf | 2 ++
> > 1 file changed, 2
Between all the adjustments done, it's worth to mention that there's no
equivalent of perl-Time-HiRes packages on openSUSE as its already part
of the base perl packages and that perl-generators is a Fedora/RHEL-ism
used for RPM auto-dependencies (which is not present nor needed on
openSUSE).
The meson version present on openSUSE 15.1 is too old (0.46.0) to build
our projects, which require 0.49.0. Knowing that, meson from pip has to
be used.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mappings.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/guests/vars/mappings.yml
Now that openSUSE 15.1 is a thing on libvirt-jenkins-ci, let's add all
possible projects to the OS, doing the needed mappings adjustments
whenever needed.
Changes since v2:
https://www.redhat.com/archives/libvir-list/2020-January/msg00333.html
- Split meson change into its specific patch;
-
On Thu, Jan 09, 2020 at 09:16:34AM +0100, Pavel Hrdina wrote:
> We use this module but we don't have explicit dependency on it.
>
> Signed-off-by: Pavel Hrdina
> ---
> bootstrap.conf | 2 ++
> 1 file changed, 2 insertions(+)
GNULIB says
On Thu, Jan 09, 2020 at 09:16:30AM +0100, Pavel Hrdina wrote:
> This patch series is motivated by the effort to adopt Meson as our
> build system but all of it improves the current build system on its own.
>
> It moves the burden to run bootstrap/autoreconf to developers which
> means it will
On Thu, Jan 09, 2020 at 09:16:30AM +0100, Pavel Hrdina wrote:
> This patch series is motivated by the effort to adopt Meson as our
> build system but all of it improves the current build system on its own.
>
> It moves the burden to run bootstrap/autoreconf to developers which
> means it will
autogen.sh is no longer used in the build process, it will now serve
only as a script to regenerate files that are stored in git.
Signed-off-by: Pavel Hrdina
---
autogen.sh | 54 --
1 file changed, 54 deletions(-)
diff --git a/autogen.sh
Now that we have bootstrap output stored in git there is no need for
these options.
Signed-off-by: Pavel Hrdina
---
autogen.sh | 38 +++---
docs/compiling.html.in | 13 -
2 files changed, 3 insertions(+), 48 deletions(-)
diff --git
Signed-off-by: Pavel Hrdina
---
autogen.sh | 44 +---
1 file changed, 13 insertions(+), 31 deletions(-)
diff --git a/autogen.sh b/autogen.sh
index 49ca91bf64..78c4320af5 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -18,20 +18,10 @@ test -f src/libvirt.c ||
>From now on there is no need to run autogen.sh in order to build
libvirt from clean git checkout as the result of running autogen.sh
is stored in git.
Signed-off-by: Pavel Hrdina
---
.gitlab-ci.yml | 2 +-
.travis.yml| 4 ++--
README-hacking | 5 ++---
ci/build.sh
The existence of AUTHORS file is required for GNU projects but since
commit <8bfb36db40f38e92823b657b5a342652064b5adc> we do not require
these files to exist.
Signed-off-by: Pavel Hrdina
---
autogen.sh | 2 +-
bootstrap.conf | 3 ---
2 files changed, 1 insertion(+), 4 deletions(-)
diff
This patch series is motivated by the effort to adopt Meson as our
build system but all of it improves the current build system on its own.
It moves the burden to run bootstrap/autoreconf to developers which
means it will save some time for others when there is any change to
the build system.
Preparation for having bootstrap result in git.
Signed-off-by: Pavel Hrdina
---
bootstrap.conf | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index a302475198..7009d22681 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -129,11 +129,7
Running bootstrap and autoreconf from autogen.sh produced different
files in build-aux directory. The reason is that gnulib usually have
newer version of these files and overwrites them after the autoreconf
step.
In order to fix it remove the --install and --force options, in addition
introduce
As preparation to run configure directly when building libvirt.
Signed-off-by: Pavel Hrdina
---
autogen.sh | 22 --
configure.ac | 14 ++
docs/compiling.html.in | 2 +-
3 files changed, 19 insertions(+), 19 deletions(-)
diff --git
The function virSecretGetSecretString calls into secret driver and is
used from other hypervisros drivers and as such makes more sense in
util.
Signed-off-by: Pavel Hrdina
---
po/POTFILES.in | 1 -
src/libvirt_private.syms | 5 +-
Signed-off-by: Pavel Hrdina
---
build-aux/syntax-check.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 7e7c59c3df..b2f4bf59f8 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -572,7 +572,7
We already ignore most of these files and the .gitignore files as well.
Signed-off-by: Pavel Hrdina
---
.gitignore | 5 -
bootstrap.conf | 3 +++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/.gitignore b/.gitignore
index 2139d176da..949bd3bc5a 100644
--- a/.gitignore
Signed-off-by: Pavel Hrdina
---
autogen.sh | 2 +-
bootstrap.conf | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/autogen.sh b/autogen.sh
index 9afad8f9d5..a119b099cb 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -147,7 +147,7 @@ if test -d .git || test -f .git; then
We are in process of removing gnulib and adopting meson as our build
system. In order to help with the transition let's drop gnulib tests.
This will also help with the fact that before we will be able to drop
gnulib completely we will store output of bootstrap in git.
Signed-off-by: Pavel
We already use this function and so far we've been lucky that the same
check is done by gnulib. This will change once we will drop gnulib and
also make it obvious that we have to do the same check in Meson as well.
Signed-off-by: Pavel Hrdina
---
configure.ac | 1 +
1 file changed, 1
We use this module but we don't have explicit dependency on it.
Signed-off-by: Pavel Hrdina
---
bootstrap.conf | 2 ++
1 file changed, 2 insertions(+)
diff --git a/bootstrap.conf b/bootstrap.conf
index 13d0e77514..a302475198 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -84,6 +84,8 @@
1 - 100 of 107 matches
Mail list logo
