[libvirt PATCH 0/3] gitdm: Fixes and updates

blurb.com *** BLURB HERE ***, Inc. Andrea Bolognani (3): gitdm: Add entry for example.com gitdm: Fix sorting gitdm: Add missing entries docs/gitdm/companies/others| 5 - docs/gitdm/groups/unaffiliated | 5 + 2 files changed, 9 insertions(+), 1 deletion(-) -- 2.24.1

[libvirt PATCH 1/3] gitdm: Add entry for example.com

We already have one instance of it being used in our git history, and more are probably bound to show up eventually. Signed-off-by: Andrea Bolognani --- docs/gitdm/groups/unaffiliated | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/gitdm/groups/unaffiliated

[libvirt PATCH 3/3] gitdm: Add missing entries

A few new companies have contributed to libvirt since the last time the gitdm configuration was updated. Signed-off-by: Andrea Bolognani --- docs/gitdm/companies/others | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/gitdm/companies/others b/docs/gitdm/companies/others index

[libvirt PATCH 2/3] gitdm: Fix sorting

Fixes: 3a3a85c529e92ad767fbe01587186854c175 Signed-off-by: Andrea Bolognani --- docs/gitdm/companies/others | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/gitdm/companies/others b/docs/gitdm/companies/others index affbaf3ea2..bf35273f4a 100644 ---

Re: [PATCH] admin: use g_autofree

On Fri, Feb 28, 2020 at 11:46:40PM +0530, Gaurav Agrawal wrote: > From: GAURAV AGRAWAL > > Signed-off-by: Gaurav Agrawal > --- > src/admin/libvirt-admin.c | 15 +-- > 1 file changed, 5 insertions(+), 10 deletions(-) > > diff --git a/src/admin/libvirt-admin.c

Re: [PATCH 3/8] qemu-conf: add dbusStateDir

On 2/25/20 6:24 AM, Michal Privoznik wrote: On 2/24/20 4:57 PM, Marc-André Lureau wrote: Hi On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote: On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Location of DBus daemon state configuration, socket, pid...

[PATCH] admin: use g_autofree

From: GAURAV AGRAWAL Signed-off-by: Gaurav Agrawal --- src/admin/libvirt-admin.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/admin/libvirt-admin.c b/src/admin/libvirt-admin.c index 4099a54854..17d0eb39fe 100644 --- a/src/admin/libvirt-admin.c +++

[libvirt PATCH] news: Update for libvirt 6.1.0

Signed-off-by: Andrea Bolognani --- I probably won't be able to check my computer between now and the release, so if anyone gets a chance to review the patch in the meantime please feel free to push it as well :) docs/news.xml | 36 1 file changed, 36

Re: [PATCH] conf: Don't generate machine names with a dot

On 2/28/20 5:22 PM, Michal Privoznik wrote: According to the linked BZ, machined expects either valid hostname or valid FQDN. While in case of multiple dots, a trailing one doesn't violate FQDN, it does violate the rule in case of something simple, like "domain.". But it's safe to remove it in

[PATCH] conf: Don't generate machine names with a dot

According to the linked BZ, machined expects either valid hostname or valid FQDN. While in case of multiple dots, a trailing one doesn't violate FQDN, it does violate the rule in case of something simple, like "domain.". But it's safe to remove it in both cases. Resolves:

[PATCH 1/2] qemu_shim: Allow other users to enter the root dir

When virt-qemu-run is ran without any root directory specified on the command line, a temporary directory is made and used instead. But since we are using g_dir_make_tmp() to create the directory it is going to have 0700 mode. So even though we create the whole directory structure under it and

[PATCH 2/2] qemu_shim: Ignore SIGPIPE

I've found that if my virtlogd is socket activated but the daemon doesn't run yet, then the virt-qemu-run is killed right after it tries to start the domain. The problem is that because the default setting is to use virtlogd, the domain create code tries to connect to virtlogd socket, which in

[PATCH 0/2] qemu_shim: Two simple fixes

Actually, 2/2 suggests we need to tweak SELinux policy too. Should I file a bug? Michal Prívozník (2): qemu_shim: Allow other users to enter the root dir qemu_shim: Ignore SIGPIPE src/qemu/qemu_shim.c | 7 +++ 1 file changed, 7 insertions(+) -- 2.24.1

Re: [PATCH 3/8] qemu-conf: add dbusStateDir

Hi On Tue, Feb 25, 2020 at 12:24 PM Michal Privoznik wrote: > > On 2/24/20 4:57 PM, Marc-André Lureau wrote: > > Hi > > > > On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik > > wrote: > >> > >> On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote: > >>> From: Marc-André Lureau > >>> > >>>

[PATCH 1/8] qemu: capabilities: Add QEMU_CAPS_BLOCKDEV_REOPEN

This capability will be asserted once qemu stabilizes 'blockdev-reopen'. For now we just add the capability so that we can introduce some code that will use the reopening call. This will show our willingness to adopt use of reopen and help qemu developers stabilize it. Signed-off-by: Peter Krempa

[PATCH 7/8] qemuDomainBlockCopyCommon: Record updated flags to block job

For a long time we've masked out VIR_DOMAIN_BLOCK_COPY_SHALLOW if there's no backing chain for the copied disk to simplify the code. One of the refacors of caused that we no longer update the 'flags' variable just the local copies. This was okay until in ccd4228afff I started storing the job

[PATCH 8/8] qemu: blockcopy: Allow late opening of the backing chain of a shallow copy

oVirt used a quirk in the pre-blockdev semantics of drive-mirror which opened the backing chain of the mirror destination only once 'block-job-complete' was called. Our introduction of blockdev made qemu open the backing chain images right at the start of the job. This broke oVirt's usage of this

[PATCH 4/8] qemuCheckpointDiscardBitmaps: Reopen images for bitmap modifications

Qemu's bitmap APIs don't reopen the appropriate images read-write for modification. It's libvirt's duty to reopen them via blockdev-reopen if we wish to modify the bitmaps. Use the new helpers to reopen the images for bitmap manipulation. Signed-off-by: Peter Krempa ---

[PATCH 6/8] qemuDomainBlockPivot: Move check prior to executing the pivot steps

Move the check whether the job is already synchronised to the beginning of the function so that we don't try to do some of the steps necessary for pivoting prior to actually wanting to pivot. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 14 +++--- 1 file changed, 7

[PATCH 5/8] qemuCheckpointDiscardBitmaps: Use correct field for checkpoint bitmap name

The code deleting checkpoints needs the name of the parent checkpoint's disk's bitmap but was using the disk alias instead. This would create wrong bitmaps after deleting some checkpoints. Signed-off-by: Peter Krempa --- src/qemu/qemu_checkpoint.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 0/8] qemu: Show willingness to use blockdev-reopen

To break the chicken and egg problem loop between qemu and libvirt in using new features introduce experimental support for blockdev-reopen (or actually x-blockdev-reopen for the time being). This patchset adds QEMU_CAPS_BLOCKDEV_REOPEN capability which is currently not asserted until qemu

[PATCH 3/8] qemu: block: implement helpers for blockdev-reopen

Introduce a set of helpers to call blockdev-reopen in certain scenarios Libvirt will use the QMP command to turn certain members of the backing chain read-write for bitmap manipulation and we'll also want to use it to replace/install the backing chain of a qcow2 format node. Signed-off-by: Peter

[PATCH 2/8] qemu: monitor: Add handler for blockdev-reopen

Introduce the monitor code for using blockdev-reopen. For now we'll use x-blockdev-reopen so that the interactions between qemu and libvirt can be tested with the existing code. Since the usage will be guarded by the for-now unasserted capability we'll be able to change the called command when

Re: [PATCH 2/2] qemu: Tell secdrivers which images are top parent

On Thu, Feb 27, 2020 at 13:07:36 +0100, Michal Privoznik wrote: > When preparing images for block jobs we modify their seclabels so > that QEMU can open them. However, as mentioned in the previous > commit, secdrivers base some it their decisions whether the image > they are working on is top