From: Vladimir Sementsov-Ogievskiy
Firstly, _next_dirty_area is for scenarios when we may contiguously
search for next dirty area inside some limited region, so it is more
comfortable to specify "end" which should not be recalculated on each
iteration.
Secondly, let's add a possibility to limit
From: Vladimir Sementsov-Ogievskiy
Introduce NBDExtentArray class, to handle extents list creation in more
controlled way and with fewer OUT parameters in functions.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-id: 20200205112041.6003-9-vsement...@virtuozzo.com
From: Vladimir Sementsov-Ogievskiy
store_bitmap_data() loop does bdrv_set_dirty_iter() on each iteration,
which means that we actually don't need iterator itself and we can use
simpler bitmap API.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Reviewed-by: John Snow
From: Vladimir Sementsov-Ogievskiy
The function is definitely internal (it's not used by third party and
it has complicated interface). Move it to .c file.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Reviewed-by: John Snow
Message-id:
From: Vladimir Sementsov-Ogievskiy
Use bdrv_dirty_bitmap_next_dirty_area for bitmap_to_extents. Since
bdrv_dirty_bitmap_next_dirty_area is very accurate in its interface,
we'll never exceed requested region with last chunk. So, we don't need
dont_fragment, and bitmap_to_extents() interface
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Reviewed-by: John Snow
Message-id: 20200205112041.6003-5-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
include/qemu/hbitmap.h | 21
tests/test-hbitmap.c | 115
From: Vladimir Sementsov-Ogievskiy
We have bdrv_dirty_bitmap_next_zero, let's add corresponding
bdrv_dirty_bitmap_next_dirty, which is more comfortable to use than
bitmap iterators in some cases.
For test modify test_hbitmap_next_zero_check_range to check both
next_zero and next_dirty and add
From: Vladimir Sementsov-Ogievskiy
We have APIs which returns signed int64_t, to be able to return error.
Therefore we can't handle bitmaps with absolute size larger than
(INT64_MAX+1). Still, keep maximum to be INT64_MAX which is a bit
safer.
Note, that bitmaps are used to represent disk
From: Vladimir Sementsov-Ogievskiy
Function is internal and even commented as internal. Drop its
definition from .h file.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Reviewed-by: John Snow
Message-id: 20200205112041.6003-4-vsement...@virtuozzo.com
Signed-off-by: John
From: Vladimir Sementsov-Ogievskiy
We are going to introduce bdrv_dirty_bitmap_next_dirty so that same
variable may be used to store its return value and to be its parameter,
so it would int64_t.
Similarly, we are going to refactor hbitmap_next_dirty_area to use
hbitmap_next_dirty together with
The following changes since commit 6e8a73e911f066527e775e04b98f31ebd19db600:
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into
staging (2020-03-11 14:41:27 +)
are available in the Git repository at:
https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request
Please disregard this patch. There is a bug in the logic:
On 3/16/20 6:53 PM, Daniel Henrique Barboza wrote:
Commit 7b79ee2f78 makes assumptions about die_id parsing in
the sysfs that aren't true for Power hosts. In both Power8
and Power9 the die_id is set to -1:
[...]
---
Commit 7b79ee2f78 makes assumptions about die_id parsing in
the sysfs that aren't true for Power hosts. In both Power8
and Power9, running 5.6 and 4.18 kernel respectively,
'die_id' is set to -1:
$ cat /sys/devices/system/cpu/cpu0/topology/die_id
-1
This breaks virHostCPUGetDie() parsing because
changes in v2:
- fixed a logic flaw
- changed commit msg wording a bit
v1: https://www.redhat.com/archives/libvir-list/2020-March/msg00567.html
Daniel Henrique Barboza (1):
virhostcpu.c: fix 'die_id' parsing for Power hosts
src/util/virhostcpu.c | 21 ++---
1 file changed, 14
Commit 7b79ee2f78 makes assumptions about die_id parsing in
the sysfs that aren't true for Power hosts. In both Power8
and Power9 the die_id is set to -1:
$ cat /sys/devices/system/cpu/cpu0/topology/die_id
-1
This breaks the parsing being done in virHostCPUGetDie(),
which is using an uInt
On 2. 3. 2020 1:54, Julio Faracco wrote:
> This commit share host Real Time Clock device (rtc) into LXC containers
> to support hardware clock. This should be available setting up a `rtc`
> timer under clock section. Since this option is not emulated, it should
> be available only for `localtime`
On 2. 3. 2020 1:54, Julio Faracco wrote:
> This commit is related to RTC timer device too. HPET is being shared
> from host device through `localtime` clock. This timer is available
> creating a new timer using `hpet` name.
>
> Signed-off-by: Julio Faracco
> ---
> docs/formatdomain.html.in | 2
On a Monday in 2020, Gaurav Agrawal wrote:
Signed-off-by: Gaurav Agrawal
---
src/qemu/qemu_domain.c | 35 +++
src/qemu/qemu_domain.h | 5 +++--
src/qemu/qemu_process.c | 4 ++--
3 files changed, 24 insertions(+), 20 deletions(-)
Reviewed-by: Ján Tomko
and
On Mon, Mar 16, 2020 at 05:03:59PM +0100, Michal Prívozník wrote:
> On 13. 3. 2020 13:00, Daniel P. Berrangé wrote:
> > During startup the udev node device driver impl uses a background thread
> > to populate the list of devices to avoid blocking the daemon startup
> > entirely. There is no
On 13. 3. 2020 13:00, Daniel P. Berrangé wrote:
> During startup the udev node device driver impl uses a background thread
> to populate the list of devices to avoid blocking the daemon startup
> entirely. There is no synchronization to the public APIs, so it is
> possible for an application to
On Mon, Mar 16, 2020 at 04:15:10PM +0100, Peter Krempa wrote:
> On Mon, Mar 16, 2020 at 14:16:52 +, Daniel Berrange wrote:
> > Add sample data files for validating handling of a QEMU guest started
> > with:
> >
> > -smp 7,maxcpus=16,sockets=2,dies=2,cores=2,threads=2
> >
> > Signed-off-by:
On 10. 3. 2020 19:13, Daniel P. Berrangé wrote:
> The virNodeDevice{Reset,ReAttach,Dettach} methods are a little
> unusual because they are registered by the virt driver, but
> use the virNodeDevicePtr object associated with the nodedev
> driver.
>
> In the split daemon world, we tried to
On 10. 3. 2020 19:13, Daniel P. Berrangé wrote:
> Some of the node device APIs are a little odd because they accept a
> virNodeDevicePtr object but are still implemented by the virt drivers.
> The first thing the virt drivers need to do is get the XML config
> associated with the node device, and
On 10. 3. 2020 19:13, Daniel P. Berrangé wrote:
> The node device APIs are a little unusual because we don't use a
> "remote_nonnull_node_device" object on the wire, instead we just
> have a "remote_string" for the device name. This meant dispatcher
> code generation needed special cases. In doing
On Mon, Mar 16, 2020 at 14:16:52 +, Daniel Berrange wrote:
> Add sample data files for validating handling of a QEMU guest started
> with:
>
> -smp 7,maxcpus=16,sockets=2,dies=2,cores=2,threads=2
>
> Signed-off-by: Daniel P. Berrangé
> ---
> ...qemumonitorjson-cpuinfo-x86-dies-cpus.json
On Mon, Mar 16, 2020 at 01:06:47PM +, Daniel P. Berrangé wrote:
> On Mon, Mar 16, 2020 at 09:53:13AM +0100, Peter Krempa wrote:
> > On Fri, Mar 13, 2020 at 16:46:16 +, Daniel Berrange wrote:
> > > The logic for querying hotpluggable CPUs needs to sort the list
> > > of CPUs returned by
Add sample data files for validating handling of a QEMU guest started
with:
-smp 7,maxcpus=16,sockets=2,dies=2,cores=2,threads=2
Signed-off-by: Daniel P. Berrangé
---
...qemumonitorjson-cpuinfo-x86-dies-cpus.json | 95 ++
...umonitorjson-cpuinfo-x86-dies-hotplug.json | 171
On Mon, Mar 16, 2020 at 09:53:13AM +0100, Peter Krempa wrote:
> On Fri, Mar 13, 2020 at 16:46:16 +, Daniel Berrange wrote:
> > The logic for querying hotpluggable CPUs needs to sort the list
> > of CPUs returned by QEMU. Unfortunately our sorting method failed
> > to use the die_id field, so
On a Monday in 2020, Peter Krempa wrote:
Use g_autoptr instead.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 26 +-
1 file changed, 9 insertions(+), 17 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Monday in 2020, Peter Krempa wrote:
Return 0 on success as per documentation and due to the fact that
callers don't check the value.
-EPARSE
Return 0 on success to match the documentation.
The callers only check for negative values.
Signed-off-by: Peter Krempa
---
On a Monday in 2020, Peter Krempa wrote:
In some cases we don't want to log errors if an agent command is
unsupported. Wire it up into qemuAgentCheckError via qemuAgentCommandFull
and provide a thin wrapper (qemuAgentCommand) to prevent having to fix
all callers.
Signed-off-by: Peter Krempa
On a Monday in 2020, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
Signed-off-by: Gaurav Agrawal
---
src/qemu/qemu_domain.c | 35 +++
src/qemu/qemu_domain.h | 5 +++--
src/qemu/qemu_process.c | 4 ++--
3 files changed, 24 insertions(+), 20 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
On a Monday in 2020, Peter Krempa wrote:
'qemuDomainGetGuestInfoCheckSupport' despite it's name was not checking
its
whether the info types are supported. Convert the function to return
integers and include the check.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 30
On a Monday in 2020, Peter Krempa wrote:
Don't rely on error check and assign hostname only when non-NULL.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP
On a Monday in 2020, Peter Krempa wrote:
As requested in:
https://www.redhat.com/archives/libvir-list/2020-March/msg00377.html
this is an incremental refactor of qemuDomainSecretAESSetup. Posted only
as an individual refactor to omit re-sending the 26 other patches from
the original series.
On a Thursday in 2020, Jiri Denemark wrote:
See patch 3/3 for explanation.
Jiri Denemark (3):
cpu: Change control flow in virCPUUpdateLive
cpu_x86: Prepare virCPUx86UpdateLive for easier extension
cpu: Honor check='full' for host-passthrough CPUs
src/cpu/cpu.c | 12 +++-
On a Saturday in 2020, Gaurav Agrawal wrote:
---
As mentioned in our contributor guidelines (number 6. in general tips):
https://libvirt.org/hacking.html
we require a sign-off line with your legal name and e-mail address
that tells us that we can legally use the patch you send us:
Rather than passing in an empty qemuDomainSecretInfoPtr allocate it
in this function and return it. This is done by absorbing the check from
qemuDomainSecretInfoNew and removing the internals of
qemuDomainSecretInfoNew.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 53
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
index 835321f54d..ad7ed3b9f0 100644
--- a/src/qemu/qemu_domain.h
+++ b/src/qemu/qemu_domain.h
@@ -1042,6 +1042,8 @@ bool
Use g_autofree for the ciphertext and init vector as they are not
secret and thus don't have to be cleared and use g_new0 to allocate the
iv for parity.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git
Replace it by a direct call to qemuDomainSecretAESSetupFromSecret.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 53 +++---
1 file changed, 13 insertions(+), 40 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
Split out the lookup of the secret from the secret driver into
qemuDomainSecretAESSetupFromSecret so that we can also instantiate
secret objects in qemu with data from other sources.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 87 ++
1 file
As requested in:
https://www.redhat.com/archives/libvir-list/2020-March/msg00377.html
this is an incremental refactor of qemuDomainSecretAESSetup. Posted only
as an individual refactor to omit re-sending the 26 other patches from
the original series.
Peter Krempa (5):
qemuDomainSecretInfo:
On 13. 3. 2020 18:48, Daniel Henrique Barboza wrote:
> POWER hosts does not implement CPU virtualization extensions like
> x86 or s390x. Instead, all bare-metal POWER hosts are considered
> to be virtualization ready.
>
> For POWER, the validation is done by checking if the virtualization
>
ping
On 03.03.2020 11:19, Nikolay Shirokovskiy wrote:
> Nikolay Shirokovskiy (8):
> qemu: remove duplicate code for removing remnant files
> qemu: qemuDomainRenameCallback: fix sending false undefined event
> qemu: rename: support renaming snapshots directory
> qemu: rename: support
On Fri, Mar 13, 2020 at 16:46:16 +, Daniel Berrange wrote:
> The logic for querying hotpluggable CPUs needs to sort the list
> of CPUs returned by QEMU. Unfortunately our sorting method failed
> to use the die_id field, so CPUs were not correctly sorted.
>
> This is seen when configuring a
Don't report cases when the guest information is not requested
explicitly and not present either.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 45 +++---
1 file changed, 20 insertions(+), 25 deletions(-)
diff --git a/src/qemu/qemu_driver.c
Use qemuAgentCommandFull so that callers of qemuAgentGetFSInfo can
suppress error reports if the function is not supported by the guest
agent.
Since this patch removes the last use of
qemuAgentErrorCommandUnsupported the whole function is deleted as well.
Signed-off-by: Peter Krempa
---
Use qemuAgentCommandFull so that callers of qemuAgentGetOSInfo can
suppress error reports if the function is not supported by the guest
agent.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 17 +
src/qemu/qemu_agent.h | 3 ++-
src/qemu/qemu_driver.c | 2 +-
Use qemuAgentCommandFull so that callers of qemuAgentGetUsers can
suppress error reports if the function is not supported by the guest
agent.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 17 +
src/qemu/qemu_agent.h | 3 ++-
src/qemu/qemu_driver.c | 2 +-
Use g_autoptr instead.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 26 +-
1 file changed, 9 insertions(+), 17 deletions(-)
diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index c55b989467..07aba2b45d 100644
--- a/src/qemu/qemu_agent.c
+++
In some cases we don't want to log errors if an agent command is
unsupported. Wire it up into qemuAgentCheckError via qemuAgentCommandFull
and provide a thin wrapper (qemuAgentCommand) to prevent having to fix
all callers.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 45
Use qemuAgentCommandFull so that callers of qemuAgentGetTimezone can
suppress error reports if the function is not supported by the guest
agent.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 17 +
src/qemu/qemu_agent.h | 3 ++-
src/qemu/qemu_driver.c | 2 +-
Use qemuAgentCommandFull in qemuAgentGetHostname so that we can suppress
error reports if the caller will not require them. Callers for now
always require error reporting but will be fixed later.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 22 +++---
Don't rely on error check and assign hostname only when non-NULL.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 641a90d595..241513705d 100644
---
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index 9ea2c59563..8790c47b87 100644
--- a/src/qemu/qemu_agent.c
+++ b/src/qemu/qemu_agent.c
@@ -1055,8 +1055,8 @@
This fixes other issues pointed out in the review of my previous fix for
crash in qemuDomainGetGuestInfo.
Peter Krempa (12):
qemuDomainGetGuestInfo: don't assign NULL hostname
qemuDomainGetGuestInfo: Validate supported information types
qemuAgentCheckError: use g_autofree
'qemuDomainGetGuestInfoCheckSupport' despite it's name was not checking
whether the info types are supported. Convert the function to return
integers and include the check.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 30 ++
1 file changed, 22
Return 0 on success as per documentation and due to the fact that
callers don't check the value.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index bc5d57ab94..c55b989467
60 matches
Mail list logo
