Re:Re: what a correct use for virConnectDomainEventRegisterAny API, how to Obtain a stable expected result

2020-04-14 Thread thomas.kuang
Daniel, thanks for your help. If it cannot receive a stable expected callback, it need a timer to handle the timeout, in the timer timeout to release memory passed to virConnectDomainEventRegisterAny or, maybe memory-leak now ... At 2020-04-14 18:00:49, "Daniel P. Berrangé" wrote: >On

Re: [PATCH] libxl: enable Xen's e820_host setting

2020-04-14 Thread Jim Fehlig
On 4/14/20 4:07 PM, Marek Marczykowski-Górecki wrote: On Tue, Apr 14, 2020 at 03:56:47PM -0600, Jim Fehlig wrote: On 4/13/20 1:17 PM, Marek Marczykowski-Górecki wrote: FWIW, in Qubes we have a patches adding e820_host setting here: https://github.com/QubesOS/qubes-core-libvirt/ (patches 8-11)

Re: [PATCH] libxl: enable Xen's e820_host setting

2020-04-14 Thread Marek Marczykowski-Górecki
On Tue, Apr 14, 2020 at 03:56:47PM -0600, Jim Fehlig wrote: > On 4/13/20 1:17 PM, Marek Marczykowski-Górecki wrote: > > FWIW, in Qubes we have a patches adding e820_host setting here: > > https://github.com/QubesOS/qubes-core-libvirt/ > > (patches 8-11) > > Not submitted before, exactly to avoid

Re: [PATCH v2 1/4] conf: add xen specific feature: e820_host

2020-04-14 Thread Jim Fehlig
On 4/13/20 8:37 PM, Marek Marczykowski-Górecki wrote: e820_host is a Xen-specific option, only available for PV domains, that provides the domain a virtual e820 memory map based on the host one. It is required when using PCI passthrough and is generally considered safe for any PV kernel.

Re: [PATCH] libxl: enable Xen's e820_host setting

2020-04-14 Thread Jim Fehlig
On 4/13/20 1:17 PM, Marek Marczykowski-Górecki wrote: FWIW, in Qubes we have a patches adding e820_host setting here: https://github.com/QubesOS/qubes-core-libvirt/ (patches 8-11) Not submitted before, exactly to avoid adding temporary options. But since 8+ years later it is still there, I think

Re: [PATCH 1/2] docs: backup: Remove references to push backup to network disk

2020-04-14 Thread Eric Blake
On 4/14/20 2:06 PM, Peter Krempa wrote: On Tue, Apr 14, 2020 at 12:36:56 -0500, Eric Blake wrote: On 4/14/20 4:22 AM, Peter Krempa wrote: It was never implemented and for now I don't think there's demand to do it. Remove the reference. https://bugzilla.redhat.com/show_bug.cgi?id=1812100

Re: [libvirt PATCH] docs: Add pci-addresses.rst

2020-04-14 Thread Laine Stump
On 4/14/20 1:53 PM, Andrea Bolognani wrote: This document describes the relationship between PCI addresses as seen in the domain XML and by the guest OS, which is a topic that people get confused by time and time again. Signed-off-by: Andrea Bolognani --- docs/formatdomain.html.in | 6 +-

Re: [PATCH 1/2] docs: backup: Remove references to push backup to network disk

2020-04-14 Thread Peter Krempa
On Tue, Apr 14, 2020 at 12:36:56 -0500, Eric Blake wrote: > On 4/14/20 4:22 AM, Peter Krempa wrote: > > It was never implemented and for now I don't think there's demand to do > > it. Remove the reference. > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1812100 > > > > Signed-off-by: Peter

Re: [RFC] Adding docker driver to libvirt

2020-04-14 Thread Andrea Bolognani
On Tue, 2020-04-14 at 18:34 +0200, Martin Kletzander wrote: > On Tue, Apr 14, 2020 at 09:56:24AM +0300, nshirokovskiy wrote: > > We wanted to add Windows containers to the libvirt API. They are available > > under docker API thus the idea to add a docker driver. The docker itself > > uses some API

[libvirt PATCH] docs: Add pci-addresses.rst

2020-04-14 Thread Andrea Bolognani
This document describes the relationship between PCI addresses as seen in the domain XML and by the guest OS, which is a topic that people get confused by time and time again. Signed-off-by: Andrea Bolognani --- docs/formatdomain.html.in | 6 +- docs/pci-addresses.rst| 184

Re: [libvirt PATCH 0/2] gitlab: Clean up and improve ccache usage

2020-04-14 Thread Andrea Bolognani
On Mon, 2020-03-30 at 19:31 +0200, Andrea Bolognani wrote: > Test pipeline: https://gitlab.com/abologna/libvirt/pipelines/131128028 > > Andrea Bolognani (2): > gitlab: Don't define $MAKE > gitlab: Enable improved ccache usage > > .gitlab-ci.yml | 13 - > 1 file changed, 4

Re: [PATCH 1/2] docs: backup: Remove references to push backup to network disk

2020-04-14 Thread Eric Blake
On 4/14/20 4:22 AM, Peter Krempa wrote: It was never implemented and for now I don't think there's demand to do it. Remove the reference. https://bugzilla.redhat.com/show_bug.cgi?id=1812100 Signed-off-by: Peter Krempa --- docs/formatbackup.html.in | 7 +++ 1 file changed, 3

Re: [PATCH 02/43] bhyve: convert virMutex to GMutex

2020-04-14 Thread Rafael Fonseca
On Tue, Apr 14, 2020 at 6:06 PM Pavel Mores wrote: > > By the way, the approach taken here with bhyveDriver{Lock,Unlock}() might make > sense with the whole series - implement e.g. virMutexInit() in terms of > g_mutex_init() in the first phase and only then replace the actual > virMutexInit()

Re: [PATCH 20/43] network: bridge_driver: convert virMutex to GMutex

2020-04-14 Thread Pavel Mores
On Fri, Apr 10, 2020 at 03:54:47PM +0200, Rafael Fonseca wrote: > Signed-off-by: Rafael Fonseca > --- > src/network/bridge_driver.c | 11 --- > src/network/bridge_driver_platform.h | 2 +- > 2 files changed, 5 insertions(+), 8 deletions(-) > > diff --git

Re: [PATCH 06/43] util: virtpm: convert virMutex to GMutex

2020-04-14 Thread Pavel Mores
On Fri, Apr 10, 2020 at 03:54:33PM +0200, Rafael Fonseca wrote: > Signed-off-by: Rafael Fonseca > --- > src/util/virtpm.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/src/util/virtpm.c b/src/util/virtpm.c > index c734bf941a..5fd6396f2f 100644 > ---

Re: [PATCH 04/43] conf: virchrdev: convert virMutex to GMutex

2020-04-14 Thread Pavel Mores
On Fri, Apr 10, 2020 at 03:54:31PM +0200, Rafael Fonseca wrote: > Signed-off-by: Rafael Fonseca > --- > src/conf/virchrdev.c | 27 +++ > 1 file changed, 7 insertions(+), 20 deletions(-) > > diff --git a/src/conf/virchrdev.c b/src/conf/virchrdev.c > index

Re: [RFC] Adding docker driver to libvirt

2020-04-14 Thread Martin Kletzander
On Tue, Apr 14, 2020 at 09:56:24AM +0300, nshirokovskiy wrote: On 12.04.2020 12:39, Martin Kletzander wrote: On Thu, Apr 09, 2020 at 03:30:11PM +0300, nshirokovskiy wrote: Hi, all. Does it make sense to add such a driver? I can't say I have a big picture of docker functionality in mind but

Re: [PATCH 02/43] bhyve: convert virMutex to GMutex

2020-04-14 Thread Pavel Mores
On Fri, Apr 10, 2020 at 03:54:29PM +0200, Rafael Fonseca wrote: > Signed-off-by: Rafael Fonseca > --- > src/bhyve/bhyve_driver.c | 11 --- > src/bhyve/bhyve_utils.h | 2 +- > 2 files changed, 5 insertions(+), 8 deletions(-) > > diff --git a/src/bhyve/bhyve_driver.c

Re: [PATCH 01/43] admin: convert virMutex to GMutex

2020-04-14 Thread Pavel Mores
On Fri, Apr 10, 2020 at 03:54:28PM +0200, Rafael Fonseca wrote: > Signed-off-by: Rafael Fonseca > --- > src/admin/admin_server_dispatch.c | 13 - > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/src/admin/admin_server_dispatch.c >

Re: [PATCH 2/2] backup: Allow 'encryption' of backups and scratch images

2020-04-14 Thread Erik Skultety
On Tue, Apr 14, 2020 at 11:22:44AM +0200, Peter Krempa wrote: > Add the appropriate entries into the schema to allow encryption of the > backup or scratch image. Since we use blockdev internals for everything > no changes to the code are actually necessary. > >

Re: [PATCH 0/2] backup: Fix docs and add schema for LUKS encrypted backups

2020-04-14 Thread Ján Tomko
On a Tuesday in 2020, Peter Krempa wrote: Peter Krempa (2): docs: backup: Remove references to push backup to network disk backup: Allow 'encryption' of backups and scratch images docs/formatbackup.html.in | 19 -- docs/schemas/domainbackup.rng | 65

Re: [libvirt PATCH] README: rewrite in rst

2020-04-14 Thread Michal Privoznik
On 4/14/20 11:11 AM, Ján Tomko wrote: Signed-off-by: Ján Tomko --- README | 2 +- README.md => README.rst | 53 + 2 files changed, 28 insertions(+), 27 deletions(-) rename README.md => README.rst (65%) Reviewed-by: Michal

[libvirt PATCH] README: Add GitLab CI badge

2020-04-14 Thread Andrea Bolognani
We've moved most of our CI jobs to GitLab, so we should display the corresponding badge prominently. Signed-off-by: Andrea Bolognani --- README.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.rst b/README.rst index 080352ac77..cdcc97b5b2 100644 --- a/README.rst +++

Re: [libvirt PATCH] Convert all remaining Markdown files to reStructuredText

2020-04-14 Thread Andrea Bolognani
On Tue, 2020-04-14 at 15:59 +0200, Ján Tomko wrote: > On a Tuesday in 2020, Andrea Bolognani wrote: > > -``` > > -$ mkdir build && cd build > > -$ ../configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var > > -$ make > > -$ sudo make install > > -``` > > +:: > > Side question: > Are we

Re: [libvirt PATCH] Convert all remaining Markdown files to reStructuredText

2020-04-14 Thread Ján Tomko
On a Tuesday in 2020, Andrea Bolognani wrote: We've adopted reStructuredText as the primary markup language for our documentation and, given that both GitLab and GitHub can render documents in this format just fine, it makes sense to get rid of the few last remaining bits of Markdown and

Re: [libvirt PATCH] Convert all remaining Markdown files to reStructuredText

2020-04-14 Thread Ján Tomko
On a Tuesday in 2020, Andrea Bolognani wrote: On Tue, 2020-04-14 at 13:52 +0200, Andrea Bolognani wrote: +++ b/README.rst @@ -1,6 +1,9 @@ -[![Build Status](https://travis-ci.org/libvirt/libvirt.svg)](https://travis-ci.org/libvirt/libvirt) - [![CII Best

Re: [PATCH 2/2] conf: Don't format http cookies unless VIR_DOMAIN_DEF_FORMAT_SECURE is used

2020-04-14 Thread Erik Skultety
On Tue, Apr 14, 2020 at 10:38:48AM +0200, Peter Krempa wrote: > Starting from 3b076391befc3fe72deb0c244ac6c2b4c100b410 s/from/with > (v6.1.0-122-g3b076391be) we support http cookies. Since they may contain > somewhat sensitive information we should not format into the XML unless s/format/format

Re: [PATCH 0/2] Fix formatting of http cookies into XML

2020-04-14 Thread Erik Skultety
On Tue, Apr 14, 2020 at 10:38:46AM +0200, Peter Krempa wrote: > See 2/2. > > Peter Krempa (2): > virstoragetest: testBackingParse: Use VIR_DOMAIN_DEF_FORMAT_SECURE > when formatting xml > conf: Don't format http cookies unless VIR_DOMAIN_DEF_FORMAT_SECURE is > used > >

Re: [libvirt PATCH] Convert all remaining Markdown files to reStructuredText

2020-04-14 Thread Andrea Bolognani
On Tue, 2020-04-14 at 13:52 +0200, Andrea Bolognani wrote: > +++ b/README.rst > @@ -1,6 +1,9 @@ > -[![Build > Status](https://travis-ci.org/libvirt/libvirt.svg)](https://travis-ci.org/libvirt/libvirt) > - [![CII Best >

Re: libvirt python console

2020-04-14 Thread Michal Privoznik
On 4/12/20 7:18 PM, PunkGeek wrote: Hello, I see this example about VM console serial, Which I could connect to the guest VM successfully. however, I could not understand how to send commands to the guest VM? https://github.com/libvirt/libvirt-python/blob/master/examples/consolecallback.py

Re: Wiki page audit - possible page deleteion

2020-04-14 Thread Michal Privoznik
On 4/9/20 12:10 PM, Daniel P. Berrangé wrote: On Wed, Apr 08, 2020 at 04:45:46PM +0100, Daniel P. Berrangé wrote: Various GSoC pages, the per-year pages, and for 2016 only some reports from the contributors. Most of the latter is outdated info that's no longer really relevant, so I'd

[libvirt PATCH] CONTRIBUTING: Include in release archives

2020-04-14 Thread Andrea Bolognani
The file, added with commit commit 874952f80c6d68c1a7a75e71c11a576f96f75dc2 Author: Andrea Bolognani Date: Mon Apr 6 11:56:58 2020 +0200 CONTRIBUTING: Add entry point for new contributors should be included in release archives. Signed-off-by: Andrea Bolognani --- Makefile.am | 1

[libvirt PATCH] Convert all remaining Markdown files to reStructuredText

2020-04-14 Thread Andrea Bolognani
We've adopted reStructuredText as the primary markup language for our documentation and, given that both GitLab and GitHub can render documents in this format just fine, it makes sense to get rid of the few last remaining bits of Markdown and standardize on reStructuredText across the board.

Re: [PATCH] libvirt-stream.c: Use g_autofree

2020-04-14 Thread Erik Skultety
On Mon, Apr 13, 2020 at 06:19:26PM +0530, Seeteena Thoufeek wrote: > Signed-off-by: Seeteena Thoufeek > --- Reviewed-by: Erik Skultety

Re: [libvirt PATCH 1/2] CONTRIBUTING: Add entry point for new contributors

2020-04-14 Thread Andrea Bolognani
On Tue, 2020-04-14 at 10:14 +0200, Ján Tomko wrote: > On a Monday in 2020, Andrea Bolognani wrote: > > diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md > > new file mode 100644 > > index 00..a8551965bd > > --- /dev/null > > +++ b/CONTRIBUTING.md > > s/md/rst/ Good point. I've verified

Re: [libvirt-jenkins-ci PATCH v3 4/5] guests: Introduce the new 'gitlab' flavor

2020-04-14 Thread Erik Skultety
On Tue, Apr 14, 2020 at 12:31:26PM +0200, Andrea Bolognani wrote: > On Tue, 2020-04-14 at 10:17 +0200, Erik Skultety wrote: > > On Thu, Apr 09, 2020 at 12:28:50PM +0200, Andrea Bolognani wrote: > > > On Thu, 2020-04-09 at 06:23 +0200, Erik Skultety wrote: > > > > +++

Re: [libvirt PATCH 2/3] travis: Reduce test matrix

2020-04-14 Thread Andrea Bolognani
On Tue, 2020-04-14 at 10:54 +0100, Daniel P. Berrangé wrote: > On Fri, Apr 10, 2020 at 11:10:33AM +0200, Andrea Bolognani wrote: > > The xcode10.3 build has recently started failing because of issues > > that are not in libvirt, so get rid of it. It didn't buy us > > additionaly platform coverage

Re: [PATCH ocaml 1/1] Add dune build system

2020-04-14 Thread Richard W.M. Jones
On Tue, Apr 14, 2020 at 12:22:49PM +0200, Pino Toscano wrote: > Introduce the dune build system to build ocaml-libvirt, providing > everything that the current autoconf-based build system has. > > Add also an opam configuration files, as it is mandatory with dune. > > Signed-off-by: Pino Toscano

Re: [libvirt-jenkins-ci PATCH v3 4/5] guests: Introduce the new 'gitlab' flavor

2020-04-14 Thread Andrea Bolognani
On Tue, 2020-04-14 at 10:17 +0200, Erik Skultety wrote: > On Thu, Apr 09, 2020 at 12:28:50PM +0200, Andrea Bolognani wrote: > > On Thu, 2020-04-09 at 06:23 +0200, Erik Skultety wrote: > > > +++ b/guests/playbooks/update/tasks/gitlab.yml > > > +- name: Make {{ gitlab_runner_config_dir }} world

[PATCH ocaml 0/1] RFC: add/switch to dune build system

2020-04-14 Thread Pino Toscano
ocaml-libvirt is currently built using manually written makefiles, and an autoconf script to detect libvirt (using pkg-config). While this seems OK, it has a lot of downsides: - all the OCaml rules are manually written - there is some form of duplication in the OCaml rules - the bytecode vs native

[PATCH ocaml 1/1] Add dune build system

2020-04-14 Thread Pino Toscano
Introduce the dune build system to build ocaml-libvirt, providing everything that the current autoconf-based build system has. Add also an opam configuration files, as it is mandatory with dune. Signed-off-by: Pino Toscano --- .gitignore | 3 +++ dune | 18

Re: [libvirt PATCH 2/3] travis: Reduce test matrix

2020-04-14 Thread Daniel P . Berrangé
On Tue, Apr 14, 2020 at 10:54:16AM +0100, Daniel P. Berrangé wrote: > On Fri, Apr 10, 2020 at 11:10:33AM +0200, Andrea Bolognani wrote: > > The xcode10.3 build has recently started failing because of issues > > that are not in libvirt, so get rid of it. It didn't buy us > > additionaly platform

Re: what a correct use for virConnectDomainEventRegisterAny API, how to Obtain a stable expected result

2020-04-14 Thread Daniel P . Berrangé
On Mon, Apr 13, 2020 at 05:32:38PM +0800, thomas.kuang wrote: > HI, everyone: > > > My target deal with network hotplug use virDomainDetachDeviceFlags. Because > when the API return ,the network maybe doesn’t remove from my vm guest os. > > So I use virConnectDomainEventRegisterAny to

libvirt python console

2020-04-14 Thread PunkGeek
Hello, I see this example about VM console serial, Which I could connect to the guest VM successfully. however, I could not understand how to send commands to the guest VM? https://github.com/libvirt/libvirt-python/blob/master/examples/consolecallback.py Best regards

Re: [libvirt PATCH 3/3] travis: Remove usage of 'sudo'

2020-04-14 Thread Daniel P . Berrangé
On Fri, Apr 10, 2020 at 11:10:34AM +0200, Andrea Bolognani wrote: > Travis CI reports > > root: deprecated key sudo (The key `sudo` has no effect anymore.) > > so let's drop it. > > Signed-off-by: Andrea Bolognani > --- > .travis.yml | 1 - > 1 file changed, 1 deletion(-) Reviewed-by:

Re: [libvirt PATCH 1/3] travis: Deduplicate build instructions

2020-04-14 Thread Daniel P . Berrangé
On Fri, Apr 10, 2020 at 11:10:32AM +0200, Andrea Bolognani wrote: > All information, except for osx_image image, is identical between > the two jobs so we can avoid repeating it. > > Signed-off-by: Andrea Bolognani > --- > .travis.yml | 51 --- >

Re: [libvirt PATCH 2/3] travis: Reduce test matrix

2020-04-14 Thread Daniel P . Berrangé
On Fri, Apr 10, 2020 at 11:10:33AM +0200, Andrea Bolognani wrote: > The xcode10.3 build has recently started failing because of issues > that are not in libvirt, so get rid of it. It didn't buy us > additionaly platform coverage anyway, since underneath it's using > the same macOS 10.14 version as

Re: [PATCH] driver.c: Use g_autofree

2020-04-14 Thread Erik Skultety
On Mon, Apr 13, 2020 at 06:18:57PM +0530, Seeteena Thoufeek wrote: > This is the only instance of g_autofree change applicable for > driver.c I'd say something like: "This is the last missing g_autofree change to convert the module after commit 1e2ae2e311c took care of the VIR_AUTOFREE

[PATCH] qemu: Revoke access to mirror on failed blockcopy

2020-04-14 Thread Michal Privoznik
When preparing to do a blockcopy, the mirror image is modified so that QEMU can access it. For instance, the mirror has seclabels set, if it is a NVMe disk it is detached from the host and so on. And usually, the restore is done upon successful finish of the blockcopy operation. But, if something

[PATCH 0/2] backup: Fix docs and add schema for LUKS encrypted backups

2020-04-14 Thread Peter Krempa
Peter Krempa (2): docs: backup: Remove references to push backup to network disk backup: Allow 'encryption' of backups and scratch images docs/formatbackup.html.in | 19 -- docs/schemas/domainbackup.rng | 65 +++

[PATCH 1/2] docs: backup: Remove references to push backup to network disk

2020-04-14 Thread Peter Krempa
It was never implemented and for now I don't think there's demand to do it. Remove the reference. https://bugzilla.redhat.com/show_bug.cgi?id=1812100 Signed-off-by: Peter Krempa --- docs/formatbackup.html.in | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 2/2] backup: Allow 'encryption' of backups and scratch images

2020-04-14 Thread Peter Krempa
Add the appropriate entries into the schema to allow encryption of the backup or scratch image. Since we use blockdev internals for everything no changes to the code are actually necessary. https://bugzilla.redhat.com/show_bug.cgi?id=1811906 Signed-off-by: Peter Krempa ---

[libvirt PATCH] README: rewrite in rst

2020-04-14 Thread Ján Tomko
Signed-off-by: Ján Tomko --- README | 2 +- README.md => README.rst | 53 + 2 files changed, 28 insertions(+), 27 deletions(-) rename README.md => README.rst (65%) diff --git a/README b/README index 42061c01a1..92cacd2853 12 ---

[PATCH 0/2] Fix formatting of http cookies into XML

2020-04-14 Thread Peter Krempa
See 2/2. Peter Krempa (2): virstoragetest: testBackingParse: Use VIR_DOMAIN_DEF_FORMAT_SECURE when formatting xml conf: Don't format http cookies unless VIR_DOMAIN_DEF_FORMAT_SECURE is used src/conf/domain_conf.c | 8 ++-- tests/virstoragetest.c | 3 ++- 2 files changed, 8

[PATCH 1/2] virstoragetest: testBackingParse: Use VIR_DOMAIN_DEF_FORMAT_SECURE when formatting xml

2020-04-14 Thread Peter Krempa
We want to format even the secure information in tests. Signed-off-by: Peter Krempa --- tests/virstoragetest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index 6e8ebeba13..6d2b21c25f 100644 --- a/tests/virstoragetest.c

[PATCH 2/2] conf: Don't format http cookies unless VIR_DOMAIN_DEF_FORMAT_SECURE is used

2020-04-14 Thread Peter Krempa
Starting from 3b076391befc3fe72deb0c244ac6c2b4c100b410 (v6.1.0-122-g3b076391be) we support http cookies. Since they may contain somewhat sensitive information we should not format into the XML unless VIR_DOMAIN_DEF_FORMAT_SECURE is asserted. Reported-by: Han Han Signed-off-by: Peter Krempa ---

Re: [libvirt-jenkins-ci PATCH v3 4/5] guests: Introduce the new 'gitlab' flavor

2020-04-14 Thread Erik Skultety
On Thu, Apr 09, 2020 at 12:28:50PM +0200, Andrea Bolognani wrote: > On Thu, 2020-04-09 at 06:23 +0200, Erik Skultety wrote: > > +++ b/guests/playbooks/update/tasks/gitlab.yml > > +- name: Make {{ gitlab_runner_config_dir }} world readable > > + file: > > +path: '{{ gitlab_runner_config_dir

Re: [libvirt PATCH 2/2] README-hacking: Drop from the git repository

2020-04-14 Thread Ján Tomko
On a Monday in 2020, Andrea Bolognani wrote: The newly-introduced CONTRIBUTING.md serves the same purposes and lives in the path where most people would look for it. Signed-off-by: Andrea Bolognani --- README-hacking | 56 -- 1 file changed, 56

Re: [libvirt PATCH 1/2] CONTRIBUTING: Add entry point for new contributors

2020-04-14 Thread Ján Tomko
On a Monday in 2020, Andrea Bolognani wrote: It's generally expected that a git repository will contain this file, which serves as an entry point for people interested in contributing to the project. In our case, we have extensive documentation available on the website which we don't want to

Re: [PATCH 05/43] esx: convert virMutex to GMutex

2020-04-14 Thread Rafael Fonseca
Pino, thank you for the review. Could you please take a look at patch #42 in this series? It's the one in which I had to add some explicit unlock calls, so it'd be good for someone who knows the code to review this part. On Tue, Apr 14, 2020 at 8:15 AM Pino Toscano wrote: > > On Friday, 10

FYI: Report about libvirt failing to compile on MSYS2 with an XDR error

2020-04-14 Thread Richard W.M. Jones
.. is here: https://github.com/msys2/MINGW-packages/issues/6384 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a

Re: [libvirt PATCH 0/2] Improve entry point for new contributors

2020-04-14 Thread Andrea Bolognani
On Mon, 2020-04-06 at 12:07 +0200, Andrea Bolognani wrote: > Use the path most people will look for, reduce building instructions > to the bare minimum necessary to locally bootstrap the learning > process, and ensure duplication doesn't creep in over time by > pointing to the full documentation.

Re: [RFC] Adding docker driver to libvirt

2020-04-14 Thread nshirokovskiy
On 12.04.2020 12:39, Martin Kletzander wrote: > On Thu, Apr 09, 2020 at 03:30:11PM +0300, nshirokovskiy wrote: >> Hi, all. >> >> Does it make sense to add such a driver? I can't say I have a big picture >> of docker functionality in mind but at least container lifecycle management >> and

Re: [RFC] Adding docker driver to libvirt

2020-04-14 Thread Cedric Bosdonnat
On Sun, 2020-04-12 at 11:39 +0200, Martin Kletzander wrote: > On Thu, Apr 09, 2020 at 03:30:11PM +0300, nshirokovskiy wrote: > > Hi, all. > > > > Does it make sense to add such a driver? I can't say I have a big picture > > of docker functionality in mind but at least container lifecycle

Re: [PATCH 05/43] esx: convert virMutex to GMutex

2020-04-14 Thread Pino Toscano
On Friday, 10 April 2020 15:54:32 CEST Rafael Fonseca wrote: > @@ -346,11 +342,12 @@ esxStreamClose(virStreamPtr stream, bool finish) > { > int result = 0; > esxStreamPrivate *priv = stream->privateData; > +g_autoptr(GMutexLocker) locker = NULL; > > if (!priv) >