[PATCH 2/5] libxl: make use of passthrough hypervisor feature

2020-04-17 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- src/libxl/libxl_conf.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 05d671bae7..458dfc2399 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -158,6 +158,27 @@

[PATCH 4/5] xenconfig: Add support for 'passthrough' hypervisor feature

2020-04-17 Thread Jim Fehlig
Add support for xl.cfg(5) 'passthrough' option in the domXML-to-xenconfig configuration converter. Signed-off-by: Jim Fehlig --- src/libvirt_private.syms | 2 ++ src/libxl/xen_common.c | 50 +++- 2 files changed, 46 insertions(+), 6 deletions(-) diff

[PATCH 3/5] libxl: refactor cpu and hypervisor feature parser/formatter

2020-04-17 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- src/libxl/xen_common.c | 38 -- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c index bbb9739e01..87c66becaf 100644 --- a/src/libxl/xen_common.c +++

[PATCH 0/5] Xen: Add support for xl.cfg passthrough setting

2020-04-17 Thread Jim Fehlig
Hi All, Note: This series is based on Marek's patches adding support for e820_host https://www.redhat.com/archives/libvir-list/2020-April/msg00633.html which I've ACK'ed, but am waiting to commit until this related setting is hashed out. This series adds support for Xen's xl.cfg(5)

[PATCH 5/5] tests: check conversion of passthrough hypervisor feature

2020-04-17 Thread Jim Fehlig
Add a new test to check the 'mode' attribute of the passthrough element and augment an existing, related test to check enablement of the passthrough element only. Signed-off-by: Jim Fehlig --- .../test-fullvirt-hypervisor-features.cfg | 26 ++

[PATCH 1/5] conf: add xen hypervisor feature 'passthrough'

2020-04-17 Thread Jim Fehlig
'passthrough' is Xen-Specific guest configuration option new to Xen 4.13 that enables IOMMU mappings for a guest and hence whether it supports PCI passthrough. The default is disabled. See the xl.cfg(5) man page and xen.git commit babde47a3fe for more details. The default state of disabled

[libvirt PATCH] util: Do not include sys/wait.h on Win32

2020-04-17 Thread Jiri Denemark
This fixes build on mingw broken by my previous commit 36e125296a. Signed-off-by: Jiri Denemark --- Pushed. src/util/virdaemon.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virdaemon.c b/src/util/virdaemon.c index 6182ca3c21..31cc24e703 100644 ---

[PATCH] Add 'permissive' option for PCI devices

2020-04-17 Thread Marek Marczykowski-Górecki
From: Simon Gaiser By setting the permissive flag the guest access to the PCI config space is not filtered. This might be a security risk, but it's required for some devices and the IOMMU and interrupt remapping should (mostly?) contain it. Signed-off-by: Simon Gaiser Signed-off-by: Marek

Re: [PATCH 0/2] Include lease time option into DHCP settings

2020-04-17 Thread Daniel P . Berrangé
On Wed, Apr 15, 2020 at 01:25:37PM -0300, Julio Faracco wrote: > I resubmitted this series because our team needs to hack dnsmasq > settings to change lease time. This feature would be so important to > us to avoid workarounds. > > It is based on Alberto's patch from 2017. But personally I don't

Re: [PATCH 1/2] conf: Add option for settings

2020-04-17 Thread Daniel P . Berrangé
On Wed, Apr 15, 2020 at 01:18:49PM -0300, Julio Faracco wrote: > If an user is trying to configure a dhcp neetwork settings, it is not > possible to change the leasetime of a range or a host entry. This is > available using dnsmasq extra options, but they are associated with > dhcp-range or

Re: [PATCH v2 0/2] docs: Further adjustments to pci-addresses.rst

2020-04-17 Thread Boris Fiuczynski
On 4/17/20 3:06 PM, Andrea Bolognani wrote: On Fri, 2020-04-17 at 14:27 +0200, Boris Fiuczynski wrote: Andrea Bolognani (1): docs: Update introduction in pci-addresses.rst Boris Fiuczynski (1): docs: Improve zPCI section in pci-addresses.rst docs/pci-addresses.rst | 31

Re: [PATCH 2/3] security: Introduce virSecurityManagerDomainSetIncomingPathLabel

2020-04-17 Thread Erik Skultety
... > > > > > > +/** > > > + * virSecurityManagerDomainSetIncomingPathLabel: > > > + * @mgr: security manager object > > > + * @vm: domain definition object > > > + * @path: path to label > > > + * > > > + * This function relabels given @path so that @vm can restore for > > > > maybe add "host"

Re: [PATCH v2 0/2] docs: Further adjustments to pci-addresses.rst

2020-04-17 Thread Andrea Bolognani
On Fri, 2020-04-17 at 14:27 +0200, Boris Fiuczynski wrote: > Andrea Bolognani (1): > docs: Update introduction in pci-addresses.rst > Boris Fiuczynski (1): > docs: Improve zPCI section in pci-addresses.rst > > docs/pci-addresses.rst | 31 ++- > 1 file changed, 18

Re: [PATCH 2/3] security: Introduce virSecurityManagerDomainSetIncomingPathLabel

2020-04-17 Thread Michal Privoznik
On 4/17/20 12:57 PM, Erik Skultety wrote: On Fri, Apr 03, 2020 at 05:58:02PM +0200, Michal Privoznik wrote: This API allows drivers to separate out handling of @stdin_path of virSecurityManagerSetAllLabel(). The thing is, the QEMU driver uses transactions for virSecurityManagerSetAllLabel()

Re: [PATCH 1/3] Improve blockpull man entry

2020-04-17 Thread Peter Krempa
On Fri, Apr 17, 2020 at 14:52:06 +0200, Peter Krempa wrote: > On Wed, Apr 15, 2020 at 11:34:04 +, Sebastian Mitterle wrote: > > 1. Mention usage of `--base` and `--bandwidth` and fix cmd syntax. > > 2. Explain valid arguments for `base`. > > 3. Move explanation for `--keep-relative` to end

Re: [PATCH 1/3] Improve blockpull man entry

2020-04-17 Thread Peter Krempa
On Wed, Apr 15, 2020 at 11:34:04 +, Sebastian Mitterle wrote: > 1. Mention usage of `--base` and `--bandwidth` and fix cmd syntax. > 2. Explain valid arguments for `base`. > 3. Move explanation for `--keep-relative` to end considering it >less frequent use case because libvirt doesn't

Re: [PATCH 0/3] doc: minor improvements

2020-04-17 Thread Sebastian Mitterle
friendly ping On Wed, Apr 15, 2020 at 1:34 PM Sebastian Mitterle wrote: > Minor man/doc improvements related to blockpull. > > Sebastian Mitterle (3): > Improve blockpull man entry > Improve Disk image chains documentation > Add version info on domaincaps doc > >

Re: [PATCH v2 2/2] docs: Improve zPCI section in pci-addresses.rst

2020-04-17 Thread Cornelia Huck
On Fri, 17 Apr 2020 14:27:34 +0200 Boris Fiuczynski wrote: > Improving the zPCI example by choosing more distinct values and > adding explanation for fid. > > Signed-off-by: Boris Fiuczynski > --- > docs/pci-addresses.rst | 22 -- > 1 file changed, 12 insertions(+), 10

[PATCH v2 1/2] docs: Update introduction in pci-addresses.rst

2020-04-17 Thread Boris Fiuczynski
Changing the introduction to bring the idea of this document better across. Signed-off-by: Andrea Bolognani Reviewed-by: Boris Fiuczynski Reviewed-by: Cornelia Huck --- docs/pci-addresses.rst | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/docs/pci-addresses.rst

[PATCH v2 2/2] docs: Improve zPCI section in pci-addresses.rst

2020-04-17 Thread Boris Fiuczynski
Improving the zPCI example by choosing more distinct values and adding explanation for fid. Signed-off-by: Boris Fiuczynski --- docs/pci-addresses.rst | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/docs/pci-addresses.rst b/docs/pci-addresses.rst

[PATCH v2 0/2] docs: Further adjustments to pci-addresses.rst

2020-04-17 Thread Boris Fiuczynski
Andrea Bolognani (1): docs: Update introduction in pci-addresses.rst Boris Fiuczynski (1): docs: Improve zPCI section in pci-addresses.rst docs/pci-addresses.rst | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) -- 2.25.1

Re: [PATCH 2/2] docs: Improve zPCI section in pci-addresses.rst

2020-04-17 Thread Andrea Bolognani
On Fri, 2020-04-17 at 13:31 +0200, Cornelia Huck wrote: > On Fri, 17 Apr 2020 13:29:43 +0200 > Boris Fiuczynski wrote: > > On 4/17/20 11:02 AM, Cornelia Huck wrote: > > > Sounds good. > > > > > > (Also the rest of the changes.) > > > > > Before I break the r-b chain as well... Is that your

[libvirt PATCH 07/10] vbox: add support for version 6.0 SDK

2020-04-17 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- src/vbox/Makefile.inc.am | 2 ++ src/vbox/vbox_V6_0.c | 13 + src/vbox/vbox_common.h| 2 ++ src/vbox/vbox_storage.c | 2 ++ src/vbox/vbox_tmpl.c | 9 - src/vbox/vbox_uniformed_api.h | 1 + 6 files

[libvirt PATCH 10/10] docs: add news about virtualbox version support changes

2020-04-17 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- docs/news.xml | 22 ++ 1 file changed, 22 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 4d0efd4219..99c65447b0 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -56,11 +56,33 @@ hotplug/unplug attempts, but

[libvirt PATCH 09/10] vbox: add support for version 6.1 SDK

2020-04-17 Thread Daniel P . Berrangé
Changes in the API: - APIs related to the graphics adapter are no longer on the IMachine interface, but on a IGraphicsAdapter interface - The LaunchVMProcess method takes a list of env variables instead of a single variable containing a concatenated list. Since we only ever pass a

[libvirt PATCH 03/10] vbox: remove support for version 5.1 API

2020-04-17 Thread Daniel P . Berrangé
This is no longer supported since 2018/04 Signed-off-by: Daniel P. Berrangé --- src/vbox/Makefile.inc.am | 2 -- src/vbox/vbox_V5_1.c | 13 - src/vbox/vbox_XPCOMCGlue.h| 2 +- src/vbox/vbox_common.h| 4 +--- src/vbox/vbox_storage.c | 4 +---

[libvirt PATCH 05/10] vbox: remove unused support for Windows MSCOM

2020-04-17 Thread Daniel P . Berrangé
Long ago we switched the vbox driver to run inside libvirtd to avoid libvirt.so being polluted with GPLv2-only code. Since libvirtd is not built on Windows, we disabled vbox on Windows builds. Thus the MSCOM glue code is not required. Signed-off-by: Daniel P. Berrangé --- po/POTFILES.in

[libvirt PATCH 00/10] vbox: update to support newer versions and drop eol versions

2020-04-17 Thread Daniel P . Berrangé
This is the bare minimum patches required to let libvirt compile with the latest virtualbox SDK for 6.0 and 6.1. Since I do not use virtualbox this is compile tested only. This will at least give users something to try and provide feedback on. In addition currently EOL versions of virtualbox are

[libvirt PATCH 01/10] vbox: remove support for version 5.0 API

2020-04-17 Thread Daniel P . Berrangé
This is no longer supported since 2017/05 Signed-off-by: Daniel P. Berrangé --- src/vbox/Makefile.inc.am | 2 -- src/vbox/vbox_V5_0.c | 13 - src/vbox/vbox_XPCOMCGlue.h| 2 +- src/vbox/vbox_common.h| 4 +--- src/vbox/vbox_storage.c | 4 +---

Re: [PATCH 2/2] docs: Improve zPCI section in pci-addresses.rst

2020-04-17 Thread Cornelia Huck
On Fri, 17 Apr 2020 13:29:43 +0200 Boris Fiuczynski wrote: > On 4/17/20 11:02 AM, Cornelia Huck wrote: > > On Fri, 17 Apr 2020 10:50:02 +0200 > > Boris Fiuczynski wrote: > > > >> On 4/16/20 6:14 PM, Cornelia Huck wrote: > >>> On Thu, 16 Apr 2020 17:56:18 +0200 > >>> Boris Fiuczynski

Re: [PATCH 2/2] docs: Improve zPCI section in pci-addresses.rst

2020-04-17 Thread Boris Fiuczynski
On 4/17/20 11:02 AM, Cornelia Huck wrote: On Fri, 17 Apr 2020 10:50:02 +0200 Boris Fiuczynski wrote: On 4/16/20 6:14 PM, Cornelia Huck wrote: On Thu, 16 Apr 2020 17:56:18 +0200 Boris Fiuczynski wrote: Improving the zPCI example by choosing more distinct values and adding explanation

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-04-17 Thread Cornelia Huck
On Fri, 17 Apr 2020 05:52:02 -0400 Yan Zhao wrote: > On Fri, Apr 17, 2020 at 04:44:50PM +0800, Cornelia Huck wrote: > > On Mon, 13 Apr 2020 01:52:01 -0400 > > Yan Zhao wrote: > > > > > This patchset introduces a migration_version attribute under sysfs of VFIO > > > Mediated devices. > > > >

Re: [PATCH 3/3] qemu: Label restore path outside of secdriver transactions

2020-04-17 Thread Erik Skultety
On Fri, Apr 03, 2020 at 05:58:03PM +0200, Michal Privoznik wrote: > As explained in the previous commit, we need to relabel the file > we are restoring the domain from. That is the FD that is passed > to QEMU. If the file is not under /dev then the file inside the > namespace is the very same as

Re: [PATCH 2/3] security: Introduce virSecurityManagerDomainSetIncomingPathLabel

2020-04-17 Thread Erik Skultety
On Fri, Apr 03, 2020 at 05:58:02PM +0200, Michal Privoznik wrote: > This API allows drivers to separate out handling of @stdin_path > of virSecurityManagerSetAllLabel(). The thing is, the QEMU driver > uses transactions for virSecurityManagerSetAllLabel() which > relabels devices from inside of

Re: [PATCH 1/3] selinux: Don't remember label for restore path

2020-04-17 Thread Erik Skultety
On Fri, Apr 03, 2020 at 05:58:01PM +0200, Michal Privoznik wrote: > The seclabel for @stdin_path in virSecuritySELinuxSetAllLabel() > is not restored, because at virSecuritySELinuxRestoreAllLabel() > phase it's too late and the caller (QEMU driver) simply doesn't > care. Well, don't remember the

Re: [libvirt PATCH] util: Fix virDaemonForkIntoBackground

2020-04-17 Thread Michal Privoznik
On 4/16/20 3:49 PM, Jiri Denemark wrote: This commit partially reverts commit c360ea28dc267802690e129fbad08ca2f22a44e9 Refs: v6.2.0-rc1-1-gc360ea28dc Author: Rafael Fonseca AuthorDate: Fri Mar 27 18:40:47 2020 +0100 Commit: Michal Prívozník CommitDate:

Re: [PATCH 2/2] docs: Improve zPCI section in pci-addresses.rst

2020-04-17 Thread Andrea Bolognani
On Fri, 2020-04-17 at 11:02 +0200, Cornelia Huck wrote: > On Fri, 17 Apr 2020 10:50:02 +0200 > Boris Fiuczynski wrote: > > > > > > > > > > > >> > > function='0x0'> > > > > - > > > > + > > > > > > Why this change? The pci-bridge does not show up in the guest

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-04-17 Thread Yan Zhao
On Fri, Apr 17, 2020 at 04:44:50PM +0800, Cornelia Huck wrote: > On Mon, 13 Apr 2020 01:52:01 -0400 > Yan Zhao wrote: > > > This patchset introduces a migration_version attribute under sysfs of VFIO > > Mediated devices. > > > > This migration_version attribute is used to check migration

Re: [PATCH 2/2] docs: Improve zPCI section in pci-addresses.rst

2020-04-17 Thread Cornelia Huck
On Fri, 17 Apr 2020 10:50:02 +0200 Boris Fiuczynski wrote: > On 4/16/20 6:14 PM, Cornelia Huck wrote: > > On Thu, 16 Apr 2020 17:56:18 +0200 > > Boris Fiuczynski wrote: > > > >> Improving the zPCI example by choosing more distinct values and > >> adding explanation for fid. > >> > >>

Re: [PATCH V2 4/5] cpu: Add helper funtions to parse vendor and model

2020-04-17 Thread Zhenyu Zheng
ping for reviews On Fri, Apr 10, 2020 at 3:58 PM Zhenyu Zheng wrote: > >> Add helper functions to parse vendor and model from >> xml for ARM arch, and use them as callbacks when >> load cpu maps. >> >> Signed-off-by: Zhenyu Zheng >> >> --- >> src/cpu/cpu_arm.c | 171

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-17 Thread Zhenyu Zheng
Ping for reviews On Fri, Apr 10, 2020 at 5:55 PM Andrea Bolognani wrote: > On Thu, 2020-04-09 at 13:03 +0200, Jiri Denemark wrote: > > On Thu, Apr 02, 2020 at 17:03:59 +0800, Zhenyu Zheng wrote: > > > +static int > > > +armCpuDataFromRegs(virCPUarmData *data) > > > +{ > > > +/* Generate

Re: [PATCH 2/2] docs: Improve zPCI section in pci-addresses.rst

2020-04-17 Thread Boris Fiuczynski
On 4/16/20 6:14 PM, Cornelia Huck wrote: On Thu, 16 Apr 2020 17:56:18 +0200 Boris Fiuczynski wrote: Improving the zPCI example by choosing more distinct values and adding explanation for fid. Signed-off-by: Boris Fiuczynski --- docs/pci-addresses.rst | 15 --- 1 file changed,

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-04-17 Thread Cornelia Huck
On Mon, 13 Apr 2020 01:52:01 -0400 Yan Zhao wrote: > This patchset introduces a migration_version attribute under sysfs of VFIO > Mediated devices. > > This migration_version attribute is used to check migration compatibility > between two mdev devices. > > Currently, it has two locations: >