[PATCH v2 2/2] tests: Add tests for to cover dnsmasq settings

New tests are required to cover some new XML syntax entry for option. This includes schema testing and other features like unit attribute and lease value. This commit includes hostsfile checks adding new files for each test case that is manipulating tag. Signed-off-by: Julio Faracco ---

[PATCH v2 1/2] conf: Add option for settings

If an user is trying to configure a dhcp neetwork settings, it is not possible to change the leasetime of a range or a host entry. This is available using dnsmasq extra options, but they are associated with dhcp-range or dhcp-hosts fields. This patch implements a leasetime for range and hosts

[PATCH v2 0/2] Include lease time option into DHCP settings

This series is based on latest series from Nehal. It includes a new entry called under and from scope. This was implemented to include independent lease time for each line and dnsmasq option. So, users are able to define one lease time for ranges and other different for each host entry. The

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

On Tue, Apr 21, 2020 at 06:56:00AM +0800, Alex Williamson wrote: > On Sun, 19 Apr 2020 21:24:57 -0400 > Yan Zhao wrote: > > > On Fri, Apr 17, 2020 at 07:24:57PM +0800, Cornelia Huck wrote: > > > On Fri, 17 Apr 2020 05:52:02 -0400 > > > Yan Zhao wrote: > > > > > > > On Fri, Apr 17, 2020 at

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

Yes, I will do that. On Mon, Apr 20, 2020 at 10:12 PM Jiri Denemark wrote: > On Fri, Apr 17, 2020 at 16:53:18 +0800, Zhenyu Zheng wrote: > > Ping for reviews > > Could you please resend the new version of patches as a separate series > (don't forget to update the subject to v3)? Hunting for the

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

On Sun, 19 Apr 2020 21:24:57 -0400 Yan Zhao wrote: > On Fri, Apr 17, 2020 at 07:24:57PM +0800, Cornelia Huck wrote: > > On Fri, 17 Apr 2020 05:52:02 -0400 > > Yan Zhao wrote: > > > > > On Fri, Apr 17, 2020 at 04:44:50PM +0800, Cornelia Huck wrote: > > > > On Mon, 13 Apr 2020 01:52:01 -0400

Re: [PATCH libvirt v1 0/6] Fix ZPCI address auto-generation on s390

On 4/10/20 2:06 PM, Andrea Bolognani wrote: On Thu, 2020-04-09 at 12:30 +0200, Shalini Chellathurai Saroja wrote: The ZPCI address validation or autogeneration does not work as expected in the following scenarios 1. uid = 0 and fid = 0 2. uid = 0 and fid > 0 3. uid = 0 and fid not specified 4.

[libvirt PATCH v3 3/5] add virQEMUCapsProbeQMPTCGState function to set QEMU_CAPS_TCG_DISABLED

virQEMUCapsProbeQMPTCGState will set QEMU_CAPS_TCG_DISABLED if QEMU version is at least 2.10, KVM is enabled, and qom-list-types does not include tcg-accel. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 32 1 file changed, 32

[libvirt PATCH v3 4/5] use new functions when probing

Probe for TCG with QMP right after probing for KVM. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 9abc6e80e7..fa3084484d

[libvirt PATCH v3 0/5] QEMU: support QEMU built without TCG

Rebased and resent from about a month ago. Since version 2.10, QEMU can be built without TCG. This patch adds capabillity QEMU_CAPS_TCG_DISABLED that allows libvirt to use a QEMU built without TCG. Rather than create a capability that is set whenever TCG is enabled (almost always),

[libvirt PATCH v3 2/5] add virQEMUCapsGetVirtType convenience function

Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 14 ++ src/qemu/qemu_capabilities.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index c56b2d8f0e..8a17287076 100644 ---

[libvirt PATCH v3 1/5] add QEMU_CAPS_TCG_DISABLED and probe conditionally

Only probe QEMU binary with accel=tcg if TCG is not disabled. Similarly, only add a VIR_DOMAIN_VIRT_QEMU guest if TCG is available. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 22 ++ src/qemu/qemu_capabilities.h | 1 + 2 files changed, 15

Re: [PATCH 2/2] Avoid unnecessary error messages handling udev events

On Monday, April 20, 2020 11:27:59 A.M. EDT Mark Asselstine wrote: > On Monday, April 20, 2020 10:22:06 A.M. EDT Michal Privoznik wrote: > > On 4/20/20 3:54 PM, Mark Asselstine wrote: > > > No problem. Thanks for taking the patches and making the necessary > > > tweaks. > > > > In return, I've

Re: [libvirt-ci PATCH 1/2] mappings: Add libssh2 and wireshark on CentOS

On Mon, Apr 20, 2020 at 03:00:36PM +0200, Andrea Bolognani wrote: > Turns out the packages are actually available on both CentOS 7 > and CentOS 8. > > Signed-off-by: Andrea Bolognani > --- > guests/vars/mappings.yml | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Daniel P. Berrangé

Re: [libvirt-ci PATCH 2/2] Build libvirt-tck on CentOS 8

On Mon, 2020-04-20 at 17:58 +0100, Daniel P. Berrangé wrote: > On Mon, Apr 20, 2020 at 06:52:59PM +0200, Andrea Bolognani wrote: > > Now the question is: if these are actual build requirements, how can > > the build succeed and the test suite pass? > > Well the "build" phase in Perl essentially

Re: [libvirt-ci PATCH 2/2] Build libvirt-tck on CentOS 8

On Mon, Apr 20, 2020 at 06:52:59PM +0200, Andrea Bolognani wrote: > On Mon, 2020-04-20 at 14:05 +0100, Daniel P. Berrangé wrote: > > On Mon, Apr 20, 2020 at 03:00:37PM +0200, Andrea Bolognani wrote: > > > # CentOS 7 doesn't include perl-generators, which is necessary to > > > # build

Re: [libvirt-ci PATCH 2/2] Build libvirt-tck on CentOS 8

On Mon, 2020-04-20 at 14:05 +0100, Daniel P. Berrangé wrote: > On Mon, Apr 20, 2020 at 03:00:37PM +0200, Andrea Bolognani wrote: > > # CentOS 7 doesn't include perl-generators, which is necessary to > > # build libvirt-tck > > perl-Sys-Virt-TCK.spec.PL says > > %if 0%{?fedora} ||

Re: [PATCH 1/3] udevRemoveOneDevice: Unlock node device obj upon return

On a Monday in 2020, Michal Privoznik wrote: When removing a node device object from the internal list the udevRemoveOneDevice() function does plain unref over the object. This is not sufficient. If there is another thread that's waiting for the object lock it will wait forever. I presume

Re: [libvirt PATCH] README: Add GitLab CI badge

On a Tuesday in 2020, Andrea Bolognani wrote: We've moved most of our CI jobs to GitLab, so we should display the corresponding badge prominently. Signed-off-by: Andrea Bolognani --- README.rst | 3 +++ 1 file changed, 3 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc

Re: [libvirt PATCH] CONTRIBUTING: Include in release archives

On a Tuesday in 2020, Andrea Bolognani wrote: The file, added with commit commit 874952f80c6d68c1a7a75e71c11a576f96f75dc2 Author: Andrea Bolognani Date: Mon Apr 6 11:56:58 2020 +0200 CONTRIBUTING: Add entry point for new contributors should be included in release archives.

Re: [PATCH 2/2] Avoid unnecessary error messages handling udev events

On Monday, April 20, 2020 10:22:06 A.M. EDT Michal Privoznik wrote: > On 4/20/20 3:54 PM, Mark Asselstine wrote: > > No problem. Thanks for taking the patches and making the necessary tweaks. > > In return, I've just posted a follow up patches that remove the device > on "move": > >

Re: [libvirt PATCH] CONTRIBUTING: Include in release archives

On Tue, 2020-04-14 at 13:57 +0200, Andrea Bolognani wrote: > The file, added with commit > > commit 874952f80c6d68c1a7a75e71c11a576f96f75dc2 > Author: Andrea Bolognani > Date: Mon Apr 6 11:56:58 2020 +0200 > > CONTRIBUTING: Add entry point for new contributors > > should be

Re: [libvirt PATCH] README: Add GitLab CI badge

On Tue, 2020-04-14 at 16:32 +0200, Andrea Bolognani wrote: > We've moved most of our CI jobs to GitLab, so we should display > the corresponding badge prominently. > > Signed-off-by: Andrea Bolognani > --- > README.rst | 3 +++ > 1 file changed, 3 insertions(+) ping -- Andrea Bolognani / Red

Re: [PATCH 2/2] Avoid unnecessary error messages handling udev events

On 4/20/20 3:54 PM, Mark Asselstine wrote: No problem. Thanks for taking the patches and making the necessary tweaks. In return, I've just posted a follow up patches that remove the device on "move": https://www.redhat.com/archives/libvir-list/2020-April/msg00936.html Could you please

[PATCH 2/3] node_device_udev: Split udevRemoveOneDevice() into two

Move internals of udevRemoveOneDevice() into a separate function which accepts sysfs path as an argument and actually removes the device from the internal list. It will be reused later. Signed-off-by: Michal Privoznik --- src/node_device/node_device_udev.c | 21 ++--- 1 file

[PATCH 3/3] udevHandleOneDevice: Remove old instance of device on "move"

When a device is "move"-d (this basically means it was renamed), we add the new device onto our list but keep the old there too. Fortunately, udev sets this DEVPATH_OLD property which points to the old device path. We can use it to remove the old instance. To test this try renaming an interface,

[PATCH 1/3] udevRemoveOneDevice: Unlock node device obj upon return

When removing a node device object from the internal list the udevRemoveOneDevice() function does plain unref over the object. This is not sufficient. If there is another thread that's waiting for the object lock it will wait forever. Signed-off-by: Michal Privoznik ---

[PATCH 0/3] udevHandleOneDevice: Remove old instance of device on "move"

Follow up to: https://www.redhat.com/archives/libvir-list/2020-April/msg00817.html I'd appreciate if somebody with systemd udev could test these and check if they are working as expected. Michal Prívozník (3): udevRemoveOneDevice: Unlock node device obj upon return node_device_udev: Split

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

On Fri, Apr 17, 2020 at 16:53:18 +0800, Zhenyu Zheng wrote: > Ping for reviews Could you please resend the new version of patches as a separate series (don't forget to update the subject to v3)? Hunting for the new patches hidden in random replies to the reviewers comments or original patches is

[libvirt-python PATCH v2] setup: require python >= 3.5 to build

Pytjon 3.5 is the oldest Python version available across our supported build platforms. Signed-off-by: Daniel P. Berrangé --- setup.py | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index 56b6eea..39a07de 100755 --- a/setup.py +++ b/setup.py @@

Re: [PATCH 2/2] Avoid unnecessary error messages handling udev events

On Monday, April 20, 2020 9:30:56 A.M. EDT Michal Privoznik wrote: > On 4/20/20 3:09 PM, Mark Asselstine wrote: > > On Monday, April 20, 2020 6:11:25 A.M. EDT Michal Privoznik wrote: > >> On 4/16/20 5:57 PM, Mark Asselstine wrote: > >>> The udev monitor thread "udevEventHandleThread()" will lag

Re: [PATCH 2/2] Avoid unnecessary error messages handling udev events

On 4/20/20 3:09 PM, Mark Asselstine wrote: On Monday, April 20, 2020 6:11:25 A.M. EDT Michal Privoznik wrote: On 4/16/20 5:57 PM, Mark Asselstine wrote: The udev monitor thread "udevEventHandleThread()" will lag the actual/real view of devices in sysfs as it serially processes udev monitor

Re: [libvirt-python PATCH] setup: require python >= 3.5 to build

Hello Daniel, Am 20.04.20 um 15:02 schrieb Daniel P. Berrangé: > On Mon, Apr 20, 2020 at 02:59:38PM +0200, Philipp Hahn wrote: >> Am 20.04.20 um 14:47 schrieb Daniel P. Berrangé: >>> Pytjon 3.5 is the oldest Python version available across our supported ... >>> -if sys.version_info[0] != 3: >>> -

Re: [PATCH 2/2] Avoid unnecessary error messages handling udev events

On Monday, April 20, 2020 6:11:25 A.M. EDT Michal Privoznik wrote: > On 4/16/20 5:57 PM, Mark Asselstine wrote: > > The udev monitor thread "udevEventHandleThread()" will lag the > > actual/real view of devices in sysfs as it serially processes udev > > monitor events. So for instance if you were

Re: [PATCH v2] doc/python: Update to Python 3

On Mon, Apr 20, 2020 at 03:01:11PM +0200, Philipp Hahn wrote: > Convert the simple example to Python 3 syntax: > - print() is a function > - do not use bare except > - libvirt.open*() does not return None but raises an exception > > The referenced source for the example was removed with >

Re: [libvirt-ci PATCH 2/2] Build libvirt-tck on CentOS 8

On Mon, Apr 20, 2020 at 03:00:37PM +0200, Andrea Bolognani wrote: > CentOS 7 is missing perl-generators, as explained in the comment, > but this limitation does not apply to CentOS 8. The comment is wrong > diff --git a/jenkins/projects/libvirt-tck.yaml > b/jenkins/projects/libvirt-tck.yaml >

Re: [libvirt-python PATCH] setup: require python >= 3.5 to build

On Mon, Apr 20, 2020 at 02:59:38PM +0200, Philipp Hahn wrote: > Hello Daniel. > > 2 nits: > > Am 20.04.20 um 14:47 schrieb Daniel P. Berrangé: > > Pytjon 3.5 is the oldest Python version available across our supported > ^ h > > build platforms. > > > > Signed-off-by: Daniel P. Berrangé >

[libvirt-ci PATCH 0/2] Improve CentOS coverage

Build more projects and install more optional dependencies. Andrea Bolognani (2): mappings: Add libssh2 and wireshark on CentOS Build libvirt-tck on CentOS 8 guests/playbooks/build/projects/libvirt-tck.yml | 2 ++ guests/vars/mappings.yml| 2 --

[libvirt-ci PATCH 2/2] Build libvirt-tck on CentOS 8

CentOS 7 is missing perl-generators, as explained in the comment, but this limitation does not apply to CentOS 8. Signed-off-by: Andrea Bolognani --- guests/playbooks/build/projects/libvirt-tck.yml | 2 ++ jenkins/projects/libvirt-tck.yaml | 2 ++ 2 files changed, 4 insertions(+)

[PATCH v2] doc/python: Update to Python 3

Convert the simple example to Python 3 syntax: - print() is a function - do not use bare except - libvirt.open*() does not return None but raises an exception The referenced source for the example was removed with 5bb2a245abbde4c0a407f631660e2f2c81bc4c02 Signed-off-by: Philipp Hahn ---

[libvirt-ci PATCH 1/2] mappings: Add libssh2 and wireshark on CentOS

Turns out the packages are actually available on both CentOS 7 and CentOS 8. Signed-off-by: Andrea Bolognani --- guests/vars/mappings.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index e924e5b..753f0fe 100644 ---

Re: [libvirt-python PATCH] setup: require python >= 3.5 to build

Hello Daniel. 2 nits: Am 20.04.20 um 14:47 schrieb Daniel P. Berrangé: > Pytjon 3.5 is the oldest Python version available across our supported ^ h > build platforms. > > Signed-off-by: Daniel P. Berrangé > --- > setup.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [python] WIP-FYI: mypy annotations for libvirt-python and cleanup for generator.py

On Mon, Apr 20, 2020 at 07:21:10AM +0200, Philipp Hahn wrote: > Hello, > > Am 08.11.18 um 11:11 schrieb Philipp Hahn: > > Maybe you already have heard about mypy , which > > "is an experimental optional static type checker for Python that aims to > > combine the benefits of

[libvirt-python PATCH] setup: require python >= 3.5 to build

Pytjon 3.5 is the oldest Python version available across our supported build platforms. Signed-off-by: Daniel P. Berrangé --- setup.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index 56b6eea..b3e418e 100755 --- a/setup.py +++ b/setup.py @@ -17,8

Re: [PATCH 4/4] docs: Docs and news for io mode io_uring

On Mon, Apr 20, 2020 at 3:55 PM Peter Krempa wrote: > On Sat, Apr 18, 2020 at 23:57:54 +0800, Han Han wrote: > > Signed-off-by: Han Han > > --- > > docs/formatdomain.html.in | 3 ++- > > docs/news.xml | 9 + > > docs/schemas/domaincommon.rng | 1 + > > 3 files

Re: [PATCH libvirt-python] examples: Fix connection error handling

On Mon, Apr 20, 2020 at 08:05:00AM +0200, Philipp Hahn wrote: > libvirt.open*() does not return None but raises an exception > > Signed-off-by: Philipp Hahn > --- > examples/dominfo.py| 5 +++-- > examples/domrestore.py | 5 +++-- > examples/domsave.py| 5 +++-- > examples/domstart.py

Re: [PATCH] doc/python: Update to Python 3

On Mon, Apr 20, 2020 at 08:01:54AM +0200, Philipp Hahn wrote: > Convert the simple example to Python 3 syntax: > - print() is a function > - do not use bare except > - libvirt.open*() does not return None but raises an exception > > The referenced source for the example was removed with >

Re: [libvirt-ci PATCH] lcitool: Don't set root shell

On Mon, Apr 20, 2020 at 01:13:46PM +0200, Andrea Bolognani wrote: > Being able to log in as root is critical to recover from failures, > so using bash might not always be the best idea: this is especially > true for FreeBSD, where bash is installed via ports and might break > on update from time

[libvirt-ci PATCH] lcitool: Don't set root shell

Being able to log in as root is critical to recover from failures, so using bash might not always be the best idea: this is especially true for FreeBSD, where bash is installed via ports and might break on update from time to time, rendering the system inaccessible without jumping through

[libvirt PATCH] CONTRIBUTING: Include information on build dependencies

libvirt depends on a ton of packages, so trying to install them all by using the classic approach of repeatedly running configure and reacting to each failure by installing the corresponding missing package will inevitably lead to frustration. Luckily there's an easy solution to get most

[libvirt-ci PATCH 1/2] lcitool: Prepare Fedora Rawhide for MinGW builds

We had use Fedora 30 during the Fedora 31 cycle because some of the MinGW packages we need had been removed from Fedora Rawhide, but they've since been reintroduced. This reverts commit 3c5ac0af41bacf5d0cb1cf2a3f79c31d0541df6a. Signed-off-by: Andrea Bolognani ---

[libvirt-ci PATCH 0/2] Move MinGW builds back to Fedora Rawhide

Andrea Bolognani (2): lcitool: Prepare Fedora Rawhide for MinGW builds Move MinGW builds back to Fedora Rawhide guests/host_vars/libvirt-fedora-30/main.yml | 10 -- guests/host_vars/libvirt-fedora-rawhide/main.yml | 10 ++ guests/playbooks/build/jobs/defaults.yml

[libvirt-ci PATCH 2/2] Move MinGW builds back to Fedora Rawhide

We had use Fedora 30 during the Fedora 31 cycle because some of the MinGW packages we need had been removed from Fedora Rawhide, but they've since been reintroduced. This reverts commit 528c9f33585c5ab913fe2c1bd172c7dd4f661bed. Signed-off-by: Andrea Bolognani ---

Re: [PATCH 1/2] node_device_udev: handle move events

On 4/18/20 3:25 PM, Martin Kletzander wrote: On Thu, Apr 16, 2020 at 11:57:45AM -0400, Mark Asselstine wrote: It is possible and common to rename some devices, this is especially true for ethernet devices such as veth pairs. In the udevEventHandleThread() we will be notified of this change but

Re: [PATCH 2/2] Avoid unnecessary error messages handling udev events

On 4/16/20 5:57 PM, Mark Asselstine wrote: The udev monitor thread "udevEventHandleThread()" will lag the actual/real view of devices in sysfs as it serially processes udev monitor events. So for instance if you were to run the following cmd to create a new veth pair and rename one of the veth

Re: [libvirt PATCH 00/10] vbox: update to support newer versions and drop eol versions

On 4/17/20 2:01 PM, Daniel P. Berrangé wrote: This is the bare minimum patches required to let libvirt compile with the latest virtualbox SDK for 6.0 and 6.1. Since I do not use virtualbox this is compile tested only. This will at least give users something to try and provide feedback on. In

Re: [PATCH 3/3] virnetdev.c: Use g_auto*()

On a Monday in 2020, Michal Privoznik wrote: While I'm at it, use more g_autofree and g_autoptr() in this file. This also fixes a possible mem-leak in virNetDevGetVirtualFunctions(). Signed-off-by: Michal Privoznik --- src/util/virnetdev.c | 384 --- 1

Re: [PATCH 0/2] Include lease time option into DHCP settings

On Sun, Apr 19, 2020 at 12:16:39AM -0400, Laine Stump wrote: > On 4/17/20 12:00 PM, Daniel P. Berrangé wrote: > > On Wed, Apr 15, 2020 at 01:25:37PM -0300, Julio Faracco wrote: > > > I resubmitted this series because our team needs to hack dnsmasq > > > settings to change lease time. This feature

Re: [PATCH 2/3] virNetDevSwitchdevFeature: Make failure to get 'family_id' non-fatal

On a Monday in 2020, Michal Privoznik wrote: I've just got a new machine and I'm still converging on the kernel config. Anyway, since I don't have enabled any of SRIO-V drivers, my kernel doesn't have NET_DEVLINK enabled (i.e. virNetDevGetFamilyId() returns 0). But this makes nodedev driver

Re: [PATCH 1/3] virNetDevGetFamilyId: Change signature

On a Monday in 2020, Michal Privoznik wrote: Introduced in v3.8.0-rc1~96, the virNetDevGetFamilyId() gets netlink family ID for passed family name (even though it's used only for getting "devlink" ID). Nevertheless, the function returns 0 on an error or if no family ID was found. This makes it

Re: [PATCH 4/4] docs: Docs and news for io mode io_uring

On Sat, Apr 18, 2020 at 23:57:54 +0800, Han Han wrote: > Signed-off-by: Han Han > --- > docs/formatdomain.html.in | 3 ++- > docs/news.xml | 9 + > docs/schemas/domaincommon.rng | 1 + > 3 files changed, 12 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH 3/4] tests: Tests for io mode io_uring

On Sat, Apr 18, 2020 at 23:57:53 +0800, Han Han wrote: > Signed-off-by: Han Han > --- > tests/qemublocktest.c | 1 + > ...le-backing_basic-aio_io_uring-srconly.json | 44 + > .../file-backing_basic-aio_io_uring.json | 66 +++ >

Re: [PATCH 2/4] qemu: Implement the aio mode io_uring

On Sat, Apr 18, 2020 at 23:57:52 +0800, Han Han wrote: > This aio mode was added since Linux 5.1[1], QEMU 5.0.0[2], which will > deliever faster and more efficient I/O operations for the file, > host_device, host_cdrom backends. > > Reference: > [1]: https://lwn.net/Articles/810414/ > [2]:

Re: [PATCH 1/4] qemu_capabilities: Introduce QEMU_CAPS_AIO_IO_URING

On Sat, Apr 18, 2020 at 23:57:51 +0800, Han Han wrote: > Add io_uring value to capability replies. > > The capability QEMU_CAPS_AIO_IO_URING will be used for io_uring aio mode, > introduced from QEMU 5.0, linux 5.1. > > Signed-off-by: Han Han > --- > src/qemu/qemu_capabilities.c

[libvirt-ci PATCH] README: Fix "maintainance" typo

Signed-off-by: Erik Skultety --- Pushed as trivial. guests/README.markdown | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guests/README.markdown b/guests/README.markdown index ed9be06..7dbefed 100644 --- a/guests/README.markdown +++ b/guests/README.markdown @@ -18,7 +18,7

[PATCH 3/3] virnetdev.c: Use g_auto*()

While I'm at it, use more g_autofree and g_autoptr() in this file. This also fixes a possible mem-leak in virNetDevGetVirtualFunctions(). Signed-off-by: Michal Privoznik --- src/util/virnetdev.c | 384 --- 1 file changed, 139 insertions(+), 245

[PATCH 0/3] Enable net devices in node-dev driver again

If the kernel doesn't have CONFIG_NET_DEVLINK then net devices are not listed in nodedev-list. See 2/3 for more info. Michal Prívozník (3): virNetDevGetFamilyId: Change signature virNetDevSwitchdevFeature: Make failure to get 'family_id' non-fatal virnetdev.c: Use g_auto*()

[PATCH 2/3] virNetDevSwitchdevFeature: Make failure to get 'family_id' non-fatal

I've just got a new machine and I'm still converging on the kernel config. Anyway, since I don't have enabled any of SRIO-V drivers, my kernel doesn't have NET_DEVLINK enabled (i.e. virNetDevGetFamilyId() returns 0). But this makes nodedev driver ignore all intefaces, because when enumerating all

[PATCH 1/3] virNetDevGetFamilyId: Change signature

Introduced in v3.8.0-rc1~96, the virNetDevGetFamilyId() gets netlink family ID for passed family name (even though it's used only for getting "devlink" ID). Nevertheless, the function returns 0 on an error or if no family ID was found. This makes it harder for a caller to distinguish these two.

[PATCH libvirt-python] examples: Fix connection error handling

libvirt.open*() does not return None but raises an exception Signed-off-by: Philipp Hahn --- examples/dominfo.py| 5 +++-- examples/domrestore.py | 5 +++-- examples/domsave.py| 5 +++-- examples/domstart.py | 5 +++-- examples/esxlist.py| 6 +++--- 5 files changed, 15

[PATCH] doc/python: Update to Python 3

Convert the simple example to Python 3 syntax: - print() is a function - do not use bare except - libvirt.open*() does not return None but raises an exception The referenced source for the example was removed with 5bb2a245abbde4c0a407f631660e2f2c81bc4c02 --- docs/python.html.in | 18