Re: [RFC] Faster libvirtd restart with nwfilter rules, one more time

On 3/20/20 5:25 AM, nshirokovskiy wrote: Hi, all. Some time ago I posted RFC [1] concerning an issue of unresponsive libvird during restart if there is large number of VMs that have network filters on their

[libvirt PATCH 1/2] network: make it safe to call networkSetupPrivateChains() multiple times

networkSetupPrivateChains() is currently called only once per run of libvirtd, so it can assume that errInitV4 and errInitV6 are empty/null when it is called. In preparation for potentially calling this function multiple times during one run, this patch moves the reset of errInitV[46] to the top

[libvirt PATCH 0/2] network: force re-creation of iptables private chains on firewalld restart

Details are in the commit log of patch 2. Essentially, we've been careful to only create the iptables chains once per run, because it's very expensive, but when firewalld is restarted, it removes our chains, so we need to put them back. I think this may have been a problem as far back as libvirt

[libvirt PATCH 2/2] network: force re-creation of iptables private chains on firewalld restart

When firewalld is stopped, it removes *all* iptables rules and chains, including those added by libvirt. Since restarting firewalld means stopping and then starting it, any time it is restarted, libvirt needs to recreate all the private iptables chains it uses, along with all the rules it adds.

Re: [libvirt PATCH] libxl: vga.kind none when no device specified

On 5/7/20 3:30 PM, Jim Fehlig wrote: On 5/7/20 11:17 AM, Marek Marczykowski-Górecki wrote: On Thu, May 07, 2020 at 09:52:44AM -0600, Jim Fehlig wrote: On 5/7/20 5:12 AM, Marek Marczykowski-Górecki wrote: On Thu, Apr 30, 2020 at 02:31:12PM +0200, Artur Puzio wrote: When no video device is

[PATCH] tests: Fix the libxl xml2domconfig test

Commit a13b2905f7 missed an adjustment to a test that is only run when building against xen <= 4.9, where LIBXL_HAVE_BUILDINFO_NESTED_HVM is not defined. Adjust fullvirt-cpuid-legacy-nest test similar to the others. Signed-off-by: Jim Fehlig --- Pushing under the build-breaker rule.

Re: [libvirt PATCH v2] libxl: vga.kind none when no device specified

On 5/7/20 5:24 AM, Artur Puzio wrote: When no video device is specified in config we should set both hvm.nographic to 1 and hvm.vga.kind to NONE. Without hvm.vga.kind=LIBXL_VGA_INTERFACE_TYPE_NONE both -nographic and -device 'cirrus-vga' are on qemu cmdline. Signed-off-by: Artur Puzio ---

Re: [libvirt PATCH] libxl: vga.kind none when no device specified

On 5/7/20 11:17 AM, Marek Marczykowski-Górecki wrote: On Thu, May 07, 2020 at 09:52:44AM -0600, Jim Fehlig wrote: On 5/7/20 5:12 AM, Marek Marczykowski-Górecki wrote: On Thu, Apr 30, 2020 at 02:31:12PM +0200, Artur Puzio wrote: When no video device is specified in config we should set both

[libvirt PATCH v2 1/3] docs: Drop glib-adoption.rst

It's been more than six months since we adopted GLib and we've been pretty aggressive at replacing our homegrown APIs with more standard ones, so by now most of the symbols mentioned in this document haven't been around for quite a long time already. Signed-off-by: Andrea Bolognani ---

[libvirt PATCH v2 2/3] docs: Use definition list instead of table in coding style

This format is much easier to tweak and update. Signed-off-by: Andrea Bolognani --- docs/coding-style.rst | 47 --- 1 file changed, 26 insertions(+), 21 deletions(-) diff --git a/docs/coding-style.rst b/docs/coding-style.rst index 151ea87b6a..03b89c86e5

[libvirt PATCH v2 3/3] docs: Document list-tables as recommended

Signed-off-by: Andrea Bolognani --- docs/styleguide.rst | 20 1 file changed, 20 insertions(+) diff --git a/docs/styleguide.rst b/docs/styleguide.rst index 3162868fb7..34c5b1573a 100644 --- a/docs/styleguide.rst +++ b/docs/styleguide.rst @@ -77,6 +77,26 @@ which allows for

[libvirt PATCH v2 0/3] docs: Some reStructuredText tweaks

Changes from [v1]: * convert simple tables to definition lists; * drop glib-adoption.rst entirely instead of tweaking it. [v1] https://www.redhat.com/archives/libvir-list/2020-May/msg00292.html Andrea Bolognani (3): docs: Drop glib-adoption.rst docs: Use definition list instead of

Re: [libvirt PATCH] libxl: vga.kind none when no device specified

On Thu, May 07, 2020 at 09:52:44AM -0600, Jim Fehlig wrote: > On 5/7/20 5:12 AM, Marek Marczykowski-Górecki wrote: > > On Thu, Apr 30, 2020 at 02:31:12PM +0200, Artur Puzio wrote: > > > When no video device is specified in config we should set both > > > hvm.nographic to 1 and hvm.vga.kind to

Re: [libvirt PATCH v2] docs: introduce a page showing a overall CI dashboard

On Thu, 2020-05-07 at 15:29 +0100, Daniel P. Berrangé wrote: > + * - ruby-libvirt > + - .. image:: > https://gitlab.com/libvirt/ruby-libvirt/badges/master/pipeline.svg > + :target: https://gitlab.com/libvirt/ruby-libvirt/pipelines > + :alt: ruby-libvirt pipeline status

Re: device hotplug & file handles

On 5/7/20 9:49 AM, Gerd Hoffmann wrote: Hi, For usb device pass-through (aka -device usb-host) it would be very useful to pass file handles from libvirt to qemu. The workflow would change from ... (1) libvirt enables access to /dev/usb/$bus/$dev (2) libvirt passes $bus + $dev (using

Re: [libvirt-ci PATCH 12/12] guests: README: Document the existence and usage of config.toml

On Wed, 2020-05-06 at 14:06 +0200, Erik Skultety wrote: > -Ansible and `virt-install` need to be available on the host. > +`ansible` and `virt-install` need to be available on the host, the former can > +be either installed system-wide using your package manager or using by `pip` s/using

Re: [libvirt-ci PATCH 11/12] config: Move the virt-install settings from install.yml to the config

On Wed, 2020-05-06 at 14:06 +0200, Erik Skultety wrote: > +++ b/guests/config.yaml > @@ -15,6 +15,23 @@ install: ># instead. (Mandatory) >#root_password: > > + # Settings mapping to the virt-install options - see virt-install(1). > + # It is strongly recommended that you keep the

[libvirt-ci PATCH] lcitool: Set make parallelism dynamically

We're about to make some changes to lcitool that would make it more annoying to get access to the number of install-time vCPUs from 'lcitool update', so let's use getconf instead. As a side effect, this also copes better with the situation where the builder was installed with a certain number of

Re: [libvirt-ci PATCH 10/12] lcitool: Drop the gitlab-related getter methods

On Wed, 2020-05-06 at 14:06 +0200, Erik Skultety wrote: > We can now access the values directly in the config dictionary. > > Signed-off-by: Erik Skultety > --- > guests/lcitool | 40 > 1 file changed, 40 deletions(-) Reviewed-by: Andrea Bolognani --

Re: [libvirt-ci PATCH 09/12] lcitool: Drop the get_root_password_file() method

On Wed, 2020-05-06 at 14:05 +0200, Erik Skultety wrote: > We can now access this value directly in the config dictionary. > > Signed-off-by: Erik Skultety > --- > guests/lcitool | 17 - > 1 file changed, 17 deletions(-) Reviewed-by: Andrea Bolognani -- Andrea Bolognani / Red

Re: [libvirt-ci PATCH 08/12] lcitool: Drop the get_flavor() method

On Wed, 2020-05-06 at 14:05 +0200, Erik Skultety wrote: > We can now access this value directly in the config dictionary. > > Signed-off-by: Erik Skultety > --- > guests/lcitool | 36 > 1 file changed, 4 insertions(+), 32 deletions(-) Reviewed-by: Andrea

Re: [libvirt-ci PATCH 07/12] lcitool: Update the config values with internal playbook settings

On Wed, 2020-05-06 at 14:05 +0200, Erik Skultety wrote: > -extra_vars = { > +self._config.values.update({ > "base": base, > "playbook_base": playbook_base, > -"root_password_file": root_pass_file, > -"flavor": flavor, >

Re: [PATCH 00/20] qemu: Remove one of last two instances of -drive if=none usage

On 5/6/20 2:08 PM, Peter Krempa wrote: QEMU want's to deprecate -drive if=none. Stop clearing QEMU_CAPS_BLOCKDEV when SD cards are used. Please see 17/20 and 20/20 for more explanation. Obviously few cleanups snuck in as well. Peter Krempa (20): qemuxml2(argv|xml): Modernize 'blkdeviotune'

Re: [libvirt PATCH] tests: Use qemu:///embed to simplify fakerootdir management

On 5/6/20 3:02 PM, Andrea Bolognani wrote: Now that the QEMU driver natively supports storing all its runtime data inside an arbitrary directory, we can avoid having multiple copies of this same logic in the test suite. Signed-off-by: Andrea Bolognani --- tests/qemuhotplugtest.c | 15

[PATCH v2] Unlock the storage pool objects after looking it up

Use g_new0 to allocate and remove NULL checks from callers and the lock will release properly Signed-off-by: Yi Li --- src/conf/virstorageobj.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index

Re: [PATCH 0/2] conf: Properly handle placement of and after blockjobs

On 5/7/20 3:26 PM, Peter Krempa wrote: Peter Krempa (2): conf: Sanitize handling of and placement for disks conf: Store 'diskElementAuth' and 'diskElementEnc' properties in status XML src/conf/backup_conf.c| 3 +- src/conf/domain_conf.c|

Re: [libvirt-ci PATCH 06/12] lcitool: Introduce methods to load and validate the YAML config

On Wed, 2020-05-06 at 14:05 +0200, Erik Skultety wrote: > class Config: > > +def __init__(self): > + > +# Load the template config containing the defaults first, this must > +# always succeed. > +# NOTE: we should load this from /usr/share once we start packaging > +

Re: [PATCH 0/2] qemu: Restrict valid configurations for disk type='lun'

On 5/7/20 12:09 PM, Peter Krempa wrote: Please see justification in the commits. This series applies on top of some of the refactors from https://www.redhat.com/archives/libvir-list/2020-May/msg00188.html Peter Krempa (2): qemu: Forbid non-raw images for disk type='lun' with vitio-blk

Re: device hotplug & file handles

On Thu, May 07, 2020 at 16:49:14 +0200, Gerd Hoffmann wrote: > Hi, > > For usb device pass-through (aka -device usb-host) it would be very > useful to pass file handles from libvirt to qemu. The workflow would > change from ... > > (1) libvirt enables access to /dev/usb/$bus/$dev > (2)

Re: [GSoC] Introduction

Hey Radostin, Welcome back to the libvirt community! I am looking forward to a cool project with you this summer. -- Cedric On Thu, 2020-05-07 at 16:16 +0100, Radostin Stoyanov wrote: > Hello everyone, > > As a quick introduction, I’m Radostin Stoyanov, a Google Summer of Code > student from

Re: [libvirt PATCH] libxl: vga.kind none when no device specified

On 5/7/20 5:12 AM, Marek Marczykowski-Górecki wrote: On Thu, Apr 30, 2020 at 02:31:12PM +0200, Artur Puzio wrote: When no video device is specified in config we should set both hvm.nographic to 1 and hvm.vga.kind to NONE. Without hvm.vga.kind=LIBXL_VGA_INTERFACE_TYPE_NONE both -nographic and

Re: [PATCH libvirt v1 0/6] Fix ZPCI address auto-generation on s390

On 5/6/20 1:48 PM, Andrea Bolognani wrote: On Mon, 2020-04-20 at 21:55 +0200, Boris Fiuczynski wrote: On 4/10/20 2:06 PM, Andrea Bolognani wrote: On Thu, 2020-04-09 at 12:30 +0200, Shalini Chellathurai Saroja wrote: The ZPCI address validation or autogeneration does not work as expected in

[libvirt-ci PATCH] lcitool: Catch exceptions earlier

Right now we catch and report properly only those exceptions that are raised by the Application.run() method: basically, we work under the assumption that nothing before that point can possibly fail. That's of course unrealistic: even now, creating an Inventory or Projects object can raise an

Re: [libvirt PATCH v2] libxl: vga.kind none when no device specified

Added Signed-off-by line Artur Puzio On 07.05.2020 13:24, Artur Puzio wrote: > When no video device is specified in config we should set both > hvm.nographic to 1 and hvm.vga.kind to NONE. > > Without hvm.vga.kind=LIBXL_VGA_INTERFACE_TYPE_NONE both -nographic and > -device 'cirrus-vga' are on

[libvirt PATCH v2] libxl: vga.kind none when no device specified

When no video device is specified in config we should set both hvm.nographic to 1 and hvm.vga.kind to NONE. Without hvm.vga.kind=LIBXL_VGA_INTERFACE_TYPE_NONE both -nographic and -device 'cirrus-vga' are on qemu cmdline. Signed-off-by: Artur Puzio --- src/libxl/libxl_conf.c

[GSoC] Introduction

Hello everyone, As a quick introduction, I’m Radostin Stoyanov, a Google Summer of Code student from University of Cambridge. In the next few months I’ll be working with my mentors Cédric Bosdonnat, Pavel Hrdina and Tyler Johnson (Akmod) on the project "Take migration in Salt virt module to

Re: [PATCH 0/8] qemu: caps: Add detection of default device property values and remove deprecated 'scsi=off'

On 5/7/20 7:57 AM, Peter Krempa wrote: First part focuses on allowing the device property code to detect the default values for the properties and the second part then uses it to remove formatting of the deprecated 'scsi=off' for virti-blk-pci. Peter Krempa (8): virQEMUCapsProbeQMPDevices:

device hotplug & file handles

Hi, For usb device pass-through (aka -device usb-host) it would be very useful to pass file handles from libvirt to qemu. The workflow would change from ... (1) libvirt enables access to /dev/usb/$bus/$dev (2) libvirt passes $bus + $dev (using hostbus + hostaddr properties) to qemu.

Re: [libvirt-ci PATCH 05/12] config: Introduce a new global config.yaml configuration file

On Wed, 2020-05-06 at 14:05 +0200, Erik Skultety wrote: > +++ b/guests/config.yaml > @@ -0,0 +1,23 @@ > +--- > +# Configuration file for lcitool > + > +install: The file looks better if you leave an empty line between the section name and the options. > + # Installation flavor determining the

[libvirt PATCH v2] docs: introduce a page showing a overall CI dashboard

With the move to GitLab CI one of the things we miss from Jenkins is a single page dashboard showing CI status across all projects. This is a very simple replacement that uses badges for CI pipeline status. Signed-off-by: Daniel P. Berrangé --- docs/ci.rst | 230

Re: [libvirt-ci PATCH 04/12] lcitool: Use a temporary JSON file to pass extra variables

On Wed, 2020-05-06 at 14:05 +0200, Erik Skultety wrote: > ansible_cfg_path = os.path.join(base, "ansible.cfg") > playbook_base = os.path.join(base, "playbooks", playbook) > playbook_path = os.path.join(playbook_base, "main.yml") > - > -extra_vars = json.dumps({ >

[libvirt-ci PATCH] lcitool: Make Python 3 only

All platforms we care about have Python 3 available. Signed-off-by: Andrea Bolognani --- guests/lcitool | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index ab3b95f..a30187b 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -1,4

Re: [libvirt PATCH 1/2] docs: Convert existing tables to list-table

On Thu, May 07, 2020 at 03:36:55PM +0200, Andrea Bolognani wrote: > On Thu, 2020-05-07 at 14:04 +0100, Daniel P. Berrangé wrote: > > I'm wondering how long we actually need to bother keeping this text, > > given that it is talking about stuff we've already deleted. > > We've started using GLib

Re: [libvirt PATCH 1/2] docs: Convert existing tables to list-table

On Thu, 2020-05-07 at 14:04 +0100, Daniel P. Berrangé wrote: > I'm wondering how long we actually need to bother keeping this text, > given that it is talking about stuff we've already deleted. We've started using GLib six months ago. Do you think that's long enough to drop this page completely?

Re: [libvirt PATCH 1/2] docs: Convert existing tables to list-table

On Thu, 2020-05-07 at 14:03 +0100, Daniel P. Berrangé wrote: > On Thu, May 07, 2020 at 02:55:24PM +0200, Peter Krempa wrote: > > On Thu, May 07, 2020 at 14:46:38 +0200, Andrea Bolognani wrote: > > > -+---++ > >

Re: [libvirt PATCH 1/2] docs: Convert existing tables to list-table

On Thu, May 07, 2020 at 14:04:44 +0100, Daniel Berrange wrote: > On Thu, May 07, 2020 at 02:46:38PM +0200, Andrea Bolognani wrote: > > Signed-off-by: Andrea Bolognani > > --- > > docs/coding-style.rst | 53 +++--- > > docs/glib-adoption.rst | 123

[PATCH 0/2] conf: Properly handle placement of and after blockjobs

Peter Krempa (2): conf: Sanitize handling of and placement for disks conf: Store 'diskElementAuth' and 'diskElementEnc' properties in status XML src/conf/backup_conf.c| 3 +- src/conf/domain_conf.c| 117 +++---

[PATCH 1/2] conf: Sanitize handling of and placement for disks

Modern way to store and of a is under . This was added to mirror how handles these and in fact they are relevant to the source rather than to any other part of the disk. Historically we allowed them to be directly under and we need to keep compatibility. This wasn't a problem until

[PATCH 2/2] conf: Store 'diskElementAuth' and 'diskElementEnc' properties in status XML

Remember the preferred placement of and for a disk source across libvirtd restarts. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c| 20 tests/qemustatusxml2xmldata/modern-in.xml | 4 2 files changed, 24 insertions(+) diff --git

Re: [libvirt-ci PATCH 2/2] containers: add a standard container for running go fmt

On Fri, 2020-05-01 at 11:52 +0100, Daniel P. Berrangé wrote: > +++ b/containers/go-fmt/go-fmt.sh > @@ -0,0 +1,24 @@ > +#!/bin/sh > + > +GOFMT=$(go env GOROOT)/bin/gofmt > + > +find -name '*.go' | xargs $GOFMT -d -e > go-fmt.patch > + > +if test -n go-fmt.patch As pointed out by Martin, this

Re: [libvirt PATCH 1/2] docs: Convert existing tables to list-table

On Thu, May 07, 2020 at 02:46:38PM +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > docs/coding-style.rst | 53 +++--- > docs/glib-adoption.rst | 123 +++-- > 2 files changed, 114 insertions(+), 62 deletions(-) > > diff

Re: [libvirt PATCH 1/2] docs: Convert existing tables to list-table

On Thu, May 07, 2020 at 02:55:24PM +0200, Peter Krempa wrote: > On Thu, May 07, 2020 at 14:46:38 +0200, Andrea Bolognani wrote: > > Signed-off-by: Andrea Bolognani > > --- > > docs/coding-style.rst | 53 +++--- > > docs/glib-adoption.rst | 123

Re: [libvirt-ci PATCH 1/2] gitlab: rename job for building check-dco container

On Fri, 2020-05-01 at 11:52 +0100, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > .gitlab-ci.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Andrea Bolognani -- Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH 1/2] docs: Convert existing tables to list-table

On Thu, May 07, 2020 at 14:46:38 +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > docs/coding-style.rst | 53 +++--- > docs/glib-adoption.rst | 123 +++-- > 2 files changed, 114 insertions(+), 62 deletions(-) > > diff

Re: [perl PATCH v4 1/3] gitlab: add CI jobs for validating build across platforms

On Thu, 2020-05-07 at 12:47 +0100, Daniel P. Berrangé wrote: > On Thu, May 07, 2020 at 12:54:26PM +0200, Andrea Bolognani wrote: > > On Thu, 2020-05-07 at 11:41 +0100, Daniel P. Berrangé wrote: > > > The way we tested RPM builds was a bit gross in CentOS as we were > > > hacking the spec to cut

[libvirt PATCH 1/2] docs: Convert existing tables to list-table

Signed-off-by: Andrea Bolognani --- docs/coding-style.rst | 53 +++--- docs/glib-adoption.rst | 123 +++-- 2 files changed, 114 insertions(+), 62 deletions(-) diff --git a/docs/coding-style.rst b/docs/coding-style.rst index

[libvirt PATCH 2/2] docs: Document list-tables as recommended

Signed-off-by: Andrea Bolognani --- docs/styleguide.rst | 20 1 file changed, 20 insertions(+) diff --git a/docs/styleguide.rst b/docs/styleguide.rst index 3162868fb7..34c5b1573a 100644 --- a/docs/styleguide.rst +++ b/docs/styleguide.rst @@ -77,6 +77,26 @@ which allows for

[libvirt PATCH 0/2] docs: Use list-tables in reStructuredText

It's easier to modify than the ASCII-art alternative. Andrea Bolognani (2): docs: Convert existing tables to list-table docs: Document list-tables as recommended docs/coding-style.rst | 53 +++--- docs/glib-adoption.rst | 123 +++--

Re: [libvirt PATCH] docs: introduce a page showing a overall CI dashboard

On Mon, 2020-05-04 at 13:35 +0100, Daniel P. Berrangé wrote: > +The dashboard below shows the current status of the GitLab CI jobs for each > +repository: > + > +.. raw:: html > + > + > + Language bindings > + > + > + libvirt-csharp > + > +

Re: Google Summer of Code 2020 Student self introduction

Hi Lee, Welcome to the libvirt community. I'm looking forward to a cool project with you for this summer! -- Cedric On Thu, 2020-05-07 at 20:18 +0900, GUOQING LI wrote: > Hi there > > I am Lee, an undergraduate student from Thailand (currently based in Japan) > and I will be working as a

Re: [perl PATCH v2 0/3] gitlab: introduce CI coverage

On Thu, 2020-05-07 at 12:32 +0100, Daniel P. Berrangé wrote: > This series introduces CI jobs for the Perl binding, enabling the switch > over to use of Merge Requests with pre-merge build validation. > > Daniel P. Berrangé (3): > gitlab: add CI jobs for validating build across platforms >

Re: [perl PATCH v4 1/3] gitlab: add CI jobs for validating build across platforms

On Thu, May 07, 2020 at 12:54:26PM +0200, Andrea Bolognani wrote: > On Thu, 2020-05-07 at 11:41 +0100, Daniel P. Berrangé wrote: > > On Thu, May 07, 2020 at 12:04:10PM +0200, Andrea Bolognani wrote: > > > Partially related point: I just realized that, among the projects > > > we've added to GitLab

Re: [perl PATCH v4 3/3] gitlab: add CONTRIBUTING.rst file to indicate use of merge requests

On Thu, 2020-05-07 at 11:51 +0100, Daniel P. Berrangé wrote: > On Thu, May 07, 2020 at 12:14:09PM +0200, Andrea Bolognani wrote: > > On Tue, 2020-05-05 at 12:40 +0100, Daniel P. Berrangé wrote: > > > +++ b/CONTRIBUTING.rst > > > @@ -0,0 +1,28 @@ > > > + > > >

[perl PATCH v2 1/3] gitlab: add CI jobs for validating build across platforms

This introduces CI jobs that replace the current jobs used on Jenkins for every platform except FreeBSD. A merge request workflow requires the user to fork the primary git repo into their personal namespace. In general the changes need to be tested against the current libvirt git master. If the

[perl PATCH v2 0/3] gitlab: introduce CI coverage

This series introduces CI jobs for the Perl binding, enabling the switch over to use of Merge Requests with pre-merge build validation. Daniel P. Berrangé (3): gitlab: add CI jobs for validating build across platforms gitlab: add a simple job that publishes the API docs as HTML gitlab: add

[perl PATCH v2 2/3] gitlab: add a simple job that publishes the API docs as HTML

The Perl modules have inline POD docs. This can be converted to HTML and published as a GitLab artifact. The rendered HTML is kind of ugly but improving this is left as an exercise for the future. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.yml | 15 +++ 1 file changed, 15

[perl PATCH v2 3/3] gitlab: add CONTRIBUTING.rst file to indicate use of merge requests

With the introduction of automated CI pipelines, we are now ready to switch to using merge requests for the project. With this switch we longer wish to have patches sent to the mailing list, and thus the git-publish config is removed. Signed-off-by: Daniel P. Berrangé --- .gitpublish | 4

Re: [PATCH] Unlock the storage pool objects after looking it up

On 5/7/20, Peter Krempa wrote: > On Thu, May 07, 2020 at 18:48:55 +0800, Yi Li wrote: >> The lock should be released. >> >> Signed-off-by: Yi Li >> --- >> src/conf/virstorageobj.c | 6 -- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/src/conf/virstorageobj.c

Google Summer of Code 2020 Student self introduction

Hi there I am Lee, an undergraduate student from Thailand (currently based in Japan) and I will be working as a Student Developer under Google Summer of Code 2020 program. The host organisation is *Libivirt **.* I will be

Re: [libvirt PATCH] docs: introduce a page showing a overall CI dashboard

On Mon, May 04, 2020 at 01:35:17PM +0100, Daniel P. Berrangé wrote: > With the move to GitLab CI one of the things we miss from Jenkins is a > single page dashboard showing CI status across all projects. This is a > very simple replacement that uses badges for CI pipeline status. > >

Re: [libvirt PATCH] libxl: vga.kind none when no device specified

On Thu, Apr 30, 2020 at 02:31:12PM +0200, Artur Puzio wrote: > When no video device is specified in config we should set both > hvm.nographic to 1 and hvm.vga.kind to NONE. > > Without hvm.vga.kind=LIBXL_VGA_INTERFACE_TYPE_NONE both -nographic and > -device 'cirrus-vga' are on qemu cmdline.

Re: [PATCH] Unlock the storage pool objects after looking it up

On Thu, May 07, 2020 at 18:48:55 +0800, Yi Li wrote: > The lock should be released. > > Signed-off-by: Yi Li > --- > src/conf/virstorageobj.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c > index

Re: [perl PATCH v4 1/3] gitlab: add CI jobs for validating build across platforms

On Thu, 2020-05-07 at 11:41 +0100, Daniel P. Berrangé wrote: > On Thu, May 07, 2020 at 12:04:10PM +0200, Andrea Bolognani wrote: > > Partially related point: I just realized that, among the projects > > we've added to GitLab CI so far, I don't think there's a single one > > where we're testing

Re: [perl PATCH v4 3/3] gitlab: add CONTRIBUTING.rst file to indicate use of merge requests

On Thu, May 07, 2020 at 12:14:09PM +0200, Andrea Bolognani wrote: > On Tue, 2020-05-05 at 12:40 +0100, Daniel P. Berrangé wrote: > > +++ b/CONTRIBUTING.rst > > @@ -0,0 +1,28 @@ > > + > > +Contributing to libvirt-perl > > + > > + > > +The

[PATCH] Unlock the storage pool objects after looking it up

The lock should be released. Signed-off-by: Yi Li --- src/conf/virstorageobj.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 13b75b648d..9f24ae67ca 100644 --- a/src/conf/virstorageobj.c +++

Re: [perl PATCH v4 2/3] gitlab: add a simple job that publishes the API docs as HTML

On Thu, May 07, 2020 at 12:11:44PM +0200, Andrea Bolognani wrote: > On Tue, 2020-05-05 at 12:40 +0100, Daniel P. Berrangé wrote: > > +++ b/.gitlab-ci.yml > > @@ -3,6 +3,7 @@ stages: > > +apiref: > > + stage: docs > > + image: perl > > Why are we using a third-party image instead of the CentOS 8

Re: [perl PATCH v4 1/3] gitlab: add CI jobs for validating build across platforms

On Thu, May 07, 2020 at 12:04:10PM +0200, Andrea Bolognani wrote: > On Tue, 2020-05-05 at 12:40 +0100, Daniel P. Berrangé wrote: > > +.git_build_job_template: _build_job_definition > > + image: $CI_REGISTRY_IMAGE/ci-$NAME:latest > > + stage: builds > > + before_script: > > +- export

Re: [perl PATCH v4 3/3] gitlab: add CONTRIBUTING.rst file to indicate use of merge requests

On Tue, 2020-05-05 at 12:40 +0100, Daniel P. Berrangé wrote: > +++ b/CONTRIBUTING.rst > @@ -0,0 +1,28 @@ > + > +Contributing to libvirt-perl > + > + > +The libvirt Perl API binding accepts code contributions via merge requests > +on the

Re: [perl PATCH v4 2/3] gitlab: add a simple job that publishes the API docs as HTML

On Tue, 2020-05-05 at 12:40 +0100, Daniel P. Berrangé wrote: > +++ b/.gitlab-ci.yml > @@ -3,6 +3,7 @@ stages: > +apiref: > + stage: docs > + image: perl Why are we using a third-party image instead of the CentOS 8 based image that we have built specifically for libvirt-perl earlier? > +

[PATCH 1/2] qemu: Forbid non-raw images for disk type='lun' with vitio-blk frontend

Historically the virtio-blk frontend by default enabled SCSI emulation and tried to do SCSI command passthrough. As this was enabled by default there's a fallback mechanism in place in cases when the backend doesn't support SCSI for any reason. This is not the case when disk type=lun is used with

[PATCH 0/2] qemu: Restrict valid configurations for disk type='lun'

Please see justification in the commits. This series applies on top of some of the refactors from https://www.redhat.com/archives/libvir-list/2020-May/msg00188.html Peter Krempa (2): qemu: Forbid non-raw images for disk type='lun' with vitio-blk frontend qemu: domain: Forbid

[PATCH 2/2] qemu: domain: Forbid slice/encryption/copy_on_read with disk type='lun'

Any non-raw block layer feature will not work with raw SCSI command passthrough via 'scsi-block'. Explicitly refuse use of luks encryption, storage slices and copy on read. https://bugzilla.redhat.com/show_bug.cgi?id=1820040 Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 13

Re: [perl PATCH v4 1/3] gitlab: add CI jobs for validating build across platforms

On Tue, 2020-05-05 at 12:40 +0100, Daniel P. Berrangé wrote: > +.git_build_job_template: _build_job_definition > + image: $CI_REGISTRY_IMAGE/ci-$NAME:latest > + stage: builds > + before_script: > +- export MAKEFLAGS="-j$(getconf _NPROCESSORS_ONLN)" > +- export SCRATCH_DIR="/tmp/scratch"

[PATCH v2] qemuProcessStop: Reattach NVMe disks a domain is mirroring into

In v5.10.0-rc1~42 (which was later fixed in v6.0.0-rc1~487) I am removing XATTRs for a file that QEMU is mirroring a disk into but it is killed meanwhile. Well, we can call qemuSecurityRestoreImageLabel() which will not only remove XATTRs but also use them to restore the original owner of the

Re: [go PATCH 3/3] gitlab: add CONTRIBUTING.rst file to indicate use of merge requests

On Tue, 2020-05-05 at 12:44 +0100, Daniel P. Berrangé wrote: > +++ b/CONTRIBUTING.rst > @@ -0,0 +1,28 @@ > +== > +Contributing to libvirt-go > +== > + > +The libvirt Go API binding accepts code contributions via merge requests > +on the GitLab

Re: [go PATCH 2/3] gitlab: introduce CI jobs testing git master & distro libvirt

On Tue, 2020-05-05 at 12:44 +0100, Daniel P. Berrangé wrote: > +++ b/.gitlab-ci.yml > @@ -1,6 +1,57 @@ > +.dist_build_job_template: _build_job_definition > + image: $CI_REGISTRY_IMAGE/ci-$NAME:latest > + stage: builds > + before_script: > +- export MAKEFLAGS="-j$(getconf _NPROCESSORS_ONLN)"

Re: [go PATCH 1/3] Fix tests on Ubuntu 18.04 / Debian 9 with missing screenshot file

On Tue, 2020-05-05 at 12:44 +0100, Daniel P. Berrangé wrote: > Some versions of the Debian packages were missing the install of the > test-screenshot.png file used by the test driver's screenshot impl. > > Signed-off-by: Daniel P. Berrangé > --- > domain_test.go | 5 + > 1 file changed, 5

[PATCH v2 1/2] conf: Add qemu_job_wait_time option

qemu_job_wait_time, a timeout for QEMU jobs, was defined as a fixed value (30 seconds). It is useful if the user can change this value arbitrarily for debugging or tuning purposes. So we move this value to the configuration file so that it can be controlled by the user. Signed-off-by: MIKI

[PATCH v2 2/2] news: add support for qemu_job_wait_time configuration

Signed-off-by: MIKI Nobuhiro --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 4cef804..1f42157 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -44,6 +44,15 @@ + + + conf: Add job wait time

[PATCH v2 0/2] introduces qemu_job_wait_time option

This series introduces qemu_job_wait_time option to configuration file. MIKI Nobuhiro (2): conf: Add qemu_job_wait_time option news: add support for qemu_job_wait_time configuration docs/news.xml | 9 + src/qemu/libvirtd_qemu.aug | 1 +

Re: [PATCH libvirt v1 0/6] Fix ZPCI address auto-generation on s390

On 5/6/20 7:48 PM, Andrea Bolognani wrote: I can remember that you had a discussion with the original author of the zpci code. There are a few issues with the currently implemented "rules" which partially are not even working as you outlined above in more complex scenarios. I disagree with this

Re: [PATCH] conf: Add qemu_job_wait_time option

On 2020/05/04 17:13, Michal Privoznik wrote: >On 5/4/20 10:07 AM, Peter Krempa wrote: >> On Fri, May 01, 2020 at 16:09:04 +0900, MIKI Nobuhiro wrote: >>> The waiting time to acquire the lock times out, which leads to a segment >>> fault. >> >> Could you please elaborate here? Adding this band-aid

Re: Release of libvirt-6.3.0

On Wed, May 06, 2020 at 03:00:08PM -0600, Jim Fehlig wrote: > Hi Daniel, Hi Jim, > On 5/5/20 2:01 AM, Daniel Veillard wrote: > > It's out, tagged in git and the signed sources tarball and rpm are > > available from the usual place: > > > > https://libvirt.org/sources/ > > > > I have

Re: [libvirt PATCH] qemu: Skip pre-creation of NVME disk

On 5/7/20 8:37 AM, Han Han wrote: Unlike the file based disk, NVME disk cannot be pre-created by libvirt. So skip the step of pre-creation. https://bugzilla.redhat.com/show_bug.cgi?id=1823639 Signed-off-by: Han Han --- src/qemu/qemu_migration.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[libvirt PATCH] qemu: Skip pre-creation of NVME disk

Unlike the file based disk, NVME disk cannot be pre-created by libvirt. So skip the step of pre-creation. https://bugzilla.redhat.com/show_bug.cgi?id=1823639 Signed-off-by: Han Han --- src/qemu/qemu_migration.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git