Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

On Tue, Jun 02, 2020 at 09:55:28PM -0600, Alex Williamson wrote: > On Tue, 2 Jun 2020 23:19:48 -0400 > Yan Zhao wrote: > > > On Tue, Jun 02, 2020 at 04:55:27PM -0600, Alex Williamson wrote: > > > On Wed, 29 Apr 2020 20:39:50 -0400 > > > Yan Zhao wrote: > > > > > > > On Wed, Apr 29, 2020 at

Re: [PATCH] libxl: Normalize MAC address in device conf when hotplugging a netdev

On 5/28/20 1:09 PM, Jim Fehlig wrote: Similar to commit 6c17606b7cc, normalize the MAC addresses in persistent and live device config to avoid a different MAC address for the device once the VM is rebooted and persistent config takes affect. Well... This has a bigger change than commit

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

On Tue, 2 Jun 2020 23:19:48 -0400 Yan Zhao wrote: > On Tue, Jun 02, 2020 at 04:55:27PM -0600, Alex Williamson wrote: > > On Wed, 29 Apr 2020 20:39:50 -0400 > > Yan Zhao wrote: > > > > > On Wed, Apr 29, 2020 at 05:48:44PM +0800, Dr. David Alan Gilbert wrote: > > > > > > > > > > > > > > > >

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

On Tue, Jun 02, 2020 at 04:55:27PM -0600, Alex Williamson wrote: > On Wed, 29 Apr 2020 20:39:50 -0400 > Yan Zhao wrote: > > > On Wed, Apr 29, 2020 at 05:48:44PM +0800, Dr. David Alan Gilbert wrote: > > > > > > > > > > > > > > > > > An mdev type is meant to define a software > > > > > > > > > >

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

On Wed, 29 Apr 2020 20:39:50 -0400 Yan Zhao wrote: > On Wed, Apr 29, 2020 at 05:48:44PM +0800, Dr. David Alan Gilbert wrote: > > > > > > > > > > > > > > > An mdev type is meant to define a software > > > > > > > > > > > > > > compatible interface, so in > > > > > > > > > > > > > > the case of

[PATCH] autogen.sh: Restore --no-git (avoid git submodule update)

Prior to 2621d48f005a "gnulib: delete all gnulib integration", one could pass ./autogen.sh --no-git to prevent the libvirt build system from running git submodule update. This feature is needed by systems like the Xen Project CI which want to explicitly control the revisions of every tree. These

[libvirt PATCH v2 1/4] ci: Use variables to build image names

This removes a lot of repetition and makes the configuration much easier to read. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrangé --- .gitlab-ci.yml | 79 -- 1 file changed, 57 insertions(+), 22 deletions(-) diff --git

[libvirt PATCH v2 4/4] ci: Update build system integration

The ci-* targets need to know where our container images are stored and how they are called to work, so now that we use the GitLab container registry instead of Quay some changes are necessary. Signed-off-by: Andrea Bolognani --- ci/Makefile | 6 +++--- ci/list-images.sh | 24

[libvirt PATCH v2 0/4] ci: Use GitLab container registry

Changes from [v1]: * only build containers necessary for extra jobs when said jobs are actually going to run; * rename container build jobs to '$arch-$os-container'; * rename 'other' stage to 'preliminary_checks' and move it before native builds; * simplify build system integration. [v1]

[libvirt PATCH v2 3/4] ci: Use GitLab container registry

Instead of using pre-built containers hosted on Quay, build containers as part of the GitLab CI pipeline and upload them to the GitLab container registry for later use. This will not significantly slow down builds, because containers are only rebuilt when the corresponding Dockerfile has been

[libvirt PATCH v2 2/4] ci: Add 'preliminary_checks' stage

We're going to build container images as part of the CI pipeline soon, which means that we need to move all jobs that run in a container image which is not provided by an external project (such as the one that we use for DCO checking) later in the pipeline or they will fail. Signed-off-by: Andrea

[libvirt PATCH 4/5] news: Convert to reStructuredText

Instead of storing release notes as XML and then converting them to HTML and ASCII at build time using XSLT and a custom script, we can use reStructuredText as both the source and ASCII representation and generate HTML from it using the same tooling we already use for the rest of the

[libvirt PATCH 5/5] news: Add information about old releases

Until libvirt 2.5.0 we didn't have a real process for release notes in place, and we just published the list of commits that had made it into each release, dividing them into categories that mostly matched the sections we use today. Those documents haven't been relevant for years, but they're

[libvirt PATCH 0/5] news: Convert to reStructuredText

Rationale in patch 4/5, in case that diffstat is not enough of a selling point for you ;) Some of the patches in this series are __heavily__ snipped. browse: https://gitlab.com/abologna/libvirt/-/tree/news-convert-cleanup git fetch: https://gitlab.com/abologna/libvirt.git news-convert-cleanup

[libvirt PATCH 1/5] docs: Fix dot_rst_html_in definition

As the name clearly implies, it's supposed to list the .html.in files that are generated from .rst files, but it mistakenly lists the corresponding .html files instead. Signed-off-by: Andrea Bolognani --- docs/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt PATCH 3/5] news: Output reStructuredText for the ASCII version

The ASCII output our scripts produce is already very close to reStructuredText, and with just a few extra tweaks we can get almost all of the way there. Signed-off-by: Andrea Bolognani --- docs/news-ascii.xsl | 40 +--- scripts/reformat-news.py | 12

[libvirt PATCH 2/5] news: Point to GitLab for full git log

The primary git repository is the one on GitLab these days. Signed-off-by: Andrea Bolognani --- docs/news-html.xsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/news-html.xsl b/docs/news-html.xsl index 6bf8bca073..ec031c6d15 100644 --- a/docs/news-html.xsl +++

[PATCH v6 05/10] conf, qemu, security, tests: introducing 'def->tpms' array

A TPM Proxy device can coexist with a regular TPM, but the current domain definition supports only a single TPM device in the 'tpm' pointer. This patch replaces this existing pointer in the domain definition to an array of TPM devices. All files that references the old pointer were adapted to

[PATCH v6 00/10] Introducing TPM Proxy device support for PPC64

No functional changes made from the previous version. Just a rebase and a trivial conflict fix in news.xml after Libvirt 6.4.0 release. changes in v6: - fixed news.xml conflict after 6.4.0 release, moved the change to 6.5.0 - added Stefan's r-b on patches 4, 5 and 6 - added Satheesh's tested-by

[PATCH v6 06/10] qemu: add validations after TPM Proxy model introduction

Previous patch handled the conversion of def->tpm to the array def->tpms and the XML parsing logic. This patch handles the validations needed to ensure the intended behavior. The existing qemuValidateDomainDeviceDefTPM() function was updated to guarantee that the VIR_DOMAIN_TPM_MODEL_SPAPR_PROXY

[PATCH v6 09/10] tests/qemuxml2argvtest.c: add TPM Proxy command line tests

Add tests for both supported scenarios: a single TPM Proxy and a TPM Proxy with a regular TPM device in the same domain. Tested-by: Satheesh Rajendran Reviewed-by: Stefan Berger Signed-off-by: Daniel Henrique Barboza --- .../ppc64-tpmproxy-single.ppc64-latest.args | 34 +

[PATCH v6 03/10] qemu_extdevice.c: remove unneeded 'ret' variable

qemuExtDevicesInitPaths() does not need 'ret'. Tested-by: Satheesh Rajendran Reviewed-by: Stefan Berger Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_extdevice.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_extdevice.c

[PATCH v6 04/10] qemu_tpm, security, tests: change 'switch' clauses for 'if'

This trivial rework is aimed to reduce the amount of line changes made by the next patch, when 'def->tpm' will become a 'def->tpms' array. Instead of using a 'switch' where only the VIR_DOMAIN_TPM_TYPE_EMULATOR label does something, use an 'if' clause instead. Tested-by: Satheesh Rajendran

[PATCH v6 08/10] qemu: build command line for the TPM Proxy device

This patch wraps it up all the wiring done in previous patches, enabling a PPC64 guest to launch a guest using a TPM Proxy device. Note that device validation is already being done in qemu_validate.c, qemuValidateDomainDeviceDefTPM(), on domain define time. We don't need to verify QEMU

[PATCH v6 07/10] tests: add XML schema tests for the TPM Proxy device

This tests aims to exercise how a TPM Proxy device can be added in the domain, either alone or with a regular TPM device. It also ensures that we do not allow bogus scenarios to slip by. Tested-by: Satheesh Rajendran Reviewed-by: Stefan Berger Signed-off-by: Daniel Henrique Barboza ---

[PATCH v6 10/10] docs/news.xml: update for the new TPM Proxy device

Tested-by: Satheesh Rajendran Reviewed-by: Stefan Berger Signed-off-by: Daniel Henrique Barboza --- docs/news.xml | 17 + 1 file changed, 17 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 18d96af048..fc41e53d1d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@

[PATCH v6 02/10] qemu: Extend QEMU capabilities with 'spapr-tpm-proxy'

Expose the TPM Proxy support for PPC64 guests by creating a new cap called QEMU_CAPS_DEVICE_SPAPR_TPM_PROXY. This device is part of the machinery the guest need to orchestrate with the PPC64 Ultravisor the transition to the Secure VM (SVM) mode. Inside QEMU, this device will be used with the

[PATCH v6 01/10] docs: documentation and schema for the new TPM Proxy model

QEMU 4.1.0 introduced a new device type called TPM Proxy, currently implemented by PPC64 guests via a new virtual device called 'spapr-tpm-proxy' (see QEMU 0fb6bd073230 for more info). The TPM Proxy device interacts with a TPM Resource Manager, a host device capable of multiplexing the host TPM

Re: [PATCH] virsysinfo: Parse OEM strings

On 6/2/20 12:56 PM, Daniel P. Berrangé wrote: On Tue, Jun 02, 2020 at 12:53:18PM +0200, Michal Privoznik wrote: Setting OEM strings for a domain was introduced in v4.1.0-rc1~315. However, any application that wanted to use them (e.g. to point to an URL where a config file is stored) had to

Re: [libvirt PATCH 3/5] ci: Use GitLab container registry

On Tue, Jun 02, 2020 at 02:45:30PM +0200, Andrea Bolognani wrote: > On Tue, 2020-06-02 at 12:23 +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 02, 2020 at 01:10:08PM +0200, Andrea Bolognani wrote: > > > On Tue, 2020-06-02 at 11:33 +0100, Daniel P. Berrangé wrote: > > > > I don't think we should

Re: [libvirt PATCH 3/5] ci: Use GitLab container registry

On Tue, 2020-06-02 at 12:23 +0100, Daniel P. Berrangé wrote: > On Tue, Jun 02, 2020 at 01:10:08PM +0200, Andrea Bolognani wrote: > > On Tue, 2020-06-02 at 11:33 +0100, Daniel P. Berrangé wrote: > > > I don't think we should be building container images that we're not going > > > to be using in any

Re: libvirt 6.4.0 is available

On Tue, 2020-06-02 at 12:14 +0200, Daniel Veillard wrote: > I made the release earlier, it is tagged in git and signed source > tarball and rpm are available at the usual place: > >https://libvirt.org/sources/ Can we stop building source RPMs entirely please? We have already agreed that

Re: [libvirt PATCH 4/5] ci: Update build system integration

On Tue, Jun 02, 2020 at 01:22:50PM +0200, Andrea Bolognani wrote: > On Tue, 2020-06-02 at 11:36 +0100, Daniel P. Berrangé wrote: > > On Fri, May 29, 2020 at 03:00:43PM +0200, Andrea Bolognani wrote: > > > +# Registry where container images are stored > > > +CI_IMAGE_REGISTRY = registry.gitlab.com

Re: [libvirt PATCH 5/5] ci: Improve CI_IMAGE_TAG handling

On Tue, 2020-06-02 at 11:37 +0100, Daniel P. Berrangé wrote: > On Fri, May 29, 2020 at 03:00:44PM +0200, Andrea Bolognani wrote: > > -# The default tag is ':latest' but if the container > > +# The default tag is 'latest' but if the container > > # repo above uses different conventions this can

Re: [libvirt PATCH 4/5] ci: Update build system integration

On Tue, 2020-06-02 at 11:36 +0100, Daniel P. Berrangé wrote: > On Fri, May 29, 2020 at 03:00:43PM +0200, Andrea Bolognani wrote: > > +# Registry where container images are stored > > +CI_IMAGE_REGISTRY = registry.gitlab.com > > + > > # Location of the container images we're going to pull > > #

Re: [libvirt PATCH 3/5] ci: Use GitLab container registry

On Tue, Jun 02, 2020 at 01:10:08PM +0200, Andrea Bolognani wrote: > On Tue, 2020-06-02 at 11:33 +0100, Daniel P. Berrangé wrote: > > On Fri, May 29, 2020 at 03:00:42PM +0200, Andrea Bolognani wrote: > > > +# We build many containers which can be useful to debug problems but are > > > not > > > +#

Re: [libvirt PATCH 3/5] ci: Use GitLab container registry

On Tue, 2020-06-02 at 11:33 +0100, Daniel P. Berrangé wrote: > On Fri, May 29, 2020 at 03:00:42PM +0200, Andrea Bolognani wrote: > > +# We build many containers which can be useful to debug problems but are > > not > > +# needed for the pipeline itself to complete: those sometimes fail, and > >

Re: [libvirt PATCH 2/5] ci: Add 'other' stage

On Tue, 2020-06-02 at 11:26 +0100, Daniel P. Berrangé wrote: > On Fri, May 29, 2020 at 03:00:41PM +0200, Andrea Bolognani wrote: > > +++ b/.gitlab-ci.yml > > @@ -5,6 +5,7 @@ stages: > >- prebuild > >- native_build > >- cross_build > > + - other > > Can we keep this before the

Re: [PATCH] virsysinfo: Parse OEM strings

On Tue, Jun 02, 2020 at 12:53:18PM +0200, Michal Privoznik wrote: > Setting OEM strings for a domain was introduced in > v4.1.0-rc1~315. However, any application that wanted to use them > (e.g. to point to an URL where a config file is stored) had to > 'dmidecode -u --oem-string N' (where N is

[PATCH] virsysinfo: Parse OEM strings

Setting OEM strings for a domain was introduced in v4.1.0-rc1~315. However, any application that wanted to use them (e.g. to point to an URL where a config file is stored) had to 'dmidecode -u --oem-string N' (where N is index of the string). Well, we can expose them under our XML and if the

Re: [libvirt PATCH 4/5] ci: Update build system integration

On Fri, May 29, 2020 at 03:00:43PM +0200, Andrea Bolognani wrote: > The ci-* targets need to know where our container images are stored > and how they are called to work, so now that we use the GitLab > container registry instead of Quay some changes are necessary. > > Signed-off-by: Andrea

Re: [libvirt PATCH 5/5] ci: Improve CI_IMAGE_TAG handling

On Fri, May 29, 2020 at 03:00:44PM +0200, Andrea Bolognani wrote: > Since we're already building the full container image reference > dynamically at this point, we can finally get rid of the annoying > requirement to include ":" in CI_IMAGE_TAG. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt PATCH 3/5] ci: Use GitLab container registry

On Fri, May 29, 2020 at 03:00:42PM +0200, Andrea Bolognani wrote: > Instead of using pre-built containers hosted on Quay, build > containers as part of the GitLab CI pipeline and upload them to the > GitLab container registry for later use. > > This will not significantly slow down builds,

Re: [libvirt PATCH 2/5] ci: Add 'other' stage

On Fri, May 29, 2020 at 03:00:41PM +0200, Andrea Bolognani wrote: > We're going to build container images as part of the CI pipeline > soon, which means that we need to move all jobs that run in a > container image which is not provided by an external project (such > as the one that we use for DCO

Re: [libvirt PATCH 1/5] ci: Use variables to build image names

On Fri, May 29, 2020 at 03:00:40PM +0200, Andrea Bolognani wrote: > This removes a lot of repetition and makes the configuration much > easier to read. > > Signed-off-by: Andrea Bolognani > --- > .gitlab-ci.yml | 79 -- > 1 file changed, 57

libvirt 6.4.0 is available

I made the release earlier, it is tagged in git and signed source tarball and rpm are available at the usual place: https://libvirt.org/sources/ I didn't push an RC2 this week end as there was no code change from RC1 only a bug fix made its way yesterday. I also pushed a python binding

Re: [PATCH 0/3] Rmove support of tftp storage protocol

On 22.05.20 04:07, Han Han wrote: > > > On Thu, May 21, 2020 at 5:21 PM Daniel P. Berrangé > wrote: > > On Thu, May 21, 2020 at 04:05:47PM +0800, Han Han wrote: > > On Thu, May 21, 2020 at 2:44 PM Peter Krempa > wrote: > >

[libvirt PATCH] maint: Post-release version bump to 6.5.0

Signed-off-by: Andrea Bolognani --- Pushed as trivial. configure.ac | 2 +- docs/news.xml | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 73dc9f841c..6c8ac2f04b 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You

Re: [libvirt PATCH] news: Update for libvirt 6.4.0

On 6/2/20 10:24 AM, Andrea Bolognani wrote: Signed-off-by: Andrea Bolognani --- docs/news.xml | 45 + 1 file changed, 45 insertions(+) Reviewed-by: Michal Privoznik Michal

[libvirt PATCH] gitdm: Add missing entries

A few new individuals have contributed to libvirt since the last time the gitdm configuration was updated. Signed-off-by: Andrea Bolognani --- docs/gitdm/groups/unaffiliated | 4 1 file changed, 4 insertions(+) diff --git a/docs/gitdm/groups/unaffiliated b/docs/gitdm/groups/unaffiliated

Re: [PATCH 5/5] qemu_validate.c: revert NUMA CPU range user warning

On Mon, 1 Jun 2020 17:14:20 -0300 Daniel Henrique Barboza wrote: > On 6/1/20 4:40 PM, Peter Krempa wrote: > > On Mon, Jun 01, 2020 at 14:50:41 -0300, Daniel Henrique Barboza wrote: > >> Now that we have the auto-fill code in place, and with proper documentation > >> to let the user know that

Re: [PATCH v2 1/7] util: introduce a parser for kernel cmdline arguments

Paulo de Rezende Pinatti [2020-05-29, 12:10PM +0200]: > Introduce two utility functions to parse a kernel command > line string according to the kernel code parsing rules in > order to enable the caller to perform operations such as > verifying whether certain argument=value combinations are >

[PATCH] numa: forbid '-numa node, mem' for 5.1 and newer machine types

Deprecation period is run out and it's a time to flip the switch introduced by cd5ff8333a. Disable legacy option for new machine types (since 5.1) and amend documentation. '-numa node,memdev' shall be used instead of disabled option with new machine types. Signed-off-by: Igor Mammedov --- -

[libvirt PATCH] news: Update for libvirt 6.4.0

Signed-off-by: Andrea Bolognani --- docs/news.xml | 45 + 1 file changed, 45 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 104babbae7..956af3036b 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -44,6 +44,24 @@ + +

Re: [PATCH libvirt v1 0/6] Fix ZPCI address auto-generation on s390

On 6/1/20 6:49 PM, Andrea Bolognani wrote: On Wed, 2020-05-20 at 13:32 +0200, Boris Fiuczynski wrote: If I do not misinterpret Dan's last mail he agrees that specifying uid=0 should be considered as error. How do we proceed from here? Shalini series still can be applied on master cleanly. Do