Re: [libvirt PATCH v2 08/15] nwfilter: remove unnecessary code from ebtablesGetSubChainInsts()

2020-07-17 Thread Laine Stump
On 7/15/20 11:30 AM, Ján Tomko wrote: On a Tuesday in 2020, Laine Stump wrote: On failure, this function would clear out and free the list of subchains it had been called with. This is unnecessary, because the *only* caller of this function will also clear out and free the list of subchains if

[PATCH] network: refactor networkSetIPv6Sysctls() for proper g_autofree usage

2020-07-17 Thread Laine Stump
This function used the same char* three times for different purposes, freeing it after each use. Since we don't want to ever manually free an autofree'd pointer, modify it to use three separate char*, and make them all g_autofree. Signed-off-by: Laine Stump --- This was suggested by Jan in

[PATCH 1/5] qemu_process.h: register AUTOPTR_CLEANUP_FUNC for qemuProcessQMPPtr

2020-07-17 Thread Daniel Henrique Barboza
Next patches will use g_autoptr() in qemuProcessQMPPtr pointers for some cleanups in QMP code. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_process.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_process.h b/src/qemu/qemu_process.h index 15e67b9762..125508f9fe

[PATCH 4/5] qemu_driver.c: modernize qemuConnectCPUModelComparison()

2020-07-17 Thread Daniel Henrique Barboza
Use g_auto* on pointers to avoid using the 'cleanup' label. In theory the 'ret' variable can also be discarded if the flow of the logic is reworked. Perhaps another time. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_driver.c | 13 + 1 file changed, 5 insertions(+), 8

[PATCH 3/5] qemu_driver.c: modernize qemuConnectCPUModelBaseline()

2020-07-17 Thread Daniel Henrique Barboza
Use g_autoptr() on pointers and remove the unneeded 'cleanup' label. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_driver.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[PATCH 0/5] trivial qemuProcessQMPPtr related cleanups

2020-07-17 Thread Daniel Henrique Barboza
Hi, These are some simple cleanups related to the qemuProcessQMPPtr pointer I ended up making while trying to understand how and when qemuProcessQMPFree() is called. Daniel Henrique Barboza (5): qemu_process.h: register AUTOPTR_CLEANUP_FUNC for qemuProcessQMPPtr qemu_process.c: modernize

[PATCH 5/5] qemu_capabilities.c: use g_autoptr() in virQEMUCapsInitQMPSingle()

2020-07-17 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_capabilities.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 98ddd2dcdc..1a2cb874c0 100644 --- a/src/qemu/qemu_capabilities.c +++

[PATCH 2/5] qemu_process.c: modernize qemuProcessQMPNew()

2020-07-17 Thread Daniel Henrique Barboza
Use g_autoptr() and remove the 'cleanup' label. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_process.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 70fc24b993..a11eedda16 100644 ---

Re: [PATCH] qemu: clear residual QMP caps processes during QEMU driver initialization

2020-07-17 Thread Daniel Henrique Barboza
On 7/17/20 8:10 AM, Bihong Yu wrote: From c328ff62b11d58553fd2032a85fd3295e009b3d3 Mon Sep 17 00:00:00 2001 From: Bihong Yu Date: Fri, 17 Jul 2020 16:55:12 +0800 Subject: [PATCH] qemu: clear residual QMP caps processes during QEMU driver initialization In some cases, the QMP capabilities

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Pavel Hrdina
On Fri, Jul 17, 2020 at 05:16:00PM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 17, 2020 at 03:51:21PM +0100, Daniel P. Berrangé wrote: > > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > > > So I was finally able to produce the patches to port libvirt to Meson. > > > Obviously,

Re: device compatibility interface for live migration with assigned devices

2020-07-17 Thread Alex Williamson
On Fri, 17 Jul 2020 19:03:44 +0100 "Dr. David Alan Gilbert" wrote: > * Alex Williamson (alex.william...@redhat.com) wrote: > > On Wed, 15 Jul 2020 16:20:41 +0800 > > Yan Zhao wrote: > > > > > On Tue, Jul 14, 2020 at 02:59:48PM -0600, Alex Williamson wrote: > > > > On Tue, 14 Jul 2020

Re: device compatibility interface for live migration with assigned devices

2020-07-17 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Wed, 15 Jul 2020 16:20:41 +0800 > Yan Zhao wrote: > > > On Tue, Jul 14, 2020 at 02:59:48PM -0600, Alex Williamson wrote: > > > On Tue, 14 Jul 2020 18:19:46 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Alex Williamson

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Daniel P . Berrangé
On Fri, Jul 17, 2020 at 07:50:35PM +0200, Pavel Hrdina wrote: > On Fri, Jul 17, 2020 at 03:51:21PM +0100, Daniel P. Berrangé wrote: > > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > > > So I was finally able to produce the patches to port libvirt to Meson. > > > Obviously, it is

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Pavel Hrdina
On Fri, Jul 17, 2020 at 07:00:07PM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 17, 2020 at 07:50:35PM +0200, Pavel Hrdina wrote: > > On Fri, Jul 17, 2020 at 03:51:21PM +0100, Daniel P. Berrangé wrote: > > > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > > > > So I was finally

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Pavel Hrdina
On Fri, Jul 17, 2020 at 03:51:21PM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > > So I was finally able to produce the patches to port libvirt to Meson. > > Obviously, it is a lot of changes. It might look that some of the > > patches could be

Re: Format/style of UI message

2020-07-17 Thread Peter Krempa
On Fri, Jul 17, 2020 at 17:01:47 +0200, Pino Toscano wrote: > Hi, > > I recently took a look at the UI/user visible messages from libvirt, > which are translated using gettext. They are extracted in a single > libvirt.pot catalog, which includes messages from libvirt.so itself > (mostly, if not

Re: [libvirt PATCH 00/16] Add support for persistent mediated devices

2020-07-17 Thread Jonathon Jongsma
On Fri, 2020-07-17 at 10:08 +0200, Erik Skultety wrote: > On Thu, Jul 16, 2020 at 05:21:30PM -0500, Jonathon Jongsma wrote: > > This patch series follows the previously-merged series which added > > support for > > transient mediated devices. This series expands mdev support to > > include > >

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Martin Kletzander
On Fri, Jul 17, 2020 at 03:12:00PM +0100, Daniel P. Berrangé wrote: On Fri, Jul 17, 2020 at 04:10:01PM +0200, Pavel Hrdina wrote: On Fri, Jul 17, 2020 at 03:02:10PM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 16, 2020 at 03:44:25PM +0200, Pavel Hrdina wrote: > > On Thu, Jul 16, 2020 at

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Pavel Hrdina
On Fri, Jul 17, 2020 at 03:28:52PM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > > So I was finally able to produce the patches to port libvirt to Meson. > > Obviously, it is a lot of changes. It might look that some of the > > patches could be

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Pavel Hrdina
On Fri, Jul 17, 2020 at 06:14:13PM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 17, 2020 at 07:00:44PM +0200, Pavel Hrdina wrote: > > On Fri, Jul 17, 2020 at 03:24:38PM +0100, Daniel P. Berrangé wrote: > > > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > > > > So I was finally

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Daniel P . Berrangé
On Fri, Jul 17, 2020 at 07:00:44PM +0200, Pavel Hrdina wrote: > On Fri, Jul 17, 2020 at 03:24:38PM +0100, Daniel P. Berrangé wrote: > > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > > > So I was finally able to produce the patches to port libvirt to Meson. > > > Obviously, it is

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Pavel Hrdina
On Fri, Jul 17, 2020 at 05:03:31PM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 17, 2020 at 05:49:42PM +0200, Pavel Hrdina wrote: > > On Fri, Jul 17, 2020 at 04:53:28PM +0200, Peter Krempa wrote: > > > > usr/share/doc/libvirt-docs/README is a symlink with meson ... the > > > automake version >

Re: [libvirt PATCH 0/3] Fix migration with host-passthrough CPU

2020-07-17 Thread Daniel Henrique Barboza
On 7/16/20 5:08 PM, Jiri Denemark wrote: Fixes a regression in libvirt 6.5.0 caused by commit 201bd5db63. See patches 2 and 3 for details. Jiri Denemark (3): qemu_monitor: Add API for checking CPU migratable property qemu: Do not set //cpu/@migratable for running domains in post-parse

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Pavel Hrdina
On Fri, Jul 17, 2020 at 03:24:38PM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > > So I was finally able to produce the patches to port libvirt to Meson. > > Obviously, it is a lot of changes. It might look that some of the > > patches could be

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Daniel P . Berrangé
On Fri, Jul 17, 2020 at 03:51:21PM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > > So I was finally able to produce the patches to port libvirt to Meson. > > Obviously, it is a lot of changes. It might look that some of the > > patches could be

Re: device compatibility interface for live migration with assigned devices

2020-07-17 Thread Alex Williamson
On Thu, 16 Jul 2020 16:32:30 +0800 Yan Zhao wrote: > On Thu, Jul 16, 2020 at 12:16:26PM +0800, Jason Wang wrote: > > > > On 2020/7/14 上午7:29, Yan Zhao wrote: > > > hi folks, > > > we are defining a device migration compatibility interface that helps > > > upper > > > layer stack like

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Daniel P . Berrangé
On Fri, Jul 17, 2020 at 05:49:42PM +0200, Pavel Hrdina wrote: > On Fri, Jul 17, 2020 at 04:53:28PM +0200, Peter Krempa wrote: > > usr/share/doc/libvirt-docs/README is a symlink with meson ... the > > automake version > > doesn't differ. Is it even worth having them? > > The symlink is also in

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Pavel Hrdina
On Fri, Jul 17, 2020 at 04:18:52PM +0200, Peter Krempa wrote: > On Fri, Jul 17, 2020 at 16:04:16 +0200, Peter Krempa wrote: > > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote: > > > > I've tried building RPMs both from the pre-patch tree state and after > > your patchset. I've then

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Pavel Hrdina
On Fri, Jul 17, 2020 at 04:53:28PM +0200, Peter Krempa wrote: > On Fri, Jul 17, 2020 at 16:37:45 +0200, Peter Krempa wrote: > > On Fri, Jul 17, 2020 at 16:31:05 +0200, Peter Krempa wrote: > > > On Fri, Jul 17, 2020 at 16:18:52 +0200, Peter Krempa wrote: > > > > On Fri, Jul 17, 2020 at 16:04:16

Re: Format/style of UI message

2020-07-17 Thread Daniel P . Berrangé
On Fri, Jul 17, 2020 at 05:01:47PM +0200, Pino Toscano wrote: > Hi, > > I recently took a look at the UI/user visible messages from libvirt, > which are translated using gettext. They are extracted in a single > libvirt.pot catalog, which includes messages from libvirt.so itself > (mostly, if not

Re: device compatibility interface for live migration with assigned devices

2020-07-17 Thread Alex Williamson
On Wed, 15 Jul 2020 15:37:19 +0800 Alex Xu wrote: > Alex Williamson 于2020年7月15日周三 上午5:00写道: > > > On Tue, 14 Jul 2020 18:19:46 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > > On Tue, 14 Jul 2020 11:21:29 +0100 > > > >

Format/style of UI message

2020-07-17 Thread Pino Toscano
Hi, I recently took a look at the UI/user visible messages from libvirt, which are translated using gettext. They are extracted in a single libvirt.pot catalog, which includes messages from libvirt.so itself (mostly, if not all, errors), the separate daemons, the helper tools, and from virsh. I

Re: device compatibility interface for live migration with assigned devices

2020-07-17 Thread Alex Williamson
On Wed, 15 Jul 2020 16:20:41 +0800 Yan Zhao wrote: > On Tue, Jul 14, 2020 at 02:59:48PM -0600, Alex Williamson wrote: > > On Tue, 14 Jul 2020 18:19:46 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > > On Tue, 14 Jul 2020

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Pavel Hrdina
On Fri, Jul 17, 2020 at 04:37:45PM +0200, Peter Krempa wrote: > On Fri, Jul 17, 2020 at 16:31:05 +0200, Peter Krempa wrote: > > On Fri, Jul 17, 2020 at 16:18:52 +0200, Peter Krempa wrote: > > > On Fri, Jul 17, 2020 at 16:04:16 +0200, Peter Krempa wrote: > > > > On Thu, Jul 16, 2020 at 11:53:56

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Peter Krempa
On Fri, Jul 17, 2020 at 16:37:45 +0200, Peter Krempa wrote: > On Fri, Jul 17, 2020 at 16:31:05 +0200, Peter Krempa wrote: > > On Fri, Jul 17, 2020 at 16:18:52 +0200, Peter Krempa wrote: > > > On Fri, Jul 17, 2020 at 16:04:16 +0200, Peter Krempa wrote: > > > > On Thu, Jul 16, 2020 at 11:53:56

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > So I was finally able to produce the patches to port libvirt to Meson. > Obviously, it is a lot of changes. It might look that some of the > patches could be squashed together but I would rather have it as > separated as possible to

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Peter Krempa
On Fri, Jul 17, 2020 at 16:31:05 +0200, Peter Krempa wrote: > On Fri, Jul 17, 2020 at 16:18:52 +0200, Peter Krempa wrote: > > On Fri, Jul 17, 2020 at 16:04:16 +0200, Peter Krempa wrote: > > > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote: > > > > > > I've tried building RPMs both

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Pavel Hrdina
On Fri, Jul 17, 2020 at 04:31:05PM +0200, Peter Krempa wrote: > On Fri, Jul 17, 2020 at 16:18:52 +0200, Peter Krempa wrote: > > On Fri, Jul 17, 2020 at 16:04:16 +0200, Peter Krempa wrote: > > > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote: > > > > > > I've tried building RPMs both

Re: [PATCH] Qemu: migration: Not bind RAM info with active migration status

2020-07-17 Thread Daniel Henrique Barboza
On 7/15/20 3:18 AM, Keqian Zhu wrote: For that Qemu supports returning incoming migration info since its commit 65ace0604551 (migration: add postcopy total blocktime into query-migrate), It is worth saying that this QEMU commit that decoupled the RAM status from the active migration status

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Peter Krempa
On Fri, Jul 17, 2020 at 16:18:52 +0200, Peter Krempa wrote: > On Fri, Jul 17, 2020 at 16:04:16 +0200, Peter Krempa wrote: > > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote: > > > > I've tried building RPMs both from the pre-patch tree state and after > > your patchset. I've then

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > So I was finally able to produce the patches to port libvirt to Meson. > Obviously, it is a lot of changes. It might look that some of the > patches could be squashed together but I would rather have it as > separated as possible to

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > So I was finally able to produce the patches to port libvirt to Meson. > Obviously, it is a lot of changes. It might look that some of the > patches could be squashed together but I would rather have it as > separated as possible to

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Pavel Hrdina
On Fri, Jul 17, 2020 at 04:04:16PM +0200, Peter Krempa wrote: > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote: > > I've tried building RPMs both from the pre-patch tree state and after > your patchset. I've then extracted all the RPMs toghether and compared > the file lists (minus

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Peter Krempa
On Fri, Jul 17, 2020 at 16:04:16 +0200, Peter Krempa wrote: > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote: > > I've tried building RPMs both from the pre-patch tree state and after > your patchset. I've then extracted all the RPMs toghether and compared > the file lists (minus the

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-07-17 Thread Peter Xu
On Thu, Jul 16, 2020 at 10:54:31AM +0800, Jason Wang wrote: > > On 2020/7/16 上午9:00, Peter Xu wrote: > > On Mon, Jul 13, 2020 at 12:04:16PM +0800, Jason Wang wrote: > > > On 2020/7/10 下午9:30, Peter Xu wrote: > > > > On Fri, Jul 10, 2020 at 02:34:11PM +0800, Jason Wang wrote: > > > > > On 2020/7/9

[PATCH] virNetSocketCheckProtocols: Actually check bool value

2020-07-17 Thread Michal Privoznik
In 9536379da4c8ed61 and 8b0cb0e666f I've tried to call virNetSocketCheckProtocolByLookup() only if we are suspecting the host is IPv4 or IPv6 capable (because we've found an interface with such address). However, the code was missing dereference of the boolean variables and thus was comparing

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Daniel P . Berrangé
On Fri, Jul 17, 2020 at 04:10:01PM +0200, Pavel Hrdina wrote: > On Fri, Jul 17, 2020 at 03:02:10PM +0100, Daniel P. Berrangé wrote: > > On Thu, Jul 16, 2020 at 03:44:25PM +0200, Pavel Hrdina wrote: > > > On Thu, Jul 16, 2020 at 01:59:00PM +0100, Daniel P. Berrangé wrote: > > > > Personally I'd

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Pavel Hrdina
On Fri, Jul 17, 2020 at 03:02:10PM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 16, 2020 at 03:44:25PM +0200, Pavel Hrdina wrote: > > On Thu, Jul 16, 2020 at 01:59:00PM +0100, Daniel P. Berrangé wrote: > > > Personally I'd really like to avoid squashing them, because splitting > > > up big

Re: [PATCH] qemu: Remove superfluous breaks

2020-07-17 Thread Daniel Henrique Barboza
On 7/16/20 11:00 PM, Yi Wang wrote: From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang --- Reviewed-by: Daniel Henrique Barboza src/qemu/qemu_firmware.c | 1 - src/qemu/qemu_hostdev.c | 1 - 2

Re: [PATCH] conf: Remove superfluous breaks

2020-07-17 Thread Daniel Henrique Barboza
On 7/16/20 11:00 PM, Yi Wang wrote: From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang Reviewed-by: Daniel Henrique Barboza --- src/conf/domain_conf.c | 6 -- src/conf/network_conf.c|

Re: [PATCH] security: Remove the superfluous break

2020-07-17 Thread Daniel Henrique Barboza
On 7/16/20 11:00 PM, Yi Wang wrote: From: Liao Pingfang Remove the superfuous break, as there is a 'return' before it. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang --- Reviewed-by: Daniel Henrique Barboza src/security/security_apparmor.c | 1 - 1 file changed, 1

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 03:44:25PM +0200, Pavel Hrdina wrote: > On Thu, Jul 16, 2020 at 01:59:00PM +0100, Daniel P. Berrangé wrote: > > Personally I'd really like to avoid squashing them, because splitting > > up big patches is not merely to benefit the initial pre-merge review, > > but to also

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Peter Krempa
On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote: I've tried building RPMs both from the pre-patch tree state and after your patchset. I've then extracted all the RPMs toghether and compared the file lists (minus the 'build-id' directory which differs). I'm not sure whether it's due to

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Pavel Hrdina
On Fri, Jul 17, 2020 at 03:45:36PM +0200, Peter Krempa wrote: > On Fri, Jul 17, 2020 at 11:39:15 +0200, Pavel Hrdina wrote: > > On Fri, Jul 17, 2020 at 11:21:56AM +0200, Peter Krempa wrote: > > > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote: > > > > > > [...] > > > > > > Tests fail

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Peter Krempa
On Fri, Jul 17, 2020 at 11:39:15 +0200, Pavel Hrdina wrote: > On Fri, Jul 17, 2020 at 11:21:56AM +0200, Peter Krempa wrote: > > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote: > > > > [...] > > > > Tests fail when building with clang: > > > > built as: > > > > CC=clang meson clang

[PATCH v2 2/2] qemu: allow configuring mem-path for ivshmem-plain device

2020-07-17 Thread Wang Xin
The shared memory path is generated by shmem name as default, however, we may need to change it to avoid filename conflict when VM migrate to other host. Signed-off-by: Yang Hang Signed-off-by: Wang Xin diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index

[PATCH v2 1/2] qemu: add support for shmem-{plain, doorbell} role

2020-07-17 Thread Wang Xin
Role(master or peer) controls how the domain behaves on migration. For more details about migration with ivshmem, see https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/system/ivshmem.rst;hb=HEAD It's a optional attribute in libvirt, and qemu will choose default role for ivshmem device if the

[PATCH] qemu: clear residual QMP caps processes during QEMU driver initialization

2020-07-17 Thread Bihong Yu
>From c328ff62b11d58553fd2032a85fd3295e009b3d3 Mon Sep 17 00:00:00 2001 From: Bihong Yu Date: Fri, 17 Jul 2020 16:55:12 +0800 Subject: [PATCH] qemu: clear residual QMP caps processes during QEMU driver initialization In some cases, the QMP capabilities processes possible residue. So we need to

Re: [PATCH 2/3] virNetSocketCheckProtocols: lookup IPv6 only if suspecting IPv6

2020-07-17 Thread Michal Prívozník
On 7/17/20 12:33 PM, John Ferlan wrote: On 7/15/20 7:48 AM, Michal Privoznik wrote: There is not much sense trying to disprove host is IPv6 capable if we know after first round (getifaddrs()) that is is not. Signed-off-by: Michal Privoznik --- src/rpc/virnetsocket.c | 3 ++- 1 file

Re: [PATCH 2/3] virNetSocketCheckProtocols: lookup IPv6 only if suspecting IPv6

2020-07-17 Thread John Ferlan
On 7/15/20 7:48 AM, Michal Privoznik wrote: > There is not much sense trying to disprove host is IPv6 capable > if we know after first round (getifaddrs()) that is is not. > > Signed-off-by: Michal Privoznik > --- > src/rpc/virnetsocket.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [libvirt PATCH] docs: fix compilation instructions to use separate build dir

2020-07-17 Thread Andrea Bolognani
On Fri, 2020-07-17 at 10:50 +0100, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > docs/compiling.html.in | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Andrea Bolognani -- Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Daniel P . Berrangé
On Fri, Jul 17, 2020 at 12:06:54PM +0200, Ján Tomko wrote: > On a Friday in 2020, Pavel Hrdina wrote: > > On Fri, Jul 17, 2020 at 11:21:56AM +0200, Peter Krempa wrote: > > > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote: > > > > > > [...] > > > > > > Tests fail when building with

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Ján Tomko
On a Friday in 2020, Pavel Hrdina wrote: On Fri, Jul 17, 2020 at 11:21:56AM +0200, Peter Krempa wrote: On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote: [...] Tests fail when building with clang: built as: CC=clang meson clang ~/libvirt cd clang ninja ninja test Looking at

Re: [libvirt PATCH] docs: fix compilation instructions to use separate build dir

2020-07-17 Thread Pavel Hrdina
On Fri, Jul 17, 2020 at 10:50:43AM +0100, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > docs/compiling.html.in | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature

[libvirt PATCH] docs: fix compilation instructions to use separate build dir

2020-07-17 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- docs/compiling.html.in | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/compiling.html.in b/docs/compiling.html.in index 0e12a9218e..18943a9a79 100644 --- a/docs/compiling.html.in +++ b/docs/compiling.html.in @@ -76,7 +76,8 @@ $

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Pavel Hrdina
On Fri, Jul 17, 2020 at 11:21:56AM +0200, Peter Krempa wrote: > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote: > > [...] > > Tests fail when building with clang: > > built as: > > CC=clang meson clang ~/libvirt > cd clang > ninja > ninja test > > > Looking at the test output

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-17 Thread Peter Krempa
On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote: [...] Tests fail when building with clang: built as: CC=clang meson clang ~/libvirt cd clang ninja ninja test Looking at the test output (pasted below) you didn't faithfully reproduce the skipping of symbol file tests which have

Re: [libvirt PATCH 00/16] Add support for persistent mediated devices

2020-07-17 Thread Daniel P . Berrangé
On Fri, Jul 17, 2020 at 10:08:59AM +0200, Erik Skultety wrote: > On Thu, Jul 16, 2020 at 05:21:30PM -0500, Jonathon Jongsma wrote: > > This patch series follows the previously-merged series which added support > > for > > transient mediated devices. This series expands mdev support to include > >

Re: [libvirt PATCH] manpages/virsh: Clarify the meaning of the '--current' flag

2020-07-17 Thread Kashyap Chamarthy
On Fri, Jul 17, 2020 at 10:46:22AM +0200, Peter Krempa wrote: > On Fri, Jul 17, 2020 at 10:38:32 +0200, Kashyap Chamarthy wrote: > > On Thu, Jul 16, 2020 at 06:34:21PM +0200, Peter Krempa wrote: > > > On Thu, Jul 16, 2020 at 17:45:21 +0200, Kashyap Chamarthy wrote: [...] > > > > -If *--current*

Re: [libvirt PATCH] manpages/virsh: Clarify the meaning of the '--current' flag

2020-07-17 Thread Peter Krempa
On Fri, Jul 17, 2020 at 10:38:32 +0200, Kashyap Chamarthy wrote: > On Thu, Jul 16, 2020 at 06:34:21PM +0200, Peter Krempa wrote: > > On Thu, Jul 16, 2020 at 17:45:21 +0200, Kashyap Chamarthy wrote: > > [...] > > > > --- > > > For 'iothreadset', the documentation says: > > > > > > "If

Re: [libvirt PATCH] manpages/virsh: Clarify the meaning of the '--current' flag

2020-07-17 Thread Kashyap Chamarthy
On Thu, Jul 16, 2020 at 06:34:21PM +0200, Peter Krempa wrote: > On Thu, Jul 16, 2020 at 17:45:21 +0200, Kashyap Chamarthy wrote: [...] > > --- > > For 'iothreadset', the documentation says: > > > > "If *--current* is specified or *--live* is not specified, then > > handle as if *--live*

Re: [libvirt PATCH 00/16] Add support for persistent mediated devices

2020-07-17 Thread Erik Skultety
On Thu, Jul 16, 2020 at 05:21:30PM -0500, Jonathon Jongsma wrote: > This patch series follows the previously-merged series which added support for > transient mediated devices. This series expands mdev support to include > persistent device definitions. Again, it relies on mdevctl as the backend.

Re: [libvirt PATCH] Partially revert "qemu: fix missing error reports in capabilities probing"

2020-07-17 Thread Michal Prívozník
On 7/15/20 5:08 PM, Daniel P. Berrangé wrote: This partially reverts commit 5331c4804f4f419b9e75741084f926e52413d3a1. The original commit mistakenly thought virFileCacheLookup did not set an error. In fact the only case it doesn't set an error for is when the cache key is NULL. This in fact the

Re: [PATCH] qemuDomainPostParseDataAlloc: Don't reset error if looking up caps fails

2020-07-17 Thread Michal Prívozník
On 7/17/20 9:36 AM, Peter Krempa wrote: On Fri, Jul 17, 2020 at 09:27:54 +0200, Michal Privoznik wrote: When starting the QEMU driver we load all domain XMLs. This means, that post parse callbacks are run for each XML, but they are allowed to fail because we will run them again when starting a

Re: [PATCH] qemuDomainPostParseDataAlloc: Don't reset error if looking up caps fails

2020-07-17 Thread Peter Krempa
On Fri, Jul 17, 2020 at 09:27:54 +0200, Michal Privoznik wrote: > When starting the QEMU driver we load all domain XMLs. This > means, that post parse callbacks are run for each XML, but they > are allowed to fail because we will run them again when starting > a domain. In the case I am fixing, we

[PATCH] qemuDomainPostParseDataAlloc: Don't reset error if looking up caps fails

2020-07-17 Thread Michal Privoznik
When starting the QEMU driver we load all domain XMLs. This means, that post parse callbacks are run for each XML, but they are allowed to fail because we will run them again when starting a domain. In the case I am fixing, we were unable to look up QEMU capabilities (in both post parse runs) and

Re: The issue about adding multipath device's targets into qemu-pr-helper's namespace

2020-07-17 Thread Michal Prívozník
On 7/15/20 5:35 AM, Lin Ma wrote: On 2020-07-14 14:38, Michal Privoznik wrote: On 7/14/20 3:41 PM, Lin Ma wrote: Hi all, I have a namespace question about passthrough disk(multipath device). In case of enabling namespace and cgroups in qemu.conf, The target(s) of the multipath device won't