Re: [libvirt PATCH 281/351] meson: tests: build commandhelper binary

2020-07-28 Thread Peter Krempa
On Thu, Jul 16, 2020 at 11:58:37 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > tests/Makefile.am | 14 +- > tests/meson.build | 17 + > 2 files changed, 18 insertions(+), 13 deletions(-) [...] > diff --git a/tests/meson.build b/tests/meson.build >

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jul 28, 2020 at 12:24:56PM +0200, Ján Tomko wrote: > On a Tuesday in 2020, Daniel P. Berrangé wrote: > > On Tue, Jul 28, 2020 at 10:00:20AM +0200, Pavel Hrdina wrote: > > > 3) Keep the patches as they are but error out in meson until the > > >conversion is complete. The error

Re: [PATCH] Qemu: migration: Not bind RAM info with active migration status

2020-07-28 Thread Daniel P . Berrangé
On Wed, Jul 15, 2020 at 02:18:01PM +0800, Keqian Zhu wrote: > For that Qemu supports returning incoming migration info since its commit > 65ace0604551 (migration: add postcopy total blocktime into query-migrate), > which may contains active status, but without RAM info. Drop this binding >

Re: [libvirt PATCH] ci: move dco-check to a later stage

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jul 28, 2020 at 11:39:10AM +0200, Ján Tomko wrote: > Be less hostile to developers and run the build jobs even > if the dco-check failed. That way they can test their own > "private" branches without a sign-off. > > Also specify empty `needs` for it, since it does not depend > on any of

Re: [libvirt PATCH] ci: move dco-check to a later stage

2020-07-28 Thread Peter Krempa
On Tue, Jul 28, 2020 at 11:39:10 +0200, Ján Tomko wrote: > Be less hostile to developers and run the build jobs even > if the dco-check failed. That way they can test their own > "private" branches without a sign-off. > > Also specify empty `needs` for it, since it does not depend > on any of

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-28 Thread Ján Tomko
On a Tuesday in 2020, Daniel P. Berrangé wrote: On Tue, Jul 28, 2020 at 10:00:20AM +0200, Pavel Hrdina wrote: 3) Keep the patches as they are but error out in meson until the conversion is complete. The error can be used to detect if git bisect is withing the meson rewrite.

Re: [PATCH] Qemu: migration: Not bind RAM info with active migration status

2020-07-28 Thread Daniel Henrique Barboza
On 7/28/20 5:46 AM, zhukeqian wrote: Hi Daniel, On 2020/7/17 22:33, Daniel Henrique Barboza wrote: On 7/15/20 3:18 AM, Keqian Zhu wrote: For that Qemu supports returning incoming migration info since its commit 65ace0604551 (migration: add postcopy total blocktime into query-migrate),

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-28 Thread Peter Krempa
On Tue, Jul 28, 2020 at 12:08:17 +0200, Pavel Hrdina wrote: > On Tue, Jul 28, 2020 at 10:58:03AM +0100, Daniel P. Berrangé wrote: > > On Tue, Jul 28, 2020 at 10:00:20AM +0200, Pavel Hrdina wrote: [...] > > - Meson build is forced to fail out of the box > > - An option "force_incomplete_build"

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-28 Thread Peter Krempa
On Tue, Jul 28, 2020 at 10:33:52 +0200, Pavel Hrdina wrote: > On Tue, Jul 28, 2020 at 10:09:42AM +0200, Peter Krempa wrote: [...] > > Here I disagree, it also means that compilation should not fail. We do > comments all the time to patch series that every single commit should > compile

Re: [PATCH] qemu: modprobe vhost-vsock module

2020-07-28 Thread Stefano Garzarella
On Tue, Jul 28, 2020 at 12:58:07PM +0300, Nikolay Shirokovskiy wrote: > /dev/vhost-vsock is usable only if the module is loaded. Let's load the > module > just like in other places where kernel module is required (nbd, pci stub > driver). Just a note, starting from Linux 4.13 (f4660cc994e1

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-28 Thread Pavel Hrdina
On Tue, Jul 28, 2020 at 10:58:03AM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 28, 2020 at 10:00:20AM +0200, Pavel Hrdina wrote: > > On Mon, Jul 27, 2020 at 06:11:11PM +0200, Peter Krempa wrote: > > > On Fri, Jul 17, 2020 at 15:02:10 +0100, Daniel Berrange wrote: > > > > On Thu, Jul 16, 2020 at

[PATCH] qemu: modprobe vhost-vsock module

2020-07-28 Thread Nikolay Shirokovskiy
/dev/vhost-vsock is usable only if the module is loaded. Let's load the module just like in other places where kernel module is required (nbd, pci stub driver). Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_process.c | 18 ++ 1 file changed, 18 insertions(+) diff --git

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jul 28, 2020 at 10:00:20AM +0200, Pavel Hrdina wrote: > On Mon, Jul 27, 2020 at 06:11:11PM +0200, Peter Krempa wrote: > > On Fri, Jul 17, 2020 at 15:02:10 +0100, Daniel Berrange wrote: > > > On Thu, Jul 16, 2020 at 03:44:25PM +0200, Pavel Hrdina wrote: > > > > On Thu, Jul 16, 2020 at

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-28 Thread Andrea Bolognani
On Tue, 2020-07-28 at 10:00 +0200, Pavel Hrdina wrote: > So based on all the comments we have these options for pushing this > series: > > 1) Squash it into single commit. > > 2) Keep the patches as they are and running meson build & ninja will >not fail. > > 3) Keep the

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-28 Thread Daniel P . Berrangé
On Fri, Jul 17, 2020 at 07:27:50PM +0200, Martin Kletzander wrote: > On Fri, Jul 17, 2020 at 03:12:00PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jul 17, 2020 at 04:10:01PM +0200, Pavel Hrdina wrote: > > > On Fri, Jul 17, 2020 at 03:02:10PM +0100, Daniel P. Berrangé wrote: > > > > On Thu, Jul

[libvirt PATCH] ci: move dco-check to a later stage

2020-07-28 Thread Ján Tomko
Be less hostile to developers and run the build jobs even if the dco-check failed. That way they can test their own "private" branches without a sign-off. Also specify empty `needs` for it, since it does not depend on any of the jobs in the container phase and can be run right away.

[PATCH] doc: fix name of file containing max number of VFs

2020-07-28 Thread Paulo de Rezende Pinatti
Signed-off-by: Paulo de Rezende Pinatti --- docs/formatnode.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatnode.html.in b/docs/formatnode.html.in index e4328fedbe..8a51c4da80 100644 --- a/docs/formatnode.html.in +++ b/docs/formatnode.html.in @@ -141,7

Re: [libvirt PATCH 246/351] meson: src: add check-augeas test

2020-07-28 Thread Pavel Hrdina
On Tue, Jul 28, 2020 at 10:22:27AM +0200, Peter Krempa wrote: > On Tue, Jul 28, 2020 at 10:09:11 +0200, Pavel Hrdina wrote: > > On Tue, Jul 28, 2020 at 09:51:40AM +0200, Peter Krempa wrote: > > > On Thu, Jul 16, 2020 at 11:58:02 +0200, Pavel Hrdina wrote: > > > > Signed-off-by: Pavel Hrdina > > >

Re: [PATCH] Qemu: migration: Not bind RAM info with active migration status

2020-07-28 Thread zhukeqian
Hi Daniel, On 2020/7/17 22:33, Daniel Henrique Barboza wrote: > > > On 7/15/20 3:18 AM, Keqian Zhu wrote: >> For that Qemu supports returning incoming migration info since its commit >> 65ace0604551 (migration: add postcopy total blocktime into query-migrate), > > > It is worth saying that

Re: [libvirt PATCH 266/351] meson: tools: install libvirt-guests sysconf file

2020-07-28 Thread Pavel Hrdina
On Tue, Jul 28, 2020 at 10:32:20AM +0200, Peter Krempa wrote: > On Thu, Jul 16, 2020 at 11:58:22 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > tools/Makefile.am | 13 ++--- > > tools/meson.build | 8 > > 2 files changed, 10 insertions(+), 11

[PATCH] qemuProcessReconnect: fix possible use after free for xmlopt

2020-07-28 Thread Chuan Zheng
From: Zheng Chuan In a case that libvirtd is killed when it has just started, the qemu_driver->xmlopt is freed in the main thread while qemuProcessReconnect still visits it, which resulting in null pointer accesses. Fix that by adding refcount of qemu_driver->xmlopt at the begining of

Re: [libvirt PATCH 261/351] meson: tools: generate virt-xml-validate script

2020-07-28 Thread Pavel Hrdina
On Tue, Jul 28, 2020 at 10:30:21AM +0200, Peter Krempa wrote: > On Thu, Jul 16, 2020 at 11:58:17 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > tools/Makefile.am | 7 +-- > > tools/meson.build | 12 > > 2 files changed, 13 insertions(+), 6 deletions(-) >

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-28 Thread Pavel Hrdina
On Tue, Jul 28, 2020 at 10:09:42AM +0200, Peter Krempa wrote: > On Tue, Jul 28, 2020 at 10:00:20 +0200, Pavel Hrdina wrote: > > On Mon, Jul 27, 2020 at 06:11:11PM +0200, Peter Krempa wrote: > > > On Fri, Jul 17, 2020 at 15:02:10 +0100, Daniel Berrange wrote: > > > > On Thu, Jul 16, 2020 at

Re: [libvirt PATCH 266/351] meson: tools: install libvirt-guests sysconf file

2020-07-28 Thread Peter Krempa
On Thu, Jul 16, 2020 at 11:58:22 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > tools/Makefile.am | 13 ++--- > tools/meson.build | 8 > 2 files changed, 10 insertions(+), 11 deletions(-) [...] > diff --git a/tools/meson.build b/tools/meson.build > index

Re: [libvirt PATCH 261/351] meson: tools: generate virt-xml-validate script

2020-07-28 Thread Peter Krempa
On Thu, Jul 16, 2020 at 11:58:17 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > tools/Makefile.am | 7 +-- > tools/meson.build | 12 > 2 files changed, 13 insertions(+), 6 deletions(-) > [...] > diff --git a/tools/meson.build b/tools/meson.build > index

Re: [libvirt PATCH 246/351] meson: src: add check-augeas test

2020-07-28 Thread Peter Krempa
On Tue, Jul 28, 2020 at 10:09:11 +0200, Pavel Hrdina wrote: > On Tue, Jul 28, 2020 at 09:51:40AM +0200, Peter Krempa wrote: > > On Thu, Jul 16, 2020 at 11:58:02 +0200, Pavel Hrdina wrote: > > > Signed-off-by: Pavel Hrdina > > > --- > > > scripts/check-augeas.sh | 12 > > >

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-28 Thread Peter Krempa
On Tue, Jul 28, 2020 at 10:00:20 +0200, Pavel Hrdina wrote: > On Mon, Jul 27, 2020 at 06:11:11PM +0200, Peter Krempa wrote: > > On Fri, Jul 17, 2020 at 15:02:10 +0100, Daniel Berrange wrote: > > > On Thu, Jul 16, 2020 at 03:44:25PM +0200, Pavel Hrdina wrote: > > > > On Thu, Jul 16, 2020 at

Re: [libvirt PATCH 246/351] meson: src: add check-augeas test

2020-07-28 Thread Pavel Hrdina
On Tue, Jul 28, 2020 at 09:51:40AM +0200, Peter Krempa wrote: > On Thu, Jul 16, 2020 at 11:58:02 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > scripts/check-augeas.sh | 12 > > scripts/meson.build | 1 + > > src/Makefile.am | 17

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-28 Thread Pavel Hrdina
On Mon, Jul 27, 2020 at 06:11:11PM +0200, Peter Krempa wrote: > On Fri, Jul 17, 2020 at 15:02:10 +0100, Daniel Berrange wrote: > > On Thu, Jul 16, 2020 at 03:44:25PM +0200, Pavel Hrdina wrote: > > > On Thu, Jul 16, 2020 at 01:59:00PM +0100, Daniel P. Berrangé wrote: > > > > Personally I'd really

Re: [libvirt PATCH 246/351] meson: src: add check-augeas test

2020-07-28 Thread Peter Krempa
On Thu, Jul 16, 2020 at 11:58:02 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > scripts/check-augeas.sh | 12 > scripts/meson.build | 1 + > src/Makefile.am | 17 - > src/meson.build | 18 +- > 4 files changed,

Re: [libvirt PATCH 222/351] meson: src: add support for installing libvirt conf and augeas files

2020-07-28 Thread Peter Krempa
On Tue, Jul 28, 2020 at 09:24:13 +0200, Pavel Hrdina wrote: > On Mon, Jul 27, 2020 at 04:56:41PM +0200, Peter Krempa wrote: > > On Thu, Jul 16, 2020 at 11:57:38 +0200, Pavel Hrdina wrote: > > > Signed-off-by: Pavel Hrdina > > > --- > > > src/Makefile.am| 5 -- > > > src/meson.build

Re: [libvirt PATCH 222/351] meson: src: add support for installing libvirt conf and augeas files

2020-07-28 Thread Pavel Hrdina
On Mon, Jul 27, 2020 at 04:56:41PM +0200, Peter Krempa wrote: > On Thu, Jul 16, 2020 at 11:57:38 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > src/Makefile.am| 5 -- > > src/meson.build| 103 + > >

Re: [PATCH 2/2] qemu_capabilities.c: drop 'kvm_pr' support for non-Power8 hosts

2020-07-28 Thread Greg Kurz
On Mon, 27 Jul 2020 17:47:58 +0100 Daniel P. Berrangé wrote: > On Mon, Jul 27, 2020 at 01:44:07PM -0300, Daniel Henrique Barboza wrote: > > > > > > On 7/27/20 12:29 PM, Daniel P. Berrangé wrote: > > > On Fri, Jun 19, 2020 at 06:04:33PM -0300, Daniel Henrique Barboza wrote: > > > > PPC64 has

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-28 Thread Peter Krempa
On Mon, Jul 27, 2020 at 20:43:05 -0400, Neal Gompa wrote: > On Mon, Jul 27, 2020 at 12:11 PM Peter Krempa wrote: > > On Fri, Jul 17, 2020 at 15:02:10 +0100, Daniel Berrange wrote: [...] > > I agree. It's definitely necessary that the build is complete at any > > point in time. > > > > I'm

<    1   2