Re: [libvirt PATCH] scripts: Fix meson-install-symlink.py overwriting existing links

On Tue, Aug 04, 2020 at 07:48:15PM +0200, Martin Kletzander wrote: > On Tue, Aug 04, 2020 at 06:27:08PM +0200, Erik Skultety wrote: > > By default, symlink re-creation fails if the link already exists, more > > specifically in case of meson-install-symlink.py: > > > > Traceback (most recent call l

qemu modularization of qemu-5.1 vs libvirt domcapabilities cache?

Hi all: In testing qemu-5.1rc2 on my Fedora 32 home system, I found that the Fedora rawhide package has broken out both the QXL display device and the USB redirect device into separate RPM modules: qemu-device-display-qxl.x86_64 2:5.1.0-0.1.rc2.fc32 @@commandline qemu-device-usb-redirect

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

On 2020/8/5 上午4:30, Peter Xu wrote: On Mon, Aug 03, 2020 at 06:00:34PM +0200, Eugenio Pérez wrote: On Fri, 2020-07-03 at 15:24 +0800, Jason Wang wrote: On 2020/7/2 下午11:45, Peter Xu wrote: On Thu, Jul 02, 2020 at 11:01:54AM +0800, Jason Wang wrote: So I think we agree that a new notifier is

Re: [libvirt PATCH 3/3] util: bitmap: use g_new0/g_free

On 8/4/20 5:09 AM, Daniel P. Berrangé wrote: On Mon, Aug 03, 2020 at 07:29:19PM +0200, Peter Krempa wrote: On Mon, Aug 03, 2020 at 19:18:53 +0200, Ján Tomko wrote: Signed-off-by: Ján Tomko --- src/util/virbitmap.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-)

Re: device compatibility interface for live migration with assigned devices

On 2020/8/5 上午10:16, Yan Zhao wrote: On Wed, Aug 05, 2020 at 10:22:15AM +0800, Jason Wang wrote: On 2020/8/5 上午12:35, Cornelia Huck wrote: [sorry about not chiming in earlier] On Wed, 29 Jul 2020 16:05:03 +0800 Yan Zhao wrote: On Mon, Jul 27, 2020 at 04:23:21PM -0600, Alex Williamson wrot

Re: device compatibility interface for live migration with assigned devices

On Wed, Aug 05, 2020 at 10:22:15AM +0800, Jason Wang wrote: > > On 2020/8/5 上午12:35, Cornelia Huck wrote: > > [sorry about not chiming in earlier] > > > > On Wed, 29 Jul 2020 16:05:03 +0800 > > Yan Zhao wrote: > > > > > On Mon, Jul 27, 2020 at 04:23:21PM -0600, Alex Williamson wrote: > > (...)

Re: device compatibility interface for live migration with assigned devices

On 2020/8/5 上午12:35, Cornelia Huck wrote: [sorry about not chiming in earlier] On Wed, 29 Jul 2020 16:05:03 +0800 Yan Zhao wrote: On Mon, Jul 27, 2020 at 04:23:21PM -0600, Alex Williamson wrote: (...) Based on the feedback we've received, the previously proposed interface is not viable.

Re: [libvirt PATCH] tests: fix license blurb in virsh-undefine

On 8/4/20 2:28 PM, Ján Tomko wrote: > Assume commit 0466ff28f2 used case-insensitive replace s/OUT/EXP/ > by mistake and this file is still licensed under GPLv2.0+ > > Undo the change. > > Signed-off-by: Ján Tomko > FIxes: 0466ff28f23f4c430906efd5859f87672cf08782 > Cc: Cole Robinson > Cc: Eric

Re: [PATCH 2/4] Xen: Add support for qemu command-line passthrough

On 8/2/20 5:16 AM, Ján Tomko wrote: On a Friday in 2020, Jim Fehlig wrote: Xen supports passing arbitrary arguments to the QEMU device model via the 'extra' member of the public libxl_domain_build_info structure. This patch uses QEMU namespace extensions already in place for the QEMU driver to

[PATCH V2 1/3] Xen: Add support for qemu command-line passthrough

Xen supports passing arbitrary arguments to the QEMU device model via the 'extra' member of the public libxl_domain_build_info structure. This patch adds a 'xen' namespace extension, similar to the QEMU and bhyve drivers, to map arbitrary arguments to the 'extra' member. Only passthrough of argumen

[PATCH V2 3/3] news: Mention support for device model commandline passthrough in Xen

Signed-off-by: Jim Fehlig --- NEWS.rst | 8 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 63ca689b43..9aa6d122b6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -13,6 +13,13 @@ v6.7.0 (unreleased) * **New features** + * xen: Add support for device model command-li

[PATCH V2 0/3] Xen: Add support for qemu commandline passthrough

V2 of https://www.redhat.com/archives/libvir-list/2020-July/msg02043.html Changes in V2: - Drop use of virStringListCopy, and hence patch 1/4 - Switch to using 'xen' namespace and schema extenstion instead of qemu - Use more glib functions Jim Fehlig (3): Xen: Add support for qemu command-lin

[PATCH V2 2/3] Xen: Add support for qemu commandline passthrough to config converter

Support qemu commandline passthrough in the domXML to native config converter. Add tests to check the conversion. Signed-off-by: Jim Fehlig --- src/libxl/xen_xl.c | 91 tests/xlconfigdata/test-qemu-passthrough.cfg | 26 ++ tests/xlconfigdata/tes

Re: [PATCH v2 0/5] Further Debian/Ubuntu Apparmor Delta

On Tue, 2020-08-04 at 17:32 +0200, Christian Ehrhardt wrote: > Hi, > I don't even remember which number of submissions that is #5 maybe? > Anyway - I'm hereby continuing to bring Debian and Ubuntu apparmor > Delta into upstream libvirt. Thanks, I really appreciate the effort :) > I have kept out

Re: [PATCH 3/4] virdevmapper: Don't use libdevmapper to obtain dependencies

On Mon, 2020-07-27 at 10:31 +0200, Michal Privoznik wrote: > CVE-2020-14339 > > When building domain's private /dev in a namespace, libdevmapper > is consulted for getting full dependency tree of domain's disks. > The reason is that for a multipath devices all dependent devices > must be created i

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

On Mon, Aug 03, 2020 at 06:00:34PM +0200, Eugenio Pérez wrote: > On Fri, 2020-07-03 at 15:24 +0800, Jason Wang wrote: > > On 2020/7/2 下午11:45, Peter Xu wrote: > > > On Thu, Jul 02, 2020 at 11:01:54AM +0800, Jason Wang wrote: > > > > So I think we agree that a new notifier is needed? > > > Good to m

Re: [libvirt PATCH 00/20] Use SPDX-License-Identifier

On a Tuesday in 2020, Daniel P. Berrangé wrote: On Tue, Aug 04, 2020 at 08:10:02PM +0200, Ján Tomko wrote: On a Tuesday in 2020, Eric Blake wrote: > On 8/4/20 12:33 PM, Daniel P. Berrangé wrote: > > On Tue, Aug 04, 2020 at 07:22:40PM +0200, Ján Tomko wrote: > > > Replace the license blurb in eve

Re: [libvirt PATCH] tests: fix license blurb in virsh-undefine

On 8/4/20 1:28 PM, Ján Tomko wrote: Assume commit 0466ff28f2 used case-insensitive replace s/OUT/EXP/ by mistake and this file is still licensed under GPLv2.0+ Undo the change. Signed-off-by: Ján Tomko FIxes: 0466ff28f23f4c430906efd5859f87672cf08782 Cc: Cole Robinson Cc: Eric Blake Cc: Pino

[libvirt PATCH] tests: fix license blurb in virsh-undefine

Assume commit 0466ff28f2 used case-insensitive replace s/OUT/EXP/ by mistake and this file is still licensed under GPLv2.0+ Undo the change. Signed-off-by: Ján Tomko FIxes: 0466ff28f23f4c430906efd5859f87672cf08782 Cc: Cole Robinson Cc: Eric Blake Cc: Pino Toscano --- tests/virsh-undefine | 2

Re: [libvirt PATCH 00/20] Use SPDX-License-Identifier

On Tue, Aug 04, 2020 at 08:10:02PM +0200, Ján Tomko wrote: > On a Tuesday in 2020, Eric Blake wrote: > > On 8/4/20 12:33 PM, Daniel P. Berrangé wrote: > > > On Tue, Aug 04, 2020 at 07:22:40PM +0200, Ján Tomko wrote: > > > > Replace the license blurb in every single file with: > > > > SPDX-License

Re: [libvirt PATCH 00/20] Use SPDX-License-Identifier

On a Tuesday in 2020, Eric Blake wrote: On 8/4/20 12:33 PM, Daniel P. Berrangé wrote: On Tue, Aug 04, 2020 at 07:22:40PM +0200, Ján Tomko wrote: Replace the license blurb in every single file with: SPDX-License-Identifier: Coincidentally, this is also machine readable. I've requested legal

[libvirt PATCH] docs: formatdomain: fyx a tipo

s/hystorical/historical/ Signed-off-by: Ján Tomko --- Pushed as trivial. Sorry if this was an easter egg. It was too painful to look at. docs/formatdomain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 3275d1b39e..218f

Re: [libvirt PATCH] scripts: Fix meson-install-symlink.py overwriting existing links

On Tue, Aug 04, 2020 at 06:27:08PM +0200, Erik Skultety wrote: By default, symlink re-creation fails if the link already exists, more specifically in case of meson-install-symlink.py: Traceback (most recent call last): File "//scripts/meson-install-symlink.py", line 15, in os.symlink

Re: [libvirt PATCH 00/20] Use SPDX-License-Identifier

On 8/4/20 12:33 PM, Daniel P. Berrangé wrote: On Tue, Aug 04, 2020 at 07:22:40PM +0200, Ján Tomko wrote: Replace the license blurb in every single file with: SPDX-License-Identifier: Coincidentally, this is also machine readable. I've requested legal clarification previously on whether doi

Re: [libvirt PATCH 00/20] Use SPDX-License-Identifier

On Tue, Aug 04, 2020 at 07:22:40PM +0200, Ján Tomko wrote: > > This identifies the few places that use GPL-3.0 (syntax-check), > some places that mistakenly changed the blurb > (patches 1/20 and 4/20). We should fix the current license text in both of those files with mangled text. Regards, Dani

Re: [libvirt PATCH 00/20] Use SPDX-License-Identifier

On Tue, Aug 04, 2020 at 07:22:40PM +0200, Ján Tomko wrote: > Replace the license blurb in every single file with: > SPDX-License-Identifier: > Coincidentally, this is also machine readable. I've requested legal clarification previously on whether doing this kind of replacement is possible. The

[libvirt PATCH 16/20] esx: Use SPDX-License-Identifier for LGPL-2.1-or-later

Signed-off-by: Ján Tomko --- src/esx/esx_driver.c| 14 +- src/esx/esx_driver.h| 14 +- src/esx/esx_interface_driver.c | 14 +- src/esx/esx_interface_driver.h | 14 +- src/esx/esx_network_driver.c| 14

[libvirt PATCH 18/20] lxc: Use SPDX-License-Identifier for LGPL-2.1-or-later

Signed-off-by: Ján Tomko --- src/lxc/lxc_cgroup.c | 14 +- src/lxc/lxc_cgroup.h | 14 +- src/lxc/lxc_conf.c | 14 +- src/lxc/lxc_conf.h | 14 +- src/lxc/lxc_container.c | 14 +- src/lxc/lxc_container.h | 14 +---

[libvirt PATCH 14/20] cpu: Use SPDX-License-Identifier for LGPL-2.1-or-later

Signed-off-by: Ján Tomko --- src/cpu/cpu.c| 14 +- src/cpu/cpu.h| 14 +- src/cpu/cpu_arm.c| 14 +- src/cpu/cpu_arm.h| 14 +- src/cpu/cpu_arm_data.h | 14 +- src/cpu/cpu_map.c| 14 +---

[libvirt PATCH 17/20] locking: Use SPDX-License-Identifier for LGPL-2.1-or-later

Signed-off-by: Ján Tomko --- src/locking/domain_lock.c | 14 +- src/locking/domain_lock.h | 14 +- src/locking/lock_daemon.c | 14 +- src/locking/lock_daemon.h | 14 +- src/locking/lock_daemon_config.c | 14 +---

[libvirt PATCH 04/20] Use SPDX-License-Identifier for LGPL-2.1-or-later-double

Again, assume 'writing to the Free Software License' was requested by mistake and this file really is under LGPL-2.1-or-later. Signed-off-by: Ján Tomko --- tests/securityselinuxlabeltest.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/tests/securityselinuxla

[libvirt PATCH 10/20] tests: Use SPDX-License-Identifier for LGPL-2.1-or-later

Signed-off-by: Ján Tomko --- tests/commandhelper.c | 14 +- tests/commandtest.c | 14 +- tests/cputest.c | 14 +- tests/domaincapsmock.c| 14 +- tests/domaincapstest.c

[libvirt PATCH 13/20] bhyve: Use SPDX-License-Identifier for LGPL-2.1-or-later

Signed-off-by: Ján Tomko --- src/bhyve/bhyve_capabilities.c | 14 +- src/bhyve/bhyve_capabilities.h | 14 +- src/bhyve/bhyve_command.c | 14 +- src/bhyve/bhyve_command.h | 14 +- src/bhyve/bhyve_conf.c | 14 +- src

[libvirt PATCH 00/20] Use SPDX-License-Identifier

Replace the license blurb in every single file with: SPDX-License-Identifier: Coincidentally, this is also machine readable. This identifies the few places that use GPL-3.0 (syntax-check), some places that mistakenly changed the blurb (patches 1/20 and 4/20). The other variations were period v

[libvirt PATCH 05/20] Use SPDX-License-Identifier for LGPL-2.1-or-later in non-C files

Replace the copyright blurb in all the files using the little tic-tac-toe sign as a comment marker. Signed-off-by: Ján Tomko --- build-aux/Makefile.nonreentrant | 14 +- build-aux/check-spacing.pl | 14 +- examples/sh/virt-lxc-convert | 14 +

[libvirt PATCH 07/20] qemu: Use SPDX-License-Identifier for LGPL-2.1-or-later

Signed-off-by: Ján Tomko --- src/qemu/qemu_agent.c| 14 +- src/qemu/qemu_agent.h| 14 +- src/qemu/qemu_alias.c| 14 +- src/qemu/qemu_alias.h| 14 +- src/qemu/qemu_backup.c

[libvirt PATCH 03/20] Use SPDX-License-Identifier for GPL-3.0-or-later

Some files imported from gnulib use GPL-3.0-or-later. Signed-off-by: Ján Tomko --- build-aux/syntax-check.mk| 14 +- build-aux/useless-if-before-free | 13 + build-aux/vc-list-files | 13 + 3 files changed, 3 insertions(+), 37 deletions(-) di

[libvirt PATCH 19/20] rpc: Use SPDX-License-Identifier for LGPL-2.1-or-later

Signed-off-by: Ján Tomko --- src/rpc/virkeepalive.c| 14 +- src/rpc/virkeepalive.h| 14 +- src/rpc/virnetclient.c| 14 +- src/rpc/virnetclient.h| 14 +- src/rpc/virnetclientprogram.c | 14 +- src/rpc/virne

[libvirt PATCH 08/20] storage: Use SPDX-License-Identifier for LGPL-2.1-or-later

Signed-off-by: Ján Tomko --- src/storage/parthelper.c| 14 +- src/storage/storage_backend.c | 14 +- src/storage/storage_backend.h | 14 +- src/storage/storage_backend_disk.c | 14 +- src/stor

[libvirt PATCH 11/20] tools: Use SPDX-License-Identifier for LGPL-2.1-or-later

Signed-off-by: Ján Tomko --- tools/nss/libvirt_nss.c | 14 +- tools/nss/libvirt_nss.h | 14 +- tools/nss/libvirt_nss_leases.c | 14 +- tools/nss/libvirt_nss_leases.h | 14 +- tools/nss/libvirt_nss_macs.c

[libvirt PATCH 02/20] Use SPDX-License-Identifier for GPL-2.0-or-later

Some of shell-based tests and virt-xml-validate use GPL-2.0-or-later. Signed-off-by: Ján Tomko --- tests/virsh-auth | 14 +- tests/virsh-checkpoint| 14 +- tests/virsh-cpuset| 14 +- tests/virsh-optparse | 14 +

[libvirt PATCH 01/20] Use SPDX-License-Identifier for GPL-2.0-or-later-WITHEXP

Assume commit 0466ff28f2 used case-insensitive replace s/OUT/EXP/ by mistake and this file is still licensed under GPL-2.0-or-later. Signed-off-by: Ján Tomko --- tests/virsh-undefine | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/tests/virsh-undefine b/tests/v

[libvirt PATCH 06/20] conf: Use SPDX-License-Identifier for LGPL-2.1-or-later

Signed-off-by: Ján Tomko --- src/conf/backup_conf.c| 14 +- src/conf/backup_conf.h| 14 +- src/conf/capabilities.c | 14 +- src/conf/capabilities.h | 14 +- src/conf/checkpoint_conf.c

[libvirt PATCH 12/20] include: Use SPDX-License-Identifier for LGPL-2.1-or-later

Signed-off-by: Ján Tomko --- include/libvirt/libvirt-admin.h | 14 +- include/libvirt/libvirt-common.h.in | 14 +- include/libvirt/libvirt-domain-checkpoint.h | 14 +- include/libvirt/libvirt-domain-snapshot.h | 14 +- include/

[libvirt PATCH 15/20] libxl: Use SPDX-License-Identifier for LGPL-2.1-or-later

Signed-off-by: Ján Tomko --- src/libxl/libxl_capabilities.c | 14 +- src/libxl/libxl_capabilities.h | 14 +- src/libxl/libxl_conf.c | 14 +- src/libxl/libxl_conf.h | 14 +- src/libxl/libxl_domain.c | 14 +- src/libx

Re: device compatibility interface for live migration with assigned devices

[sorry about not chiming in earlier] On Wed, 29 Jul 2020 16:05:03 +0800 Yan Zhao wrote: > On Mon, Jul 27, 2020 at 04:23:21PM -0600, Alex Williamson wrote: (...) > > Based on the feedback we've received, the previously proposed interface > > is not viable. I think there's agreement that the us

Re: [libvirt PATCH] src: add G_GNUC_NO_INLINE annotations for mocked symbols

On a Tuesday in 2020, Daniel P. Berrangé wrote: We should prevent inlining of symbols from the driver .so files that are mocked, as well as those in the main libvirt.so This isn't fixing any currently known problem, just trying to prevent future issues. With clang, probably. Signed-off-by:

Re: [PATCH] tests: qemublocktest: fix crashing with SIGBUS

On a Tuesday in 2020, Roman Bogorodskiy wrote: Commit bcbb026993 converted qemublocktest to use g_autoptr for virQEMUCaps. To prevent it from crashing, don't explicitly call virObjectUnref() on this object. Oops, thanks for catching that. Signed-off-by: Roman Bogorodskiy --- tests/qemublock

[libvirt PATCH] scripts: Fix meson-install-symlink.py overwriting existing links

By default, symlink re-creation fails if the link already exists, more specifically in case of meson-install-symlink.py: Traceback (most recent call last): File "//scripts/meson-install-symlink.py", line 15, in os.symlink(target, link) FileExistsError: File exists: '../default.xml'

Re: [PATCH] tests: qemublocktest: fix crashing with SIGBUS

On Tue, Aug 04, 2020 at 08:10:00PM +0400, Roman Bogorodskiy wrote: > Commit bcbb026993 converted qemublocktest to use > g_autoptr for virQEMUCaps. To prevent it from crashing, > don't explicitly call virObjectUnref() on this object. > > Signed-off-by: Roman Bogorodskiy > --- > tests/qemublocktes

[PATCH] tests: qemublocktest: fix crashing with SIGBUS

Commit bcbb026993 converted qemublocktest to use g_autoptr for virQEMUCaps. To prevent it from crashing, don't explicitly call virObjectUnref() on this object. Signed-off-by: Roman Bogorodskiy --- tests/qemublocktest.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qemublocktest.c b/te

[libvirt PATCH] src: add G_GNUC_NO_INLINE annotations for mocked symbols

We should prevent inlining of symbols from the driver .so files that are mocked, as well as those in the main libvirt.so This isn't fixing any currently known problem, just trying to prevent future issues. Signed-off-by: Daniel P. Berrangé --- scripts/mock-noinline.py | 2 +- src/libxl/li

Re: [libvirt PATCH] docs: fix libvirt go-import metadata in pages

On Tue, Aug 04, 2020 at 04:52:56PM +0100, Daniel P. Berrangé wrote: > The meson conversion lost the tags providing the go-import, > because the "$pagename" variable lost the .html suffix. Rather > than fix that, just change to using "$pagesrc" instead, as it is a > better fit. > > Signed-off-by:

[libvirt PATCH] docs: fix libvirt go-import metadata in pages

The meson conversion lost the tags providing the go-import, because the "$pagename" variable lost the .html suffix. Rather than fix that, just change to using "$pagesrc" instead, as it is a better fit. Signed-off-by: Daniel P. Berrangé --- docs/newapi.xsl | 2 -- docs/page.xsl

Re: [PATCH-for-5.1] .travis.yml: Deprecate it in favor of GitLab CI

Philippe Mathieu-Daudé writes: > As of QEMU 5.2 we prefer to focus our CI development on GitLab. > Mark Travis-CI as deprecated (adding a big warning). Subject doesn't match body (5.1 vs 5.2) > > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/system/deprecated.rst | 11 +++ > .t

[PATCH v2 1/5] apparmor: allow default pki path

From: Sam Hartman /etc/pki/qemu is a pki path recommended by qemu tls docs [1] and one that can cause issues with spice connections when missing. Add the path to the allowed list of pki paths to fix the issue. Note: this is active in Debian/Ubuntu [1] for quite a while already. [1]: https://ww

[PATCH v2 4/5] apparmor: qemu access to @{PROC}/*/auxv for hw_cap

From: Stefan Bader On some architectures (ppc, s390x, sparc, arm) qemu will read auxv to detect hardware capabilities via qemu_getauxval. Allow that access read-only for the entry owned by the current qemu process. Signed-off-by: Christian Ehrhardt Signed-off-by: Stefan Bader Acked-by: Jamie

[PATCH v2 2/5] apparmor: allow libvirtd to call pygrub

From: Stefan Bader When using xen through libxl in Debian/Ubuntu it needs to be able to call pygrub. This is placed in a versioned path like /usr/lib/xen-4.11/bin. In theory the rule could be more strict by rendering the libexec_dir setting pkg-config can derive from libbxen-dev. But that would

[PATCH v2 0/5] Further Debian/Ubuntu Apparmor Delta

Hi, I don't even remember which number of submissions that is #5 maybe? Anyway - I'm hereby continuing to bring Debian and Ubuntu apparmor Delta into upstream libvirt. I have kept out all patches that are either Distro-specific or we ran into trouble/discussions in the past. But there are enough l

[PATCH v2 5/5] apparmor: let qemu load old shared objects after upgrades

Since [1] qemu can after upgrade fall back to pre-upgrade modules to still be able to dynamically load qemu-module based features. The paths for these modules are pre-defined by the code and should be allowed to be mapped and loaded from which will allow packagers avoiding the inability of late fe

[PATCH v2 3/5] apparmor: read only access to overcommit_memory

From: Jamie Strandboge Allow qemu to read @{PROC}/sys/vm/overcommit_memory. This is read on guest start-up and (as read-only) not a critical secret that has to stay hidden. Signed-off-by: Christian Ehrhardt Signed-off-by: Stefan Bader Signed-off-by: Jamie Strandboge --- src/security/apparmor

[GSoC][PATCH 4/7] qemu_domain: funciton declarations moved to correct file

Functions `qemuDomainRemoveInactiveJob` and `qemuDomainRemoveInactiveJobLocked` had their declaration mispalced in `qemu_domainjob` and were moved to `qemu_domain`. Signed-off-by: Prathamesh Chavan --- src/qemu/qemu_domain.h| 6 ++ src/qemu/qemu_domainjob.h | 6 -- 2 files changed, 6

[GSoC][PATCH 0/7] Making `qemu_domainjob` hypervisor-agnostic

Following are a series of patches aimed to make qemu_domainjob hypervisor agnostic, and create a virdomainjob file in the future which handles domain-jobs. Prathamesh Chavan (7): qemu_domain: Added `qemuDomainJobInfo` to domainJob's `privateData` qemu_domainjob: added maxQueuedJobs and jobs_qu

[GSoC][PATCH 6/7] qemu_domainjob: removed reference to `qemuDomainObjPrivatePtr`

References to `qemuDomainObjPrivatePtr` in qemu_domainjob were removed as it is a qemu-hypervisor specific pointer. Signed-off-by: Prathamesh Chavan --- src/qemu/qemu_backup.c | 15 +- src/qemu/qemu_checkpoint.c | 12 +- src/qemu/qemu_domain.c | 20 +- src/qemu/qemu_domainjob.c | 222

[GSoC][PATCH 7/7] virmigraiton: `qemuMigrationJobPhase` transformed for more generic use

`qemuMigrationJobPhase` was transformed into `virMigrationJobPhase` and a common util file `virmigration` was created to store its defination. Signed-off-by: Prathamesh Chavan --- src/hypervisor/meson.build| 1 + src/hypervisor/virmigration.c | 41 src/hypervisor/virmig

[GSoC][PATCH 2/7] qemu_domainjob: added maxQueuedJobs and jobs_queued to `qemuDomainJob`

Since the attribute `jobs_queued` was specific to jobs, we decided to move this from `qemuDomainObjPrivate` to `qemuDomainJobObj` structure. Also, reference to `maxQueuedJobs` required us to access config of the qemu-driver. And creating its copy in the `qemuDomainJob` helped us access the variabl

[GSoC][PATCH 1/7] qemu_domain: Added `qemuDomainJobInfo` to domainJob's `privateData`

As `qemuDomainJobInfo` had attributes specific to qemu hypervisor's jobs, we moved the attribute `current` and `completed` from `qemuDomainJobObj` to its `privateData` structure. In this process, two callback functions: `setJobInfoOperation` and `currentJobInfoInit` were introduced to qemuDomainJo

[GSoC][PATCH 5/7] qemu_domainjob: added `getDomainXMLOptionPtr` callback function

To remove dependency of funcitons to access the `privateData` of qemu-domain, we introduce this callback funciton so that funcitons get exactly what they need. Signed-off-by: Prathamesh Chavan --- src/qemu/qemu_domain.c| 8 src/qemu/qemu_domainjob.c | 4 ++-- src/qemu/qemu_domainjob

[libvirt PATCH v2] manpages/virsh: A couple of small clarifications

Changes: - Update the descriptions of --current & --config flags. For --config, the reason to rephrase "next boot" to "next start" is: "Next boot may still imply somebody selecting "reboot" in the guest OS and fully expecting the changes to be applied." (per Peter Krempa)

Re: [libvirt PATCH] build-aux: remove some syntax-check cruft

On a Tuesday in 2020, Daniel P. Berrangé wrote: sc_proper_name_utf8_requires_ICONV looks for Makefile.am files, so is not going to work correctly with meson. Nor do we use proper_name_utf8 The 'today' variable is not referenced anywhere. The 'writable-files' target is not used anywhere sc_

[libvirt PATCH] build-aux: remove some syntax-check cruft

sc_proper_name_utf8_requires_ICONV looks for Makefile.am files, so is not going to work correctly with meson. The 'today' variable is not referenced anywhere. The 'writable-files' target is not used anywhere sc_prohibit_reversed_compare_failure only checks 'init.sh' which does not exist in libvi

Re: [libvirt PATCH] network: Use single quotes in default network configuration

On Tue, Aug 04, 2020 at 02:30:07PM +0200, Andrea Bolognani wrote: > Whenever libvirt is upgraded on a Debian system, the user will be > prompted along the lines of > > Configuration file '/etc/libvirt/qemu/networks/default.xml' >==> Modified (by you or by a script) since installation. >=

[libvirt PATCH] network: Use single quotes in default network configuration

Whenever libvirt is upgraded on a Debian system, the user will be prompted along the lines of Configuration file '/etc/libvirt/qemu/networks/default.xml' ==> Modified (by you or by a script) since installation. ==> Package distributor has shipped an updated version. What would you lik

Re: [PATCH] mdev: fix daemon crash on reattach mdevs

On Tue, Jul 21, 2020 at 05:21:10PM +0800, Binfeng Wu wrote: > Causing a crash when virMediatedDeviceListFindIndex because of > some pointers in mgr->activeMediatedHostdevs become dangling > pointers if goto cleanup label in virMediatedDeviceListMarkDevices. > > Reproduction scenario: > 1. start v

Re: [libvirt PATCH 0/2] header fixes

On a Tuesday in 2020, Pavel Hrdina wrote: Pavel Hrdina (2): remote: remove duplicated header src/logging: no need to include log_protocol.h in log_manager.h src/logging/log_manager.h | 2 -- src/qemu/qemu_command.c | 1 + src/remote/remote_daemon_dispatch.c | 1 - 3 files ch

Re: [PATCH 6/7] docs: css: Modify appearance of the kbase directory page

On Tue, Aug 04, 2020 at 01:13:16PM +0200, Ján Tomko wrote: > On a Monday in 2020, Peter Krempa wrote: > > On Mon, Aug 03, 2020 at 14:30:30 +0200, Ján Tomko wrote: > > > On a Monday in 2020, Peter Krempa wrote: > > > > Remove the gray background and switch to underlined links. > > > > > > > > > > H

Re: [libvirt PATCH 0/2] ci: Some cirrus-run related changes

On a Tuesday in 2020, Andrea Bolognani wrote: The corresponding libvirt-ci MR is https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/41 and this is what it looks like in action: https://gitlab.com/abologna/libvirt/-/jobs/669949971 https://gitlab.com/abologna/libvirt/-/jobs/669949970 Let

Re: [PATCH 6/7] docs: css: Modify appearance of the kbase directory page

On a Monday in 2020, Peter Krempa wrote: On Mon, Aug 03, 2020 at 14:30:30 +0200, Ján Tomko wrote: On a Monday in 2020, Peter Krempa wrote: > Remove the gray background and switch to underlined links. > Here, I prefer the old look. The difference with the ToC might be that the ToC entries are in

[libvirt PATCH 0/2] ci: Some cirrus-run related changes

The corresponding libvirt-ci MR is https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/41 and this is what it looks like in action: https://gitlab.com/abologna/libvirt/-/jobs/669949971 https://gitlab.com/abologna/libvirt/-/jobs/669949970 Let's help test the upcoming cirrus-run release

[libvirt PATCH 1/2] ci: Show build log for Cirrus CI jobs

This feature has been implemented as of https://github.com/sio/cirrus-run/commit/b9b2278f1d6c45b22d5f84fca0621e77622a6da4 and will be included in the upcoming 0.3.0 release. Signed-off-by: Andrea Bolognani --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt PATCH 2/2] ci: Temporarily enable verbose mode for cirrus-run

We've hit issues with GitLab CI jobs reporting a failure despite the corresponding Cirrus CI job finishing successfully: this is apparently caused by the underlying VM being rescheduled. A workaround for this issue has been implemented as of https://github.com/sio/cirrus-run/commit/5299874bbb7

Re: [libvirt PATCH 1/3] bhyve: fix NULL pointer check position

Ján Tomko wrote: > src/bhyve/bhyve_parse_command.c:437:9: warning: Either the condition > '!config' is redundant or there is possible null pointer dereference: > config. [nullPointerRedundantCheck] > > src/bhyve/bhyve_parse_command.c:280:23: warning: Either the condition > '!separator' is redun

Re: [PATCH-for-5.1] .travis.yml: Deprecate it in favor of GitLab CI

On Tue, Aug 04, 2020 at 10:30:40AM +0200, Philippe Mathieu-Daudé wrote: > As of QEMU 5.2 we prefer to focus our CI development on GitLab. > Mark Travis-CI as deprecated (adding a big warning). > > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/system/deprecated.rst | 11 +++ > .travi

Re: [PATCH 3/8] apparmor: allow virt-aa-helper nameservices

On Mon, Aug 3, 2020 at 5:05 PM Jamie Strandboge wrote: > On Mon, 03 Aug 2020, Christian Ehrhardt wrote: > > > Since quite a while libvirt-aa-helper triggers nss related apparmor > > denials like: > > operation="open" profile="virt-aa-helper" name="/etc/nsswitch.conf" > > operation="open" profil

[libvirt PATCH 1/2] remote: remove duplicated header

We already include viraccessapicheck.h few lines above. Signed-off-by: Pavel Hrdina --- src/remote/remote_daemon_dispatch.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c index c91b5d3293..dacfa4e9fb 100644 --- a/src/

[PATCH] fix vm schizencephaly when heartbeat stoped

>From e28cb2a03a670e4c0e7641f68f9d9f3accb00ae0 Mon Sep 17 00:00:00 2001 From: Yilu Lin Date: Tue, 4 Aug 2020 02:42:00 -0400 Subject: [PATCH] fix vm schizencephaly when heartbeat stoped Signed-off-by: Yilu Lin If keepalive messages lost in finish step, vm maybe schizencephaly. Shutdown src vm fo

[libvirt PATCH 2/2] src/logging: no need to include log_protocol.h in log_manager.h

The header log_manager.h doesn't use anything from log_protocol.h and the only other place than logging using log_protocol.h is qemu_command.c where we can include log_protocol.h directly to have enum value VIR_LOG_MANAGER_PROTOCOL_DOMAIN_OPEN_LOG_FILE_TRUNCATE available. Fixes race-condition comp

Re: [libvirt PATCH] meson_options: change default value to auto for driver_esx

On Mon, Aug 03, 2020 at 09:02:41PM +0200, Pavel Hrdina wrote: > Reported-by: Daniel P. Berrangé > Signed-off-by: Pavel Hrdina > --- > meson_options.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

[libvirt PATCH 0/2] header fixes

Pavel Hrdina (2): remote: remove duplicated header src/logging: no need to include log_protocol.h in log_manager.h src/logging/log_manager.h | 2 -- src/qemu/qemu_command.c | 1 + src/remote/remote_daemon_dispatch.c | 1 - 3 files changed, 1 insertion(+), 3 deletions(-)

Re: [libvirt PATCH 3/3] util: bitmap: use g_new0/g_free

On Mon, Aug 03, 2020 at 07:29:19PM +0200, Peter Krempa wrote: > On Mon, Aug 03, 2020 at 19:18:53 +0200, Ján Tomko wrote: > > Signed-off-by: Ján Tomko > > --- > > src/util/virbitmap.c | 20 ++-- > > 1 file changed, 6 insertions(+), 14 deletions(-) > > > > diff --git a/src/util/vir

Re: [PATCH v2] conf: Add support for initiator IQN setting for iSCSI hostdevs

On a Tuesday in 2020, Peter Krempa wrote: We already allow controlling the initiator IQN for iSCSI based disks. Add the same for host devices. Signed-off-by: Peter Krempa --- Rebased on top of the latest patch to convert formatdomain to rst and fixed 'since' tag. docs/formatdomain.rst

Re: [PATCH] docs: formatdomain: Convert to rst

On a Monday in 2020, Peter Krempa wrote: For now just plain conversion to rst. Anchors which existed until now are preserved, but the table of contents now uses the docutils-generated ones. Additionally which was nested in a link () was removed as rst doesn't support nesting of inline markup.

Re: device compatibility interface for live migration with assigned devices

> > yes, include a device_api field is better. > > for mdev, "device_type=vfio-mdev", is it right? > > No, vfio-mdev is not a device API, it's the driver that attaches to the > mdev bus device to expose it through vfio. The device_api exposes the > actual interface of the vfio device, it's also v

Re: [libvirt PATCH] meson: Fix libvirtd|virtproxyd socket prefixes

On Tue, Aug 04, 2020 at 10:00:19AM +0200, Pavel Hrdina wrote: > On Tue, Aug 04, 2020 at 09:48:58AM +0200, Pavel Hrdina wrote: > > On Tue, Aug 04, 2020 at 09:30:42AM +0200, Erik Skultety wrote: > > > For the daemons in question the correct socket prefix is "libvirt-", > > > not "libvirtd-". > > > >

Re: [PATCH-for-5.1] .travis.yml: Deprecate it in favor of GitLab CI

On 04/08/2020 10.30, Philippe Mathieu-Daudé wrote: > As of QEMU 5.2 we prefer to focus our CI development on GitLab. > Mark Travis-CI as deprecated (adding a big warning). > > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/system/deprecated.rst | 11 +++ > .travis.yml

Re: [libvirt PATCH] meson: Fix libvirtd|virtproxyd socket prefixes

On Tue, Aug 04, 2020 at 10:00:19AM +0200, Pavel Hrdina wrote: > On Tue, Aug 04, 2020 at 09:48:58AM +0200, Pavel Hrdina wrote: > > On Tue, Aug 04, 2020 at 09:30:42AM +0200, Erik Skultety wrote: > > > For the daemons in question the correct socket prefix is "libvirt-", > > > not "libvirtd-". > > > >

[PATCH-for-5.1] .travis.yml: Deprecate it in favor of GitLab CI

As of QEMU 5.2 we prefer to focus our CI development on GitLab. Mark Travis-CI as deprecated (adding a big warning). Signed-off-by: Philippe Mathieu-Daudé --- docs/system/deprecated.rst | 11 +++ .travis.yml| 7 +++ 2 files changed, 18 insertions(+) diff --git a/doc

Re: [libvirt PATCH] meson: Fix libvirtd|virtproxyd socket prefixes

On Tue, Aug 04, 2020 at 09:48:58AM +0200, Pavel Hrdina wrote: > On Tue, Aug 04, 2020 at 09:30:42AM +0200, Erik Skultety wrote: > > For the daemons in question the correct socket prefix is "libvirt-", > > not "libvirtd-". > > > > Fixes: dd4f2c73ad7f9fc0eae5325d5bf5786afd3a467e > > > > Signed-off-b

Re: [PATCH 7/8] apparmor: allow virt-aa-helper to read openvswitch sockets

On Mon, Aug 3, 2020 at 5:13 PM Jamie Strandboge wrote: > On Mon, 03 Aug 2020, Christian Ehrhardt wrote: > > > From: Serge Hallyn > > > > Chardevs/sockets configured for openvswitch-dpdk use cases > > might be probed by virt-aa-helper. Allow that access to enable > > virt-aa-helper rendering per-

[PATCH v2] conf: Add support for initiator IQN setting for iSCSI hostdevs

We already allow controlling the initiator IQN for iSCSI based disks. Add the same for host devices. Signed-off-by: Peter Krempa --- Rebased on top of the latest patch to convert formatdomain to rst and fixed 'since' tag. docs/formatdomain.rst| 4 d

  1   2   >