On 8/5/20 7:22 AM, Thomas Huth wrote:
libvirt currently silently allows and some
other timer tags in the guest XML definition for timers that do not
exist on non-x86 systems. We should not silently ignore these tags
since the users might not get what they expected otherwise.
Note: The error
On 8/6/20 2:50 PM, Peter Krempa wrote:
See patch 2/2.
Peter Krempa (2):
testutilsqemuschema: Add template checker for schema entries
qemumonitorjsontest: Add a last-resort warning if
object-add/device_add are QAPIfied
tests/qemumonitorjsontest.c | 53 +
On 8/7/20 3:46 PM, Patrick J. Magauran wrote:
On Fri, 2020-08-07 at 17:16 +0100, Daniel P. Berrangé wrote:
On Thu, Aug 06, 2020 at 10:53:32PM -0400, Patrick Magauran wrote:
Libvirt bases its decision about whether to apply the vnet_hdr flag
to the tap interface on whether or not the selected
On Fri, 2020-08-07 at 17:16 +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 06, 2020 at 10:53:32PM -0400, Patrick Magauran wrote:
> > Libvirt bases its decision about whether to apply the vnet_hdr flag
> > to the tap interface on whether or not the selected model is
> > VirtIO. Originally, VirtIO
Signed-off-by: Daniel P. Berrangé
---
src/remote/remote_driver.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 88eb52ec4b..cc1a10b775 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
We'll shortly want to reuse code for determining whether to connect to
the system or session daemon from places outside the remote driver
client. Pulling it out into a self contained function facilitates reuse.
Signed-off-by: Daniel P. Berrangé
---
src/remote/remote_driver.c | 51
Switch keyfile and netcat parameters, since the netcat path and
socket path are a logical pair that belong together. This patches
the other constructors.
Signed-off-by: Daniel P. Berrangé
---
src/remote/remote_driver.c | 2 +-
src/rpc/virnetclient.c | 2 +-
src/rpc/virnetclient.h | 4
We have long had a problem with use of netcat for ssh tunnelling because
there's no guarantee the UNIX socket path the client builds will match
the UNIX socket path the remote host uses. We don't even allow session
mode SSH tunnelling for this reason. We also can't easily auto-spawn
libvirtd in
When accessing libvirtd over a SSH tunnel, the remote driver needs a way
to proxy the SSH input/output stream to a suitable libvirt daemon. Tihs
is currently done by spawning netcat, pointing it to the libvirtd socket
path. This is problematic for a number of reasons:
- The socket path varies
The remoteGetUNIXSocketHelper method will be needed by source files
beyond the remote driver client.
Signed-off-by: Daniel P. Berrangé
---
src/remote/remote_driver.c | 129 +-
src/remote/remote_sockets.c | 134
The remoteSplitURISCheme method will be needed by source files beyond
the remote driver client.
Signed-off-by: Daniel P. Berrangé
---
src/remote/remote_driver.c | 25 -
src/remote/remote_sockets.c | 28
src/remote/remote_sockets.h | 6
We don't want to repeat the choice of default netcat binary setting in
three different places. This will also make it possible to do better
error reporting in the helper.
Signed-off-by: Daniel P. Berrangé
---
src/remote/remote_driver.c | 2 +-
src/rpc/virnetclient.c | 5 +++--
2 files
Three parts of the code all build up the same SSH shell script
snippet for remote tunneling the RPC protocol, but in slightly
different ways. Combine them all into one helper method in the
virNetClient code, since this logic doesn't really belong in
the virNetSocket code.
Note that the this
This wires up support for using the new virt-ssh-helper binary with the ssh,
libssh and libssh2 protocols.
The new binary will be used preferentially if it is available in $PATH,
otherwise we fall back to traditional netcat.
The "proxy" URI parameter can be used to force use of netcat e.g.
The remoteDriverTransport and remoteDriverMode enums are going to be
needed by source files beyond the remote driver client.
Signed-off-by: Daniel P. Berrangé
---
src/remote/meson.build | 1 +
src/remote/remote_driver.c | 41 +-
src/remote/remote_sockets.c |
We delay converting the remote transport string to enum form until
fairly late. As a result we're doing string comparisons when we
could be just doing enum comparisons.
Signed-off-by: Daniel P. Berrangé
---
po/POTFILES.in | 1 +
src/remote/remote_driver.c | 51
On 08/07/20 13:21, Erik Skultety wrote:
> With virtio-net further configuration settings are required, so document
> them and while at it, fix the Q35 machine XML example which wouldn't
> work with SEV because of not disabling vhost and the option boot ROM.
(1) Please drop:
not disabling vhost
On 20/07/2020 12.22, Thomas Huth wrote:
> qemuAgentFSInfoToPublic() currently only sets the devAlias for PCI devices.
> However, the QEMU guest agent could also provide the device name in the
> "dev" field of the response for other devices instead (well, at least after
> fixing another problem in
On Thu, Aug 06, 2020 at 10:53:32PM -0400, Patrick Magauran wrote:
> Libvirt bases its decision about whether to apply the vnet_hdr flag to the
> tap interface on whether or not the selected model is VirtIO. Originally,
> VirtIO was the only model to support the vnet_hdr in QEMU; however, the
>
On Fri, Aug 07, 2020 at 12:21:20PM +0200, Christian Ehrhardt wrote:
> With qemu 5.0 and libvirt 6.6 there are new apparmor denials:
> apparmor="DENIED" operation="umount" profile="libvirtd"
> name="/run/libvirt/qemu/1-kvmguest-groovy-norm.dev/" comm="rpc-worker"
>
> These are related to new
On Fri, Aug 07, 2020 at 12:21:19PM +0200, Christian Ehrhardt wrote:
> The design of apparmor in libvirt always had a way to define custom
> per-guest rules as described in docs/drvqemu.html and [1].
>
> A fix meant to clean the profiles after guest shutdown was a bit
> overzealous and
On Fri, Aug 07, 2020 at 07:09:35PM +0400, Roman Bogorodskiy wrote:
> Document the new element which allows to specify
> host audio backend for a guest device, and update
> the element description with the new
> sub-element which specified the other end of the mapping.
>
> Signed-off-by: Roman
On Fri, Aug 07, 2020 at 07:09:34PM +0400, Roman Bogorodskiy wrote:
> Signed-off-by: Roman Bogorodskiy
> ---
> tests/virschematest.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-
On Fri, Aug 07, 2020 at 07:09:33PM +0400, Roman Bogorodskiy wrote:
> Allow to map sound playback and recording devices to host devices
> using "" OSS audio backend.
>
> Signed-off-by: Roman Bogorodskiy
> ---
> src/bhyve/bhyve_command.c | 26 ---
>
On Fri, Aug 07, 2020 at 07:09:32PM +0400, Roman Bogorodskiy wrote:
> Introduce a new device element "" which allows
> to map guest sound device specified using the ""
> element to specific audio backend.
>
> Example:
>
>
>
>
>
>
>
>
>
> This block maps to OSS audio
On Fri, Aug 07, 2020 at 04:59:12PM +0200, Pavel Hrdina wrote:
> Commit <2020c6af8a8e4bb04acb629d089142be984484c8> fixed an issue with
> QEMU driver by reporting offline CPUs as well. However, doing so it
> introduced a regression into libxl and test drivers by completely
> ignoring the passed
On Fri, Aug 07, 2020 at 07:09:30PM +0400, Roman Bogorodskiy wrote:
> Add 'ich7' sound model. This is a preparation for sound support in
> bhyve, as 'ich7' is the only model it supports.
>
> Signed-off-by: Roman Bogorodskiy
> ---
> docs/schemas/domaincommon.rng | 1 +
> src/conf/domain_conf.c
On Fri, Aug 07, 2020 at 04:59:14PM +0200, Pavel Hrdina wrote:
> Following the rationale from commit
> <2020c6af8a8e4bb04acb629d089142be984484c8> we should do the same thing
> for iothread info as well.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/qemu/qemu_driver.c | 7 +--
> 1 file changed,
On Fri, Aug 07, 2020 at 07:09:31PM +0400, Roman Bogorodskiy wrote:
> bhyve supports intel hda sound devices that could be specified
> on the command like using "-1:0,hda,play=$play_dev,rec=$rec_dev",
> where "1:0" is a PCI address, and "$play_dev" and "$rec_dev"
> point to the playback and
On Fri, Aug 07, 2020 at 04:59:13PM +0200, Pavel Hrdina wrote:
> Commit <6328da04285d9f65cb323d399f731c20caf63f5a> introduced
> testDomainGetEmulatorPinInfo() into test driver but used
> virHostCPUGetCount() function to get the number of host CPUs.
>
> This would be correct for other drivers but
On Fri, Aug 07, 2020 at 01:45:52PM +0100, Daniel P. Berrangé wrote:
> The systemd .socket unit files we ship for libvirt daemons use
> SocketMode=0666 on the assumption that libvirt is built with
> polkit which provides access control.
>
> Some people, however, may have explicitly turned off
Changes since v2:
- Add 'ich7' sound device model,
- Convert audio id from string to integer,
- Use 'union' to store audio backend specific configuration,
- Document changes in formatdomain,
- Don't use hash for sound<->audio mapping lookups.
Roman Bogorodskiy (6):
conf: add 'ich7' sound
Add 'ich7' sound model. This is a preparation for sound support in
bhyve, as 'ich7' is the only model it supports.
Signed-off-by: Roman Bogorodskiy
---
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c | 1 +
src/conf/domain_conf.h | 1 +
src/qemu/qemu_command.c
Signed-off-by: Roman Bogorodskiy
---
tests/virschematest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/virschematest.c b/tests/virschematest.c
index 8720031375..17eb2a4b34 100644
--- a/tests/virschematest.c
+++ b/tests/virschematest.c
@@ -201,7 +201,8 @@
Introduce a new device element "" which allows
to map guest sound device specified using the ""
element to specific audio backend.
Example:
This block maps to OSS audio backend on the host using
/dev/dsp0 device for both input (recording)
and output (playback).
Document the new element which allows to specify
host audio backend for a guest device, and update
the element description with the new
sub-element which specified the other end of the mapping.
Signed-off-by: Roman Bogorodskiy
---
docs/formatdomain.rst | 49
bhyve supports intel hda sound devices that could be specified
on the command like using "-1:0,hda,play=$play_dev,rec=$rec_dev",
where "1:0" is a PCI address, and "$play_dev" and "$rec_dev"
point to the playback and recording device on the host respectively.
Currently, schema of the 'sound'
Allow to map sound playback and recording devices to host devices
using "" OSS audio backend.
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_command.c | 26 ---
src/conf/domain_conf.c| 13 ++
src/conf/domain_conf.h
Commit <6328da04285d9f65cb323d399f731c20caf63f5a> introduced
testDomainGetEmulatorPinInfo() into test driver but used
virHostCPUGetCount() function to get the number of host CPUs.
This would be correct for other drivers but in test driver we must not
depend on the host, we have to use hard-coded
Following the rationale from commit
<2020c6af8a8e4bb04acb629d089142be984484c8> we should do the same thing
for iothread info as well.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_driver.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/qemu/qemu_driver.c
Commit <2020c6af8a8e4bb04acb629d089142be984484c8> fixed an issue with
QEMU driver by reporting offline CPUs as well. However, doing so it
introduced a regression into libxl and test drivers by completely
ignoring the passed `hostcpus` variable.
Move the virHostCPUGetAvailableCPUsBitmap() out of
We should really unify the code and create helpers used by all of these
to prevent all of the bugs fixed by this series.
It started by failing libvirt-dbus test suite. After fixing it I checked
The code looks right but I can't get the patch to be applied:
$ git am \[PATCH\]\ virnetserver\:\ fix\ some\ memory\ leaks\ in\
virNetTLSContextReloadForServer.eml
warning: Patch sent with format=flowed; space at the end of lines might be lost.
Applying: virnetserver: fix some memory leaks in
On Tue, 2020-08-04 at 23:56 +0200, Andrea Bolognani wrote:
> Anyway, I'm absolutely not an AppArmor expert but the pointers you
> provide along with the various changes and the discussion around v1,
> along with the fact that these patches have been shipped in Debian
> and Ubuntu for so long, are
This is not expose in most historical versions of glibc, nor
non-glibc impls. We must use our wrapper API instead.
Signed-off-by: Daniel P. Berrangé
---
Pushed as build fix
src/qemu/qemu_shim.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_shim.c
The systemd .socket unit files we ship for libvirt daemons use
SocketMode=0666 on the assumption that libvirt is built with
polkit which provides access control.
Some people, however, may have explicitly turned off polkit at
build time and not realize that leaves them insecure unless
they also
On Wed, 05 Aug 2020 12:35:01 +0100
Sean Mooney wrote:
> On Wed, 2020-08-05 at 12:53 +0200, Jiri Pirko wrote:
> > Wed, Aug 05, 2020 at 11:33:38AM CEST, yan.y.z...@intel.com wrote:
(...)
> > >software_version: device driver's version.
> > > in .[.bugfix] scheme, where there
With virtio-net further configuration settings are required, so document
them and while at it, fix the Q35 machine XML example which wouldn't
work with SEV because of not disabling vhost and the option boot ROM.
Reported-by: Dr. David Alan Gilbert
Signed-off-by: Erik Skultety
---
The design of apparmor in libvirt always had a way to define custom
per-guest rules as described in docs/drvqemu.html and [1].
A fix meant to clean the profiles after guest shutdown was a bit
overzealous and accidentially removed this important admin feature as
well.
Therefore reduce the
With qemu 5.0 and libvirt 6.6 there are new apparmor denials:
apparmor="DENIED" operation="umount" profile="libvirtd"
name="/run/libvirt/qemu/1-kvmguest-groovy-norm.dev/" comm="rpc-worker"
These are related to new issues around devmapper handling [1] and the
error path triggered by these
Signed-off-by: Han Han
---
docs/formatdomain.rst | 5 -
docs/schemas/domaincommon.rng | 3 +++
src/conf/domain_conf.c| 4
src/util/virstoragefile.h | 1 +
4 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
Ceph Nautilus supports separate image namespaces within a pool for
tenant isolation and QEMU added it as a rbd blockdev options from 5.0.0.
This optional attribute is used to access a image with namespace.
Add unit tests for this attribute.
https://bugzilla.redhat.com/show_bug.cgi?id=1816909
Diff from v3:
- add the check for capability of rbd namespace
- rename the item of rbd namespace in disk source struct
- combine the commit of doc into the commit of patch
- remove the code for -drive
gitlab branch:
https://gitlab.com/hhan2/libvirt/-/commits/rbd-namespace-v4
Han Han (4):
Add rbd namespace in aarch64 capability replies.
The capability flag will be used for rbd namespace option. The rbd namespace
is introduced since ceph Nautilus and qemu v5.0.0.
Signed-off-by: Han Han
---
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h
Signed-off-by: Han Han
---
NEWS.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 63ca689b43..57d8a40731 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -13,6 +13,12 @@ v6.7.0 (unreleased)
* **New features**
+ * qemu: Support rbd namespace attribute
+
+The
On Fri, Aug 7, 2020 at 5:17 PM Peter Krempa wrote:
> On Fri, Aug 07, 2020 at 17:11:25 +0800, Han Han wrote:
> > On Thu, Aug 6, 2020 at 7:58 PM Peter Krempa wrote:
> >
> > > On Thu, Aug 06, 2020 at 19:41:44 +0800, Han Han wrote:
> > > > Ceph Nautilus supports separate image namespaces within a
On Fri, Aug 07, 2020 at 17:11:25 +0800, Han Han wrote:
> On Thu, Aug 6, 2020 at 7:58 PM Peter Krempa wrote:
>
> > On Thu, Aug 06, 2020 at 19:41:44 +0800, Han Han wrote:
> > > Ceph Nautilus supports separate image namespaces within a pool for
> > > tenant isolation and QEMU added it as a rbd
On Thu, Aug 6, 2020 at 7:58 PM Peter Krempa wrote:
> On Thu, Aug 06, 2020 at 19:41:44 +0800, Han Han wrote:
> > Ceph Nautilus supports separate image namespaces within a pool for
> > tenant isolation and QEMU added it as a rbd blockdev options from 5.0.0.
> > This optional attribute is used to
From 55fce33e9cf2d5ea58ebc44b4d78f9c12122fdcb Mon Sep 17 00:00:00 2001
From: Jin Yan
Date: Fri, 7 Aug 2020 15:59:45 +0800
Subject: [PATCH] virnetserver: fix some memory leaks in
virNetTLSContextReloadForServer
These leaks were introduced in commit 15d280fa97b0, use g_autofree for all
cert_path
On Fri, Aug 07, 2020 at 01:27:59PM +0800, Zhong, Luyao wrote:
On 8/3/2020 7:00 PM, Martin Kletzander wrote:
On Mon, Aug 03, 2020 at 05:31:56PM +0800, Luyao Zhong wrote:
Hi Libvirt experts,
I would like enhence the numatune snippet configuration. Given a
example snippet:
 ...
Â
 Â
 Â
60 matches
Mail list logo
