b_info->u.hvm.{acpi,apic} are deprecated. But also, on recent libxl
version (4.14) the old one seems to be broken. While libxl part should
be fixed too, update the usage here and at some point drop support for
the old version.
b_info->acpi was added in Xen 4.8
b_info->apic was added in Xen 4.10
On Wed, Sep 9, 2020 at 3:48 PM Matt Coleman wrote:
>
> I knew I’d miss something... Shucks!
>
> Does this work, or should I start a separate [PATCH v2] thread with the DCO
> added to the commit messages?
>
> Signed-off-by: Matt Coleman
>
As we typically amend all patches with the various fake
On Wed, Sep 09, 2020 at 06:38:04AM +, Cedric Bosdonnat wrote:
> The check didn't involve any NetworkManager at all, but a network with
> RA route for the default route. Completely removing the check is rather
> likely to introduce a regression on that side.
Thanks for putting up with my
I knew I’d miss something... Shucks!
Does this work, or should I start a separate [PATCH v2] thread with the DCO
added to the commit messages?
Signed-off-by: Matt Coleman
> On Sep 9, 2020, at 1:41 AM, Erik Skultety wrote:
>
> On Tue, Sep 08, 2020 at 04:43:51PM -0400, Matt Coleman wrote:
>>
On Wed, Sep 09, 2020 at 06:06:19PM +0200, Michal Privoznik wrote:
> On 9/9/20 5:47 PM, Pavel Hrdina wrote:
> > On Wed, Sep 09, 2020 at 05:06:19PM +0200, Jan Kiszka wrote:
> > > On 09.09.20 16:38, Erik Skultety wrote:
> > > > On Mon, Sep 07, 2020 at 11:25:34PM +0200, Jan Kiszka wrote:
> > > > >
On Wed, Sep 09, 2020 at 05:53:06PM +0200, Jan Kiszka wrote:
>
>
> Am 9. September 2020 17:47:59 MESZ schrieb Pavel Hrdina :
> >On Wed, Sep 09, 2020 at 05:06:19PM +0200, Jan Kiszka wrote:
> >> On 09.09.20 16:38, Erik Skultety wrote:
> >> > On Mon, Sep 07, 2020 at 11:25:34PM +0200, Jan Kiszka
On 9/9/20 2:38 AM, Cedric Bosdonnat wrote:
On Wed, 2020-09-09 at 12:39 +1000, Ian Wienand wrote:
On Tue, Sep 01, 2020 at 08:27:47AM +, Cedric Bosdonnat wrote:
So the hypervisor has at least one (Router Advertised) RA route.
After defining a network like the following, the RA route is
On Wed, Sep 09, 2020 at 05:06:19PM +0200, Jan Kiszka wrote:
> On 09.09.20 16:38, Erik Skultety wrote:
> > On Mon, Sep 07, 2020 at 11:25:34PM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka
> >>
> >> If the target path contains a link with an absolute path (e.g.
> >> /var/run -> /run), makedirs
On 9/9/20 5:47 PM, Pavel Hrdina wrote:
On Wed, Sep 09, 2020 at 05:06:19PM +0200, Jan Kiszka wrote:
On 09.09.20 16:38, Erik Skultety wrote:
On Mon, Sep 07, 2020 at 11:25:34PM +0200, Jan Kiszka wrote:
From: Jan Kiszka
If the target path contains a link with an absolute path (e.g.
/var/run ->
Am 9. September 2020 17:47:59 MESZ schrieb Pavel Hrdina :
>On Wed, Sep 09, 2020 at 05:06:19PM +0200, Jan Kiszka wrote:
>> On 09.09.20 16:38, Erik Skultety wrote:
>> > On Mon, Sep 07, 2020 at 11:25:34PM +0200, Jan Kiszka wrote:
>> >> From: Jan Kiszka
>> >>
>> >> If the target path contains a
On Wed, Sep 09, 2020 at 05:06:19PM +0200, Jan Kiszka wrote:
> On 09.09.20 16:38, Erik Skultety wrote:
> > On Mon, Sep 07, 2020 at 11:25:34PM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka
> >>
> >> If the target path contains a link with an absolute path (e.g.
> >> /var/run -> /run), makedirs
On Wed, 9 Sep 2020 14:40:33 +0200
Erik Skultety wrote:
> On Wed, Sep 09, 2020 at 08:23:39AM +0200, Bjoern Walk wrote:
> > Erik Skultety [2020-09-08, 06:01PM +0200]:
> > > On Mon, Aug 24, 2020 at 01:59:15PM +0200, Bjoern Walk wrote:
> > > > From: Boris Fiuczynski
> > > > +case
On 09.09.20 16:38, Erik Skultety wrote:
> On Mon, Sep 07, 2020 at 11:25:34PM +0200, Jan Kiszka wrote:
>> From: Jan Kiszka
>>
>> If the target path contains a link with an absolute path (e.g.
>> /var/run -> /run), makedirs will target the wrong location. Resolve the
>> path first, then append
On Wed, 2020-09-09 at 15:19 +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 09, 2020 at 04:17:21PM +0200, Andrea Bolognani wrote:
> > On Wed, 2020-09-09 at 15:01 +0100, Daniel P. Berrangé wrote:
> > > It appears that 'ninja test' is just a dumb shim to invoke
> > > 'meson test'. Given that using
On 8/29/20 2:49 AM, Sebastian Mitterle wrote:
The changed condition was always false because the function was always
called with boundary values 0.
Use the free extent's start value to get its start offset from the
cylinder boundary and determine if the needed size for allocation
needs to be
On Mon, Sep 07, 2020 at 11:25:34PM +0200, Jan Kiszka wrote:
> From: Jan Kiszka
>
> If the target path contains a link with an absolute path (e.g.
> /var/run -> /run), makedirs will target the wrong location. Resolve the
> path first, then append DESTDIR again if needed.
Can you elaborate on
On 8/12/20 3:21 AM, Ian Wienand wrote:
Add some expanded examples for the nat ipv6 introduced with
927acaedec7effbe67a154d8bfa0e67f7d08e6c7.
Unfortunately while for IPv4 it's well-known what addresses ranges are
useful for NAT, with IPv6 unless you enjoy digging through RFC's going
On Wed, 2020-09-09 at 16:09 +0200, Pavel Hrdina wrote:
> On Wed, Sep 09, 2020 at 03:56:08PM +0200, Andrea Bolognani wrote:
> > Taking a step back,
> > what are the reasons one might want to call either meson or ninja to
> > run the test suite?
>
> It might be more natural for users to run `ninja
On Wed, Sep 09, 2020 at 04:17:21PM +0200, Andrea Bolognani wrote:
> On Wed, 2020-09-09 at 15:01 +0100, Daniel P. Berrangé wrote:
> > On Wed, Sep 09, 2020 at 03:56:08PM +0200, Andrea Bolognani wrote:
> > > Taking a step back,
> > > what are the reasons one might want to call either meson or ninja
On Wed, 2020-09-09 at 15:01 +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 09, 2020 at 03:56:08PM +0200, Andrea Bolognani wrote:
> > Taking a step back,
> > what are the reasons one might want to call either meson or ninja to
> > run the test suite?
>
> It appears that 'ninja test' is just a dumb
On Wed, Sep 09, 2020 at 03:56:08PM +0200, Andrea Bolognani wrote:
> On Wed, 2020-09-09 at 14:41 +0100, Daniel P. Berrangé wrote:
> > On Wed, Sep 09, 2020 at 03:38:21PM +0200, Pavel Hrdina wrote:
> > > On Wed, Sep 09, 2020 at 02:31:48PM +0100, Daniel P. Berrangé wrote:
> > > > Does Meson not have a
On Wed, Sep 09, 2020 at 03:56:08PM +0200, Andrea Bolognani wrote:
> On Wed, 2020-09-09 at 14:41 +0100, Daniel P. Berrangé wrote:
> > On Wed, Sep 09, 2020 at 03:38:21PM +0200, Pavel Hrdina wrote:
> > > On Wed, Sep 09, 2020 at 02:31:48PM +0100, Daniel P. Berrangé wrote:
> > > > Does Meson not have a
On Wed, 2020-09-09 at 14:41 +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 09, 2020 at 03:38:21PM +0200, Pavel Hrdina wrote:
> > On Wed, Sep 09, 2020 at 02:31:48PM +0100, Daniel P. Berrangé wrote:
> > > Does Meson not have a standard way to increase the default
> > > timeout globally ? It feels
On Wed, 2020-09-09 at 14:31 +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 09, 2020 at 03:10:06PM +0200, Andrea Bolognani wrote:
> > The default timeout for tests is 30s, but that's not always
> > enough time: the Valgrind test, for example, are currently
> > special-cased because they take
On Wed, Sep 09, 2020 at 03:38:21PM +0200, Pavel Hrdina wrote:
> On Wed, Sep 09, 2020 at 02:31:48PM +0100, Daniel P. Berrangé wrote:
> > On Wed, Sep 09, 2020 at 03:10:06PM +0200, Andrea Bolognani wrote:
> > > The default timeout for tests is 30s, but that's not always
> > > enough time: the
On Wed, Sep 09, 2020 at 02:31:48PM +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 09, 2020 at 03:10:06PM +0200, Andrea Bolognani wrote:
> > The default timeout for tests is 30s, but that's not always
> > enough time: the Valgrind test, for example, are currently
> > special-cased because they take
On Wed, 2020-09-09 at 15:30 +0200, Ján Tomko wrote:
> The singular spelling seems to be popular even within the context of
> this patch. And unlike its plural counterpart, it:
> 1) can actually be pronounced
> 2) involves less typing
> 3) 'test coverage' is actually a term
>
On a Wednesday in 2020, Daniel P. Berrangé wrote:
On Wed, Sep 09, 2020 at 03:10:06PM +0200, Andrea Bolognani wrote:
The default timeout for tests is 30s, but that's not always
enough time: the Valgrind test, for example, are currently
special-cased because they take longer, and on certain
On Wed, Sep 09, 2020 at 03:10:06PM +0200, Andrea Bolognani wrote:
> The default timeout for tests is 30s, but that's not always
> enough time: the Valgrind test, for example, are currently
> special-cased because they take longer, and on certain
> architectures where powerful hardware is not (yet)
-
tl;dr: ((( (_)T(_)
On a Wednesday in 2020, Andrea Bolognani wrote:
We already have two options that influence how 'ninja test'
ninja *test* [1]
behaves and we're about to introduce a third one, so it makes
sense to give them consistent names.
Signed-off-by: Andrea
On Wed, Sep 09, 2020 at 03:01:50PM +0200, Cornelia Huck wrote:
> On Wed, 9 Sep 2020 14:46:00 +0200
> Erik Skultety wrote:
>
> > > > > Are ^these attributes documented a little more somewhere? I didn't
> > > > > find those
> > > > > in [1]. I suppose it is available in the z/Architecture:
We already have two options that influence how 'ninja test'
behaves and we're about to introduce a third one, so it makes
sense to give them consistent names.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 2 +-
meson.build | 6 +++---
meson_options.txt | 4 ++--
3 files changed,
The default timeout for tests is 30s, but that's not always
enough time: the Valgrind test, for example, are currently
special-cased because they take longer, and on certain
architectures where powerful hardware is not (yet) available
even the basic test programs might take more than 30s to
See patch 2/2 for the rationale.
Andrea Bolognani (2):
meson: Rename tests-related build options
meson: Add tests_timeout build option
libvirt.spec.in | 2 +-
meson.build | 8 +---
meson_options.txt | 5 +++--
tests/meson.build | 6 +++---
4 files changed, 12 insertions(+), 9
On a Thursday in 2020, Hao Wang wrote:
From 3ad3fae4f2562a11bef8dcdd25b6a7e0b00d4e2c Mon Sep 17 00:00:00 2001
From: Hao Wang
Date: Sat, 18 Jul 2020 15:43:30 +0800
Subject: [PATCH] client: fix memory leak in client msg
When closing client->waitDispatch in virNetClientIOEventLoopRemoveAll
or
On Wed, 9 Sep 2020 14:46:00 +0200
Erik Skultety wrote:
> > > > Are ^these attributes documented a little more somewhere? I didn't find
> > > > those
> > > > in [1]. I suppose it is available in the z/Architecture: Principles of
> >
> > [BTW: what are [1] and [2] referring to?]
>
>
On 9/9/20 1:27 PM, Alex Bennée wrote:
> It's buggy and we are not sure anyone uses it.
>
> Signed-off-by: Alex Bennée
> Reviewed-by: Richard Henderson
> Acked-by: David Gibson
> ---
> docs/system/deprecated.rst | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git
...
> > > > diff --git a/docs/schemas/nodedev.rng b/docs/schemas/nodedev.rng
> > > > index 4b2b350f..f7f517b5 100644
> > > > --- a/docs/schemas/nodedev.rng
> > > > +++ b/docs/schemas/nodedev.rng
> > > > @@ -85,6 +85,7 @@
> > > >
> > > >
> > > >
> > > > +
> > >
On Wed, Sep 09, 2020 at 08:23:39AM +0200, Bjoern Walk wrote:
> Erik Skultety [2020-09-08, 06:01PM +0200]:
> > On Mon, Aug 24, 2020 at 01:59:15PM +0200, Bjoern Walk wrote:
> > > From: Boris Fiuczynski
> > > +case VIR_NODE_DEV_CAP_SYSTEM:
> > > +case VIR_NODE_DEV_CAP_USB_DEV:
> > >
On Wed, Sep 09, 2020 at 11:05:37AM +0200, Ján Tomko wrote:
The changes for sparse stream support started passing
virshStreamCallbackDataPtr to virshStreamSink
instead of passing a simple file descriptor, but
forgot to adjust all the callers.
Fix it in cmdScreenshot as well.
Signed-off-by: Ján
It's buggy and we are not sure anyone uses it.
Signed-off-by: Alex Bennée
Reviewed-by: Richard Henderson
Acked-by: David Gibson
---
docs/system/deprecated.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
index
Hi all,
at the moment if there's no hook defined and installed, libvirtd caches
this fact at start and don't add it even if hookds are added/stopped
later. So libvirtd restart is required to hook up the hook.
What do you think if we disable caching for that reason to allow
adding/removing hooks
On Tue, 2020-09-08 at 19:28 +0200, Michal Privoznik wrote:
> In 8e1804f9f66 I've tried to fix the following use case: domain
> is started with path to UEFI only and relies on libvirt to figure
> out corresponding NVRAM template to create a per-domain copy
> from. The fix consisted of having a
The changes for sparse stream support started passing
virshStreamCallbackDataPtr to virshStreamSink
instead of passing a simple file descriptor, but
forgot to adjust all the callers.
Fix it in cmdScreenshot as well.
Signed-off-by: Ján Tomko
Fixes: 9e745a97171e10f050962c166082439d6724e245
On a Tuesday in 2020, Matt Coleman wrote:
This patchset fixes several spelling and punctuation errors in the
documentation.
Where British vs. American conventions differ, I used Google Trends to
determine which form is most commonly used, globally.
Ah, argumentum ad populum. :)
We use a mix
On Wed, 9 Sep 2020 08:18:08 +0200
Bjoern Walk wrote:
> Erik Skultety [2020-09-08, 05:46PM +0200]:
> > On Mon, Aug 24, 2020 at 01:59:12PM +0200, Bjoern Walk wrote:
> > > From: Boris Fiuczynski
> > >
> > > Make channel subsystem (CSS) devices available in the node_device
> > > driver.o
> >
On a Wednesday in 2020, Tim Wiederhake wrote:
V1: https://www.redhat.com/archives/libvir-list/2020-September/msg00355.html
Changes since V1:
* Most patches already commited, this is the remainder.
* Incorporated comment from Ján into patch #1.
* Rebased on top of Daniels patches.
With these
V1: https://www.redhat.com/archives/libvir-list/2020-September/msg00355.html
Changes since V1:
* Most patches already commited, this is the remainder.
* Incorporated comment from Ján into patch #1.
* Rebased on top of Daniels patches.
With these patches, src/cpu/ becomes `goto` free.
Tim
On Wed, 2020-09-09 at 12:39 +1000, Ian Wienand wrote:
> On Tue, Sep 01, 2020 at 08:27:47AM +, Cedric Bosdonnat wrote:
> > So the hypervisor has at least one (Router Advertised) RA route.
> > After defining a network like the following, the RA route is removed if
> > accept_ra isn't set to 2.
>
The call to `g_strfreev` is not required, as in both cases no memory has been
allocated.
Signed-off-by: Tim Wiederhake
---
src/cpu/cpu_ppc64.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c
index 9e6f1e856e..28fbfea9ae
Signed-off-by: Tim Wiederhake
---
src/cpu/cpu_map.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c
index 3abec68c60..65d244e011 100644
--- a/src/cpu/cpu_map.c
+++ b/src/cpu/cpu_map.c
@@ -39,20 +39,19 @@ loadData(const
Erik Skultety [2020-09-08, 06:01PM +0200]:
> On Mon, Aug 24, 2020 at 01:59:15PM +0200, Bjoern Walk wrote:
> > From: Boris Fiuczynski
> > +case VIR_NODE_DEV_CAP_SYSTEM:
> > +case VIR_NODE_DEV_CAP_USB_DEV:
> > +case VIR_NODE_DEV_CAP_USB_INTERFACE:
> > +case
Erik Skultety [2020-09-08, 05:46PM +0200]:
> On Mon, Aug 24, 2020 at 01:59:12PM +0200, Bjoern Walk wrote:
> > From: Boris Fiuczynski
> >
> > Make channel subsystem (CSS) devices available in the node_device driver.o
>
> Can there be more CSS devices per CPC?
Yes, several typically. One for
PING
On Sat, Aug 29, 2020 at 2:49 AM Sebastian Mitterle
wrote:
> The changed condition was always false because the function was always
> called with boundary values 0.
>
> Use the free extent's start value to get its start offset from the
> cylinder boundary and determine if the needed size
54 matches
Mail list logo
