Re: [PATCH] Modify virCPUarmCompare to perform compare actions

2020-09-18 Thread Zhenyu Zheng
Thanks, I've updated the codes, please have a look :), the topic of the mail is [PATCH V3] Modify virCPUarmCompare to perform compare actions BR, Zhenyu On Fri, Sep 18, 2020 at 8:01 PM Jiri Denemark wrote: > On Mon, Sep 07, 2020 at 20:15:59 +0800, Zhenyu Zheng wrote: > > So the suitable way

Re: [PATCH] smp: drop support for deprecated (invalid topologies)

2020-09-18 Thread Eduardo Habkost
On Mon, Sep 14, 2020 at 09:37:20AM +0200, Igor Mammedov wrote: > On Fri, 11 Sep 2020 11:04:47 -0400 > "Michael S. Tsirkin" wrote: > > > On Fri, Sep 11, 2020 at 09:32:02AM -0400, Igor Mammedov wrote: > > > it's was deprecated since 3.1 > > > > > > Support for invalid topologies is removed, the

[libvirt PATCH] docs: Document global_{period, quota} schedinfo fields

2020-09-18 Thread Andrea Bolognani
These fields have existed for a very long time but they were never documented in virsh(1). https://bugzilla.redhat.com/show_bug.cgi?id=1354391 Signed-off-by: Andrea Bolognani --- docs/manpages/virsh.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PULL v2 13/15] cphp: remove deprecated cpu-add command(s)

2020-09-18 Thread Michael S. Tsirkin
From: Igor Mammedov These were deprecated since 4.0, remove both HMP and QMP variants. Users should use device_add command instead. To get list of possible CPUs and options, use 'info hotpluggable-cpus' HMP or query-hotpluggable-cpus QMP command. Signed-off-by: Igor Mammedov Reviewed-by:

Re: [PATCH] libxl: use b_info->{acpi,acpi} when available

2020-09-18 Thread Daniel P . Berrangé
On Fri, Sep 18, 2020 at 05:41:21PM +0200, Marek Marczykowski-Górecki wrote: > On Fri, Sep 18, 2020 at 05:12:52PM +0200, Michal Prívozník wrote: > > On 9/18/20 1:31 PM, Daniel P. Berrangé wrote: > > > On Wed, Sep 16, 2020 at 11:09:31AM +0200, Michal Privoznik wrote: > > > > On 9/10/20 6:18 AM,

Re: [PATCH] libxl: use b_info->{acpi,acpi} when available

2020-09-18 Thread Marek Marczykowski-Górecki
On Fri, Sep 18, 2020 at 05:12:52PM +0200, Michal Prívozník wrote: > On 9/18/20 1:31 PM, Daniel P. Berrangé wrote: > > On Wed, Sep 16, 2020 at 11:09:31AM +0200, Michal Privoznik wrote: > > > On 9/10/20 6:18 AM, Marek Marczykowski-Górecki wrote: > > > > b_info->u.hvm.{acpi,apic} are deprecated. But

Re: [PATCH] libxl: use b_info->{acpi,acpi} when available

2020-09-18 Thread Michal Prívozník
On 9/18/20 1:31 PM, Daniel P. Berrangé wrote: On Wed, Sep 16, 2020 at 11:09:31AM +0200, Michal Privoznik wrote: On 9/10/20 6:18 AM, Marek Marczykowski-Górecki wrote: b_info->u.hvm.{acpi,apic} are deprecated. But also, on recent libxl version (4.14) the old one seems to be broken. While libxl

[PULL 13/15] cphp: remove deprecated cpu-add command(s)

2020-09-18 Thread Michael S. Tsirkin
From: Igor Mammedov These were deprecated since 4.0, remove both HMP and QMP variants. Users should use device_add command instead. To get list of possible CPUs and options, use 'info hotpluggable-cpus' HMP or query-hotpluggable-cpus QMP command. Signed-off-by: Igor Mammedov Reviewed-by:

Re: [PATCH v3 5/6] qemu: Introduce to handle transient disk

2020-09-18 Thread Peter Krempa
On Thu, Sep 17, 2020 at 09:30:44 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > Here is the implementation of transient option for qcow2 and raw format > disk. This gets available directive in domain xml file > like as: > > > > > > > > > When

Re: [PATCH v3 4/6] qemu: update the validation for transient disk option

2020-09-18 Thread Peter Krempa
On Thu, Sep 17, 2020 at 09:30:43 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > Update validation of transient disk option. The option for qemu is supported > with under condistions. > > - qemu has blockdev feature > - the type is file and the format is qcow2 and raw > - writable

Re: [PATCH v3 3/6] qemu: Block migration when transient disk option is enabled

2020-09-18 Thread Peter Krempa
On Thu, Sep 17, 2020 at 09:30:42 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > Block migration when transient disk option is enabled because migration > requires some blockjobs. > > Signed-off-by: Masayoshi Mizuma > --- > src/qemu/qemu_migration.c | 10 ++ > 1 file

Re: [PATCH v3 2/6] qemu: Block disk hotplug when transient disk option is enabled

2020-09-18 Thread Peter Krempa
On Thu, Sep 17, 2020 at 09:30:41 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > Signed-off-by: Masayoshi Mizuma > --- > src/qemu/qemu_hotplug.c | 6 ++ > 1 file changed, 6 insertions(+) Similarly to previous commit, the code is good but the commit message could actually

Re: [PATCH v3 1/6] qemu: Block blockjobs when transient disk option is enabled

2020-09-18 Thread Peter Krempa
On Fri, Sep 18, 2020 at 14:53:53 +0200, Peter Krempa wrote: > On Thu, Sep 17, 2020 at 09:30:40 -0400, Masayoshi Mizuma wrote: > > From: Masayoshi Mizuma > > > > Signed-off-by: Masayoshi Mizuma > > --- > > src/qemu/qemu_domain.c | 7 +++ > > 1 file changed, 7 insertions(+) > > Reviewed-by:

Re: [PATCH v3 1/6] qemu: Block blockjobs when transient disk option is enabled

2020-09-18 Thread Peter Krempa
On Thu, Sep 17, 2020 at 09:30:40 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > Signed-off-by: Masayoshi Mizuma > --- > src/qemu/qemu_domain.c | 7 +++ > 1 file changed, 7 insertions(+) Reviewed-by: Peter Krempa

Re: [PATCH] Modify virCPUarmCompare to perform compare actions

2020-09-18 Thread Jiri Denemark
On Mon, Sep 07, 2020 at 20:15:59 +0800, Zhenyu Zheng wrote: > So the suitable way of doing this will be checking for `VIR_CPU_TYPE_HOST` > and perform a comparison in this case and still return IDENTICAL for all > other cases right? Yes. > Then the upper layer caller(like OpenStack Nova) will

Re: [PATCH] libxl: use b_info->{acpi,acpi} when available

2020-09-18 Thread Daniel P . Berrangé
On Wed, Sep 16, 2020 at 11:09:31AM +0200, Michal Privoznik wrote: > On 9/10/20 6:18 AM, Marek Marczykowski-Górecki wrote: > > b_info->u.hvm.{acpi,apic} are deprecated. But also, on recent libxl > > version (4.14) the old one seems to be broken. While libxl part should > > be fixed too, update the

Re: [libvirt PATCH v2 0/4] storage: fully support qcow2 with LUKS volumes

2020-09-18 Thread Michal Prívozník
On 9/17/20 1:59 PM, Daniel P. Berrangé wrote: We added support for LUKS with raw volumes, but never extended it to cover qcow2 volumes. In v2: - Fixed confusion of src/dst volume types - Fixed syntax check - Now with unit tests Daniel P. Berrang=C3=A9 (4): scripts: fix logic error in

Re: [libvirt PATCH 0/3] cpu: Make unknown XML elements fail CPU comparison

2020-09-18 Thread Peter Krempa
On Thu, Sep 17, 2020 at 15:20:18 +0200, Tim Wiederhake wrote: > On Wed, 2020-09-16 at 14:48 +0100, Daniel P. Berrangé wrote: > > On Wed, Sep 16, 2020 at 03:33:53PM +0200, Tim Wiederhake wrote: > > > We currently ignore unknown elements in the CPU XML description, > > > e.g. with vi= > > > rsh > >

Re: [PATCH] libxl: use b_info->{acpi,acpi} when available

2020-09-18 Thread Michal Prívozník
On 9/17/20 7:57 PM, Jim Fehlig wrote: On 9/16/20 3:09 AM, Michal Privoznik wrote: On 9/10/20 6:18 AM, Marek Marczykowski-Górecki wrote: b_info->u.hvm.{acpi,apic} are deprecated. But also, on recent libxl version (4.14) the old one seems to be broken. While libxl part should be fixed too,

Re: [libvirt PATCH 0/2] Add news entries for HAL and GLib DBus

2020-09-18 Thread Erik Skultety
On Thu, Sep 17, 2020 at 06:34:27PM +0200, Pavel Hrdina wrote: > Pavel Hrdina (2): > news: node_device: remove HAL node device backend > news: dbus: use GLib implementation instead of libdbus > > NEWS.rst | 14 ++ > 1 file changed, 14 insertions(+) Reviewed-by: Erik Skultety