Signed-off-by: Roman Bogorodskiy
---
NEWS.rst | 4
1 file changed, 4 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index e708f06e9e..bc35458f38 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -25,6 +25,10 @@ v6.9.0 (unreleased)
``virConnectGetVersion()``, and ``virDomainGetAutostart()`` APIs
For the virtio-9p bhyve command line argument, the proper order
is mount_tag=/path/to/host/dir, not the opposite.
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_command.c | 2 +-
tests/bhyvexml2argvdata/bhyvexml2argv-fs-9p-readonly.args | 2 +-
Signed-off-by: Roman Bogorodskiy
---
docs/drvbhyve.html.in | 21 +
1 file changed, 21 insertions(+)
diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in
index 49d4aa5878..228e8b2bd5 100644
--- a/docs/drvbhyve.html.in
+++ b/docs/drvbhyve.html.in
@@ -482,6 +482,27 @@ to
The aim of virSocketAddrPrefixToNetmask() is to initialize passed
virSocketAddr structure based on prefix length and family.
However, it doesn't set all members in the struct which may lead
to reads of uninitialized values:
==15421== Use of uninitialised value of size 8
==15421==at 0x50F297A:
These XML attributes have been mandatory since the introduction of SEV
support to libvirt. This design decision was based on QEMU's
requirement for these to be mandatory for migration purposes, as
differences in these values across platforms must result in the
pre-migration checks failing (not
These XML attributes have been mandatory since the introduction of SEV
support to libvirt. This design decision was based on QEMU's
requirement for these to be mandatory for migration purposes, as
differences in these values across platforms must result in the
pre-migration checks failing (not
We designed them as mandatory, but these are platform dependent and can be
filled from QEMU capabilities.
Resolves: https://gitlab.com/libvirt/libvirt/-/issues/57
Erik Skultety (3):
qemu_process: sev: Drop an unused variable
qemu: process: sev: Fill missing 'cbitpos' & 'reducedPhysBits' from
Signed-off-by: Erik Skultety
---
src/qemu/qemu_process.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 6b5de29fdb..2cc1d58266 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -6394,9 +6394,8 @@
> On Oct 9, 2020, at 4:58 AM, Pino Toscano wrote:
>
> On Friday, 9 October 2020 10:31:50 CEST Matt Coleman wrote:
>> +static int
>> +hypervDomainSetAutostart(virDomainPtr domain, int autostart)
>> +{
>> +int result = -1;
>> +char uuid_string[VIR_UUID_STRING_BUFLEN];
>> +hypervPrivate
On Fri, Oct 09, 2020 at 12:47:16 +0200, Tim Wiederhake wrote:
> I encountered some references to a cpu_map.xml file which was
> moved to a subdirectory in commit 3ecbac95cd and split up in to
> different files in 2c127947ae and e6d7be38b9. This series removes
> all remaining references to this
On some architectures, e.g. aarch64 and s390x, the output of
`virsh capabilities` is not suitable for use in
`virsh hypervisor-cpu-baseline`. Expand the description of the
man page to make this explicit.
https://bugzilla.redhat.com/show_bug.cgi?id=1850654
Signed-off-by: Tim Wiederhake
---
> On Oct 9, 2020, at 4:43 AM, Daniel P. Berrangé wrote:
>
> On Fri, Oct 09, 2020 at 04:31:54AM -0400, Matt Coleman wrote:
>> Signed-off-by: Matt Coleman
>> ---
>> src/hyperv/hyperv_driver.c | 15 +++
>> src/hyperv/hyperv_wmi_classes.h | 1 +
>> 2 files changed, 12 insertions(+),
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 8 ++--
src/hyperv/hyperv_wmi_classes.h | 1 +
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 89840f7ac4..c91bc58488 100644
---
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 15 +++
src/hyperv/hyperv_wmi_classes.h | 1 +
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 0b28c1e94b..89840f7ac4 100644
---
Signed-off-by: Matt Coleman
---
NEWS.rst | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/NEWS.rst b/NEWS.rst
index e708f06e9e..9404ed7809 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -22,8 +22,11 @@ v6.9.0 (unreleased)
* hyperv: implement new APIs
The
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c| 77 ++
src/hyperv/hyperv_wmi_generator.input | 78 +++
2 files changed, 155 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 28
1 file changed, 28 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 6b2acbc405..7e2bc002bd 100644
--- a/src/hyperv/hyperv_driver.c
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 48 +
src/hyperv/hyperv_wmi_classes.h | 1 +
2 files changed, 49 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index
This set of patches adds several new APIs and fixes several others.
Matt Coleman (7):
hyperv: implement domainSetAutostart
hyperv: implement nodeGetFreeMemory
hyperv: implement domainReboot and domainReset
hyperv: implement domainShutdown and domainShutdownFlags
hyperv: fix
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 92 ++
1 file changed, 92 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 2ac30fa4c6..6b2acbc405 100644
---
On Fri, 2020-10-09 at 07:11 -0400, Neal Gompa wrote:
> On Fri, Oct 9, 2020 at 4:49 AM Andrea Bolognani wrote:
> > On Thu, 2020-10-08 at 22:17 -0400, Neal Gompa wrote:
> > > I've got a patch set locally that adds the few knobs needed to make
> > > openSUSE build with the upstream spec file. If you
On Thu, Oct 08, 2020 at 11:36:56AM -0500, Jonathon Jongsma wrote:
> On Thu, 8 Oct 2020 16:26:56 +0200
> Pavel Hrdina wrote:
>
> > As preparation for g_autoptr() we need to change the function to take
> > only virCgroupPtr.
> >
> > Signed-off-by: Pavel Hrdina
> > ---
> > src/libvirt-lxc.c
Bug fixes and comments specific to older versions have been removed.
Signed-off-by: Matt Coleman
---
libvirt.spec.in| 2 +-
meson.build| 2 +-
src/hyperv/hyperv_driver.c | 4 +---
src/hyperv/hyperv_wmi.c| 8
src/hyperv/openwsman.h | 21
This header's main purpose was to work around bugs in older versions of
openwsman. Most of the files using it only needed wsman-api.h, which
they now include directly.
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 1 -
src/hyperv/hyperv_private.h | 3 ++-
As Daniel mentioned in the thread for my commit "hyperv: make
Msvm_ComputerSystem WQL queries locale agnostic", we can increase the
minimum openwsman version since all the supported distributions have at
least version 2.6.3.
Comments about older versions have been removed throughout the codebase.
On 10/9/20 7:09 AM, Ján Tomko wrote:
> Signed-off-by: Ján Tomko
> Reported-by: John Ferlan
> Fixes: 8487595bee0c04e56b0d8e866c5c71318faf1689
> Signed-off-by: Ján Tomko
> ---
> /me gets the paper bag
> > src/remote/remote_driver.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: John
> On Oct 5, 2020, at 12:20 PM, Matt Coleman wrote:
>
> These patches fix a couple bugs, consolidate duplicate code, and
> implement several APIs.
If one of the primary maintainers has a chance, I think these changes
are ready. Pino gave me some great feedback on v1, but said on IRC that
it
On Fri, Oct 9, 2020 at 4:49 AM Andrea Bolognani wrote:
>
> On Thu, 2020-10-08 at 22:17 -0400, Neal Gompa wrote:
> > On Thu, Oct 8, 2020 at 1:43 PM Andrea Bolognani wrote:
> > > We lost this coverage during the move from CentOS CI to GitLab CI,
> > > and it's high time we brought it back.
> > >
>
On Fri, Oct 9, 2020 at 5:27 AM Andrea Bolognani wrote:
>
> Changes from [v1]:
>
> * address review feedback.
>
> [v1] https://www.redhat.com/archives/libvir-list/2020-October/msg00336.html
>
> Andrea Bolognani (9):
> spec: Simplify setting features off by default
> spec: firewalld is always
Signed-off-by: Ján Tomko
Reported-by: John Ferlan
Fixes: 8487595bee0c04e56b0d8e866c5c71318faf1689
Signed-off-by: Ján Tomko
---
/me gets the paper bag
src/remote/remote_driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index
"cpu_map.xml" was moved to a directory "cpu_map" and split up into
several files.
Signed-off-by: Tim Wiederhake
---
src/qemu/qemu_capabilities.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index
"cpu_map.xml" was moved to a directory "cpu_map" and split up into
several files.
Signed-off-by: Tim Wiederhake
---
tests/cputest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/cputest.c b/tests/cputest.c
index bf5ce84aa7..87ad5825b8 100644
--- a/tests/cputest.c
"cpu_map.xml" was moved to a directory "cpu_map" and split up into
several files.
Signed-off-by: Tim Wiederhake
---
docs/formatdomain.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index cc4f91d4ea..0ffb1b7196 100644
---
Actual change is "s/``elements``/``feature`` elements/", rest is
reflow.
Signed-off-by: Tim Wiederhake
---
docs/formatdomain.rst | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index 0ffb1b7196..df5ac28028 100644
---
I encountered some references to a cpu_map.xml file which was
moved to a subdirectory in commit 3ecbac95cd and split up in to
different files in 2c127947ae and e6d7be38b9. This series removes
all remaining references to this file and fixes an unrelated minor
issue in the description of the
On Thu, Oct 08, 2020 at 08:17:09PM +0200, Andrea Bolognani wrote:
> On Thu, 2020-10-08 at 15:59 +0200, Pavel Hrdina wrote:
> > +++ b/meson_options.txt
> > @@ -8,6 +8,7 @@ option('test_coverage', type: 'boolean', value: false,
> > description: 'turn on cod
> > option('git_werror', type:
On Thu, Oct 08, 2020 at 08:16:59PM +0200, Andrea Bolognani wrote:
> On Thu, 2020-10-08 at 15:59 +0200, Pavel Hrdina wrote:
> > + 'parallels': parallels_sdk_dep.found(),
>
> Should this be 'parallels-sdk'?
Sure, I'll change it before pushing.
Pavel
signature.asc
Description: PGP signature
On Thu, Oct 08, 2020 at 08:18:51PM +0200, Andrea Bolognani wrote:
> On Thu, 2020-10-08 at 15:58 +0200, Pavel Hrdina wrote:
> > Pavel Hrdina (15):
> > meson_options: change VMware default from enabled to auto
> > meson_options: change VirtualBox default from enabled to auto
> > meson_options:
On Thu, Oct 08, 2020 at 08:16:49PM +0200, Andrea Bolognani wrote:
> On Thu, 2020-10-08 at 15:58 +0200, Pavel Hrdina wrote:
> > +++ b/meson_options.txt
> > @@ -31,6 +31,7 @@ option('numactl', type: 'feature', value: 'auto',
> > description: 'numactl support'
> > option('openwsman', type:
On 10/8/20 8:12 AM, Ján Tomko wrote:
> Signed-off-by: Ján Tomko
> ---
> src/remote/remote_daemon_config.c | 3 +-
> src/remote/remote_daemon_dispatch.c | 225 ++--
> src/remote/remote_daemon_stream.c | 6 +-
> src/remote/remote_driver.c | 102
It belongs before package-specific feature flags are defined.
Signed-off-by: Andrea Bolognani
Reviewed-by: Neal Gompa
---
libvirt.spec.in | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index ae6381fe3e..dd2247d712 100644
---
With this commit, all architecture lists that we base feature
enablement decisions on are defined within a few lines of each
other, increasing maintainability.
Additionally, generic architecture lists that appear in the
conditions for multiple features are defined, so that repetition
is reduced.
Remove the red herring.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 508b4c8dcc..66f0560a5c 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -84,6 +84,9 @@
%define
Knowing this, we can remove some code.
Signed-off-by: Andrea Bolognani
Reviewed-by: Neal Gompa
---
libvirt.spec.in | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 36a2cac2b2..508b4c8dcc 100644
--- a/libvirt.spec.in
+++
Keep it close to similar ones.
Signed-off-by: Andrea Bolognani
Reviewed-by: Neal Gompa
---
libvirt.spec.in | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 66f0560a5c..d9fa27a5fe 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@
Changes from [v1]:
* address review feedback.
[v1] https://www.redhat.com/archives/libvir-list/2020-October/msg00336.html
Andrea Bolognani (9):
spec: Simplify setting features off by default
spec: firewalld is always enabled
spec: bash completion actually defaults to on
spec: Move
Neither Fedora nor RHEL build packages on this architecture.
Signed-off-by: Andrea Bolognani
Reviewed-by: Neal Gompa
Reviewed-by: Thomas Huth
---
libvirt.spec.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index
To keep things maintainable, we want to have architecture handling
all in one spot instead of sprinkling %ifarch conditionals all over
the place.
Signed-off-by: Andrea Bolognani
Reviewed-by: Neal Gompa
---
libvirt.spec.in | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git
The right-hand side of these expressions will always evaluate to
zero. Stop obfuscating this fact.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index
There's no need to set a default for it if we're going to override
it immediately afterwards anyway, and setting with_qemu_tcg at the
same time only makes things more confusing.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 25 -
1 file changed, 12 insertions(+),
On Fri, Oct 09, 2020 at 04:56:09AM -0400, Matt Coleman wrote:
> > On Oct 9, 2020, at 4:43 AM, Daniel P. Berrangé wrote:
> >
> > On Fri, Oct 09, 2020 at 04:31:54AM -0400, Matt Coleman wrote:
> >> Signed-off-by: Matt Coleman
> >> ---
> >> src/hyperv/hyperv_driver.c | 15 +++
> >>
On Friday, 9 October 2020 10:31:50 CEST Matt Coleman wrote:
> +static int
> +hypervDomainSetAutostart(virDomainPtr domain, int autostart)
> +{
> +int result = -1;
> +char uuid_string[VIR_UUID_STRING_BUFLEN];
> +hypervPrivate *priv = domain->conn->privateData;
> +
On Thu, 2020-10-08 at 22:17 -0400, Neal Gompa wrote:
> On Thu, Oct 8, 2020 at 1:43 PM Andrea Bolognani wrote:
> > We lost this coverage during the move from CentOS CI to GitLab CI,
> > and it's high time we brought it back.
> >
> > Building RPMs is currently skipped for:
> >
> > * openSUSE,
On Fri, Oct 09, 2020 at 04:31:54AM -0400, Matt Coleman wrote:
> Signed-off-by: Matt Coleman
> ---
> src/hyperv/hyperv_driver.c | 15 +++
> src/hyperv/hyperv_wmi_classes.h | 1 +
> 2 files changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/src/hyperv/hyperv_driver.c
On 05/10/2020 20.40, Andrea Bolognani wrote:
> Neither Fedora nor RHEL build packages on this architecture.
>
> Signed-off-by: Andrea Bolognani
> ---
> libvirt.spec.in | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index
On 8/21/20 12:59 PM, Fangge Jin wrote:
The original descirption for *_tls_x509_verify is a little misleading
by saying that "Enabling this option will reject any client who does
not have a ca-cert.pem certificate".
Signed-off-by: Fangge Jin
---
src/qemu/qemu.conf | 20
On 10/9/20 9:46 AM, Matt Coleman wrote:
As Daniel mentioned in the thread for my commit "hyperv: make
Msvm_ComputerSystem WQL queries locale agnostic", we can increase the
minimum openwsman version since all the supported distributions have at
least version 2.6.3.
Comments about older versions
On 10/8/20 3:18 PM, Roman Bogorodskiy wrote:
Roman Bogorodskiy wrote:
Recently virtio-9p support was added to bhyve.
On the host side it looks this way:
bhyve -s 25:0,virtio-9p,sharename=/path/to/shared/dir
It could also have ",ro" suffix to make share read-only.
In the Linux
On 10/9/20 9:14 AM, Matt Coleman wrote:
On Oct 5, 2020, at 12:20 PM, Matt Coleman wrote:
These patches fix a couple bugs, consolidate duplicate code, and
implement several APIs.
If one of the primary maintainers has a chance, I think these changes
are ready. Pino gave me some great feedback
On 10/2/20 4:42 PM, Daniel Henrique Barboza wrote:
The code is ok but the commit message can be improved. Usually
we want a commit title with a single-line summary of what you're
changing, a blank line, and a description describes in more
the change, and your signed-off tag. This guideline can
On 10/5/20 3:34 PM, Mauro Matteo Cascella wrote:
Signed-off-by: Mauro Matteo Cascella
---
Rephrased sentence.
docs/submitting-patches.rst | 3 +++
1 file changed, 3 insertions(+)
Reviewed-by: Michal Privoznik
and pushed.
Michal
On 10/8/20 7:42 PM, Andrea Bolognani wrote:
See it in action:
https://gitlab.com/abologna/libvirt/-/pipelines/199936179
Andrea Bolognani (3):
ci: Refresh Dockerfiles
ci: Allow skipping dist
ci: Start building RPMs
.gitlab-ci.yml| 41
62 matches
Mail list logo
