Since 'block-export-add' is new to 5.2, we can still tweak the
interface; there, allowing 'bitmaps':['str'] is nicer than
'bitmap':'str'. This wires up the qapi and qemu-nbd changes to permit
passing multiple bitmaps as distinct metadata contexts that the NBD
client may request, but the actual
ping. Any reviews?
On Sat, Oct 10, 2020 at 3:07 PM Han Han wrote:
> Diffence from v5:
> - conf: implement virStringSplit() to parse the src->path
> - tests: Add the cases of path 'pool//image' to
> disk-network-rbd-namespace test
> - temporarily removed the patch of news
> - tweak of version
On Mon, Oct 26, 2020 at 7:30 PM Andrea Bolognani wrote:
>
> When trying to figure out whether virt-ssh-helper is available
> on the remote host, we mistakenly look for the helper by the
> name it had while the feature was being worked on instead of
> the one that was ultimately picked, and thus
On Mon, Oct 26, 2020 at 7:31 PM Andrea Bolognani wrote:
>
> Signed-off-by: Andrea Bolognani
> ---
> NEWS.rst | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/NEWS.rst b/NEWS.rst
> index 3587bc2c13..5bd8ed1c91 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -46,6 +46,12 @@ v6.9.0
See patch 1 for details.
Andrea Bolognani (2):
rpc: Fix virt-ssh-helper detection
news: Mention virt-ssh-helper detection fix
NEWS.rst | 6 ++
src/rpc/virnetclient.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
--
2.26.2
On Fri, 2020-07-24 at 18:22 +0200, Andrea Bolognani wrote:
> On Fri, 2020-07-24 at 16:14 +0100, Daniel P. Berrangé wrote:
> > char *
> > +virNetClientSSHHelperCommand(virNetClientProxy proxy,
> > + const char *netcatPath,
> > + const char
When trying to figure out whether virt-ssh-helper is available
on the remote host, we mistakenly look for the helper by the
name it had while the feature was being worked on instead of
the one that was ultimately picked, and thus end up using the
netcat fallback every single time.
Fixes:
Signed-off-by: Andrea Bolognani
---
NEWS.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 3587bc2c13..5bd8ed1c91 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -46,6 +46,12 @@ v6.9.0 (unreleased)
Relying on the "Description" field caused queries to fail on
> On Oct 26, 2020, at 2:02 PM, Jiri Denemark wrote:
>
> I have just tagged v6.9.0-rc1 in the repository and pushed signed
> tarballs and source RPMs to https://libvirt.org/sources/
>
> Please give the release candidate some testing and in case you find a
> serious issue which should have a fix
Contemporary versions of Fedora automatically set SOURCE_DATE_EPOCH
based on the changelog entry date stamp. In scenarios where it already
is defined, we do not want to redefine it.
Additionally, when building the libvirt package in an Open Build Service
instance, the spec file is not present in
On Mon, Oct 26, 2020 at 2:03 PM Jiri Denemark wrote:
>
> I have just tagged v6.9.0-rc1 in the repository and pushed signed
> tarballs and source RPMs to https://libvirt.org/sources/
>
> Please give the release candidate some testing and in case you find a
> serious issue which should have a fix
As it turns out, the rather complicated structure that is
currently used for enabling or disabling features in the libvirt
build does not cleanly map well to RPM's bcond feature.
Consequently, we need these back in order to support trivially
activating these features through extra macros as build
On 10/26/20 10:45 AM, Peter Krempa wrote:
> We didn't use it rigorously and some helpers even dasted it away. Remove
s/dasted/cast/
(both the typo, and the odd English word whose present and past tense
forms are identical)
> const from all hash utility functions.
>
> Signed-off-by: Peter
Peter,
> Sent: Saturday, October 24, 2020 at 8:28 AM
> From: "daggs"
> To: "Peter Krempa"
> Cc: libvir-list@redhat.com
> Subject: Re: [PATCH 0/6] qemu: Fix cdrom as SCSI hostdev via -blockdev
>
> Greetings Peter,
>
> looks like I was mistaken, I see the same prints in 6.8.0 + your patchset.
>
I have just tagged v6.9.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
On a Wednesday in 2020, Yi Li wrote:
Eliminate cleanup code by using g_autofree.
Signed-off-by: Yi Li
---
src/qemu/qemu_monitor_json.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Ján Tomko
And pushed.
Jano
signature.asc
Description: PGP signature
On 10/26/20 1:51 PM, Peter Krempa wrote:
Use the 'parent' axis to check whether the parent is a div with
class='section' rather than looking for 'toc-backref' anchor to see
whether to generate one of the headerlink alternatives. Both hare
docutils-specific thus apply to docs generated from RST
Ping? (patch Acked).
On 10/19/20 10:21 AM, Philippe Mathieu-Daudé wrote:
Since commit aa35ec2213b ("hw/arm/raspi: Use more
specific machine names") the raspi2/raspi3 machines
have been renamed as raspi2b/raspi3b.
As more Raspberry Pi 2/3 models are emulated, in order
to avoid confusion
On a Tuesday in 2020, Laine Stump wrote:
These started with a couple small cleanups to functions I was going to
change the API for, but then I decided not to change the API, and just
didn't want to waste the effort spent cleaning them up.
Thank you.
Laine Stump (9):
util: simplify
On Montag, 26. Oktober 2020 09:12:38 CET Michal Privoznik wrote:
> On 10/23/20 4:19 PM, Christian Schoenebeck wrote:
> > On Donnerstag, 22. Oktober 2020 19:07:33 CEST Michal Privoznik wrote:
> >> [Please don't CC random people on patches until asked to, we are all
> >> subscribed to the list]
> >
On a Monday in 2020, Peter Krempa wrote:
Rename 'data' argument which is used for opaque data.
Signed-off-by: Peter Krempa
---
src/util/virhash.c | 24
src/util/virhash.h | 14 +++---
2 files changed, 19 insertions(+), 19 deletions(-)
Reviewed-by: Ján Tomko
Polite ping. Have there been relevant updates elsewhere that I might've
missed? Thanks!
On 9/24/20 8:22 PM, Collin Walling wrote:
> The following patches provide some TLC to the hypervisor CPU baseline
> handler within the qemu_driver code.
>
> #1 checks for the cpu-model-expansion capability
On a Monday in 2020, Peter Krempa wrote:
Simulate that the device is a cdrom when the path equals to /dev/cdrom
to provide testing for the 'host_cdrom' backend.
Signed-off-by: Peter Krempa
---
I've already posted this before but I mistakenly identified is as wrong
and self-NACKed it, but we
On a Tuesday in 2020, Michal Prívozník wrote:
On 10/20/20 12:22 PM, Daniel P. Berrangé wrote:
The fallback for distros which lack pkg-config support for devmapper
references an undefined variable "tmp". It appears non of our supported
build platforms are triggering this bug and so the fallback
On Mon, Oct 26, 2020 at 04:45:50PM +0100, Peter Krempa wrote:
> Glib's hash table provides basically the same functionality as our hash
> table.
>
> In most cases the only thing that remains in the virHash* wrappers is
> NULL-checks of '@table' argument as glib's hash functions don't tolerate
>
On Thu, Oct 22, 2020 at 05:10:10PM +0200, Christian Schoenebeck wrote:
> I'm suggesting to add the AppArmor permission "l" on libvirt export pathes
> to allow guests creating hard links, which is currently a problem for 9pfs
> mounts.
>
> Since the suggested patch would affect virtiofs as well, I
There's no much sense to test the remnants of the functions which just
NULL-check prior to handing off to g_hash_table* functions.
Signed-off-by: Peter Krempa
---
tests/meson.build | 1 -
tests/virhashdata.h | 284 ---
tests/virhashtest.c | 539
For functions which have reasonable replacement, let's encourage usage
of g_hash_table_ alternatives.
Signed-off-by: Peter Krempa
---
src/util/virhash.c | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/src/util/virhash.c b/src/util/virhash.c
Glib's hash table provides basically the same functionality as our hash
table.
In most cases the only thing that remains in the virHash* wrappers is
NULL-checks of '@table' argument as glib's hash functions don't tolerate
NULL.
In case of iterators, we adapt the existing API of iterators to
All but one of the callers either use the list in arbitrary order or
sorted by key. Rewrite the function so that it supports sorting by key
natively and make it return the element count. This in turn allows to
rewrite the only caller to sort by value internally.
This allows to remove multiple
Our hash table API was surprisingly close to glibs.
Peter Krempa (13):
virhashtest: testHashGetItems: Remove test case for sorting by value
util: hash: Rewrite sorting of elements in virHashGetItems
util: virhash: Standardize on 'opaque' for opaque data
util: hash: Introduce
'virHashForEach' historically allowed deletion of the current element as
'virHashRemoveSet' didn't exits. To prevent us from having to deepy
analyse all iterators add virHashForEachSafe which first gets a list of
elements and iterates them outside of the hash table.
This will allow replace the
Upcoming patch will rewrite virHashGetItems to remove the sorting
function since the prevalent mode is to order by keys.
Remove the test for it.
Signed-off-by: Peter Krempa
---
tests/virhashtest.c | 19 ---
1 file changed, 19 deletions(-)
diff --git a/tests/virhashtest.c
We didn't use it rigorously and some helpers even dasted it away. Remove
const from all hash utility functions.
Signed-off-by: Peter Krempa
---
src/conf/nwfilter_params.c | 2 +-
src/conf/nwfilter_params.h | 2 +-
src/util/virhash.c | 17 -
src/util/virhash.h |
Don't hide our use of GHashTable behind our typedef. This will also
promote the use of glibs hash function directly.
Signed-off-by: Peter Krempa
---
src/conf/backup_conf.c| 2 +-
src/conf/domain_addr.h| 2 +-
src/conf/domain_conf.c|
Convert all calls to virHashForEach where it's not obvious that the
callback is _not_ deleting the current element from the hash to
virHashForEachSafe which will be deemed safe to do such operation.
Now that no iterator used with virHashForEach deletes current element we
can document that
The simplest way to write tests is to check the output against expected
output, but we must ensure that the output is stable. We can use
virHashForEachSorted as a hash iterator to ensure stable ordering.
This patch fixes 3 instances of hash iteration which is tested in
various parts, including
Code which is sensitive to ordering now uses deterministic iterator
functions, so we can remove the mock override.
Signed-off-by: Peter Krempa
---
tests/meson.build| 1 -
tests/qemublocktest.c| 2 +-
tests/qemumonitorjsontest.c | 2 +-
tests/qemuxml2xmltest.c
Rename 'data' argument which is used for opaque data.
Signed-off-by: Peter Krempa
---
src/util/virhash.c | 24
src/util/virhash.h | 14 +++---
2 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/src/util/virhash.c b/src/util/virhash.c
index
Iterate the hash elements sorted by key. This is useful to provide a
stable ordering such as in cases when the output is checked in tests.
Signed-off-by: Peter Krempa
---
src/libvirt_private.syms | 1 +
src/util/virhash.c | 39 +++
src/util/virhash.h
On 10/26/20 8:19 AM, Peter Krempa wrote:
> qemu decided to modify the arguments of 'block-export-add' to include an
> array of bitmaps rather than a single bitmap.
>
> Since we've added the code prior to qemu setting the interface in stone
> and thus it will be changed incompatibly and we already
Looking at the entire repository reveals we're not too consistent
about this, but at least in this specific document we mostly have
two blank lines between sections, so let's stick with that.
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
NEWS.rst | 2 ++
1 file changed, 2
Simulate that the device is a cdrom when the path equals to /dev/cdrom
to provide testing for the 'host_cdrom' backend.
Signed-off-by: Peter Krempa
---
I've already posted this before but I mistakenly identified is as wrong
and self-NACKed it, but we don't really have a test for a backed by a
On 10/26/20 8:19 AM, Peter Krempa wrote:
> Now that qemu stabilized it's interface and we've switched to the new
> design we can re-enable use of 'block-export-add'
>
> This reverts commit TBD!!
Cute - but it works! Obviously, as with 2/3, you'll add S-o-b when the
commit message is fixed.
On 10/26/20 8:19 AM, Peter Krempa wrote:
> We use the capability to switch to using 'block-export-add' in the
> upcoming qemu release instead of the at the same time deprecated
> 'nbd-server-add'.
>
> Unfortunately qemu wants to change the interface of 'block-export-add'
> before the release.
Now on every nwfilter config package update we overwrite existing filters
entirely. It is desired to bring new version of filters on update but we'd
better keep their uuids I guess.
Actually patch primarily address noise in logs on update. If both libvirtd and
firewalld are running and libvirt is
On Mon, Oct 26, 2020 at 14:19:29 +0100, Peter Krempa wrote:
> qemu decided to modify the arguments of 'block-export-add' to include an
> array of bitmaps rather than a single bitmap.
>
> Since we've added the code prior to qemu setting the interface in stone
> and thus it will be changed
qemu decided to modify the arguments of 'block-export-add' to include an
array of bitmaps rather than a single bitmap.
Since we've added the code prior to qemu setting the interface in stone
and thus it will be changed incompatibly and we already have tests for
the new interface we need to update
We use the capability to switch to using 'block-export-add' in the
upcoming qemu release instead of the at the same time deprecated
'nbd-server-add'.
Unfortunately qemu wants to change the interface of 'block-export-add'
before the release. Since we've tried to stay up to date and added the
code
Now that qemu stabilized it's interface and we've switched to the new
design we can re-enable use of 'block-export-add'
This reverts commit TBD!!
---
src/qemu/qemu_capabilities.c | 1 +
tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml | 1 +
2 files changed, 2 insertions(+)
Justification from 1/3:
Unfortunately qemu wants to change the interface of 'block-export-add'
before the release. Since we've tried to stay up to date and added the
code before it was written in stone, we need to disable the use of the
new interface for the upcoming libvirt release so that
On 10/26/20 5:50 AM, Peter Krempa wrote:
> On Fri, Oct 23, 2020 at 13:36:46 -0500, Eric Blake wrote:
>> Since 'nbd-server-add' is deprecated, and 'block-export-add' is new to
>> 5.2, we can still tweak the interface. Allowing 'bitmaps':['str'] is
>> nicer than 'bitmap':'str'. This wires up the
Use the 'parent' axis to check whether the parent is a div with
class='section' rather than looking for 'toc-backref' anchor to see
whether to generate one of the headerlink alternatives. Both hare
docutils-specific thus apply to docs generated from RST documents.
This adds the links for pages
On 10/26/20 6:53 AM, John Ferlan wrote:
On 10/14/20 1:08 PM, Jonathon Jongsma wrote:
The current udev node device driver ignores all events related to vdpa
devices. Since libvirt now supports vDPA network devices, include these
devices in the device list.
Example output:
virsh # nodedev-list
On Mon, Oct 26, 2020 at 11:41:35 +0100, Michal Privoznik wrote:
> In one of recent patches the way that we start NBD server for
> incoming migration was reworked (v6.8.0-rc1~298). A new boolean
> was introduced that tracks whether the NBD server was started so
> that we don't start it twice nor
On Mon, Oct 26, 2020 at 11:41:36 +0100, Michal Privoznik wrote:
> In recent commit v6.8.0-135-g518be41aaa the formatting of NBD
> into migration cookie was moved into a separate function and with
> it it was switched from direct printing into the output buffer to
> virXMLFormatElement(). But there
On Fri, Oct 23, 2020 at 13:36:46 -0500, Eric Blake wrote:
> Since 'nbd-server-add' is deprecated, and 'block-export-add' is new to
> 5.2, we can still tweak the interface. Allowing 'bitmaps':['str'] is
> nicer than 'bitmap':'str'. This wires up the qapi and qemu-nbd
> changes to permit passing
On 10/14/20 1:08 PM, Jonathon Jongsma wrote:
> The current udev node device driver ignores all events related to vdpa
> devices. Since libvirt now supports vDPA network devices, include these
> devices in the device list.
>
> Example output:
>
> virsh # nodedev-list
> [...ommitted long list
In one of recent patches the way that we start NBD server for
incoming migration was reworked (v6.8.0-rc1~298). A new boolean
was introduced that tracks whether the NBD server was started so
that we don't start it twice nor record in the port in the port
allocator twice. Well, this idea is good,
In recent commit v6.8.0-135-g518be41aaa the formatting of NBD
into migration cookie was moved into a separate function and with
it it was switched from direct printing into the output buffer to
virXMLFormatElement(). But there was a typo. The
virXMLFormatElement() accepts two buffers on input, one
The report on libvirt-users [1] got me into testing and I've found
another problem fixed in the other patch.
1: https://www.redhat.com/archives/libvirt-users/2020-October/msg00035.html
Michal Prívozník (2):
qemu: Don't try to start NBD server twice
qemu_migration: Don't mangle NBD part of
On Fri, 23 Oct 2020 19:27:55 +0200
Igor Mammedov wrote:
> On Fri, 23 Oct 2020 11:54:40 -0400
> "Michael S. Tsirkin" wrote:
>
> [...]
> [...]
> [...]
> [...]
> >
> > Rather than adding_device_allowed, something like "query slot"
> > might be helpful for debugging. That would help
On Fri, Oct 23, 2020 at 19:27:55 +0200, Igor Mammedov wrote:
> On Fri, 23 Oct 2020 11:54:40 -0400
> "Michael S. Tsirkin" wrote:
>
> > On Fri, Oct 23, 2020 at 09:47:14AM +0300, Marcel Apfelbaum wrote:
> > > Hi David,
> > >
> > > On Fri, Oct 23, 2020 at 6:49 AM David Gibson wrote:
> > >
> > >
On Tue, Oct 20, 2020 at 13:54:33 -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma
>
> virtiofsd has --thread-pool-size=NUM option to limit the
> thread pool size. It will be useful to tune the performance.
Usually it's great to document or at least link to a document which
outlines how
On 10/23/20 3:53 PM, zhenwei pi wrote:
Signed-off-by: zhenwei pi
---
NEWS.rst | 10 ++
1 file changed, 10 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index d0454b7840..428928e80b 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -13,6 +13,16 @@ v6.9.0 (unreleased)
* **New features**
On 10/23/20 4:19 PM, Christian Schoenebeck wrote:
On Donnerstag, 22. Oktober 2020 19:07:33 CEST Michal Privoznik wrote:
[Please don't CC random people on patches until asked to, we are all
subscribed to the list]
Got it, I'll refrain from CCing on libvirt in future.
Not as erratic as it
On Fri, Oct 23, 2020 at 07:31:42PM +0200, Boris Fiuczynski wrote:
> Since channel subsystem devices can have the capability to create an
> mdev device they should expose this by listing the mdev_types capability.
>
> Many patches of this series is concerned with refactoring existing PCI code.
Hi
Thanks for the reminding. I would fix that in my V3 patches.
在 2020/10/26 14:24, Peter Krempa 写道:
> On Sun, Oct 25, 2020 at 10:35:03 +0800, Hao Wang wrote:
>> Hi Daniel,
>>
>> For the warning in your compiling -- "error:
>> ‘qemuMonitorJSONExtractDirtyRateInfo’ defined but not used
>>
On 10/14/20 1:08 PM, Jonathon Jongsma wrote:
The current udev node device driver ignores all events related to vdpa
devices. Since libvirt now supports vDPA network devices, include these
devices in the device list.
Example output:
virsh # nodedev-list
[...ommitted long list of nodedevs...]
On Sun, Oct 25, 2020 at 10:35:03 +0800, Hao Wang wrote:
> Hi Daniel,
>
> For the warning in your compiling -- "error:
> ‘qemuMonitorJSONExtractDirtyRateInfo’ defined but not used
> [-Werror=unused-function]":
>
> " qemuMonitorJSONExtractDirtyRateInfo" would be called by function
>
70 matches
Mail list logo
