On 11/4/2020 9:02 PM, Martin Kletzander wrote:
On Fri, Oct 16, 2020 at 10:38:51PM +0800, Zhong, Luyao wrote:
On 10/16/2020 9:32 PM, Zang, Rui wrote:
How about if “migratable” is set, “mode” should be ignored/omitted?
So any setting of “mode” will be rejected with an error indicating an
On 06.11.2020 17:03, Jiri Denemark wrote:
> On Tue, Aug 18, 2020 at 13:26:36 +0300, Nikolay Shirokovskiy wrote:
>> During API call connection is referenced and close callback is called when
>> connection is disposed. Thus during API call close callback cannot be
>> triggered
>> and we don't
On Mon, Oct 26, 2020 at 09:50:22AM +0100, Peter Krempa wrote:
> On Tue, Oct 20, 2020 at 13:54:33 -0400, Masayoshi Mizuma wrote:
> > From: Masayoshi Mizuma
> >
> > virtiofsd has --thread-pool-size=NUM option to limit the
> > thread pool size. It will be useful to tune the performance.
>
>
On Fri, Nov 06, 2020 at 02:30:13PM +0100, Michal Privoznik wrote:
If starting an container fails, the virLXCProcessStop() is
called. But since vm->def->id is not set until libvirt_lxc is
spawned (the domain's ID is PID of that process),
virLXCProcessStop() returns early as virDomainObjIsActive()
On Fri, 2020-11-06 at 15:10 +0100, Martin Kletzander wrote:
> On Wed, Oct 28, 2020 at 03:51:48PM +0800, Han Han wrote:
> > Signed-off-by: Han Han
> > ---
> > NEWS.rst | 2 ++
> > 1 file changed, 2 insertions(+)
>
> So yes, this was added in 6.4.0, but I don't know whether we have any policy
>
On Fri, Nov 06, 2020 at 02:30:26PM +0100, Michal Privoznik wrote:
> The virGDBusBusInit is supposed to return a reference to
> requested bus type (system/session) or, if non-shared bus is
> requested then create a new bus of the type. As an argument, it
> gets a double pointer to GError which is
On Thu, Oct 29, 2020 at 11:47:01AM +0100, Andrea Bolognani wrote:
As explained in the original commit (31d687a3218c), these values
are actually unaffected by the corresponding _without_* macros
and so we can leave out the additional processing / obfuscation.
This reverts commit
On Wed, Oct 28, 2020 at 03:51:48PM +0800, Han Han wrote:
Signed-off-by: Han Han
---
NEWS.rst | 2 ++
1 file changed, 2 insertions(+)
So yes, this was added in 6.4.0, but I don't know whether we have any policy
regarding news for older releases as that would create inconsistency and there
is
On Tue, Aug 18, 2020 at 13:26:36 +0300, Nikolay Shirokovskiy wrote:
> During API call connection is referenced and close callback is called when
> connection is disposed. Thus during API call close callback cannot be
> triggered
> and we don't need to unset callback on API call duration.
>
>
On Thu, Oct 22, 2020 at 04:41:18PM +0200, Michal Privoznik wrote:
Some completers for libvirt related tools might want to list
domain IDs only. Just like the one I've implemented for
virt-viewer [1]. I've worked around it using some awk magic,
but if it was possible to just 'virsh list --id'
The virGDBusBusInit is supposed to return a reference to
requested bus type (system/session) or, if non-shared bus is
requested then create a new bus of the type. As an argument, it
gets a double pointer to GError which is passed to all g_dbus_*()
calls which allocate it on failure. Pretty
If starting an container fails, the virLXCProcessStop() is
called. But since vm->def->id is not set until libvirt_lxc is
spawned (the domain's ID is PID of that process),
virLXCProcessStop() returns early as virDomainObjIsActive()
returns false. But doing so leaves behind resources reserved for
On Tue, Aug 18, 2020 at 13:26:35 +0300, Nikolay Shirokovskiy wrote:
> qemuMigrationSrcCleanup uses qemuDomainObjDiscardAsyncJob currently. But
> discard does not reduce jobs_queued counter so it leaks. Also discard does not
> notify other threads that job condition is available. Discard does reset
> On Nov 4, 2020, at 12:05 PM, Peter Krempa wrote:
>
> Our hash table API was surprisingly close to glibs.
>
> v2:
> - pushed ACK'd patch
> - typo fix
> - rebased on current master
> - hashing function not replaced as our has random initialization
>
> Peter Krempa (12):
> virhashtest:
On Wed, Nov 4, 2020 at 12:06 PM Peter Krempa wrote:
>
> Our hash table API was surprisingly close to glibs.
>
> v2:
> - pushed ACK'd patch
> - typo fix
> - rebased on current master
> - hashing function not replaced as our has random initialization
>
> Peter Krempa (12):
> virhashtest:
On Thu, Nov 5, 2020 at 10:33 PM Matt Coleman wrote:
>
> Most of this is making functions void that unnecessarily return an int.
> It also includes some conversion to GLib.
>
> Feel free to squash related commits, if you'd like. I left them separate
> to make it easier to review.
>
> Matt Coleman
On 11/6/20 11:17 AM, Ján Tomko wrote:
On a Friday in 2020, Michal Privoznik wrote:
The whole test is built only if SELinux secdriver is enabled and
thus the !WITH_SELINUX can't be satisfied really.
Which seems like a mistake. testIdentityAttrs does not depend on SELinux
and the virIdentity
On a Friday in 2020, Yi Li wrote:
On 11/6/20, Ján Tomko wrote:
On a Friday in 2020, Yi Li wrote:
---
src/libvirt_private.syms | 1 -
src/util/virxml.c| 21 -
src/util/virxml.h| 1 -
3 files changed, 23 deletions(-)
Looks good, but it's missing a sign-off.
On a Friday in 2020, Michal Privoznik wrote:
The whole test is built only if SELinux secdriver is enabled and
thus the !WITH_SELINUX can't be satisfied really.
Which seems like a mistake. testIdentityAttrs does not depend on SELinux
and the virIdentity APIs it tests are called even from code
On 11/6/20, Ján Tomko wrote:
> On a Friday in 2020, Yi Li wrote:
>>---
>> src/libvirt_private.syms | 1 -
>> src/util/virxml.c| 21 -
>> src/util/virxml.h| 1 -
>> 3 files changed, 23 deletions(-)
>>
>
> Looks good, but it's missing a sign-off.
>
> Can you,
On a Friday in 2020, Yi Li wrote:
---
src/libvirt_private.syms | 1 -
src/util/virxml.c| 21 -
src/util/virxml.h| 1 -
3 files changed, 23 deletions(-)
Looks good, but it's missing a sign-off.
Can you, please, include a Signed-off-by line to indicate you
The whole test is built only if SELinux secdriver is enabled and
thus the !WITH_SELINUX can't be satisfied really. Also, the block
references @ret variable which exists no more after v5.9.0-rc1~269.
Signed-off-by: Michal Privoznik
---
tests/viridentitytest.c | 8
1 file changed, 8
On 11/5/20 10:04 PM, Barrett J Schonefeld wrote:
Hey folks,
We appreciate the feedback, and we've used this to complete some initial
work on issue 11.
We started with small changes in src/util, and we submitted them via
email (following these guidelines on submitting patches
23 matches
Mail list logo
