[PATCH 5/5] qemu: Remove virQEMUDomainCapsCache code

2020-11-15 Thread Michal Privoznik
Now that the domCaps cache is history, this code is no longer used and thus can be removed. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 129 --- src/qemu/qemu_capabilities.h | 10 --- 2 files changed, 139 deletions(-) diff --git a/src/qemu

[PATCH 4/5] qemu: Don't cache domCaps in virQEMUDriverGetDomainCapabilities()

2020-11-15 Thread Michal Privoznik
Currently, whenever a domain capabilities is needed (fortunately, after cleanup done by previous commits it is now only in virConnectGetDomainCapabilities()), the object is stored in a cache. But there is no invalidation mechanism for the cache (except the implicit one - the cache is part of qemuCa

[PATCH 3/5] conf: Drop virDomainCapsDeviceDefValidate()

2020-11-15 Thread Michal Privoznik
Now that nothing uses virDomainCapsDeviceDefValidate() it can be removed. Signed-off-by: Michal Privoznik --- src/conf/domain_capabilities.c | 55 -- src/conf/domain_capabilities.h | 4 --- src/libvirt_private.syms | 1 - src/qemu/qemu_validate.c | 1

[PATCH 0/5] qemu: Don't cache domCaps

2020-11-15 Thread Michal Privoznik
See 4/5 for explanation. Michal Prívozník (5): qemu: Validate RNG model qemu: Validate video model conf: Drop virDomainCapsDeviceDefValidate() qemu: Don't cache domCaps in virQEMUDriverGetDomainCapabilities() qemu: Remove virQEMUDomainCapsCache code src/conf/domain_capabilities.c

[PATCH 2/5] qemu: Validate video model

2020-11-15 Thread Michal Privoznik
The aim is to eliminate virDomainCapsDeviceDefValidate(). And in order to do so, the domain video model has to be validated in qemuValidateDomainDeviceDefVideo(). Signed-off-by: Michal Privoznik --- src/conf/domain_capabilities.c| 19 + src/qemu/qemu_validate.c

[PATCH 1/5] qemu: Validate RNG model

2020-11-15 Thread Michal Privoznik
The aim is to eliminate virDomainCapsDeviceDefValidate(). And in order to do so, the domain RNG model has to be validated in qemuValidateDomainRNGDef(). Signed-off-by: Michal Privoznik --- src/conf/domain_capabilities.c | 18 +- src/qemu/qemu_validate.c | 25 +++

Re: [PATCH libvirt v2 01/11] nodedev: detect AP card device

2020-11-15 Thread Bjoern Walk
Jonathon Jongsma [2020-11-13, 09:28AM -0600]: > That said, I don't believe that your parsing code actually supports an > optional '0x' prefix. In virNodeDevCapAPCardParseXML(), you call > > virStrToLong_uip(adapter, NULL, 0, &ap_card->ap_adapter) > > But I'm quite sure that passing a value o

nwfilter issue with new ebtables

2020-11-15 Thread Christian Ehrhardt
Hi, I have last week discussed breakage in nwfilter usage on IRC virsh start error: Failed to start domain error: internal error: applyDHCPOnlyRules failed - spoofing not protect With debug in the logs enabled I got confirmation by Daniel (thanks!) that the command sequence li

[PATCH] News: Several apparmor improvements at v6.7.0[v3]

2020-11-15 Thread jgao
From: Jianan Gao Add news about apparmor about the improvements. Signed-off-by: Jianan Gao --- Clarified news content and revised commit information --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 905deba5a8..fd3254d47f 100644 --- a/NEWS.rst +++

Re: [libvirt PATCH 1/2] network: Drop UUID handling for default network

2020-11-15 Thread Laine Stump
On 11/15/20 3:43 PM, Andrea Bolognani wrote: We are generating a fresh UUID and storing it in the XML for the default network, but this is unnecessary because the network driver will automatically generate one if it's missing from the XML; But that automatically generated uuid will not be stor

[libvirt PATCH 1/2] network: Drop UUID handling for default network

2020-11-15 Thread Andrea Bolognani
We are generating a fresh UUID and storing it in the XML for the default network, but this is unnecessary because the network driver will automatically generate one if it's missing from the XML; the fact that we only do this if the uuidgen command happens to be available on the build machine is fur

[libvirt PATCH 2/2] spec: Drop UUID handling for default network

2020-11-15 Thread Andrea Bolognani
We're no longer generating a UUID during installation, so we clearly don't need to strip it afterwards; and since the network driver is perfectly capable of generating a UUID if necessary, we don't need to do that at %post time either. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 4

[libvirt PATCH 0/2] network: Drop UUID handling for default network

2020-11-15 Thread Andrea Bolognani
cc30b49f-6084-48da-879e-55645459f2a0 Andrea Bolognani (2): network: Drop UUID handling for default network spec: Drop UUID handling for default network libvirt.spec.in | 4 src/network/meson.build | 32 +++- 2 files changed, 7 insertions(+), 29 delet

[libvirt PATCH] Do not disable incompatible-pointer-types-discards-qualifiers

2020-11-15 Thread Martin Kletzander
This reverts commit b3710e9a2af402a2b620de570b062294e11190eb. That check is very valuable for our code, but it causes issue with glib >= 2.67.0 when building with clang. The reason is a combination of two commits in glib, firstly fdda405b6b1b which adds a g_atomic_pointer_{set,get} variants that