Re: [PATCH for-5.2] docs: Fix some typos (found by codespell)

2020-11-17 Thread Michael S. Tsirkin
On Tue, Nov 17, 2020 at 08:34:48PM +0100, Stefan Weil wrote: > Fix also a similar typo in a code comment. > > Signed-off-by: Stefan Weil Reviewed-by: Michael S. Tsirkin > --- > docs/can.txt | 8 > docs/interop/vhost-user.rst | 2 +- > docs/replay.txt

Re: [PATCH v1 02/10] qemu_domain.c: align memory modules before calculating 'initialmem'

2020-11-17 Thread Peter Krempa
On Mon, Nov 16, 2020 at 20:43:09 +0100, Andrea Bolognani wrote: > On Fri, 2020-11-13 at 16:23 -0300, Daniel Henrique Barboza wrote: > > On 11/13/20 10:51 AM, Andrea Bolognani wrote: > > > I only skimmed the remaining patches and didn't dig into the code as > > > much, or as recently, as you have,

Re: [libvirt PATCH 06/11] qemu_monitor_json: explicitly ignore return values

2020-11-17 Thread Peter Krempa
On Mon, Nov 16, 2020 at 18:04:38 +0100, Pavel Hrdina wrote: > On Mon, Nov 16, 2020 at 05:20:00PM +0100, Peter Krempa wrote: > > On Mon, Nov 16, 2020 at 17:09:17 +0100, Pavel Hrdina wrote: > > > On Mon, Nov 16, 2020 at 04:58:56PM +0100, Peter Krempa wrote: > > > > On Mon, Nov 16, 2020 at 16:38:53

Re: [PATCH v2 1/6] Introduce OpenSSH authorized key file mgmt APIs

2020-11-17 Thread Peter Krempa
On Mon, Nov 16, 2020 at 18:41:57 +0100, Michal Privoznik wrote: > On 11/16/20 3:46 PM, Peter Krempa wrote: > > On Mon, Nov 16, 2020 at 13:20:58 +0100, Michal Privoznik wrote: > > > When setting up a new guest or when a management software wants > > > to allow access to an existing guest the > > >

Re: [PATCH] add phytium FT-2000+ and Tengyun-S2500 support on arm architecture.

2020-11-17 Thread Han Han
Just a reminder: remember to mention that in the NEWS after the patch is merged. On Wed, Nov 18, 2020 at 9:06 AM wrote: > From: Shaojun Yang > > Signed-off-by: Shaojun Yang > --- > src/cpu_map/arm_Phytium.xml | 10 ++ > src/cpu_map/arm_vendors.xml | 1 + > src/cpu_map/index.xml

Re: [libvirt] improve security by adjusting the privileges of libvirtd processes

2020-11-17 Thread Neal Gompa
On Mon, Nov 16, 2020 at 7:12 AM yebiaoxiang wrote: > > Hi Team > > The daemon libvirtd runs as root user, which against the least privilege > security model. > > root 567642 1.2 0.0 2856020 47576 ? Ssl 15:49 0:02 /usr/sbin/libvirtd --listen > > In addition, the "--listen" parameter exposes TCP or

Re: [PATCH] apparmor: allow kvm-spice compat wrapper

2020-11-17 Thread Neal Gompa
On Tue, Nov 17, 2020 at 11:49 AM Christian Ehrhardt wrote: > > On Mon, Nov 16, 2020 at 3:28 PM Michal Privoznik wrote: > > > > On 11/16/20 1:26 PM, Christian Ehrhardt wrote: > > > 'kvm-spice' is a binary name used to call 'kvm' which actually is a > > > wrapper > > > around qemu-system-x86_64

Re: [libvirt PATCH 2/2] spec: Drop UUID handling for default network

2020-11-17 Thread Neal Gompa
On Tue, Nov 17, 2020 at 2:29 PM Andrea Bolognani wrote: > > On Tue, 2020-11-17 at 13:01 -0500, Neal Gompa wrote: > > On Sun, Nov 15, 2020 at 3:43 PM Andrea Bolognani > > wrote: > > > -UUID=`/usr/bin/uuidgen` > > > sed -e "s/${orig_sub}/${sub}/g" \ > > > --e "s,,\n $UUID," \ >

[PATCH] cpu_map: Support phytium processor

2020-11-17 Thread yangshaojun19
From: Shaojun Yang FT-2000+ and Tengyun-S2500 are two chips by produced Phytium Technology Co., Ltd., which based on ARMv8 architecure. Shaojun Yang (1): add phytium FT-2000+ and Tengyun-S2500 support on arm architecture. src/cpu_map/arm_Phytium.xml | 10 ++

[PATCH] add phytium FT-2000+ and Tengyun-S2500 support on arm architecture.

2020-11-17 Thread yangshaojun19
From: Shaojun Yang Signed-off-by: Shaojun Yang --- src/cpu_map/arm_Phytium.xml | 10 ++ src/cpu_map/arm_vendors.xml | 1 + src/cpu_map/index.xml | 3 +++ 3 files changed, 14 insertions(+) create mode 100644 src/cpu_map/arm_Phytium.xml diff --git a/src/cpu_map/arm_Phytium.xml

[PATCH] util: convert char pointers to use g_autofree

2020-11-17 Thread Barrett J Schonefeld
>From 82f992c7ff4ef59682f42c863fca242dd84208f9 Mon Sep 17 00:00:00 2001 From: Barrett Schonefeld Date: Mon, 9 Nov 2020 16:07:25 -0600 Subject: [PATCH] util: convert char pointers to use g_autofree additional conversions to the GLib API in src/util per issue #11. Related issue:

Re: [libvirt PATCH 05/16] docs: add manpage for virtbhyved

2020-11-17 Thread Ryan Moeller
On Tue, Nov 17, 2020 at 12:03 PM Daniel P. Berrangé wrote: > > This is an adaptation of the libvirtd manpage. > > Signed-off-by: Daniel P. Berrangé > --- > docs/manpages/index.rst | 7 ++ > docs/manpages/meson.build| 1 + > docs/manpages/virtbhyved.rst | 215

Re: [libvirt PATCH 2/2] spec: Drop UUID handling for default network

2020-11-17 Thread Andrea Bolognani
On Tue, 2020-11-17 at 13:01 -0500, Neal Gompa wrote: > On Sun, Nov 15, 2020 at 3:43 PM Andrea Bolognani wrote: > > -UUID=`/usr/bin/uuidgen` > > sed -e "s/${orig_sub}/${sub}/g" \ > > --e "s,,\n $UUID," \ > > < %{_datadir}/libvirt/networks/default.xml \ > > >

Re: [libvirt PATCH 1/2] network: Drop UUID handling for default network

2020-11-17 Thread Laine Stump
On 11/17/20 12:45 PM, Andrea Bolognani wrote: On Tue, 2020-11-17 at 10:47 -0500, Laine Stump wrote: On 11/16/20 11:43 AM, Andrea Bolognani wrote: I don't see how we could possibly not be okay with writing back the updated configuration: filling in whatever blanks are present in the

Re: [libvirt PATCH 2/2] spec: Drop UUID handling for default network

2020-11-17 Thread Neal Gompa
On Sun, Nov 15, 2020 at 3:43 PM Andrea Bolognani wrote: > > We're no longer generating a UUID during installation, so we > clearly don't need to strip it afterwards; and since the network > driver is perfectly capable of generating a UUID if necessary, we > don't need to do that at %post time

Re: [libvirt PATCH 00/16] docs: add manpages for all the modular daemons

2020-11-17 Thread Neal Gompa
On Tue, Nov 17, 2020 at 12:03 PM Daniel P. Berrangé wrote: > > Most of the modular daemon stuff has been done from a single template, > but for the man pages that is more trouble than it is worth, so we > create a separate man page source for each daemon, which makes it easy > to extend with

Re: [PATCH 0/5] Deduplicate some of validation code

2020-11-17 Thread Cole Robinson
On 11/17/20 6:28 AM, Michal Privoznik wrote: > These stemmed from Cole's comment on my patches: > > https://www.redhat.com/archives/libvir-list/2020-November/msg00888.html > > The approach might not be that obvious at first because domCaps do > qemuCaps to device model translation and during

Re: [libvirt PATCH 1/2] network: Drop UUID handling for default network

2020-11-17 Thread Andrea Bolognani
On Tue, 2020-11-17 at 10:47 -0500, Laine Stump wrote: > On 11/16/20 11:43 AM, Andrea Bolognani wrote: > > I don't see how we could possibly not be okay with writing back the > > updated configuration: filling in whatever blanks are present in the > > user-provided configuration and then writing

Re: [PATCH 3/4] qemuxml2argvtest: Increase timeout on macOS

2020-11-17 Thread Roman Bolshakov
On Tue, Nov 17, 2020 at 11:01:21AM +0100, Andrea Bolognani wrote: > On Tue, 2020-11-17 at 01:34 +0300, Roman Bolshakov wrote: > > On Fri, Nov 13, 2020 at 04:58:36PM +0100, Michal Privoznik wrote: > > > On 11/8/20 10:24 PM, Roman Bolshakov wrote: > > > > + if data['name'] == 'qemuxml2argvtest' and

[libvirt PATCH 14/16] docs: add manpage for virtvboxd

2020-11-17 Thread Daniel P . Berrangé
This is an adaptation of the libvirtd manpage. Signed-off-by: Daniel P. Berrangé --- docs/manpages/index.rst | 1 + docs/manpages/meson.build | 1 + docs/manpages/virtvboxd.rst | 213 3 files changed, 215 insertions(+) create mode 100644

[libvirt PATCH 12/16] docs: add manpage for virtsecretd

2020-11-17 Thread Daniel P . Berrangé
This is an adaptation of the libvirtd manpage. Signed-off-by: Daniel P. Berrangé --- docs/manpages/index.rst | 1 + docs/manpages/meson.build | 1 + docs/manpages/virtsecretd.rst | 214 ++ 3 files changed, 216 insertions(+) create mode 100644

[libvirt PATCH 07/16] docs: add manpage for virtlxcd

2020-11-17 Thread Daniel P . Berrangé
This is an adaptation of the libvirtd manpage. Signed-off-by: Daniel P. Berrangé --- docs/manpages/index.rst| 1 + docs/manpages/meson.build | 1 + docs/manpages/virtlxcd.rst | 215 + 3 files changed, 217 insertions(+) create mode 100644

Re: [libvirt PATCH 2/4] nodedev: dont rely on ignoring errors on missing properties

2020-11-17 Thread Daniel P . Berrangé
On Tue, Nov 17, 2020 at 11:04:07AM -0500, Laine Stump wrote: > On 11/17/20 7:56 AM, Daniel P. Berrangé wrote: > > The udevProcessStorage method relies on udevGetIntProperty ignoring > > errors about non-existant properties and instead setting the value to > > zero. In theory when seeing

[libvirt PATCH 16/16] docs: add manpage for virtxend

2020-11-17 Thread Daniel P . Berrangé
This is an adaptation of the libvirtd manpage. Signed-off-by: Daniel P. Berrangé --- docs/manpages/index.rst| 1 + docs/manpages/meson.build | 1 + docs/manpages/virtxend.rst | 215 + 3 files changed, 217 insertions(+) create mode 100644

[libvirt PATCH 01/16] docs: consistently mark libvirtd as preformatted text

2020-11-17 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- docs/manpages/libvirtd.rst | 48 +++--- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/docs/manpages/libvirtd.rst b/docs/manpages/libvirtd.rst index cd9976c5e4..2ce6284b3a 100644 ---

[libvirt PATCH 08/16] docs: add manpage for virtnetworkd

2020-11-17 Thread Daniel P . Berrangé
This is an adaptation of the libvirtd manpage. Signed-off-by: Daniel P. Berrangé --- docs/manpages/index.rst| 1 + docs/manpages/meson.build | 1 + docs/manpages/virtnetworkd.rst | 215 + 3 files changed, 217 insertions(+) create mode 100644

Re: [libvirt PATCH 2/4] nodedev: dont rely on ignoring errors on missing properties

2020-11-17 Thread Laine Stump
On 11/17/20 7:56 AM, Daniel P. Berrangé wrote: The udevProcessStorage method relies on udevGetIntProperty ignoring errors about non-existant properties and instead setting the value to zero. In theory when seeing ID_CDROM=1, you might expect that devices which are not CDs will get ID_CDROM=0,

[libvirt PATCH 13/16] docs: add manpage for virtstoraged

2020-11-17 Thread Daniel P . Berrangé
This is an adaptation of the libvirtd manpage. Signed-off-by: Daniel P. Berrangé --- docs/manpages/index.rst| 1 + docs/manpages/meson.build | 1 + docs/manpages/virtstoraged.rst | 215 + 3 files changed, 217 insertions(+) create mode 100644

[libvirt PATCH 00/16] docs: add manpages for all the modular daemons

2020-11-17 Thread Daniel P . Berrangé
Most of the modular daemon stuff has been done from a single template, but for the man pages that is more trouble than it is worth, so we create a separate man page source for each daemon, which makes it easy to extend with driver specific information. Daniel P. Berrangé (16): docs:

[libvirt PATCH 09/16] docs: add manpage for virtnodedevd

2020-11-17 Thread Daniel P . Berrangé
This is an adaptation of the libvirtd manpage. Signed-off-by: Daniel P. Berrangé --- docs/manpages/index.rst| 1 + docs/manpages/meson.build | 1 + docs/manpages/virtnodedevd.rst | 214 + 3 files changed, 216 insertions(+) create mode 100644

[libvirt PATCH 02/16] docs: don't hardcode an ancient version in manpage examples

2020-11-17 Thread Daniel P . Berrangé
Subsitute in the current version so the example always reflect today's version of reality. Signed-off-by: Daniel P. Berrangé --- docs/manpages/libvirtd.rst | 2 +- docs/manpages/meson.build | 1 + docs/manpages/virtlockd.rst | 2 +- docs/manpages/virtlogd.rst | 2 +- 4 files changed, 4

[libvirt PATCH 15/16] docs: add manpage for virtvzd

2020-11-17 Thread Daniel P . Berrangé
This is an adaptation of the libvirtd manpage. Signed-off-by: Daniel P. Berrangé --- docs/manpages/index.rst | 1 + docs/manpages/meson.build | 1 + docs/manpages/virtvzd.rst | 215 ++ 3 files changed, 217 insertions(+) create mode 100644

[libvirt PATCH 11/16] docs: add manpage for virtqemud

2020-11-17 Thread Daniel P . Berrangé
This is an adaptation of the libvirtd manpage. Signed-off-by: Daniel P. Berrangé --- docs/manpages/index.rst | 1 + docs/manpages/meson.build | 1 + docs/manpages/virtqemud.rst | 215 3 files changed, 217 insertions(+) create mode 100644

[libvirt PATCH 03/16] docs: tweak heading for daemon manual pages

2020-11-17 Thread Daniel P . Berrangé
This group will be distinct from the per-driver modular daemon mapages. Signed-off-by: Daniel P. Berrangé --- docs/manpages/index.rst | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/manpages/index.rst b/docs/manpages/index.rst index 3624ae4e8f..e116c6f415 100644

[libvirt PATCH 10/16] docs: add manpage for virtnwfilterd

2020-11-17 Thread Daniel P . Berrangé
This is an adaptation of the libvirtd manpage. Signed-off-by: Daniel P. Berrangé --- docs/manpages/index.rst | 1 + docs/manpages/meson.build | 1 + docs/manpages/virtnwfilterd.rst | 215 3 files changed, 217 insertions(+) create mode 100644

[libvirt PATCH 05/16] docs: add manpage for virtbhyved

2020-11-17 Thread Daniel P . Berrangé
This is an adaptation of the libvirtd manpage. Signed-off-by: Daniel P. Berrangé --- docs/manpages/index.rst | 7 ++ docs/manpages/meson.build| 1 + docs/manpages/virtbhyved.rst | 215 +++ 3 files changed, 223 insertions(+) create mode 100644

[libvirt PATCH 06/16] docs: add manpage for virtinterfaced

2020-11-17 Thread Daniel P . Berrangé
This is an adaptation of the libvirtd manpage. Signed-off-by: Daniel P. Berrangé --- docs/manpages/index.rst | 1 + docs/manpages/meson.build| 1 + docs/manpages/virtinterfaced.rst | 215 +++ 3 files changed, 217 insertions(+) create mode 100644

Re: [PATCH] add phytium FT-2000+ and Tengyun-S2500 support on arm architecture.

2020-11-17 Thread Andrea Bolognani
On Tue, 2020-11-17 at 17:02 +0800, yangshaoju...@163.com wrote: > From: yangshaojun > > Signed-off-by: yangshaojun Both the git authorship information and the Signed-off-by tag should contain information in the form FirstName LastName Please update them. > +++

[libvirt PATCH 04/16] docs: add manpage for virtproxyd

2020-11-17 Thread Daniel P . Berrangé
This is an adaptation of the libvirtd manpage. Signed-off-by: Daniel P. Berrangé --- docs/manpages/index.rst | 1 + docs/manpages/meson.build| 1 + docs/manpages/virtproxyd.rst | 256 +++ 3 files changed, 258 insertions(+) create mode 100644

Re: [libvirt PATCH 0/4] nodedev: cleanup some historical baggage

2020-11-17 Thread Laine Stump
On 11/17/20 7:56 AM, Daniel P. Berrangé wrote: Daniel P. Berrangé (4): nodedev: improve debugging logs from udev device/event processing nodedev: dont rely on ignoring errors on missing properties nodedev: drop DKD_MEDIA_AVAILABLE property check nodedev: report errors about missing

Re: [libvirt PATCH 1/2] network: Drop UUID handling for default network

2020-11-17 Thread Laine Stump
On 11/16/20 11:43 AM, Andrea Bolognani wrote: On Mon, 2020-11-16 at 10:00 -0500, Laine Stump wrote: On 11/16/20 5:33 AM, Andrea Bolognani wrote: On Sun, 2020-11-15 at 19:19 -0500, Laine Stump wrote: On 11/15/20 3:43 PM, Andrea Bolognani wrote: We are generating a fresh UUID and storing it in

Re: [PATCH] apparmor: allow kvm-spice compat wrapper

2020-11-17 Thread Christian Ehrhardt
On Mon, Nov 16, 2020 at 3:28 PM Michal Privoznik wrote: > > On 11/16/20 1:26 PM, Christian Ehrhardt wrote: > > 'kvm-spice' is a binary name used to call 'kvm' which actually is a wrapper > > around qemu-system-x86_64 enabling kvm acceleration. This isn't in use > > for quite a while anymore, but

Re: [PATCH 4/5] qemu: Don't cache domCaps in virQEMUDriverGetDomainCapabilities()

2020-11-17 Thread Cole Robinson
On 11/17/20 2:50 AM, Michal Privoznik wrote: > On 11/16/20 8:40 PM, Cole Robinson wrote: >> On 11/16/20 2:43 AM, Michal Privoznik wrote: >>> Currently, whenever a domain capabilities is needed (fortunately, >>> after cleanup done by previous commits it is now only in >>>

Re: [PATCH] node_device: Use "udev" monitor source

2020-11-17 Thread Daniel P . Berrangé
On Tue, Nov 17, 2020 at 02:29:27PM +0100, Michal Privoznik wrote: > On 11/17/20 1:51 PM, Daniel P. Berrangé wrote: > > On Tue, Nov 17, 2020 at 01:29:47PM +0100, Michal Privoznik wrote: > > > In v6.3.0-rc1~67 I've made a switch: instead of listening on udev > > > events the nodedev driver started

Re: [libvirt PATCH 0/2] qemu: support kvm-poll-control performance hint

2020-11-17 Thread Michal Privoznik
On 11/13/20 9:49 AM, Tim Wiederhake wrote: See the commit message of the first patch and https://bugzilla.redhat.com/show_bug.cgi?id=1895204 Tim Wiederhake (2): qemu: support kvm-poll-control performance hint tests: Add tests for kvm-poll-control feature docs/formatdomain.rst

Re: [libvirt PATCH 1/2] qemu: support kvm-poll-control performance hint

2020-11-17 Thread Michal Privoznik
On 11/13/20 9:49 AM, Tim Wiederhake wrote: QEMU version 4.2 introduced a performance feature under commit d645e13287 ("kvm: i386: halt poll control MSR support"). This patch adds a new KVM feature 'poll-control' to set this performance hint for KVM guests. The feature is off by default. To

Re: [libvirt PATCH 1/2] qemu: support kvm-poll-control performance hint

2020-11-17 Thread Michal Privoznik
On 11/17/20 2:26 PM, Tim Wiederhake wrote: On Mon, 2020-11-16 at 14:27 +0100, Michal Privoznik wrote: On 11/13/20 9:49 AM, Tim Wiederhake wrote: QEMU version 4.2 introduced a performance feature under commit d645e13287 ("kvm: i386: halt poll control MSR support"). This patch adds a new KVM

Re: [PATCH] node_device: Use "udev" monitor source

2020-11-17 Thread Michal Privoznik
On 11/17/20 1:51 PM, Daniel P. Berrangé wrote: On Tue, Nov 17, 2020 at 01:29:47PM +0100, Michal Privoznik wrote: In v6.3.0-rc1~67 I've made a switch: instead of listening on udev events the nodedev driver started listening for kernel events. This was because when a device changes its name (e.g.

Re: [libvirt PATCH 1/2] qemu: support kvm-poll-control performance hint

2020-11-17 Thread Tim Wiederhake
On Mon, 2020-11-16 at 14:27 +0100, Michal Privoznik wrote: > On 11/13/20 9:49 AM, Tim Wiederhake wrote: > > QEMU version 4.2 introduced a performance feature under commit > > d645e13287 ("kvm: i386: halt poll control MSR support"). > > > > This patch adds a new KVM feature 'poll-control' to set

[libvirt PATCH 4/4] nodedev: report errors about missing integer properties

2020-11-17 Thread Daniel P . Berrangé
The helper methods for getting integer properties ignore a missing property setting its value to zero. This lack of error reporting resulted in missing the regression handling hotplug of USB devices with the vendor and model IDs getting set to zero silently. The few callers which relied on this

[libvirt PATCH 3/4] nodedev: drop DKD_MEDIA_AVAILABLE property check

2020-11-17 Thread Daniel P . Berrangé
The access of DKD_MEDIA_AVAILABLE for floppy disks, is mistakenly protected by a check for ID_CDROM_MEDIA, introduced in: commit 10427db77983edfaafec74ec13cc5015bab6aa95 Author: Ján Tomko Date: Fri Jun 3 16:10:21 2016 +0200 Only return two values in udevGetUintProperty Thus the

[libvirt PATCH 2/4] nodedev: dont rely on ignoring errors on missing properties

2020-11-17 Thread Daniel P . Berrangé
The udevProcessStorage method relies on udevGetIntProperty ignoring errors about non-existant properties and instead setting the value to zero. In theory when seeing ID_CDROM=1, you might expect that devices which are not CDs will get ID_CDROM=0, but that's not what happens in practice. Instead

[libvirt PATCH 1/4] nodedev: improve debugging logs from udev device/event processing

2020-11-17 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- src/node_device/node_device_udev.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index 65f312d8f4..b1b1886c54 100644 ---

[libvirt PATCH 0/4] nodedev: cleanup some historical baggage

2020-11-17 Thread Daniel P . Berrangé
Daniel P. Berrangé (4): nodedev: improve debugging logs from udev device/event processing nodedev: dont rely on ignoring errors on missing properties nodedev: drop DKD_MEDIA_AVAILABLE property check nodedev: report errors about missing integer properties

Re: [PATCH] node_device: Use "udev" monitor source

2020-11-17 Thread Daniel P . Berrangé
On Tue, Nov 17, 2020 at 01:29:47PM +0100, Michal Privoznik wrote: > In v6.3.0-rc1~67 I've made a switch: instead of listening on udev > events the nodedev driver started listening for kernel events. > This was because when a device changes its name (e.g. NICs) we > will get "move" event with

Re: [Question] sg_persist failed when using qemu-pr-helper

2020-11-17 Thread Michal Privoznik
On 11/17/20 2:42 AM, Zihao Chang wrote: On 2020/11/16 23:10, Michal Privoznik wrote: On 11/16/20 3:22 PM, Zihao Chang wrote: Hi all, When using qemu-pr-helper,"sg_persist" in guest return Aborted Command after iscsiadm logout & login. My confusion: Is this problem caused by bugs of

[libvirt PATCH 0/3] Define and enable Snowridge model

2020-11-17 Thread Tim Wiederhake
This series adds a CPU model for Snowridge to libvirt. Snowridge was added to QEMU in v4.1.0. Tim Wiederhake (3): cpu_map: Add support for core-capability CPU feature cpu_map: Add support for split-lock-detect CPU feature cpu_map: Define and enable Snowridge model src/cpu_map/index.xml

[libvirt PATCH 3/3] cpu_map: Define and enable Snowridge model

2020-11-17 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/index.xml | 1 + src/cpu_map/meson.build | 1 + src/cpu_map/x86_Snowridge.xml | 71 +++ .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 +

[libvirt PATCH 2/3] cpu_map: Add support for split-lock-detect CPU feature

2020-11-17 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 4f5a9f4787..58a91bd089 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -578,4

[libvirt PATCH 1/3] cpu_map: Add support for core-capability CPU feature

2020-11-17 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index a55f52b16c..4f5a9f4787 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -354,6

[PATCH] node_device: Use "udev" monitor source

2020-11-17 Thread Michal Privoznik
In v6.3.0-rc1~67 I've made a switch: instead of listening on udev events the nodedev driver started listening for kernel events. This was because when a device changes its name (e.g. NICs) we will get "move" event with DEVPATH_OLD property set, which we can then use to remove the old device and

[PATCH libvirt v3 01/11] nodedev: detect AP card device

2020-11-17 Thread Shalini Chellathurai Saroja
Introduce support for the Adjunct Processor (AP) crypto card device. Udev already detects the device, so add support for libvirt nodedev driver. Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski ---

[PATCH libvirt v3 05/11] virsh: nodedev: Filter by AP card and AP queue capabilities

2020-11-17 Thread Shalini Chellathurai Saroja
From: Farhan Ali Add support to filter by 'ap_card' and 'ap_queue' capabilities. Signed-off-by: Farhan Ali Reviewed-by: Boris Fiuczynski Reviewed-by: Bjoern Walk Signed-off-by: Shalini Chellathurai Saroja --- docs/manpages/virsh.rst | 2 +- include/libvirt/libvirt-nodedev.h | 2

[PATCH libvirt v3 04/11] tests: AP queue node device

2020-11-17 Thread Shalini Chellathurai Saroja
Add tests to verify libvirt node device driver support for AP queues Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- tests/nodedevschemadata/ap_07_0038.xml | 9 + tests/nodedevxml2xmltest.c |

[PATCH libvirt v3 06/11] nodedev: detect AP matrix device

2020-11-17 Thread Shalini Chellathurai Saroja
Add support for AP matrix device in libvirt node device driver. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs/schemas/nodedev.rng | 7 +++ src/conf/node_device_conf.c| 9 + src/conf/node_device_conf.h

[PATCH libvirt v3 08/11] virsh: nodedev: filter by AP Matrix capability

2020-11-17 Thread Shalini Chellathurai Saroja
Add support to filter by 'ap_matrix' capability. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs/formatnode.html.in | 3 +++ docs/manpages/virsh.rst | 2 +- include/libvirt/libvirt-nodedev.h | 1 +

[PATCH libvirt v3 09/11] node_device: refactor address retrieval of node device

2020-11-17 Thread Shalini Chellathurai Saroja
Use switch statements instead of if-else condition in the method nodeDeviceFindAddressByName to retrieve address of a node device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/node_device/node_device_driver.c | 30

[PATCH libvirt v3 00/11] Support AP card, AP queues and AP matrix

2020-11-17 Thread Shalini Chellathurai Saroja
Add support for AP card devices, AP queues and AP matrix devices in libvirt node device driver. --- v3: - Modify schema definition of ap-adapter to support hex values alone. - Modify schema definition of ap-domain to support hex values alone. - Verify domain value of AP queue device to be

[PATCH libvirt v3 11/11] node_device: detecting mdev_types capability on ap_matrix device

2020-11-17 Thread Shalini Chellathurai Saroja
From: Boris Fiuczynski Add detection of mdev_types capability to Adjunct Processor Matrix device. Signed-off-by: Boris Fiuczynski Reviewed-by: Shalini Chellathurai Saroja Reviewed-by: Jonathon Jongsma Signed-off-by: Shalini Chellathurai Saroja --- docs/formatnode.html.in

[PATCH libvirt v3 03/11] nodedev: detect AP queues

2020-11-17 Thread Shalini Chellathurai Saroja
Each AP card device can support upto 256 AP queues. AP queues are also detected by udev, so add support for libvirt nodedev driver. Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs/formatnode.html.in

[PATCH libvirt v3 10/11] node_device: mdev matrix support

2020-11-17 Thread Shalini Chellathurai Saroja
Allow mdev devices to be created on the matrix device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/node_device/node_device_driver.c | 5 - src/node_device/node_device_udev.c | 4 +++- 2 files changed, 7 insertions(+), 2

[PATCH libvirt v3 02/11] tests: AP card node device

2020-11-17 Thread Shalini Chellathurai Saroja
Add tests to verify libvirt node device driver support for AP card device. Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- tests/nodedevschemadata/ap_card07.xml | 8 tests/nodedevxml2xmltest.c

[PATCH libvirt v3 07/11] tests: AP matrix node device

2020-11-17 Thread Shalini Chellathurai Saroja
Add tests to verify libvirt node device driver support for AP matrix device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- tests/nodedevschemadata/ap_matrix.xml| 7 +++

[PATCH 5/5] qemu_validate: Deduplicate code for graphics type check

2020-11-17 Thread Michal Privoznik
Similarly to previous commits, we can utilize domCaps to check if graphics type is supported. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capabilities.h | 3 +++ src/qemu/qemu_validate.c | 40 3 files changed,

[PATCH 4/5] domcaps: Report egl-headless graphics type

2020-11-17 Thread Michal Privoznik
QEMU supports egl-headless if QEMU_CAPS_EGL_HEADLESS capability is present. There are some additional requirements but those are checked for in qemuValidateDomainDeviceDefGraphics() and depend on domain configuration and thus are not representable in domain capabilities. Let's stick with plain

[PATCH 2/5] qemu_validate: Deduplicate code for video model check

2020-11-17 Thread Michal Privoznik
In my recent commit of a33279daa8 I've moved video model check from domain capabilities validator into qemu validator. During that I had to basically duplicate video model to qemuCaps checks. Problem with this approach is that after my commit qemu validator and domCaps are disconnected and thus

[PATCH 3/5] qemu_validate: Deduplicate code for RNG model check

2020-11-17 Thread Michal Privoznik
In my recent commit of 5216304bfe I've moved RNG model check from domain capabilities validator into qemu validator. During that I had to basically duplicate RNG model to qemuCaps checks. Problem with this approach is that after my commit qemu validator and domCaps are disconnected and thus

[PATCH 0/5] Deduplicate some of validation code

2020-11-17 Thread Michal Privoznik
These stemmed from Cole's comment on my patches: https://www.redhat.com/archives/libvir-list/2020-November/msg00888.html The approach might not be that obvious at first because domCaps do qemuCaps to device model translation and during validation we want the exact opposite - we have parsed

[PATCH 1/5] domain_capabilities: Introduce VIR_DOMAIN_CAPS_ENUM_IS_SET

2020-11-17 Thread Michal Privoznik
This is a convenient macro for querying whether particular domain caps enum value is set or not. Signed-off-by: Michal Privoznik --- src/conf/domain_capabilities.c | 2 +- src/conf/domain_capabilities.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 3/4] qemuxml2argvtest: Increase timeout on macOS

2020-11-17 Thread Andrea Bolognani
On Tue, 2020-11-17 at 01:34 +0300, Roman Bolshakov wrote: > On Fri, Nov 13, 2020 at 04:58:36PM +0100, Michal Privoznik wrote: > > On 11/8/20 10:24 PM, Roman Bolshakov wrote: > > > + if data['name'] == 'qemuxml2argvtest' and host_machine.system() == > > > 'darwin' > > > +timeout = 180 > > > +

Re: [libvirt PATCH v3] Do not disable incompatible-pointer-types-discards-qualifiers

2020-11-17 Thread Daniel P . Berrangé
On Mon, Nov 16, 2020 at 09:31:22PM +0100, Martin Kletzander wrote: > This reverts commit b3710e9a2af402a2b620de570b062294e11190eb. > > That check is very valuable for our code, but it causes issue with glib >= > 2.67.0 when building with clang. > > The reason is a combination of two commits in

[PATCH] add phytium FT-2000+ and Tengyun-S2500 support on arm architecture.

2020-11-17 Thread yangshaojun19
From: yangshaojun Signed-off-by: yangshaojun --- src/cpu_map/arm_Phytium.xml | 10 ++ src/cpu_map/arm_vendors.xml | 1 + src/cpu_map/index.xml | 3 +++ 3 files changed, 14 insertions(+) create mode 100644 src/cpu_map/arm_Phytium.xml diff --git a/src/cpu_map/arm_Phytium.xml